From nobody Mon Feb 9 13:38:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654853877; cv=none; d=zohomail.com; s=zohoarc; b=N4snsQo3EXY1RKqD9ivJwdu1JbruOyqW6wqYshgQs5M9cRL/6Rn022F5xme75R7Yd9A+khsN+zjdG3zh/15SVYmrW+iTTWOLAVPquRwh7br4E44E7whuBJ0eD1hkFoXYYXpamjOhQwzWg2w+ER8T709Kpsy9m3452+5vNWE+d3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654853877; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vNpi+lv9eUeu1Vt5Hknt5gq0K5cS6eTghz588WqWk28=; b=LLK2P0LShlfpBk5ZzzBrKiem6J4dHCWjYqGww1zJdHYLMi3iIlydlFiRSMSW7xvDCUEOAFLIU79uEbMqDgrGkh27yghj+PcIZspmafHGfVEfxk/Z5DCq1deM2CuCikhcsYtYwhPCYXU8uypLrq1Zblmad6u6O5psCrbz3SAd5OU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654853877620712.4535601031732; Fri, 10 Jun 2022 02:37:57 -0700 (PDT) Received: from localhost ([::1]:51748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzb5T-0002jo-KC for importer@patchew.org; Fri, 10 Jun 2022 05:37:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzZYb-0002tp-IA for qemu-devel@nongnu.org; Fri, 10 Jun 2022 03:59:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:53708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzZYY-0006Te-VE for qemu-devel@nongnu.org; Fri, 10 Jun 2022 03:59:49 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59--C4eB1a2NiemjdzdB029TA-1; Fri, 10 Jun 2022 03:59:45 -0400 Received: by mail-wm1-f71.google.com with SMTP id l4-20020a05600c1d0400b0039c60535405so3370454wms.6 for ; Fri, 10 Jun 2022 00:59:44 -0700 (PDT) Received: from redhat.com ([212.116.178.142]) by smtp.gmail.com with ESMTPSA id f6-20020a05600c4e8600b0039c6ce32a2dsm2153858wmq.33.2022.06.10.00.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 00:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654847986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vNpi+lv9eUeu1Vt5Hknt5gq0K5cS6eTghz588WqWk28=; b=Wc6MuxFY66BX4Vu3FELj/pV0940INbkQ2a3ua7qSXj8EcRvv5vxy9ckzcPLjGMwD3yDVJZ EqZiXOtW5AWzWMsv91Sk8pngpkWUYaOSDx0BkJ+/8GNit/TnYimvyAHeSKIrzJHzqlTe/R eqwQLfRUXT6hd+toRiainET9uhfl/S8= X-MC-Unique: -C4eB1a2NiemjdzdB029TA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vNpi+lv9eUeu1Vt5Hknt5gq0K5cS6eTghz588WqWk28=; b=lF28bypkTHaDtTjb4Wl8CEzX5F5/OlIBC+221m+BUF92MZ/37yyYvPd2m5sEJjx0Q1 oXTfxFKvRZDehfYb6lmVbOK+lhjZlGWm04BPJKZRFRsq6yPyp1s04PVjVCfhD8Bl1627 +gdyX3KnmrLaGNTXkyJMt8ldiCOW1wdOygaDIn+dpJUYRgZr6d0Hz3tg3K0+rRdFNL9F eV9dmGYCyHUy4SEXJUGuLl7QyL/S5Un2kPzyhLdTrxez4jSYNw4or/sPkHTGXKTngrZQ 3sLgOOtioSKjQS1PkEvwK6FkMIHyiY2kEJ1fU0eyUHi9nMzqz5J5WZb7nX8hmYYdK9k9 lwLg== X-Gm-Message-State: AOAM532WVZ8o7qNnhB48Au+uQEWedM82nuS2WhpIprxCQxm9fkr8H/bz IV5IDafxaGUb0DvMa93Os85sCGVjzfduCT+IM8vXavry1UxeKfBset+rDnmQece3xUMsUqnjUmp UE0aCm5RKSKD2MSLRZwxvs6URSEtTNXlnddq2KYzamlrV9fTWiWatg6YrOvra X-Received: by 2002:a5d:6091:0:b0:210:3e16:c600 with SMTP id w17-20020a5d6091000000b002103e16c600mr41220609wrt.456.1654847982696; Fri, 10 Jun 2022 00:59:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRKVNJvAlea7XLwfLaJrLdAZG3ZxaT9XSHywd7uUyex/CiZhk2XehQ8wVCcjpiqu4GZVGXYg== X-Received: by 2002:a5d:6091:0:b0:210:3e16:c600 with SMTP id w17-20020a5d6091000000b002103e16c600mr41220578wrt.456.1654847982395; Fri, 10 Jun 2022 00:59:42 -0700 (PDT) Date: Fri, 10 Jun 2022 03:59:39 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Changpeng Liu , Raphael Norwitz , Kevin Wolf , Hanna Reitz , Paolo Bonzini , Fam Zheng , qemu-block@nongnu.org Subject: [PULL 53/54] hw/vhost-user-scsi|blk: set `supports_config` flag correctly Message-ID: <20220610075631.367501-54-mst@redhat.com> References: <20220610075631.367501-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610075631.367501-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1654853878384100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Changpeng Liu Currently vhost-user-scsi driver doesn't allow to change the configuration space of virtio_scsi, while vhost-user-blk support that, so here we set the flag in vhost-user-blk driver and unset it in vhost-user-scsi. Signed-off-by: Changpeng Liu Message-Id: <20220525125540.50979-2-changpeng.liu@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Changpeng Liu Signed-off-by: Changpeng Liu --- hw/block/vhost-user-blk.c | 1 + hw/scsi/vhost-user-scsi.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index 5dca4eab09..9117222456 100644 --- a/hw/block/vhost-user-blk.c +++ b/hw/block/vhost-user-blk.c @@ -337,6 +337,7 @@ static int vhost_user_blk_connect(DeviceState *dev, Err= or **errp) =20 vhost_dev_set_config_notifier(&s->dev, &blk_ops); =20 + s->vhost_user.supports_config =3D true; ret =3D vhost_dev_init(&s->dev, &s->vhost_user, VHOST_BACKEND_TYPE_USE= R, 0, errp); if (ret < 0) { diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c index 9be21d07ee..1b2f7eed98 100644 --- a/hw/scsi/vhost-user-scsi.c +++ b/hw/scsi/vhost-user-scsi.c @@ -121,7 +121,6 @@ static void vhost_user_scsi_realize(DeviceState *dev, E= rror **errp) vsc->dev.backend_features =3D 0; vqs =3D vsc->dev.vqs; =20 - s->vhost_user.supports_config =3D true; ret =3D vhost_dev_init(&vsc->dev, &s->vhost_user, VHOST_BACKEND_TYPE_USER, 0, errp); if (ret < 0) { --=20 MST