From nobody Mon Feb 9 11:33:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654849939; cv=none; d=zohomail.com; s=zohoarc; b=AjTNpmHA8yLEMia5UpLt+kuk2uQ1jGgwWWLayj6JJBrx81nJspHplSza5yd22SUDn87hnPjuxJa/L5uTPDTfcQ6zV2Y9cR07I0bADOXHpjHfg4XNQH7Le2W8H1kP7zobVgLYIx5tVop+yA8p0NF4cEkXj+UWkkDWj8JCpOK3dEI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654849939; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E4XMO6SNV8cB5seqMqIW7M9vTpFNU/jgvVEGvtachsk=; b=gMEtu49QqffHsACpxDXo+67G5tVylF0hBVtX5gBFkHcLy5UDGgqQZBCJWL1+kJo6FgmLUPf+BgfSS07ZGmC0ZTJOwDXs35+l73H9WXpDAbTueCrO1tznDv4baiEVAldpLu3qRRMk/MMLIWJywEep8NPW/4bVPPIfzyZRQd7BCQE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654849939808159.56597487146405; Fri, 10 Jun 2022 01:32:19 -0700 (PDT) Received: from localhost ([::1]:41942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nza42-0003RD-OK for importer@patchew.org; Fri, 10 Jun 2022 04:32:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzZWj-0007Hn-6g for qemu-devel@nongnu.org; Fri, 10 Jun 2022 03:57:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:50950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzZWh-0006F0-Km for qemu-devel@nongnu.org; Fri, 10 Jun 2022 03:57:52 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-363-Lon3WsnPNxiQCq298IPXOQ-1; Fri, 10 Jun 2022 03:57:49 -0400 Received: by mail-wm1-f71.google.com with SMTP id z13-20020a7bc7cd000000b0039c4a238eadso4998540wmk.9 for ; Fri, 10 Jun 2022 00:57:49 -0700 (PDT) Received: from redhat.com ([212.116.178.142]) by smtp.gmail.com with ESMTPSA id l21-20020a1ced15000000b003942a244ed1sm1973338wmh.22.2022.06.10.00.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 00:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654847871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E4XMO6SNV8cB5seqMqIW7M9vTpFNU/jgvVEGvtachsk=; b=LOCk/SiX6v80QTFMzru6Iag6NQuZPzdOKl2BjkyjzbG5BrYEVFX1A16jI3uI/hk0ktaIkf ixPR8pYAKlveS6LMbJMvdPbhfyBhwY9EINF47CxYIf2Zpr5fF0NB2XtmR3L0S5+/l8BExr iQizriXGYffyNG+7rzc73cRbhBn2Oak= X-MC-Unique: Lon3WsnPNxiQCq298IPXOQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E4XMO6SNV8cB5seqMqIW7M9vTpFNU/jgvVEGvtachsk=; b=AgB460XiGg8BrvwSIIHdLg4DOG5w+DhqDX6/0fY+ztGZWY4mIRUMKKHHreODJKHvsi MZQg1KYi3gbTtsEENP5rk4SokCWegANQFabUq9dpzC3o5Zaq7nsA2JnoClgM0ObHpht8 4+cRNFXiSD9EMhuzSKZ0+gMFKbI7OgshwpvL3Z+QxjTR/xudJ3Gao0hcdLrjdo+aC4Wc 1XHkVLhat3lHVxw54LUVawwtQCmUmEUmAYDpsRWNggv39W+cFNzS2WLiOjCgj5R9TCrp +tpXW+XnNJNQNzagwFP6Z5y0zTD4TEcWLmEcRcfwVpvZ+OQrL1LhmQ7B2Zc81ow2VsTe W9gA== X-Gm-Message-State: AOAM532iBF6WoWD5MdSS0De/H/cPe4iGMqivsK5Wrp1UJ419tRgPI8Sy DU5d7TJ67RRXUcA2VY3Qkr+fVDv+hyEZ1hN8swdKswbyrdgXv/zvpNOQo0P0b7tMYMMSnFzwhmY rrpUsH0mOzuhlQ/H/869vlL/YE/QaEzcTjbEJZoKAgm2jiJXWrxBM2dGSsTG/ X-Received: by 2002:a05:600c:590:b0:39c:5cd4:8623 with SMTP id o16-20020a05600c059000b0039c5cd48623mr7370315wmd.45.1654847868459; Fri, 10 Jun 2022 00:57:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ7+3FVmCkwWGPf5jxZObIKindZm7wQsebSguW7vfDX3pQkBHmLDiFGG9ukd4kw529Ckc10g== X-Received: by 2002:a05:600c:590:b0:39c:5cd4:8623 with SMTP id o16-20020a05600c059000b0039c5cd48623mr7370292wmd.45.1654847868196; Fri, 10 Jun 2022 00:57:48 -0700 (PDT) Date: Fri, 10 Jun 2022 03:57:45 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Igor Mammedov , Gerd Hoffmann , Marcel Apfelbaum Subject: [PULL 15/54] acpi: ich9-smb: add support for AcpiDevAmlIf interface Message-ID: <20220610075631.367501-16-mst@redhat.com> References: <20220610075631.367501-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610075631.367501-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1654849941094100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Igor Mammedov wire AcpiDevAmlIf interface to build ich9-smb and its slave devices AML. It will be used by followup patches to switch from creating AML in ad-hoc way to a more systematic one that will scan present devices and ask them to provide their AML code like it's done with ISA devices. This patch is a partial conversion, as it only fetches AML from slave devices attached to its I2C bus. The conversion will be completed when PCI bus is switched to use AcpiDevAmlIf and build_smb0() could be dropped. Signed-off-by: Igor Mammedov Acked-by: Gerd Hoffmann Message-Id: <20220608135340.3304695-16-imammedo@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i2c/smbus_ich9.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index 44dd5653b7..ee50ba1f2c 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -29,6 +29,7 @@ =20 #include "hw/i386/ich9.h" #include "qom/object.h" +#include "hw/acpi/acpi_aml_interface.h" =20 OBJECT_DECLARE_SIMPLE_TYPE(ICH9SMBState, ICH9_SMB_DEVICE) =20 @@ -94,10 +95,22 @@ static void ich9_smbus_realize(PCIDevice *d, Error **er= rp) &s->smb.io); } =20 +static void build_ich9_smb_aml(AcpiDevAmlIf *adev, Aml *scope) +{ + BusChild *kid; + ICH9SMBState *s =3D ICH9_SMB_DEVICE(adev); + BusState *bus =3D BUS(s->smb.smbus); + + QTAILQ_FOREACH(kid, &bus->children, sibling) { + call_dev_aml_func(DEVICE(kid->child), scope); + } +} + static void ich9_smb_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); + AcpiDevAmlIfClass *adevc =3D ACPI_DEV_AML_IF_CLASS(klass); =20 k->vendor_id =3D PCI_VENDOR_ID_INTEL; k->device_id =3D PCI_DEVICE_ID_INTEL_ICH9_6; @@ -112,6 +125,7 @@ static void ich9_smb_class_init(ObjectClass *klass, voi= d *data) * pc_q35_init() */ dc->user_creatable =3D false; + adevc->build_dev_aml =3D build_ich9_smb_aml; } =20 static void ich9_smb_set_irq(PMSMBus *pmsmb, bool enabled) @@ -143,6 +157,7 @@ static const TypeInfo ich9_smb_info =3D { .class_init =3D ich9_smb_class_init, .interfaces =3D (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, + { TYPE_ACPI_DEV_AML_IF }, { }, }, }; --=20 MST