From nobody Tue Feb 10 00:31:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1654790572; cv=none; d=zohomail.com; s=zohoarc; b=QubQJhHU1Hh+X3x0gdfDbI/1wnpACNJMQxFJgFVWoOdb8MF+y2dEBI6rOCgie0BL64CNpDUACFEF3ldYJsUTfpZhIivGDbQ9JbPeS78Jmb+/rRMIQjx+uFVEkAYJfEAPOCcGhGH9TsvLBwKRUkA6dx7YGZtTkm0C/FYkiZL7bgs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654790572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fHUR3mBsZkn4Z5H5KmLKNpVXQmMut9sF7EYLdAcPnMs=; b=nSUah00IWhMReUjGMYSpmA21tUo1UgTqzXap8Quhj9mdTxJyV5mZ8/Z3CWo1M9ppWEWhVlOmCXTul8NTuB8rZJknFbSG3WBxn2FHXyz6Ow7ays7EXfdrkJwHXl6lLuQfvT9F0+XRFSgjBwyxoALxNs7u/EozYVzst/Zem8nGtSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16547905727171018.5706606508853; Thu, 9 Jun 2022 09:02:52 -0700 (PDT) Received: from localhost ([::1]:53184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzKcV-00021Q-HF for importer@patchew.org; Thu, 09 Jun 2022 12:02:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzK3r-0006la-DG for qemu-devel@nongnu.org; Thu, 09 Jun 2022 11:27:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:23427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzK3p-0000eE-GQ for qemu-devel@nongnu.org; Thu, 09 Jun 2022 11:27:02 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-zhxfPvhOO1yQ8wLdgcYkKA-1; Thu, 09 Jun 2022 11:26:53 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D7602804194 for ; Thu, 9 Jun 2022 15:26:52 +0000 (UTC) Received: from localhost (unknown [10.39.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3B7D1415102; Thu, 9 Jun 2022 15:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654788420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fHUR3mBsZkn4Z5H5KmLKNpVXQmMut9sF7EYLdAcPnMs=; b=X34kEjUa4GH8C1kPTARgSUkoeJyNtDZf1yZ4SkSwR5+uKq4lqCbjwiDdhNJ17PB0VsbdrL AuusjLTZAqNsBAxXAfFLFO+acgHnXBB68pIggU0w2vKERpaDrJoSC319eWQfB6RL3RXBN3 JUNH3KE0cSt8CCMLltmjOUzAi3OEydE= X-MC-Unique: zhxfPvhOO1yQ8wLdgcYkKA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: crobinso@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PATCH] dbus-display: fix test race when initializing p2p connection Date: Thu, 9 Jun 2022 19:26:47 +0400 Message-Id: <20220609152647.870373-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1654790573580100001 From: Marc-Andr=C3=A9 Lureau The D-Bus connection starts processing messages before QEMU has the time to set the object manager server. This is causing dbus-display-test to fail randomly with: ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm: assertion failed (qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) =3D=3D "dbus-test"): (NULL =3D=3D "dbus-test") ERROR Use the delayed message processing flag and method to avoid that situation. (the bus connection doesn't need a fix, as the initialization is done synchronously) Reported-by: Robinson, Cole Signed-off-by: Marc-Andr=C3=A9 Lureau Tested-by: Cole Robinson --- ui/dbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/dbus.c b/ui/dbus.c index 7a87612379e8..70dd4be210e4 100644 --- a/ui/dbus.c +++ b/ui/dbus.c @@ -268,6 +268,7 @@ dbus_display_add_client_ready(GObject *source_object, } =20 g_dbus_object_manager_server_set_connection(dbus_display->server, conn= ); + g_dbus_connection_start_message_processing(conn); } =20 =20 @@ -300,7 +301,8 @@ dbus_display_add_client(int csock, Error **errp) =20 g_dbus_connection_new(G_IO_STREAM(conn), guid, - G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER, + G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER| + G_DBUS_CONNECTION_FLAGS_DELAY_MESSAGE_PROCESSING, NULL, dbus_display->add_client_cancellable, dbus_display_add_client_ready, --=20 2.36.0.44.g0f828332d5ac