From nobody Tue Feb 10 23:54:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1654666458; cv=none; d=zohomail.com; s=zohoarc; b=kCr+8cmD9EX/hzntxAYV0HjuPyUbuw4NvEUk2wNxkdgx0jZtHF2YM2SJ5NmBTbKYAVyindzKf/3SHwbxjWaMmVngMTFDjDFaeRNVhkDSXecLRy0X4EfDl+HV1rdZ2OllzP8TfvU1JKpBWV7kvJYV1l5A+sG9PibGHdpicQzbyTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654666458; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vchvWnQo4YVofH3IH1WWni/usGrLZ5KUM5YMsZGZNkI=; b=KjYtGE1rPIGFkU2hxV6f9wMK5SJQnmUQ4u+B3vVDmMIbIgoUxSn5A5CEw+Vif3AaEbDuV4UqngnkU3JQGalfKhq6/hQ/DjYkKaatTbwHjWVIslEeHOTGJDnvU1xoZWieKWPiXFl+dC1TWV246EbvoEeRcMo/bszIWskh3AP5BVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654666458441923.97199805079; Tue, 7 Jun 2022 22:34:18 -0700 (PDT) Received: from localhost ([::1]:56990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyoKe-0006pr-Po for importer@patchew.org; Wed, 08 Jun 2022 01:34:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyo6m-0006u7-F3 for qemu-devel@nongnu.org; Wed, 08 Jun 2022 01:19:57 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:51941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyo6k-00022n-2R for qemu-devel@nongnu.org; Wed, 08 Jun 2022 01:19:56 -0400 Received: by mail-pj1-x102d.google.com with SMTP id cx11so17604822pjb.1 for ; Tue, 07 Jun 2022 22:19:52 -0700 (PDT) Received: from stoup.. ([2602:ae:1547:e101:c626:2f70:ac99:7c97]) by smtp.gmail.com with ESMTPSA id k8-20020a170902d58800b001641244d051sm13378807plh.257.2022.06.07.22.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vchvWnQo4YVofH3IH1WWni/usGrLZ5KUM5YMsZGZNkI=; b=HO93Od8Vu9r1/7Kh/vDT8rMHYrZUCwZlEUwD7ybT0KMJJGpaehkDXxlBKXRotfBuvL rlsT3h/MR8tJHQ2EuMz9yZw3pCN7gDJDhAzboNaIilqpj+6WVhuXVtc/+B1BqPcu5jD2 i/sdaq04RFONOuKrsgoE+Go4Qn4VyfXOvkLgNO6nXrMcuNG+AR5uK3XC8cs0UoT3XgMz x8O4vba/txcRUZ1ap17I9dohaiXDS2l9/2z/EVk9of8onkkNfSSgUY5PLeF0F+N32rou AgfYb2+BATJy7gg/YrfJlBmS1ympWgSwNSm9nQloQU8xKqVgiVdFalG6d4SdIGoIuhX5 H28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vchvWnQo4YVofH3IH1WWni/usGrLZ5KUM5YMsZGZNkI=; b=o9zuqMWtHk52MeVvkt2kqFIvRmE0DZejINyYMWMXhMRg7wGWM9+duKD8ulKrxkI+Wo aQVATO8iiS8/hAflGaV0veYJVKvioIe93pxDnIxjKB7PC1x/gzlZAsKPWWc8xI7lyv5b 18px1Gi4hZ2Fw9a4bYiELQL06ZPVfwXGuCyVG9ofLeDyLF68x+AT8UN7QHcWIc+G3H+c HguPgQUK/jyQjr82q6vo98TTPo60slzUBU5CmQQvrVM0nH8m+WCLZQfAV+4WppazCNhP /JNiNX53fEWdWB7N3Fx9H4M/KnSaTZx9FVZIoGm66yrSB5hT9Met54Vm398J/+qmNYGP Agsw== X-Gm-Message-State: AOAM530/Tp11v63jYqK/KJmo+SAJInt9f4GX76saDCv7mjj39yKa8g2j twtzFWw8osC8as3lw1F2XNLMJaTUBnjc1g== X-Google-Smtp-Source: ABdhPJzQi3nSng+qOGH+9GvOxIVMIpl9+jcGP786BjSMmR2fAjhDNehq+0zd14UA306TqArTYlRJOA== X-Received: by 2002:a17:90b:4b90:b0:1e8:48bd:453 with SMTP id lr16-20020a17090b4b9000b001e848bd0453mr24626763pjb.86.1654665591427; Tue, 07 Jun 2022 22:19:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: f4bug@amsat.org Subject: [PATCH v4 05/11] target/mips: Drop pread and pwrite syscalls from semihosting Date: Tue, 7 Jun 2022 22:19:39 -0700 Message-Id: <20220608051945.802339-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220608051945.802339-1-richard.henderson@linaro.org> References: <20220608051945.802339-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1654666459924100001 Content-Type: text/plain; charset="utf-8" We don't implement it with _WIN32 hosts, and the syscalls are missing from the gdb remote file i/o interface. Since we can't implement them universally, drop them. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/sysemu/mips-semi.c | 39 ++++++------------------------ 1 file changed, 7 insertions(+), 32 deletions(-) diff --git a/target/mips/tcg/sysemu/mips-semi.c b/target/mips/tcg/sysemu/mi= ps-semi.c index 254c7fad9a..93c9d3d0b3 100644 --- a/target/mips/tcg/sysemu/mips-semi.c +++ b/target/mips/tcg/sysemu/mips-semi.c @@ -188,8 +188,8 @@ static int get_open_flags(target_ulong target_flags) return open_flags; } =20 -static int write_to_file(CPUMIPSState *env, target_ulong fd, target_ulong = vaddr, - target_ulong len, target_ulong offset) +static int write_to_file(CPUMIPSState *env, target_ulong fd, + target_ulong vaddr, target_ulong len) { int num_of_bytes; void *dst =3D lock_user(VERIFY_READ, vaddr, len, 1); @@ -197,23 +197,14 @@ static int write_to_file(CPUMIPSState *env, target_ul= ong fd, target_ulong vaddr, report_fault(env); } =20 - if (offset) { -#ifdef _WIN32 - num_of_bytes =3D 0; -#else - num_of_bytes =3D pwrite(fd, dst, len, offset); -#endif - } else { - num_of_bytes =3D write(fd, dst, len); - } + num_of_bytes =3D write(fd, dst, len); =20 unlock_user(dst, vaddr, 0); return num_of_bytes; } =20 static int read_from_file(CPUMIPSState *env, target_ulong fd, - target_ulong vaddr, target_ulong len, - target_ulong offset) + target_ulong vaddr, target_ulong len) { int num_of_bytes; void *dst =3D lock_user(VERIFY_WRITE, vaddr, len, 0); @@ -221,15 +212,7 @@ static int read_from_file(CPUMIPSState *env, target_ul= ong fd, report_fault(env); } =20 - if (offset) { -#ifdef _WIN32 - num_of_bytes =3D 0; -#else - num_of_bytes =3D pread(fd, dst, len, offset); -#endif - } else { - num_of_bytes =3D read(fd, dst, len); - } + num_of_bytes =3D read(fd, dst, len); =20 unlock_user(dst, vaddr, len); return num_of_bytes; @@ -309,11 +292,11 @@ void mips_semihosting(CPUMIPSState *env) gpr[3] =3D errno_mips(errno); break; case UHI_read: - gpr[2] =3D read_from_file(env, gpr[4], gpr[5], gpr[6], 0); + gpr[2] =3D read_from_file(env, gpr[4], gpr[5], gpr[6]); gpr[3] =3D errno_mips(errno); break; case UHI_write: - gpr[2] =3D write_to_file(env, gpr[4], gpr[5], gpr[6], 0); + gpr[2] =3D write_to_file(env, gpr[4], gpr[5], gpr[6]); gpr[3] =3D errno_mips(errno); break; case UHI_lseek: @@ -379,14 +362,6 @@ void mips_semihosting(CPUMIPSState *env) FREE_TARGET_STRING(p, gpr[4]); abort(); break; - case UHI_pread: - gpr[2] =3D read_from_file(env, gpr[4], gpr[5], gpr[6], gpr[7]); - gpr[3] =3D errno_mips(errno); - break; - case UHI_pwrite: - gpr[2] =3D write_to_file(env, gpr[4], gpr[5], gpr[6], gpr[7]); - gpr[3] =3D errno_mips(errno); - break; default: error_report("Unknown UHI operation %d", op); abort(); --=20 2.34.1