From nobody Tue Feb 10 18:54:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1654501682; cv=none; d=zohomail.com; s=zohoarc; b=g6wjawQA9+7Pk4Wuzy9qew3gvLLtnT1uR+D2v+DSrzWvMk48y4IFYZYzYK3CyOu3Ga/iEdVX+ZV9mH+JViq1Cj98PpN1N7mxTeIbyjcUg0p3J4f5Fs87BIM56fvXCwu5Oo3Aydxgu0p+g9cPyIN10aQpS9q/sULQuFTjzP82Xuo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654501682; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eLWMfMpL4ZcPp/OcEBqe7eqlTLC8tWbOtZ4hTrOYDng=; b=OR8UB59eNcUijlErVIAk65IYA/MkEpOsRgGDYqpMchfNH6RmzMU9F8p1XAyz8t23a/ZpYzB6YVUPk+QjMh13GA7d518oxCeki1tWMnk7KBGNAUqilo8dCDmc2PL+gQq7W6Sax2SiLkmKi0Q34UgJ+GrmUlFzkMNRtoPapBA6uCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654501682229907.4313291352397; Mon, 6 Jun 2022 00:48:02 -0700 (PDT) Received: from localhost ([::1]:54712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ny7Sz-0003k4-71 for importer@patchew.org; Mon, 06 Jun 2022 03:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny79h-0005LI-Kf; Mon, 06 Jun 2022 03:28:05 -0400 Received: from forwardcorp1o.mail.yandex.net ([2a02:6b8:0:1a2d::193]:43242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny79f-0002YH-R0; Mon, 06 Jun 2022 03:28:05 -0400 Received: from sas1-3cba3404b018.qloud-c.yandex.net (sas1-3cba3404b018.qloud-c.yandex.net [IPv6:2a02:6b8:c08:bd26:0:640:3cba:3404]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id B01792E0929; Mon, 6 Jun 2022 10:27:52 +0300 (MSK) Received: from sas1-7470331623bb.qloud-c.yandex.net (sas1-7470331623bb.qloud-c.yandex.net [2a02:6b8:c08:bd1e:0:640:7470:3316]) by sas1-3cba3404b018.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id 2NoPqQAVXo-RqK0p68w; Mon, 06 Jun 2022 10:27:52 +0300 Received: from vsementsov-win.yandex-team.ru (unknown [2a02:6b8:b081:b6b6::1:2c]) by sas1-7470331623bb.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id Y8SDrjDjAj-RpM45sso; Mon, 06 Jun 2022 10:27:51 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1654500472; bh=eLWMfMpL4ZcPp/OcEBqe7eqlTLC8tWbOtZ4hTrOYDng=; h=Message-Id:References:Date:Subject:In-Reply-To:Cc:To:From; b=kttPwdTn4+JBJm8Hojjzp10ygG/8JgkP2gog9nssfhAgDl7LoqZ7TLNGcysv3puUd rdGIlGBo0ZAiyVSrjvv9EyT+CCVHKw/KOWDVxb/DMCwUZei0GKviDDpigPYPLgLTFh pjGihQNMIRgPFYQrihow2wIj78rsWfooZoq/LR3w= Authentication-Results: sas1-3cba3404b018.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, eblake@redhat.com, jsnow@redhat.com, Cleber Rosa , Beraldo Leal Subject: [PATCH v2 03/11] python/machine.py: upgrade vm.cmd() method Date: Mon, 6 Jun 2022 10:27:23 +0300 Message-Id: <20220606072731.878226-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220606072731.878226-1-vsementsov@yandex-team.ru> References: <20220606072731.878226-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:0:1a2d::193; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1o.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1654501683972100001 Content-Type: text/plain; charset="utf-8" The method is not popular in iotests, we prefer use vm.qmp() and then check success by hand.. But that's not optimal. To simplify movement to vm.cmd() let's support same interface improvements like in vm.qmp(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/machine/machine.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 65703176e5..10d3304dcf 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -649,13 +649,23 @@ def qmp(self, cmd: str, return ret =20 def cmd(self, cmd: str, - conv_keys: bool =3D True, + args_dict: Optional[Dict[str, object]] =3D None, + conv_keys: Optional[bool] =3D None, **args: Any) -> QMPReturnValue: """ Invoke a QMP command. On success return the response dict. On failure raise an exception. """ + if args_dict is not None: + assert not args + assert conv_keys is None + args =3D args_dict + conv_keys =3D False + + if conv_keys is None: + conv_keys =3D True + qmp_args =3D self._qmp_args(conv_keys, args) ret =3D self._qmp.cmd(cmd, **qmp_args) if cmd =3D=3D 'quit': --=20 2.25.1