From nobody Tue Feb 10 10:19:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654172568744446.0773389718962; Thu, 2 Jun 2022 05:22:48 -0700 (PDT) Received: from localhost ([::1]:58910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwjqg-00056D-Gr for importer@patchew.org; Thu, 02 Jun 2022 08:22:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTe-00012y-Jb for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:58 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:39111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjTd-0001HA-2E for qemu-devel@nongnu.org; Thu, 02 Jun 2022 07:58:58 -0400 Received: from quad ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MDykM-1o6apP0V6q-009vQS; Thu, 02 Jun 2022 13:58:47 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 17/19] linux-user/strace: Use is_error in print_syscall_err Date: Thu, 2 Jun 2022 13:58:35 +0200 Message-Id: <20220602115837.2013918-18-laurent@vivier.eu> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220602115837.2013918-1-laurent@vivier.eu> References: <20220602115837.2013918-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XWErTcrZ6W5JxPdOk3q0B2fTn1s115yHePcBVlGBw46nDI3KZJw JQIQy/SIJwh3UqaapA8CPrCDw9Yrp9XcUsWIoePE6cjqwZ6T6uzA6FCjpCu8aJYp7AykLbJ VlXfd4NgmXg6OCRpaFfPklD77p8u2DEIbaIk9qrCpo1j5/n8AWufHGVJvjYarDunAk+nsyE TGIAE8hhatX8npu+GgCIw== X-UI-Out-Filterresults: notjunk:1;V03:K0:EM9Dr8HJ7BY=:/TYFpVVxoDDSBa3VMK7+HH gTASeUxFvDLe+YvyXJKWdqjFzUjJBOyiAEf1nS4RQ+/ahem/PYYZuX+APOnjf3fQC9O4U3Qmq 9j9SHmRwFzICUmuLbdmevg7UMF6RTkdASUzvGCfKS98LQO/inOPl4zQSLJ/1VmyblLIspvdNI nxahldfng0CNVgYkX81C0w7bpul71PNhgMwBLzGSvl1UZ0M2AIzthX92l9GIDhA2/0NKL/oXe P3VDfYfQpvV7qQsmc71Z3fy486yo2NxSccVN5zVgBeaRM1S1Z+wOsVXTNuzBekb+nMnXDNJT7 IV6tPBq2Z61xJH8AX6zIkGs+ZRo8tI3LdeCmc2HAZNgUvVrdvRHrdtyszSKPW4+WBQKAsEvjk 2ESVoYZcR2VviA72HiIngGHOUnyo/meOZM+ezySvuwhfWbNG39NaT6VtZ1nuvMIbVuOZvDBxb dwRjBaaju0/Kmz+YW5OZwXdcUZUGr4qdRtAOk4HY+dgJXsQlPgtUfbCnfi4OZ8xr1g6gX/ieC s5VnkljkFrVeealawdUcN0aQKXk8dYR6VyCvD/V+xMln7MezKsfrQzegnKE67k/Osx4qFbF/5 RSPkI8sTlf4kd3TkuGd2NiC5lUaWoG0Iy/EPgeARF9fFi6Q79ErYgcKP5xHxlWOFxbBaDlb0g Ph4ovwF4XZnOE3miC6iOvqj3VYvqYFfV75S0FYZ4D2/pfLfkJdI+Asy/BZV2Yfn8HEUuaIh0H MHPcczzkHgEvVWMOsGrC08XRhMWpzOhqeTdaiw== Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1654172569966100001 From: Richard Henderson Errors are not all negative numbers: use is_error. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Message-Id: <20220602013401.303699-16-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 9fa681dea9bb..7d882526da03 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -689,7 +689,7 @@ print_syscall_err(abi_long ret) const char *errstr; =20 qemu_log(" =3D "); - if (ret < 0) { + if (is_error(ret)) { errstr =3D target_strerror(-ret); if (errstr) { qemu_log("-1 errno=3D%d (%s)", (int)-ret, errstr); --=20 2.36.1