From nobody Sun Feb 8 18:29:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1654033929; cv=none; d=zohomail.com; s=zohoarc; b=QnD9v086OyuZeoRVqme8ZIb7jycsRDXTK5H6+YMb7Z2StqnSeuxv1bxahBmmMfD3x0/AVR3mQ3uDO7w3nBz6kOg+2oYudMHNlCkqmPYLFEpsyszHh+3Z7BvE8vFag1a49jpyIEeTEvRUYhJ4XecLpA5BAHWfQjejCES2WU86A5E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654033929; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1XLQXA2zIOXa8yl+dwEEXPr3as/VYtJrfGwXifLwIjM=; b=mnqK1G0QZRjStln0xFEFHoR8CxwqpBoRR+0aCB97WGYiffjDzaT8kwSf1n6J59pTR55+3RTAe7fta5c8BlmFMXDIiz3moEq0pIbnC+KzWOwwSfUfbGdfPGNnbVkGGNyek6wNHmfb2kKQkT9Fe9PSvj1pRrRtVFyDcUllNAc5tF0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1654033929467901.5925722420425; Tue, 31 May 2022 14:52:09 -0700 (PDT) Received: from localhost ([::1]:58566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nw9ma-0003Tj-DZ for importer@patchew.org; Tue, 31 May 2022 17:52:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nw9k3-0000Ea-5p; Tue, 31 May 2022 17:49:31 -0400 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]:33963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nw9k1-0003Kf-GV; Tue, 31 May 2022 17:49:30 -0400 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-f314077115so232078fac.1; Tue, 31 May 2022 14:49:28 -0700 (PDT) Received: from balboa.COMFAST ([152.250.93.219]) by smtp.gmail.com with ESMTPSA id pd19-20020a0568701f1300b000f333ac991fsm3476988oab.27.2022.05.31.14.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 14:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1XLQXA2zIOXa8yl+dwEEXPr3as/VYtJrfGwXifLwIjM=; b=OrxyjbLJVnhS6BWG2fF8oEJ1xsQRstxk67hmyJe63G1qTjLDOHLI6E5VbEliLjBXaR mxfDDQqWCQzaUm0IV22OlMQEswBBIf46bR2jFh10WoAsUuTPDb+nUVG/GA6Ja0KHNvU5 IeWURvmz9JBOZ+L0s3OoSB7SrD69qzFOFrEQ51O/toeau2hqP6N3SHRh1w7tQUWscYIM 1fBw4sd5POWwjzBDDsfFf5QAuRoT3+omXAGq/J089THXhgiqKsxGL7NS8Hmeh6HJ7NDs Upl8n/VFjUTWhdfkQJ4I3HikHsP5x4+o9brAqeLaYgRulIAUBQ8el0vKNHD2TaRYF75Y KazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1XLQXA2zIOXa8yl+dwEEXPr3as/VYtJrfGwXifLwIjM=; b=MfZ1o/nGZsl4Gu97UKlLFa7vgCFTYQLD2FJ0+ESLg5fyMGpGi1JnloMlDa0evmb/ix dnE9cCEWJVbDMKNV2l13U4CceZNcrR50dvz4QErWk1Fa52jHQbNM9rl536lE9A9QXGSv LMjm4YD9UEE7AG2DQJXCKYXVpOFCVMlvaGUnnKa/nwbxAko3L2b9JF4AXz8pzTPWUC4d BP6gsh+Ceg+BQoXxap6iCfHtJ9fPz0hD4f/KtFD9+QeP92mv/OfburFYTZwKoQMKjeoi AkGAKdcWIDNDamlehPAUJ6Roy3i3YcvX5/WA2R0FFpd8RwbdvYeqBULF1iP0lagOseeQ mPjA== X-Gm-Message-State: AOAM532xC7iOvGRFf7u7oSYjefpA15dUcUcOFijzq0x860Ov71HxuKCT q3T51WP6r2GEbmo8janTtR4Y3dfN2d0v8Q== X-Google-Smtp-Source: ABdhPJzROxIgbc2tK/iKSHv8JzSlm4sNTzDy4k+RJq2BIdsnAV/B0j/Wm9qxBHnxslGHk3B8P6iKFA== X-Received: by 2002:a05:6870:340b:b0:ee:37af:2722 with SMTP id g11-20020a056870340b00b000ee37af2722mr14447387oah.91.1654033767682; Tue, 31 May 2022 14:49:27 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, clg@kaod.org, mark.cave-ayland@ilande.co.uk, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 02/16] ppc/pnv: add pnv_get_phb3_child() Date: Tue, 31 May 2022 18:49:03 -0300 Message-Id: <20220531214917.31668-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220531214917.31668-1-danielhb413@gmail.com> References: <20220531214917.31668-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::29; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x29.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1654033930375100001 Content-Type: text/plain; charset="utf-8" The ics and pic related functions in pnv.c relies in the fact that the child device of the chip is always a PnvPHB3 object. This will change in the next patches, and the PHB3 will be a child of another device that will be attached to the pnv8 chip. To ease the amount of changes done later, on let's create a helper that retrieves the PnvPHB3 pointer from the child object in these functions. After that we'll have a single place to change when the chip starts using the upcoming device instead. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pnv.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 7c08a78d6c..aaf4d241c3 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -652,10 +652,15 @@ static ISABus *pnv_isa_create(PnvChip *chip, Error **= errp) return PNV_CHIP_GET_CLASS(chip)->isa_create(chip, errp); } =20 +static PnvPHB3 *pnv_get_phb3_child(Object *child) +{ + return (PnvPHB3 *)object_dynamic_cast(child, TYPE_PNV_PHB3); +} + static int pnv_chip_power8_pic_print_info_child(Object *child, void *opaqu= e) { Monitor *mon =3D opaque; - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); + PnvPHB3 *phb3 =3D pnv_get_phb3_child(child); =20 if (phb3) { pnv_phb3_msi_pic_print_info(&phb3->msis, mon); @@ -1942,7 +1947,7 @@ typedef struct ForeachPhb3Args { static int pnv_ics_get_child(Object *child, void *opaque) { ForeachPhb3Args *args =3D opaque; - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); + PnvPHB3 *phb3 =3D pnv_get_phb3_child(child); =20 if (phb3) { if (ics_valid_irq(&phb3->lsis, args->irq)) { @@ -1992,7 +1997,7 @@ PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t = chip_id) =20 static int pnv_ics_resend_child(Object *child, void *opaque) { - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); + PnvPHB3 *phb3 =3D pnv_get_phb3_child(child); =20 if (phb3) { ics_resend(&phb3->lsis); --=20 2.36.1