From nobody Thu Dec 18 22:24:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1653934332; cv=none; d=zohomail.com; s=zohoarc; b=BKQwYz8plXn0MHabL7splR/J+huJcTig4S7yjibZO0ad+X4uh3bQdmCqhV+FFeMieK8uMPXK8yMzNNzAG+U7Xzgij2Qeqzp70OoJ0ZFOGLUfZn1oNcdoCwmlFfcKmxwhdbA+kP/CF3SARTpKz9CujsCW5NQNpJNAjaQccQgb2pA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653934332; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y6320XCgMwJY1zG7cLEXVifisYCoFNkKfucLWd4W1X4=; b=c/D1mXiGKchcbt5PMeq6/b5Pt4WuTFaoGJsuSMjgk8jvspT9OTOWH9g7YZ5PyTKB100aSsC4yoLFEZglOhE/9p+ND26B1mNkSf+rTmDGS1ReQGxs8Njv0p/7TIzbaNC9ncouWcgGqAhi0L69uW7YUmg4gsMRN665WiItWoOfBtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1653934332585896.3401893935887; Mon, 30 May 2022 11:12:12 -0700 (PDT) Received: from localhost ([::1]:57212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvjsB-0007Rv-HQ for importer@patchew.org; Mon, 30 May 2022 14:12:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvhwe-0004AE-Nu for qemu-devel@nongnu.org; Mon, 30 May 2022 12:08:40 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:36780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvhwb-0007MM-TW for qemu-devel@nongnu.org; Mon, 30 May 2022 12:08:40 -0400 Received: by mail-wr1-x42d.google.com with SMTP id u3so15272110wrg.3 for ; Mon, 30 May 2022 09:08:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi12-20020a05600c3d8c00b003974b95d897sm10232152wmb.37.2022.05.30.09.08.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 09:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=y6320XCgMwJY1zG7cLEXVifisYCoFNkKfucLWd4W1X4=; b=VhBexR0V7LBIHP3xP7EZixnRRZwfVxpXnTf8E9xrBkOPT6PWPSxcA+Ldw6L7eoOGeL 3LqtW2KCIi6sRR3OCkr9E1QEkUtAr3DdLNnggVuKOdMfLPp4knmO+Z63X0VBgnbqBrdt 9IqNosCrCbFyaGDxC+TgSNSSb1VkyOB9wTE3TfGRB8dAYcpwqNW52Z1nVVh0J1FXpC1i 0QIsws8X3tKX0WUQ5M58h9wVWsCq62MsZBuCoIAdY7u0OQao9ULRKPHAuEWIlunBXUd6 LsmbDYAk+RrOcdHl0Zq4gcm+JkhfpRy4EdKev2+/aVHvmL359CdORo/qnJx+JbkGpqgd baxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y6320XCgMwJY1zG7cLEXVifisYCoFNkKfucLWd4W1X4=; b=IhomIwM4m+cp4O8FVDRQzQZXHEcx45eAmycQb67s3u7YZOpJw0FFNkhFKrmd/8PMxI EzMFjyn23XoW9s9rdqp/nRFLP5O1T58PYeaj7pGO1AluvT2GzkuGRgQtv2KH39gpWjEf sTwzV5biZnVR0vGI0GrGhGo64PSr4vudquitBuUwOZoCCsuG+1OA7kOhQnu01ykJEu4K Da1wyKhY4OMU8a2gkR8PjCL4Ee0tgypWF0V8ygHGqk2fNGr3l3W1Y0/0fXNaetpzIu45 A5uUWTVK8/yXCsojItOxCxWGzhk43xFE4Ww0hCRSUIhhQyes5Tdwj4aBzPvuvV9hUOyX 3+mw== X-Gm-Message-State: AOAM530kjiXodxRLP5GEllboEDo5Rh4S6TNtaQsL/KICJTpH2gW/1kTk y07O4PIGhyYgb2qmuuF+lMgYfu5nR7typQ== X-Google-Smtp-Source: ABdhPJzlVMMoxlYMvj7mhaTErn5IpO0NYKjhT7SrmNxoMP0CXkk019mr/xABevwJBZlBQYXBmR+oeg== X-Received: by 2002:a5d:52c7:0:b0:210:ac6:3956 with SMTP id r7-20020a5d52c7000000b002100ac63956mr18447365wrv.379.1653926916967; Mon, 30 May 2022 09:08:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 097/117] target/arm: Move null function and sve check into do_frint_mode Date: Mon, 30 May 2022 17:06:48 +0100 Message-Id: <20220530160708.726466-98-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220530160708.726466-1-peter.maydell@linaro.org> References: <20220530160708.726466-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1653934334610100001 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20220527181907.189259-95-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 52 +++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 2a5fbec2d6d..43cfd2818ea 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4140,62 +4140,56 @@ TRANS_FEAT(FRINTX, aa64_sve, gen_gvec_fpst_arg_zpz,= frintx_fns[a->esz], static bool do_frint_mode(DisasContext *s, arg_rpr_esz *a, int mode, gen_helper_gvec_3_ptr *fn) { - if (sve_access_check(s)) { - unsigned vsz =3D vec_full_reg_size(s); - TCGv_i32 tmode =3D tcg_const_i32(mode); - TCGv_ptr status =3D fpstatus_ptr(a->esz =3D=3D MO_16 ? FPST_FPCR_F= 16 : FPST_FPCR); + unsigned vsz; + TCGv_i32 tmode; + TCGv_ptr status; =20 - gen_helper_set_rmode(tmode, tmode, status); - - tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd), - vec_full_reg_offset(s, a->rn), - pred_full_reg_offset(s, a->pg), - status, vsz, vsz, 0, fn); - - gen_helper_set_rmode(tmode, tmode, status); - tcg_temp_free_i32(tmode); - tcg_temp_free_ptr(status); + if (fn =3D=3D NULL) { + return false; } + if (!sve_access_check(s)) { + return true; + } + + vsz =3D vec_full_reg_size(s); + tmode =3D tcg_const_i32(mode); + status =3D fpstatus_ptr(a->esz =3D=3D MO_16 ? FPST_FPCR_F16 : FPST_FPC= R); + + gen_helper_set_rmode(tmode, tmode, status); + + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->rd), + vec_full_reg_offset(s, a->rn), + pred_full_reg_offset(s, a->pg), + status, vsz, vsz, 0, fn); + + gen_helper_set_rmode(tmode, tmode, status); + tcg_temp_free_i32(tmode); + tcg_temp_free_ptr(status); return true; } =20 static bool trans_FRINTN(DisasContext *s, arg_rpr_esz *a) { - if (a->esz =3D=3D 0) { - return false; - } return do_frint_mode(s, a, float_round_nearest_even, frint_fns[a->esz]= ); } =20 static bool trans_FRINTP(DisasContext *s, arg_rpr_esz *a) { - if (a->esz =3D=3D 0) { - return false; - } return do_frint_mode(s, a, float_round_up, frint_fns[a->esz]); } =20 static bool trans_FRINTM(DisasContext *s, arg_rpr_esz *a) { - if (a->esz =3D=3D 0) { - return false; - } return do_frint_mode(s, a, float_round_down, frint_fns[a->esz]); } =20 static bool trans_FRINTZ(DisasContext *s, arg_rpr_esz *a) { - if (a->esz =3D=3D 0) { - return false; - } return do_frint_mode(s, a, float_round_to_zero, frint_fns[a->esz]); } =20 static bool trans_FRINTA(DisasContext *s, arg_rpr_esz *a) { - if (a->esz =3D=3D 0) { - return false; - } return do_frint_mode(s, a, float_round_ties_away, frint_fns[a->esz]); } =20 --=20 2.25.1