From nobody Sun Feb 8 15:46:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1653911819; cv=none; d=zohomail.com; s=zohoarc; b=deg2U+SRT6izYTQFu0xf3+i/o0TYH4t9z1UlineeuPgYkAKpm+FKbCn+fg7HdNYXtMlB9r+UpFInvPlHkCeYkH+22HCMV87fyesYdzkWqLBWkLER9VTRDjx4yln6YCp7QSqZ4dPqMi/wf1BDIIhW0wyeeF4Wvzeyb6SbJed4FXs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653911819; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Xg3ddB2ASNlFC7R7TJt/TAeFKmI/LPGXMVgfcznMf0=; b=Y5sN49uZyFL2UF7g3xp6Ao8LEz67kDI2SHM8sCI9B2HXigpWMD9rRP4d2ww6GaaJuPsU1gjs86JP17+QcXa6rtMtU2F4ApROScV90pfZwetpF0MvBYfk/nrDvdukA3eBTTW8sxsfDkYxzSH37ZayBLIwvYIZaUzR4Fs3XA9rp8o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1653911819976830.3632619175842; Mon, 30 May 2022 04:56:59 -0700 (PDT) Received: from localhost ([::1]:41898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nve14-0003gC-WD for importer@patchew.org; Mon, 30 May 2022 07:56:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvdZ1-0000AG-FV for qemu-devel@nongnu.org; Mon, 30 May 2022 07:27:59 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:43616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvdYz-0001M9-SF for qemu-devel@nongnu.org; Mon, 30 May 2022 07:27:59 -0400 Received: by mail-pf1-x42f.google.com with SMTP id y189so10318669pfy.10 for ; Mon, 30 May 2022 04:27:57 -0700 (PDT) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id u1-20020a17090282c100b00163fbb2bae5sm85700plz.209.2022.05.30.04.27.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 30 May 2022 04:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Xg3ddB2ASNlFC7R7TJt/TAeFKmI/LPGXMVgfcznMf0=; b=mQK09UIXCOv/dAvenP8EcLB7GbC8/Bv3b1vlv9G6km3Y2JYf3LXy8EiJ98MU2lKy7Y 5YDc/Hf8JHRvNEH+Br/ST56ZA/NXN+QRS+ZgX/fZFZbx1datiMVyzQfe2CfqUuhG85Gh 7Xo/HuFis76AOVWNmYmBs20zYWXPnc+2s9IeZ37vprWAJKDa33gRcavnXrtW9uY/5cWD hKXH+JFGMfyU9gHVa4WBrlCo3Uva5QCgVANYeehy38UZSPaljuTkThYT7dS90wzxKBPM Yj4t0znta7yP/8W44pX+eiqclXwKwFEBH779NRhaPY/FFlWsfV0glRzyAAe8x0xGieqS V7tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Xg3ddB2ASNlFC7R7TJt/TAeFKmI/LPGXMVgfcznMf0=; b=DsoitxjuNEQSdcLx1SpEtf6SFflGlh8Ih4hrOEPZU7OAp2sKAZjK1LtOxqXB6aZQ4/ qQTsCoeLO+MBzR+07xZZLho8527XHMI2FMlD4Omb1E+DMkpPfVhdKRDUEG3avjLUoq1S X14Y1TqSkzFrMBP9EdFkgMY2X/es5MrKxxuSRYyayHXLT9p2OTxGHeMleScf4Xk8t9uo mMB/f+WofiTJjMtzuq72HMMlG1ghSS6PlkuF4iaWWQ39NKGioMWDPjUMW8MXx67PGcje GMwkvc5NEKh664BNTHRjxRkRAZcDRkAwVdTfrwt+rrVX+V+f7Q8JFrO/dMtZI5qpTgWt iK6Q== X-Gm-Message-State: AOAM532ivVGiOd5LVppAlHax/cGCAyHqaBTTG/b5ABKl2rgt0eOuc1gP rPYlww8Ku5eJ41qtgIM+i4I= X-Google-Smtp-Source: ABdhPJyJnBwmY334wWKxjsyfgqZm8oIRxztcJNCLi4S8SMovC5nTSJcQ+dTnVr2pXgwg+116gsxBEA== X-Received: by 2002:a62:e40e:0:b0:518:3f5d:eecc with SMTP id r14-20020a62e40e000000b005183f5deeccmr16496571pfh.22.1653910076255; Mon, 30 May 2022 04:27:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Mark Cave-Ayland , qemu-devel@nongnu.org Cc: Richard Henderson , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Igor Mammedov , Ani Sinha , Bernhard Beschow , Eduardo Habkost , Marcel Apfelbaum , Aurelien Jarno , Paolo Bonzini Subject: [PATCH v2 03/11] hw/acpi/piix4: convert smm_enabled bool to qdev property Date: Mon, 30 May 2022 13:27:10 +0200 Message-Id: <20220530112718.26582-4-philippe.mathieu.daude@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220530112718.26582-1-philippe.mathieu.daude@gmail.com> References: <20220530112718.26582-1-philippe.mathieu.daude@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1653911822372100001 From: Mark Cave-Ayland This allows the smm_enabled value to be set using a standard qdev property = instead of being referenced directly in piix4_pm_init(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Ani Sinha Message-Id: <20220528091934.15520-4-mark.cave-ayland@ilande.co.uk> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/acpi/piix4.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 558c250884..316e41e1d0 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -547,6 +547,7 @@ I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t = smb_io_base, pci_dev =3D pci_new(devfn, TYPE_PIIX4_PM); dev =3D DEVICE(pci_dev); qdev_prop_set_uint32(dev, "smb_io_base", smb_io_base); + qdev_prop_set_bit(dev, "smm-enabled", smm_enabled); if (piix4_pm) { *piix4_pm =3D dev; } @@ -554,7 +555,6 @@ I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t = smb_io_base, s =3D PIIX4_PM(dev); s->irq =3D sci_irq; s->smi_irq =3D smi_irq; - s->smm_enabled =3D smm_enabled; =20 pci_realize_and_unref(pci_dev, bus, &error_fatal); =20 @@ -664,6 +664,7 @@ static Property piix4_pm_properties[] =3D { DEFINE_PROP_BOOL("memory-hotplug-support", PIIX4PMState, acpi_memory_hotplug.is_enabled, true), DEFINE_PROP_BOOL("smm-compat", PIIX4PMState, smm_compat, false), + DEFINE_PROP_BOOL("smm-enabled", PIIX4PMState, smm_enabled, false), DEFINE_PROP_BOOL("x-not-migrate-acpi-index", PIIX4PMState, not_migrate_acpi_index, false), DEFINE_PROP_END_OF_LIST(), --=20 2.36.1