From nobody Tue Feb 10 13:37:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653660691; cv=none; d=zohomail.com; s=zohoarc; b=DNMl5WGPVaO/8xVSO86i01hEKBlY3c1MukrCvsqeX/rBw2kYGgrPO78G2NSWjm8VgBeVAuCb88wYpThALv1cEhjRT8Q0CDVmo31we0150lDzwGfGD8bGK4Ir/jAvtqQT6mPYTNlrRruTb8kyCPWGDnDkE6brCaEUzAhjJdjZix0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653660691; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AoC3af8qVDab0GoHo/bFL4H4GUuWAWqp9w2CRC6bztY=; b=GlAlq/RgAIVDMe4G4ObZxFVSUE7lp4GGQ9OqFqiDhUKA+ci4rgAHoEEhOJ3q/BIC2Xw/zePQz/5V3TY5/PN0T+yQvxFqYXI7hJgiMtyctabWN2kjxSoVh1qr1bSfvDuEgzjR1k9x8s9/HdE/xHM49nJFa6JoId7ZWi82PcS3HLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1653660691117476.865389861588; Fri, 27 May 2022 07:11:31 -0700 (PDT) Received: from localhost ([::1]:47340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuagb-00067c-Rm for importer@patchew.org; Fri, 27 May 2022 10:11:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuaQx-000210-BH for qemu-devel@nongnu.org; Fri, 27 May 2022 09:55:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuaQu-0000ZC-Ve for qemu-devel@nongnu.org; Fri, 27 May 2022 09:55:19 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-AcKrbuclMc6unBTRmT997w-1; Fri, 27 May 2022 09:55:12 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B5803C11737; Fri, 27 May 2022 13:55:12 +0000 (UTC) Received: from localhost (unknown [10.39.192.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id E38232026D64; Fri, 27 May 2022 13:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653659715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AoC3af8qVDab0GoHo/bFL4H4GUuWAWqp9w2CRC6bztY=; b=U+G1JSkBi0C7tnnzE6PEEV17NYOcp7HRHAq6vItmWxvrqqWsEqE7NMTCx9J8crFEUoZIVA ClZzs4/kcBHHi84qfSy/amYDWr15HXw0KBffE2Df/JndMSgD803IJlj1V5TtpI93jslXVm Sj34i1otHsDvLuVm5FqEX3HJzNEct3E= X-MC-Unique: AcKrbuclMc6unBTRmT997w-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Michael Roth , peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 06/15] qga: use qga_open_cloexec() for safe_open_or_create() Date: Fri, 27 May 2022 15:54:50 +0200 Message-Id: <20220527135459.117877-7-marcandre.lureau@redhat.com> In-Reply-To: <20220527135459.117877-1-marcandre.lureau@redhat.com> References: <20220527135459.117877-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653660692889100001 From: Marc-Andr=C3=A9 Lureau The function takes care of setting CLOEXEC. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster Message-Id: <20220525144140.591926-7-marcandre.lureau@redhat.com> --- qga/commands-posix.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 3b2392398e..2ecc43eca9 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -27,6 +27,7 @@ #include "qemu/cutils.h" #include "commands-common.h" #include "block/nvme.h" +#include "cutils.h" =20 #ifdef HAVE_UTMPX #include @@ -370,10 +371,10 @@ safe_open_or_create(const char *path, const char *mod= e, Error **errp) * open() is decisive and its third argument is ignored, and the second * open() and the fchmod() are never called. */ - fd =3D open(path, oflag | ((oflag & O_CREAT) ? O_EXCL : 0), 0); + fd =3D qga_open_cloexec(path, oflag | ((oflag & O_CREAT) ? O_EXCL : 0)= , 0); if (fd =3D=3D -1 && errno =3D=3D EEXIST) { oflag &=3D ~(unsigned)O_CREAT; - fd =3D open(path, oflag); + fd =3D qga_open_cloexec(path, oflag, 0); } if (fd =3D=3D -1) { error_setg_errno(errp, errno, @@ -382,8 +383,6 @@ safe_open_or_create(const char *path, const char *mode,= Error **errp) goto end; } =20 - qemu_set_cloexec(fd); - if ((oflag & O_CREAT) && fchmod(fd, DEFAULT_NEW_FILE_MODE) =3D=3D -1) { error_setg_errno(errp, errno, "failed to set permission " "0%03o on new file '%s' (mode: '%s')", --=20 2.36.1