From nobody Tue Feb 10 12:09:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1653244705032876.1255981667592; Sun, 22 May 2022 11:38:25 -0700 (PDT) Received: from localhost ([::1]:60916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsqT9-0002UO-WB for importer@patchew.org; Sun, 22 May 2022 14:38:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsqBI-0007b5-83; Sun, 22 May 2022 14:19:56 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:47530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsqBF-0003Zx-34; Sun, 22 May 2022 14:19:55 -0400 Received: from [2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab] (helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsq9l-0007pH-8f; Sun, 22 May 2022 19:18:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EWNKZgKs7Hw9xnifwpxp3QQzYWeTAZiPICd9VkBsaUU=; b=NTmZ8VkBSfk9hoBrlT+qjrPRRd KDy5ldr+72e+xfWmm/LdW9p0EIadvxWERs959ONdpa1PYOp1aFC0Dwa1gUM78h0IGfD8IOZsg/crb EPSW3ImwSx5tXpro26rDIvO2+ZjaX3QSntbxCE1C+iIQU92ISSe+5W/hN8lE7NLPU/LUxhU4gQyRW MPVLQTTIyEzc7cZzerXKMnwpcrsPnrk7lWqQqOqPYBHUiA2eK0UVRvdobx2HNvYuNM3VEErne/gn0 V+z3Gi5ep4S6kgP7M6BCrVVlV+yiSP9wCaJq58qEq5ritKjhYC0z409dL84UV8ftZyFPwNIoxKwc8 cRk/jkG179h/s6c6iw237rkJrvI0WIJIeKTYXZMqZbU1ZV63lPAJz132/R8lJW11GMDkBmxjcdKet oeoap/PdtWGCKdchKT4TWO9ILVme4k18eyniCXlE8d0jAxujZVz0BloI4VpsFQFl7dyZwuh2bLdAm IfLbPQc5NATPfLybN1/iOW9hDnD33ooKK+cbPOuwEii+DzF1l+s0VWSpeWxNuRUbV+sulZan8o7Lz bG3TvYBXIHVr1vKtHqMwByuYcfBPQnuSv0MzL5ol5qZPcQfjDpdr6YHZrHl5G5Nd7XYM02f0vP8y/ EjV5CLK96xebpLPfx+MOv4KFNn9cU0vWCKgz0+AYw=; From: Mark Cave-Ayland To: richard.henderson@linaro.org, deller@gmx.de, mst@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, hpoussin@reactos.org, aleksandar.rikalo@syrmia.com, f4bug@amsat.org, jiaxun.yang@flygoat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Sun, 22 May 2022 19:17:59 +0100 Message-Id: <20220522181836.864-14-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220522181836.864-1-mark.cave-ayland@ilande.co.uk> References: <20220522181836.864-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 13/50] ps2: don't use vmstate_register() in ps2_mouse_init() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1653244707272100002 Content-Type: text/plain; charset="utf-8" Since PS2_MOUSE_DEVICE is a qdev device then vmstate_ps2_mouse can be regis= tered using the DeviceClass vmsd field instead. There is no need to use qdev_set_legacy_instance_id() to ensure migration compatibility since the f= irst 2 parameters to vmstate_register() are NULL and 0 respectively. Signed-off-by: Mark Cave-Ayland --- hw/input/ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 04360c7f74..e3ee69870b 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -1262,7 +1262,6 @@ void *ps2_mouse_init(void (*update_irq)(void *, int),= void *update_arg) trace_ps2_mouse_init(s); ps2->update_irq =3D update_irq; ps2->update_arg =3D update_arg; - vmstate_register(NULL, 0, &vmstate_ps2_mouse, s); return s; } =20 @@ -1291,6 +1290,7 @@ static void ps2_mouse_class_init(ObjectClass *klass, = void *data) dc->realize =3D ps2_mouse_realize; device_class_set_parent_reset(dc, ps2_mouse_reset, &ps2dc->parent_reset); + dc->vmsd =3D &vmstate_ps2_mouse; } =20 static const TypeInfo ps2_mouse_info =3D { --=20 2.20.1