From nobody Mon Feb 9 17:23:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652972337; cv=none; d=zohomail.com; s=zohoarc; b=OmMuobe4KRmJ48OWvhjylph8gavjwTjTNhdmcvG4+2HGKcvpebu4xke5u6Z01EufNXseKq7aVZoEqPnqB6Ac7r6UzjOcaZhL7C+TMoo42v724K62U0W/pjOrrpJ8w8WIZWod7+rUSXmCS1alX+4QvxSvwe8Y5f3Q2t8hdVAEGGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652972337; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FYkBzLLtmlIkJEpoQJ4WaoAUoOIG4EPcEIw6zgksXzY=; b=m0rts5k6iyMA/0KIz8Nj3tb54C85ZX6f8VQ9rJtAxQ4ihlJpfcuVaa9+qRU20CruQDQROCuFiF0FaRf4FLGF2N7Fu7e3mEx6oZBDlSv84BjvXFLWQrqANmN12ofHOoXArNdFk9oKjPylFN96HyQVURC9TgPnn+aOLLaXKbmbLl0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165297233739942.047459140856404; Thu, 19 May 2022 07:58:57 -0700 (PDT) Received: from localhost ([::1]:35938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrhc7-0003J0-6A for importer@patchew.org; Thu, 19 May 2022 10:58:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrhSt-0007C6-E2 for qemu-devel@nongnu.org; Thu, 19 May 2022 10:49:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrhSr-00010C-H8 for qemu-devel@nongnu.org; Thu, 19 May 2022 10:49:23 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-LGtzrC5bNr2UMIzY1Lj6jg-1; Thu, 19 May 2022 10:49:16 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E78B1395AFE5; Thu, 19 May 2022 14:49:15 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.192.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F318400E115; Thu, 19 May 2022 14:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652971760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYkBzLLtmlIkJEpoQJ4WaoAUoOIG4EPcEIw6zgksXzY=; b=djK4Y12RNurN30L2sqP2K5RBOgpDYh4fUnc3yiRiPhrQPUnuZuCcBBl0f5bUeEDE2WD90L AnKTGURq/RlyJWCPTQ2ldRxWIqvyhEpODMq8zCmTemR5I2jWvpW1jFbn8uaFbjAcauooee uJ7eQ3QAQG39X0tU5T4GRHDWvVbQFbg= X-MC-Unique: LGtzrC5bNr2UMIzY1Lj6jg-1 From: Alberto Faria To: qemu-devel@nongnu.org Cc: "Denis V. Lunev" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, Kevin Wolf , Stefan Hajnoczi , John Snow , Hanna Reitz , Eric Blake , Stefan Weil , Jeff Cody , Fam Zheng , Ari Sundholm , Alberto Faria Subject: [PATCH v3 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty() Date: Thu, 19 May 2022 15:48:40 +0100 Message-Id: <20220519144841.784780-11-afaria@redhat.com> In-Reply-To: <20220519144841.784780-1-afaria@redhat.com> References: <20220519144841.784780-1-afaria@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=afaria@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652972337669100001 Content-Type: text/plain; charset="utf-8" Use bdrv_pwrite_sync() instead of calling bdrv_pwrite() and bdrv_flush() separately. Signed-off-by: Alberto Faria Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f2fb54c51f..90a2dd406b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -516,12 +516,9 @@ int qcow2_mark_dirty(BlockDriverState *bs) } =20 val =3D cpu_to_be64(s->incompatible_features | QCOW2_INCOMPAT_DIRTY); - ret =3D bdrv_pwrite(bs->file, offsetof(QCowHeader, incompatible_featur= es), - sizeof(val), &val, 0); - if (ret < 0) { - return ret; - } - ret =3D bdrv_flush(bs->file->bs); + ret =3D bdrv_pwrite_sync(bs->file, + offsetof(QCowHeader, incompatible_features), + sizeof(val), &val, 0); if (ret < 0) { return ret; } --=20 2.35.3