From nobody Mon Feb 9 19:06:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652738357; cv=none; d=zohomail.com; s=zohoarc; b=SEmCRei68pRfgdRU6IfTP7XqhD5IMvOVMiSpi0CY8LN5RdqjTnkGUm5BgZ8ZmL2J/Z5L0hFeS4DHdfj6PJgCylQqMh6BXZSyDPS/mio5WnZbXkgLJPW+jTxLBDlWuMcRMw/QuSFvqdgKt7hz1inMGmHaWnhbDSgTyvQ6chNpgQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652738357; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RGmB4zsjFa00mhjv069N1K/klVxvRGM4udUUjgkD3LM=; b=aKLvI4a1KRRDTlHhFHk7WliU5f0YArhd7/sn5VIL0FwcZxXbF5HSbfhgMc45H1OHwFwxSKwowjEAzr/ZUYUzPCD9DmtiogTe1ezCQOKcLhVCXYldalDnpNPdAXLiMQsxf83ADijEbxv0OdHNgBVJERHZtxsWdbhDhZo8V77UsHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165273835774821.11955255914063; Mon, 16 May 2022 14:59:17 -0700 (PDT) Received: from localhost ([::1]:34014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqikG-000058-PB for importer@patchew.org; Mon, 16 May 2022 17:59:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqhkW-0003QG-JM for qemu-devel@nongnu.org; Mon, 16 May 2022 16:55:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqhkV-00073R-4n for qemu-devel@nongnu.org; Mon, 16 May 2022 16:55:28 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-PqTZF1pxORuffXEd9EfS6Q-1; Mon, 16 May 2022 16:55:25 -0400 Received: by mail-ed1-f69.google.com with SMTP id f20-20020a50d554000000b0042abba35e60so1410688edj.15 for ; Mon, 16 May 2022 13:55:25 -0700 (PDT) Received: from redhat.com ([2.55.131.38]) by smtp.gmail.com with ESMTPSA id gz15-20020a170907a04f00b006f3ef214dddsm176011ejc.67.2022.05.16.13.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 13:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652734526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RGmB4zsjFa00mhjv069N1K/klVxvRGM4udUUjgkD3LM=; b=Nsv2WMQBsY4cBfhXL9HTQK5TaVpPAKUWuNnjPQSa7t95FEwfql4Q6HamRlXy41jTNlF3FS NGKbDAS3KxdP8nkHVXaNZKZgY9iEb803MWoZxxKLxamYOQH/TBA9jDs0AAHkmS7uI+gySA 7BJrHw0D/Gob4aOlLQTofFx7OELo2Qo= X-MC-Unique: PqTZF1pxORuffXEd9EfS6Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RGmB4zsjFa00mhjv069N1K/klVxvRGM4udUUjgkD3LM=; b=mLGRNa/w1x8m/zPzLyh4bwIbwAsNs4NH+ig3s5XxQzJjs65q8UX3e7ybGy89lgg+OV Rve2kJ2f6aYmv/4yDXupkIUi1hwPqPBoR5LyvKiaDWDm/AvHXNFM7/+G+M7DVLK/ijJW W3DiIJGCFZX5VbMLkq6VnWPF8+0Xa8sOJQruqeebpzIpqTy73qa24ONNWIJqPZfY5t3i wWM3e5GY0wjJ74GJ+C35YaUytuf1fxURxcmO4oprByp/j6V8ffXbcAMeRHGBI275JFkl zwdc5T99KOv3OGDy4K4msL4neOSURhBumDMJlTn/E/S/ac43/cpkTBSMlnsMamw5X9u/ RDag== X-Gm-Message-State: AOAM530OqkqoY/fvvNi7yFWDj+q2drd2fLBcPp7OeJ42OUPkF5lve4aD RhUnwXj3JybKbQie31YfCldtJN38HkpXCZL4mn7mdHfmY7CnZra/QXEAAHvpuJl+3jMpIPaU1q5 6W4J4HRcSmWCV9Zsb2Tzjb5yJiukuSXqDeDUcPZ0lD4VD+xOUFuM9QFmkqzsd X-Received: by 2002:a17:906:6a0e:b0:6f5:30c9:7c7d with SMTP id qw14-20020a1709066a0e00b006f530c97c7dmr16389292ejc.63.1652734523856; Mon, 16 May 2022 13:55:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsAzrFoZXXuHAqZ0hW4PJQ5IZua6hlsAcsmSGZh0lZKpiXIhL3iNIA7qxd7izebMExiZMOSg== X-Received: by 2002:a17:906:6a0e:b0:6f5:30c9:7c7d with SMTP id qw14-20020a1709066a0e00b006f530c97c7dmr16389277ejc.63.1652734523558; Mon, 16 May 2022 13:55:23 -0700 (PDT) Date: Mon, 16 May 2022 16:55:21 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Francisco Iglesias , Marcel Apfelbaum Subject: [PULL v2 75/86] include/hw/pci/pcie_host: Correct PCIE_MMCFG_SIZE_MAX Message-ID: <20220516204913.542894-76-mst@redhat.com> References: <20220516204913.542894-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220516204913.542894-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652738357954100003 From: Francisco Iglesias According to 7.2.2 in [1] bit 27 is the last bit that can be part of the bus number, this makes the ECAM max size equal to '1 << 28'. This patch restores back this value into the PCIE_MMCFG_SIZE_MAX define (which was changed in commit 58d5b22bbd5 ("ppc4xx: Add device models found in PPC440 core SoCs")). [1] PCI Express=C2=AE Base Specification Revision 5.0 Version 1.0 Signed-off-by: Francisco Iglesias Message-Id: <20220411221836.17699-3-frasse.iglesias@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: BALATON Zoltan Tested-by: BALATON Zoltan --- include/hw/pci/pcie_host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h index b3c8ce973c..82d92177da 100644 --- a/include/hw/pci/pcie_host.h +++ b/include/hw/pci/pcie_host.h @@ -65,7 +65,7 @@ void pcie_host_mmcfg_update(PCIExpressHost *e, * bit 12 - 14: function number * bit 0 - 11: offset in configuration space of a given device */ -#define PCIE_MMCFG_SIZE_MAX (1ULL << 29) +#define PCIE_MMCFG_SIZE_MAX (1ULL << 28) #define PCIE_MMCFG_SIZE_MIN (1ULL << 20) #define PCIE_MMCFG_BUS_BIT 20 #define PCIE_MMCFG_BUS_MASK 0xff --=20 MST