From nobody Mon Feb 9 20:46:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652343392; cv=none; d=zohomail.com; s=zohoarc; b=HR8Mms0BMNnz4VxIwbJozE8sMuBG0amHcMxuCmqbc2zPck6rLL0mHqwAHDmUWu+gg23Yd5o4Rbl7lsgpfWSy6zXFAOXeRnrPJggvo9fDZ2Ad3hLH5qyfVnr5rpXVAFex+in6/fY0PzaBia3syMTykbIeMPxVbLKo6OPMjvfaE8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652343392; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a8K1t0ahP//ILKE3gNUpij/2Hp8ohUgCeOWGIj4/nrY=; b=NWiOdE+bOk68q22EmlcVcoyttXYaKcwvV7MJ/cQinxZX6F76ar4pQDXtTdeKNEsYkrcwl3GnxybiM2AMpWTWou3zxHwU7OgAXltEVAivq0h10gUPFxI5EpWbyKt0vpeKMxeZFuIAK07LigmnWUYbi8PcQWai4f4ck0v1225XlqM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652343392844255.47089050683894; Thu, 12 May 2022 01:16:32 -0700 (PDT) Received: from localhost ([::1]:44504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np3zr-0001VK-1d for importer@patchew.org; Thu, 12 May 2022 04:16:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np3tK-0006iw-JI for qemu-devel@nongnu.org; Thu, 12 May 2022 04:09:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np3tI-0002jx-Np for qemu-devel@nongnu.org; Thu, 12 May 2022 04:09:46 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-216-mD7jWT-7OkKgDWkeaQ7UlQ-1; Thu, 12 May 2022 04:09:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2856F1C08969 for ; Thu, 12 May 2022 08:09:42 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.194.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5888840CF8F4; Thu, 12 May 2022 08:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652342983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8K1t0ahP//ILKE3gNUpij/2Hp8ohUgCeOWGIj4/nrY=; b=Hy1ZWRd4ddgZqC3jsRXF4dh3MatmxG9AQlXbAOxBUkKWgM4BHHDC7tg3So/iG3yzTG7Y9u re968OEX4S2HpNKGQnL2NtoMcig8b+/7tVpVr3TfIv4oAaWC0/nAiDiyC3PQwWrAHJA5s5 eYv15oyGcbpjwDCcH2+dqc8NxSlFxmQ= X-MC-Unique: mD7jWT-7OkKgDWkeaQ7UlQ-1 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Stefano Brivio , Laurent Vivier Subject: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection Date: Thu, 12 May 2022 10:09:28 +0200 Message-Id: <20220512080932.735962-5-lvivier@redhat.com> In-Reply-To: <20220512080932.735962-1-lvivier@redhat.com> References: <20220512080932.735962-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652343393449100001 Content-Type: text/plain; charset="utf-8" From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P. Berrang=C3=A9 --- net/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/stream.c b/net/stream.c index fdc97ee43a56..12fc26b9f4c7 100644 --- a/net/stream.c +++ b/net/stream.c @@ -365,8 +365,7 @@ static int net_stream_client_init(NetClientState *peer, if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { /* continue */ } else if (errno =3D=3D EINPROGRESS || - errno =3D=3D EALREADY || - errno =3D=3D EINVAL) { + errno =3D=3D EALREADY) { break; } else { error_setg_errno(errp, errno, "can't connect socket"); --=20 2.35.3