From nobody Mon Feb 9 12:27:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1652298746; cv=none; d=zohomail.com; s=zohoarc; b=INbrxnwoRzRFy7JRfRPX+kBmbj/4d9Ip2ls5L9Mmp+N8sNz2LUAbVZEsijVt6Z9y+bL/ALwbmGf4EF5br3TRurIOkqa6p5GUryktUQPOp6kG9noYglHuvcwOw1LKm+5bLALIwGIgkff4wHEbCalxXU2KvSmtpC6FkE65orV13iQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652298746; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject; bh=I1lbPGDDDcJ3j205wwK7ZYoGtRDBknLMwCXJQ+5U/Us=; b=P1hPVABYaPm9QZiCVaZZykpIupP9yUFI1XdN+oTsBFm+k6ZVTjqWlrJFAKDXSqnra+BogeYpkJYNt0juAfcurIdfCLAzHYdOOPvWHinkQ+20G3hwzMD3t8hXUlenV/ST2DYUtotox88IVOEprQsVihpq5f+IHjcmdCblUDjSMh4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652298746507451.27056133218036; Wed, 11 May 2022 12:52:26 -0700 (PDT) Received: from localhost ([::1]:42750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nosNk-0003f1-VG for importer@patchew.org; Wed, 11 May 2022 15:52:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1norLb-0006dM-GJ for qemu-devel@nongnu.org; Wed, 11 May 2022 14:46:07 -0400 Received: from 66-220-155-178.mail-mxout.facebook.com ([66.220.155.178]:40165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1norLX-0003qR-Ua for qemu-devel@nongnu.org; Wed, 11 May 2022 14:46:06 -0400 Received: by devvm5719.atn0.facebook.com (Postfix, from userid 279525) id 7E2B913B0B87; Wed, 11 May 2022 11:45:41 -0700 (PDT) To: Cc: irischenlj@fb.com, pdel@fb.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, clg@kaod.org, patrick@stwcx.xyz Subject: [PATCH 1/1] hw: allow write_enable latch get/set Date: Wed, 11 May 2022 11:45:39 -0700 Message-Id: <20220511184539.1099161-2-irischenlj@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220511184539.1099161-1-irischenlj@fb.com> References: <20220511184539.1099161-1-irischenlj@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=66.220.155.178; envelope-from=irischenlj@devvm5719.atn0.facebook.com; helo=66-220-155-178.mail-mxout.facebook.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NO_DNS_FOR_FROM=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, TVD_RCVD_IP=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 11 May 2022 15:50:19 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Reply-to: Iris Chen From: Iris Chen via X-ZM-MESSAGEID: 1652298748140100003 Content-Type: text/plain; charset="utf-8" --- hw/block/m25p80.c | 30 ++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 20 ++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 430d1298a8..fb72704e5a 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -35,6 +35,7 @@ #include "qapi/error.h" #include "trace.h" #include "qom/object.h" +#include "qapi/visitor.h" =20 /* Fields for FlashPartInfo->flags */ =20 @@ -1646,6 +1647,31 @@ static const VMStateDescription vmstate_m25p80 =3D { } }; =20 +static void m25p80_get_wel(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + Flash *s =3D M25P80(obj); + + assert(strcmp(name, "WEL") =3D=3D 0); + + visit_type_bool(v, name, &s->write_enable, errp); +} + +static void m25p80_set_wel(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + Flash *s =3D M25P80(obj); + bool value; + + assert(strcmp(name, "WEL") =3D=3D 0); + + if (!visit_type_bool(v, name, &value, errp)) { + return; + } + + s->write_enable =3D value; +} + static void m25p80_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1660,6 +1686,10 @@ static void m25p80_class_init(ObjectClass *klass, vo= id *data) device_class_set_props(dc, m25p80_properties); dc->reset =3D m25p80_reset; mc->pi =3D data; + + object_class_property_add(klass, "WEL", "bool", + m25p80_get_wel, + m25p80_set_wel, NULL, NULL); } =20 static const TypeInfo m25p80_info =3D { diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index 87b40a0ef1..af885a9c9d 100644 --- a/tests/qtest/aspeed_smc-test.c +++ b/tests/qtest/aspeed_smc-test.c @@ -49,6 +49,7 @@ */ enum { JEDEC_READ =3D 0x9f, + RDSR =3D 0x5, BULK_ERASE =3D 0xc7, READ =3D 0x03, PP =3D 0x02, @@ -348,6 +349,24 @@ static void test_write_page_mem(void) flash_reset(); } =20 +static void test_read_status_reg(void) +{ + uint8_t r; + + qmp("{ 'execute': 'qom-set', 'arguments': " + "{'path': '/machine/soc/fmc/ssi.0/child[0]', 'property': 'WEL', 'va= lue': true}}"); + + spi_conf(CONF_ENABLE_W0); + spi_ctrl_start_user(); + writeb(ASPEED_FLASH_BASE, RDSR); + r =3D readb(ASPEED_FLASH_BASE); + spi_ctrl_stop_user(); + + g_assert_cmphex(r, =3D=3D, 0x2); + + flash_reset(); +} + static char tmp_path[] =3D "/tmp/qtest.m25p80.XXXXXX"; =20 int main(int argc, char **argv) @@ -373,6 +392,7 @@ int main(int argc, char **argv) qtest_add_func("/ast2400/smc/write_page", test_write_page); qtest_add_func("/ast2400/smc/read_page_mem", test_read_page_mem); qtest_add_func("/ast2400/smc/write_page_mem", test_write_page_mem); + qtest_add_func("/ast2400/smc/read_status_reg", test_read_status_reg); =20 ret =3D g_test_run(); =20 --=20 2.30.2