From nobody Tue Feb 10 06:27:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652222805; cv=none; d=zohomail.com; s=zohoarc; b=YYvEwguYq3KRGHFK8xLxC0tzR6CVW4JbzLfqOV6BdPjhr5mMPUpuDlMDKLgoJCJMF5zdBPtQynKcZbazkQTERwr2kair/z6k68pPJusF5xkES1SJBReN52190BQ3rMlz0h+MOVdWyyNFrIaWv8PMNoO2XcW1Qa+PnrRjuIccCIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652222805; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vs8n8rfHPzW28VW8OO5SR80yoUi9AvYtSnpc5snK8dk=; b=GQHZpNT7euH4NGBu3BQplF7ume5oCl0RmPyG7FgzILXuUBRtDu6tabpQNV4hebvhO4kNFkAS5kFUac3Z+w2ocZUHjFlm1GTxwcMysWezchnu4VvTzcxzGzMGXQpN2BYcyCYv3i65GGDHzIMp6nryyBPM53kfE/frXUFxUFtSVYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652222805905656.4499663560323; Tue, 10 May 2022 15:46:45 -0700 (PDT) Received: from localhost ([::1]:41668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noYcu-0007Sa-R5 for importer@patchew.org; Tue, 10 May 2022 18:46:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noYaK-0004cW-I0 for qemu-devel@nongnu.org; Tue, 10 May 2022 18:44:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:24349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noYaH-0006JG-P4 for qemu-devel@nongnu.org; Tue, 10 May 2022 18:44:04 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-mDlWBoM4PUuyVG5Wo6598w-1; Tue, 10 May 2022 18:42:39 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 249BA1C05AA8; Tue, 10 May 2022 22:42:39 +0000 (UTC) Received: from secure.mitica (unknown [10.39.195.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93EAB40CFD25; Tue, 10 May 2022 22:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652222641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vs8n8rfHPzW28VW8OO5SR80yoUi9AvYtSnpc5snK8dk=; b=YuQqtJoDUZnMl8gAQXrGNaFMhlIVc3D4a528x/6g2Ukz9gLjREsWYjvXOHMd+Q9OQKU2V2 6QRzVgo9fNQneJ05TFeD6ycsU3rh+vjV4w6RFHLuqj+ku8Y1OQWtzQTWLM7UsA2hxzeCZl 2CXMxcubb3SeJ7lnJSFsjK990jviXJs= X-MC-Unique: mDlWBoM4PUuyVG5Wo6598w-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Juan Quintela , "Dr. David Alan Gilbert" , Eduardo Habkost , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Leonardo Bras , Marcel Apfelbaum Subject: [PATCH v6 08/13] multifd: Prepare to send a packet without the mutex held Date: Wed, 11 May 2022 00:42:15 +0200 Message-Id: <20220510224220.5912-9-quintela@redhat.com> In-Reply-To: <20220510224220.5912-1-quintela@redhat.com> References: <20220510224220.5912-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652222806707100001 Content-Type: text/plain; charset="utf-8" We do the send_prepare() and the fill of the head packet without the mutex held. It will help a lot for compression and later in the series for zero pages. Notice that we can use p->pages without holding p->mutex because p->pending_job =3D=3D 1. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 ++ migration/multifd.c | 11 ++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/migration/multifd.h b/migration/multifd.h index ecf5a8e868..ed81f249d7 100644 --- a/migration/multifd.h +++ b/migration/multifd.h @@ -107,7 +107,9 @@ typedef struct { /* array of pages to sent. * The owner of 'pages' depends of 'pending_job' value: * pending_job =3D=3D 0 -> migration_thread can use it. + * No need for mutex lock. * pending_job !=3D 0 -> multifd_channel can use it. + * No need for mutex lock. */ MultiFDPages_t *pages; =20 diff --git a/migration/multifd.c b/migration/multifd.c index 3f9d9e3a56..c8f2caa2ae 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -632,6 +632,8 @@ static void *multifd_send_thread(void *opaque) p->flags |=3D MULTIFD_FLAG_SYNC; p->sync_needed =3D false; } + qemu_mutex_unlock(&p->mutex); + p->iovs_num =3D 1; p->normal_num =3D 0; =20 @@ -648,11 +650,6 @@ static void *multifd_send_thread(void *opaque) } } multifd_send_fill_packet(p); - p->num_packets++; - p->total_normal_pages +=3D p->normal_num; - p->pages->num =3D 0; - p->pages->block =3D NULL; - qemu_mutex_unlock(&p->mutex); =20 trace_multifd_send(p->id, packet_num, p->normal_num, p->flags, p->next_packet_size); @@ -667,6 +664,10 @@ static void *multifd_send_thread(void *opaque) } =20 qemu_mutex_lock(&p->mutex); + p->num_packets++; + p->total_normal_pages +=3D p->normal_num; + p->pages->num =3D 0; + p->pages->block =3D NULL; p->sent_bytes +=3D p->packet_len;; p->sent_bytes +=3D p->next_packet_size; p->pending_job--; --=20 2.35.1