From nobody Tue May 14 00:42:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652163600; cv=none; d=zohomail.com; s=zohoarc; b=F6YBBAa0LOOy6myQMamCmQanBAYgJtiYtfWFLlo3oejCg0R0OPZ6fk4AMeM5dYn+ux6OCyP1luPlf5e8EAteTdTBGhH55iLIkLiJ+I2xDXyiCrepQ3/t3MVAu4U2QZgkwSNEpLyNxSjDzBFw9UUsfn6LSD8OhGMFg5RvlX1xlwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652163600; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2p6Xhuk2jkjGQj9y38i3tiwxJCln+G2rkSiZ2hOHHQ4=; b=ghJc90WsZIUcbSfzXGs/HCPCCx5zzPTE5q4couqmximHf1S69bWQyu6ZX88kFuVGai4jEA6XIFpa/luj7f5ZoBqKZLG05ZKRu6uP9ZA135XvgYKZ9Fb8nG7iLotJ+XGHeDe5dGUNamb0Ahdu7VmAxGrIkTdIR6KC7CpK1XGgFNc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652163600422222.98893339970653; Mon, 9 May 2022 23:20:00 -0700 (PDT) Received: from localhost ([::1]:56680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noJDy-0006PJ-MR for importer@patchew.org; Tue, 10 May 2022 02:19:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noJAy-0004jz-2z for qemu-devel@nongnu.org; Tue, 10 May 2022 02:16:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noJAw-00056c-4F for qemu-devel@nongnu.org; Tue, 10 May 2022 02:16:51 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-0X3iV8YFPcmqyqnaeUl3dA-1; Tue, 10 May 2022 02:16:47 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2CF838C5C41; Tue, 10 May 2022 06:16:46 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF6A8415F4E; Tue, 10 May 2022 06:16:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7C4B821E6882; Tue, 10 May 2022 08:16:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652163409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2p6Xhuk2jkjGQj9y38i3tiwxJCln+G2rkSiZ2hOHHQ4=; b=bXVtZw+a3x6QFfB66VUqajDtuz20MdWqDDSP8JtAIhEHXv7UY5GIF52jQpexw2foZCWabe 0XiNzOcvSL5kBnggR9yBcXF708m4JRq/HgzUGkj9KbdzpgYlBc5YuxTIOsRAaE6LxKwSa0 E7zgzy0H8UAY0xN2nPhCG69Gm5xLau0= X-MC-Unique: 0X3iV8YFPcmqyqnaeUl3dA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com Subject: [PATCH 1/2] qapi/expr: Enforce feature naming rules again Date: Tue, 10 May 2022 08:16:44 +0200 Message-Id: <20220510061645.3209195-2-armbru@redhat.com> In-Reply-To: <20220510061645.3209195-1-armbru@redhat.com> References: <20220510061645.3209195-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652163601917100001 Content-Type: text/plain; charset="utf-8" Commit e42648dccd "qapi/expr.py: Remove single-letter variable" accidentally removed the check for "only lower case letters and hyphens". Restore it. Fixes: e42648dccdd1defe8f35f247966cd7283f865cd6 Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 48578e1698..5a1782b57e 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.py @@ -443,7 +443,7 @@ def check_features(features: Optional[object], check_keys(feat, info, source, ['name'], ['if']) check_name_is_str(feat['name'], info, source) source =3D "%s '%s'" % (source, feat['name']) - check_name_str(feat['name'], info, source) + check_name_lower(feat['name'], info, source) check_if(feat, info, source) =20 =20 --=20 2.35.1 From nobody Tue May 14 00:42:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652163605; cv=none; d=zohomail.com; s=zohoarc; b=jaNEFi67iJeWg+40TXc/UFE3mHBR/Fn9qUxGyoD86+XB78r+JNbfKCh5F93C/PsEIOZZgDa/wj0akqT9uUrJeYpG8fQw9TIIPFMzU9HwhVRGpjRfekmQeTdkY65IOOa2Ti66XrmkvKhuqZEsXA8vSFoVh8dx2z39d4cI7Lt9jsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652163605; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qxuWDoycgoG/3v5Im8OyjTO/m10Oor16ne3kAi/MmKk=; b=dmvcsF4qiV1uwGS0gGjQMcQPWFRG9nrombtY9XLa2mWcGQZkikjv9/sx/PCCXNQlIqvwwLt7JozF2DM3MVMPnDtTCrSQtAK8/BWi9gyUmzSyFYo6nqGX6LosyuDBWCmmNsmAvLdURQOVvtitpW/iW7QDrTPNh4thlYwlhX0okds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652163605498447.72072888052617; Mon, 9 May 2022 23:20:05 -0700 (PDT) Received: from localhost ([::1]:56638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noJE3-0006Ny-Lz for importer@patchew.org; Tue, 10 May 2022 02:20:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noJAy-0004jN-2e for qemu-devel@nongnu.org; Tue, 10 May 2022 02:16:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noJAv-00056X-Nj for qemu-devel@nongnu.org; Tue, 10 May 2022 02:16:50 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-zEnkgkiUN1aAbQrTSzPjXw-1; Tue, 10 May 2022 02:16:47 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3CDC805B25; Tue, 10 May 2022 06:16:46 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFA4D40D2822; Tue, 10 May 2022 06:16:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7E54D21E6885; Tue, 10 May 2022 08:16:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652163408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxuWDoycgoG/3v5Im8OyjTO/m10Oor16ne3kAi/MmKk=; b=eWzV5GEtD1eksz7eN0wRyYeZWvIl3uWw/+ZQGJkVGygjF1CiWADMZGjozGOxsOj7IOl2U5 YLSmhfYifrwa7llO105G5iCsCPG9+oSZtge9pML8NAe5A9TbJcVQy02otMIUt2mCNz6oKN EZ3ALb8whXaCg1riRoG+pWQymXBKxao= X-MC-Unique: zEnkgkiUN1aAbQrTSzPjXw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com Subject: [PATCH 2/2] docs/devel/qapi-code-gen: Belatedly document feature naming rules Date: Tue, 10 May 2022 08:16:45 +0200 Message-Id: <20220510061645.3209195-3-armbru@redhat.com> In-Reply-To: <20220510061645.3209195-1-armbru@redhat.com> References: <20220510061645.3209195-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652163606002100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 7b968433a6..cd9b544376 100644 --- a/docs/devel/qapi-code-gen.rst +++ b/docs/devel/qapi-code-gen.rst @@ -739,10 +739,11 @@ Type names ending with ``Kind`` or ``List`` are reser= ved for the generator, which uses them for implicit union enums and array types, respectively. =20 -Command names, and member names within a type, should be all lower -case with words separated by a hyphen. However, some existing older -commands and complex types use underscore; when extending them, -consistency is preferred over blindly avoiding underscore. +Command names, member names within a type, and feature names should be +all lower case with words separated by a hyphen. However, some +existing older commands and complex types use underscore; when +extending them, consistency is preferred over blindly avoiding +underscore. =20 Event names should be ALL_CAPS with words separated by underscore. =20 --=20 2.35.1