From nobody Sun May 19 11:06:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1651908826; cv=none; d=zohomail.com; s=zohoarc; b=nvNJvXMKvXPSnzOdN8u2IuVkBBmEJ3yYn6zHVyRLjj7AV1ZoBzESyTpcitd2zC9hxg8fDVzxTr0SBM0v8MS7a2Gh19+zUwHFgg65nLQNY9YQlf4A0og2RjI4uGepURcP5SCgZE2mdPwWV4gbvPgivYHC+5dx8kwEFpb9g5PGKQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651908826; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3CPdH+RD54hIHIqTYN4JhVu9DVg+RzvT3Hqs/pJZ6wU=; b=IYyn15q6WjlIsQQElwTE5nE/OGXf4zk8wY1yg+hX8z6BqPNQX82jHHtkTL0AdIeEQjKXOKIMhQA+KOVMTnqnRK+9xrdvOgDYoF7PKwHIdnkEcERDTWQJrQ6RBDDhg2K3dbIh9vvd3ddaYHctNGWFHyzZ6gW1D03bzTdxoccZYSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651908826619568.6449718175729; Sat, 7 May 2022 00:33:46 -0700 (PDT) Received: from localhost ([::1]:46332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnEwj-0003wV-1H for importer@patchew.org; Sat, 07 May 2022 03:33:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnEts-0001za-K1 for qemu-devel@nongnu.org; Sat, 07 May 2022 03:30:51 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:45630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnEtp-0001fB-0N for qemu-devel@nongnu.org; Sat, 07 May 2022 03:30:46 -0400 Received: by mail-pj1-x102f.google.com with SMTP id w17-20020a17090a529100b001db302efed6so8681236pjh.4 for ; Sat, 07 May 2022 00:30:44 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id z15-20020aa7990f000000b0050dc76281c8sm4595821pff.162.2022.05.07.00.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 00:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3CPdH+RD54hIHIqTYN4JhVu9DVg+RzvT3Hqs/pJZ6wU=; b=t/PMJMweeA0r9V1HZbCZfHgkZnJXlRU4tK/HJhyK8HDqdRy8+Jaj0HG7U6UOAxB337 u32dswucvk56ksWa5R6UkS5DPXAD7heLDg93VeT8GZ3BcvW/rykgrJ3/JPfiM2Kof0V2 pbFJGOd2mS1lB8tQiBchd5jjy5Di6uPDS3bmjFm7B81GYe6D7B1pe25w7QpKeQGPjkUq EDqC/pWgYznFv9z8lGIVE0bP6HljJczapFPrK4b6H7qC3Cy/CjVqq8zuhWeuh5D5JeOS btgjR7b5d2vg9NnkyZfI0sQ0ruzC6LRk3cViPsXQ43NEy1xzR7vW+6zJQZajEu8Z5Z6y E3ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3CPdH+RD54hIHIqTYN4JhVu9DVg+RzvT3Hqs/pJZ6wU=; b=w0fsfHQawrIX4/t4Y2yKZtrg1xNJFhfwvBHVcE4N6LGpD1hfonN6zlnGdy3+KSJW/d +fRe2LnIPxz01abi52h9ZgWicynwHihLbIacc5kwT/OgEV1BgKpxlG0GqnGHBbPOuLks cl5eH2BlMUUBAH8BtxKj08+bcxQEM6LjFXsWS09Q/hk6VITW6Msp+Tyl/AmjMnErdANc xRCzf7yzpQqnQS0JoAAiAO57VailEGJTkTQCLulZa42SIAI6lK+euyO4zMx5NCv2sNG2 sNk+TUDNJO3vcQdkPnU6XOputRH/h4SXDYyHlIVEkKBpFktCpRGFWsMqFiQT5FWCY2pD 1qCg== X-Gm-Message-State: AOAM5315FIS1UTinhlKsNV7VaiWV9aRARcxE7fdU2gHYvYDjW+27yNlF Mn1Ct6bkdJkv1cKOuSmhBgWEHA== X-Google-Smtp-Source: ABdhPJzaLXhkVP2HW3TBYC+1BXudmb9ebtLVIuYFUGkgRtwhQTJAnrCVDw1ka4G+B3iWv+Y7ADT7hw== X-Received: by 2002:a17:90a:a410:b0:1dc:d03b:5623 with SMTP id y16-20020a17090aa41000b001dcd03b5623mr8639904pjp.95.1651908643746; Sat, 07 May 2022 00:30:43 -0700 (PDT) From: zhenwei pi To: kbusch@kernel.org, its@irrelevant.dk, k.jensen@samsung.com Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, hch@lst.de, zhenwei pi Subject: [PATCH 1/2] hw/nvme: introduce smart bits of aen cfg Date: Sat, 7 May 2022 15:26:43 +0800 Message-Id: <20220507072644.263105-2-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507072644.263105-1-pizhenwei@bytedance.com> References: <20220507072644.263105-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=pizhenwei@bytedance.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bytedance-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1651908827927100003 Content-Type: text/plain; charset="utf-8" According to NVM Express v1.4, Section 5.21.1.11 (Asynchronous Event Configuration), introduce bit 0 ~ bit 5. Signed-off-by: zhenwei pi --- include/block/nvme.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 3737351cc8..d92912f9ad 100644 --- a/include/block/nvme.h +++ b/include/block/nvme.h @@ -1122,7 +1122,13 @@ typedef struct NvmeIdCtrlNvm { } NvmeIdCtrlNvm; =20 enum NvmeIdCtrlOaes { - NVME_OAES_NS_ATTR =3D 1 << 8, + NVME_OAES_SMART_SPARE =3D NVME_SMART_SPARE, + NVME_OAES_SMART_TEMPERATURE =3D NVME_SMART_TEMPERATURE, + NVME_OAES_SMART_RELIABILITY =3D NVME_SMART_RELIABILITY, + NVME_OAES_SMART_MEDIA_READ_ONLY =3D NVME_SMART_MEDIA_READ_ONLY, + NVME_OAES_SMART_FAILED_VOLATILE_MEDIA =3D NVME_SMART_FAILED_VOLATILE_M= EDIA, + NVME_OAES_SMART_PMR_UNRELIABLE =3D NVME_SMART_PMR_UNRELIABLE, + NVME_OAES_NS_ATTR =3D 1 << 8, }; =20 enum NvmeIdCtrlCtratt { --=20 2.20.1 From nobody Sun May 19 11:06:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1651908998; cv=none; d=zohomail.com; s=zohoarc; b=VnYS3YIkxEW/4lD1yQHa/G6zGaoY/hDHDZ/Vd1hq4XwMD7Y7Nsenz60133ZZLxXmcSFg6sbcI1dEo/Ghkf2kPMRSyxNujiiNMFeWv+sDsnNyuaKCUSn4M5QIOXM17dymya7L/Xxev/2ufsPsHjN0B+54ygap4CLXc9RlZw6I96o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651908998; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P2oK6t9IGBfNJr96xxF0rzSZVXeS68xfEy7UOuVaQ0k=; b=bbggahlBUCpueo7vX2ux3sDVtcSFiPiBwuzKQzOGg4+5v83GQ0Jdhj1ak+I4+qC+aESI97kzoRtdy55/Wi7SbFh1dRmCn7a1KeHwiZypscja2nsqQrifaH9Ie2dvzo7mneQwjYahfbX87uWRjpjYozipfC49DnKZ9AmTJ1W6he4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651908998358333.88189694900507; Sat, 7 May 2022 00:36:38 -0700 (PDT) Received: from localhost ([::1]:51520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnEzV-0007cX-Bk for importer@patchew.org; Sat, 07 May 2022 03:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnEtx-00021t-9G for qemu-devel@nongnu.org; Sat, 07 May 2022 03:30:53 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:40692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnEtv-0001fs-Pn for qemu-devel@nongnu.org; Sat, 07 May 2022 03:30:52 -0400 Received: by mail-pf1-x42b.google.com with SMTP id i24so8041724pfa.7 for ; Sat, 07 May 2022 00:30:48 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id z15-20020aa7990f000000b0050dc76281c8sm4595821pff.162.2022.05.07.00.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 00:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2oK6t9IGBfNJr96xxF0rzSZVXeS68xfEy7UOuVaQ0k=; b=OPqsqTqNAmqvU2JWWrU43wuWGuYJHtc7z+whpnERWuy55hhvOOgUbTKh8DspEe55Nl VDFWoRrlURPXq60rx3mPEHGjmRTdDKHKKvzKiy3cB80axNhBFNssA04ASrUXyaOkjJHJ B8GkUTZsNP/g3fnRMae4mbV+FhoJLxxYP03A7UX53hJGmHAsHRqB06Jli04fRM71W6lr UViS14BsyNeBoLuWqMFduRekcEyHZVEwKz3YK9vMPi/HSLJP6R4PiMw11fcJrz5J/ZZY yxDkwBPLJVgWYRSW7/DGemgiYVEgZasSqvYnM8gDV8hyJqRgYryDbnxXOrJcyHbqF9Ri sqaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2oK6t9IGBfNJr96xxF0rzSZVXeS68xfEy7UOuVaQ0k=; b=GsxYoYqIPkkU6WQNqFsn621CXwC8IWvf96iixK6G4EAX56jG6x6FJJpN6VUmEiZ+k8 nm66/KJQ6uiluyRjySvAmiOK81C9HdoWwYLY1egpOHG1aAZWBS3mZbP4V7tI884Oz9s6 DSjoiR40GpEB9D9jURmNKwlGbW1C5Ss2uJSVIdjhFCtLBP5zR/TSQYZ7Bac44pTp6K7c PJOQwy6ODm5ZFSgXA0KhiH6yAfspwyQ3oPfbh2h/iZVj31vJmKIJ9Agz5hdqV3AtgZpm Llr2BFcZK8x+QyvRUPvC7CG8aiRLflQ1noUQ+o4Cx6h5O+xFJCnhlyP4uZT0EnrTN9RX Ilxg== X-Gm-Message-State: AOAM533q4+yfnxpKZETzpLsd95VmWsqvsuaZ/I2P/cktrXgUOQOfqreN PjqWIFvfGIYat/rch+E27gs1efKxAETS2w== X-Google-Smtp-Source: ABdhPJznakD0/6057kEtIjLqMzNiNzdLVEkFVB/HAO8OJsrYYe4Dam7lLHiFyb18dVp/7brk5rN96Q== X-Received: by 2002:a63:6fc4:0:b0:393:9567:16dc with SMTP id k187-20020a636fc4000000b00393956716dcmr5688184pgc.593.1651908647369; Sat, 07 May 2022 00:30:47 -0700 (PDT) From: zhenwei pi To: kbusch@kernel.org, its@irrelevant.dk, k.jensen@samsung.com Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, hch@lst.de, zhenwei pi Subject: [PATCH 2/2] hw/nvme: support smart AEN Date: Sat, 7 May 2022 15:26:44 +0800 Message-Id: <20220507072644.263105-3-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507072644.263105-1-pizhenwei@bytedance.com> References: <20220507072644.263105-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=pizhenwei@bytedance.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bytedance-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1651908999181100001 Content-Type: text/plain; charset="utf-8" Support smart AEN on controller side, if the guest side enables this feature, after injecting smart critical warning, also raise AER. This can be tested by: virsh qemu-monitor-command vm '{ "execute": "qom-set", "arguments": { "path": "/machine/peripheral/nvme0", "property": "smart_critical_warning", "value":1 } }' Signed-off-by: zhenwei pi --- hw/nvme/ctrl.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 03760ddeae..8236a746c8 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -6707,6 +6707,7 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice *pc= i_dev) NvmeIdCtrl *id =3D &n->id_ctrl; uint8_t *pci_conf =3D pci_dev->config; uint64_t cap =3D ldq_le_p(&n->bar.cap); + uint32_t supported_oaes; =20 id->vid =3D cpu_to_le16(pci_get_word(pci_conf + PCI_VENDOR_ID)); id->ssvid =3D cpu_to_le16(pci_get_word(pci_conf + PCI_SUBSYSTEM_VENDOR= _ID)); @@ -6716,7 +6717,13 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice *p= ci_dev) =20 id->cntlid =3D cpu_to_le16(n->cntlid); =20 - id->oaes =3D cpu_to_le32(NVME_OAES_NS_ATTR); + supported_oaes =3D NVME_OAES_SMART_SPARE | NVME_OAES_SMART_TEMPERATURE= | + NVME_OAES_SMART_RELIABILITY | + NVME_OAES_SMART_MEDIA_READ_ONLY | + NVME_OAES_SMART_FAILED_VOLATILE_MEDIA | + NVME_OAES_SMART_PMR_UNRELIABLE | + NVME_OAES_NS_ATTR; + id->oaes =3D cpu_to_le32(supported_oaes); id->ctratt |=3D cpu_to_le32(NVME_CTRATT_ELBAS); =20 id->rab =3D 6; --=20 2.20.1