From nobody Sun May 19 11:31:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=samsung.com ARC-Seal: i=1; a=rsa-sha256; t=1651854755; cv=none; d=zohomail.com; s=zohoarc; b=R8x4LPirmO+/MyKNrB0tEvzdE5XOoycnT8BoAeH5bF0Jam5sF84vYQUqBxmlYgkUO4ZXlmJbKGBkclUd5aQ1ag7r1k6j/Caz6yQUmEOMlIJ/zhEWEXI0FI+dWS4YtieIziuu6+LaL6J3SEVXG9wpdqNqkc/L2PkY8uDCwZHDCtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651854755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1ZjvoENIycjky5C3cXuao6J9XyheLQrjNGLqV80MRCw=; b=lKVZpjH7MJwsVtq1rSFlydqLGpRO56YAb7nrggnodb1wyPGBlskjyxSj0i18t0S21koVgj8nthFLuviCS3Ns+J0C+hZWs9utAkykRoYQpourRkZwpH/+bODG+x/rEAqDNQL9eO5XtJnid5DKLYx12hgv+3R2pRd8auZ7pAhH0iQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651854755665969.6340855847151; Fri, 6 May 2022 09:32:35 -0700 (PDT) Received: from localhost ([::1]:45086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nn0sc-0001yW-Bs for importer@patchew.org; Fri, 06 May 2022 12:32:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nn0rP-0000Xp-FP; Fri, 06 May 2022 12:31:20 -0400 Received: from mailout1.w2.samsung.com ([211.189.100.11]:33609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nn0rN-0006NW-QY; Fri, 06 May 2022 12:31:19 -0400 Received: from uscas1p1.samsung.com (unknown [182.198.245.206]) by mailout1.w2.samsung.com (KnoxPortal) with ESMTP id 20220506163107usoutp01930c52429bf46083e9bf0fc19903b83f~skRF_Q1SV0869808698usoutp01b; Fri, 6 May 2022 16:31:07 +0000 (GMT) Received: from ussmges3new.samsung.com (u112.gpu85.samsung.co.kr [203.254.195.112]) by uscas1p1.samsung.com (KnoxPortal) with ESMTP id 20220506163107uscas1p1255299366ad933575db61d7e2dc23178~skRFaS9yi3044830448uscas1p1B; Fri, 6 May 2022 16:31:07 +0000 (GMT) Received: from uscas1p2.samsung.com ( [182.198.245.207]) by ussmges3new.samsung.com (USCPEMTA) with SMTP id 58.97.09749.A4D45726; Fri, 6 May 2022 12:31:06 -0400 (EDT) Received: from ussmgxs1new.samsung.com (u89.gpu85.samsung.co.kr [203.254.195.89]) by uscas1p2.samsung.com (KnoxPortal) with ESMTP id 20220506163106uscas1p20aa8ba0a290a9b50be54df6ec4f9cee0~skRFDtAsx1463714637uscas1p2t; Fri, 6 May 2022 16:31:06 +0000 (GMT) Received: from SSI-EX3.ssi.samsung.com ( [105.128.2.145]) by ussmgxs1new.samsung.com (USCPEXMTA) with SMTP id 1F.8D.52349.A4D45726; Fri, 6 May 2022 12:31:06 -0400 (EDT) Received: from SSI-EX2.ssi.samsung.com (105.128.2.227) by SSI-EX3.ssi.samsung.com (105.128.2.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.2375.7; Fri, 6 May 2022 09:31:05 -0700 Received: from SSI-EX2.ssi.samsung.com ([105.128.2.227]) by SSI-EX2.ssi.samsung.com ([105.128.2.227]) with mapi id 15.01.2375.007; Fri, 6 May 2022 09:31:05 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w2.samsung.com 20220506163107usoutp01930c52429bf46083e9bf0fc19903b83f~skRF_Q1SV0869808698usoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1651854667; bh=1ZjvoENIycjky5C3cXuao6J9XyheLQrjNGLqV80MRCw=; h=From:To:CC:Subject:Date:References:From; b=VwLfa3iUiQ9qpKKd0b4ZIq5GXwaMAegU9ElWXGL0V4NpYCK0zW/U40rq6qIjKQDGY YR8I8AdpM5/nuzRcLWlvLFlRVjp+K/zqjDOpBKi1dvDMYjUaXob1x1zVayZs/3627b jF/+3PKfQ0ifi/n0qKJHchxDPjlKoq9GaQcIbgFQ= X-AuditID: cbfec370-a83ff70000002615-23-62754d4a7f7f From: Tong Zhang To: Paolo Bonzini , Peter Xu , "David Hildenbrand" , =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "qemu-devel@nongnu.org" CC: "ztong0001@gmail.com" , "qemu-trivial@nongnu.org" , Tong Zhang , "Francisco Londono" Subject: [RESEND PATCH] hw/dma: fix crash caused by race condition Thread-Topic: [RESEND PATCH] hw/dma: fix crash caused by race condition Thread-Index: AQHYYWauxUs3tXrAZkiwq8GTgHSRFw== Date: Fri, 6 May 2022 16:31:05 +0000 Message-ID: <20220506163059.2517-1-t.zhang2@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [105.128.2.176] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWy7djX87pevqVJBs/um1l8Xf+L2eLEpoPM Fvu3/WO12LL/G7vF8d4dLBZrz8xltTj56jybA7vHgRcL2T12zrrL7vHk2mYmj/f7rrIFsERx 2aSk5mSWpRbp2yVwZcz9klWwmbNi4RK+Bsab7F2MnBwSAiYSp64/Z+5i5OIQEljJKNHb8YQJ wmllkmi8f4gNpmrRw42sILaQwFpGidv7nCDsD4wSC+9EQDQsZZQ4duMNC0iCTUBd4lfnIjaQ hIjAQ0aJ130rwBxmgR2MEmu+/gRbLizgJLF+bgsTiC0i4C5x59g7KFtP4vO/TkYQm0VARWJJ w3awOK+AhcSs5vlgNqOAmMT3U2vAbGYBcYlbTyDiEgKCEotm72GGsMUk/u16CPWCosT97y/Z Ier1JG5MncIGYWtLLFv4mhlivqDEyZlPWCDqJSUOrrjBAnK0hMBSDombU2+xQiRcJHZ8a4Qa Ki1x9fpUqGX1EjNv/WCEaOgB+vLIemgQW0v8OroHajOfxN9fj4CKOIDivBIdbUITGJVmIflh FpL7ZiG5bxaS+xYwsqxiFC8tLs5NTy02zkst1ytOzC0uzUvXS87P3cQITD+n/x0u2MF469ZH vUOMTByMhxglOJiVRHiFZ5UkCfGmJFZWpRblxxeV5qQWH2KU5mBREuddlrkhUUggPbEkNTs1 tSC1CCbLxMEp1cCU99Nn+qYGx/5rk1T0qtqNlz/LTJ27csl+I6NTZzLqr1u9a7/l93ZqQ8Vz jcyWG7s8lhgFLjnRHDsjJWxbWsOUoJ5ZGx77r1++/4jwvT7LLeGtMi4X+asP/vywtTTgtf4h h/LTU4J+rq4Pe3D66arLO2+6TZ9/U1uuxMZv1qMKp/x9wjq6AWvOzA7dUM3mnxE1r8S77bOq rev8vZVuErGZuyceWLS0pNPBPCK26coxAUmFycZPz+ZXL1/mmR9p1e+zv8x0+90ndrOFfD75 1sd7uauHuXkYF62X6lFYscHh2y+GXYtNZV+svW6eGeuTdKvQtvvjVuf7rTV+UxruH7+e+CaI rdlWyCRSxPPjqwAlluKMREMt5qLiRABKqMIDrgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsWS2cA0UdfLtzTJ4PRnZYuv638xW5zYdJDZ Yv+2f6wWW/Z/Y7c43ruDxWLtmbmsFidfnWdzYPc48GIhu8fOWXfZPZ5c28zk8X7fVbYAligu m5TUnMyy1CJ9uwSujLlfsgo2c1YsXMLXwHiTvYuRk0NCwERi0cONrF2MXBxCAqsZJe58v8QI 4XxglNi2dBaUs5RRomnaYWaQFjYBdYlfnYvYQBIiAvcZJR7tnsoM4jAL7GCUWPP1J9hgYQEn ifVzW5hAbBEBd4k7x95B2XoSn/91MoLYLAIqEksatoPFeQUsJGY1zwezGQXEJL6fWgNmMwuI S9x6AhGXEBCQWLLnPDOELSrx8vE/VghbUeL+95fsEPV6EjemTmGDsLUlli18zQwxX1Di5Mwn LBD1khIHV9xgmcAoOgvJillI2mchaZ+FpH0BI8sqRvHS4uLc9Ipiw7zUcr3ixNzi0rx0veT8 3E2MwKg7/e9w5A7Go7c+6h1iZOJgPMQowcGsJMIrPKskSYg3JbGyKrUoP76oNCe1+BCjNAeL kjivkOvEeCGB9MSS1OzU1ILUIpgsEwenVAPTRr4FakFhU31mRsSFJKy53l3e/H7H84D/G49Z sid1sPn8qb/NzH6k2sBQfruBpMEJ5ocBGcaSZpGlSz9nzjjClfP1WqvKtukVdnX6y99p9ku4 vRW/tPpDfX7ma+3mE6btjYyxy0+vO9Il63NB2Wq3ue1xho2H85e+DdGe/ebWV11/q+/fl6ox WfffEkw4o3bxcdX3vjxmHZn3i7hYJ4tzcu+Ve87U1RJ/34jd/57R05lpv+3mvss8NDFeIMll xt+D19Z/qVukoPYs9OS3oAsbdy68Vy81UzPZ5xrDDeEveo0/rwnnb+QSmGagmlNUGMNT8t50 GSfvRIdzPY5tuTfWNBgz3VFLfqgR4CotPkWJpTgj0VCLuag4EQA3JR/2KQMAAA== X-CMS-MailID: 20220506163106uscas1p20aa8ba0a290a9b50be54df6ec4f9cee0 CMS-TYPE: 301P X-CMS-RootMailID: 20220506163106uscas1p20aa8ba0a290a9b50be54df6ec4f9cee0 References: Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.189.100.11; envelope-from=t.zhang2@samsung.com; helo=mailout1.w2.samsung.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @samsung.com) X-ZM-MESSAGEID: 1651854758476100001 Content-Type: text/plain; charset="utf-8" assert(dbs->acb) is meant to check the return value of io_func per documented in commit 6bee44ea34 ("dma: the passed io_func does not return NULL"). However, there is a chance that after calling aio_context_release(dbs->ctx); the dma_blk_cb function is called before the assertion and dbs->acb is set to NULL again at line 121. Thus when we run assert at line 181 it will fail. softmmu/dma-helpers.c:181: dma_blk_cb: Assertion `dbs->acb' failed. Reported-by: Francisco Londono Signed-off-by: Tong Zhang Reviewed-by: Laurent Vivier --- softmmu/dma-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/dma-helpers.c b/softmmu/dma-helpers.c index 7820fec54c..cb81017928 100644 --- a/softmmu/dma-helpers.c +++ b/softmmu/dma-helpers.c @@ -177,8 +177,8 @@ static void dma_blk_cb(void *opaque, int ret) aio_context_acquire(dbs->ctx); dbs->acb =3D dbs->io_func(dbs->offset, &dbs->iov, dma_blk_cb, dbs, dbs->io_func_opaque); - aio_context_release(dbs->ctx); assert(dbs->acb); + aio_context_release(dbs->ctx); } =20 static void dma_aio_cancel(BlockAIOCB *acb) --=20 2.25.1