From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673218; cv=pass; d=zohomail.com; s=zohoarc; b=Swp1T/wGdNS9ZxMFtOLPPOLT+XzOWskWIWg7totcijxZ2vebiMLInx08Pij1+yByjYeMslLhK62haiFnlSNQiDv16juJ4FNcXb3QO/IR2MiZuddnJ3zacW0PqXk17kG23UT4y02puG6oiww/gpEcUs4yePYd5FMQGLOqA0Blw7c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=LLcVULaT4HSJLyIyFFLZanGYxpcXYir5tcaegUgSLdE=; b=bjmjH6qVtpL3RCZRc3h5wxOOWKII6MViER9MaBRAXKKNB/ci8RmRtSPdmv9+2mh2DYNwTFm7o/1PPtWVL32BAKqirwhviMqBPXQrJWsjRwXM/fQ2LhXUMg3uwuR+r21uVh2Iye5swJy8yJ0R8cTcQY8rh6RGEZBJ9GUuwqEiIkM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673218097868.961037229663; Wed, 4 May 2022 07:06:58 -0700 (PDT) Received: from localhost ([::1]:33626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFea-0001q0-On for importer@patchew.org; Wed, 04 May 2022 10:06:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoZ-0001X6-PE for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:06 -0400 Received: from mail-am6eur05on20702.outbound.protection.outlook.com ([2a01:111:f400:7e1b::702]:5752 helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoX-0001EJ-6R for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:03 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DU0PR03MB8551.eurprd03.prod.outlook.com (2603:10a6:10:3e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:22 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gK0Dp+WBKkN7xJrc8tLcUsxryWzKaHtpQJ5QuFtDwooxbh1pkDYSAej+kl4/ZSzmTf47id23awCkf11lfxT/By6IZfzT699FtQVrARSofDJAArDj/Vdr2UQVrmkeI8vHCAgVWnTyb/VMiovqUncMTV5f3y5sYS6Hngd5y9BSsx1e3CCtKEEkAsSCFGPiLveg9Oq+Xu5NiCwCS01p0zCWZVfaMMcN5z0S4kIxprYzuRhf+Z0rFC20POsBDqLREN25rP06yyQTW2KyKKz0pFISBt91ehmUKaz5DGynNqez8FyF/TYpbnI4tR7Iud8dGWahWJL30VhQEkFB+UC8z4glmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LLcVULaT4HSJLyIyFFLZanGYxpcXYir5tcaegUgSLdE=; b=AJ6wZLLWjXoGOtAA+vszaOdIGzILG06xYIKHvWOq5jYL/xpUOkEAk82WPHPmRZG6IMrqzdpg8gk2Ldc082gj9RlPLGldw/oDNVE8zP3DzrjRSo6XjAbyAXkeKQ3aQunSWUJcAcJZj4dlE2Vra9kgppzWkivMwTvhfYMU7wESb9HCyCYkR6EctaUHoyQ7eFMeY04j5SaqHCNPpm0HfVpy+htflAYKrJc7yul0LMUeRC7VFq91aGZu5/SROLfEQbf580+3XjCga5eESiLWauGbMVJGI2m3wLH5AxUe+3+JiU6f49sYtSzpUKAfaMNrK0YTvcI3Rzd21O3QKUritDVtSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LLcVULaT4HSJLyIyFFLZanGYxpcXYir5tcaegUgSLdE=; b=P//Cncw9i6w5BEa307jxzhGwJHL4TgAqHhjwC9i9I7RYsFRT+OOJT1w5Vylv2CVCMfUE0MdO+s1RGZKE3umsynPfDMb9BPJWiyPX3Y8q05LYw9vTvZbzSNN+EK/BccBoGbaQu4urdqMoZb4hjbrvAWmpkpL4NdjuMuFlnEMn91g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Stefan Pejic Subject: [PATCH 1/7] target/mips: Fix emulation of nanoMips MTHLIP instruction Date: Wed, 4 May 2022 13:03:57 +0200 Message-Id: <20220504110403.613168-2-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 217bd3f3-6496-48c4-9b7d-08da2dbdd817 X-MS-TrafficTypeDiagnostic: DU0PR03MB8551:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3JQw2rWrUqS8Wz2g10KDbTvQ0jnl2tUmPVrTCrPBpt2jYrovhGtzr7+KKAPJ8eqTtaWzwkBJz8tqDkgU5qy3S2oHrUlgKMDGNeDpxuYlDT+iWxCs1nJ1rqrNiFyZxGLrtw4uyOl985nZkI3YPq5lxXs1UDkHuaVaRaWQVFUCeewPsH5XcSD7/DVrfTSq5WJ/VQpgJM4W7yLoyOqVpAhIqgwmd6UtQkpqdIxc5BXJOqsYIy6QYi016jgbULQR6/Tx/3pb6r2VniZC5DAL8C52S4EV31L04W/WEc0TroeKNzNobXm6+4j0TOpPmmexrCMfwbR7bqWLvLLjO4LD6kkE7hGCWejuwccJcqRq7J/nsDHMIsKO38jnBy67XhGxOkt7srImKx91b7ZKOXCTvSpxIra22N4T0HTOg7B9uYkOO9gG1wLSFT+PyfmWfIvCsRtN1KIU2CcMtY8b7YwbuBuichIt4VSTnSnG/IeJCDzdQ63v0q5HI0QXJq7eiiLrAhLJdGscXUbpq/z9mpxRP3iDdV05/lUlO4wC8fTFrXfPfBwBRcwD1T20MMQaHndFiLu1Rs+PWBhNigElfYKZ9kvrKEPsslXxU4GESgtyMBnkzFLknIQCvjItM3uDy8p5F6QxPG9nru48lR9mutpwrwDxMkFQ90WSQkuL6M9E1kolakhcmIy7QMRVi2gOvC+J5dzWkwJQeUf9t2pRqJjrqzUySw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(39840400004)(346002)(376002)(396003)(136003)(38100700002)(8936002)(36756003)(38350700002)(316002)(1076003)(83380400001)(6506007)(6916009)(2616005)(186003)(4326008)(44832011)(107886003)(6486002)(2906002)(3450700001)(5660300002)(508600001)(8676002)(66556008)(52116002)(6666004)(66946007)(66476007)(6512007)(26005)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iKH7pI5Y1Kxqd7/qPc999RUMWoBaVfTuGWFa4dadhUq6H5ZM2XLCY7VaKIOE?= =?us-ascii?Q?JtdPecLU93oJi5D1v48YJtuHizCA2Q9/3OpPNUP88JJyfP3nuPknlT8DYOD2?= =?us-ascii?Q?ubdUJSnDM7f/OPedTq+KDJ+EI+G6zQbf42oNesBig0OEoaWSBCxH3UFXNzB2?= =?us-ascii?Q?FLY5zBgaUqYUK3HWfEXJoqMKKTQPNF6DjluWnzLEhYpiow3Gng7vS7RAZ2gp?= =?us-ascii?Q?BpOjZPTuvqa0BaXKcwhIl/cxS63nMkbUmLSq6jJubiSA/7Z5mT8NuPSv5MId?= =?us-ascii?Q?sBnoO/sslulyH+qJ+18kk615FROYqYlliEZDAtqhnsmD+BZaqN9/RwipiaDA?= =?us-ascii?Q?We/axyiIGiLTs8iNbEmbFQiN0VWqUFtoFBVM/B+ZV7rFfFf3H4qz7JIeWXPp?= =?us-ascii?Q?iyaa5uiwuwXZHOgKFTSJGkW8TNJvR2jZmmlKaq4DJyze0PEL1lT4rNdV5XhJ?= =?us-ascii?Q?OjUWOm2bGC/7izpu/CMf1rZhLv3LGkCD2fWA6yzMYClhlFvmJZVXTF0cqMV+?= =?us-ascii?Q?wDpRHGJPMf8OxUzU488FiVH2bEkQ0t8GmDYe1Z9v8KLVnDvmXvHNx/cLgi3V?= =?us-ascii?Q?9G5COgWzHtxf3jQxig1U/HtjkHK1FoWczBE2IqvxQMcmE4ame6bgitpUoJy3?= =?us-ascii?Q?/T/NrsjrxrPr8L3FZ0K22tymqGqmM8XBro3RzwAu9r+LbLT6CcYu8npZcRrn?= =?us-ascii?Q?12tESlNL9WwLhYCvFxzxsFL039IVFDnILvZnFO+PTXcRHOiVtzStBmulNBZh?= =?us-ascii?Q?JAjOv2pvyPdcOrv0GNmfk54BJQ2vK+fF0LQIOjnWeUz7w3aCSBVZUiavnSrg?= =?us-ascii?Q?TAX05RYYGMGBdpJIC9223VKrtBkgGFz+yIFZQBxdpW1p+CN/7fSjxjSjz1P3?= =?us-ascii?Q?ytBU5r0uQeldOGOliHjE9Ok93CLQen9M7w9HHaDXitu5y+OkL9L44fVFppWJ?= =?us-ascii?Q?2h2Qxnojaos2/lZcRMU/kvQ6zzaKT0c0uspfCeteE3WYCuRDXBwNyPBbbsEq?= =?us-ascii?Q?yNzdYfaNzvnYMiLr5yAOtff+HaWQkTmXEcO9vrGbvO+btSqalDYcgU625oJq?= =?us-ascii?Q?7d8tRNqCxzmn9x+W8PdT781am9V3Ji1j6ICBdRhxkl/4MomytNKyMR2xjCAZ?= =?us-ascii?Q?m9JHsC5REuzsd/fbs9sf9lBWkzvhfWKbFW56MpHOFrd4K0XaV8d5v0pq+6qG?= =?us-ascii?Q?KDqgvVkwYFzUqLgeS82uc6c2VGZUM9zgYEHuEfbI/VzyWZy3Tqjw9ezCdyPG?= =?us-ascii?Q?3X/cMOIcqGAU55fbar4wGl+RSlBF+mVT6Sfo02qjLpOPe1JDkOu40kwXuasY?= =?us-ascii?Q?mbmzTy0VBMd45a18w6iIb1Z3Eujq3WtmBqVWaceX+4yzX4XJTo2SY9AqkdTG?= =?us-ascii?Q?wYiGeLkzJwAczVyDm5QxHQavHyFFRMaMjQx57y+FonEmPrBybMz8E/LhJ9o6?= =?us-ascii?Q?7ifLONm6CQ7+lzxvHmlaz7FMavX20ji1hmAzL0m6iEeSS2i1V2/XLxGrlfgH?= =?us-ascii?Q?tm/DJR8uSsXyPC3lSj27q8ut9MIQqmPEeIFfUJAU+L0/fkSYobyrX2qiG41o?= =?us-ascii?Q?8LfDsmv0bt2UDV0jIbVT6npLbT9PtFKavlugJxdsiFGXDPn5c+L66cTgdpdS?= =?us-ascii?Q?CjhygwPx94C39ECyJUOAmWpECvAwFXunSb0ZZmVyVMyMqpmdsJqu1J/AUt6o?= =?us-ascii?Q?P2PRs0FWMH0YiShdKKUl6vFP5/d0sOnImXyk6t9IJg0c57iln2Xm47gCc/iT?= =?us-ascii?Q?+hI9OqWLwFgFy6J2KJvahDtx0Eg7iLo=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 217bd3f3-6496-48c4-9b7d-08da2dbdd817 X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:22.5091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dQaTEodESK236fBJ5fB3oW4bEi6gvCOCBEcEKLMaQt8IYaBDaQ6wR5+1B32huVQW+S4HcaZ85+JkQN222ru3MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8551 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::702; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673219393100001 Content-Type: text/plain; charset="utf-8" The field ac in nanoMips instruction MTHLIP rs, ac is specified in nanoMips documentation as opcode[15..14] (2 bits). However, in the current QEMU code, the corresponding argument passed to the helper gen_helper_mthlip() has the value of opcode[15..11] (5 bits). Right shift the value of this argument by three bits to fix this. Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/nanomips_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 916cece4d2..58ae35a156 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -1597,7 +1597,7 @@ static void gen_pool32axf_1_nanomips_insn(DisasContex= t *ctx, uint32_t opc, check_dsp(ctx); switch (extract32(ctx->opcode, 12, 2)) { case NM_MTHLIP: - tcg_gen_movi_tl(t0, v2); + tcg_gen_movi_tl(t0, v2 >> 3); gen_helper_mthlip(t0, v0_t, cpu_env); break; case NM_SHILOV: --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673205; cv=pass; d=zohomail.com; s=zohoarc; b=ImUChFcB6c983wg/TDIkBNJpL5TfciatHToQ3BssydKsxQ1MYQCvnk8aI7HUHoa9dRiP8O0aai11t8137dIxx5zTuRos9F3a238HrEAz+tHg+DjaHCBWEcPbD2/2rSpQAoAdEb3C37GV7wWa7Vv2ln7cTKg2IJ8/HNEKY6AiADo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673205; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=+eWEKkeWWtnDzqZYQ8GW2QUsplmJ2C3cad4vZJUg7uE=; b=AD1pZqPMcp59JN8gs/y7qARLiPhhk3SqT0DO1xpy/BQ4DmdQyeOJUSYkLDhSIRr6eMM9gxjUabt+iDH7qmIXNC+JCYR2KiDzPiuaFytOyZA+bBWbJdpiXSs+Q1Fwd0m/+8I7XjkEZZAjyeaKiyVbQdmw1F46zo9Z7jh4aCaOKK4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165167320527396.77253729272081; Wed, 4 May 2022 07:06:45 -0700 (PDT) Received: from localhost ([::1]:32956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFeO-0001OR-8v for importer@patchew.org; Wed, 04 May 2022 10:06:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoX-0001Wy-1d for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:04 -0400 Received: from mail-am6eur05on20702.outbound.protection.outlook.com ([2a01:111:f400:7e1b::702]:5752 helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoU-0001EJ-Eq for qemu-devel@nongnu.org; Wed, 04 May 2022 07:04:59 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DU0PR03MB8551.eurprd03.prod.outlook.com (2603:10a6:10:3e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:23 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MbujUQrqBJNWYYWRqt8V3u08ND91in/ad2pKjMxPQw0wQLVa19QDm/9N4msxa9vUmQcv2mpLb+GYOi3ioiN6ZaQh6pQ2aBUl3ZGqjuuYj+LR4i9P/06iu4ElYvFhrwwtXIhfx+Hlaz3EJSCgNn2CPoJ6aTLaPWrKUqAnJ7P9HsHWOsdJiJKPhdGWW8blrqXUxKKKsrlGS6xFrpr5EuONy3PYEH6hLSs10GMDEJplNcpL56UmN2zBs9O7zo3QbTZnVpc1k3poN4dG439ZWBicp4yviGyDRB26a9EaC/sfPjiW2jhrC5ZNReLVmwq/UZ/6h0kW8RPuLb5H9wkBA5IJbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+eWEKkeWWtnDzqZYQ8GW2QUsplmJ2C3cad4vZJUg7uE=; b=e2549/MG6MfyQrsjLVNUrBGhsZDpgPKSXFhFdPbIXfYaQspAJtqCN9SNEGv0Sd4qWmHqQZEv+8wC+EOgrY5dSu6NUoD2ZeKg1M7bU2PDVWY4DC6+oVRlgu/034RAJTc7baOTgpEQ9QS7FOU0KRvo+QIIU0+tq1rRcU5qRYLD0V6TMiaC07BvSn7j5otqHqtzYHSQbyQrRtFNesQJ5z6PYV/QXqLAfghh8n2JMJwVQAgGai7i6gLs9ZLQgJIA8YucIbtvk/82IemdXD/5foVi0372orCb3kNAKkq/WoeNmGTY4ELIrP4+TQzW8ArHJuVETXl6VhVjX0fqlxIb8yVQgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+eWEKkeWWtnDzqZYQ8GW2QUsplmJ2C3cad4vZJUg7uE=; b=vkFC4butsn4AnDKhfiiZihVNCATC//aJUD7/v2Ll7234+51ifBUdfV6vAVTcXZHPi0QpUBsE2pP2b29oQIpNafkJMN/Kvk68CHnssX/M0A3ISb5lO+ksLEKsugA32ALcLUgH2w3vnTUuehaWy64hwj97m52K4XqhojXb98aWGAw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Dragan Mladjenovic , Stefan Pejic Subject: [PATCH 2/7] target/mips: Fix emulation of nanoMips EXTRV_S.H instruction Date: Wed, 4 May 2022 13:03:58 +0200 Message-Id: <20220504110403.613168-3-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1829e020-22f5-4c62-20ec-08da2dbdd85f X-MS-TrafficTypeDiagnostic: DU0PR03MB8551:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g/k6q9+C2J9bbbJCR+BmVzTGhtKOFOIWFar7Y0hfrW7LbV9d3EzMX26kvwxa/KAwxo/oGDO3NvashTeKGNTxbsPh2u4CtfCsXf1YbgC40TsbTktzIV60RwX5l/uF+Gnbr2CmoUSs2f3NL1Hmr4SOwXJc1pW98jkDt/rO1PWA9O6/lWQXeriHIfq84c0QiJKhu0tSpuvwbxVGx65KMp9d6sQ3JZT5NTl2I2mv7PH2D4MjOG4MsNXi34DKiwrTeYyxxyC+vP7MytEnLsPFiaM+RcJCZBmdL5e3hCe7a/itkBECmMFZUO6Kj8Zm0OGrPsIoFoqup5KtwT6/Vw/M/2pR+dwVjhXNY+TCL8AepvMs/QrwCIoYm3i5aZtUlwPhq4A8Phfxb+yLG1hxC2AfS7g+HtTLGMkabeLD3i+/Ng9eXbvJKMvOb+ZG2qB4AE0rFnzxQHyCCkLRapfRiNP5YyiCjXLFqrTzfyOkeiU382l8/q58PQQx5WF43QgFcxozZ/NY7svpI2WDbi+nwg25A4CJ3Z8OyJzc97M/OImdssS/UEcA59vj3L5WYyzmN2y34WfhySMCt5tzeqx5WXW5O7boSwlCqaWcq3LcGtRC7/jD6ZKU1rQtRtE/Gd7nSyMd8LTP5/stf6toH8WjS2n3d6r5xDdN2Mujq6Ka+ImcAAEc1bNffL0/H3mKeF1p0Q3zznvR3XXgIYA+PY/oKP+G+0ZkhQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(39840400004)(346002)(376002)(396003)(136003)(38100700002)(8936002)(36756003)(38350700002)(316002)(1076003)(83380400001)(6506007)(54906003)(6916009)(2616005)(186003)(4326008)(44832011)(107886003)(6486002)(2906002)(3450700001)(5660300002)(508600001)(8676002)(66556008)(52116002)(6666004)(66946007)(66476007)(6512007)(26005)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xqQ2D6a+JfwW/odEDNA+xIEj+OGDNIUGFUqDaMvpJAQLdX48JhveWhqyo7xD?= =?us-ascii?Q?OX95T9RQI9my/uksTvSMt3MXgDIjaOsXpUUzzqqKyIQMMOFiauU9ejyI+n4O?= =?us-ascii?Q?XdIMOeFmMdvMGAdqoO2ta7YCvdec0t3QR9FF2bCX4OuQ3vtyOBzHV6XIdgAL?= =?us-ascii?Q?F3NCSIhq18PDTg7WcO8PYQWv4YkjRNCRdTKMoJCTYvg+CTEI73klGxyOzoJs?= =?us-ascii?Q?3IY0Xj3qgkZWz8y8qMBhizwN8EVW3uXBmMkSYRkP9eqxzY67bH35Bpi3weUt?= =?us-ascii?Q?WcDXXwPNBX2cJr7j0KWQXbRwA6Sb2LDpkYS7pqkO7mp9cgGB9cQpmt78/Idz?= =?us-ascii?Q?ZbeAMY1cAVEiMwJq5li1mIfiIOUlYgCosuW4494YKRyNsgagHWX8hXedQgYs?= =?us-ascii?Q?DvbEZnnxaL5fTXjxVCQeXVZ7eQ9bGFOvPHnEyxsG6HA9w8a/WqJi8Ss7EKlR?= =?us-ascii?Q?2ffcnXA0XwzwAvxAWv1fvIwqcfQnyzuawsE+PIqsBD2jeH+Z6C6BY9e7yoow?= =?us-ascii?Q?emuOUuw0M/zqkP1boad1/8f2w4ubQVgI0BlAIyAU212Q9IWB09o3//as92q8?= =?us-ascii?Q?b6D/eTx+w/wkf1xtGjTuGAwzZjB6E4OiNJt8qM714bYTSkegHtk11ArFnp1r?= =?us-ascii?Q?S8p4Nj/nqiWOxnUlZjofuoaxKA8g2OZJ6IXKRnwPSAb7LZ1SzDiWD3GGxdLd?= =?us-ascii?Q?p7vwdxv3niag7Jl2PHCyEHC0xqRLnEtjJsKKfAA4+YQOmXznhoM/8B5x7Jjx?= =?us-ascii?Q?w1JN6PhTDDEkR9aW42SoE3fI0RJUuIZ7MMzsOVv8/0DEfe73CMbzoevVMarw?= =?us-ascii?Q?p/BWM77J7UExV2x2lhFvGjNWTwX6lrUQXxYBnpWZXBdaicl7GD5b/06KJ6Df?= =?us-ascii?Q?TJO2AEuAApKS/OC5T+ZhOGVHIbIPURS8S7qQEUeahMRIDWu9iArfSDeJunhu?= =?us-ascii?Q?YCglj+FFmZ2NfVdIV7QO7DTacQHSlcWbgiW/XKSk8aENaLR4NceYSnuvWlS/?= =?us-ascii?Q?tkcDqwHnf1ZyhNrJ+vu3jOSq6jdwO5DlVSCwGcsjDvSlnjJDjW//NFPXslo5?= =?us-ascii?Q?rJ1MpxWSjQeMAbHuqWgKElmadCj0BzgNvYb2rYMOyQDdevkEifCpwHawrNB3?= =?us-ascii?Q?3MF06hYzhioqxEZjY2YliLJ4Su5K3dlKRQ8cfUfsdZW8pavijXliXmKQFjyQ?= =?us-ascii?Q?8bmSNqpBXHrPH8+UVgBnEm9u/AfviOBr3pIkQAEiAWvaWMi0S+ZaXBdznVuG?= =?us-ascii?Q?v7CL4SI1V+qz0Ay/mpiNsUAhEEKlbhbKNvEU+jshSBF4sDl7kW+KrTpCAU0c?= =?us-ascii?Q?93n+MmVLLgOEqHe78qTp4AjrgSnpGNlrHQihtt31eHbaw4RhVTCtLaqfFc0i?= =?us-ascii?Q?fWOmPUQpSDtPawqQg2NldxJ39hE+A15uoQnorD0nEQzTD6+oI737gGSkrZc5?= =?us-ascii?Q?Q7OVOch/gYpzWLLHLJp7TJFEwUDvXm7r1/cJt88Gur5ld581ft+zNEypdO6v?= =?us-ascii?Q?iu7SM0/Z0YfD5Ebd/P1ehFQ/Cudgm5JnLc4vL86EgiDNNehBms0UX2YlfUEK?= =?us-ascii?Q?VBbtURv7nG55EnlxyE7i16GlN+JHU+FF+a9rNMdgG2TC6kG1B9/gGtBYBddV?= =?us-ascii?Q?aQSeNvCyp/XZnQC6w5NJB25ndFOywSnLh+LZqMIrmIGH8wp2ZkmaHQRdzFKF?= =?us-ascii?Q?izb8NqLJto9wpyE8On9QcnfMB88hUgYHeyaEYryUqQVa2ZtlrG5poovyVB3j?= =?us-ascii?Q?GT2JORR6V/h9gFkfI2hbQU+A4gNzUBg=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1829e020-22f5-4c62-20ec-08da2dbdd85f X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:22.9778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VKdZJQ45xVsXT97SjGde/djCSie+g/8J0yMSWRZzmUlCd8KfnRH/TILkjdUxO4rBoLWNpyHL0osb4bH4UzePlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8551 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::702; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673206792100001 Content-Type: text/plain; charset="utf-8" From: Dragan Mladjenovic The field rs in the instruction EXTRV_S.H rt, ac, rs is specified in nanoMips documentation as opcode[20..16]. It is, however, erroneously considered as opcode[25..21] in the current QEMU implementation. In function gen_pool32axf_2_nanomips_insn(), the variable v0_t corresponds to rt/opcode[25..21], and v1_t corresponds to rs/opcode[20..16]), and v0_t is by mistake passed to the helper gen_helper_extr_s_h(). Use v1_t rather than v0_t in the invocation of gen_helper_extr_s_h() to fix this. Signed-off-by: Dragan Mladjenovic Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/nanomips_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 58ae35a156..9ee4df2135 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -2036,7 +2036,7 @@ static void gen_pool32axf_2_nanomips_insn(DisasContex= t *ctx, uint32_t opc, case NM_EXTRV_S_H: check_dsp(ctx); tcg_gen_movi_tl(t0, rd >> 3); - gen_helper_extr_s_h(t0, t0, v0_t, cpu_env); + gen_helper_extr_s_h(t0, t0, v1_t, cpu_env); gen_store_gpr(t0, ret); break; } --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673474; cv=pass; d=zohomail.com; s=zohoarc; b=HYpQ1+/VoFOwMM0MwcCN7vHpThEJ3dWyGikuUm0E9+Iscu15DEUe5nKRsLxv8rcdm7/aM1r3hI5C6d7B843JqcC3LLXLsdpEGuZI0PKwBK8BaxseVfgboNOHLKUMWdDPiL6YiGVolPaQYWtoQRYzLoUSpD0ELn5uLeAT/FDZK34= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673474; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2COhxjV2uDL/oJ3JdRCWk27DPTp4+rt8OWyF9JgGQMA=; b=XCuJtbQlUbC2uQOnCl1n9R00RGFQMddX4kqFtdbEo2l0YDcYo+tszp7TGPNyhvyxt/1HeV2qBc1CHZv+TRY8N4GeOp/V8q5A8nPqqI1214/Eee3l4Be7Qh2RVOZZj7z1xbjcXT5HMSnXFKXBYgN5IVWJJCC7dQb7ye1phljab8Y= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673474262598.4380442198077; Wed, 4 May 2022 07:11:14 -0700 (PDT) Received: from localhost ([::1]:41230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFii-0007H0-JD for importer@patchew.org; Wed, 04 May 2022 10:11:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCsv-0003ms-AL for qemu-devel@nongnu.org; Wed, 04 May 2022 07:09:35 -0400 Received: from mail-eopbgr70090.outbound.protection.outlook.com ([40.107.7.90]:41294 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCsq-0002KR-Pt for qemu-devel@nongnu.org; Wed, 04 May 2022 07:09:30 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DB6PR0302MB2631.eurprd03.prod.outlook.com (2603:10a6:4:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:24 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZcQOHPozcnDumi3V4N9TsYAbYxPYHAfzyiQtAd8esrW1ydYGdefECUgeXphLNcdGjbQCRGEExF3IOGOdcGNsQD0CJy/3hqsqtvqav6VewYW3Mm9jj7RFhaHOigzZkp+t4WW6K7crjaW0gWcGtPlWaXqTmkll69/X2nzf2XPf+nDCBD7mpR96vnNvDnHi9th+DlsQ6aN5a2zfv2BCi5JD7AgVr28G91DGbIip28NuFW3nh2dooWPYcsMNxLac8AM+9zzqgPriD/QX7WLYjYhwU3Eh1Kx4qEPmHvkIAMPu/kpVgYM5BmBaJ8cw0N4K0HR2ye05vGL3fzX+6e+vCfyIcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2COhxjV2uDL/oJ3JdRCWk27DPTp4+rt8OWyF9JgGQMA=; b=Vi+vbHYgtSxJOHM5/EwS6bOMptlZqz1i4LFVf7/OP2TPvUDoh7EEknwbrFUWTp5PAWVViiOq5N8qxadry9c8xg3y7cKUhz1faQL9oYPLe6k+DSszh3BKNSpVpgMU0+KalftqCqvJz8c0Io9E7jXdrcVPUeQEr2gg4GpbQDR+x5BTdRdMYYyel4gfPWQ4Q+9Rh5G2tojcetR3u8V6OAuZG4wsSzazTMDbP0I7FbNaJprAsUPjp3H2YqtyWAjg12eIZEq5icuMFeGDMNErho8Qo6j6ZV2csw8QkrSinK45KPdurN5TSbIlQxS308bFF/ZyhGQjyUet7uJ3cyPjBTMBbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2COhxjV2uDL/oJ3JdRCWk27DPTp4+rt8OWyF9JgGQMA=; b=rJZS0omcDlwXVszpGCvyhR+878ogQSC/jX0AqN3mCOhEzlH//ffUHVrEJHSxOeT8KBf43ypK9/yFv27g7o0JqhwddT+8Zk7Ss9rvmU9ngUStVzfgc+ByKXMMEJ6mdzJnlDvySZw8ugt8fhdlq5Enw7yKLjN5ukXh39bbXw9QgZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Dragan Mladjenovic , Stefan Pejic Subject: [PATCH 3/7] target/mips: Fix emulation of nanoMips BPOSGE32C instruction Date: Wed, 4 May 2022 13:03:59 +0200 Message-Id: <20220504110403.613168-4-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f434b0f-3188-415d-cb6d-08da2dbdd8cc X-MS-TrafficTypeDiagnostic: DB6PR0302MB2631:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iBZRxvh6txKM00kf+O4+I9ESawqMifctMJdea58N1H/uFatFmIJz2hDfUu4zt0d5mY197vlyMO9Tf6cysxcU+Paddo0Fy8hER2q2kQJ7wJqOM/KFnt0SwpDj2RPtf58y6951WIN/WclDW4MIOgPORIyN//lBZrQ1eFpqeqjsNW7Pi29tk4e5QGeC9O2FacywLn2UFwFSvwyFXc1OCX1QC7c6nxMZMvL/SIkhjRxq8d2yQepPzh7TPCwHxsHG9ppy51ANT+8AjWo0neqjkZXf+V/SvuyOIME0bdjofQJU4in7sFIbLIbG8pZyaItR0JzzWIqfjSmbjmL+vWvn4mFPM9XSikD1ITVhnXJlhjOHhU2xWct8fe+cADndxyip54UffOepJxG42ta1AAmO3zMAHARxi6Xz0jermQUWns/1kQQJmJN0ZZiRTe3J6rG9Hj0zMJrp3wLIA51djQgYfeFm0hQUm21T+6wa+6W1Ka4Zf+yTqWlw2LSy9I/IBSWWoSm5S3ea1+W5DkK6MJRAE0IO5SBM3KsKAiJ0Qrz/lC0lGeoJ55Fry/FHvjMR/x1IMKIFrEjytu54BXHyFcO098+As1LHKgYr+cdypeB9zSuga+dSVdwi+wAfK8IsYNDwgnWfNwHTsiF/ptGpgbXBCSF8Z9P4uTwmvkUeMACSY7SHlHycVs+EFcKaTiHvkrBbltzA/DVHRqFofhy6iR+G3UJzSw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(346002)(396003)(376002)(136003)(366004)(52116002)(2616005)(107886003)(26005)(6506007)(83380400001)(6512007)(1076003)(3450700001)(36756003)(2906002)(44832011)(8936002)(5660300002)(6666004)(86362001)(4326008)(8676002)(6486002)(66556008)(66946007)(66476007)(186003)(54906003)(6916009)(38100700002)(38350700002)(508600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7vBqO3VkjXo3Yl3oefPnDwqMbM/vak9g6nKTEbXimFhvQQqJHUWpF4YWaeD5?= =?us-ascii?Q?4o7Pxj3TokO51oMxrDCmy/yIA0AKE/P1qgEgjzAPU6Z3BveUbxlcrZS7hHCQ?= =?us-ascii?Q?OytLJBz3nEs2eXQqOBqUhyaqxIpz/dLJLtQOzU9rLZxovvwO11zlNyZLmkUx?= =?us-ascii?Q?9Gak72OF6BEdj7zdtfw9Jjkn47mnf2cPcPDG1p0io4LG0UJi3NqvBpXAAS1g?= =?us-ascii?Q?el3y87tepJdBLNwAqmjhEvw8k9kwkA3Y1eBTtUWr0KOq/+x0iw1yLBmGlM6X?= =?us-ascii?Q?zpqIU4gI+gqKAqwvuFR+RFkHoISagtBSkIaPZJWKejT/omxhaG2KVlznvMZT?= =?us-ascii?Q?ydp1du+WHkKiSZDTGeEoZQAp5fLMaP36XuEGedGp4yL/G/MUQfNOyfoGTl+i?= =?us-ascii?Q?7FgPGSc/NnDG75di8fYjWP8fIyl6SaapTZMwPxWu7dIQRg/WAXp0c7niTrXg?= =?us-ascii?Q?PGqKNZC4nux6FRdGVPEG3If5Z3+1Q2w3tssoEjAzBGD4pxyIHF7YNP5Z0sWH?= =?us-ascii?Q?aAHYm6IaZF+9PSXDvLIGm3/oy6XQ5lZiWtdHzCtPGLhQ4zZnUuyZCxtPLdLm?= =?us-ascii?Q?6q/VoyhKQmbIwafHHbmGjaYUNXs1IDfvHHiy5jMhZaFabLJoQmhcKNkuq2D8?= =?us-ascii?Q?o41FsRWh8szilXKZ/+DF+0PENDZQIijq19amXUea7CRw1GoXCidNFpbw2zqe?= =?us-ascii?Q?ZILobeZX0Pz8vICEbb/AYAlohyCM6szd67B4NJvIfMVl1DDt8TJ6pcYZEG3m?= =?us-ascii?Q?mq0yaUoCxTRwrHlTgrvTWNCe3rz+3DV6R3nbKLEcsDNrBDM2Xvp5O5DBW0GC?= =?us-ascii?Q?jIR0v2hb44Ly5obRPi6z+aZw/IOvpVzH/On93Bu9JtDy63RkCBiRtMvS9Ruz?= =?us-ascii?Q?JPfKwYlogclvPOgx3S2zqMCoe90nc3+bfM1xJaXsUCGY5aLFR+0reHdzOdyD?= =?us-ascii?Q?d9MwWb+7jh56/PN8/Liazqb7WptdwxviOuNu5z2Wt9OCkpdsoE5o+q+u5kmH?= =?us-ascii?Q?FGw9zIi/11KMLZ2kFIj0NGpCxY4l6T411TfgG5BsGN348wT3NPYjyq3Sx4rI?= =?us-ascii?Q?wtjqh58Z7MvfNNYLlBofwe2YgmHytJbWmWH057walRW9pZAQBdiF8Jn3z0it?= =?us-ascii?Q?Qtp4MgPgcauaGM7kzD7tLJtBED44QvgvSDr1mANKUXkQZhhC/9BQIQnc3l6f?= =?us-ascii?Q?kDXJPUHSDrYRE4RFct1OSYC1/Cl7aA1xYyXnBCyUn+Fag65/23QSw8THFm/Q?= =?us-ascii?Q?ekx7xLecLHyTZLzMC3tQNxkLWq5xvwQwkVf6s0i+AaBUr3bvioL7irrNPEPt?= =?us-ascii?Q?UfqTJ+siUacTJAkq9Y2FV0h9ohxahqrdB7NWjnQA6Jub4MBJg5FKmCgzXDAA?= =?us-ascii?Q?cX1wU11/RrDWM1wB+QvkjJdQ42EQ9XKrThUKUnK80y6SlrFyB6m0U6d03SSe?= =?us-ascii?Q?Rpk3hZuno/ZFdrN8RBY4gZVAYtxLQKiRMKr9RPYZVvt1bYS4bObOEaJFXYuI?= =?us-ascii?Q?peRLjW5EQTK9SMcRj+KUJSUv0u/yZINhcX7CYw/838bIeN13O3tiycTnX2FV?= =?us-ascii?Q?dMDqfaQjBusuo9mGm66u3TIHeUvWisYQCdKYoOc7k7HQ/Ejg9/fAjh6WrKEi?= =?us-ascii?Q?2gQZyh5G2f1shvHe2CyM6uvISRBhszEc9PtSj0YKuwHeWIrtRWiKIsDDIu+O?= =?us-ascii?Q?0SAKGJK84a23P0wrJ2VUf31sa/WpY4HVL6K/5ldqiIbTRCo6ZzxFdiaAwUV0?= =?us-ascii?Q?Q3aOyrlGCbM5jhwTaVMBRPvAJ89AMOk=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f434b0f-3188-415d-cb6d-08da2dbdd8cc X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:23.6965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DDAo9Dx5b6IFob3wL7jJeUeTIUdSB9bNkFYMIqooXhTzyo1w3qVe8vbNrfCI8hqqZPaLOvG5IYyjMdraWgy4Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2631 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.7.90; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673475759100001 Content-Type: text/plain; charset="utf-8" From: Dragan Mladjenovic There are currently two problems related to the emulation of the instruction BPOSGE32C. The nanoMips instruction BPOSGE32C belongs to DSP R3 instructions (actually, as of now, it is the only instruction of DSP R3). The presence of DSP R3 instructions in QEMU is indicated by the flag MIPS_HFLAG_DSP_R3 (0x20000000). This flag is currently being properly set in CPUMIPSState's hflags (for example, for I7200 nanoMips CPU). However, it is not propagated to DisasContext's hflags, since the flag MIPS_HFLAG_DSP_R3 is not set in MIPS_HFLAG_TMASK (while similar flags MIPS_HFLAG_DSP_R2 and MIPS_HFLAG_DSP are set in this mask, and there is no problem in functioning check_dsp_r2(), check_dsp()). This means the function check_dsp_r3() currently does not work properly, and the emulation of BPOSGE32C can not work properly as well. Change MIPS_HFLAG_TMASK from 0x1F5807FF to 0x3F5807FF (logical OR with 0x20000000) to fix this. Additionally, check_cp1_enabled() is currently incorrectly called while emulating BPOSGE32C. BPOSGE32C is in the same pool (P.BR1) as FPU branch instruction BC1EQZC and BC1NEZC, but it not a part of FPU (CP1) instructions, and check_cp1_enabled() should not be involved while emulating BPOSGE32C. Rearrange invocations of check_cp1_enabled() within P.BR1 pool handling to affect only BC1EQZC and BC1NEZC emulation, and not BPOSGE32C emulation. Signed-off-by: Dragan Mladjenovic Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/cpu.h | 2 +- target/mips/tcg/nanomips_translate.c.inc | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index 5335ac10a3..04812e84d5 100644 --- a/target/mips/cpu.h +++ b/target/mips/cpu.h @@ -1076,7 +1076,7 @@ typedef struct CPUArchState { #define EXCP_INST_NOTAVAIL 0x2 /* No valid instruction word for BadInstr */ uint32_t hflags; /* CPU State */ /* TMASK defines different execution modes */ -#define MIPS_HFLAG_TMASK 0x1F5807FF +#define MIPS_HFLAG_TMASK 0x3F5807FF #define MIPS_HFLAG_MODE 0x00007 /* execution modes */ /* * The KSU flags must be the lowest bits in hflags. The flag order diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 9ee4df2135..941cfaa6bb 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -4478,12 +4478,13 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *= env, DisasContext *ctx) case NM_P_BR3A: s =3D sextract32(ctx->opcode, 0, 1) << 14 | extract32(ctx->opcode, 1, 13) << 1; - check_cp1_enabled(ctx); switch (extract32(ctx->opcode, 16, 5)) { case NM_BC1EQZC: + check_cp1_enabled(ctx); gen_compute_branch_cp1_nm(ctx, OPC_BC1EQZ, rt, s); break; case NM_BC1NEZC: + check_cp1_enabled(ctx); gen_compute_branch_cp1_nm(ctx, OPC_BC1NEZ, rt, s); break; case NM_BPOSGE32C: --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673072; cv=pass; d=zohomail.com; s=zohoarc; b=hUVdzLqa2IV82MUoV7ySltrskzTT85LpWGQI8zW3R3UTbYQ86+FXS7+ggVuMVzULJJQbh3jGQHbg8i0QmiBHCQh5F4OB9vDTGGSOXq3XLpr/uqWI1dhgKRi0uY/3pN85quhj7EWw1wBgvUCH1JqKhClLcoZPNX+ya71OygzJxns= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673072; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Mh4xnVvFj8U0XPjt/GXzqM3mor308dX7W1KtIlE5Jgs=; b=joYRoSHCc9DkgBevral9K0AZkmZMiBs1LJM919ICNcSMEnugZvQ0Wd2XmrJo22kXgbdMy+6hGaewUuv7SVEVhnNTrYh0KGejYI+FfexbuIU1zgk9/tF/yIB3dCW9f3+/5K+QWI0L15PrVRNXRWoeVpmFLA5nXCMhOC3u0CTXwAQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673072324436.355454134635; Wed, 4 May 2022 07:04:32 -0700 (PDT) Received: from localhost ([::1]:53268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFcE-0004JV-Qf for importer@patchew.org; Wed, 04 May 2022 10:04:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoY-0001X4-W2 for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:04 -0400 Received: from mail-db8eur05on20708.outbound.protection.outlook.com ([2a01:111:f400:7e1a::708]:59233 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoX-0001El-57 for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:02 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DB6PR0302MB2631.eurprd03.prod.outlook.com (2603:10a6:4:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:24 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMYTcKCG3CgH8jYCvRd2ClTnwn/r/V3gdnKu0V7EKy5brXXBLBYw9WTI6PH3ZoKgngC8spUMHuG91Qp0mYaNig9QA8Dq4oBN8Vx9Cw5BnvcUPJXitHeB72ctlDmwMK/vBZl26FxhFXmE0bIHKYjdAHQBbSBVvBNWPxdC0n/25VIl32XTnWnPYm0xSt4/Gh6ylJVOgb6sv1v+NSf0/OW9zKgDZSaQL7NqYCszmm8r3y96aYz7R+wBNCLEQprD3kj5STtD2IwDX6R3cUG9dBEy+/Zrt8HzSg5nwIJQc3YueScbZImTp+7RAlDUsglWe3dMUZuxQnslpJIedbQ+Gy403A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mh4xnVvFj8U0XPjt/GXzqM3mor308dX7W1KtIlE5Jgs=; b=ffF7cVAlJO6Aluwbd92FxVrCjhkHzoQkbhqFkS4EqEghf4/s73nDWpzyx7mcHUrNa3NyxSge16sM7QavK/7ddCVp1WReavt1LHUddPhptR5xMGVOTjrvQRna6BvuSd8hXwVJ583Ffaiu2pzEdj7oJeNQgl+hBv4CGqaEa93/J3oSthO7A1TlfuCH4z7LYla/L1se4HXFM5oBh4u3lB7wmulrhRRs0is7tlhGbpGjJHt7lMdAY1Ug3/psb2PtD5UAvBG50iP9P/+GNmLBrPPZtvkGzEI9pAq6739CezGUKZPlSFhCZTX5ZPOl4ZT2EFjNO0RNVm1T03RzhDLkL7VhDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mh4xnVvFj8U0XPjt/GXzqM3mor308dX7W1KtIlE5Jgs=; b=UIciVEl9RYxqg78kgChbxvjo1At4pt5n/8YFe0Kn/hAo0zbtcjEwRHnFHQ8Z2uUm7nm98MmQNiNBuOHywE46POTeUtkTpmtLLOFeSi39FHboxTygesduJzqz2xnwtCnysUS5NjRUPYyhJgdeggApGzUiwYUXMIglGKNTfpeiUWE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Dragan Mladjenovic , Stefan Pejic Subject: [PATCH 4/7] target/mips: Fix emulation of nanoMips BNEC[32] instruction Date: Wed, 4 May 2022 13:04:00 +0200 Message-Id: <20220504110403.613168-5-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3230f8e3-9a1b-4d5a-ea92-08da2dbdd94f X-MS-TrafficTypeDiagnostic: DB6PR0302MB2631:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IOUVkmOqoTOexqSUn2Ez2tlikS530Dsl8w8A7PSOE3oLdylbcix3gY/5Tc7PS9C54Necp8912sYUNtFTnurWUzpSYMTJigl+300HAaJKLOtZw01TddIRW2aX3XPPa93vJTfb3b62qH/4OOhjmC6U1Le6GbSNjwVeOxYZRO6KVfbNuuYEgfBBan1dlckoH1UF3J9ilDNoPzC6Zu//wq4xYRoMURMovhrO1PsX0oL+jyyuOY3G30PbcBR/k3FW8IDB5LptDeS02nm7Jv2ELxGcD9Mijx++qagON4EBTlt8QLDLz+pyqMAfVPVGMN8nWxnogjz6qJNlzRwbBacAcjZCWKGRoDyloJuNJMMm3ZVvPy7DSdfq3UjDr/6omfVFWodm4LW6u/m76ZZZqpFO29S4DjPgzSSzLw/WX9ONSjvtKD41/zQ/qJBBO8sAeITNpgOt/0xxMII1uI87Au+gncLDsE8OB7sUT0AyqZtqz5b7/PGFg62obMZeLeS26EWQ3ndb22lhLdIjuD7Brc7A9Cee+4OIytL8h/DIHfprE4CmmyYXsW38pIXujBBgaOhcf3wC7izdLc7WAgCdd6DjWATaN/wqxp+LuOtVxb06RlHBNjuPVPB4lt5EZNaElUFMSrsvrkGJXdLBbyyDDzMBaDAZlaMiZBhf4EBrhXFlSG6Rrp7lA/dzKRXqgc/Hg9m2vtxJjUID8C9zNs78mEdGVbXKkA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(346002)(396003)(376002)(136003)(366004)(52116002)(2616005)(107886003)(26005)(6506007)(83380400001)(6512007)(1076003)(3450700001)(36756003)(2906002)(44832011)(8936002)(5660300002)(6666004)(86362001)(4326008)(8676002)(6486002)(66556008)(66946007)(66476007)(186003)(54906003)(6916009)(38100700002)(38350700002)(508600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kMetzgHfk0C701abZKgyGVjd3hw9MxSIFX4CrDaSYePGmHCeyKc7AC3Rd1XZ?= =?us-ascii?Q?RZgP6mGrnV/DAlX7gg37h7PQUK+ka50Ax6Q7AChv08GB7rTP8GkJCXiAKExj?= =?us-ascii?Q?zoa1f7yuPqvaOa4CCFhJjpLToVveBC8E+aiwNFoPQHDBKe60oUMSeLpS+Ke1?= =?us-ascii?Q?AefjI/CqjsTzmDrrdfaPV7QXeiCcWzStUY1T1Yo02dvl7YPzS2qyyj//s6ig?= =?us-ascii?Q?rsOCaQQLgqPA2/6Lecnw5A5bHE9ydQ6zvLVCrWF7fAbgh4YD9rF26zZsmEtU?= =?us-ascii?Q?4FktzH/6/qMWkz0U/JY/WC0kJzKiSoHjKgVN/jl9AW4MhKG7VueSK5XP9KtF?= =?us-ascii?Q?9c/00qtR2Hnxr4m6DZ+xe3/1E6Btu4U4VTK8Sjfl1pJ0NmNH1cYrUyjVirfg?= =?us-ascii?Q?dFGMvf4Hskw2N4e1SAwg3YEHuz0sz8V0gkUrBc/Q4T4gmBqZuqy5brXKZqfC?= =?us-ascii?Q?6/VDkEYcmk2P6ZIYRUMMdJ+Sa0lYJ4zNLeJG/xY6NHllnzLgekzlV+48fcS4?= =?us-ascii?Q?KSOZvkvx3sfcdNOSbLHn6a9sZ8ZCrZ1nhZfSGSiv9O33ZRUrNMLGTHyC12JP?= =?us-ascii?Q?aA20a8r8IosWGzmDQXpJKjTwB3GOgd5eYEkk6k/eZEJZ7t4RlDizQGnMhtCX?= =?us-ascii?Q?q21oEhW7FrdJi5KrpXjlFDI189gi/2P/M0VuPGm8hxWxBE7+RgqtkL70qDtK?= =?us-ascii?Q?Pwb7skWFhXC7aQcBOoL1E/t7nDr/4VcPevIXpvPv/gUbpD0onRNprLFuxZEq?= =?us-ascii?Q?KvJgi/pXRQMHhw0niGzIwmIG2stnXKKJOdGRgb3GknSzb8u0nohOgJHa056m?= =?us-ascii?Q?GymaefcCv7zPjWCn9lY+LSz6us7KRLIBnBwSqTG3+Z8oDcMQWZhT2KnLFJ4a?= =?us-ascii?Q?7Wf+ilgf9YWu/qHHGhiCoV73ihVkOIx0Q3MaYVZRTB8R7eKXo8igbNq+SIce?= =?us-ascii?Q?bDtgcizzp4jygHOoiDCGPYLldngIjk9yrgGH1KtTj1uAkGZCZz7fWHs3wnR9?= =?us-ascii?Q?AsrK+MFjx1Nzeb0p0RpZyJ0tcYj+1RqZT3VpLGDWDm/MZPYEflvvxirHemsn?= =?us-ascii?Q?7YoGjIyPQmV1VEG0i5nJB+2e03158xNPUwFCKQNq3mmnAuLX/KBTiI5YLarm?= =?us-ascii?Q?ako2t/BtCv0EZjnV0Z8x+gkzcf03oqmNRwtWHzsJSfUYodo5kwOfSy6hLreD?= =?us-ascii?Q?yHPF1+ojXHabOwhr5OiPHm5t/hX3PXtNowzyuwdwu31pDEU/OKlmUrBFjWJi?= =?us-ascii?Q?aoaR/Wc8p/DVLUj7LArP5UBnuCSNw95xhT+j3JHUqwjNouQ7FL1cLNl0GlOD?= =?us-ascii?Q?vMxyvts5nlj5st7UbIxVXIjff7BFkb8yG/ehWnzTQKEPFcBzfK9S7LSsOzZ1?= =?us-ascii?Q?chY/Ju0eEpmHRpOqWIa3WWJE1tgAIfSYz/dLfC9ZB60R9jSCwhrzXRP8g97k?= =?us-ascii?Q?fUOYN4HxSliprjeqmsh1NHcltu56b+r2QMNxT6bo6lPAbSp01PA0cj/dhdOd?= =?us-ascii?Q?f9w7YYrdcqw+rcQS1g8epa6CYUXvo2ELxnxp2zkM5RNi7pixL1exw87KGl5e?= =?us-ascii?Q?0Uo5HmmayP1090KheTXpaJ7BTHWKKEcWSaktk8AYK4mynLH5Atk+NEzJ4SmB?= =?us-ascii?Q?w/poFCElM7zAiOIzXZUZQK6bm4mBKT5FWF2YWb/sWtdcPR82wFdssjLm6Kr9?= =?us-ascii?Q?Mw2RbfMoZnB7iwLlvhGPJNclwdk+O7cnJh6cDbQH7O85uohf1zqJnbwJTElA?= =?us-ascii?Q?a55qXDIrTugspWsQ8o32tN4u7rQNmjU=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3230f8e3-9a1b-4d5a-ea92-08da2dbdd94f X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:24.5714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QFahZ6I1pG/d/EP4KjdZLwljXlLUDuIfilqp8fEwBW4O/HuQOAtOZvyUnvHbQ0pgqbj0QQ3o0nRtgijpdU5A8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2631 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1a::708; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673073552100001 Content-Type: text/plain; charset="utf-8" From: Dragan Mladjenovic If both rs and rt are the same register, the nanoMips instruction BNEC[32] rs, rt, address is equivalent to NOP (branch is not taken and there is no delay slot). This commit provides such behavior. Without this commit, this scenario results in an incorrect behavior. Signed-off-by: Dragan Mladjenovic Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/nanomips_translate.c.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 941cfaa6bb..1ee5c8c8d4 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -4528,7 +4528,12 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *e= nv, DisasContext *ctx) switch (extract32(ctx->opcode, 14, 2)) { case NM_BNEC: check_nms(ctx); - gen_compute_branch_nm(ctx, OPC_BNE, 4, rs, rt, s); + if (rs =3D=3D rt) { + /* NOP */ + ctx->hflags |=3D MIPS_HFLAG_FBNSLOT; + } else { + gen_compute_branch_nm(ctx, OPC_BNE, 4, rs, rt, s); + } break; case NM_BLTC: if (rs !=3D 0 && rt !=3D 0 && rs =3D=3D rt) { --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673075; cv=pass; d=zohomail.com; s=zohoarc; b=LeqgzgUYYSDlpaofCQApxgcv5Sl3SiAlNBb5911kVzHw06pLSBlA4LEM0Mue0GEQ1Fw7fdtXqeFYzNNQFlAFNqeLuWEVKbg1AADyU8UfPOVB2Ya3DkOT/1QDrc9bovMMbOr8MDwAoiE+LXSE5puUBUh+Gtm82jNqaFf5d2u9sx0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673075; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=n2joZhY2ZLeNT13d+F5SnzjvlrYThQf6RX4V4Guehc4=; b=argiecBNX/pAeHtmKNE4YZMDyVfS4+zT7AbDkUdB1nDWJ1lFrAxciYCwM+8LPNczThqDegSD9YqmfXsTFjiJF5Z1Gztr3bw1S+81kMj8QsNRX4NW5m9dG0CioMJKBljMYVUWKevRu1SypQcjbZg+Qr7jIJTbyU/gWItncZoFMXY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673075633332.8903862391087; Wed, 4 May 2022 07:04:35 -0700 (PDT) Received: from localhost ([::1]:53238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFcI-0004Ie-GY for importer@patchew.org; Wed, 04 May 2022 10:04:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoa-0001XM-Nt for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:06 -0400 Received: from mail-db8eur05on20708.outbound.protection.outlook.com ([2a01:111:f400:7e1a::708]:59233 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoZ-0001El-67 for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:04 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DB6PR0302MB2631.eurprd03.prod.outlook.com (2603:10a6:4:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:25 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TXu9x6SB3uq5/d6v9VRI5NyQURBh+VG8+/6JsX06hON2o3d2fFQ6zA2pUOMFfJWZ03SaEVSozAGwNNGM9fpXwYgzjoNONJTLleBMvH4GrlYMoY2PKqjqqDiwO/ihOrfv2Ma3T3iqAjM7Nm2jnryVbxxOi+Uq6bkqiDNARcKx3CSU0bweW8p6Tu9brcD3AGZDKdN4dyI3eDC4Wvp0/uV3HqDe4c8u3UUXLri75hK3n9lBCaf8r+ufB0o4apftEf/by3B0ZhFmGuhv/D+3BrkuhWfYnXhw4svXs3gkQyzycbzhi6Do04dONvp/6Sd3IazM0qTGNwFgd5IVwxBHEWilag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2joZhY2ZLeNT13d+F5SnzjvlrYThQf6RX4V4Guehc4=; b=Kp/zpsTJ5ZeZW8A34OnbVPxAcEaY/yPq6MgtE7SZLeCdqtMP//gTaWh28L2FJCIq4L29/tawSr5muu73jNkZZRJNX4OvOMAUnGf5W16GQeKI/zaCVZmhCdon9bV2VAQWh/r9/v8pXBjCmd2+U0xQAULDIsADQYiCxUWqhpcRxmUPVxjVo43bbkfVwmjAqQAUdszmT3ytSF52x/lEAM2Zb2aXLHrHGuzaopRU4WXkePNCckkvngvJFT0Kzt2l9XM3EofqWZw85ha19NatfpzoIEhdqT3fC4Y4Dpc7irmRwpLA0a3WbuzbTxyjDSx6Ixj9qS6xdONjrp9b0i7FPYu1pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n2joZhY2ZLeNT13d+F5SnzjvlrYThQf6RX4V4Guehc4=; b=YlX0mQujngywruH/1u3OQq1EjK67wGEqgczOp1q9mJSzFjeCIevU4qEgCO8xsRJ3jpjneIQ05OL+z12d0Hery31cSArtMDPu1AaltYtXOaSHga1pndl3arzXzf6EJOQ4dVS0TybOYtasX1sIlGrI40Ju5WgfbpNod/x7Cedz1vI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Dragan Mladjenovic , Stefan Pejic Subject: [PATCH 5/7] target/mips: Fix handling of unaligned memory access for nanoMips ISA Date: Wed, 4 May 2022 13:04:01 +0200 Message-Id: <20220504110403.613168-6-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14f09c75-81d9-4430-57b8-08da2dbdd9e1 X-MS-TrafficTypeDiagnostic: DB6PR0302MB2631:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yi1Nc9Ue+O8/T7uxwqymyjJp8skt83PzhsJDhaGcpC9xk/RWY5cbZ9jLGNF1wAw/4kDqX3cgxerqs7wnoHKCsBDPXUiZjNXTkj2+BLkZ2ed9qCq0OfhOFXRuXmlvctkjiSAsaOulQf+uajWfOJl7Xc+C4Zftdked9sTf8v5hGSXEhL60n32E8PUmaRX2KCPJs+Tv9ovWvmFVg56NFDkEyAzCGyO4auoOPJ+TdBLcnhwOI9KkmjbM2+vDs5pibjnItvaRJWRoei/0Ygdc7VvFj+cFfYiN0tu68ZUkyeSCvhCIDiQhbzxlQCLvD4bo4wmL+4InF11j7/ATG2RxTOgFfeZR8rgfwSAU+w4egHQeD+GVfoC0t3DdHNNJ9g++hT7gvica3CBXrku7ULasly+3Qjwn4QEv0dE9I7UGeBxN9WjCWqDjtWbKQOY8kB8WvEyENa/j+wqh5P2cwVnR5RLbQgje/b/D2zUsWI01+pA+sEFo+yrRzFk6O+O3DGO81hri//tU14bfyJ35CfbbgIbhcL2k9w6XV27UTkdn3su45FsdoaMqREc62ZER+2fQPZk+5in5z0CkEsA68o6YE1EO+qwizhpF8qp6IJx3QkX8c2Rh3vdBOxWO3eBVVZRhBMm/ewFaa5Co+UQbcz1QYpVRxMgoU5aj787hu/KmaPShA43pJPCOEVgiIaC3OxYg7jPI9LAMnEA1BE4h9Yv/JEkZiw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(346002)(396003)(376002)(136003)(366004)(52116002)(2616005)(107886003)(26005)(6506007)(83380400001)(6512007)(1076003)(3450700001)(36756003)(2906002)(44832011)(8936002)(5660300002)(6666004)(86362001)(4326008)(8676002)(6486002)(66556008)(66946007)(66476007)(186003)(54906003)(6916009)(38100700002)(38350700002)(508600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4BhnDR6nGvU5BkmANUbrDqYatWhRIKf4sow7983W/9LjYYbI0yRh3aS7muVH?= =?us-ascii?Q?p5xkiXwVSTa5gdcb3Rucz64imO2aZfxwfaTJXZ+nCT5M+NPv+S4xd3SP2v2Y?= =?us-ascii?Q?xpwiesDi6Nm7Tnl9osT1RVjj766APMAD2/twEcWbf6uDLTR/Y/VXWwYeNzZe?= =?us-ascii?Q?SU7p22Hixh2pHSHEg317CNeFeqQT68qzlskrNq7E0D8ir4R94Dj/gkbmWSQu?= =?us-ascii?Q?vr8Fe1Zi1Iub9uMFa/zVGii+vfYloOIzHylZLp9/T26nB9dznmnxCOwono/R?= =?us-ascii?Q?JA9KZeRxx0g2oUA1x0TQn7fbJBgu5EN+zDNzBS5E1o3EKRYePH9hzInMbqis?= =?us-ascii?Q?rfqJpEMotCDyxVRYf3cH2+uXoVKuh2HlR+e75XfNNYSZbg/yjkQhIvNC/9Mh?= =?us-ascii?Q?O1VrHnETTU+3oVn5NDTWw29sS7DZSuDmsPnzZCVogp45YuPLUJc8o67wg4yU?= =?us-ascii?Q?GzQh+QFG8iSNrsISD5sIS3SXpwwp0FBOWrZFrHddfqjagtCsIGEWd8gLIG64?= =?us-ascii?Q?eXpYKAh+xTcRXmLdZ/Fj/qq3uWgk5zLkifuM8EzrqyZV6khGeG3/HgBDIJKI?= =?us-ascii?Q?SqY5NdwVVtkG6RWQENsYEPXNmKwaBO9ll4bJHcepUU2lDoLpgwphsPJLnC1z?= =?us-ascii?Q?1/H6xqf9SnRSQ6xQc/jMttpeydbwqK4Qh96/amOakWl5QOiyuYMTKz5A72E3?= =?us-ascii?Q?J8NIs4eiSyg9Df/UAdVDocI9/SYsElZcsQ/4ANoJuPtp/DbYQFmzbSv8VTaN?= =?us-ascii?Q?1GHVF36EK89dI7cQDfNVO4f4Lt18DSDmo4jiv4LaDbP9Icy5WO8KV/+dQcDT?= =?us-ascii?Q?ygeTHbZdyS3ty1oFeBO10xx9fX0Ux0AbeU0BGGJ88CUz5jKp3+7eyMMSpPls?= =?us-ascii?Q?ZlennLOnc9H1+lMV8e76zzf203VpzluoNtobQQWdBY+7flXkSfRMxSEWo5Mv?= =?us-ascii?Q?01fceBRJNgYqAg1h7UQ0UrtzYJtKcoToh02HU/tKFHTYCdJowkDEd27Dqp1Z?= =?us-ascii?Q?DpsIHxKyy2QcV/G/2HnMG9W6X42IbyriwVfXr+XGdTLWa9DBU5i1Immgm4Ub?= =?us-ascii?Q?6dQA3lJEIfU0fpBXuJF+8ja6jDvOxHjMmEKxMNr29y7jnRNKWz5mn8Uu2JdP?= =?us-ascii?Q?sgowScIpJn61R4VttN/v/eiBLjW5XlKKnao9XFyKOAxxWW1ZAkVC3cBN8JJU?= =?us-ascii?Q?MZRVVDm4qcifCkZkk1GIBqn2FOfqbZ3clFgPMe5Y5DB2XYx/KnerhjJys0Sd?= =?us-ascii?Q?h9IKNIL5J/xR454+rOvCiQgm34/mcQMpEmSOKN1hRdUUvwYL84BzorkCc+yC?= =?us-ascii?Q?OlO+WGeiHhCJkt8dnivsmgd16oTkKd9cJf3GGBTJStZJRN2fLfc3wtRyQ8MC?= =?us-ascii?Q?8ZNNQebWUtj7wgwsUPIgqyzTx9ucUHpYSsqUHO4viItg2JqjMeQFW8OppaUx?= =?us-ascii?Q?jO85/QzgNIyPtrw8pxdvKJGzTEzNLPRDiAtLytql5BNnDqfpYjYVpHztlOyu?= =?us-ascii?Q?bXGCs/S0QgjYj7+oW8grGwKnYqmVy1Awn2sofFUVkuk1ptTvczs+44EcGG3f?= =?us-ascii?Q?+AgQu75Wxw4yDKS+J2csF1D7fXCwhfppHTsnsyAwTOBDjrSpFnV2BRXZrXSa?= =?us-ascii?Q?nJwbz2DMv1NsjYuqNEm798nIix0r0zkv4T8xJtaOKRBT33ohrNXGDN+9KbFF?= =?us-ascii?Q?fN9p1caNwo7JlMP0PczSvGVhDYD9rMGB62dNN434hmOCmJrFl2H3AArnxqlH?= =?us-ascii?Q?lKxe7yJL3OPOaD4lT0ZJ7U+SBf/SmxY=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14f09c75-81d9-4430-57b8-08da2dbdd9e1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:25.5401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 53ZPeWUGm7ToLJV28680xZlAwY2tIUZrZnhRfXExpnFXPzSHvWC3IhUXowXU6IjJ+l3wiGg9HWzIw5y7PK8R4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2631 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1a::708; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673077486100001 Content-Type: text/plain; charset="utf-8" From: Dragan Mladjenovic nanoMips ISA does not support unaligned memory access. Adjust DisasContext's default_tcg_memop_mask to reflect this. Signed-off-by: Dragan Mladjenovic Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 6de5b66650..5f460fb687 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -16023,8 +16023,9 @@ static void mips_tr_init_disas_context(DisasContext= Base *dcbase, CPUState *cs) #else ctx->mem_idx =3D hflags_mmu_index(ctx->hflags); #endif - ctx->default_tcg_memop_mask =3D (ctx->insn_flags & (ISA_MIPS_R6 | - INSN_LOONGSON3A)) ? MO_UNALN : MO_ALIGN; + ctx->default_tcg_memop_mask =3D (!(ctx->insn_flags & ISA_NANOMIPS32) && + (ctx->insn_flags & (ISA_MIPS_R6 | + INSN_LOONGSON3A))) ? MO_UNALN : MO_ALIGN; =20 /* * Execute a branch and its delay slot as a single instruction. --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673088; cv=pass; d=zohomail.com; s=zohoarc; b=RjSt8AGGijC8QSkozPyyQfFEW/Gtb8UDB02k2dP0OtptHj//O7n1nlKOoCVPzKbxD0DOaHC+FH/sVxAsIugkaSRKZD2nmo9d4t9JegJ2iZRP3bbkhsWJzOu26W51bgPsCeRa7D9tNQ5uKjI/99Zs4U15+s9DXU/gQ+yHsPtFXDo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673088; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Ktf/CYDPPZp1t7KMKK6DoHL3nW3Baxiiib2OyTyzXUA=; b=iyjW5BhH02eHyHkmppQQOd8kHP2ZcqcvPSWWFy7APajwS96tkYcUL8KbKdJaGrSJvdzGZWMy/bOZxUNKEHlBQB1rQ6EarPEf+pCfjmou6B0QBIM5ANq4yqxgEJtt21ycIUVcRaY4y4TEZyJ7ThxHdhDjwxc9f6VTpa0a7cMqePo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673088790202.5259634768065; Wed, 4 May 2022 07:04:48 -0700 (PDT) Received: from localhost ([::1]:53488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFcV-0004S2-OF for importer@patchew.org; Wed, 04 May 2022 10:04:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoe-0001YA-ED for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:10 -0400 Received: from mail-db8eur05on20708.outbound.protection.outlook.com ([2a01:111:f400:7e1a::708]:59233 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoa-0001El-UK for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:06 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DB6PR0302MB2631.eurprd03.prod.outlook.com (2603:10a6:4:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:26 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEiTXVfhZzc8Xvo8QhGvnj3EyuL2sroUcVNqvqcdg5YVrhPN+oAzEt+fsDgHwPfs11bCPyTZjg+xh8lhVSHY8j4QAF3EJkbT6lFtbD84DJoAPRGbVezpcI1AcGurjE1s+oC6CEQpLs0rRbuVXF+Pot1LnEoB3/CxYOwPdU+SOEkfe412xVqefWrmPP/yFABniuKVWrrQR6VBHIuwR+oWuCerDux7zYfioU2qPJcYpMZwpfenzQNmG2VOqCyjs/1K/Qvwlgi8Dsr9GTX4hNMkvUMHQQJZzOa4uhcIwOXwcwhZKKpfpqv2jf7IvpLvacnDwsABoR9pwiRkWssDI8ElZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ktf/CYDPPZp1t7KMKK6DoHL3nW3Baxiiib2OyTyzXUA=; b=YpCPXsrmJD+S/FRkDto7lpN8tnVRLJe56aEo8R84kwiGqk6V/nAHGdRc8M0q4dc5b9MTBi5pYZ/XCK2HqJ44ZI5NSIjQQqMav0Bt54tHqLsxBaYsXFurPb/xJDGnkX/HbrQUApdbIQ8PjUT1RBZntny1uBew1r9G3B5R6hsAhvrvHvE8E8H19PS9XN1EC3nJw3EyI3W/Kpax4obINLrx1Wso/Ih9A09orop/n5gsZJzNF/OX8sz5fMedx0g3qS2BsTY8YQ7FSXA0fUIUr5SRShTRscipgs7WfXzD3eDAnncSm+oen6G5b3KsyXTOo/H0BWpBKBV4EbSroL4h8KTjqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ktf/CYDPPZp1t7KMKK6DoHL3nW3Baxiiib2OyTyzXUA=; b=MaQ5XOWCfzZ8oxNBUgExm+6FP/auBJUBcSL+OwKlrGvBeH9jrknCbKL2wk14dTRPGE8xoazJ5mXLzUb65/ZVKHIRA/ekcf0c8AE9Bc1LeAIttyp56tGnKWdrH2dMO+XeyuF9zBqht7/RNoGgRLeXYSrSZDzshffYIrOG8azGi4U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Stefan Pejic Subject: [PATCH 6/7] target/mips: Add missing default cases for some nanoMips pools Date: Wed, 4 May 2022 13:04:02 +0200 Message-Id: <20220504110403.613168-7-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ddfc7ae-1ddf-4e7a-c4e6-08da2dbdda72 X-MS-TrafficTypeDiagnostic: DB6PR0302MB2631:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RGmVaH3+qxlPXPrXWZExCfGsJkcEKTCoKuATGmM9bATVLniRrqa/4LGXfrSBCRiI4L2/0V3W+s+D5vV65UwnKP0CpOKSLCf6S8zBr/BLnzMh3ggLMW16AoiGJ3XXaMExQikVtzVqyvVX5LkmZVgrAppAXotH91Ve2KxJUJILhmdU8ptrdSG76U8j5Z/6v4qHa4y4PkdT/ixIsv5FfXS6y0Y41Ib36aBYgMo7GO/PaP2qqLNqCXzLVpOGohv3SsJHjgEfEo5ZqUTWVG6fF5KaRGbYSeMpi748fXMy288WrBH+UZcIru/TTob3I1t7QEpAS3UUaJWDutiY0s8L2cwBC29b8fQ+MIyRbPPs7HCvSaUqBBBpzRoj96D7xAxIe/ilHcIh8alu3VQ5Ibncj3+g+8+rXPt6RG17uZgao7Hl8etxbljMjtvIuakALjkU9Tw3kyE1s0BarPIGrbEdKGv74HnD6UE5p7va84/Rghym+YvGDTJtvqEfjvWWNbS9bKnhcM8Et7A4jU57Dq0Z9hAAWQRDEoInlSkf5IvvJSt63AGglmPy6d4KBLTX8H8KBU6nfBRUoY7eHTbta/Hbdaz9i23hqcRR5aLmIdtaHL6b1F3wuFvFM/hwCsDeBdTwOmzBI+ZDieuszpRShq8u3WRQWG0hBAhnUaCvYXXLdA1G2FdBN0NPhW2UCwxQy9v39qM4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(346002)(396003)(376002)(136003)(366004)(52116002)(2616005)(107886003)(26005)(6506007)(6512007)(1076003)(3450700001)(36756003)(2906002)(44832011)(8936002)(5660300002)(6666004)(86362001)(4326008)(8676002)(6486002)(66556008)(66946007)(66476007)(186003)(6916009)(38100700002)(38350700002)(508600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WxB4Wvs8XTPbsMjxV5vMbYyC9rZ87blTCj7kx8zHtFZ4nqm1OAo5z1Qb+aGj?= =?us-ascii?Q?mCwKgo/oWLX6wwJDFnbucD9duNjZ2Sxnk72LIRfx0IgEJ4SMK2o8PAWADNOE?= =?us-ascii?Q?ppGPGyIAV1RIK+84lx6tG89tOOBEs0YeWx0mIClXnitXJc/yz5XHK0CIuNBW?= =?us-ascii?Q?v9vNmO4AMbqwcDPp8330NK2nWPY9Rl3MJTMOz28amuIQ/uq6GBXXn+3xuYfd?= =?us-ascii?Q?vv3Dm1hRaL3NZI6Mf5jvGX0/Hr/E4lWLIkfsMJ2azzZP79VC4wF5rgw29q/C?= =?us-ascii?Q?gjZrpWW/0RfJ/kcjJWgvLVJUeWPXZf6RLCFUTJNDrXwKSrgfGzdHyUbVLRXF?= =?us-ascii?Q?W4y5MOASFzbuRskFyRbIvHkYmmzGGA+iQRnni79FYY7VGT1j9uYwZcHuY3N2?= =?us-ascii?Q?xLl+FXGFDKRFF/egoaY5KrbqhKxCZfZOf9XtZRO1IQYwEYAAB94wVwrWUtsP?= =?us-ascii?Q?rNWO+jiLfFH+Bl3URTGR/piueWTDPcui6CWADqjeM9eOHP4SGl0ae5ewqBwe?= =?us-ascii?Q?aNQ+5FdxnHO+h8UE4abM9WE2vqAUTH12W1BGMkqVfM3i7DJlsfQgyF9KWOXZ?= =?us-ascii?Q?AR0Sgot3ar5puBkqaZci5rr13nhvxo+YGvbMjvsV+E8lWdPda2WrEpZGFjHy?= =?us-ascii?Q?oDi9aOJETeld4cFXvV9vTfWX+Mp5CAzVmDoq3b3wn2z4HlBgcjm/XRZqbiwL?= =?us-ascii?Q?0G1phvm7WhL42DibeSnMlf7WqYBN+SJP/2234uR8Xlk3lCUfA/t+tw9wYbrM?= =?us-ascii?Q?tNFo4GAJqe77sEwFw7U9cbiCmSgyzoWvyJnDrlKQxL6s6MEcPSotGyonfb3I?= =?us-ascii?Q?hMjbe5GCnnLMIqB2aQLC/uf0jtalLFtR9+yFGnxRCzYdPQSkK9YcTvjOtDjk?= =?us-ascii?Q?6hN1SjQU5ydEmyS8q19rW3Lx1axg4P7vkhF3MyaHb7d/QhJqN6wGmmpsh23F?= =?us-ascii?Q?8/53rkXTeQGzC1LZzGJ9a7KqEMigU03oJIKEPHNGN048E2OPHJjg7Py8Bw4l?= =?us-ascii?Q?mfmY9iK/j+f9Gcvq+yeBGciVhCs8bY5vOQ9mWkhuez3Pt46MYyGSUe1+eByk?= =?us-ascii?Q?KuKeiwc9OmwS5Dd/oEi1oH3j8pGbQ/ssdXJqMddSVgUoBZ5+tkrwsHs+owX5?= =?us-ascii?Q?o/hOMCV6QwUTRZ9yoBEEC0kDqGEYGuenfu6qkN2uhnU13atZHvoZnU8zfCL4?= =?us-ascii?Q?WdHz0HOkq+oLpToh/rN+xTcwP+N250w0fvOzIID2PiIX5J8RvHfT0oIDxIK5?= =?us-ascii?Q?MTtvmAjLPZ8I2hg69la+ktN2+Ei71UoM4M2KMgHDZOa4PW5hnSWDiKSPvkFS?= =?us-ascii?Q?BiL/M56DcP3b1NVqX/1SQbVtTc4fUfJxlLf2WEmhFVlJlrSHj+lvYlah7m1A?= =?us-ascii?Q?95d8qS9OZYpc0Ux5xhUlRROhMnzLPGQehThONXRJzAWWxnt6KOgRPS39yUjG?= =?us-ascii?Q?or7ie7DCFS3pK4tFVjmmfZIo7CHc/dtQGqQl55B8fxVRdxXCZr07Z0F0+tjp?= =?us-ascii?Q?F6NycY5AOcAUb1/NkcMD8ls4xtep6lH5N4hEMCocCHw7xCcOV7zgL/n0TYWn?= =?us-ascii?Q?8f1s8e8195FjhXVc4sbxNuUDaSssNkD0fNZrQLB52TA4B96SetJZR8hwlcR1?= =?us-ascii?Q?Gak1zbRPywl8E1PNSf3xnAynAQLF6PUqI+LRW/n/az95+MLNvsA4DLN/L1rF?= =?us-ascii?Q?9D4N5VN/LlmdFfK0lj78m88VGrUFoT17+54r8tsUth+EgWEIG9MjW0yr2AOg?= =?us-ascii?Q?G8AyCV11FTA6FOSnIIJ4tg0qBx+tuxw=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ddfc7ae-1ddf-4e7a-c4e6-08da2dbdda72 X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:26.6182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6gaAoE15DKaoaWktmeY7WaMyt2oRlr2rJknAlxT5LrIeszeVJd0EkebRuMDY//+DvawWl9SGN0R6fjHRv/05hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2631 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1a::708; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673089675100001 Content-Type: text/plain; charset="utf-8" Switch statements for the code segments that handle nanoMips instruction pools P.LL, P.SC, P.SHIFT, P.LS.S1, P.LS.E0, PP.LSXS do not have proper default case, resulting in not generating reserved instruction exception for certain illegal opcodes. Fix this by adding default cases for these switch statements that trigger reserved instruction exception. Signed-off-by: Stefan Pejic Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/nanomips_translate.c.inc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 1ee5c8c8d4..c0ba2bf1b1 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -2707,6 +2707,9 @@ static void gen_p_lsx(DisasContext *ctx, int rd, int = rs, int rt) case NM_SDC1XS: tcg_gen_shli_tl(t0, t0, 3); break; + default: + gen_reserved_instruction(ctx); + goto out; } } gen_op_addr_add(ctx, t0, t0, t1); @@ -2797,6 +2800,7 @@ static void gen_p_lsx(DisasContext *ctx, int rd, int = rs, int rt) break; } =20 +out: tcg_temp_free(t0); tcg_temp_free(t1); } @@ -3944,6 +3948,9 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) gen_shift_imm(ctx, OPC_ROTR, rt, rs, extract32(ctx->opcode, 0, 5)); break; + default: + gen_reserved_instruction(ctx); + break; } } break; @@ -4245,6 +4252,9 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) check_xnp(ctx); gen_llwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3,= 5)); break; + default: + gen_reserved_instruction(ctx); + break; } break; case NM_P_SC: @@ -4257,6 +4267,9 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) gen_scwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3,= 5), false); break; + default: + gen_reserved_instruction(ctx); + break; } break; case NM_CACHE: @@ -4265,6 +4278,9 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) gen_cache_operation(ctx, rt, rs, s); } break; + default: + gen_reserved_instruction(ctx); + break; } break; case NM_P_LS_E0: @@ -4371,6 +4387,9 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) break; } break; + default: + gen_reserved_instruction(ctx); + break; } break; case NM_P_LS_WM: --=20 2.25.1 From nobody Sun May 19 04:35:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) ARC-Seal: i=2; a=rsa-sha256; t=1651673221; cv=pass; d=zohomail.com; s=zohoarc; b=MKUedSJMyYVqKbrdH2MqfzoNEEBWQ7BBAnlAIYIeRn+i3kvLVRzIjJ4rP+aYRnJJGgU6KdXwYVreMZDAe+5w0JSsh5H8B/3C+fqXvHAZ+cVjImgLPoHawp8ID/wrnMsJA8j1S1UHfvbp/cuSyPHYtvYl6Nn+wooJbxOlerY64zA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651673221; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ozRZWXamtvJBh7cPTG4AjBo+CJtW+2SxDR23pwlF/ik=; b=F4rev0OqgV34ee6cWI6teSN9DkjnHvVyiXN9wEUX73xGesRsbwFN5lzJZkSPMREJyQJyMwUvVXUFoVcH3PV++2o6uBN/cjShzzwYxjZiEPjuddNue9VSacILAIpVvuU1N4Uc3euzLNvn9REicNP9FJ62vSRBRMICZ8YY/uUSd2g= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=syrmia.com) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651673221657313.0071379356366; Wed, 4 May 2022 07:07:01 -0700 (PDT) Received: from localhost ([::1]:33782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmFee-0001wG-3C for importer@patchew.org; Wed, 04 May 2022 10:07:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCoh-0001Ym-P6 for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:13 -0400 Received: from mail-db8eur05on20708.outbound.protection.outlook.com ([2a01:111:f400:7e1a::708]:59233 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmCof-0001El-Ex for qemu-devel@nongnu.org; Wed, 04 May 2022 07:05:11 -0400 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) by DB6PR0302MB2631.eurprd03.prod.outlook.com (2603:10a6:4:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 11:04:27 +0000 Received: from VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463]) by VE1PR03MB5501.eurprd03.prod.outlook.com ([fe80::f0a0:695d:75c8:b463%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:04:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfC7dBGkqji0Q5TwawsN/YV5RhESXa+HqE1qHLG81Gi1jTdQQ0io3dNhaoGWtUCJQv4gSUjNQv5+Vf8JZJPIc+xOCt+nMD2rEHKNKGZu/scvK8IUb3rmS8gfTH5/u2XPnNhBWIuhXCkQod8Y7Xj1sHv6yN+GpZOLaQ3h/GfyeFbwALJ8L7vCFAb4KtRIjvk2jH+6i4bYg+N5LEK7VI6ECPq957QOM8V8XfPwHqw+fR5z8KZMWbqD1lfQmjFR42dNCJelzdzIpJHR+q5NWVZDVXeoLyvSkzpBuxji9hGLh0B4EOq7zM09Z798OmdhkFYKUkQoyjgRZRpKEdJCT7KQHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozRZWXamtvJBh7cPTG4AjBo+CJtW+2SxDR23pwlF/ik=; b=h6BAUoD5XKiwXNjFa5mTo+xfz/lBocC74kqymws2ifpyIFf531AOG/ZQuuRn4q1B+HhrAXPjZVX+EzSMIZ1Ji74FlyGqCq+2g/AmgS1lYl2zC8OBhTryhZ0hvDzYOEoQa2INiiU9skngcm2Gqtaof7MjnLnwQfHz2DktL080qyx5F2hfU8pEiUDdLkvSi+GqOZvui/elSYV++YXj47PCNFpg2LskB6ITPzVAGBS/Di5/ShpGw2siEnQNupyVY8p880Xo43HfmCVHKmQrdAB+AgXZu+iT0v9qL8A7CIfygl1Pzwp8nN+IccXQUIfyDMzMbb6vUFTuOQNKpiA3oh9yrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ozRZWXamtvJBh7cPTG4AjBo+CJtW+2SxDR23pwlF/ik=; b=lJ59z1cAE0kp9Qgtl+5A6BOVUdp7SOZBR+OyzPFLShS+m5+fsMtFGRwd4AHtprO/wDhhgum2zCIoUevz1nY5SU3m+7W6jOVKeYCUuaZmbAGlxE3nSYAfMHuRoywJEbQPuQdAKdFLexhZlxFMM/zPEhntqFL5FQbppoJaU0Ae0OY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; From: Stefan Pejic To: qemu-devel@nongnu.org Cc: ot_stefan.pejic@mediatek.com, ot_dragan.mladjenovic@mediatek.com, Stefan Pejic Subject: [PATCH 7/7] target/mips: Undeprecate nanoMips ISA support in QEMU Date: Wed, 4 May 2022 13:04:03 +0200 Message-Id: <20220504110403.613168-8-stefan.pejic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220504110403.613168-1-stefan.pejic@syrmia.com> References: <20220504110403.613168-1-stefan.pejic@syrmia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR06CA0132.eurprd06.prod.outlook.com (2603:10a6:803:a0::25) To VE1PR03MB5501.eurprd03.prod.outlook.com (2603:10a6:803:11e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fc2193b-672b-44da-7fe5-08da2dbddb12 X-MS-TrafficTypeDiagnostic: DB6PR0302MB2631:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g94YdkR737lxhYdzfSYtVxVOAScEC+E1A/mccyw4UR0R5Ki3Jfgfcjph7+1E4B9DvDDGParPW48ZfPAsD1qUR57/QzTjrRdrYdtMLTBCkx9Y5/psewO9ZoGo7mPLT+xj3hsxRHmvdR3AwyqCp8u7jKGc/AyuHvtrf9RXFTe5a45LyIQvCXWNZkYrpo9yQhtbQY/Z83uM+iTqcae0JhoXQOMPD8Z2iWX/9jTTeQQxyZHyDk1Y4faPuNKWnDRVWe1nUKZQFkuR2/OFhq4rejRyss+VDJ4tcdpEvAHRNbf9csnYQ/35cjpJhUPRyN6sawvyaf86TRY4YnzvtUtkfLGMuRYTuJle3czrSZT5gfa2a9aJEYMxdo4Z22gUKxmYB1m8nkQHfdsAbdtVHCdd+D90lPp+NcJreK8Nji0u3jOg9V6S1fgwhPtC1uKsGt036MvsbVK74XtZ2M4utDhv+lPzowFr5ZNqug6CEr4WDBzkbDMyYYMesFXrl4OuG3/ahoqRv8RAtU/STc25O01SnJr7T/71A/LypMOVqh58trIL9GIaRf7m1D5Cp2Q068t2MkWmD8qts0B3pN+2H1nPYvj0TnFjBp6bPmIbFo08sqhq0EfrHu2VoBHQMk8TsQjW6axt4dPXWhVyKL6YuCTsq6ewAQzgMdfIQkmFYJG7HTkKuBx/E/po3CY+YMkf/SZnkLC/i0No2h5Ic9M2whM5kuwmcA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR03MB5501.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(39840400004)(346002)(396003)(376002)(136003)(366004)(52116002)(2616005)(107886003)(26005)(6506007)(83380400001)(6512007)(1076003)(3450700001)(36756003)(2906002)(44832011)(8936002)(5660300002)(6666004)(86362001)(4326008)(8676002)(6486002)(66556008)(66946007)(66476007)(186003)(6916009)(38100700002)(38350700002)(508600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aTy8gRs2eu2+dMZh8+VpvJtC5AyvRBIL5F7JZO21jyXVKtHnO0cYn9qbyzNr?= =?us-ascii?Q?8uDozvo+nJS7dCPsEnDPZyBpBg3ZPQP852Iw+l93U20JoRgNRbcunZORlsdc?= =?us-ascii?Q?N0HiGyiRz70SdntEFZEI6DqFu/w1T/ZDLTltpQ3EpYJTLgyRfBeK3UYWtHgn?= =?us-ascii?Q?DQQyD2cqh9E6TIJ6iYvsndTujYayVvUWyN8krCP3WBMVFqsI3sCufiAapGib?= =?us-ascii?Q?xkxSI0xj05q1DfjYQfP7mj3RLRArT92OzynPvLKOPExRwwK8DRikmbaq6tSf?= =?us-ascii?Q?q5NlfkFzKsjO2eb7AUYqoNpHT2rOt+Xzfjv/pvo9UQzc8tKT+4iwVtxPHlKB?= =?us-ascii?Q?GvR3rW/EQd9bpyLxd/+0Y5gFzLkUVSDUjL7ex7IzEHFaJo9s8llA+lYzqBO5?= =?us-ascii?Q?hw1RfgJuwtwk7Nglx87RBblKswyQnvLgtcfBnfdD2lNOvkqioPTsIyh7UT50?= =?us-ascii?Q?0cwKQxqfoCyhjC5jfGpgmObJBV4SkEtNoPG71Quz3O/7gaUX9dYCjBOIswuJ?= =?us-ascii?Q?nT01w8TaMbPeXZ3a42tSE9IX8loS8/QDOYt79euO9IX3MyoWdJt7imCtemmQ?= =?us-ascii?Q?Zg6nsEokQOu8lLr6pfS04A3g/3cwRnRFlcOJqLwgvL7IuSRbuGkOWYUsY6hL?= =?us-ascii?Q?x1M7MtFDX2/kRFdSiuC1cvQRQDcfRitaYFuwN5dsfjanQp8Uel8WfU9OX2vy?= =?us-ascii?Q?ETLxE8pix2ad7msuPUWKHR7QUBU+ZLj9siMxGKqB4NxRC0txQSxEYBhedbqc?= =?us-ascii?Q?5qrjYBa9Xec9eypqRA4dJnnpbbJ+xlVQMEzGzkNdGpiFeulStiD5ilpD88OA?= =?us-ascii?Q?DgT5azURR+Wqx82nnhRWkK5m4nkiRI6zIcB69epA+pruZ4MgRxL8pcAVjZD+?= =?us-ascii?Q?TtJGai8FNIDi0KddVzm71UZ/BftpkxdMyu6QrgKeaxSUwtsCyTyB8ywPviMb?= =?us-ascii?Q?4fDACriLsUxhPqwSgfCkaheoyHnPX1guCsGkAINTHaOUUpU0RvwDhISMCTBT?= =?us-ascii?Q?U87Xgd/AvB11Hf4kUNGUOzucrsrOMktUY9CErCkOWSv9oQiWdYcHPV3wIR0p?= =?us-ascii?Q?M4l0rMoJM7innoojGNV27pbErt5JEAKzpVRt4NZUFGEo0HK35KiCO6orUJbx?= =?us-ascii?Q?AeWF1SERjhn+bGisq9O/mAWg2ObkOuLqPvWY/V3RvXleVD5Tweq2zT6DuOb4?= =?us-ascii?Q?Y4hIg6Lp7DGM8irutjnO73L0rtC+4Arcl7SPkk9hkiBBuWAEabbICq5ac/5N?= =?us-ascii?Q?hDLFYeK6jl5hTVu6936xjHke70+kc67HA/Jn93Jy662AsEPZd9+XbOSXK3QO?= =?us-ascii?Q?+zjwRIE86szHNAGCO2pwZyfv/PN+wryNz4G94y/wIQh21sdflrK6+Go7Vi8p?= =?us-ascii?Q?NPnge3Ewop91BS3/vbw68Ocw45fj9OrijR9k6gHlK98uWw4CV6jIr4DJKDxj?= =?us-ascii?Q?/OAMM4POPPlFGHb2e9y1MrGyfwRWhRHwWB3umfuJMlXAzpRcrJ7q+rzzVkyB?= =?us-ascii?Q?5B03xfFs8DIFhuIdzzDRetAu2t27YnPx3HxImxKNLaik/MHUOMdtyO58UEwB?= =?us-ascii?Q?fUzY5Y07rIKVOEFcPMs+a7KD6EAo091NQqEMLuCGJaxwnPlrkhu/5azKUEjh?= =?us-ascii?Q?JxjcsfLdkFxa8DbjTeKOW/HAbXwgcbOy5xQQe7W8r20UUBkhGo8h514n6NBz?= =?us-ascii?Q?EsqBZj4+VkTTSUkX27y1A0HR5b6ySawqsSUWGtvNcL/FjxJJK4SSWVpLDu9f?= =?us-ascii?Q?Aarx1BGohllUNaahEfYYF/xiPPn7VDk=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc2193b-672b-44da-7fe5-08da2dbddb12 X-MS-Exchange-CrossTenant-AuthSource: VE1PR03MB5501.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:04:27.6494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rMeXYaWI/bP/Bio31hZUuCWm9gzROHjmHuSjWdmou4ztP158eBCMbfXmMH2qgPbqZM2P50o/l1NZsTGSPw5lgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2631 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1a::708; envelope-from=Stefan.Pejic@Syrmia.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 04 May 2022 10:01:55 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Stefan Pejic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @syrmia.com) X-ZM-MESSAGEID: 1651673223149100001 Content-Type: text/plain; charset="utf-8" nanoMips ISA support in QEMU is actively used by MediaTek and is planned to be maintained and potentially extended by MediaTek in future. Un-orphan nanoMips ISA support in QEMU by setting a mainainer from MediaTek and remove deprecation notes from documentation as well. Signed-off-by: Stefan Pejic --- MAINTAINERS | 3 ++- docs/about/deprecated.rst | 26 -------------------------- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 294c88ace9..f1e0dee8a2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -240,7 +240,8 @@ F: docs/system/cpu-models-mips.rst.inc F: tests/tcg/mips/ =20 MIPS TCG CPUs (nanoMIPS ISA) -S: Orphan +M: Stefan Pejic +S: Maintained F: disas/nanomips.* F: target/mips/tcg/*nanomips* =20 diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 896e5a97ab..4b0868886f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -276,13 +276,6 @@ System emulator CPUS ``Icelake-Client`` CPU Models are deprecated. Use ``Icelake-Server`` CPU Models instead. =20 -MIPS ``I7200`` CPU Model (since 5.2) -'''''''''''''''''''''''''''''''''''' - -The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated -(the ISA has never been upstreamed to a compiler toolchain). Therefore -this CPU is also deprecated. - =20 QEMU API (QAPI) events ---------------------- @@ -382,16 +375,6 @@ The above, converted to the current supported format:: =20 json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"} =20 -linux-user mode CPUs --------------------- - -MIPS ``I7200`` CPU (since 5.2) -'''''''''''''''''''''''''''''' - -The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated -(the ISA has never been upstreamed to a compiler toolchain). Therefore -this CPU is also deprecated. - Backwards compatibility ----------------------- =20 @@ -421,15 +404,6 @@ versions, aliases will point to newer CPU model versio= ns depending on the machine type, so management software must resolve CPU model aliases before starting a virtual machine. =20 -Guest Emulator ISAs -------------------- - -nanoMIPS ISA -'''''''''''' - -The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain. -As it is hard to generate binaries for it, declare it deprecated. - Tools ----- =20 --=20 2.25.1