From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997600; cv=none; d=zohomail.com; s=zohoarc; b=IZ0e2d8zg9j7hH0zz7D//M4YwSN1NddBODgMqdud5jjPbh1oYFlrIQwWhom/CSmJlM9+/Sm0osVNOBXA4XyN+cLNa8mMLkInccuVJNLzuLBMQmSPgiQ/+Y5H0/JYJItLYco9i53huSYWvbiQv6EtVywtSqA8yj+GM90M/HxvlAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997600; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=meOXfrn2PD5m0Qh1cBNLkWBSrBP+MRPsiz/DUB3aYZo=; b=JQPncz7LsjKvPYECkS3Ef9j0CyMrw+ptTUM4T8uSLC0VKMIb7ZS3cTU3EFQ5p3+0Tmfqwj3YxmHa6ufz+gaOIom+IfxHy+fhmJTJ4CmWr6yGfRsf+HFsjI5NGiREx5A3v9z4hlvvdGCo0IYOLthzAYJFOf4RN3BtbfoJkFPLpJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997600731618.958575724611; Tue, 26 Apr 2022 11:26:40 -0700 (PDT) Received: from localhost ([::1]:60846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPtX-00068p-8A for importer@patchew.org; Tue, 26 Apr 2022 14:26:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmR-0002St-QU for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:21 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:56259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmI-0004JH-PE for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:12 -0400 Received: by mail-pj1-x102c.google.com with SMTP id r9so2157632pjo.5 for ; Tue, 26 Apr 2022 11:19:10 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=meOXfrn2PD5m0Qh1cBNLkWBSrBP+MRPsiz/DUB3aYZo=; b=loCFcVUOP72i9/F3g/GaoW09E7nfR/V6rEGLs6ufEqTp0S/B5pDYBUQKpgjj0XGEir JYOxMkWyUCJQrTOA7W1cfXgf3Ztk5firwe743j/bM6PxiNUoxRATM1/ksiS0kwq6XKce QGLNIo7WFb2yqTqCmgS1yzZzMwlmgW3RWmD4rBbT52wmvgl3j8t613kdi6NqGBmGfI4Z 9F3AT5Zf9zOgbXqH67860g5sT8AHAtrCe3x30jOS3wfyYc9xKCGih8curP/1sr1xN1g+ vgTz5VIP8YUIkXVISSeVjLxdBok4a2wnJ3CnPayeP/LwxsoVlSerarWtUhenM8GPnFaU kEdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=meOXfrn2PD5m0Qh1cBNLkWBSrBP+MRPsiz/DUB3aYZo=; b=Db/pnwXTckz9ugC5xMhDHKV6ZE0RSh1CviRaHKutfjVT/8zOYlIYSEeOwiy7SwPzkU zkwBq4zgxbnpqFVe+cppEdUzvUgqygHs95sgq5YwoVlJWa/zyXxvkUTihz+DOhrF+Cct yFfem1/wXZ9c9gpB+d7yl8z7t3l9pgnksyENgeOVaFbYBYyEraKqcG9m/THY9JXjhXzO IM9Gge5n6cIEurVnzOlNLUpZfJPUpwUwnPL5cxPAy5Xl2ODJ1bnP0lQ/bz3Qv5xZ6AGJ qSlOrj9RlaSV9RBltGHuxm8A2jKYNfObAIacdIxVHXv7JdNqLLqTM+FZo+FdqEAFH9SF 2mZQ== X-Gm-Message-State: AOAM532CLBKMqGulGK1j0AIMosX3+p1DMEQUfNESMkhkI1bJfRDfKqsP KF0Iv3mcyU5WAbKvKVSiTX/MWuzC+Yt5Xg== X-Google-Smtp-Source: ABdhPJxgKjzfkY38aQLGtqQDdp2dsmnS/FY4LdlDqkNMGe9W61K8XaRSQ7Rpmo6f4LsYcrQY8qky8A== X-Received: by 2002:a17:902:f789:b0:14e:ebbc:264b with SMTP id q9-20020a170902f78900b0014eebbc264bmr24158710pln.169.1650997149433; Tue, 26 Apr 2022 11:19:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 01/68] linux-user/nios2: Hoist pc advance to the top of EXCP_TRAP Date: Tue, 26 Apr 2022 11:18:00 -0700 Message-Id: <20220426181907.103691-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997601821100003 Content-Type: text/plain; charset="utf-8" Note that this advance *should* be done by the translator, as that's the pc value that's supposed to be generated by hardware. However, that's a much larger change across sysemu as well. In the meantime, produce the correct PC for any signals raised by the trap instruction. Note the special case of TRAP_BRKPT, which itself is special cased within the kernel. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-2-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 1e93ef34e6..2e9296750d 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -40,6 +40,12 @@ void cpu_loop(CPUNios2State *env) break; =20 case EXCP_TRAP: + /* + * TODO: This advance should be done in the translator, as + * hardware produces an advanced pc as part of all exceptions. + */ + env->regs[R_PC] +=3D 4; + switch (env->error_code) { case 0: qemu_log_mask(CPU_LOG_INT, "\nSyscall\n"); @@ -56,7 +62,6 @@ void cpu_loop(CPUNios2State *env) env->regs[2] =3D abs(ret); /* Return value is 0..4096 */ env->regs[7] =3D ret > 0xfffff000u; - env->regs[R_PC] +=3D 4; break; =20 case 1: @@ -69,6 +74,8 @@ void cpu_loop(CPUNios2State *env) break; case 31: qemu_log_mask(CPU_LOG_INT, "\nTrap 31\n"); + /* Match kernel's breakpoint_c(). */ + env->regs[R_PC] -=3D 4; force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->re= gs[R_PC]); break; default: @@ -99,7 +106,6 @@ void cpu_loop(CPUNios2State *env) o =3D env->regs[5]; n =3D env->regs[6]; env->regs[2] =3D qatomic_cmpxchg(h, o, n) - o; - env->regs[R_PC] +=3D 4; } break; } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997651; cv=none; d=zohomail.com; s=zohoarc; b=M5xT9nWHJA09yF1a520jCyQ3rRNZHtuWZlOeEz4JvQc3L+tURCVmTVAMG4pSO3c4W9I/v3na8Vvs5d0vgjacXon0KisfiRLZQHn5ZKzPrwBGNKZrNhKYG0EN31D7s5vXfrmX2cWGuG1fBHVPGb5zBwA5qevFLJcDwZTcpbQn33w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997651; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Kt2BBU1GUjUG3/EJVuAysOFujg46su8Ylz5CGCHbv4o=; b=XuDqJqPyfYgL0SiqNIDPxQSclY6O5QQBNmYCOwroi/GKX083y/mseQ6+YkTzHAO97JZNfOsJ9iRXg83wIs3px3n6/A8eOQB2KRuTL+MgwCDYauBTBvT05z4clPgpm6jolQqhnWemKbkPqhd56SDoLowh+KvUcxk1omFg+yVn+pc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997651772719.9491336191046; Tue, 26 Apr 2022 11:27:31 -0700 (PDT) Received: from localhost ([::1]:34842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPuM-0007eG-At for importer@patchew.org; Tue, 26 Apr 2022 14:27:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmU-0002Tq-TE for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:23 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:37597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmM-0004Jw-4E for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:20 -0400 Received: by mail-pj1-x1035.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so2860306pju.2 for ; Tue, 26 Apr 2022 11:19:11 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kt2BBU1GUjUG3/EJVuAysOFujg46su8Ylz5CGCHbv4o=; b=icXI29fQFx8EUBPE1kG1591sIHCEXjgHIWgbv+lliGGI6NT25+GafN5FA0R9kR6gWs vsoLI+QgubqRRfoy8sIgWwb22F1rr8QKbGVw2sU2SkDaCEXevqSVLBYufcX49xgte3H3 t5pAv/W56ltJpY95OU5GAQ6MMa1up4UUxsQpRYxEDGUGkpcbZrp7VmtaOgQQ/c2Fx3Bq ZmisXFyaR4s3huI4Q3zwNktkws6K+vXW0QWz4LwCJN+T9sMGC+fqzLQpSyBjaXcQIwN1 Nu65ee8aN16ac13MD1SWiwnenFKxEya81aUV7OTcUEKtLaUYH/YOc2L+wLrjgKYLgfmO IS3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kt2BBU1GUjUG3/EJVuAysOFujg46su8Ylz5CGCHbv4o=; b=Co6ivw0kpgBh/PA3sG7FHnX1lgcB3QNmZfNN4Ke2R4Iq+/+k4zsQaEcVx+YDbQlEd7 HtQQGOFSQ5V08fS7O3FIbHRpuobPdysN0p1MgaUEd8GEiSF0nps5LHjaUvMylDZLZjUA qJmCTH/RfhanE6V8s7DDkiY+ei/w5RBsTU5K1skASGTUCxH1SZS3Tz6tx+tLh+eLcT3m /NbRfy9HbBNZXtLSLXlx9D/BHaJGE01NlQfrPYm0Unf/Vyx9irXUByhe6MylWJ1Bes0P CWCDQvYxd5IlzXbIL4Xkw+BIgaYTGnsEbpyDUTxVcJ73rmBC3HyI8P2R1nPvhAfh3TtZ rP3w== X-Gm-Message-State: AOAM531YVUWQKklzOA1YkBKwqAoDWUWXlSQNvfPMktHk1DAy41GkItTG X1qVyhi3Vca2VR7aXSetllxD0FI/qytSJw== X-Google-Smtp-Source: ABdhPJzwu3yGAZhBPSU2P4umv1cjy7RSQBQrvXNsk4s9l7jP3gJoRD8LI/2UDEzkdf85DTDX+62KQQ== X-Received: by 2002:a17:902:aa8e:b0:158:e94b:7c92 with SMTP id d14-20020a170902aa8e00b00158e94b7c92mr24696786plr.126.1650997150521; Tue, 26 Apr 2022 11:19:10 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 02/68] linux-user/nios2: Fix clone child return Date: Tue, 26 Apr 2022 11:18:01 -0700 Message-Id: <20220426181907.103691-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997652237100001 Content-Type: text/plain; charset="utf-8" The child side of clone needs to set the secondary syscall return value, r7, to indicate syscall success. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-3-richard.henderson@linaro.org> --- linux-user/nios2/target_cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/nios2/target_cpu.h b/linux-user/nios2/target_cpu.h index 2d2008f002..830b4c0741 100644 --- a/linux-user/nios2/target_cpu.h +++ b/linux-user/nios2/target_cpu.h @@ -27,6 +27,7 @@ static inline void cpu_clone_regs_child(CPUNios2State *en= v, target_ulong newsp, env->regs[R_SP] =3D newsp; } env->regs[R_RET0] =3D 0; + env->regs[7] =3D 0; } =20 static inline void cpu_clone_regs_parent(CPUNios2State *env, unsigned flag= s) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998228; cv=none; d=zohomail.com; s=zohoarc; b=TWjYvP9faBhYhkkReQzqXzJrzB1AZoW1xgA9DvhP8yT3uNplbNF0DzdmVkEblR/VbjOgHUXEabOKsBVN0k1TTUZWebXXDuINBelO26w4FP+bAzO3+UFKmMCPNm+jAigIH+xhWJGqJYjCU1lRRl9Kmg9xBt1hvHzMq/Vqr+ASVgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998228; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zx3qhK8H+v+NAZcjuR7FBLrFsz8zqhmn66xWRsawstk=; b=fQPUW6pxdDo30SffMaqZiYSAtG94WNT/72VKSmID+tCdVh62gGYEhnVVARjGM+/VpEJn4DgIagBGHS+QjNbooyDehLmnYf69lCwG8Cno3B5a/aAB3WCmJb3ekCIih+BpbvLBSKbx4WOfQtGEUtkzzVh4fP+1GZ4InSPNM1fEXtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165099822893388.8640639397754; Tue, 26 Apr 2022 11:37:08 -0700 (PDT) Received: from localhost ([::1]:53608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ3f-00046G-Pj for importer@patchew.org; Tue, 26 Apr 2022 14:37:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmU-0002Tr-TW for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:23 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:38770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004Kx-Bg for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:21 -0400 Received: by mail-pf1-x431.google.com with SMTP id b15so18710559pfm.5 for ; Tue, 26 Apr 2022 11:19:12 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zx3qhK8H+v+NAZcjuR7FBLrFsz8zqhmn66xWRsawstk=; b=Los2CCnr84gMnsbx+7Z6MXkKYQZnXI4qcJAWwDYAa65uaXudqwT3/4PgLxUpWzKEWn 1Q3h5FAIBUbTpHJc4mmtSKvSoen3x7vvIg4JZJnIYLVGGafVhKvkwkiTUpRYt4jO9YiG Y+oPSOvAbYNfQ4siD9IwPcagaNu4equQGSJLLzOdA3F3wmmwrVK14+VSdU/P0mNQBN53 bjttXxpopAD9mODhguUS/n2M1tK0QSB/CxpNkMMvLbBpKu0heWDroRZLp+d1/mjfhmw+ pgaoIbJoYpOMBOrMzhGPNjFSqjeEcttCdKYTRagfdfXgJFhJjoCD0kvwQHiaRIVSQhc6 PS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zx3qhK8H+v+NAZcjuR7FBLrFsz8zqhmn66xWRsawstk=; b=0Jdq6XsbD9+WyFTyqUTo++Aqx+k9wEBynZb5MP+fTna8J5vdT7utwscLtjcgre2z2N sP5EAr02PuwbNHW0CqeDsnrkicY/aidLESdEMmcP4iSRkKbCPyYctd8z2HKXeQXuaDO3 avdc3yA1eF8VjU3vrmdti55/qcU363k5tB52Yu1YRPZpgi7wyhW9w+CtGO+Xe//v24g+ 4JRxrMpG1i3INUjRfi2Cdzn/Y5PanN0Q/6nIRg69bw5chLo/FShpcEEymCKam9fTMbR0 VP+nV33QOz3TTeG1e3FL4oT20u3AX5j7/PPoWDkEkeI+EdDEuxEIYYlNuDrBG4cBQ52N NJfQ== X-Gm-Message-State: AOAM530LV8HHjADq0D+J0UhHXNwx2xgwXVfOaQ0UitMCHq+Wjee3Txuo KS/Y9H6D1cnVgwSmNClBMGqFBuY2FIlhLA== X-Google-Smtp-Source: ABdhPJy/THLIjUD9+/Ta5K6QC3RkLQKYak6VLbOtGHDlgX56oiZlV6GbdY2DhtxHMEqiBeSBVGod1w== X-Received: by 2002:a05:6a00:1ad0:b0:50a:906b:807c with SMTP id f16-20020a056a001ad000b0050a906b807cmr25808498pfv.42.1650997151525; Tue, 26 Apr 2022 11:19:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 03/68] linux-user/nios2: Drop syscall 0 "workaround" Date: Tue, 26 Apr 2022 11:18:02 -0700 Message-Id: <20220426181907.103691-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998229822100001 Content-Type: text/plain; charset="utf-8" Syscall 0 is __NR_io_setup for this target; there is nothing to work around. Reviewed-by: Peter Maydell Fixes: a0a839b65b6 ("nios2: Add usermode binaries emulation") Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-4-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 2e9296750d..91737c568f 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,10 +55,6 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); =20 - if (env->regs[2] =3D=3D 0) { /* FIXME: syscall 0 workar= ound */ - ret =3D 0; - } - env->regs[2] =3D abs(ret); /* Return value is 0..4096 */ env->regs[7] =3D ret > 0xfffff000u; --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998133; cv=none; d=zohomail.com; s=zohoarc; b=msh7KvadE1Cnl94H2WRf0gQ0Ao4HphBvJILAk+nKQn0gzt0dENCoVp6RDoj//y+ahgSUCvaPHLN0MvOrorIQeYQMzwVaiE50k/LDeThlhnoyEcGjogfO3pvm3GyCXXZJnme0snH6kDp6ZhaK0oDZ/4CNa0wz2Ls55v4Kf4r36Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998133; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Cz85jXXNTXB185MIdFgmydKGclnlgZjRARJ6+y2fc4Y=; b=B2XSes6n53FhCp3Brv4aeQXNR91bytWSq5fvfuEUbttOlCxYttbMjcSYfnbR2dV8wmpIMTnknrTlbDhiAqWPBRIQ4xDz4GWMjtSKR5w6Q4NkJDMFo+FAD6tdmGi0jfdHDzEcfdvnUTjfu5KzvZZowePN/LlC6/4Y8J/LOk8LWI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998133626813.3725576851806; Tue, 26 Apr 2022 11:35:33 -0700 (PDT) Received: from localhost ([::1]:49728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ28-0001Cg-Gg for importer@patchew.org; Tue, 26 Apr 2022 14:35:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmU-0002Tp-SH for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:23 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:46848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004L7-B9 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:20 -0400 Received: by mail-pf1-x432.google.com with SMTP id j6so16380094pfe.13 for ; Tue, 26 Apr 2022 11:19:13 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cz85jXXNTXB185MIdFgmydKGclnlgZjRARJ6+y2fc4Y=; b=FP1MY99p6xmAdx+EPVzcnZ4AoJgvPHtHs5o6Ra846zjDuq9HdM3shz3u971zdt/ImU VQyNf2d9ycGiQq8KOn7E6fRQGELzjA7QV9/Yh5fNNstJ49dBz9PO5e/FawvWHZjwsqKr hMgcYD5S61oWcVXQsMsULrlxzbpXOmkJF4obYn9QAb0WuHiHX2bUERpm70CHucW2mWt6 G7QFiqbp2j+d1lLeNLwMRLR5XnTAlQuONFN2W+fKrLuA5oe03EaI3ROvqP5DWQ5hpRpr 2cL/imdMWJq5u/qMRF3sYyGHE4SFxH5yjGhv7GUiXL+6QwjFpI8kF7L8HdHjwmqjXBUX zjYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Cz85jXXNTXB185MIdFgmydKGclnlgZjRARJ6+y2fc4Y=; b=TOULU6JWzBTBnenv1CuIeEefdYW7Niy6yn7/w2BDMiX2AD0jbygCfYIHkYKcs611Ju mb/skhpCLeQ0D3Wfz4hFUG1S21K+md7ljzDcxPWHTbgjJ8ZTVlfoQzlBRlVSfFmAPK45 ZsFhOAxzhAFfElp2OWRM/q1VkDtcq3d0eMev5m2Eb8CJxA7gheDuGxh6mg4mZ6DNMsMx /SGhw026E0VUjbeDdGFhf/NA6TZWJ6kcssQeZuni4fC8uzGKe067v6eT3FAU6c3a/BFR uMXl9qNgiAo8z79rvvXHZTClMUhP9O0JK7rdG3twTJG5BWYR2iEgYOLqkR/LBylXvwSw u8Hg== X-Gm-Message-State: AOAM533JI712Z59SFFvsEhYijbmwvhE0jNz7vPZ7SBkoWZZx0U4hMuHC 51EW0ZByjis7kQUsu9LQ8EyXcIhuJtfSpw== X-Google-Smtp-Source: ABdhPJyFzcP9f33jtk7j2o3tqv8JSSkVNm24AAaJUqfs4/tUvXcgENGSjVbNFsD3llEDhdHz/dhzxw== X-Received: by 2002:a05:6a00:1903:b0:4fa:fa9e:42e6 with SMTP id y3-20020a056a00190300b004fafa9e42e6mr25683929pfi.1.1650997152488; Tue, 26 Apr 2022 11:19:12 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 04/68] linux-user/nios2: Adjust error return Date: Tue, 26 Apr 2022 11:18:03 -0700 Message-Id: <20220426181907.103691-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998135340100001 Content-Type: text/plain; charset="utf-8" Follow the kernel assembly, which considers all negative return values to be errors. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-5-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 91737c568f..63afba5862 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); =20 + /* + * See the code after translate_rc_and_ret: all negative + * values are errors (aided by userspace restricted to 2G), + * errno is returned positive in r2, and error indication + * is a boolean in r7. + */ env->regs[2] =3D abs(ret); - /* Return value is 0..4096 */ - env->regs[7] =3D ret > 0xfffff000u; + env->regs[7] =3D ret < 0; break; =20 case 1: --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998395; cv=none; d=zohomail.com; s=zohoarc; b=AP9e0F5FKbSUyIT41Jc6g/rwKdSzHyOTnyI650DbmYvIN/pD77BKLyAxaXMbyo+WnHv+FEivIkedVEki5d8R8/0q0mCZMjO4W/EnD1qxKVUW6clE5ufMmxUO1/nxWyz5A85JTDyx1la9zR/aCjb4SNIv3L1C4/c2HxlFz1K/eV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998395; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BaXzjQ4uHQf8aegyrwpNgla1ibfyULSXvI/9Vr/sAxc=; b=PCBO+Mj/myzrffXDIvllv2Gbny38ATcw1rBxZNPQQJYsqt3NVhRdrYvxvnKM6bYqA1E+zoRGJjuFSyA2LybkWOZA10DKaWzACxt5xg4pW9+2oGhcyYY2nmzvHbGWqfQWvHHy0AWfuQt6QNlYfjgjJeV+u5m2qxRrHTHrHNWTC84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998395515654.7257533010273; Tue, 26 Apr 2022 11:39:55 -0700 (PDT) Received: from localhost ([::1]:60132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ6L-0000L0-QN for importer@patchew.org; Tue, 26 Apr 2022 14:39:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmX-0002Xc-I3 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:43876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmU-0004LA-M5 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: by mail-pj1-x1031.google.com with SMTP id j8-20020a17090a060800b001cd4fb60dccso3273046pjj.2 for ; Tue, 26 Apr 2022 11:19:14 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BaXzjQ4uHQf8aegyrwpNgla1ibfyULSXvI/9Vr/sAxc=; b=KRnKrTVMScpLU/xoFxQbQTW+SGx7PnSpEZder1TS6rUrnpqqA9g+L+vOOf7d63Rk09 dgVpli8D5/GWTkSryl6aN1LNf8VwhNLAvIqB2dal2RBeq47Qz0QhG+pmn0glhvKD0Bj/ KTbYOZxkhXhgCZiD9c8Rw4hHiDOMb0RgKqEYPSpGQjpRIaHAHeD9jJ0saf8IhDVukpTg DNyu0O9SNcGSB173h8IyFGrJ1xAPjghY0hfHYjrsT1zf7aYN5iTo2IWa+sAgjAqbRNbV tzl3YwJmVN+hhr9uOJWKtOiRJcoUBtuTk3fFGNRLcDDSExX3KDS1D0tCy37KYB7gdsKL e4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BaXzjQ4uHQf8aegyrwpNgla1ibfyULSXvI/9Vr/sAxc=; b=v3yE3+fBmilw6E+6GTz8jf+EAx2WtYH+2C2u4Ve/QC+9XrM1pSvk9OT/KOGNiDS428 FOtbyUx5z4E/foruFveb/no+s7qbsJ40OWA2DEmzHGktczqnw4Xig+uHJr41DS2FlWHl L6qSg4OhgEG0GLpjAF8t0MRxuCGxEu8L5m7goQzGPPTHtRmhDl29kyM4DADfr9WebHZ/ zmxqBWv1XWpKSMGz9Jtx24uEQrO+fQCSIutKstur8pnqTJwAKWzEO8bnM7oIVjTh36KZ YixpA4u8D6MVO9JtheFfdQiYG0hfzOThNjuUx7uAuX6J9rDpX1lf/J4UJNrbjNDoK5xy E2GQ== X-Gm-Message-State: AOAM531g4vf7rQGfXDnNHOmJVX4mOgcYAcRV7Rr9G6bwA7ezEs9UgDJL riPLX0v0OZ4rBek0p4C2EIuJ5Kh6LpHGoQ== X-Google-Smtp-Source: ABdhPJzTrjeML99g+aeNt8r3IZMrP0+82Atc/h/k/d7POg3C1o1cdmKwQdEdU6RMF3+USIPI4EARyQ== X-Received: by 2002:a17:90a:62c7:b0:1da:2c51:943e with SMTP id k7-20020a17090a62c700b001da2c51943emr132006pjs.208.1650997153292; Tue, 26 Apr 2022 11:19:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 05/68] linux-user/nios2: Handle special qemu syscall return values Date: Tue, 26 Apr 2022 11:18:04 -0700 Message-Id: <20220426181907.103691-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998396549100001 Content-Type: text/plain; charset="utf-8" Honor QEMU_ESIGRETURN and QEMU_ERESTARTSYS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-6-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 63afba5862..2963fc62b4 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,6 +55,14 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); =20 + if (ret =3D=3D -QEMU_ESIGRETURN) { + /* rt_sigreturn has set all state. */ + break; + } + if (ret =3D=3D -QEMU_ERESTARTSYS) { + env->regs[R_PC] -=3D 4; + break; + } /* * See the code after translate_rc_and_ret: all negative * values are errors (aided by userspace restricted to 2G), --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998445; cv=none; d=zohomail.com; s=zohoarc; b=GR4OAK/lqjFDeUiJSntterX8fBl15tkvk5z0hQ1XoOoYYtDgmBSI5jCEpwrGYxW8iWc6EnFemEePyYLMGx4XvXkeaEKP0N1PKF/xLWDm81nO0myfv5bM+bXxs4x5wSYVvq1xmahFUAMP1wxmjrSFhfff7PSCDeCevo0OnKLE1rE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998445; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nqaKUgAiXbPVN3N+PzEnaP4AnWTK8+75oezV6iZmBrU=; b=VwwoTV+gdY3wIbuC22AVeeix0vm8CPEk5G3TlOP8uzONmS416Kavv1ibcqUS2MMnXGhRls4ZweMe6Km7FJDPw8oXZTvcg1oxrX7qGP+QIjFPbTKuZ6RMN8HVL860TeDwKjpyFt4Tg8oYxwYeJ4TA1djQ3ikAyXk8GSzbwX6SmxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998445681841.870478814835; Tue, 26 Apr 2022 11:40:45 -0700 (PDT) Received: from localhost ([::1]:33808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ7A-0001e9-38 for importer@patchew.org; Tue, 26 Apr 2022 14:40:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmV-0002U3-JT for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:38408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004LF-JP for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:22 -0400 Received: by mail-pg1-x531.google.com with SMTP id s137so16737010pgs.5 for ; Tue, 26 Apr 2022 11:19:15 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nqaKUgAiXbPVN3N+PzEnaP4AnWTK8+75oezV6iZmBrU=; b=Z7ZfNARVKLpCk5n9Lzj471DsDyvx4uGeSCFFAA7BwMQ+Q+lSMVisiWP/s3eacqkZpi TCNkRl6c2hKWEtUjvrUEVYfT78ye9MoS/iYGetRbgZtphk1MfDITvF0037DwBzvl+UNq jtg/b3Q7MnPEi/ECCt39dWpKgCK70DrwU/QkMgOJBqWpPK35N8Osn989sskJpoXztOaK gcElw7S0vtMY0pAmw9UNxefqEhWHfvZhq59E7Adz1BWCnLkdldwwtS+3dTvZMt9E04wj A4ev6/HHLv7vsxcboxLgYDuaTNCgp8Y+pFstk8/vLsPFn+zKl4vzc1FOvrS0JJCws16X /75w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nqaKUgAiXbPVN3N+PzEnaP4AnWTK8+75oezV6iZmBrU=; b=eBpDaad5stVJVmdCcx0C5cPaO6JrGRxRI7mV0El06mGUISY3lB4+MA6i8A0tCQ7pan nYAmEYKNBYbLZzCpQC+gkGQCPGF2lp9BFHe8TLyo6W26bebfDXhCHv1nUbc+ts4TJHPN W0Mu572XQk+5CB9UHrwmD+PFimV6ve+rGGr7iDsDgXSIhzPmcl1Y4YAU/m08PPvplWGH yjL7F420kXSRdjMWQBLAzqPVFnvJdMoNo8353K7j0OC2ImrXmt9RQz0yA0p93jqwB43i 1tM06KI3ff2SfYGX79M/6tawYQ0GCEkFWWw10/8sqMksxAqoQ2Cq47Y89jUbXRU2DZxN VNuw== X-Gm-Message-State: AOAM5316xj+laiW1qaYzBwEypGZYc0NOj10smwoZjcmiBmPljRcM17b0 ut5pQZneTDQYgA5wYqSXJvU8CjfMpEM57Q== X-Google-Smtp-Source: ABdhPJzbj6H/OVWDzZpAIo7mSNwGOtZXQugd23+VFQKyZstBn7Ss0OjB5y0Iqsan4Xq5ei8p+H722g== X-Received: by 2002:aa7:88d2:0:b0:50a:cf7d:6ff1 with SMTP id k18-20020aa788d2000000b0050acf7d6ff1mr25849739pff.67.1650997154198; Tue, 26 Apr 2022 11:19:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 06/68] linux-user/nios2: Remove do_sigreturn Date: Tue, 26 Apr 2022 11:18:05 -0700 Message-Id: <20220426181907.103691-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998447036100001 Content-Type: text/plain; charset="utf-8" There is no sigreturn syscall, only rt_sigreturn. This function is unused. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-7-richard.henderson@linaro.org> --- linux-user/nios2/signal.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 517cd39270..133bc05673 100644 --- a/linux-user/nios2/signal.c +++ b/linux-user/nios2/signal.c @@ -185,13 +185,6 @@ void setup_rt_frame(int sig, struct target_sigaction *= ka, unlock_user_struct(frame, frame_addr, 1); } =20 -long do_sigreturn(CPUNios2State *env) -{ - trace_user_do_sigreturn(env, 0); - qemu_log_mask(LOG_UNIMP, "do_sigreturn: not implemented\n"); - return -TARGET_ENOSYS; -} - long do_rt_sigreturn(CPUNios2State *env) { /* Verify, can we follow the stack back */ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998869; cv=none; d=zohomail.com; s=zohoarc; b=cKuyMNRH0sc3ZT1s0PfVsSFOBpXH2QmM0P0HFVycnKNy7gZZm7peiH5Ix1Uocgq4/3fQyl6a9T3m3AoltAdXeEEOk/pPv5V9Am07erYvjYJ8Xe+eL8F0p45aKZuL2R8j0qPusYRTPb3DVMFnFNBa9zofxDw6XCeHEE4ZBZq2fDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998869; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YXPXvIKScv4pzB3hV1PnW5pSW1FWM2CG8BhQI6zsA0g=; b=PO/nkDFtb+xdQPgXha5kBR0I1n4uk4gnqYpjGTvYyD9+YtYBj471wwzTzhqrQ+UVAoM/mL/RjRj5zJRh3TIMNKIC6RsjjPKjTmj94V0xWdlA8BB+CQRlcpw3Qsu36r2Zqx34VTtaRhUgnRljl9eAtUTlPgQ6Zn1T7dijEb13aMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998868992577.1765322779863; Tue, 26 Apr 2022 11:47:48 -0700 (PDT) Received: from localhost ([::1]:51178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQDz-0005O0-W5 for importer@patchew.org; Tue, 26 Apr 2022 14:47:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmX-0002WG-7q for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:42663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmU-0004LK-LI for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: by mail-pj1-x1032.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so3278001pjm.1 for ; Tue, 26 Apr 2022 11:19:15 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YXPXvIKScv4pzB3hV1PnW5pSW1FWM2CG8BhQI6zsA0g=; b=XGnGgcqEnse3mYaZwhjIk1RGa+eg3yiutr9BcAWf+wNCA05c/r1WU6XGYszmafg6Qp 0QHPYlQwr9bpY59xzcs7darGTN2uwSGILybGLsH1DJdTK2XwX/1Ux8JNbEBmH0mhMfBu VeekxF0HSSLJuaPLvTKw0oEnrP63+LOYqz1kWO/Q2UUIzPDsjBPEKDV8ZISDRmpRZrLQ 3fwdYGs+0p1kwEU/Y7qYgkKMRYtbUJHrUoI1/+ugmq+lfohBFTUPFkOiA5Kk7CXF7J3n +ZjmxV+mruaFHKHPIK2TwkEPf/bnwWKYF7dn7bwdZWr2DJaFkP15BQiPxPg61fVSdel6 lbwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YXPXvIKScv4pzB3hV1PnW5pSW1FWM2CG8BhQI6zsA0g=; b=XVCx/ZUgCjNHwUVuj9FjomyIHpljj4SRi0g2tYOWkfjJ7UjJd+LshnNZiGeKdi9XtP Ztv12PDdv5clOTBltEVOvwk6/WV8rfEU4OLj1s+ulQaVeWWlze9eh7vSujMbkwgbdMmF OTEof7PMfvVwxXdZcitzJyuGz5ACRmd2WtErRLiL1q/l6PyhEiMxUAoRv9+CEP9j1N9X TAYMsEtbsEc2atN853sulFJq/XEyzLiPgRH4D57IoE7IlMHat/8v+snt3KH2MkGcv6J+ 88wpOv6mofmnyY0aZbeB5Nz+dw1sdwPbv8txAi++YNfmBf2LgKINun7MpIMb6Uf0153w ruOw== X-Gm-Message-State: AOAM533mBITE24Wc5weM9YFWTfGsDfiRHDriY4XfZSoBOZrsDQF07bSR j/OePGHeB6c2AhV7mdfxUZQB2z/QKI8uyw== X-Google-Smtp-Source: ABdhPJxyIGlilSDA3JerpkeeQsEZ2WGkblBvV0LpKTLqmy2GWjVTQkf6HD2TT8NwFQwosDzlNfEvhA== X-Received: by 2002:a17:90a:638e:b0:1d2:b6e3:6e9d with SMTP id f14-20020a17090a638e00b001d2b6e36e9dmr39344180pjj.74.1650997154955; Tue, 26 Apr 2022 11:19:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 07/68] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn Date: Tue, 26 Apr 2022 11:18:06 -0700 Message-Id: <20220426181907.103691-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998870977100001 Content-Type: text/plain; charset="utf-8" Drop the kernel-specific "pr2" code structure and use the qemu-specific error return value. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-8-richard.henderson@linaro.org> --- linux-user/nios2/signal.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 133bc05673..9aa525e723 100644 --- a/linux-user/nios2/signal.c +++ b/linux-user/nios2/signal.c @@ -77,8 +77,7 @@ static void rt_setup_ucontext(struct target_ucontext *uc,= CPUNios2State *env) __put_user(env->regs[R_SP], &gregs[28]); } =20 -static int rt_restore_ucontext(CPUNios2State *env, struct target_ucontext = *uc, - int *pr2) +static int rt_restore_ucontext(CPUNios2State *env, struct target_ucontext = *uc) { int temp; unsigned long *gregs =3D uc->tuc_mcontext.gregs; @@ -128,8 +127,6 @@ static int rt_restore_ucontext(CPUNios2State *env, stru= ct target_ucontext *uc, __get_user(env->regs[R_SP], &gregs[28]); =20 target_restore_altstack(&uc->tuc_stack, env); - - *pr2 =3D env->regs[2]; return 0; } =20 @@ -191,7 +188,6 @@ long do_rt_sigreturn(CPUNios2State *env) abi_ulong frame_addr =3D env->regs[R_SP]; struct target_rt_sigframe *frame; sigset_t set; - int rval; =20 if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1)) { goto badframe; @@ -200,15 +196,15 @@ long do_rt_sigreturn(CPUNios2State *env) target_to_host_sigset(&set, &frame->uc.tuc_sigmask); set_sigmask(&set); =20 - if (rt_restore_ucontext(env, &frame->uc, &rval)) { + if (rt_restore_ucontext(env, &frame->uc)) { goto badframe; } =20 unlock_user_struct(frame, frame_addr, 0); - return rval; + return -QEMU_ESIGRETURN; =20 badframe: unlock_user_struct(frame, frame_addr, 0); force_sig(TARGET_SIGSEGV); - return 0; + return -QEMU_ESIGRETURN; } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997926; cv=none; d=zohomail.com; s=zohoarc; b=FSnoqKXSkayuvAFys3qwWCF9h6ypk24Wjhf75/kXiEPOuIF46cPYwmwH6b+E3w/Rwftb3slel4lFREenZqnq23mAbrsjxWCLierYUdQ1Mn5AtOYPPizoqx5nsCPr5V5R4C5axWpnccdxMLz9k/0q4FSZ5+ubU7cbuZ3y1VNGmio= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997926; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CrNW1rK4WiXSB4GD2xVRHyjJx/JGJkz3Qq1JReZmp+g=; b=bYhkBDDxngrRjqs7vi7bMuuDTeYx1hfR9qFOupZJy6RJ1RMnhCMc4wD5QoBa5QxpCiVCOuWuzn9bifLq7JY8heYiFLVSz5XYrxaqzZG3kZnKdwxP8M3pXzg0Tba2w8h39ZdbdcpFpM9xRTzTKKcRb2mQwmFw2sdTaaD5sYz3IcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997926552538.4468042884598; Tue, 26 Apr 2022 11:32:06 -0700 (PDT) Received: from localhost ([::1]:43214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPyn-0004wf-Ij for importer@patchew.org; Tue, 26 Apr 2022 14:32:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmW-0002Ug-6m for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:37741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004LO-PO for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:23 -0400 Received: by mail-pg1-x536.google.com with SMTP id 15so8369223pgf.4 for ; Tue, 26 Apr 2022 11:19:16 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CrNW1rK4WiXSB4GD2xVRHyjJx/JGJkz3Qq1JReZmp+g=; b=bIzzNw5Lwb0+/ywL2qw18YBHpp4l/HfnPxPn+HVcvyyoQ5LvETLZ22VPy+atjqDVZ0 DrSUHZ6ETi1meTE5NK26kaJ8bM402Lo/X3HbPxxoM5W8TtuNNlU+WHzgawiaFmLSk/rf d5wHDwQs4HHymLEx0PCNOZCB3IStJr38/VRtYKSr27sNQnRfmvUATNi8UzGkz5xF1cSR BGaqjD5w4jE8dsP54Z0a8w4ymBrR62UuNlEroYITnwLsQl61jM+XLDxKqfh6ZM7JVAwT 4djX/w5kEidWvvMA0E+0waE7hD221z/lQpQAGNriC9Q+yTQtUxEzT3T8W/Be0xxPE4nu F+6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CrNW1rK4WiXSB4GD2xVRHyjJx/JGJkz3Qq1JReZmp+g=; b=e3FfMHVrHvht6j168VYEMkjML+qA0fKOb1/zYLFCzkyS0dfpYgJ58L5FlKuOXxYugl jnhL9PE/1y5XGdLHgAuFOuwgZhlrJFmQKI+BZ8oINpwAUvjgCJ7DbMR9AroIgRN6wTBD F2h4oilk/AdUYm9aWK904cX1ov1Qcz0rJLTdktHBV9QnE33ue5jmAnPODz8OlIUCsntq 4+jqTsEKlibY536RsHRDP3+QOf4B7Ra5i7r1r9b7/o9VQrTUOa25o5HhJ+Eka6S8Inni DwViAtr8CsocmWKvHdxaKwrEzDpGY6ZV1R2vLEyANdt7ekLmJN1Sy60Q0mc6MMH1EWRr 5TPA== X-Gm-Message-State: AOAM531Yc3A06p3EFk7TUSYS3xeXUuZEal04UAjQDHfsNppC5rLOhmm1 P+oFdlZd2ccGo9xF+4LjaksHZhJEBwe8zg== X-Google-Smtp-Source: ABdhPJyCzWWo49YFISbdJj0cBkkMxBXJHl9qyac1CoK6Usdi4y9U/fRaj4U0W4x3WelgRM4RO1Sl6w== X-Received: by 2002:a05:6a00:23c3:b0:50a:7ee6:b369 with SMTP id g3-20020a056a0023c300b0050a7ee6b369mr25478993pfc.76.1650997155684; Tue, 26 Apr 2022 11:19:15 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 08/68] tests/tcg/nios2: Re-enable linux-user tests Date: Tue, 26 Apr 2022 11:18:07 -0700 Message-Id: <20220426181907.103691-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997927915100001 Content-Type: text/plain; charset="utf-8" Now that threads and signals have been fixed, re-enable tests. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-9-richard.henderson@linaro.org> --- tests/tcg/nios2/Makefile.target | 11 ----------- 1 file changed, 11 deletions(-) delete mode 100644 tests/tcg/nios2/Makefile.target diff --git a/tests/tcg/nios2/Makefile.target b/tests/tcg/nios2/Makefile.tar= get deleted file mode 100644 index b38e2352b7..0000000000 --- a/tests/tcg/nios2/Makefile.target +++ /dev/null @@ -1,11 +0,0 @@ -# nios2 specific test tweaks - -# Currently nios2 signal handling is broken -run-signals: signals - $(call skip-test, $<, "BROKEN") -run-plugin-signals-with-%: - $(call skip-test, $<, "BROKEN") -run-linux-test: linux-test - $(call skip-test, $<, "BROKEN") -run-plugin-linux-test-with-%: - $(call skip-test, $<, "BROKEN") --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998665; cv=none; d=zohomail.com; s=zohoarc; b=if55gAPL7l8Tf1EkEAKR0qW3bZcx9yUp3+1AITtlZsP25IzqZEpFRZTfyAas7QXHXp/EB36pf+c9Zm14JFPSk4nzQrOhc/WtaCcQyxEo6QRhUkb2OYLcYtERJ6ipu/kXuhMPBODBnze0eQqo2K3TYgm3noY1PTynx5QFQfwJW6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998665; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oKKUu+zNBC8As9SImKOzVlpqPHOufT8qoTmRma0rBy0=; b=k1Ve2+C6j5NFuwDb9c+Am9a5rb62hGO+BXEoy/HN4bfz66FyvY41wpS6P2ivR9twYt70gvKAFsNpklyt0CsZdGXLX1QGO5mXPm1K5MltTcdEodreTLc2AiORFz4o+CYC5xfeibTg41OUD57JKDIZlwdrfhP5Mu45MiPCynHKw2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998665377828.551069048936; Tue, 26 Apr 2022 11:44:25 -0700 (PDT) Received: from localhost ([::1]:42474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQAi-0007qz-7l for importer@patchew.org; Tue, 26 Apr 2022 14:44:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmW-0002Ui-A5 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:40816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004LU-Jl for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: by mail-pj1-x1032.google.com with SMTP id iq2-20020a17090afb4200b001d93cf33ae9so2838979pjb.5 for ; Tue, 26 Apr 2022 11:19:17 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oKKUu+zNBC8As9SImKOzVlpqPHOufT8qoTmRma0rBy0=; b=d7T+4Pp0rVCuo539R5J9OMM8kKFfGyUSxwDi7fhYiuQfpCAl3x/IWqyrH2W0kQjPTT j7HH4XpDqo165mXB+QlJv/ON/Zr/qlRr6JeLZlKx9Ov8Lzmvwsxlu6/mOT0FZjdPOh5s eZ/iwiLBR3dh+zdS2Bdj8q/OX/Tw/DMum9dtcx1tOsmdhRIRISnbZGlKGTl4ROrxKaFi SETDBKOMeoyAfRMAWJx9wV7qkhqMARam1Z+prxBe83sqCBotbYBegKIqldV1hBqGq8nH Nwe526OSUP5RZqIUOGDgnSb0YL6IBSmHGbHCro7UryWYBxRT/uK/i4yTLH/KeO5pFaXk VSaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oKKUu+zNBC8As9SImKOzVlpqPHOufT8qoTmRma0rBy0=; b=UyXpLnK/tHEuYjYsKw1xGTm8g6zTGFMHYzRw4iXggIP3xaxaQLtAlqq8loIsAJp6IA brC1T5dXmM/H84AqNmr2rOYKjY2mUxaNBdlrPn9S9GOQ8N8GnyhBslkX7+XcCwKmQe6/ EGz0GSVywBRealeyviC+i67tJbJz/93WE3esbFiL6u2Sgi+GwNmonH2WhLybBVdIG61u P2x9RtFC3ScZT55ZJ3yMUl0xQostIWWKDg+nbWE3p+qFecrw0MXMSSnCU0GEAK9tUg+G iXPjBEcD+s5JVUkODYamIDvb3dW8Tnvi+LI2T09F2MsRiDNKUEH01uTEnVZkLWNl563k uxTg== X-Gm-Message-State: AOAM531HwuBxzrwKPuhc7/L/PDn5oXFWRok7wvoVoZouDbIO0GdVN8Gr 2tBjuvl8QV59K8QC2QC5X2Sqr2HglVmTuA== X-Google-Smtp-Source: ABdhPJxpksoJgO3GG9lqquCwetwPCiIL+Wu505HY2NHwSNctsdYvNyjF36O6UIdhMWbwvJyOgA3DqQ== X-Received: by 2002:a17:902:eb8e:b0:15d:11f5:59e7 with SMTP id q14-20020a170902eb8e00b0015d11f559e7mr11972478plg.32.1650997156487; Tue, 26 Apr 2022 11:19:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 09/68] target/nios2: Remove user-only nios2_cpu_do_interrupt Date: Tue, 26 Apr 2022 11:18:08 -0700 Message-Id: <20220426181907.103691-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998666278100001 Content-Type: text/plain; charset="utf-8" Since 78271684719, this function is unused for user-only, when the TCGCPUOps.do_interrupt hook itself became system-only. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-10-richard.henderson@linaro.org> --- target/nios2/helper.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index e5c98650e1..678fd96c4e 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -30,14 +30,6 @@ =20 #if defined(CONFIG_USER_ONLY) =20 -void nios2_cpu_do_interrupt(CPUState *cs) -{ - Nios2CPU *cpu =3D NIOS2_CPU(cs); - CPUNios2State *env =3D &cpu->env; - cs->exception_index =3D -1; - env->regs[R_EA] =3D env->regs[R_PC] + 4; -} - void nios2_cpu_record_sigsegv(CPUState *cs, vaddr addr, MMUAccessType access_type, bool maperr, uintptr_t retaddr) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998166; cv=none; d=zohomail.com; s=zohoarc; b=LP1StDtgjlKEtNZXuIaGEDsBUfdSCiFcJOlEetJIdFBLU9NJJZGHpNfwWzKBwaiZkgZZ9ujBC687WUsOQaRqCtLwhApTMVYiQHVOS4qD+SqGp/NA687TIrPKtf1aQL4hJQ8KOD2gN73YHy1CGBCUyYirZeWMEwma6PB0l+zP7Eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998166; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tSluLj2R1JhZMB4God4i50Z4RRfFTHgwIiUmh8NzNww=; b=fVGmksIXgVRpICMaODmlZcZ0KkXgrtkTgnxliHO43VXkyu7T30silZ2GLfPWChraq0TfCkQoBafP+V7Unf4a+eQBlEAsUWRNv4p1R0x2xckAoRTBpdygFY8yPGDsnG97Zjei1LeZLpioX+Sig0juvPVgQ1Ctn9+belsPqRLhDyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998166425988.039625890015; Tue, 26 Apr 2022 11:36:06 -0700 (PDT) Received: from localhost ([::1]:51612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ2e-0002kA-Ve for importer@patchew.org; Tue, 26 Apr 2022 14:36:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmW-0002Uh-94 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:41788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmR-0004LZ-Je for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:23 -0400 Received: by mail-pl1-x62f.google.com with SMTP id s14so30970204plk.8 for ; Tue, 26 Apr 2022 11:19:18 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tSluLj2R1JhZMB4God4i50Z4RRfFTHgwIiUmh8NzNww=; b=fde1Z+V5XxB01cD+oNTb0/2SxrK9fd0jvGAHA/DVDwHd4eNjMoEvNK2dy9wvLkIUfU H/iNBqcm25GLwkAd9WkmsBvcplZXPAFPyZ6ScQ0kiDOSOYqywSMO+XTzv0Mb8rKrBIQB V/xYOvOCAp4EBSPT53PedbZxN4dkZWY9Sc7tguR2tMnTChv1r2FHeY9o17dUHV7ffQHZ kZHKf4DddnkqEf+eGbb4ixRSYyOEtDyCUVpsgyyv+psqvW1BIBOxEOqmd8huGOrDG1pH ifNG/788GDX45sqAFveMqa49qYNaK2HikSEYTs/qfyMey+s6ditcc7lZ6tLLbQdwgz5k vvRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tSluLj2R1JhZMB4God4i50Z4RRfFTHgwIiUmh8NzNww=; b=7Z5toLJ0WVuQGnY8ejk8QKN88mgLI9Z6iEZfmA6N0SYQK8cwH0TEP1h9bg8Ouoakrt eDv/uAUiAvFypKTzGrtUXnUe61o9DHld5nB+VO1Lcs6bSZpjIbkLX6Q8VmRKm09RnMQk DvDjYxvzSiQBfzUi9zvC/nGw0YskxEkxZBdNX5iStCs3M4yIwyJWRrcs1j1xGQOCJ1e+ DPDjfhuNHSmK7Qg53BbeAc2t+rOX/M0f05PwLDejBBRd8qrzt4D5XJWbi0qxeahw0Cof uSNMSYSQZD7UGMMufzaPO/5cegEPFE0pSlh0CiVvlLBWoqskZo+X86sDCLF2EigyofJA 8Bcw== X-Gm-Message-State: AOAM5300WLS4tcwi5mfu+1/94S0OEZ22dgv1kFv4T29s9RTRzG6bdHWx eui2cTdu01YyLM4M2RC0N8p6buxhYBoA3g== X-Google-Smtp-Source: ABdhPJyTKbTF4LMsduYnCBuFbKkJq904q8e47thxAUZYsdm83jrLiv58Y5PQCBGg8Hz6eQt+fAFBIw== X-Received: by 2002:a17:90b:3b4f:b0:1d2:7117:d758 with SMTP id ot15-20020a17090b3b4f00b001d27117d758mr39015938pjb.105.1650997157424; Tue, 26 Apr 2022 11:19:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 10/68] target/nios2: Remove nios2_cpu_record_sigsegv Date: Tue, 26 Apr 2022 11:18:09 -0700 Message-Id: <20220426181907.103691-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998166938100003 Content-Type: text/plain; charset="utf-8" Since f5ef0e518d0, we have a real page mapped for kuser, which means the special casing for SIGSEGV can go away. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-11-richard.henderson@linaro.org> --- target/nios2/cpu.h | 6 +----- linux-user/nios2/cpu_loop.c | 10 ---------- target/nios2/cpu.c | 4 +--- target/nios2/helper.c | 14 +------------- 4 files changed, 3 insertions(+), 31 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 1bab805bb0..3198c17213 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -216,11 +216,7 @@ static inline int cpu_mmu_index(CPUNios2State *env, bo= ol ifetch) MMU_SUPERVISOR_IDX; } =20 -#ifdef CONFIG_USER_ONLY -void nios2_cpu_record_sigsegv(CPUState *cpu, vaddr addr, - MMUAccessType access_type, - bool maperr, uintptr_t ra); -#else +#ifndef CONFIG_USER_ONLY bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, int size, MMUAccessType access_type, int mmu_idx, bool probe, uintptr_t retaddr); diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 2963fc62b4..f37850fe81 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -126,16 +126,6 @@ void cpu_loop(CPUNios2State *env) info.si_code =3D TARGET_TRAP_BRKPT; queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); break; - case 0xaa: - { - info.si_signo =3D TARGET_SIGSEGV; - info.si_errno =3D 0; - /* TODO: check env->error_code */ - info.si_code =3D TARGET_SEGV_MAPERR; - info._sifields._sigfault._addr =3D env->regs[R_PC]; - queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); - } - break; default: EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting= \n", trapnr); diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index b0877cb39e..9774a3b8a4 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -210,9 +210,7 @@ static const struct SysemuCPUOps nios2_sysemu_ops =3D { static const struct TCGCPUOps nios2_tcg_ops =3D { .initialize =3D nios2_tcg_init, =20 -#ifdef CONFIG_USER_ONLY - .record_sigsegv =3D nios2_cpu_record_sigsegv, -#else +#ifndef CONFIG_USER_ONLY .tlb_fill =3D nios2_cpu_tlb_fill, .cpu_exec_interrupt =3D nios2_cpu_exec_interrupt, .do_interrupt =3D nios2_cpu_do_interrupt, diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 678fd96c4e..55b8fb0bcb 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -28,19 +28,7 @@ #include "exec/helper-proto.h" #include "semihosting/semihost.h" =20 -#if defined(CONFIG_USER_ONLY) - -void nios2_cpu_record_sigsegv(CPUState *cs, vaddr addr, - MMUAccessType access_type, - bool maperr, uintptr_t retaddr) -{ - /* FIXME: Disentangle kuser page from linux-user sigsegv handling. */ - cs->exception_index =3D 0xaa; - cpu_loop_exit_restore(cs, retaddr); -} - -#else /* !CONFIG_USER_ONLY */ - +#if !defined(CONFIG_USER_ONLY) void nios2_cpu_do_interrupt(CPUState *cs) { Nios2CPU *cpu =3D NIOS2_CPU(cs); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998346; cv=none; d=zohomail.com; s=zohoarc; b=iizzTHK78cOosZ21rx387hDkLbKVC1c+tsvZJ+MVJHOO45u2nJU68sm76qKi8zAuliUbyjrSKJWj67C16dqs4XjyUBoYBJeUSHQJJjR4XBdKkYNEfXiEQ3r7wMYR1U7LBEd2NGLbYDkVtBMGwyN0y2bOFRh6nSSbiT+8MZ6FhTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998346; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aSCpXgZFYrLKFx9z48EM2Iny/HfNa5ePJRFMiB+lNrQ=; b=krR6LcfHMc87WdkoiBOdngjkO1A1I7tbq/UBgXSHoXcxi8hFfC8O+1DHxFmm8s+d7uCxOJzezuJu7ct7ugOH2E2wK26JYB09k2ExztLUwApAYfN0tK5ZLzat9PkbeLMuwQM03R4ZWIt+6Nvk/01/FB+gHEwPnvVC7J1tTjGaVsA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998346862543.4845043247102; Tue, 26 Apr 2022 11:39:06 -0700 (PDT) Received: from localhost ([::1]:58200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ5Z-0007Sn-Mb for importer@patchew.org; Tue, 26 Apr 2022 14:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmW-0002Uj-DB for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:35670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmU-0004Ld-1n for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:24 -0400 Received: by mail-pf1-x434.google.com with SMTP id t13so5055946pfg.2 for ; Tue, 26 Apr 2022 11:19:19 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aSCpXgZFYrLKFx9z48EM2Iny/HfNa5ePJRFMiB+lNrQ=; b=N+u9E1lwGhGsj2Xfdj9bGCMiknWs5MzgJDR78Xjee3FC6OaOyqejTzICzEjpWiaCqq /uRu76GMnMCt4R95M03z7Sy4fr5iNCGUkORSS4W8r1gCgZdDORG4p5U/IDtT9Emns83I fOFC3wqc4nfsJ318lbq470NkPenXmOneLCKdgYVGx1fpMYVRKTRN/Q3gM44w5x6MhUlg m0iChju+7Y4wiQBAwJRFhbAZqP2/Pvx4rCG04mn7MMVCBA0FHHCeM9NBxfxG3dhzL7px Ul8yLKDnCn247iGWZjWv6CjZpyFw55W8mdjzpSyd8L9F9ByiBDd3qT+3Gi3ZcLZsBkdN 9IKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aSCpXgZFYrLKFx9z48EM2Iny/HfNa5ePJRFMiB+lNrQ=; b=7wPLStG3BuGvIeRBeMqZTDHONCDueF3DnOv/NMf1uENtjM3spC6IVdh/ZJy7xrojp9 p8O3GeCVz7aknVnh7bfi0N/pAKlSLDW4T4S51xMJXuFmTkRxclVE8mBxNnV+LzB/ug9I 8BbgPpZTYUiyjmMDORftC5+aXLwtqAf7Pqz1g44HqiObH9/w3GP6Xwzp9e+O94JwapOv Ke2v8mxl3ILYF+RpjfB9uCdKiFnqTCrGZXDde5xctoVoNAHdo9vC52/ppQ8Ipuu5G2R4 nDRHjGhtZtHeIADCzvwTQzZghugT9A6bRNdG2DNat0evsWVi7enyd29pu+I+DUo/5B6g v0sw== X-Gm-Message-State: AOAM530IDamvzvUFzqkxoaUDRQ59Vb9YpXqOEibgOUpEmXOLgFouNCop P27LXJS7vDOElXSSJ6MkKP9U1KyQK6EoSQ== X-Google-Smtp-Source: ABdhPJxja3S+MkGHbbZtdFre7BOMxF+JeUIxfjlrvJ2htjROE+TOiMdG7ZI/vIoyGHPb6gI/sTwX8Q== X-Received: by 2002:aa7:8890:0:b0:50a:9b3d:bfa5 with SMTP id z16-20020aa78890000000b0050a9b3dbfa5mr25997728pfe.48.1650997158227; Tue, 26 Apr 2022 11:19:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 11/68] target/nios2: Build helper.c for system only Date: Tue, 26 Apr 2022 11:18:10 -0700 Message-Id: <20220426181907.103691-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998348120100001 Content-Type: text/plain; charset="utf-8" Remove the #ifdef !defined(CONFIG_USER_ONLY) that surrounds the whole file, and move helper.c to nios2_softmmu_ss. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-12-richard.henderson@linaro.org> --- target/nios2/helper.c | 3 +-- target/nios2/meson.build | 7 +++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 55b8fb0bcb..04a8831443 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -28,7 +28,7 @@ #include "exec/helper-proto.h" #include "semihosting/semihost.h" =20 -#if !defined(CONFIG_USER_ONLY) + void nios2_cpu_do_interrupt(CPUState *cs) { Nios2CPU *cpu =3D NIOS2_CPU(cs); @@ -292,4 +292,3 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, env->regs[CR_BADADDR] =3D address; cpu_loop_exit_restore(cs, retaddr); } -#endif /* !CONFIG_USER_ONLY */ diff --git a/target/nios2/meson.build b/target/nios2/meson.build index 62b384702d..2bd60ba306 100644 --- a/target/nios2/meson.build +++ b/target/nios2/meson.build @@ -1,14 +1,17 @@ nios2_ss =3D ss.source_set() nios2_ss.add(files( 'cpu.c', - 'helper.c', 'nios2-semi.c', 'op_helper.c', 'translate.c', )) =20 nios2_softmmu_ss =3D ss.source_set() -nios2_softmmu_ss.add(files('monitor.c', 'mmu.c')) +nios2_softmmu_ss.add(files( + 'helper.c', + 'monitor.c', + 'mmu.c' +)) =20 target_arch +=3D {'nios2': nios2_ss} target_softmmu_arch +=3D {'nios2': nios2_softmmu_ss} --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997359; cv=none; d=zohomail.com; s=zohoarc; b=UBJHWK59vDvgPAg2mA5GlWoCamFvDAS5GO8dMcT4jcq/vAKuGazFkz6Fvfd8zORGUzzAj43d4WtoQz4AGt+u/XjfBKg3x1i3tWkdllZrkwPydSoe3tcx1Aalq2GEyJkXX2c0GQn4GUr5mChiUjSfi052Ji2wWVueQuxTjnH/HZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997359; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RtRmXlsOxeVOyDOQBenqjq06keYpCIdFa3N3ui9g9FQ=; b=HfeI0woiafaEgJWLjkO6zQDCsfbd5d07B70Hv90CU02jE8W9pLcJuXYZkUFXLw3Of179EI2WvrNypGtlH0KsuLjTo0DwhFSQvWxE717CKMIYIr0Zj/hUKnph0dAezAodwJBNTl1LB1sWSpaAhkE3tOMsHQHXYvovVqYoxghtlzE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997359113833.5235730086417; Tue, 26 Apr 2022 11:22:39 -0700 (PDT) Received: from localhost ([::1]:52630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPpe-0000GQ-30 for importer@patchew.org; Tue, 26 Apr 2022 14:22:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmX-0002YI-OR for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:34640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmV-0004Lz-A8 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: by mail-pf1-x42c.google.com with SMTP id a11so7470966pff.1 for ; Tue, 26 Apr 2022 11:19:19 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RtRmXlsOxeVOyDOQBenqjq06keYpCIdFa3N3ui9g9FQ=; b=Tmp/u/OGcMCpu5xMjc019OXaLZ88WXwF+9yvUdJun4TxxrAmIypzUUjCdSEMd2CqKk UPxdMkKYB+WuNvC/aKbVPT5XT1ViIBwnMDBi1DRyuYiczKUioy5INWTz9TC/6LITT87i O/23oNcfJLPGMbqXaBKCuFnZPIWBSLYad1rlf0jD5syhYZTSpjR7VxOTgrW3tuRYOLya Ju3xbHcfz8zVtN3YsrAuWTyfQzMG67RNKPM21gqPOcNFyTFaRBIL4Jf3JtgV7vdu6HCb CIAuuZwCexYVW7AWMU5YCxwKHGMigBU00/fV4+SHxLgScn+n70+kZ8i/H7NDAGtj9Isr oxeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RtRmXlsOxeVOyDOQBenqjq06keYpCIdFa3N3ui9g9FQ=; b=I/V4qJoPu4nRtzy4RWV7ZOYeNZ63ErXQS6ApUkhwAU2RBUumpwTke6x4Dp9IydfG+j k3bKoR6juQ+d7IxWLC9a441w2Nxbg7wL4xoj6lG1VIBnR4XNgQi+kA1kxjIUroNiqtIQ Y8EiHOt7DDk9JB0LFcXaR3Qsv1xrM+6s8lTdtKOtXyxkenbFfsSdu7KDCL6TsbivK3Hx XOCH1T1uHbM0m/1Hl70zANY+DBgLloNRnwzOaRObs6DbmQNN9VLz/ocICzcE97w5vXEc bCuSUC2yqt2K4v3zNLRlAZ5/lJgSWXgQKOX1KMoY4OrYaCQjQJgvf3Rplz7W4466YcRF xcxw== X-Gm-Message-State: AOAM533vAEkItYMmd5TrNnAVqCUI+fCL59qs8IaDISRE/8mcgYJvowXD nMSdxSShVcQe8TucYv7LBzW+D7GWZ6PGpA== X-Google-Smtp-Source: ABdhPJz+FDxKXWNJ4h6moGmTNB0AF5JTjizGz9EQ3HMXvkliRmNe2QofuLTwOwHnztsy/pw6b09N+g== X-Received: by 2002:aa7:83c2:0:b0:505:723f:6ace with SMTP id j2-20020aa783c2000000b00505723f6acemr26064489pfn.86.1650997159068; Tue, 26 Apr 2022 11:19:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 12/68] linux-user/nios2: Use force_sig_fault for EXCP_DEBUG Date: Tue, 26 Apr 2022 11:18:11 -0700 Message-Id: <20220426181907.103691-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997359869100001 Content-Type: text/plain; charset="utf-8" Use the simpler signal interface, which forces us to supply the missing PC value to si_addr. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-13-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index f37850fe81..e725036628 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -26,7 +26,6 @@ void cpu_loop(CPUNios2State *env) { CPUState *cs =3D env_cpu(env); - target_siginfo_t info; int trapnr, ret; =20 for (;;) { @@ -121,10 +120,7 @@ void cpu_loop(CPUNios2State *env) break; =20 case EXCP_DEBUG: - info.si_signo =3D TARGET_SIGTRAP; - info.si_errno =3D 0; - info.si_code =3D TARGET_TRAP_BRKPT; - queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); + force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->regs[R= _PC]); break; default: EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting= \n", --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998627668931.3278319394116; Tue, 26 Apr 2022 11:43:47 -0700 (PDT) Received: from localhost ([::1]:40530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQA6-0006U7-KJ for importer@patchew.org; Tue, 26 Apr 2022 14:43:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmX-0002Y1-Ls for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:34194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmV-0004MA-9y for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: by mail-pj1-x1033.google.com with SMTP id d23-20020a17090a115700b001d2bde6c234so2260491pje.1 for ; Tue, 26 Apr 2022 11:19:20 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6UYSlRGZfhDryiA9u1wA9vZSGmpcy5aRg3TaG0SXLQ4=; b=oVbNU6YPBNHQkUQsZ1r9L5kgyOSEQC9SRbC428MN90SJL/dLSnSNJFXPkWt8yQxgYR SqxKN0nbnC+ZsfMLbYnr/rTuHyUr0Rjbcpp/yJTte9XURZCnBaG8cPqs0ytVCZRutMBI pJxeswesInR6eP8+OwyNpxT8UgWZpFHxpjGfbTKruenaco1CgYWAVr6mpJYGpyEcyfpA DG3NwH+CjtLG8J4FUmsX5Agyq+FWD+PGf8ZzoY77phTu+X5uz5ASfkGJLIlckwRPFCuA KSsxrcy7BOa2S7v80SAse69jrKYurplkuyTzL58ChXuMbyq9r2+Y973ZOaHT1k0Gqiva KcLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6UYSlRGZfhDryiA9u1wA9vZSGmpcy5aRg3TaG0SXLQ4=; b=AC1Q0bp3GUOASBoiAesglr8ld1pZxPEC8Yka+uJG+72tjON9fkZqljTQo1Ib7S0ggb uqBE5XBQG2sqGeo/yrAEnEtiYE2GiWGl1JbvO+qZfAJO/YufgBzZp1rgkH92qYMulWML LSBU8XMj8feMAw2CC7Zgo9sksIaTAqGTJQPbr1uPH5N+RdFt4lLdShskCku0iYLVZ5xh lgPRn8FV7VshFEmF42FXjtRFosQiuRzfrSKKaU0iQ/UAWMjBEQ8OzCz9J2EKnUXaSULA O7pRxdn6BDijvC9SpD8KR+0QJtNcbNEqUcGK5mnqXgGUyNqfc1PtRzh6Ofh/Flappsqc Bf8Q== X-Gm-Message-State: AOAM5328gcHhUfLEO36514858I8RWZjDdfh9iDn2DmEO17MDk9/YtGWL dTv0x7UHHJr+ivmV3CFB5/WsQy1oxNM7xg== X-Google-Smtp-Source: ABdhPJxJONvP9ex+0hEsf8hbl/1pu0pimPn9W0xgiauXAh0mGPE+idV0b8D897ehS0kiinNe2DkBpw== X-Received: by 2002:a17:90b:4a48:b0:1da:1fb3:2f65 with SMTP id lb8-20020a17090b4a4800b001da1fb32f65mr1484116pjb.168.1650997160079; Tue, 26 Apr 2022 11:19:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 13/68] target/nios2: Check supervisor on eret Date: Tue, 26 Apr 2022 11:18:12 -0700 Message-Id: <20220426181907.103691-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Amir Gonnen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1650998628242100003 Content-Type: text/plain; charset="utf-8" From: Amir Gonnen eret instruction is only allowed in supervisor mode. Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Amir Gonnen Message-Id: <20220303153906.2024748-2-amir.gonnen@neuroblade.ai> Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-14-richard.henderson@linaro.org> --- target/nios2/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 89b97ef520..eb97e13feb 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -384,6 +384,8 @@ static const Nios2Instruction i_type_instructions[] =3D= { */ static void eret(DisasContext *dc, uint32_t code, uint32_t flags) { + gen_check_supervisor(dc); + tcg_gen_mov_tl(cpu_R[CR_STATUS], cpu_R[CR_ESTATUS]); tcg_gen_mov_tl(cpu_R[R_PC], cpu_R[R_EA]); =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998989; cv=none; d=zohomail.com; s=zohoarc; b=YERNEmuzOSdKXUDTdc/f9eES88DIcOEsn9uIyo1V34tYULEk7STQ0iznbFJ1C/MPhBupmQpVDroCx9X2RqeGaNo3XgLxbQ8lXJueQQWgkX/tiMJpZn75KKraDToLJVeWzDZiM08DgbGMvjoBPsXwUc6E90k6WsKSaLOU8IBrmj8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998989; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4LG2ggGa5J5Lu4I1wse39Ww5a8efRD9iZexWoAzkdh0=; b=lnL2Geg9F8IR0wAErHvRTGWrCZkU+/wfygpoVe1n5xpEGvYXdFoFFWWMsE/bWsM0L+jUX3CUHbBz0DknjGZCNv4acDJGHOOyRfx7iAiw6E8qV7LDE3OL/TF7/teYZtilX1FyBnfir6d3SfYzjYQxfqb8BtD8d3dmQqH0gywTUW8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998989623555.4537568471936; Tue, 26 Apr 2022 11:49:49 -0700 (PDT) Received: from localhost ([::1]:57824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQFv-0001a1-8Q for importer@patchew.org; Tue, 26 Apr 2022 14:49:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmX-0002YL-QU for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:34322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmV-0004MS-AD for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:25 -0400 Received: by mail-pg1-x52c.google.com with SMTP id z21so9082745pgj.1 for ; Tue, 26 Apr 2022 11:19:21 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4LG2ggGa5J5Lu4I1wse39Ww5a8efRD9iZexWoAzkdh0=; b=wLsYfP+d9KcZPoO/twVsghfqaNA9+87J+Cd9ox66aNpl2ZqoKtFxICsQUGO9Q1OCdN HArTHbxjHwREH5iyX0QTKCeXpYek7b90Wl5rxZ21yFK3Ar1NFHWtpRnkeziG9T4lkQeR zCgU8nCckveRxvwiG1BPc+/LiyExxezrdnZClySt3k8qxwNx6Wk4BIjXR1ecOKbQCjrB 365SlAEOeIvPfPffBmfWVrjxce8w7sukpkAw+DGMDwZxvVokiBtl5sBSkDMq8XByE9D4 0xUA+X4J+CPWdd0Frv3g43JbUOXYxL7unbQYtreGvmxAu6PArKAvk3+5VnzNsHEWGnHz q7rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4LG2ggGa5J5Lu4I1wse39Ww5a8efRD9iZexWoAzkdh0=; b=20+Q2GbDz07QjrNp84jNPK7DwUebeaBVJ3/XOWtF8QoxzGOnBM+deTvrZ3dmWSpu7D 994RrAnzFWMOhhUwrOC34Vrxtdd5bai3fap2JxQ0NySb33snlozV4nFQ5wrpSCvnYowK 7zZ2kWeZjg8B9Uy/lEMCaYjAf0pTTBUE0XBPy3UbCKYJu7J0I2QxUObQA3viiDErjpPZ W5SaMAPUZJeJRZx5/LHSxgGn70Zd+6BmrRcfuX0Gmf15ogNm/ZhwEIlq5w/JEwD7FoLY KEn6JgUnKF9/FETtFF/pHra5k8cDOh4P8AIxdUCeDzNWgW5vipOMWle7LdKtLuIcyX67 MZpQ== X-Gm-Message-State: AOAM531TB1PZqqmzMjb0VtzWptJL+DyPtrtOkHohIK/O71I8blbWMABs mH6kpD4yjiVAJVi9N4EVaHU4C4bdqW7x1g== X-Google-Smtp-Source: ABdhPJwZe/Pso1hAnb3Zfphg3hPVM07zDKZTUiHJ2zjf6qYNgd1HSZJyqKWqXhNY3k+j3PpM23sKPA== X-Received: by 2002:a63:e51:0:b0:3a4:9d22:1fd5 with SMTP id 17-20020a630e51000000b003a49d221fd5mr20793126pgo.586.1650997160895; Tue, 26 Apr 2022 11:19:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 14/68] target/nios2: Stop generating code if gen_check_supervisor fails Date: Tue, 26 Apr 2022 11:18:13 -0700 Message-Id: <20220426181907.103691-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998991318100001 Content-Type: text/plain; charset="utf-8" Whether the cpu is in user-mode or not is something that we know at translation-time. We do not need to generate code after having raised an exception. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-15-richard.henderson@linaro.org> --- target/nios2/translate.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index eb97e13feb..d61e349207 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -169,12 +169,14 @@ static void gen_excp(DisasContext *dc, uint32_t code,= uint32_t flags) t_gen_helper_raise_exception(dc, flags); } =20 -static void gen_check_supervisor(DisasContext *dc) +static bool gen_check_supervisor(DisasContext *dc) { if (dc->base.tb->flags & CR_STATUS_U) { /* CPU in user mode, privileged instruction called, stop. */ t_gen_helper_raise_exception(dc, EXCP_SUPERI); + return false; } + return true; } =20 /* @@ -384,7 +386,9 @@ static const Nios2Instruction i_type_instructions[] =3D= { */ static void eret(DisasContext *dc, uint32_t code, uint32_t flags) { - gen_check_supervisor(dc); + if (!gen_check_supervisor(dc)) { + return; + } =20 tcg_gen_mov_tl(cpu_R[CR_STATUS], cpu_R[CR_ESTATUS]); tcg_gen_mov_tl(cpu_R[R_PC], cpu_R[R_EA]); @@ -447,7 +451,9 @@ static void rdctl(DisasContext *dc, uint32_t code, uint= 32_t flags) { R_TYPE(instr, code); =20 - gen_check_supervisor(dc); + if (!gen_check_supervisor(dc)) { + return; + } =20 if (unlikely(instr.c =3D=3D R_ZERO)) { return; @@ -474,9 +480,13 @@ static void rdctl(DisasContext *dc, uint32_t code, uin= t32_t flags) /* ctlN <- rA */ static void wrctl(DisasContext *dc, uint32_t code, uint32_t flags) { - gen_check_supervisor(dc); + if (!gen_check_supervisor(dc)) { + return; + } =20 -#ifndef CONFIG_USER_ONLY +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else R_TYPE(instr, code); TCGv v =3D load_gpr(dc, instr.a); =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165099880651419.004275166622165; Tue, 26 Apr 2022 11:46:46 -0700 (PDT) Received: from localhost ([::1]:49184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQCz-000408-GW for importer@patchew.org; Tue, 26 Apr 2022 14:46:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmY-0002YN-9E for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:38763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmV-0004Mc-Ax for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: by mail-pf1-x429.google.com with SMTP id b15so18710989pfm.5 for ; Tue, 26 Apr 2022 11:19:22 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oxknAb8WZp8/c3OBXmugT+dPS7TU38e5j5a7fcIuSm4=; b=A6ej/pQ47OMHEP9PGF0kxeHiOWzJYZb9uwPq0j6LrLToaGLadL+FLS+BZaJnVln1fB sKCeG/LZdNU0nw/0Rq+LuqsCqF/9c7Zz6LFngs9hUh2H6rdVGsRkv0ZZzbfGm2tJPmKw g+35UpkXy5LwysyYOkrzAM/9gEV9LvTzgoxlGY5BeHEHh/MLtJd15cKaCsi39imuSdKT BX3MYFeGJ3ZkNWcQUfCInFkWoE0l6qT6Mbh1G9iQCvoL/dhfr/E/rU5mRGwtDZK2MYsL N+Kyia6u2WlGElaKWHiZLm0gyxvOOITdxOgum4Rs0GsYulxQ3wWfBzBFisRy/x43DE7d SqUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oxknAb8WZp8/c3OBXmugT+dPS7TU38e5j5a7fcIuSm4=; b=1a8YlR5zAVcWBLtmHIH2UzBQ99Fwl533tdh3NTBjaCOy6RCIC68cxNAypzWTORnKA5 yD3YiN2vMfytv6bqv3gO1k3BfGm1ftJUecK5XZRwERnNSdMk0t0u7M6V8Ygr/qZ/pN77 rhynpTc2fZHWpJQrEDqrUTpiqNiznFPdAzbCK8PWWL9GjVSK6FN5N5YwTprLNe7Cy0gM up0vIf6NDVnuMGopGl5Fc1Aa6M9NxM1cuFwvSLEhRPztg31hdiUVIOxoZTbqQ3+wNq8R KEyAz9aBMlV23SQ/awfG1t03bXPqTixmM6WVjyjUmJSB2u7fqt1VHog+1d5mxif1ELoL bwhQ== X-Gm-Message-State: AOAM531KgELLZTaU7sZVh904mDPmV88PbYOYBdIzCry2kjv7jiOf22jd OxIiPPGgKuOzm28eUOzorIsm+hcvRdWa6Q== X-Google-Smtp-Source: ABdhPJxajNAXggiN8aS3ihsnByXJy9HxiRo+5j4RA9hsmdBD54zmT10lhZUMFqAE4fX995RSiY2Nyw== X-Received: by 2002:a63:5d0a:0:b0:399:40fd:2012 with SMTP id r10-20020a635d0a000000b0039940fd2012mr21063148pgb.454.1650997162063; Tue, 26 Apr 2022 11:19:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 15/68] target/nios2: Add NUM_GP_REGS and NUM_CP_REGS Date: Tue, 26 Apr 2022 11:18:14 -0700 Message-Id: <20220426181907.103691-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Amir Gonnen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1650998808630100003 Content-Type: text/plain; charset="utf-8" From: Amir Gonnen Split NUM_CORE_REGS into components that can be used elsewhere. Reviewed-by: Peter Maydell Signed-off-by: Amir Gonnen Message-Id: <20220303153906.2024748-3-amir.gonnen@neuroblade.ai> [rth: Split out of a larger patch for shadow register sets.] Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-16-richard.henderson@linaro.org> --- target/nios2/cpu.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 3198c17213..09dc38a4e7 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -56,9 +56,11 @@ struct Nios2CPUClass { #define EXCEPTION_ADDRESS 0x00000004 #define FAST_TLB_MISS_ADDRESS 0x00000008 =20 +#define NUM_GP_REGS 32 +#define NUM_CR_REGS 32 =20 /* GP regs + CR regs + PC */ -#define NUM_CORE_REGS (32 + 32 + 1) +#define NUM_CORE_REGS (NUM_GP_REGS + NUM_CR_REGS + 1) =20 /* General purpose register aliases */ #define R_ZERO 0 @@ -79,7 +81,7 @@ struct Nios2CPUClass { #define R_RA 31 =20 /* Control register aliases */ -#define CR_BASE 32 +#define CR_BASE NUM_GP_REGS #define CR_STATUS (CR_BASE + 0) #define CR_STATUS_PIE (1 << 0) #define CR_STATUS_U (1 << 1) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997612; cv=none; d=zohomail.com; s=zohoarc; b=JtjS3acG0s8kB8g6L5hPORY2AGrJtdeR+TGg/c1xR3jNv3Er0cpP8n2TWQN2KeM82wLPQ/4TzUb6VGu/we+0n76RsXvJr5jFTMzqv0at/CGWrw7IztG0M5/VGAdFk3sZNL8qyArYMSI3S4Y9b50E/iA7uBNEQdK4jr0EFWwp/jE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997612; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i6tK1AeH5jwbz3jIl7FB7GUKXxYdrLeMzRjc3oifIdk=; b=Ijpr+QUWIZVqfVR4B6mUGI/HuNzwuOZtkqRs7Dl/gQrpJ6fi+20XoP38V1GFs9pAymm6KuOj4hlIY83YolHbl1ZBlXAVLJdFrPaujOkdidfwJ7VAKbFngbjsFO9iF1WOMle4Yy7wLNUh514rVIS6GjzqsbFJD/7V6EFcQbYfDEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997612880687.7966814259609; Tue, 26 Apr 2022 11:26:52 -0700 (PDT) Received: from localhost ([::1]:33336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPtj-0006cr-Pk for importer@patchew.org; Tue, 26 Apr 2022 14:26:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmZ-0002Zt-So for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:28 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:46849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmW-0004N9-Up for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:27 -0400 Received: by mail-pf1-x432.google.com with SMTP id j6so16380541pfe.13 for ; Tue, 26 Apr 2022 11:19:23 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i6tK1AeH5jwbz3jIl7FB7GUKXxYdrLeMzRjc3oifIdk=; b=yw7K/Oe3Ag+ZRf20W76F7Cl506gMAPLzz6SXFnOSxwo0AyKuX48tfsuGvQ5L4cISt9 +j0s5nn3AcxqG+9PTkCwmGQMXWEKLYS5SmwGksHYDA/J+bN3Q9jfyzFM2d9pbn0Mvs3L T9pxJxLKih2VI29Kcctn+qQcdsC/Kgkrgls+mugWsFI+IeGNA5R6f0lIbOkViLrx4IR6 h/uAZCiLq6rOAplF02+/WUbwm4mukM1igO5YsrCU0httil8vXk1Mqq/v/ncMhfeFdGoY /ZUpFdvnFZ+4NBDxoRyb4akjqUfUmuATVJZvS/OCjnjsspPUz1E0mrqGqk3K412v1Y5f UF2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i6tK1AeH5jwbz3jIl7FB7GUKXxYdrLeMzRjc3oifIdk=; b=J4T2eRLHMQRKjcR/xEM4i3wONzZ5vBouLmJwkEhoQHOX7ryiEFSqztak1O7+NEac8/ S980t8AWdi3Z/TRF6iBsqYeY0XWHEM66KqMpBsv0JCYbEJLzux4M0XJyse0EcREvbD6G Vsihnu9ZMt2P121i8bDfmgGkiAjWR+JuFb/1I91jMTx1IxWiN7YvadDbyg9m8uRQEwgN XbFwgNP/5Uw9nRSpj35J0qFubM0Bj6QcpuhNCDgt7AzqnBKv0jB9Qrl8AZc7HiwLZyRu uFDzLiu/D+2j0dz/LaTgdYx0b6YjmAs9UGEx45kz1wNxv5Gl81QewtQy2V82x3ekcj9/ CtVw== X-Gm-Message-State: AOAM531eeySpm/MfQp4O69FE1oW4vWOrURrWaXdsYBDFNsn4HXj7a3C2 BFyyv15aoevSuMOzx2FNbGo4temcp7cdZA== X-Google-Smtp-Source: ABdhPJwt5lJSZo+YQysAJWir1o9g3S9zWikYmIFcC3a3XncYjzcCMIN4zfAt0hJju+1ngweroLtAZg== X-Received: by 2002:a05:6a00:15d0:b0:50d:3810:922e with SMTP id o16-20020a056a0015d000b0050d3810922emr14115208pfu.6.1650997162974; Tue, 26 Apr 2022 11:19:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 16/68] target/nios2: Split PC out of env->regs[] Date: Tue, 26 Apr 2022 11:18:15 -0700 Message-Id: <20220426181907.103691-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997614189100001 Content-Type: text/plain; charset="utf-8" It is cleaner to have a separate name for this variable. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-17-richard.henderson@linaro.org> --- target/nios2/cpu.h | 10 +++----- linux-user/elfload.c | 2 +- linux-user/nios2/cpu_loop.c | 19 +++++++------- linux-user/nios2/signal.c | 6 ++--- target/nios2/cpu.c | 8 +++--- target/nios2/helper.c | 49 +++++++++++++++++-------------------- target/nios2/translate.c | 29 +++++++++++----------- 7 files changed, 58 insertions(+), 65 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 09dc38a4e7..7c48b3452f 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -59,8 +59,8 @@ struct Nios2CPUClass { #define NUM_GP_REGS 32 #define NUM_CR_REGS 32 =20 -/* GP regs + CR regs + PC */ -#define NUM_CORE_REGS (NUM_GP_REGS + NUM_CR_REGS + 1) +/* GP regs + CR regs */ +#define NUM_CORE_REGS (NUM_GP_REGS + NUM_CR_REGS) =20 /* General purpose register aliases */ #define R_ZERO 0 @@ -130,9 +130,6 @@ struct Nios2CPUClass { #define CR_MPUBASE (CR_BASE + 14) #define CR_MPUACC (CR_BASE + 15) =20 -/* Other registers */ -#define R_PC 64 - /* Exceptions */ #define EXCP_BREAK 0x1000 #define EXCP_RESET 0 @@ -158,6 +155,7 @@ struct Nios2CPUClass { =20 struct CPUArchState { uint32_t regs[NUM_CORE_REGS]; + uint32_t pc; =20 #if !defined(CONFIG_USER_ONLY) Nios2MMU mmu; @@ -237,7 +235,7 @@ typedef Nios2CPU ArchCPU; static inline void cpu_get_tb_cpu_state(CPUNios2State *env, target_ulong *= pc, target_ulong *cs_base, uint32_t *f= lags) { - *pc =3D env->regs[R_PC]; + *pc =3D env->pc; *cs_base =3D 0; *flags =3D (env->regs[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U)); } diff --git a/linux-user/elfload.c b/linux-user/elfload.c index d6bb1fc7ca..397dec5eb8 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1170,7 +1170,7 @@ static void elf_core_copy_regs(target_elf_gregset_t *= regs, (*regs)[30] =3D -1; /* R_SSTATUS */ (*regs)[31] =3D tswapreg(env->regs[R_RA]); =20 - (*regs)[32] =3D tswapreg(env->regs[R_PC]); + (*regs)[32] =3D tswapreg(env->pc); =20 (*regs)[33] =3D -1; /* R_STATUS */ (*regs)[34] =3D tswapreg(env->regs[CR_ESTATUS]); diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index e725036628..a941f9032e 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -43,7 +43,7 @@ void cpu_loop(CPUNios2State *env) * TODO: This advance should be done in the translator, as * hardware produces an advanced pc as part of all exceptions. */ - env->regs[R_PC] +=3D 4; + env->pc +=3D 4; =20 switch (env->error_code) { case 0: @@ -59,7 +59,7 @@ void cpu_loop(CPUNios2State *env) break; } if (ret =3D=3D -QEMU_ERESTARTSYS) { - env->regs[R_PC] -=3D 4; + env->pc -=3D 4; break; } /* @@ -74,22 +74,21 @@ void cpu_loop(CPUNios2State *env) =20 case 1: qemu_log_mask(CPU_LOG_INT, "\nTrap 1\n"); - force_sig_fault(TARGET_SIGUSR1, 0, env->regs[R_PC]); + force_sig_fault(TARGET_SIGUSR1, 0, env->pc); break; case 2: qemu_log_mask(CPU_LOG_INT, "\nTrap 2\n"); - force_sig_fault(TARGET_SIGUSR2, 0, env->regs[R_PC]); + force_sig_fault(TARGET_SIGUSR2, 0, env->pc); break; case 31: qemu_log_mask(CPU_LOG_INT, "\nTrap 31\n"); /* Match kernel's breakpoint_c(). */ - env->regs[R_PC] -=3D 4; - force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->re= gs[R_PC]); + env->pc -=3D 4; + force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->pc= ); break; default: qemu_log_mask(CPU_LOG_INT, "\nTrap %d\n", env->error_code); - force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLTRP, - env->regs[R_PC]); + force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLTRP, env->pc); break; =20 case 16: /* QEMU specific, for __kuser_cmpxchg */ @@ -120,7 +119,7 @@ void cpu_loop(CPUNios2State *env) break; =20 case EXCP_DEBUG: - force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->regs[R= _PC]); + force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->pc); break; default: EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting= \n", @@ -156,6 +155,6 @@ void target_cpu_copy_regs(CPUArchState *env, struct tar= get_pt_regs *regs) env->regs[R_SP] =3D regs->sp; env->regs[R_GP] =3D regs->gp; env->regs[CR_ESTATUS] =3D regs->estatus; - env->regs[R_PC] =3D regs->ea; + env->pc =3D regs->ea; /* TODO: unsigned long orig_r7; */ } diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 9aa525e723..32b3dc99c6 100644 --- a/linux-user/nios2/signal.c +++ b/linux-user/nios2/signal.c @@ -73,7 +73,7 @@ static void rt_setup_ucontext(struct target_ucontext *uc,= CPUNios2State *env) __put_user(env->regs[R_RA], &gregs[23]); __put_user(env->regs[R_FP], &gregs[24]); __put_user(env->regs[R_GP], &gregs[25]); - __put_user(env->regs[R_PC], &gregs[27]); + __put_user(env->pc, &gregs[27]); __put_user(env->regs[R_SP], &gregs[28]); } =20 @@ -121,7 +121,7 @@ static int rt_restore_ucontext(CPUNios2State *env, stru= ct target_ucontext *uc) __get_user(env->regs[R_GP], &gregs[25]); /* Not really necessary no user settable bits */ __get_user(temp, &gregs[26]); - __get_user(env->regs[R_PC], &gregs[27]); + __get_user(env->pc, &gregs[27]); =20 __get_user(env->regs[R_RA], &gregs[23]); __get_user(env->regs[R_SP], &gregs[28]); @@ -177,7 +177,7 @@ void setup_rt_frame(int sig, struct target_sigaction *k= a, env->regs[4] =3D sig; env->regs[5] =3D frame_addr + offsetof(struct target_rt_sigframe, info= ); env->regs[6] =3D frame_addr + offsetof(struct target_rt_sigframe, uc); - env->regs[R_PC] =3D ka->_sa_handler; + env->pc =3D ka->_sa_handler; =20 unlock_user_struct(frame, frame_addr, 1); } diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 9774a3b8a4..dc1551241e 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -31,7 +31,7 @@ static void nios2_cpu_set_pc(CPUState *cs, vaddr value) Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUNios2State *env =3D &cpu->env; =20 - env->regs[R_PC] =3D value; + env->pc =3D value; } =20 static bool nios2_cpu_has_work(CPUState *cs) @@ -49,7 +49,7 @@ static void nios2_cpu_reset(DeviceState *dev) ncc->parent_reset(dev); =20 memset(env->regs, 0, sizeof(uint32_t) * NUM_CORE_REGS); - env->regs[R_PC] =3D cpu->reset_addr; + env->pc =3D cpu->reset_addr; =20 #if defined(CONFIG_USER_ONLY) /* Start in user mode with interrupts enabled. */ @@ -156,7 +156,7 @@ static int nios2_cpu_gdb_read_register(CPUState *cs, GB= yteArray *mem_buf, int n) if (n < 32) { /* GP regs */ return gdb_get_reg32(mem_buf, env->regs[n]); } else if (n =3D=3D 32) { /* PC */ - return gdb_get_reg32(mem_buf, env->regs[R_PC]); + return gdb_get_reg32(mem_buf, env->pc); } else if (n < 49) { /* Status regs */ return gdb_get_reg32(mem_buf, env->regs[n - 1]); } @@ -178,7 +178,7 @@ static int nios2_cpu_gdb_write_register(CPUState *cs, u= int8_t *mem_buf, int n) if (n < 32) { /* GP regs */ env->regs[n] =3D ldl_p(mem_buf); } else if (n =3D=3D 32) { /* PC */ - env->regs[R_PC] =3D ldl_p(mem_buf); + env->pc =3D ldl_p(mem_buf); } else if (n < 49) { /* Status regs */ env->regs[n - 1] =3D ldl_p(mem_buf); } diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 04a8831443..34b3e18e37 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -38,7 +38,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_IRQ: assert(env->regs[CR_STATUS] & CR_STATUS_PIE); =20 - qemu_log_mask(CPU_LOG_INT, "interrupt at pc=3D%x\n", env->regs[R_P= C]); + qemu_log_mask(CPU_LOG_INT, "interrupt at pc=3D%x\n", env->pc); =20 env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; env->regs[CR_STATUS] |=3D CR_STATUS_IH; @@ -47,14 +47,13 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[R_EA] =3D env->regs[R_PC] + 4; - env->regs[R_PC] =3D cpu->exception_addr; + env->regs[R_EA] =3D env->pc + 4; + env->pc =3D cpu->exception_addr; break; =20 case EXCP_TLBD: if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - qemu_log_mask(CPU_LOG_INT, "TLB MISS (fast) at pc=3D%x\n", - env->regs[R_PC]); + qemu_log_mask(CPU_LOG_INT, "TLB MISS (fast) at pc=3D%x\n", env= ->pc); =20 /* Fast TLB miss */ /* Variation from the spec. Table 3-35 of the cpu reference sh= ows @@ -70,11 +69,10 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; env->regs[CR_TLBMISC] |=3D CR_TLBMISC_WR; =20 - env->regs[R_EA] =3D env->regs[R_PC] + 4; - env->regs[R_PC] =3D cpu->fast_tlb_miss_addr; + env->regs[R_EA] =3D env->pc + 4; + env->pc =3D cpu->fast_tlb_miss_addr; } else { - qemu_log_mask(CPU_LOG_INT, "TLB MISS (double) at pc=3D%x\n", - env->regs[R_PC]); + qemu_log_mask(CPU_LOG_INT, "TLB MISS (double) at pc=3D%x\n", e= nv->pc); =20 /* Double TLB miss */ env->regs[CR_STATUS] |=3D CR_STATUS_EH; @@ -85,14 +83,14 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 env->regs[CR_TLBMISC] |=3D CR_TLBMISC_DBL; =20 - env->regs[R_PC] =3D cpu->exception_addr; + env->pc =3D cpu->exception_addr; } break; =20 case EXCP_TLBR: case EXCP_TLBW: case EXCP_TLBX: - qemu_log_mask(CPU_LOG_INT, "TLB PERM at pc=3D%x\n", env->regs[R_PC= ]); + qemu_log_mask(CPU_LOG_INT, "TLB PERM at pc=3D%x\n", env->pc); =20 env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; env->regs[CR_STATUS] |=3D CR_STATUS_EH; @@ -105,19 +103,18 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_TLBMISC] |=3D CR_TLBMISC_WR; } =20 - env->regs[R_EA] =3D env->regs[R_PC] + 4; - env->regs[R_PC] =3D cpu->exception_addr; + env->regs[R_EA] =3D env->pc + 4; + env->pc =3D cpu->exception_addr; break; =20 case EXCP_SUPERA: case EXCP_SUPERI: case EXCP_SUPERD: - qemu_log_mask(CPU_LOG_INT, "SUPERVISOR exception at pc=3D%x\n", - env->regs[R_PC]); + qemu_log_mask(CPU_LOG_INT, "SUPERVISOR exception at pc=3D%x\n", en= v->pc); =20 if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; - env->regs[R_EA] =3D env->regs[R_PC] + 4; + env->regs[R_EA] =3D env->pc + 4; } =20 env->regs[CR_STATUS] |=3D CR_STATUS_EH; @@ -126,17 +123,16 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[R_PC] =3D cpu->exception_addr; + env->pc =3D cpu->exception_addr; break; =20 case EXCP_ILLEGAL: case EXCP_TRAP: - qemu_log_mask(CPU_LOG_INT, "TRAP exception at pc=3D%x\n", - env->regs[R_PC]); + qemu_log_mask(CPU_LOG_INT, "TRAP exception at pc=3D%x\n", env->pc); =20 if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; - env->regs[R_EA] =3D env->regs[R_PC] + 4; + env->regs[R_EA] =3D env->pc + 4; } =20 env->regs[CR_STATUS] |=3D CR_STATUS_EH; @@ -145,24 +141,23 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[R_PC] =3D cpu->exception_addr; + env->pc =3D cpu->exception_addr; break; =20 case EXCP_BREAK: - qemu_log_mask(CPU_LOG_INT, "BREAK exception at pc=3D%x\n", - env->regs[R_PC]); + qemu_log_mask(CPU_LOG_INT, "BREAK exception at pc=3D%x\n", env->pc= ); /* The semihosting instruction is "break 1". */ if (semihosting_enabled() && - cpu_ldl_code(env, env->regs[R_PC]) =3D=3D 0x003da07a) { + cpu_ldl_code(env, env->pc) =3D=3D 0x003da07a) { qemu_log_mask(CPU_LOG_INT, "Entering semihosting\n"); - env->regs[R_PC] +=3D 4; + env->pc +=3D 4; do_nios2_semihosting(env); break; } =20 if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->regs[CR_BSTATUS] =3D env->regs[CR_STATUS]; - env->regs[R_BA] =3D env->regs[R_PC] + 4; + env->regs[R_BA] =3D env->pc + 4; } =20 env->regs[CR_STATUS] |=3D CR_STATUS_EH; @@ -171,7 +166,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[R_PC] =3D cpu->exception_addr; + env->pc =3D cpu->exception_addr; break; =20 default: diff --git a/target/nios2/translate.c b/target/nios2/translate.c index d61e349207..226bd9e30b 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -104,6 +104,7 @@ typedef struct DisasContext { } DisasContext; =20 static TCGv cpu_R[NUM_CORE_REGS]; +static TCGv cpu_pc; =20 typedef struct Nios2Instruction { void (*handler)(DisasContext *dc, uint32_t code, uint32_t flags); @@ -144,7 +145,7 @@ static void t_gen_helper_raise_exception(DisasContext *= dc, { TCGv_i32 tmp =3D tcg_const_i32(index); =20 - tcg_gen_movi_tl(cpu_R[R_PC], dc->pc); + tcg_gen_movi_tl(cpu_pc, dc->pc); gen_helper_raise_exception(cpu_env, tmp); tcg_temp_free_i32(tmp); dc->base.is_jmp =3D DISAS_NORETURN; @@ -156,10 +157,10 @@ static void gen_goto_tb(DisasContext *dc, int n, uint= 32_t dest) =20 if (translator_use_goto_tb(&dc->base, dest)) { tcg_gen_goto_tb(n); - tcg_gen_movi_tl(cpu_R[R_PC], dest); + tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(tb, n); } else { - tcg_gen_movi_tl(cpu_R[R_PC], dest); + tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(NULL, 0); } } @@ -391,7 +392,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) } =20 tcg_gen_mov_tl(cpu_R[CR_STATUS], cpu_R[CR_ESTATUS]); - tcg_gen_mov_tl(cpu_R[R_PC], cpu_R[R_EA]); + tcg_gen_mov_tl(cpu_pc, cpu_R[R_EA]); =20 dc->base.is_jmp =3D DISAS_JUMP; } @@ -399,7 +400,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) /* PC <- ra */ static void ret(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_mov_tl(cpu_R[R_PC], cpu_R[R_RA]); + tcg_gen_mov_tl(cpu_pc, cpu_R[R_RA]); =20 dc->base.is_jmp =3D DISAS_JUMP; } @@ -407,7 +408,7 @@ static void ret(DisasContext *dc, uint32_t code, uint32= _t flags) /* PC <- ba */ static void bret(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_mov_tl(cpu_R[R_PC], cpu_R[R_BA]); + tcg_gen_mov_tl(cpu_pc, cpu_R[R_BA]); =20 dc->base.is_jmp =3D DISAS_JUMP; } @@ -417,7 +418,7 @@ static void jmp(DisasContext *dc, uint32_t code, uint32= _t flags) { R_TYPE(instr, code); =20 - tcg_gen_mov_tl(cpu_R[R_PC], load_gpr(dc, instr.a)); + tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); =20 dc->base.is_jmp =3D DISAS_JUMP; } @@ -440,7 +441,7 @@ static void callr(DisasContext *dc, uint32_t code, uint= 32_t flags) { R_TYPE(instr, code); =20 - tcg_gen_mov_tl(cpu_R[R_PC], load_gpr(dc, instr.a)); + tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); tcg_gen_movi_tl(cpu_R[R_RA], dc->base.pc_next); =20 dc->base.is_jmp =3D DISAS_JUMP; @@ -742,7 +743,7 @@ illegal_op: t_gen_helper_raise_exception(dc, EXCP_ILLEGAL); } =20 -static const char * const regnames[] =3D { +static const char * const regnames[NUM_CORE_REGS] =3D { "zero", "at", "r2", "r3", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11", @@ -759,7 +760,6 @@ static const char * const regnames[] =3D { "reserved6", "reserved7", "reserved8", "reserved9", "reserved10", "reserved11", "reserved12", "reserved13", "reserved14", "reserved15", "reserved16", "reserved17", - "rpc" }; =20 #include "exec/gen-icount.h" @@ -827,7 +827,7 @@ static void nios2_tr_tb_stop(DisasContextBase *dcbase, = CPUState *cs) case DISAS_TOO_MANY: case DISAS_UPDATE: /* Save the current PC back into the CPU register */ - tcg_gen_movi_tl(cpu_R[R_PC], dc->base.pc_next); + tcg_gen_movi_tl(cpu_pc, dc->base.pc_next); tcg_gen_exit_tb(NULL, 0); break; =20 @@ -877,8 +877,7 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int fl= ags) return; } =20 - qemu_fprintf(f, "IN: PC=3D%x %s\n", - env->regs[R_PC], lookup_symbol(env->regs[R_PC])); + qemu_fprintf(f, "IN: PC=3D%x %s\n", env->pc, lookup_symbol(env->pc)); =20 for (i =3D 0; i < NUM_CORE_REGS; i++) { qemu_fprintf(f, "%9s=3D%8.8x ", regnames[i], env->regs[i]); @@ -904,10 +903,12 @@ void nios2_tcg_init(void) offsetof(CPUNios2State, regs[i]), regnames[i]); } + cpu_pc =3D tcg_global_mem_new(cpu_env, + offsetof(CPUNios2State, pc), "pc"); } =20 void restore_state_to_opc(CPUNios2State *env, TranslationBlock *tb, target_ulong *data) { - env->regs[R_PC] =3D data[0]; + env->pc =3D data[0]; } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999223566908.5908618545075; Tue, 26 Apr 2022 11:53:43 -0700 (PDT) Received: from localhost ([::1]:38266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQJi-0007ny-Ei for importer@patchew.org; Tue, 26 Apr 2022 14:53:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmZ-0002ZJ-1L for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:28 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:40497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmX-0004Nj-3J for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:26 -0400 Received: by mail-pf1-x42c.google.com with SMTP id i24so18692275pfa.7 for ; Tue, 26 Apr 2022 11:19:24 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qf4cYEUah8+UZ9PulZzd1wKH6UWiuDaNT9BP/AwB7KQ=; b=JuuwjbvniXbPi87xZ7zDwLsJpsP6IwmCz8H/JJ6C4PYyuK75/Qc5508f6PSSBqvWHI SPYD3Ry4FKYpTt6BnGY6xbHIsFTuAHPFsM/YB6S40AtCDip0R2iuNmPzWp/r0HC/Dz/f is7JJDPmH6FoUGlAEsygZaLMvpOsNSXAWBc0k7UkVsRFNIdYGvU3W+HokFqMSz9WclC2 K9lAw5yEZDbh0xT5MNFw0GQ38HsdEQIKbLa7QxFjD/4xlPr7XduEbCYCUbIZpMfTD5N/ Ut2c326GSXpimypyUGCuXEXfpiex9f7LWgY0OU8/5FSogTqy81pMGtEk7Dn47F0WQlvb OSGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qf4cYEUah8+UZ9PulZzd1wKH6UWiuDaNT9BP/AwB7KQ=; b=qsWdsVqaLFhMWauTNq9qQkR7YV7tg3wVNGpaozaZvNZEkNRtRMLtZvbLdXz18LGGNo rU5wuX/vk0+T7jWcb4yl2ql4wCMpV9WxW1Xp74/JXY08p6gAgOhE3yeuL7pcaQSoKkkf hiycqe32dBFTjrDX3rOljDH3cil9YLtPkEw8KDrTct7tC8t1fJlLu9zSyok4YZIfatgm 3uobhrpzHXKt5bFEwiEj2ijO0yDH/1DBR2I8SVKaox7O4Y9TNpkVIvQNUCR0lxnM4xL8 ai+5m/xqmfa9B28y70pxtA/A1zmHihBdsvUW40DI1EGxbZKm4z47+fwxridb4fUBYkI6 eTeA== X-Gm-Message-State: AOAM532eu4S/NZXH/GtOhD0Pa4ac92v8qRNhwP0P+khbqb5jN0b3TrLz sbI5IspwWmsGjRyL2cVmLSyQJ36ncrg78w== X-Google-Smtp-Source: ABdhPJxM4qip5O46x1i1p9plST4ACLm8GywJ0VLTRRc7AsN2c7vNEjCLEGF8KenQ/mSVukmvEtNUZA== X-Received: by 2002:a65:41c3:0:b0:363:5711:e234 with SMTP id b3-20020a6541c3000000b003635711e234mr20855804pgq.386.1650997163851; Tue, 26 Apr 2022 11:19:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 17/68] target/nios2: Split out helper for eret instruction Date: Tue, 26 Apr 2022 11:18:16 -0700 Message-Id: <20220426181907.103691-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Amir Gonnen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1650999224520100001 Content-Type: text/plain; charset="utf-8" From: Amir Gonnen The implementation of eret will become much more complex with the introduction of shadow registers. [rth: Split out of a larger patch for shadow register sets. Directly exit to the cpu loop from the helper.] Reviewed-by: Peter Maydell Signed-off-by: Amir Gonnen Message-Id: <20220303153906.2024748-3-amir.gonnen@neuroblade.ai> Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-18-richard.henderson@linaro.org> --- target/nios2/helper.h | 1 + target/nios2/op_helper.c | 9 +++++++++ target/nios2/translate.c | 10 ++++++---- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/target/nios2/helper.h b/target/nios2/helper.h index a44ecfdf7a..525b6b685b 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -21,6 +21,7 @@ DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) =20 #if !defined(CONFIG_USER_ONLY) +DEF_HELPER_3(eret, noreturn, env, i32, i32) DEF_HELPER_2(mmu_write_tlbacc, void, env, i32) DEF_HELPER_2(mmu_write_tlbmisc, void, env, i32) DEF_HELPER_2(mmu_write_pteaddr, void, env, i32) diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index caa885f7b4..ee5ad8b23f 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -30,3 +30,12 @@ void helper_raise_exception(CPUNios2State *env, uint32_t= index) cs->exception_index =3D index; cpu_loop_exit(cs); } + +#ifndef CONFIG_USER_ONLY +void helper_eret(CPUNios2State *env, uint32_t new_status, uint32_t new_pc) +{ + env->regs[CR_STATUS] =3D new_status; + env->pc =3D new_pc; + cpu_loop_exit(env_cpu(env)); +} +#endif /* !CONFIG_USER_ONLY */ diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 226bd9e30b..53699ee088 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -391,10 +391,12 @@ static void eret(DisasContext *dc, uint32_t code, uin= t32_t flags) return; } =20 - tcg_gen_mov_tl(cpu_R[CR_STATUS], cpu_R[CR_ESTATUS]); - tcg_gen_mov_tl(cpu_pc, cpu_R[R_EA]); - - dc->base.is_jmp =3D DISAS_JUMP; +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + gen_helper_eret(cpu_env, cpu_R[CR_ESTATUS], cpu_R[R_EA]); + dc->base.is_jmp =3D DISAS_NORETURN; +#endif } =20 /* PC <- ra */ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998596; cv=none; d=zohomail.com; s=zohoarc; b=aVTHLOMbXhAX2YNMnZB4lLh+Aq2zwWWmw711DwqrayfKwaUMLQq8Lx20irpvf7sbTMsqDqLhoe2lOmRv8GZs7E+Wf/KpxIDdtx0igkQ0viVs8tWjBEqW/J4XhU2hPJhqon1+tTcS/SiHeLSAyW5sByiwIFcGYuNcL7KlUTxq8jw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998596; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i+pIlq3Zf7Ct4aEs80TxFQjBRjx+ntMdX+PCJRolBhs=; b=S+Id/G/asGZwFQ94tUqiu4X1+xk3Qa8PKVa9GwlwfPnj5C2nqRX03QxfOc7kbxnKAEPqSb46qPYDPrfAzWpjjTn/Ag8P6QcAa3tnRHOP5nJuTZHzZxMAhf5jHWyBMn92lyNU8WYj6JGdp9IG0dihW69HuxHKAh131FlKgwueDDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998596585759.422085759661; Tue, 26 Apr 2022 11:43:16 -0700 (PDT) Received: from localhost ([::1]:38486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ9b-00055b-84 for importer@patchew.org; Tue, 26 Apr 2022 14:43:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmZ-0002Zq-KO for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:28 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:35603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmY-0004OA-3y for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:27 -0400 Received: by mail-pg1-x529.google.com with SMTP id r83so16743077pgr.2 for ; Tue, 26 Apr 2022 11:19:25 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i+pIlq3Zf7Ct4aEs80TxFQjBRjx+ntMdX+PCJRolBhs=; b=h1M3ibQBXkj7y4vkNLhPwa2fp6HzgBPebAtCu/FIOr/3s9Y8zM9gPUYO2uC7DRFOVe NKooUyUITPmzRKCneXz5bFiGGGshblIZwsayp+foyh0MfSqs9/+ZeZLAxaM+ByvSDmTb YhYaPhboYAEZHV/zlbLA0E2n5PUr1wo2Jpa5FHx/HfxSYfwhecA227pZvKDA1tnbL2hS ti9PLcEteXSYkI7JCS3nlLjFdsRg9VlK182NzKMYkkGtvMVX8O4cxUfp9QSOC1cdfADG r86cQtAbBtiGBd9FelFirjh9usi3nZsBNuL1fwtyPChiUjZOAMdo4Qr/OkjFrUDgrzs4 cc4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i+pIlq3Zf7Ct4aEs80TxFQjBRjx+ntMdX+PCJRolBhs=; b=S9JgSgslTgGbMk+re3bJON+QIvIOzxF/7+SEfIix4ZZVMdf8yAYsJT/zQA7AhaLuFQ 8J784vGVrC42n4MxvAeaRyyxZgjll8Inve8GDyd/e/SjbhJjHNPNVKVoCtavJYC0QgMg ws/Bjz0NxucbQbz3QQWb27KIiM4KSh3JBr4U+n+RkvgSTBH+RuN1Y09zbnZM5YG8HL4R tjudpkycUrqswG9T8he04hva6Z7QSCx1X6/6LlS+SC8TkTk38shHikG48G/TeITaWxvJ /r8v83u3MkBz8Vxlwlh9u9rb1+CLYWk97ThMJUCiIIwPt839WcaB7fdmQFNeaHg+TI6X PhVA== X-Gm-Message-State: AOAM531/LqeHKviUXyeihk4i3PTV6PBzCMl3ar623r0c+pz0RMDfe1tg ZJZTHGC7Ra7XSccjoF4ovR+80E3OAcTRuA== X-Google-Smtp-Source: ABdhPJwzsKB9i50pm2uBZFBPAEfqPxld02DPKBX3RF2Cn7zXSUVYjN81FyNxlDr20HQyMoCuz2mtNg== X-Received: by 2002:a65:6657:0:b0:381:1b99:3f04 with SMTP id z23-20020a656657000000b003811b993f04mr20390053pgv.512.1650997164770; Tue, 26 Apr 2022 11:19:24 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 18/68] target/nios2: Fix BRET instruction Date: Tue, 26 Apr 2022 11:18:17 -0700 Message-Id: <20220426181907.103691-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998598188100001 Content-Type: text/plain; charset="utf-8" We had failed to copy BSTATUS back to STATUS, and diagnose supervisor-only. The spec is light on the specifics of the implementation of bret, but it is an easy assumption that the restore into STATUS should work the same as eret. Therefore, reuse the existing helper_eret. Reviewed-by: Peter Maydell Reported-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-19-richard.henderson@linaro.org> --- target/nios2/translate.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 53699ee088..3694f2503b 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -407,12 +407,22 @@ static void ret(DisasContext *dc, uint32_t code, uint= 32_t flags) dc->base.is_jmp =3D DISAS_JUMP; } =20 -/* PC <- ba */ +/* + * status <- bstatus + * PC <- ba + */ static void bret(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_mov_tl(cpu_pc, cpu_R[R_BA]); + if (!gen_check_supervisor(dc)) { + return; + } =20 - dc->base.is_jmp =3D DISAS_JUMP; +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + gen_helper_eret(cpu_env, cpu_R[CR_BSTATUS], cpu_R[R_BA]); + dc->base.is_jmp =3D DISAS_NORETURN; +#endif } =20 /* PC <- rA */ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999046; cv=none; d=zohomail.com; s=zohoarc; b=FY9vXOb3N8UIgV2pD77gp18GQR8PiUa7GEJbaXIF9MfbQIQ4DjjcrrwqY9/u+MkJC8+TlTyfqVFVYsNHzCJ3ecyA1ZBvQDZ5S8JCQMIuU6n8eSE/pC0NPJB1QG2/Jpil/d7uKey8x2bEFKdlwvs9MhVMES0yQJWQFYbxWBdrzxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999046; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r8f+qzpvdgvny2fiqiDe7wZJGOpE02k47NFtBiJd8Y4=; b=gdaO+J7MKKkklYouI0+yuRALva6epzMEtx2zKVgjdn7NsCkqI7ONkROaIEETlJ3L+Z65bGMlbZj3M/Dq9r7p+G0aj2xT+xrSCBCFBtQbLbidsr5AgULYJ91/MYQgTDdMcRHJ3XzfrLBYAxCl7JzmJn7Up+JFwq8trBu7NUq78Oc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999046794156.1387168478003; Tue, 26 Apr 2022 11:50:46 -0700 (PDT) Received: from localhost ([::1]:59840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQGr-0002zO-PY for importer@patchew.org; Tue, 26 Apr 2022 14:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPma-0002Zv-Kp for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:28 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:37408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmZ-0004Pf-0G for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:28 -0400 Received: by mail-pf1-x430.google.com with SMTP id bo5so18710784pfb.4 for ; Tue, 26 Apr 2022 11:19:26 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r8f+qzpvdgvny2fiqiDe7wZJGOpE02k47NFtBiJd8Y4=; b=j4lpQpYKJsrOYcVTMVMWT5kSaARuKEBBvutNWWdBhuSpPZAnbYKRVDDwA7P3jzRyjz fAUU+o8uU7eWWmbbusHF8uja9Qg400U3wRmd7gAYbth0my0s+VHW7lmcMebIdZtjrIHq aTrn+46lLe1hHU4x4WCdG/JGsvHsrE5tNdE+MrWsMVqw3kBOL+NaGTuNgU2feIOuNN95 p9Uc9ubtKemusQimeqNd80nQbvE8goONGEjPRMwf1WR7ta9B4iQKYRZ3hKiiOQkhh3ON YMI4ctCBBFxBaTnnvFUc3yYx0QpLNDT5Vpr3Qj609ylZHLzaAcOMCrIeX+GdSSriRj1y 31Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8f+qzpvdgvny2fiqiDe7wZJGOpE02k47NFtBiJd8Y4=; b=uhFtOr4qoRXfg2FVEYh68hDetokT/xf+iHEyJEIdArbG49p84bipwxFpNx3sbmagdZ kXuFgijEXrkqtCQB/ZKMAoAdvYJVGPFXqV9ajzJ8Fiasqw7L9g3rV0jCWAnFehwxoY+M blf4uzVMJYX6VDw9hlJLhONSvzOaQm/pXZ4l5hZrG6nunwjgyVzD0usYpiTS8qpAPzP9 hJdZxfJnl5nyOiGxcsv0VNCxbMNR+x5jsPSu0NvWr5icKggfy6jS79kFGO1rm9jcVrSj 9w0WxTi+VaxRxS4jIZmV+dGUawUIUEnem3zvML+tAR68mHRin5dDUGbRap+jNmAHcpQd pQ3w== X-Gm-Message-State: AOAM531LHQSqYW0pdYRR/kS1q6fDhysByOIVh9APY4JQd3NARW3d6lVe JrcLH5/euzMtzds9Q98SGMKfYiMOWaGY+g== X-Google-Smtp-Source: ABdhPJz7vjOtwTZcOcFuMsrtPwAVAC12V2xkoJQz6QaW5GQtpsaD1VEA0s9tu5OOOPQw4hXwQpoSqA== X-Received: by 2002:a05:6a00:1695:b0:4f7:decc:506b with SMTP id k21-20020a056a00169500b004f7decc506bmr25598364pfc.7.1650997165638; Tue, 26 Apr 2022 11:19:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 19/68] target/nios2: Do not create TCGv for control registers Date: Tue, 26 Apr 2022 11:18:18 -0700 Message-Id: <20220426181907.103691-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999047546100001 Content-Type: text/plain; charset="utf-8" We don't need to reference them often, and when we do it is just as easy to load/store from cpu_env directly. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-20-richard.henderson@linaro.org> --- target/nios2/translate.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 3694f2503b..6c739bfa5e 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -103,7 +103,7 @@ typedef struct DisasContext { int mem_idx; } DisasContext; =20 -static TCGv cpu_R[NUM_CORE_REGS]; +static TCGv cpu_R[NUM_GP_REGS]; static TCGv cpu_pc; =20 typedef struct Nios2Instruction { @@ -394,7 +394,11 @@ static void eret(DisasContext *dc, uint32_t code, uint= 32_t flags) #ifdef CONFIG_USER_ONLY g_assert_not_reached(); #else - gen_helper_eret(cpu_env, cpu_R[CR_ESTATUS], cpu_R[R_EA]); + TCGv tmp =3D tcg_temp_new(); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, regs[CR_ESTATUS])); + gen_helper_eret(cpu_env, tmp, cpu_R[R_EA]); + tcg_temp_free(tmp); + dc->base.is_jmp =3D DISAS_NORETURN; #endif } @@ -420,7 +424,11 @@ static void bret(DisasContext *dc, uint32_t code, uint= 32_t flags) #ifdef CONFIG_USER_ONLY g_assert_not_reached(); #else - gen_helper_eret(cpu_env, cpu_R[CR_BSTATUS], cpu_R[R_BA]); + TCGv tmp =3D tcg_temp_new(); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, regs[CR_BSTATUS])); + gen_helper_eret(cpu_env, tmp, cpu_R[R_BA]); + tcg_temp_free(tmp); + dc->base.is_jmp =3D DISAS_NORETURN; #endif } @@ -463,6 +471,7 @@ static void callr(DisasContext *dc, uint32_t code, uint= 32_t flags) static void rdctl(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, code); + TCGv t1, t2; =20 if (!gen_check_supervisor(dc)) { return; @@ -482,10 +491,19 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) * must perform the AND here, and anywhere else we need the * guest value of ipending. */ - tcg_gen_and_tl(cpu_R[instr.c], cpu_R[CR_IPENDING], cpu_R[CR_IENABL= E]); + t1 =3D tcg_temp_new(); + t2 =3D tcg_temp_new(); + tcg_gen_ld_tl(t1, cpu_env, + offsetof(CPUNios2State, regs[CR_IPENDING])); + tcg_gen_ld_tl(t2, cpu_env, + offsetof(CPUNios2State, regs[CR_IENABLE])); + tcg_gen_and_tl(cpu_R[instr.c], t1, t2); + tcg_temp_free(t1); + tcg_temp_free(t2); break; default: - tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); + tcg_gen_ld_tl(cpu_R[instr.c], cpu_env, + offsetof(CPUNios2State, regs[instr.imm5 + CR_BASE])); break; } } @@ -522,7 +540,8 @@ static void wrctl(DisasContext *dc, uint32_t code, uint= 32_t flags) dc->base.is_jmp =3D DISAS_UPDATE; /* fall through */ default: - tcg_gen_mov_tl(cpu_R[instr.imm5 + CR_BASE], v); + tcg_gen_st_tl(v, cpu_env, + offsetof(CPUNios2State, regs[instr.imm5 + CR_BASE])); break; } #endif @@ -910,7 +929,7 @@ void nios2_tcg_init(void) { int i; =20 - for (i =3D 0; i < NUM_CORE_REGS; i++) { + for (i =3D 0; i < NUM_GP_REGS; i++) { cpu_R[i] =3D tcg_global_mem_new(cpu_env, offsetof(CPUNios2State, regs[i]), regnames[i]); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998369; cv=none; d=zohomail.com; s=zohoarc; b=Ih6Btt//oOnrj2kPmB/h+QTLBq84Di1Ofkf3XzUoWAVKrhEyeCK9FL0Miu0selR5y0jrPcFUmkpRXLFgPlReCxjIyzSdqa3hY/K6f8qiUcdtOjCqcxuAEYIIDcrU9VPlpYqr6aHgrTK08GnGA1I4DvfRvI1wjb5Q5m9f4fDUzM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998369; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XWBe6x9J/Z2cYvBtaKJvqh+NFZjbIgZiKhNrx43HC0o=; b=gXZ1m0NoBHvPM/hvMOsJEn+yfFqyTVSHDw8j82wviMLNyfFY8TCdVMpHZQe8SwQJAlyl6hfHuCx+41LzoZzuiOeoRdq0/lrmYbqQ/LHdHR8AgBrCSaY62lQ+6L5WLtCCT2HlAbMLqUs7zCOc53OGuZ/deR7+h4N9GViNh+lKiUM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998369971703.4005502102649; Tue, 26 Apr 2022 11:39:29 -0700 (PDT) Received: from localhost ([::1]:58852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ5x-0007tu-0Q for importer@patchew.org; Tue, 26 Apr 2022 14:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmb-0002ci-Fe for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:30 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:46853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmZ-0004Pz-Uy for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:29 -0400 Received: by mail-pf1-x436.google.com with SMTP id j6so16380692pfe.13 for ; Tue, 26 Apr 2022 11:19:27 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XWBe6x9J/Z2cYvBtaKJvqh+NFZjbIgZiKhNrx43HC0o=; b=TD+T1mZ4hjt2wuHTYsr8xHo7bG18IAWwTl4YNmoEKB5g+eRwGjp7kbJi1XTjaC2m32 JRcj0WafA66XWt7XJsKJmuEkBTRl39DAj3QimHAp4s1CCgxNVD+NFe8skpya0QCGjMMd AmU3u7OHoLQfNrUpq/FW6043hxR3fLmbjHrEpUn0DrZhEsaweZXOV1Lo/zjth5jWcZRf 5bmE7CgN+5wayGtQrvMYD5oh4xLGllDNczie9bRMioAGYdXlU9EmOwTZolCLXROPZNTW QgeycLacvnNeQS3vSmeqN230X/kjAdblr3R52xal3Cm+Hz6JsZtmblGU9jc0j+uLK5QH LQBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XWBe6x9J/Z2cYvBtaKJvqh+NFZjbIgZiKhNrx43HC0o=; b=EpMDWNDFEHM8LAyp1OCD2wAjGYkC65HGCha84YrhgYCfc6G4p9hANBzVAb/FX9WMsu e68XNj/f0Y1a62l8FSG8GE7UTHEifFX20HU7wlbMjJrg0rREcTSFHkzLQGNyslliUTtg mt1lAhozO9PZirHACzdkgheo+mFRlA87/SMNNTsfSVWzyax7y0KHOCpgGljShDO00WAb yuQnszm2EcHOek/ucXUWImCdFXw7UOQ+/y1Hp0CppJaboNeEA0PFrJYI6YAQMhiNYTFg GfWABBAcCYlxaEfLCbReboKpiDUqgO6qZqqt4dHXHN7LP5Q/DWl94kM0cTfiZI973r7o OGSw== X-Gm-Message-State: AOAM533efvUnF23FN0t/xxj1J6i4rCgzjxT9EvmeaGQijKngOYr9s/TD qxRWWwwb84quJ2yG1+C9RGULm6jmlsHkWA== X-Google-Smtp-Source: ABdhPJy95I4USoGF2lAWUUg8Y+9YJPyiYXlxke2hoVWuUSsEP+6eNA6owiUjQck+bP8RL7ma7BXtcA== X-Received: by 2002:a05:6a00:1943:b0:4cb:79c9:fa48 with SMTP id s3-20020a056a00194300b004cb79c9fa48mr25628813pfk.47.1650997166606; Tue, 26 Apr 2022 11:19:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 20/68] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs Date: Tue, 26 Apr 2022 11:18:19 -0700 Message-Id: <20220426181907.103691-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998370193100001 Content-Type: text/plain; charset="utf-8" Drop the set of estatus in init_thread; it was clearly intended to be setting the value of CR_STATUS for the application, but we never actually performed that copy. However, the proper value is set in nios2_cpu_reset so we don't need to do anything here. We only initialize SP and EA in init_thread, there's no value in copying other uninitialized data into ENV. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-21-richard.henderson@linaro.org> --- linux-user/elfload.c | 1 - linux-user/nios2/cpu_loop.c | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 397dec5eb8..61063fd974 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1096,7 +1096,6 @@ static void init_thread(struct target_pt_regs *regs, = struct image_info *infop) { regs->ea =3D infop->entry; regs->sp =3D infop->start_stack; - regs->estatus =3D 0x3; } =20 #define LO_COMMPAGE TARGET_PAGE_SIZE diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a941f9032e..c5e68ac048 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -133,28 +133,6 @@ void cpu_loop(CPUNios2State *env) =20 void target_cpu_copy_regs(CPUArchState *env, struct target_pt_regs *regs) { - env->regs[0] =3D 0; - env->regs[1] =3D regs->r1; - env->regs[2] =3D regs->r2; - env->regs[3] =3D regs->r3; - env->regs[4] =3D regs->r4; - env->regs[5] =3D regs->r5; - env->regs[6] =3D regs->r6; - env->regs[7] =3D regs->r7; - env->regs[8] =3D regs->r8; - env->regs[9] =3D regs->r9; - env->regs[10] =3D regs->r10; - env->regs[11] =3D regs->r11; - env->regs[12] =3D regs->r12; - env->regs[13] =3D regs->r13; - env->regs[14] =3D regs->r14; - env->regs[15] =3D regs->r15; - /* TODO: unsigned long orig_r2; */ - env->regs[R_RA] =3D regs->ra; - env->regs[R_FP] =3D regs->fp; env->regs[R_SP] =3D regs->sp; - env->regs[R_GP] =3D regs->gp; - env->regs[CR_ESTATUS] =3D regs->estatus; env->pc =3D regs->ea; - /* TODO: unsigned long orig_r7; */ } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998607; cv=none; d=zohomail.com; s=zohoarc; b=J9tkU+jq3BuIK+yMUe1SK57d2u9TwrbYetqSceP2C9zL+3xtD04QIHLC0/hSerC3yIaYIvTheMN5pnMCN7RSRJm0AdwWnDnjpPZvmR8NUHN6fqHi4fKAVbJszbuF4vZXskN+QDkD5DXFSOcuMOl/UkAevJd6H2R2wDdWEXejyPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998607; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WDgeHzUdOULYKlRg869VIeEkdCFXvvv6jSBdC5RVE7o=; b=GoXHKJn/eD+zcphAxO3+6auoLjrDD2SssZ/taWO59Dp5S/oBMLL5MBkAUhJvfk/cZCj8HFuB2F2+fXR6ln0Z7A1nu6PzLVz+Ell3jCNxm32E5E22gtfMlIw5cL39AXHcQTuzNCBb2z9Qmn6aMXD8PAIvLV1gx+KlcfP43v0LqiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998607246982.683068752273; Tue, 26 Apr 2022 11:43:27 -0700 (PDT) Received: from localhost ([::1]:39314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ9l-0005dX-Ls for importer@patchew.org; Tue, 26 Apr 2022 14:43:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmc-0002ck-NX for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:30 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:34332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPma-0004QK-P6 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:29 -0400 Received: by mail-pg1-x536.google.com with SMTP id z21so9083025pgj.1 for ; Tue, 26 Apr 2022 11:19:28 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WDgeHzUdOULYKlRg869VIeEkdCFXvvv6jSBdC5RVE7o=; b=OPPpJ95oBR+hnc38bznC0AoirOBDhlNwfwHvEoh1EqDxLGEi+fntxY1Iazj5lRlfOx mDBQfTw8brFMSt9QEi7c+vlazgph2Hfc2MYBT2gBl8CvcHzIwGEQwKzvYnxOveZtmrcQ Ll2F2DzuqtEW6O6GDOGNii0N42Wv8gxIcsOSnTqJwiV7kdJEy1ZT3jCoVKmWEAJR0507 XqW4v0dK16JeNK/p62VvPnoQ0WK7atvB7K1aoDyK/ZzI4+QeO52ktIJVrKDWhlG8rUuG ngx2+naM3AczDrOK0s+qz49lJWMYcL4dk3lF7RGKOTzLOgWAJ96vefOSyCWUZdoH8gzA Q4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WDgeHzUdOULYKlRg869VIeEkdCFXvvv6jSBdC5RVE7o=; b=CGlJZloHN0MWfwohFZ2q4tATdcbqPTg8va5Pnc9ddkgofxuvbKK6Pp03cCx1JuRNbX dQA2Oy9vieefAXFYN8PnoAWvapAsU8f0HWfOZwCj4HNd/OgGE8hKdonzvOw3zpN2lOK+ Zh9vIX0cBDVOjw+QiTE8JPmPFEovu4bj1eUQv5dioDApOghse+48lh5abA6U56HBjzfw mcZ+dOi+Ti5hiBw+B37eq5ykxM3pQelbePZGE2rKcw6qvuefYJnjzpv3gcr0xIBHU3aB qzuezXIJ9y1aop6OWUDS++YXjgKu/3v4mjA/LXrg3/QIL7MfP47WZYXc1ycsr9xw4KH+ tSKg== X-Gm-Message-State: AOAM531tLgZK9EqA/1cJgm5Snjy0tJogG73Db3OkoRZ0LqNA+SZweYG0 2bBSJ4DTFrPAvh7X0CzdcXNQYtmtur0MpQ== X-Google-Smtp-Source: ABdhPJyS6bLQvTMM6+RCYubxmZSK39Txa7lDEGZUC5r0w1CSlkxY3ybkcI/KyahCzvY1tINUSPN1wg== X-Received: by 2002:a05:6a00:b92:b0:50d:440a:b9fd with SMTP id g18-20020a056a000b9200b0050d440ab9fdmr10474181pfj.31.1650997167528; Tue, 26 Apr 2022 11:19:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 21/68] target/nios2: Remove cpu_interrupts_enabled Date: Tue, 26 Apr 2022 11:18:20 -0700 Message-Id: <20220426181907.103691-22-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998608062100001 Content-Type: text/plain; charset="utf-8" This function is unused. The real computation of this value is located in nios2_cpu_exec_interrupt. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-22-richard.henderson@linaro.org> --- target/nios2/cpu.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 7c48b3452f..6bd8367eb8 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -222,11 +222,6 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, i= nt size, bool probe, uintptr_t retaddr); #endif =20 -static inline int cpu_interrupts_enabled(CPUNios2State *env) -{ - return env->regs[CR_STATUS] & CR_STATUS_PIE; -} - typedef CPUNios2State CPUArchState; typedef Nios2CPU ArchCPU; =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999642; cv=none; d=zohomail.com; s=zohoarc; b=JqYQtu4fxNhUxf+s0FWyNq2KNZwcT8Gj2HfOSv5DHCVGXgQL8zPhhP5K5uvF6Rm4LuKbaw14+inaw0OSCbYOysexlo7VbsNMKXCM6Qx7TMczyMwyxyKt6JWrfYmY9JHjRBdRP61tNNzEgo64v38o1fQrk5KpzTiALTaG1AU8m14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999642; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xcpq8OTysx50Lw5Wv3QQ4NLDXZZZLcnn9tCqlnHYPYo=; b=fLMqLXQvmUMkpQ06fFEBpS64HDm/SWpC+IiXpBOYRXzcb/R39RQ0FeF1sfVWnB0yFlT75XOUgi7Dnjst3yCSZVnuLt7B4Czd8Utz1PBeMk3kLPeSSTncYo1qsNPAIObr30Wo0yP7iFzWZqHCltNaQ4VBVt5Mq+rO7flgECe0m3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999641997145.89611627022737; Tue, 26 Apr 2022 12:00:41 -0700 (PDT) Received: from localhost ([::1]:55520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQQR-0002du-EO for importer@patchew.org; Tue, 26 Apr 2022 15:00:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmf-0002fw-Pa for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:43923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmc-0004QZ-Fg for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:33 -0400 Received: by mail-pf1-x42f.google.com with SMTP id y14so17926064pfe.10 for ; Tue, 26 Apr 2022 11:19:29 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xcpq8OTysx50Lw5Wv3QQ4NLDXZZZLcnn9tCqlnHYPYo=; b=nbSizCFt0dIMav4czkO6tyymHxwOgmhHvnDjepjZY2oYQ0VyUa3sEIGkIMdDYoDGki SJrr7PD9m+RenS5xrudEuzRoo0+V1c9lDLJdMiupHqVNgiBkL5WM1Lqtr0Mx9Z6+/xlE KgsZGF9ButEGxAqh8LL1N/cfK43ILAEl22BDktGOQmepyWaVUORpZft+bpu3h++clmCG WomUtrcwAenhAakt3etSSn878wsHkwNtPhiMYm78rRq3Tgx8qSGvf7SJAZcGipXsSKyi fCL51N6yY1iSM/n/SDzss+RoGaFol6q3KNO5Yva1e9BS4bvvAn7iYGjwLMHTTMArd7A7 zT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xcpq8OTysx50Lw5Wv3QQ4NLDXZZZLcnn9tCqlnHYPYo=; b=h0E+QkOKvuuKdcmOhkmSYorwqWu5pjO3YoSjqnnaMYHloWWxdvIz2wBfk6KGxJPXQ0 vhYYjggM1N6B4OHDmQ+CqPkLXTi9rKHmOw1D8gzehS3oKmuLpdFhfvu0z8H/cP5AC5tx uCvKtI7ftdzPgrUFcym39Pf99HGgS9dyuYl7Qim/y0xnKUhAdEeCygehtbhS4QOJasCx utnBQil4T/RTocHmUAQo7XvuO52uTF2GJa846tXR20YZ0FG+wbP7Ca2CX5/sytR2tFJk +k65n33fkJSnSD1inVony4l4QwQ+Tsxc2PEM6MaR+o9jYQZ+Z4GBnpl9u9VS9m13uJDP 2c1w== X-Gm-Message-State: AOAM531aWs7DXUUX6TFOReEW1XU/iBXnQljLU1z0qyQwv4Y3oB8APXMX 5mMaal6CVrWFy0sv7QAjVN6Nw10+uCcK7Q== X-Google-Smtp-Source: ABdhPJxQYhEng8YunEeSPnuYxl9jkbUsHAsEWGTf19fcQDhtC2LQRIIw4l+7eTdBle+Hm1JmCnszDA== X-Received: by 2002:a05:6a00:14d2:b0:50d:4871:3635 with SMTP id w18-20020a056a0014d200b0050d48713635mr8757606pfu.72.1650997168392; Tue, 26 Apr 2022 11:19:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 22/68] target/nios2: Split control registers away from general registers Date: Tue, 26 Apr 2022 11:18:21 -0700 Message-Id: <20220426181907.103691-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999643144100001 Content-Type: text/plain; charset="utf-8" Place the control registers into their own array, env->ctrl[]. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-23-richard.henderson@linaro.org> --- target/nios2/cpu.h | 43 ++++++++-------- target/nios2/cpu.c | 19 +++---- target/nios2/helper.c | 106 +++++++++++++++++++-------------------- target/nios2/mmu.c | 26 +++++----- target/nios2/op_helper.c | 2 +- target/nios2/translate.c | 35 +++++++------ 6 files changed, 118 insertions(+), 113 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 6bd8367eb8..68ff8033b6 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -59,9 +59,6 @@ struct Nios2CPUClass { #define NUM_GP_REGS 32 #define NUM_CR_REGS 32 =20 -/* GP regs + CR regs */ -#define NUM_CORE_REGS (NUM_GP_REGS + NUM_CR_REGS) - /* General purpose register aliases */ #define R_ZERO 0 #define R_AT 1 @@ -81,8 +78,7 @@ struct Nios2CPUClass { #define R_RA 31 =20 /* Control register aliases */ -#define CR_BASE NUM_GP_REGS -#define CR_STATUS (CR_BASE + 0) +#define CR_STATUS 0 #define CR_STATUS_PIE (1 << 0) #define CR_STATUS_U (1 << 1) #define CR_STATUS_EH (1 << 2) @@ -92,19 +88,19 @@ struct Nios2CPUClass { #define CR_STATUS_PRS (63 << 16) #define CR_STATUS_NMI (1 << 22) #define CR_STATUS_RSIE (1 << 23) -#define CR_ESTATUS (CR_BASE + 1) -#define CR_BSTATUS (CR_BASE + 2) -#define CR_IENABLE (CR_BASE + 3) -#define CR_IPENDING (CR_BASE + 4) -#define CR_CPUID (CR_BASE + 5) -#define CR_CTL6 (CR_BASE + 6) -#define CR_EXCEPTION (CR_BASE + 7) -#define CR_PTEADDR (CR_BASE + 8) +#define CR_ESTATUS 1 +#define CR_BSTATUS 2 +#define CR_IENABLE 3 +#define CR_IPENDING 4 +#define CR_CPUID 5 +#define CR_CTL6 6 +#define CR_EXCEPTION 7 +#define CR_PTEADDR 8 #define CR_PTEADDR_PTBASE_SHIFT 22 #define CR_PTEADDR_PTBASE_MASK (0x3FF << CR_PTEADDR_PTBASE_SHIFT) #define CR_PTEADDR_VPN_SHIFT 2 #define CR_PTEADDR_VPN_MASK (0xFFFFF << CR_PTEADDR_VPN_SHIFT) -#define CR_TLBACC (CR_BASE + 9) +#define CR_TLBACC 9 #define CR_TLBACC_IGN_SHIFT 25 #define CR_TLBACC_IGN_MASK (0x7F << CR_TLBACC_IGN_SHIFT) #define CR_TLBACC_C (1 << 24) @@ -113,7 +109,7 @@ struct Nios2CPUClass { #define CR_TLBACC_X (1 << 21) #define CR_TLBACC_G (1 << 20) #define CR_TLBACC_PFN_MASK 0x000FFFFF -#define CR_TLBMISC (CR_BASE + 10) +#define CR_TLBMISC 10 #define CR_TLBMISC_WAY_SHIFT 20 #define CR_TLBMISC_WAY_MASK (0xF << CR_TLBMISC_WAY_SHIFT) #define CR_TLBMISC_RD (1 << 19) @@ -124,11 +120,11 @@ struct Nios2CPUClass { #define CR_TLBMISC_BAD (1 << 2) #define CR_TLBMISC_PERM (1 << 1) #define CR_TLBMISC_D (1 << 0) -#define CR_ENCINJ (CR_BASE + 11) -#define CR_BADADDR (CR_BASE + 12) -#define CR_CONFIG (CR_BASE + 13) -#define CR_MPUBASE (CR_BASE + 14) -#define CR_MPUACC (CR_BASE + 15) +#define CR_ENCINJ 11 +#define CR_BADADDR 12 +#define CR_CONFIG 13 +#define CR_MPUBASE 14 +#define CR_MPUACC 15 =20 /* Exceptions */ #define EXCP_BREAK 0x1000 @@ -154,7 +150,8 @@ struct Nios2CPUClass { #define CPU_INTERRUPT_NMI CPU_INTERRUPT_TGT_EXT_3 =20 struct CPUArchState { - uint32_t regs[NUM_CORE_REGS]; + uint32_t regs[NUM_GP_REGS]; + uint32_t ctrl[NUM_CR_REGS]; uint32_t pc; =20 #if !defined(CONFIG_USER_ONLY) @@ -212,7 +209,7 @@ void do_nios2_semihosting(CPUNios2State *env); =20 static inline int cpu_mmu_index(CPUNios2State *env, bool ifetch) { - return (env->regs[CR_STATUS] & CR_STATUS_U) ? MMU_USER_IDX : + return (env->ctrl[CR_STATUS] & CR_STATUS_U) ? MMU_USER_IDX : MMU_SUPERVISOR_IDX; } =20 @@ -232,7 +229,7 @@ static inline void cpu_get_tb_cpu_state(CPUNios2State *= env, target_ulong *pc, { *pc =3D env->pc; *cs_base =3D 0; - *flags =3D (env->regs[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U)); + *flags =3D env->ctrl[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U); } =20 #endif /* NIOS2_CPU_H */ diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index dc1551241e..fce16a2e77 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -48,14 +48,15 @@ static void nios2_cpu_reset(DeviceState *dev) =20 ncc->parent_reset(dev); =20 - memset(env->regs, 0, sizeof(uint32_t) * NUM_CORE_REGS); + memset(env->regs, 0, sizeof(env->regs)); + memset(env->ctrl, 0, sizeof(env->ctrl)); env->pc =3D cpu->reset_addr; =20 #if defined(CONFIG_USER_ONLY) /* Start in user mode with interrupts enabled. */ - env->regs[CR_STATUS] =3D CR_STATUS_U | CR_STATUS_PIE; + env->ctrl[CR_STATUS] =3D CR_STATUS_U | CR_STATUS_PIE; #else - env->regs[CR_STATUS] =3D 0; + env->ctrl[CR_STATUS] =3D 0; #endif } =20 @@ -66,9 +67,9 @@ static void nios2_cpu_set_irq(void *opaque, int irq, int = level) CPUNios2State *env =3D &cpu->env; CPUState *cs =3D CPU(cpu); =20 - env->regs[CR_IPENDING] =3D deposit32(env->regs[CR_IPENDING], irq, 1, != !level); + env->ctrl[CR_IPENDING] =3D deposit32(env->ctrl[CR_IPENDING], irq, 1, != !level); =20 - if (env->regs[CR_IPENDING]) { + if (env->ctrl[CR_IPENDING]) { cpu_interrupt(cs, CPU_INTERRUPT_HARD); } else { cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); @@ -126,8 +127,8 @@ static bool nios2_cpu_exec_interrupt(CPUState *cs, int = interrupt_request) CPUNios2State *env =3D &cpu->env; =20 if ((interrupt_request & CPU_INTERRUPT_HARD) && - (env->regs[CR_STATUS] & CR_STATUS_PIE) && - (env->regs[CR_IPENDING] & env->regs[CR_IENABLE])) { + (env->ctrl[CR_STATUS] & CR_STATUS_PIE) && + (env->ctrl[CR_IPENDING] & env->ctrl[CR_IENABLE])) { cs->exception_index =3D EXCP_IRQ; nios2_cpu_do_interrupt(cs); return true; @@ -158,7 +159,7 @@ static int nios2_cpu_gdb_read_register(CPUState *cs, GB= yteArray *mem_buf, int n) } else if (n =3D=3D 32) { /* PC */ return gdb_get_reg32(mem_buf, env->pc); } else if (n < 49) { /* Status regs */ - return gdb_get_reg32(mem_buf, env->regs[n - 1]); + return gdb_get_reg32(mem_buf, env->ctrl[n - 33]); } =20 /* Invalid regs */ @@ -180,7 +181,7 @@ static int nios2_cpu_gdb_write_register(CPUState *cs, u= int8_t *mem_buf, int n) } else if (n =3D=3D 32) { /* PC */ env->pc =3D ldl_p(mem_buf); } else if (n < 49) { /* Status regs */ - env->regs[n - 1] =3D ldl_p(mem_buf); + env->ctrl[n - 33] =3D ldl_p(mem_buf); } =20 return 4; diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 34b3e18e37..2e5f5b8b54 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -36,38 +36,38 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 switch (cs->exception_index) { case EXCP_IRQ: - assert(env->regs[CR_STATUS] & CR_STATUS_PIE); + assert(env->ctrl[CR_STATUS] & CR_STATUS_PIE); =20 qemu_log_mask(CPU_LOG_INT, "interrupt at pc=3D%x\n", env->pc); =20 - env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; - env->regs[CR_STATUS] |=3D CR_STATUS_IH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; + env->ctrl[CR_STATUS] |=3D CR_STATUS_IH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 env->regs[R_EA] =3D env->pc + 4; env->pc =3D cpu->exception_addr; break; =20 case EXCP_TLBD: - if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { + if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { qemu_log_mask(CPU_LOG_INT, "TLB MISS (fast) at pc=3D%x\n", env= ->pc); =20 /* Fast TLB miss */ /* Variation from the spec. Table 3-35 of the cpu reference sh= ows * estatus not being changed for TLB miss but this appears to * be incorrect. */ - env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; - env->regs[CR_TLBMISC] |=3D CR_TLBMISC_WR; + env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; =20 env->regs[R_EA] =3D env->pc + 4; env->pc =3D cpu->fast_tlb_miss_addr; @@ -75,13 +75,13 @@ void nios2_cpu_do_interrupt(CPUState *cs) qemu_log_mask(CPU_LOG_INT, "TLB MISS (double) at pc=3D%x\n", e= nv->pc); =20 /* Double TLB miss */ - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - env->regs[CR_TLBMISC] |=3D CR_TLBMISC_DBL; + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_DBL; =20 env->pc =3D cpu->exception_addr; } @@ -92,15 +92,15 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_TLBX: qemu_log_mask(CPU_LOG_INT, "TLB PERM at pc=3D%x\n", env->pc); =20 - env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 - if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->regs[CR_TLBMISC] |=3D CR_TLBMISC_WR; + if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; } =20 env->regs[R_EA] =3D env->pc + 4; @@ -112,16 +112,16 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_SUPERD: qemu_log_mask(CPU_LOG_INT, "SUPERVISOR exception at pc=3D%x\n", en= v->pc); =20 - if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; + if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { + env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; env->regs[R_EA] =3D env->pc + 4; } =20 - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 env->pc =3D cpu->exception_addr; break; @@ -130,16 +130,16 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_TRAP: qemu_log_mask(CPU_LOG_INT, "TRAP exception at pc=3D%x\n", env->pc); =20 - if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->regs[CR_ESTATUS] =3D env->regs[CR_STATUS]; + if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { + env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; env->regs[R_EA] =3D env->pc + 4; } =20 - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 env->pc =3D cpu->exception_addr; break; @@ -155,16 +155,16 @@ void nios2_cpu_do_interrupt(CPUState *cs) break; } =20 - if ((env->regs[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->regs[CR_BSTATUS] =3D env->regs[CR_STATUS]; + if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { + env->ctrl[CR_BSTATUS] =3D env->ctrl[CR_STATUS]; env->regs[R_BA] =3D env->pc + 4; } =20 - env->regs[CR_STATUS] |=3D CR_STATUS_EH; - env->regs[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; + env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->regs[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->regs[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); + env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; =20 env->pc =3D cpu->exception_addr; break; @@ -207,8 +207,8 @@ void nios2_cpu_do_unaligned_access(CPUState *cs, vaddr = addr, Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUNios2State *env =3D &cpu->env; =20 - env->regs[CR_BADADDR] =3D addr; - env->regs[CR_EXCEPTION] =3D EXCP_UNALIGN << 2; + env->ctrl[CR_BADADDR] =3D addr; + env->ctrl[CR_EXCEPTION] =3D EXCP_UNALIGN << 2; helper_raise_exception(env, EXCP_UNALIGN); } =20 @@ -246,7 +246,7 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, return false; } cs->exception_index =3D EXCP_SUPERA; - env->regs[CR_BADADDR] =3D address; + env->ctrl[CR_BADADDR] =3D address; cpu_loop_exit_restore(cs, retaddr); } } @@ -275,15 +275,15 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, } =20 if (access_type =3D=3D MMU_INST_FETCH) { - env->regs[CR_TLBMISC] &=3D ~CR_TLBMISC_D; + env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_D; } else { - env->regs[CR_TLBMISC] |=3D CR_TLBMISC_D; + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_D; } - env->regs[CR_PTEADDR] &=3D CR_PTEADDR_PTBASE_MASK; - env->regs[CR_PTEADDR] |=3D (address >> 10) & CR_PTEADDR_VPN_MASK; - env->mmu.pteaddr_wr =3D env->regs[CR_PTEADDR]; + env->ctrl[CR_PTEADDR] &=3D CR_PTEADDR_PTBASE_MASK; + env->ctrl[CR_PTEADDR] |=3D (address >> 10) & CR_PTEADDR_VPN_MASK; + env->mmu.pteaddr_wr =3D env->ctrl[CR_PTEADDR]; =20 cs->exception_index =3D excp; - env->regs[CR_BADADDR] =3D address; + env->ctrl[CR_BADADDR] =3D address; cpu_loop_exit_restore(cs, retaddr); } diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 4daab2a7ab..95900724e8 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -95,8 +95,8 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t= v) v & CR_TLBACC_PFN_MASK); =20 /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ - if (env->regs[CR_TLBMISC] & CR_TLBMISC_WR) { - int way =3D (env->regs[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); + if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WR) { + int way =3D (env->ctrl[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; int g =3D (v & CR_TLBACC_G) ? 1 : 0; @@ -117,8 +117,8 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32= _t v) entry->data =3D newData; } /* Auto-increment tlbmisc.WAY */ - env->regs[CR_TLBMISC] =3D - (env->regs[CR_TLBMISC] & ~CR_TLBMISC_WAY_MASK) | + env->ctrl[CR_TLBMISC] =3D + (env->ctrl[CR_TLBMISC] & ~CR_TLBMISC_WAY_MASK) | (((way + 1) & (cpu->tlb_num_ways - 1)) << CR_TLBMISC_WAY_SHIFT); } @@ -153,17 +153,17 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uin= t32_t v) &env->mmu.tlb[(way * cpu->tlb_num_ways) + (vpn & env->mmu.tlb_entry_mask)]; =20 - env->regs[CR_TLBACC] &=3D CR_TLBACC_IGN_MASK; - env->regs[CR_TLBACC] |=3D entry->data; - env->regs[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC_G := 0; - env->regs[CR_TLBMISC] =3D + env->ctrl[CR_TLBACC] &=3D CR_TLBACC_IGN_MASK; + env->ctrl[CR_TLBACC] |=3D entry->data; + env->ctrl[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC_G := 0; + env->ctrl[CR_TLBMISC] =3D (v & ~CR_TLBMISC_PID_MASK) | ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) << CR_TLBMISC_PID_SHIFT); - env->regs[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; - env->regs[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VPN_SH= IFT; + env->ctrl[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; + env->ctrl[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VPN_SH= IFT; } else { - env->regs[CR_TLBMISC] =3D v; + env->ctrl[CR_TLBMISC] =3D v; } =20 env->mmu.tlbmisc_wr =3D v; @@ -175,8 +175,8 @@ void helper_mmu_write_pteaddr(CPUNios2State *env, uint3= 2_t v) (v & CR_PTEADDR_VPN_MASK) >> CR_PTEADDR_= VPN_SHIFT); =20 /* Writes to PTEADDR don't change the read-back VPN value */ - env->regs[CR_PTEADDR] =3D (v & ~CR_PTEADDR_VPN_MASK) | - (env->regs[CR_PTEADDR] & CR_PTEADDR_VPN_MASK); + env->ctrl[CR_PTEADDR] =3D ((v & ~CR_PTEADDR_VPN_MASK) | + (env->ctrl[CR_PTEADDR] & CR_PTEADDR_VPN_MASK)= ); env->mmu.pteaddr_wr =3D v; } =20 diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index ee5ad8b23f..08ed3b4598 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -34,7 +34,7 @@ void helper_raise_exception(CPUNios2State *env, uint32_t = index) #ifndef CONFIG_USER_ONLY void helper_eret(CPUNios2State *env, uint32_t new_status, uint32_t new_pc) { - env->regs[CR_STATUS] =3D new_status; + env->ctrl[CR_STATUS] =3D new_status; env->pc =3D new_pc; cpu_loop_exit(env_cpu(env)); } diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 6c739bfa5e..308da8057c 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -395,7 +395,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) g_assert_not_reached(); #else TCGv tmp =3D tcg_temp_new(); - tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, regs[CR_ESTATUS])); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_ESTATUS])); gen_helper_eret(cpu_env, tmp, cpu_R[R_EA]); tcg_temp_free(tmp); =20 @@ -425,7 +425,7 @@ static void bret(DisasContext *dc, uint32_t code, uint3= 2_t flags) g_assert_not_reached(); #else TCGv tmp =3D tcg_temp_new(); - tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, regs[CR_BSTATUS])); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_BSTATUS])); gen_helper_eret(cpu_env, tmp, cpu_R[R_BA]); tcg_temp_free(tmp); =20 @@ -481,7 +481,7 @@ static void rdctl(DisasContext *dc, uint32_t code, uint= 32_t flags) return; } =20 - switch (instr.imm5 + CR_BASE) { + switch (instr.imm5) { case CR_IPENDING: /* * The value of the ipending register is synthetic. @@ -493,17 +493,15 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) */ t1 =3D tcg_temp_new(); t2 =3D tcg_temp_new(); - tcg_gen_ld_tl(t1, cpu_env, - offsetof(CPUNios2State, regs[CR_IPENDING])); - tcg_gen_ld_tl(t2, cpu_env, - offsetof(CPUNios2State, regs[CR_IENABLE])); + tcg_gen_ld_tl(t1, cpu_env, offsetof(CPUNios2State, ctrl[CR_IPENDIN= G])); + tcg_gen_ld_tl(t2, cpu_env, offsetof(CPUNios2State, ctrl[CR_IENABLE= ])); tcg_gen_and_tl(cpu_R[instr.c], t1, t2); tcg_temp_free(t1); tcg_temp_free(t2); break; default: tcg_gen_ld_tl(cpu_R[instr.c], cpu_env, - offsetof(CPUNios2State, regs[instr.imm5 + CR_BASE])); + offsetof(CPUNios2State, ctrl[instr.imm5])); break; } } @@ -521,7 +519,7 @@ static void wrctl(DisasContext *dc, uint32_t code, uint= 32_t flags) R_TYPE(instr, code); TCGv v =3D load_gpr(dc, instr.a); =20 - switch (instr.imm5 + CR_BASE) { + switch (instr.imm5) { case CR_PTEADDR: gen_helper_mmu_write_pteaddr(cpu_env, v); break; @@ -541,7 +539,7 @@ static void wrctl(DisasContext *dc, uint32_t code, uint= 32_t flags) /* fall through */ default: tcg_gen_st_tl(v, cpu_env, - offsetof(CPUNios2State, regs[instr.imm5 + CR_BASE])); + offsetof(CPUNios2State, ctrl[instr.imm5])); break; } #endif @@ -774,7 +772,7 @@ illegal_op: t_gen_helper_raise_exception(dc, EXCP_ILLEGAL); } =20 -static const char * const regnames[NUM_CORE_REGS] =3D { +static const char * const gr_regnames[NUM_GP_REGS] =3D { "zero", "at", "r2", "r3", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11", @@ -783,6 +781,9 @@ static const char * const regnames[NUM_CORE_REGS] =3D { "r20", "r21", "r22", "r23", "et", "bt", "gp", "sp", "fp", "ea", "ba", "ra", +}; + +static const char * const cr_regnames[NUM_CR_REGS] =3D { "status", "estatus", "bstatus", "ienable", "ipending", "cpuid", "reserved0", "exception", "pteaddr", "tlbacc", "tlbmisc", "reserved1", @@ -910,8 +911,14 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int f= lags) =20 qemu_fprintf(f, "IN: PC=3D%x %s\n", env->pc, lookup_symbol(env->pc)); =20 - for (i =3D 0; i < NUM_CORE_REGS; i++) { - qemu_fprintf(f, "%9s=3D%8.8x ", regnames[i], env->regs[i]); + for (i =3D 0; i < NUM_GP_REGS; i++) { + qemu_fprintf(f, "%9s=3D%8.8x ", gr_regnames[i], env->regs[i]); + if ((i + 1) % 4 =3D=3D 0) { + qemu_fprintf(f, "\n"); + } + } + for (i =3D 0; i < NUM_CR_REGS; i++) { + qemu_fprintf(f, "%9s=3D%8.8x ", cr_regnames[i], env->ctrl[i]); if ((i + 1) % 4 =3D=3D 0) { qemu_fprintf(f, "\n"); } @@ -932,7 +939,7 @@ void nios2_tcg_init(void) for (i =3D 0; i < NUM_GP_REGS; i++) { cpu_R[i] =3D tcg_global_mem_new(cpu_env, offsetof(CPUNios2State, regs[i]), - regnames[i]); + gr_regnames[i]); } cpu_pc =3D tcg_global_mem_new(cpu_env, offsetof(CPUNios2State, pc), "pc"); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999428; cv=none; d=zohomail.com; s=zohoarc; b=SY1ji5PXtx/WInESgur0NYAc2Y6nNCH4EYM93qtY9Jg5+3pBLg7NUFqQxpzjs54wPC7soVHdKXZVwUG/4U54dYYe8hUgjOKWM0Y4+3EZuxw21wmF61VuQoY9/iN8VhL2BHJwMkJnylXW4n6fRqi35cUimF1uvTpD2UD2GR75iso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999428; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zXcdhRLjKPOUAo+r01dJ9lV49KSzWQuat06zJqj++Ck=; b=GHwgGdaf0hwzlZ6Uo+qqyjENV7vsPvmAfdm9EYm1uNJ0fbvJrMiDCi9DUlfzL5nwkaOF6F5w3qkWk09Kg958fB4PLTuOCoqakgkzKkyzaat6oD4Bd0f6bTcJ9WYcCy1Xe/5xiBIptTiNW6GWLqU1JpXB/qf7Pe1usoPqnNfwldc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165099942844575.03618742303127; Tue, 26 Apr 2022 11:57:08 -0700 (PDT) Received: from localhost ([::1]:46808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQN0-0005Gh-KP for importer@patchew.org; Tue, 26 Apr 2022 14:57:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmf-0002fx-Pv for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:45794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmc-0004Qk-UZ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:33 -0400 Received: by mail-pg1-x532.google.com with SMTP id k29so16704107pgm.12 for ; Tue, 26 Apr 2022 11:19:30 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zXcdhRLjKPOUAo+r01dJ9lV49KSzWQuat06zJqj++Ck=; b=ln+tdd4GqCS8BpU1XtGs9Yvp78QwP2R2F7hRhqXZBi+BFBPJdlOgB1Qeezo34z1Afy lKtUzt/KwtE+hrMFaOBeIqMCHAcQ5yRHNoAaZ3nc9nucvwKqP6iu+dmVAOzxqofZgY6c SQr0BcZfpcI4fD0I96NKzZ3XHW5GXbaCmvfDT0ti27nAYZG34ubmqPLBC7pUZnHMA8ov iIoZLlPtzIKfmoa2mjOT6R+9f9Yl5uFUm+D9+W2a4d4Jh0nty8A1/axKjazZX2fUNZ1/ 1bdwcCL9UFQOkOZxIgmcf+hX1sSU78hK90VGlWvUGFlZgBnjowZSCjvXZ8uYeKUTs3Am cmeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zXcdhRLjKPOUAo+r01dJ9lV49KSzWQuat06zJqj++Ck=; b=sOw61S/YWWegKyRxqEmPboafRgH/Ci4W38wRc8v0ExCrOfste6ndZbexwZByvLBtP2 w7EqXYtnn+AVyLOEyHJ4+bEeQZ7H9mZNFzXZi2F5BBcw2bS1canHIM2nSuWR4yoU6M30 nAaTNVqAg7AOa67xrdoeZ1nYSHaAUuIQ1Cf7h7GSsMvI5C2yw8GywVYcafGixbhBgWsm 2f/8mJX0BVOEtbvhO3xvYEcLFtV0w2iwS+dT+1+Qe95qopw7EuikZ7UYi3eP33ogBNRV 9ophhu5NMP1wGVKMKtsjdeymXqjp3MENPZyuoISX1mYKWqzDuN3uDrWCM0heENQI3DzT hIww== X-Gm-Message-State: AOAM5330P0DlhZS2TG/xkufa2sfN7GyNM1hj8zG2W4N2eFcGMtpGoD9O A8vdXMRLNjl6PCGqJ9CVBbxq9kGJvaPI5w== X-Google-Smtp-Source: ABdhPJwu3hB4HcKmiwDAFZQ3mDWqQd8OR7SN+DDrQVMi/3cila4k1Y4jn+i3ga+acWBuAaOdasNKDg== X-Received: by 2002:a05:6a00:a94:b0:4fd:c14b:21cb with SMTP id b20-20020a056a000a9400b004fdc14b21cbmr25724690pfl.53.1650997169270; Tue, 26 Apr 2022 11:19:29 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 23/68] target/nios2: Clean up nios2_cpu_dump_state Date: Tue, 26 Apr 2022 11:18:22 -0700 Message-Id: <20220426181907.103691-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999429001100001 Content-Type: text/plain; charset="utf-8" Do not print control registers for user-only mode. Rename reserved control registers to "resN", where N is the control register index. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-24-richard.henderson@linaro.org> --- target/nios2/translate.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 308da8057c..fc49a7101f 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -783,16 +783,18 @@ static const char * const gr_regnames[NUM_GP_REGS] = =3D { "fp", "ea", "ba", "ra", }; =20 +#ifndef CONFIG_USER_ONLY static const char * const cr_regnames[NUM_CR_REGS] =3D { "status", "estatus", "bstatus", "ienable", - "ipending", "cpuid", "reserved0", "exception", + "ipending", "cpuid", "res6", "exception", "pteaddr", "tlbacc", "tlbmisc", "reserved1", "badaddr", "config", "mpubase", "mpuacc", - "reserved2", "reserved3", "reserved4", "reserved5", - "reserved6", "reserved7", "reserved8", "reserved9", - "reserved10", "reserved11", "reserved12", "reserved13", - "reserved14", "reserved15", "reserved16", "reserved17", + "res16", "res17", "res18", "res19", + "res20", "res21", "res22", "res23", + "res24", "res25", "res26", "res27", + "res28", "res29", "res30", "res31", }; +#endif =20 #include "exec/gen-icount.h" =20 @@ -905,10 +907,6 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int f= lags) CPUNios2State *env =3D &cpu->env; int i; =20 - if (!env) { - return; - } - qemu_fprintf(f, "IN: PC=3D%x %s\n", env->pc, lookup_symbol(env->pc)); =20 for (i =3D 0; i < NUM_GP_REGS; i++) { @@ -917,13 +915,14 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int = flags) qemu_fprintf(f, "\n"); } } + +#if !defined(CONFIG_USER_ONLY) for (i =3D 0; i < NUM_CR_REGS; i++) { qemu_fprintf(f, "%9s=3D%8.8x ", cr_regnames[i], env->ctrl[i]); if ((i + 1) % 4 =3D=3D 0) { qemu_fprintf(f, "\n"); } } -#if !defined(CONFIG_USER_ONLY) qemu_fprintf(f, " mmu write: VPN=3D%05X PID %02X TLBACC %08X\n", env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK, (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4, --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999449; cv=none; d=zohomail.com; s=zohoarc; b=OkedobXtsatcZqXZ9MrHfSumcN7Au4wfr4x04fFC21ua5u0MNWIBsdhJ4R+Cq9un2PcJS7KlwJdN7QjYd8cZhd9pwSNSONsK0Iu+dQL3nJJqK2LcPpitTKdCrfZlPCS0O62YQ1GmCikuX24hBP1rnggzhKxuHEQjImB0eiqHc4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999449; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E+4Qd4E9HIFHi1BwjZ85dNcwW/a/s3TNOGQFzvuAjJM=; b=nfENzMgGnD+sA9NYyny9Qbuu81iWZpRXiMq2uvRw0nfx5zYAUx5Zw5aMcN44Ah+2SfXzze8iQ9BvW8Qf/Vq4BVpV33s78l0nCI7Ps0d7YqWNJpa8Z8xFg/jrAebSS0OjRlr/Ry+VGzyfbUaeaJAUbrVZk72B0j+iyJ+DzCzPmgg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999449181766.7245148586383; Tue, 26 Apr 2022 11:57:29 -0700 (PDT) Received: from localhost ([::1]:48816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQNM-0006aK-65 for importer@patchew.org; Tue, 26 Apr 2022 14:57:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmg-0002g0-VU for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:33322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPme-0004Qp-Gt for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:34 -0400 Received: by mail-pg1-x534.google.com with SMTP id k14so16764562pga.0 for ; Tue, 26 Apr 2022 11:19:30 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E+4Qd4E9HIFHi1BwjZ85dNcwW/a/s3TNOGQFzvuAjJM=; b=cHCv1jlG4qfzF3vmLuJ8TByVOIV7ODPAmMR8z5XYh+bl2/IE5afeMSouPbkViS8aB1 DEq+bVgeUgBK4Jl956d+XMYM9bNALujRf3CsyOPQxjf4biQObMghoj3pxHMSc1449T7I 6FTCUIxnIUSIUChMPJYWGJaGoKdiFBnk2IJ7ZV9IIeND59CAy+g1mFgf5AfPviLKeI7L PNI1bqB5pyOomGrQll1euGAtxhoxHS65fJC5RwZWax3+79JxtFeHZnR+get5gqWPKpvb 3fjOoQSE9q/OMArwMx95TXVi9F2gwKKJQCSry1Hx0RkTm1uf8StBwXpooCwj3awhN3X0 gYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E+4Qd4E9HIFHi1BwjZ85dNcwW/a/s3TNOGQFzvuAjJM=; b=tjMTSLp7q/ea+knLS0lGROdc0NkGpSe42vfbm6K2KwlEMYanNab7pVeCkaJcyotlmx 1MDXln4Sf/cPzHWhSeGwgduiAe+22UHzgW3MIqkHdlPCsFPqrQ+uwB+XzWjJEVs7xWMj leNanuleYJ2e+H21p4o9a1jfFxkIi+Y9Nz6h8/5XakZqWt4L3nVgsqYjUFQGcjMZnJxu SEMxglvX9P4PGUc7tKorvDPEWz/FrpiqGeACORr1xm149rohOPns3dPyzRvFRmYh25Md VdCXgN5KS3R1VRG3FLztQJpOva9bwuVB8NzC6IdNaiof4is4r3MUaQz549d1fLRcLrx6 9tMg== X-Gm-Message-State: AOAM533QHKxjYkcoQ/D4a+J6qD/71Hw5pCnAsLhlMnr+5FJyGo8f62/7 X8eFS+0+36Hj403OnLsAHNIEawlWXw2rtQ== X-Google-Smtp-Source: ABdhPJws1zABuk4zLqoWJUcadVfjeGlcawsSd6IOqDTI0pBFHfBmZxSSriti1EzoP4Y5AFw/wjRB1Q== X-Received: by 2002:a62:1b91:0:b0:50a:64d0:58a2 with SMTP id b139-20020a621b91000000b0050a64d058a2mr25670391pfb.38.1650997170097; Tue, 26 Apr 2022 11:19:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 24/68] target/nios2: Use hw/registerfields.h for CR_STATUS fields Date: Tue, 26 Apr 2022 11:18:23 -0700 Message-Id: <20220426181907.103691-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999451128100001 Content-Type: text/plain; charset="utf-8" Add all fields; retain the helper macros for single bit fields. So far there are no uses of the multi-bit status fields. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-25-richard.henderson@linaro.org> --- target/nios2/cpu.h | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 68ff8033b6..562dca8195 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -23,6 +23,7 @@ =20 #include "exec/cpu-defs.h" #include "hw/core/cpu.h" +#include "hw/registerfields.h" #include "qom/object.h" =20 typedef struct CPUArchState CPUNios2State; @@ -79,15 +80,24 @@ struct Nios2CPUClass { =20 /* Control register aliases */ #define CR_STATUS 0 -#define CR_STATUS_PIE (1 << 0) -#define CR_STATUS_U (1 << 1) -#define CR_STATUS_EH (1 << 2) -#define CR_STATUS_IH (1 << 3) -#define CR_STATUS_IL (63 << 4) -#define CR_STATUS_CRS (63 << 10) -#define CR_STATUS_PRS (63 << 16) -#define CR_STATUS_NMI (1 << 22) -#define CR_STATUS_RSIE (1 << 23) + +FIELD(CR_STATUS, PIE, 0, 1) +FIELD(CR_STATUS, U, 1, 1) +FIELD(CR_STATUS, EH, 2, 1) +FIELD(CR_STATUS, IH, 3, 1) +FIELD(CR_STATUS, IL, 4, 6) +FIELD(CR_STATUS, CRS, 10, 6) +FIELD(CR_STATUS, PRS, 16, 6) +FIELD(CR_STATUS, NMI, 22, 1) +FIELD(CR_STATUS, RSIE, 23, 1) + +#define CR_STATUS_PIE R_CR_STATUS_PIE_MASK +#define CR_STATUS_U R_CR_STATUS_U_MASK +#define CR_STATUS_EH R_CR_STATUS_EH_MASK +#define CR_STATUS_IH R_CR_STATUS_IH_MASK +#define CR_STATUS_NMI R_CR_STATUS_NMI_MASK +#define CR_STATUS_RSIE R_CR_STATUS_RSIE_MASK + #define CR_ESTATUS 1 #define CR_BSTATUS 2 #define CR_IENABLE 3 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999682; cv=none; d=zohomail.com; s=zohoarc; b=HWJDBv23Nor4QlFe7cwgJ5PZqynTD6fEWw+542XMQ0lIHK168m2EYCmQKU3NMKQ0XdHa+oz2KxQRoSe9/5XVHsIeAFahgDPGD1j1iPO6CmvzvDUSz1P/u8DmwQtBuFqX/U4yzHdjd4G+bWNIJt5k1kMk/W5/bNrNwp+x+wSRchY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999682; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7/HOE2e7ynTg66W4PjhgIMT/dmI++JIVfa+aDY4ajpE=; b=B1alSCgGZbGtLGBYY7VmRWNhoJ4BrRPzD3L7C9aA/6YmvfMpkibnnfCgck+Kf8Xuszt5ZYvrEUIddfvzEAT5m3ZGDECCKqCj92CCDtfZMapQIQa/RZIxwpPT0q86RpBqaEVCCe1qBi1bcIxQEDGVRZmnWWSO0inayHy/RpNDFKU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999682083865.1268788236824; Tue, 26 Apr 2022 12:01:22 -0700 (PDT) Received: from localhost ([::1]:57292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQR7-0003xc-0X for importer@patchew.org; Tue, 26 Apr 2022 15:01:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmh-0002g7-OC for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:38660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmf-0004Qy-3e for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:34 -0400 Received: by mail-pj1-x1030.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so924417pjb.3 for ; Tue, 26 Apr 2022 11:19:31 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7/HOE2e7ynTg66W4PjhgIMT/dmI++JIVfa+aDY4ajpE=; b=jZo8gHt9xdzUUv+DnKPuKvyAS2J1XATQPZhmdZUykwJtZmClAZtaVvz42jRmX920+O +SONmM9l32HEfCrSEUJGgmcbNPCkYkEpUqb2lWgmT5kStaHju0Pl5N/JhKBBYzP7ANZ2 dOhmEXezcDmZrjaxnvCjaNp/l0FPDGVNu4T25ckVPxWtFzF92JGVdwkSz/bxia0Zx7X5 1Rg41JAYTLyQAxpSRj41X50UtvxPbl6TzRf6HbKCLQ8YPI4uXhslC9/zB/LsbjVSEyKA PzpXiN65ercIlD606+W5XBkYkikrkDluUN2SLCxbEdCJyqoiu+3KRpvu5QV1KVEhwNaJ oKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7/HOE2e7ynTg66W4PjhgIMT/dmI++JIVfa+aDY4ajpE=; b=h/uC+VDpBMJO+uSaIadlRsX4Wp7oP7MkolBpQPRCxXq3sJYYBIFft95Bs9953jLqbI 3PIWkalp2T3+VWzz27AFsCCZmaqJ0MVtuRezef4LjATE4AwBoWZe7S6OPINDoOv7ruqD mlU9IBf8e2Ar25/T4HuO8cr2rXxgcXozHqTDlB5nK/xAbnfhxKmQHuNkoqCnJEvKyLP5 6pWnRm8xGmYot/WG4v6ZAbUPF6ZEGfvkVLDQwTIO2CJHOMNxyU8IjMu7+OjvxfyBuYa7 6jMc+pO0yTkzJYByM3wNO/mj/0fkM6pwtLwwZ0f9oKQQeV+2zerQ1T3j/+3HL29E7xug /6OA== X-Gm-Message-State: AOAM532RcMfxF8OtrpXvKzgU9OBj7VZC488L+emIdJLvwRKyCqO8E0I0 SLeu8MMJlXK66x8l6eZijbSQR73jBvmQuQ== X-Google-Smtp-Source: ABdhPJyKw6jRCuPRaBC6LPv4K8XM37woZDm0jWkI4MqkV3RaHsIJbXKuklx7mjXd4HJlw8h8JwvFHw== X-Received: by 2002:a17:90b:4d8c:b0:1d2:a600:301f with SMTP id oj12-20020a17090b4d8c00b001d2a600301fmr38551961pjb.29.1650997170927; Tue, 26 Apr 2022 11:19:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 25/68] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields Date: Tue, 26 Apr 2022 11:18:24 -0700 Message-Id: <20220426181907.103691-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999683175100001 Content-Type: text/plain; charset="utf-8" Use FIELD_DP32 instead of manual shifting and masking. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-26-richard.henderson@linaro.org> --- target/nios2/cpu.h | 4 ++++ target/nios2/helper.c | 37 ++++++++++++++++++++++--------------- 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 562dca8195..f8cd5dc218 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -105,6 +105,10 @@ FIELD(CR_STATUS, RSIE, 23, 1) #define CR_CPUID 5 #define CR_CTL6 6 #define CR_EXCEPTION 7 + +FIELD(CR_EXCEPTION, CAUSE, 2, 5) +FIELD(CR_EXCEPTION, ECCFTL, 31, 1) + #define CR_PTEADDR 8 #define CR_PTEADDR_PTBASE_SHIFT 22 #define CR_PTEADDR_PTBASE_MASK (0x3FF << CR_PTEADDR_PTBASE_SHIFT) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 2e5f5b8b54..b30740824c 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -44,8 +44,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_IH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->regs[R_EA] =3D env->pc + 4; env->pc =3D cpu->exception_addr; @@ -63,8 +64,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; @@ -78,8 +80,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_DBL; =20 @@ -96,8 +99,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; @@ -120,8 +124,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->pc =3D cpu->exception_addr; break; @@ -138,8 +143,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->pc =3D cpu->exception_addr; break; @@ -163,8 +169,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 - env->ctrl[CR_EXCEPTION] &=3D ~(0x1F << 2); - env->ctrl[CR_EXCEPTION] |=3D (cs->exception_index & 0x1F) << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); =20 env->pc =3D cpu->exception_addr; break; @@ -208,7 +215,7 @@ void nios2_cpu_do_unaligned_access(CPUState *cs, vaddr = addr, CPUNios2State *env =3D &cpu->env; =20 env->ctrl[CR_BADADDR] =3D addr; - env->ctrl[CR_EXCEPTION] =3D EXCP_UNALIGN << 2; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(0, CR_EXCEPTION, CAUSE, EXCP_UN= ALIGN); helper_raise_exception(env, EXCP_UNALIGN); } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999253; cv=none; d=zohomail.com; s=zohoarc; b=QLuSeg5QPRKsF1IKG71xb/1C2W+43dOc8XY0UHRrkr3uYaxK2RhDNGGYRZcdUIZBbsJr6iw3LCjWHwC9jpCEADQJ9Jln4mE8qcVssNtO2TVhGLdPY97+j0oV1va28UNFn9XCqCdEvce/EUPhrG/znOxhNf4II0UOy0/1GgqKNrY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999253; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C/u00nAmgF45yxO3zIMu5WmncM8sGR/FNykbnvTKhkM=; b=FdWtgo/MyYQeY2g+ku2GHDRXvmP5HjwBBoPs0GGhIbauEpCDZdtKH8+VvXKLUAfh0AMaagLtcmz6V1ijXt9GGJ89ZZhMm1wgVm/1cB/xY2qYAWeg1vrukUlFpChpa2uUtYqUtEjfMHlnquojLjZtF/Bx6Q7kVziYEilJDG8lWBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999253342475.70753050227324; Tue, 26 Apr 2022 11:54:13 -0700 (PDT) Received: from localhost ([::1]:40194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQKC-0000iu-9Y for importer@patchew.org; Tue, 26 Apr 2022 14:54:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmh-0002g8-Oq for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:45755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmf-0004R5-3r for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:35 -0400 Received: by mail-pl1-x633.google.com with SMTP id h12so27286957plf.12 for ; Tue, 26 Apr 2022 11:19:32 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C/u00nAmgF45yxO3zIMu5WmncM8sGR/FNykbnvTKhkM=; b=yanGUVQwNFfuuZDkOCb7BTrja9Jro/krMx0XiHF8bCYHiC1uAzADctrHBri6G/qhgW dSors3IY4/NsswvjTCIPTF1Uzp2rZokL/PCCSrRpMd5tWlyJdHPxGkcaTxa/T2wAggWS hJR7VmwFEyFnZvhysdRDsvYsdA9tQNAO1wD4SHVg+vmQ6qiTFY/JoUjhXdUo7Lq6l+p1 OcYGxw5gWKOfXYuFo3S6a6jqKDsKy6s5Z/Q6903qdEmh9e1yhvF2i33NcksMvGu2LEQs z/36HwEACb7X0Vlt4/+d9vyxKvO2vrvj1dyzK547oDBb2JkTYkrp6BqbqjxgqOhW/O87 IyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C/u00nAmgF45yxO3zIMu5WmncM8sGR/FNykbnvTKhkM=; b=JaHFeeEBw92jVfAVORaUyzVdbmza00xNp5ZIBGLHxyE+Vzt0YY34eV+T3zi41yzJcN NeeZBKiAxB4kNDW7xEMnkJzbuuuoVqR3CJ1cjnaJnuNMWQgwZVTWVbvbzxPD2r1k1uVN 0u5bigxeIyMx0O3Pwaq1drcjGh3sUZNthgRr5I24rX2p5zwfI08iq8sryzMkNvrLLAWN JclsFdFPAPoG+M0buXt4MU+21/P73u9XafLEOjtyGMDF4+cFTACe6DQypwJBqfexPNbR 8d3SuJ/qFi1ipysBe9bkcDaOieeDtOwsW8C5E+JF3JBhnplN5ctyEWkXLhZQFMak5g8G cMew== X-Gm-Message-State: AOAM531NYyNpqC11TR3hsi4kPHuwQBMPo3pa7Jbas4e/P6LNFPgzL0x/ 9nlYEgZyLPQct3UZA20VKkjPAngTnSDHxw== X-Google-Smtp-Source: ABdhPJzq2zMA8yTcBhzZNjezRSxFdVxV27poCl1bvBSekvxIOkJKAGbeytWpnlOZJEGqNKrVIJH7Zg== X-Received: by 2002:a17:902:7296:b0:151:62b1:e2b0 with SMTP id d22-20020a170902729600b0015162b1e2b0mr24469797pll.165.1650997171759; Tue, 26 Apr 2022 11:19:31 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 26/68] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields Date: Tue, 26 Apr 2022 11:18:25 -0700 Message-Id: <20220426181907.103691-27-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999254548100001 Content-Type: text/plain; charset="utf-8" Use FIELD_EX32 and FIELD_DP32 instead of manual manipulation of the fields. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-27-richard.henderson@linaro.org> --- target/nios2/cpu.h | 8 ++++---- target/nios2/helper.c | 4 ++-- target/nios2/mmu.c | 17 +++++++++-------- target/nios2/translate.c | 2 +- 4 files changed, 16 insertions(+), 15 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index f8cd5dc218..a6811ff7ea 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -110,10 +110,10 @@ FIELD(CR_EXCEPTION, CAUSE, 2, 5) FIELD(CR_EXCEPTION, ECCFTL, 31, 1) =20 #define CR_PTEADDR 8 -#define CR_PTEADDR_PTBASE_SHIFT 22 -#define CR_PTEADDR_PTBASE_MASK (0x3FF << CR_PTEADDR_PTBASE_SHIFT) -#define CR_PTEADDR_VPN_SHIFT 2 -#define CR_PTEADDR_VPN_MASK (0xFFFFF << CR_PTEADDR_VPN_SHIFT) + +FIELD(CR_PTEADDR, VPN, 2, 20) +FIELD(CR_PTEADDR, PTBASE, 22, 10) + #define CR_TLBACC 9 #define CR_TLBACC_IGN_SHIFT 25 #define CR_TLBACC_IGN_MASK (0x7F << CR_TLBACC_IGN_SHIFT) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index b30740824c..c2d0afe1b6 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -286,8 +286,8 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, } else { env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_D; } - env->ctrl[CR_PTEADDR] &=3D CR_PTEADDR_PTBASE_MASK; - env->ctrl[CR_PTEADDR] |=3D (address >> 10) & CR_PTEADDR_VPN_MASK; + env->ctrl[CR_PTEADDR] =3D FIELD_DP32(env->ctrl[CR_PTEADDR], CR_PTEADDR= , VPN, + address >> TARGET_PAGE_BITS); env->mmu.pteaddr_wr =3D env->ctrl[CR_PTEADDR]; =20 cs->exception_index =3D excp; diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 95900724e8..75afc56daf 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -97,7 +97,7 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t= v) /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WR) { int way =3D (env->ctrl[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); - int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; + int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; int g =3D (v & CR_TLBACC_G) ? 1 : 0; int valid =3D ((vpn & CR_TLBACC_PFN_MASK) < 0xC0000) ? 1 : 0; @@ -148,7 +148,7 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uint3= 2_t v) /* if tlbmisc.RD =3D=3D 1 then trigger a TLB read on writes to TLBMISC= */ if (v & CR_TLBMISC_RD) { int way =3D (v >> CR_TLBMISC_WAY_SHIFT); - int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; + int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); Nios2TLBEntry *entry =3D &env->mmu.tlb[(way * cpu->tlb_num_ways) + (vpn & env->mmu.tlb_entry_mask)]; @@ -160,8 +160,9 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uint3= 2_t v) (v & ~CR_TLBMISC_PID_MASK) | ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) << CR_TLBMISC_PID_SHIFT); - env->ctrl[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; - env->ctrl[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VPN_SH= IFT; + env->ctrl[CR_PTEADDR] =3D FIELD_DP32(env->ctrl[CR_PTEADDR], + CR_PTEADDR, VPN, + entry->tag >> TARGET_PAGE_BITS); } else { env->ctrl[CR_TLBMISC] =3D v; } @@ -171,12 +172,12 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uin= t32_t v) =20 void helper_mmu_write_pteaddr(CPUNios2State *env, uint32_t v) { - trace_nios2_mmu_write_pteaddr(v >> CR_PTEADDR_PTBASE_SHIFT, - (v & CR_PTEADDR_VPN_MASK) >> CR_PTEADDR_= VPN_SHIFT); + trace_nios2_mmu_write_pteaddr(FIELD_EX32(v, CR_PTEADDR, PTBASE), + FIELD_EX32(v, CR_PTEADDR, VPN)); =20 /* Writes to PTEADDR don't change the read-back VPN value */ - env->ctrl[CR_PTEADDR] =3D ((v & ~CR_PTEADDR_VPN_MASK) | - (env->ctrl[CR_PTEADDR] & CR_PTEADDR_VPN_MASK)= ); + env->ctrl[CR_PTEADDR] =3D ((v & ~R_CR_PTEADDR_VPN_MASK) | + (env->ctrl[CR_PTEADDR] & R_CR_PTEADDR_VPN_MAS= K)); env->mmu.pteaddr_wr =3D v; } =20 diff --git a/target/nios2/translate.c b/target/nios2/translate.c index fc49a7101f..baa22c5101 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -924,7 +924,7 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int fl= ags) } } qemu_fprintf(f, " mmu write: VPN=3D%05X PID %02X TLBACC %08X\n", - env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK, + env->mmu.pteaddr_wr & R_CR_PTEADDR_VPN_MASK, (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4, env->mmu.tlbacc_wr); #endif --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650997879; cv=none; d=zohomail.com; s=zohoarc; b=V8vMIcwobqvLaB7W56rTNeQfUh91N/RJTDSKhOHvuK41GjYnqDJdItQR049FwVnmCcdxw/sZ8zrqJODTx2tb6wK0AY2RsM2oCY9Fm2qEIzfkcQEjNRVkyKnPPRNbvo3DEfBBnjHvx7Q85BQ77mNdexQyuNA2ktrV8c8iTILAjoQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650997879; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JmB13VTyuzzFASmlJJ9jmm7vtSLnsoUw3SQpc47Yi90=; b=A6dbHxIlx9SXAYYBKfe8B8rMnzs79EUcqPfb+NGUU9hgRHUPspwXm1T4K2+V3JsyM/53B/OPbcZhs3kDppnYunaw4v2P7AcPpqcHXTNGC1ZKZgQ/0x6e9Pnb3XmErPlqBM3oA85z9AhHR/OcHl0/VfsDvUhfOCZR22x78ZmhEU0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650997879315610.5039386670423; Tue, 26 Apr 2022 11:31:19 -0700 (PDT) Received: from localhost ([::1]:41896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njPy2-00043A-A0 for importer@patchew.org; Tue, 26 Apr 2022 14:31:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmi-0002gQ-Uk for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:38 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:41733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmg-0004RE-AK for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:36 -0400 Received: by mail-pj1-x1036.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so3310335pjf.0 for ; Tue, 26 Apr 2022 11:19:33 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JmB13VTyuzzFASmlJJ9jmm7vtSLnsoUw3SQpc47Yi90=; b=g0Pd1C5CnXSYSs52J5VmMJeCH1fTh/QhEmbJ92GlzLKsUsx1OfJRFDCQ6/gr2svX0r Wmx+KWOZeGMnpaff+K2yht169rRV7mshCfHyyX0UPsHHLlxYPsUa+g21H8J4VTthKHbl U7RiLcypbQy3dOZFP2qs+mgsUSTCyCmNWWcaCsO1Dbz/xJJGrmFTdyzjaFg711FuhGuX lP70vfNK19eNE1N7fLOhgF8cJ/g7mYZ4+1euoFmKjzJ6Cde5W72LzDCjDeb6/jYcC+kN IEP+yetcd1IL4z4hsQU3GJcIbDeOfqzpOqUznwwbaEOyicv6ZzZM+xQj5jRejACahF0s 57jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JmB13VTyuzzFASmlJJ9jmm7vtSLnsoUw3SQpc47Yi90=; b=EuHrMI9zXqycqqbsWxlXAoRwIXfAfwAKGQpWL5k2JPnAYgeYwEJhUJTzq+8iC5Pk4t eEavElYnTKZEBJ4oOVuRSOn5wglKz4HIgMxNiymO9WaqR6Q/tmQQ+4GDaM6Ff5sSHJWq GWN0JBL8EsNnqn6KaF30i/20TQyArM7J1k8xmQFYoBZmC4CDSKOFW9ivIa150LSaCybb xwa75ILTibgC4yeDRGkjDKgAGQyO/A1xhA+o6/f2nzAaq0XbK/bJr9KTE0srfvDHMVj9 XmuSzCX+WnUBQsWYal7ekmvQEIpkjWBj7R8LIetUIXD7XeDTg3I4fyjFDltrDYOiCZkQ kUrg== X-Gm-Message-State: AOAM532za25DSytwxTHOCyw798k0b9SXIz8wYSJuZ6U72AfbZELDVVsG SR9Mak2niJ8JXMF8+2OIA7OOXNDNgiD3eA== X-Google-Smtp-Source: ABdhPJwAwG1D+Cpu25yH+n27WTcoYLjaUe6+t+1LgbSXOUS7gw68v0n/0u3NbGG9ownR9od2fZy2Ag== X-Received: by 2002:a17:902:a710:b0:156:5650:f94a with SMTP id w16-20020a170902a71000b001565650f94amr24026328plq.86.1650997172907; Tue, 26 Apr 2022 11:19:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 27/68] target/nios2: Use hw/registerfields.h for CR_TLBACC fields Date: Tue, 26 Apr 2022 11:18:26 -0700 Message-Id: <20220426181907.103691-28-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650997879546100001 Content-Type: text/plain; charset="utf-8" Retain the helper macros for single bit fields as aliases to the longer R_*_MASK names. Use FIELD_EX32 and FIELD_DP32 instead of manually manipulating the fields. Since we're rewriting the references to CR_TLBACC_IGN_* anyway, we correct the name of this field to IG, which is its name in the official CPU documentation. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-28-richard.henderson@linaro.org> --- target/nios2/cpu.h | 23 +++++++++++++++-------- target/nios2/mmu.c | 16 ++++++++-------- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index a6811ff7ea..bfa86edd97 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -115,14 +115,21 @@ FIELD(CR_PTEADDR, VPN, 2, 20) FIELD(CR_PTEADDR, PTBASE, 22, 10) =20 #define CR_TLBACC 9 -#define CR_TLBACC_IGN_SHIFT 25 -#define CR_TLBACC_IGN_MASK (0x7F << CR_TLBACC_IGN_SHIFT) -#define CR_TLBACC_C (1 << 24) -#define CR_TLBACC_R (1 << 23) -#define CR_TLBACC_W (1 << 22) -#define CR_TLBACC_X (1 << 21) -#define CR_TLBACC_G (1 << 20) -#define CR_TLBACC_PFN_MASK 0x000FFFFF + +FIELD(CR_TLBACC, PFN, 0, 20) +FIELD(CR_TLBACC, G, 20, 1) +FIELD(CR_TLBACC, X, 21, 1) +FIELD(CR_TLBACC, W, 22, 1) +FIELD(CR_TLBACC, R, 23, 1) +FIELD(CR_TLBACC, C, 24, 1) +FIELD(CR_TLBACC, IG, 25, 7) + +#define CR_TLBACC_C R_CR_TLBACC_C_MASK +#define CR_TLBACC_R R_CR_TLBACC_R_MASK +#define CR_TLBACC_W R_CR_TLBACC_W_MASK +#define CR_TLBACC_X R_CR_TLBACC_X_MASK +#define CR_TLBACC_G R_CR_TLBACC_G_MASK + #define CR_TLBMISC 10 #define CR_TLBMISC_WAY_SHIFT 20 #define CR_TLBMISC_WAY_MASK (0xF << CR_TLBMISC_WAY_SHIFT) diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 75afc56daf..826cd2afb4 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -49,7 +49,7 @@ unsigned int mmu_translate(CPUNios2State *env, } =20 lu->vaddr =3D vaddr & TARGET_PAGE_MASK; - lu->paddr =3D (entry->data & CR_TLBACC_PFN_MASK) << TARGET_PAGE_BI= TS; + lu->paddr =3D FIELD_EX32(entry->data, CR_TLBACC, PFN) << TARGET_PA= GE_BITS; lu->prot =3D ((entry->data & CR_TLBACC_R) ? PAGE_READ : 0) | ((entry->data & CR_TLBACC_W) ? PAGE_WRITE : 0) | ((entry->data & CR_TLBACC_X) ? PAGE_EXEC : 0); @@ -86,27 +86,27 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32= _t v) CPUState *cs =3D env_cpu(env); Nios2CPU *cpu =3D env_archcpu(env); =20 - trace_nios2_mmu_write_tlbacc(v >> CR_TLBACC_IGN_SHIFT, + trace_nios2_mmu_write_tlbacc(FIELD_EX32(v, CR_TLBACC, IG), (v & CR_TLBACC_C) ? 'C' : '.', (v & CR_TLBACC_R) ? 'R' : '.', (v & CR_TLBACC_W) ? 'W' : '.', (v & CR_TLBACC_X) ? 'X' : '.', (v & CR_TLBACC_G) ? 'G' : '.', - v & CR_TLBACC_PFN_MASK); + FIELD_EX32(v, CR_TLBACC, PFN)); =20 /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WR) { int way =3D (env->ctrl[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; - int g =3D (v & CR_TLBACC_G) ? 1 : 0; - int valid =3D ((vpn & CR_TLBACC_PFN_MASK) < 0xC0000) ? 1 : 0; + int g =3D FIELD_EX32(v, CR_TLBACC, G); + int valid =3D FIELD_EX32(vpn, CR_TLBACC, PFN) < 0xC0000; Nios2TLBEntry *entry =3D &env->mmu.tlb[(way * cpu->tlb_num_ways) + (vpn & env->mmu.tlb_entry_mask)]; uint32_t newTag =3D (vpn << 12) | (g << 11) | (valid << 10) | pid; uint32_t newData =3D v & (CR_TLBACC_C | CR_TLBACC_R | CR_TLBACC_W | - CR_TLBACC_X | CR_TLBACC_PFN_MASK); + CR_TLBACC_X | R_CR_TLBACC_PFN_MASK); =20 if ((entry->tag !=3D newTag) || (entry->data !=3D newData)) { if (entry->tag & (1 << 10)) { @@ -153,7 +153,7 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uint3= 2_t v) &env->mmu.tlb[(way * cpu->tlb_num_ways) + (vpn & env->mmu.tlb_entry_mask)]; =20 - env->ctrl[CR_TLBACC] &=3D CR_TLBACC_IGN_MASK; + env->ctrl[CR_TLBACC] &=3D R_CR_TLBACC_IG_MASK; env->ctrl[CR_TLBACC] |=3D entry->data; env->ctrl[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC_G := 0; env->ctrl[CR_TLBMISC] =3D @@ -208,7 +208,7 @@ void dump_mmu(CPUNios2State *env) entry->tag >> 12, entry->tag & ((1 << cpu->pid_num_bits) - 1), (entry->tag & (1 << 11)) ? 'G' : '-', - entry->data & CR_TLBACC_PFN_MASK, + FIELD_EX32(entry->data, CR_TLBACC, PFN), (entry->data & CR_TLBACC_C) ? 'C' : '-', (entry->data & CR_TLBACC_R) ? 'R' : '-', (entry->data & CR_TLBACC_W) ? 'W' : '-', --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998744; cv=none; d=zohomail.com; s=zohoarc; b=Nng/KAx6r9TZFw+BZIuPQ1lDwHbloG8KQp8aeFgLWRwaoXnCz5sg/PNmQ0Q+hmm7uQAr625SP02bgAusrk0J+UoNHarvReUvGeJfOifDm1wyyrd4IY+a/eHcDhFHLN7VgfdY2DRW4+wlHHJLnKhIjfl1kxvJtwenHTWriu92WUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998744; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r5Zy2yCkq1/yGdzgbEGm15IgEb8bGe9eHlGj+1AyTDk=; b=Eh69MpWjCb7zHhXBmTtJhDPTxhiGsqILFQtcdzKETSxP4TWQ4JzCuIEUfKL6Cy+1c+t/jyNTp+g3Q2PmXBG6GbQTX3B9qc6WS6xHoZJteUSgl+9MauZWzyP9ZDeo5nrlAiZ++l6ZJgwpksYlfyuUzirzN/vxwOx/wAX9hLPEKTs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998744255815.7302288280116; Tue, 26 Apr 2022 11:45:44 -0700 (PDT) Received: from localhost ([::1]:47128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQBy-0002YT-D9 for importer@patchew.org; Tue, 26 Apr 2022 14:45:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmk-0002hH-K9 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:39 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:45746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmh-0004RW-TF for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:37 -0400 Received: by mail-pl1-x629.google.com with SMTP id h12so27287034plf.12 for ; Tue, 26 Apr 2022 11:19:35 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r5Zy2yCkq1/yGdzgbEGm15IgEb8bGe9eHlGj+1AyTDk=; b=hIv4NEOz4k4NY4oUeMPtlZpt/oL8FgJwz28WWXt4CkLexhCDWobVuKyeq23TIkHADy ba06cy/RPiZw9JBy/qpLX2IpCZIS6jmxEeH85TrKpJ03VaFXSbkfIj9DfK8/mBDACqq7 2hoFkMfOQDD7XaPy7ycwCO++QHnh+UZtPgAM+s9U/9saVo7dqPJLRaLJ5JPZE1tCrMTf LeCFSbku+SjMafBv9L2Ko4+SjGTjE+x0nP/ycJp5+xdDl8WAcYEXQSW0lzRvMz/yh9X0 p0TjIfKpOfsi7mEYMG+fn7BqNlz0EYWhSrAAYzHTugULGazBR5zWYEzjfmF45wWUWGQC fv0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r5Zy2yCkq1/yGdzgbEGm15IgEb8bGe9eHlGj+1AyTDk=; b=4FLFZ214Nvqz13+RSrM5mekmmpRnRhdHLhlzigOEel/whMcI4tXpUqQww1P1STOmdO iSAI23b1Z8zdytolr5Gfxt4B8oJtNhXW+7GjyeShesioA3Pjfldk+HxTc96lpOV/0yk6 rMUNh0a3Nh69L4J9Fi2CWhbSzPNesTZxIb7QIdrSzzrddl9xvOnYSsk/cpoEA+Uqlilb bwYsr1lvfJx4o0c5prkeHBPIJhsCWVKknSr74/fsQ4B747zJiC5B472h8s1Hlr2ke+QN YruL/jp6+DM0tXOdPkBbngcGq/6kJ1S+o4Zh5d4NbjhPnRzVvhb4aBip3WQOr+0HpCR5 ty8A== X-Gm-Message-State: AOAM533MozHkpEVf8QcayUOgJSoDAW9YAoMACyC85qnbIlAhLasd/6he aTSdmNTGmBF2+HcopdIWpCdFlwK00X1dyA== X-Google-Smtp-Source: ABdhPJw/1cqlC/zWruc1kTbTwVWnmM2C8UKKdYqd2G+WkOdEJzvWaQoSVEfJNR5oiBwPQLQMAVzgLA== X-Received: by 2002:a17:90a:7e97:b0:1d2:7bcb:ee78 with SMTP id j23-20020a17090a7e9700b001d27bcbee78mr28545822pjl.40.1650997174134; Tue, 26 Apr 2022 11:19:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 28/68] target/nios2: Rename CR_TLBMISC_WR to CR_TLBMISC_WE Date: Tue, 26 Apr 2022 11:18:27 -0700 Message-Id: <20220426181907.103691-29-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998745711100001 Content-Type: text/plain; charset="utf-8" WE is the architectural name of the field, not WR. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-29-richard.henderson@linaro.org> --- target/nios2/cpu.h | 2 +- target/nios2/helper.c | 4 ++-- target/nios2/mmu.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index bfa86edd97..54bb6cd9be 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -134,7 +134,7 @@ FIELD(CR_TLBACC, IG, 25, 7) #define CR_TLBMISC_WAY_SHIFT 20 #define CR_TLBMISC_WAY_MASK (0xF << CR_TLBMISC_WAY_SHIFT) #define CR_TLBMISC_RD (1 << 19) -#define CR_TLBMISC_WR (1 << 18) +#define CR_TLBMISC_WE (1 << 18) #define CR_TLBMISC_PID_SHIFT 4 #define CR_TLBMISC_PID_MASK (0x3FFF << CR_TLBMISC_PID_SHIFT) #define CR_TLBMISC_DBL (1 << 3) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index c2d0afe1b6..31d83e0291 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -69,7 +69,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) cs->exception_index); =20 env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; =20 env->regs[R_EA] =3D env->pc + 4; env->pc =3D cpu->fast_tlb_miss_addr; @@ -104,7 +104,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) cs->exception_index); =20 if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WR; + env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; } =20 env->regs[R_EA] =3D env->pc + 4; diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 826cd2afb4..0f33ea5e04 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -95,7 +95,7 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t= v) FIELD_EX32(v, CR_TLBACC, PFN)); =20 /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ - if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WR) { + if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WE) { int way =3D (env->ctrl[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; @@ -133,7 +133,7 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uint3= 2_t v) =20 trace_nios2_mmu_write_tlbmisc(v >> CR_TLBMISC_WAY_SHIFT, (v & CR_TLBMISC_RD) ? 'R' : '.', - (v & CR_TLBMISC_WR) ? 'W' : '.', + (v & CR_TLBMISC_WE) ? 'W' : '.', (v & CR_TLBMISC_DBL) ? '2' : '.', (v & CR_TLBMISC_BAD) ? 'B' : '.', (v & CR_TLBMISC_PERM) ? 'P' : '.', --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998150; cv=none; d=zohomail.com; s=zohoarc; b=jmJjuKyz6ABYOcEgv4cGEyS/2tJXOouKj9IN+WouBJD9SY67qORfi6G4BNVm4oDIKATdBlQJCuKaCbWYmwzciuihlhj5/z/D1BU96+ZDgoVwUSmQE+h2wDDDK8EvEs51D7otkhOIG+dV9feL9SfTg7np/sw5oeJBXt/IhWPI8mM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998150; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4obiPdK12f4MtL4q5H0bjRe5759e1tJa5XBfCZLZ5J4=; b=n10u9C5LxK369gliv4rdRNcBzZ/uYuTLc8QvdrCzuG/a6MkaiLjwnK62iS46Tk8oR+OdY6M84HMvY28mW3mDG99TVDKw4wboB9e3MaWPpnH1icCPuiI/lryIYRpPVK3tQg+3RSaGypP35N2GNxX8FAAZPUKMkDImca2mi0ibaVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998150658950.1320488140757; Tue, 26 Apr 2022 11:35:50 -0700 (PDT) Received: from localhost ([::1]:50402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQ2P-0001h5-Ij for importer@patchew.org; Tue, 26 Apr 2022 14:35:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmk-0002hI-Kb for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:39 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:53190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmi-0004Rl-M4 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:38 -0400 Received: by mail-pj1-x102a.google.com with SMTP id e24so2278191pjt.2 for ; Tue, 26 Apr 2022 11:19:36 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4obiPdK12f4MtL4q5H0bjRe5759e1tJa5XBfCZLZ5J4=; b=uzYzNR47yRN115Fk45Mecu5Ec6ZeRsWSpt8TEpv/D4DCRqZK/bhHnJWbBL61ZA/ppk Gz37rzFB1w2/wiq7UIBsLFGPePGM5wRCTaYr3IJtAm2xOy/fzI7UvBf/uRg7X3XoC81e DnBzXPuR4MjPItAqPSG5qxPtmIgWq6H2I8nFeX7ez1nEKezgI3GosAGrrdwv5HZqsGJw /FakY/CLnGnoq1iYrLE5Ug+Lrv7ML074F3erjDtszG3elD4qYM+38xVVMbqaDb9iKq0M jD10jGSYsWbHrEVI1nqtb+FiZUX+tD21RU4Qp1MytB9ZEvAXve2toUDS8/0Ay8VzU2n4 pm2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4obiPdK12f4MtL4q5H0bjRe5759e1tJa5XBfCZLZ5J4=; b=fYlKcrZ9zWcsMGqqdNoH6xB7JbEExZF/vWBk5yIBhrDECoqy9UE/aR5QYdTY/WTWSC JMvZjzz3+mddeVqq+d9jMVVsGFyaj8deKfza4mfpxFuvBzDHtJFQQB8RlOEvo7stVAPd Z10Cz7JkbjkN0eRLQeiXoiutbJFj14PRo8tCUT+6egobukR7yCEUyR27cIo67YPCRNxV xrRAvKh9XX3P4Qu62SEvkdf95RHdHGLPv3WyEtk0BA9PpGzOqFFTWN36qAFdhq36yT/P MKJjTLThfaK4dOrEnJmc1PuwNdgdW5/3yYWOQWDl/lMl90jT1xhDDHJy8Pd3tdG2Wl3P 8oUA== X-Gm-Message-State: AOAM533Ggs6AK480L6X0TIeQFRNiLUkpwxveDeJKFE16gXUaqophKiPI NO1mZVJlKhf8ath8VIZ4CFJrTIpmUXGKSQ== X-Google-Smtp-Source: ABdhPJwuxN23vi4iEN6C8HWGK/NUIwETl48X4L+H3CVV1W9xhzzQ4li9HZXx6FbPg1VWQGvYfQde8A== X-Received: by 2002:a17:902:bd95:b0:14f:40ab:270e with SMTP id q21-20020a170902bd9500b0014f40ab270emr24446262pls.101.1650997175019; Tue, 26 Apr 2022 11:19:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 29/68] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields Date: Tue, 26 Apr 2022 11:18:28 -0700 Message-Id: <20220426181907.103691-30-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998152788100001 Content-Type: text/plain; charset="utf-8" Use FIELD_EX32 and FIELD_DP32 instead of managing the masking by hand. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-30-richard.henderson@linaro.org> --- target/nios2/cpu.h | 29 +++++++++++++++++++---------- target/nios2/helper.c | 7 ++----- target/nios2/mmu.c | 35 +++++++++++++++++------------------ target/nios2/translate.c | 2 +- 4 files changed, 39 insertions(+), 34 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 54bb6cd9be..f312050ecd 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -131,16 +131,25 @@ FIELD(CR_TLBACC, IG, 25, 7) #define CR_TLBACC_G R_CR_TLBACC_G_MASK =20 #define CR_TLBMISC 10 -#define CR_TLBMISC_WAY_SHIFT 20 -#define CR_TLBMISC_WAY_MASK (0xF << CR_TLBMISC_WAY_SHIFT) -#define CR_TLBMISC_RD (1 << 19) -#define CR_TLBMISC_WE (1 << 18) -#define CR_TLBMISC_PID_SHIFT 4 -#define CR_TLBMISC_PID_MASK (0x3FFF << CR_TLBMISC_PID_SHIFT) -#define CR_TLBMISC_DBL (1 << 3) -#define CR_TLBMISC_BAD (1 << 2) -#define CR_TLBMISC_PERM (1 << 1) -#define CR_TLBMISC_D (1 << 0) + +FIELD(CR_TLBMISC, D, 0, 1) +FIELD(CR_TLBMISC, PERM, 1, 1) +FIELD(CR_TLBMISC, BAD, 2, 1) +FIELD(CR_TLBMISC, DBL, 3, 1) +FIELD(CR_TLBMISC, PID, 4, 14) +FIELD(CR_TLBMISC, WE, 18, 1) +FIELD(CR_TLBMISC, RD, 19, 1) +FIELD(CR_TLBMISC, WAY, 20, 4) +FIELD(CR_TLBMISC, EE, 24, 1) + +#define CR_TLBMISC_EE R_CR_TLBMISC_EE_MASK +#define CR_TLBMISC_RD R_CR_TLBMISC_RD_MASK +#define CR_TLBMISC_WE R_CR_TLBMISC_WE_MASK +#define CR_TLBMISC_DBL R_CR_TLBMISC_DBL_MASK +#define CR_TLBMISC_BAD R_CR_TLBMISC_BAD_MASK +#define CR_TLBMISC_PERM R_CR_TLBMISC_PERM_MASK +#define CR_TLBMISC_D R_CR_TLBMISC_D_MASK + #define CR_ENCINJ 11 #define CR_BADADDR 12 #define CR_CONFIG 13 diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 31d83e0291..a56aaaea18 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -281,11 +281,8 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, i= nt size, return false; } =20 - if (access_type =3D=3D MMU_INST_FETCH) { - env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_D; - } else { - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_D; - } + env->ctrl[CR_TLBMISC] =3D FIELD_DP32(env->ctrl[CR_TLBMISC], CR_TLBMISC= , D, + access_type !=3D MMU_INST_FETCH); env->ctrl[CR_PTEADDR] =3D FIELD_DP32(env->ctrl[CR_PTEADDR], CR_PTEADDR= , VPN, address >> TARGET_PAGE_BITS); env->mmu.pteaddr_wr =3D env->ctrl[CR_PTEADDR]; diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 0f33ea5e04..d9b690b78e 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -33,7 +33,7 @@ unsigned int mmu_translate(CPUNios2State *env, target_ulong vaddr, int rw, int mmu_idx) { Nios2CPU *cpu =3D env_archcpu(env); - int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; + int pid =3D FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID); int vpn =3D vaddr >> 12; int way, n_ways =3D cpu->tlb_num_ways; =20 @@ -96,9 +96,9 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t= v) =20 /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ if (env->ctrl[CR_TLBMISC] & CR_TLBMISC_WE) { - int way =3D (env->ctrl[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); + int way =3D FIELD_EX32(env->ctrl[CR_TLBMISC], CR_TLBMISC, WAY); int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); - int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; + int pid =3D FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID); int g =3D FIELD_EX32(v, CR_TLBACC, G); int valid =3D FIELD_EX32(vpn, CR_TLBACC, PFN) < 0xC0000; Nios2TLBEntry *entry =3D @@ -117,10 +117,9 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint3= 2_t v) entry->data =3D newData; } /* Auto-increment tlbmisc.WAY */ - env->ctrl[CR_TLBMISC] =3D - (env->ctrl[CR_TLBMISC] & ~CR_TLBMISC_WAY_MASK) | - (((way + 1) & (cpu->tlb_num_ways - 1)) << - CR_TLBMISC_WAY_SHIFT); + env->ctrl[CR_TLBMISC] =3D FIELD_DP32(env->ctrl[CR_TLBMISC], + CR_TLBMISC, WAY, + (way + 1) & (cpu->tlb_num_ways = - 1)); } =20 /* Writes to TLBACC don't change the read-back value */ @@ -130,24 +129,25 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint= 32_t v) void helper_mmu_write_tlbmisc(CPUNios2State *env, uint32_t v) { Nios2CPU *cpu =3D env_archcpu(env); + uint32_t new_pid =3D FIELD_EX32(v, CR_TLBMISC, PID); + uint32_t old_pid =3D FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID); + uint32_t way =3D FIELD_EX32(v, CR_TLBMISC, WAY); =20 - trace_nios2_mmu_write_tlbmisc(v >> CR_TLBMISC_WAY_SHIFT, + trace_nios2_mmu_write_tlbmisc(way, (v & CR_TLBMISC_RD) ? 'R' : '.', (v & CR_TLBMISC_WE) ? 'W' : '.', (v & CR_TLBMISC_DBL) ? '2' : '.', (v & CR_TLBMISC_BAD) ? 'B' : '.', (v & CR_TLBMISC_PERM) ? 'P' : '.', (v & CR_TLBMISC_D) ? 'D' : '.', - (v & CR_TLBMISC_PID_MASK) >> 4); + new_pid); =20 - if ((v & CR_TLBMISC_PID_MASK) !=3D - (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK)) { - mmu_flush_pid(env, (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> - CR_TLBMISC_PID_SHIFT); + if (new_pid !=3D old_pid) { + mmu_flush_pid(env, old_pid); } + /* if tlbmisc.RD =3D=3D 1 then trigger a TLB read on writes to TLBMISC= */ if (v & CR_TLBMISC_RD) { - int way =3D (v >> CR_TLBMISC_WAY_SHIFT); int vpn =3D FIELD_EX32(env->mmu.pteaddr_wr, CR_PTEADDR, VPN); Nios2TLBEntry *entry =3D &env->mmu.tlb[(way * cpu->tlb_num_ways) + @@ -156,10 +156,9 @@ void helper_mmu_write_tlbmisc(CPUNios2State *env, uint= 32_t v) env->ctrl[CR_TLBACC] &=3D R_CR_TLBACC_IG_MASK; env->ctrl[CR_TLBACC] |=3D entry->data; env->ctrl[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC_G := 0; - env->ctrl[CR_TLBMISC] =3D - (v & ~CR_TLBMISC_PID_MASK) | - ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) << - CR_TLBMISC_PID_SHIFT); + env->ctrl[CR_TLBMISC] =3D FIELD_DP32(v, CR_TLBMISC, PID, + entry->tag & + ((1 << cpu->pid_num_bits) - 1)); env->ctrl[CR_PTEADDR] =3D FIELD_DP32(env->ctrl[CR_PTEADDR], CR_PTEADDR, VPN, entry->tag >> TARGET_PAGE_BITS); diff --git a/target/nios2/translate.c b/target/nios2/translate.c index baa22c5101..4191db1342 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -925,7 +925,7 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int fl= ags) } qemu_fprintf(f, " mmu write: VPN=3D%05X PID %02X TLBACC %08X\n", env->mmu.pteaddr_wr & R_CR_PTEADDR_VPN_MASK, - (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4, + FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID), env->mmu.tlbacc_wr); #endif qemu_fprintf(f, "\n\n"); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999910; cv=none; d=zohomail.com; s=zohoarc; b=UPJvMlDFS0eFDg1UsL/YUKCxGN5gzKdmse0a7BIb7z8OgBYt9Q0T1km+ADFCbsnFoxTfW2ksxaFH3u+lm0BESBJb9fuvjxsIReUaPoNXl7okzD0oRH0ajBac6MihPjClGU8VPEqt7BEtvdTXESbDgKgO4KiUePKN8+Cv3w5RBqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999910; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ye00+f937DzjmYFcQBAIIaxN5ODYSNdMuba5fZB95Nk=; b=CMt/rSM+aKEi8f5FmpBP2AFV4QfQwWtbYMAhDKXMIYJ3rdw7IlhYYqrxY2N25xdQ39V/+arxET+AqqIGLZptdg5yECzaWm8Jn9QMytJU8ItXbf8E/mO7e1wy2Lw1i/R84a2qh3YjL22NR+9mPaJH8YKFN3pbC2pHjHUwpAtdZIE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16509999106221019.449405433751; Tue, 26 Apr 2022 12:05:10 -0700 (PDT) Received: from localhost ([::1]:35902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQUn-0000D6-6H for importer@patchew.org; Tue, 26 Apr 2022 15:05:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPml-0002hL-Kw for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:40 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:33437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmj-0004Rs-CB for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:39 -0400 Received: by mail-pf1-x42b.google.com with SMTP id p12so7000846pfn.0 for ; Tue, 26 Apr 2022 11:19:36 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ye00+f937DzjmYFcQBAIIaxN5ODYSNdMuba5fZB95Nk=; b=cEgqXvwpOXaCg3eVrUzuOv0AHEB8YsY6xpXROzkOF4LS3qCsWFeZGQ3m2ViCk92pmP kDxM2VgMUWnmh6zvtjNbAl2xQYNTphx2VcDXOiQsi0xah6c5tcxK9Q62VAGEsmSg1Cfc npc+wiElVSV5JL5JGlb6Jf8wwRvC9GpN7xA1oyUhjHFAcTMdReolP1rqf3w5Iu0hzYJb Z8Ru72EhAR01gf0MQQRDljeijCZHPHkgQ6AwmObPhB3yDJM0GdeTc8F5wiOCXy52rgJh S3PVTk5c82cSsvYHjAM3w7YHyUSOTf4ChjU9IybfakzCJZs1YSYeIkXhvLuliIsGY8Iq bGjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ye00+f937DzjmYFcQBAIIaxN5ODYSNdMuba5fZB95Nk=; b=U39x2oG+X6k4CuZseF8DIKwO0pYOh/uY9kZwv9ST9YtKx7jB7Dj+bRTn1hSo1cY1Xo dD2k4p6vAo5m55jlLLs6sWu86y/7au1qqV5epmV0PkVId/TaSK9DOSKZBOifQKlYnONt ZP/Zeu8KchA8apTcyOSYnojp7QaLYRrv8anVaeN6QqcunY94slFM+EgzB0rie3ekYiWS nSIsLFgVUnrECp6KjLoeJ1O88/fAWpw6+Ymnf2cBI7F/1CUuSCweyfN6ts8BVcJjkqbU U+MkY/jhTN7f9FQv5ugM3bJrlrzkK9kULRj3PIqEUHYyw2XNZEnjTxXoAddcOLvLkkX0 ZKvA== X-Gm-Message-State: AOAM531uPl/L8/Y9VoN35VZV3RguSonc310dalOOcwYh0QU1h23C2c90 S3LZ1TV5D4kHevL1Ds59kXyA/EqbuOD9PQ== X-Google-Smtp-Source: ABdhPJzQ5+lpPPoGItwxJxdp/3wZwrBtB/Qx/ccjhJ9BCbzNL+ute+gT9U4Hawmw9CRPuhdoKdlVVQ== X-Received: by 2002:aa7:84d9:0:b0:50d:3254:db8b with SMTP id x25-20020aa784d9000000b0050d3254db8bmr15583124pfn.78.1650997175943; Tue, 26 Apr 2022 11:19:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 30/68] target/nios2: Move R_FOO and CR_BAR into enumerations Date: Tue, 26 Apr 2022 11:18:29 -0700 Message-Id: <20220426181907.103691-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999912855100003 Content-Type: text/plain; charset="utf-8" These symbols become available to the debugger. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-31-richard.henderson@linaro.org> --- target/nios2/cpu.h | 72 ++++++++++++++++++++++------------------------ 1 file changed, 35 insertions(+), 37 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index f312050ecd..65bcc5fc0e 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -61,25 +61,43 @@ struct Nios2CPUClass { #define NUM_CR_REGS 32 =20 /* General purpose register aliases */ -#define R_ZERO 0 -#define R_AT 1 -#define R_RET0 2 -#define R_RET1 3 -#define R_ARG0 4 -#define R_ARG1 5 -#define R_ARG2 6 -#define R_ARG3 7 -#define R_ET 24 -#define R_BT 25 -#define R_GP 26 -#define R_SP 27 -#define R_FP 28 -#define R_EA 29 -#define R_BA 30 -#define R_RA 31 +enum { + R_ZERO =3D 0, + R_AT =3D 1, + R_RET0 =3D 2, + R_RET1 =3D 3, + R_ARG0 =3D 4, + R_ARG1 =3D 5, + R_ARG2 =3D 6, + R_ARG3 =3D 7, + R_ET =3D 24, + R_BT =3D 25, + R_GP =3D 26, + R_SP =3D 27, + R_FP =3D 28, + R_EA =3D 29, + R_BA =3D 30, + R_RA =3D 31, +}; =20 /* Control register aliases */ -#define CR_STATUS 0 +enum { + CR_STATUS =3D 0, + CR_ESTATUS =3D 1, + CR_BSTATUS =3D 2, + CR_IENABLE =3D 3, + CR_IPENDING =3D 4, + CR_CPUID =3D 5, + CR_EXCEPTION =3D 7, + CR_PTEADDR =3D 8, + CR_TLBACC =3D 9, + CR_TLBMISC =3D 10, + CR_ENCINJ =3D 11, + CR_BADADDR =3D 12, + CR_CONFIG =3D 13, + CR_MPUBASE =3D 14, + CR_MPUACC =3D 15, +}; =20 FIELD(CR_STATUS, PIE, 0, 1) FIELD(CR_STATUS, U, 1, 1) @@ -98,24 +116,12 @@ FIELD(CR_STATUS, RSIE, 23, 1) #define CR_STATUS_NMI R_CR_STATUS_NMI_MASK #define CR_STATUS_RSIE R_CR_STATUS_RSIE_MASK =20 -#define CR_ESTATUS 1 -#define CR_BSTATUS 2 -#define CR_IENABLE 3 -#define CR_IPENDING 4 -#define CR_CPUID 5 -#define CR_CTL6 6 -#define CR_EXCEPTION 7 - FIELD(CR_EXCEPTION, CAUSE, 2, 5) FIELD(CR_EXCEPTION, ECCFTL, 31, 1) =20 -#define CR_PTEADDR 8 - FIELD(CR_PTEADDR, VPN, 2, 20) FIELD(CR_PTEADDR, PTBASE, 22, 10) =20 -#define CR_TLBACC 9 - FIELD(CR_TLBACC, PFN, 0, 20) FIELD(CR_TLBACC, G, 20, 1) FIELD(CR_TLBACC, X, 21, 1) @@ -130,8 +136,6 @@ FIELD(CR_TLBACC, IG, 25, 7) #define CR_TLBACC_X R_CR_TLBACC_X_MASK #define CR_TLBACC_G R_CR_TLBACC_G_MASK =20 -#define CR_TLBMISC 10 - FIELD(CR_TLBMISC, D, 0, 1) FIELD(CR_TLBMISC, PERM, 1, 1) FIELD(CR_TLBMISC, BAD, 2, 1) @@ -150,12 +154,6 @@ FIELD(CR_TLBMISC, EE, 24, 1) #define CR_TLBMISC_PERM R_CR_TLBMISC_PERM_MASK #define CR_TLBMISC_D R_CR_TLBMISC_D_MASK =20 -#define CR_ENCINJ 11 -#define CR_BADADDR 12 -#define CR_CONFIG 13 -#define CR_MPUBASE 14 -#define CR_MPUACC 15 - /* Exceptions */ #define EXCP_BREAK 0x1000 #define EXCP_RESET 0 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999930; cv=none; d=zohomail.com; s=zohoarc; b=InZgGEAZj7GE//lYCqgeBNXTUP0fUWk40F7EmkiWADU4iHw6ntGwQpGUkNYik+9QRv9k8IVBoUbOonnqiY2xqZmyTHqUwnxUmoWowj4sOEQ2Ly4QXoWXrrOznnxNiu7n46aXN1vRq0rBkbnMfffzQ75dQBUo7k4Tes2Uhciph0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999930; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JGG1SeKnuAT2QHCjae7Ts/IpHjmxbOVPlNo/xG2utBk=; b=Rhy9h3FaUluxkl70wq3lWG4/xRBjqabSeyBFQXeuvUulJHhydDN26hZIorfxzvPSCYZNiCZRmVGWZxXFQ6VKQwbHSTeKRUsefd1yQTHH5vPOwxCRRCOESGjiaafCa4H0L1Zy+AekGx8MsQXHpHFkr0Eo4IRg0kUHWgdDUZRZ2Ok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999930006969.1412870377804; Tue, 26 Apr 2022 12:05:30 -0700 (PDT) Received: from localhost ([::1]:37570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQV6-0001MC-Uo for importer@patchew.org; Tue, 26 Apr 2022 15:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmm-0002ha-3b for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:40 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:43922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmk-0004S1-Cg for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:39 -0400 Received: by mail-pf1-x42d.google.com with SMTP id y14so17926428pfe.10 for ; Tue, 26 Apr 2022 11:19:37 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JGG1SeKnuAT2QHCjae7Ts/IpHjmxbOVPlNo/xG2utBk=; b=ODGBhfon5dy7laNbX5Rp5wJwZRhk99HNMMoCbizdxAmmtTiTNVmwVdzwcq/ih/djji +ieYo79vgnOsSz3i743swU14eceiaC2gdABczWS+hQMwQv6d3NP0eQwTvYRpYlddOak8 Wvh4V3Cbt2Im1OjhVBIeoYBZVO7YSjGI+1ALFk/C6c/MNCCTj81Q2xxxLVNcUVi23CFE Mf5SiNQ1YClKWwyUTLNw+8mUEhYVu5cuJN8+c4lXg6CKbG62D5Ocaez5qzB2J5zB0x9f 6L7KNxgA9NK1rNaxHmd/EtsxFEmWJFrj4S1fL5JC2z+C1PA4jXVZyzxznb0rkv+CLIZz AZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JGG1SeKnuAT2QHCjae7Ts/IpHjmxbOVPlNo/xG2utBk=; b=I75Y7xgDQ4i6lguOvEkLxEJUr7xm4uJT/XOm52GhHvl/dSsslHsyNWbjqPV8w2svyO EdWzMnaQbdngb5kbA9+2owXjEGamWfOZVTh9obzXTRStu1z0M1XeZ9x7cKtBMmXdKjjQ VNC1A+rAnc6slSTr3IXjfLBxxJgjqRfJTd7B9U1JIVwnBlhoPCv42lHojiR80+RuHDAC /f0ggnkxCy3Q6LD3tfpI4ly0YNCYSjo0sJ1PRYL91ebumRdvMKSblv6T2+o8vz9Sbkpe CQaASJiRllJXX446MMQkWwBhjlJurPZi2INkvHDLenwZ2SvMZ5+riXF2WHL9zTuEKotb g+3w== X-Gm-Message-State: AOAM533Cogv+A4woeITqB9UHDDidF4Hkjq1uqWBOZkpTOpGsGyjsuSZR w0AJmlmpjq4XUjYOBfqR4fWTgzchPSSzYQ== X-Google-Smtp-Source: ABdhPJx0hBUjw730r6urtog3qTCBOU4QgmryiYRJfN84+GspU+qCxRk+kiCqe4qH5mx8IsM/iz6nQw== X-Received: by 2002:aa7:9109:0:b0:50a:78c8:8603 with SMTP id 9-20020aa79109000000b0050a78c88603mr25599642pfh.77.1650997176878; Tue, 26 Apr 2022 11:19:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 31/68] target/nios2: Create EXCP_SEMIHOST for semi-hosting Date: Tue, 26 Apr 2022 11:18:30 -0700 Message-Id: <20220426181907.103691-32-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999931046100001 Content-Type: text/plain; charset="utf-8" Decode 'break 1' during translation, rather than doing it again during exception processing. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-32-richard.henderson@linaro.org> --- target/nios2/cpu.h | 1 + target/nios2/helper.c | 14 ++++++-------- target/nios2/translate.c | 17 ++++++++++++++++- 3 files changed, 23 insertions(+), 9 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 65bcc5fc0e..01cead5502 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -156,6 +156,7 @@ FIELD(CR_TLBMISC, EE, 24, 1) =20 /* Exceptions */ #define EXCP_BREAK 0x1000 +#define EXCP_SEMIHOST 0x1001 #define EXCP_RESET 0 #define EXCP_PRESET 1 #define EXCP_IRQ 2 diff --git a/target/nios2/helper.c b/target/nios2/helper.c index a56aaaea18..1d17c0379f 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -152,14 +152,6 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 case EXCP_BREAK: qemu_log_mask(CPU_LOG_INT, "BREAK exception at pc=3D%x\n", env->pc= ); - /* The semihosting instruction is "break 1". */ - if (semihosting_enabled() && - cpu_ldl_code(env, env->pc) =3D=3D 0x003da07a) { - qemu_log_mask(CPU_LOG_INT, "Entering semihosting\n"); - env->pc +=3D 4; - do_nios2_semihosting(env); - break; - } =20 if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->ctrl[CR_BSTATUS] =3D env->ctrl[CR_STATUS]; @@ -176,6 +168,12 @@ void nios2_cpu_do_interrupt(CPUState *cs) env->pc =3D cpu->exception_addr; break; =20 + case EXCP_SEMIHOST: + qemu_log_mask(CPU_LOG_INT, "BREAK semihosting at pc=3D%x\n", env->= pc); + env->pc +=3D 4; + do_nios2_semihosting(env); + break; + default: cpu_abort(cs, "unhandled exception type=3D%d\n", cs->exception_index); diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 4191db1342..97e531529f 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -33,6 +33,7 @@ #include "exec/translator.h" #include "qemu/qemu-print.h" #include "exec/gen-icount.h" +#include "semihosting/semihost.h" =20 /* is_jmp field values */ #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ @@ -686,6 +687,20 @@ static void trap(DisasContext *dc, uint32_t code, uint= 32_t flags) t_gen_helper_raise_exception(dc, EXCP_TRAP); } =20 +static void gen_break(DisasContext *dc, uint32_t code, uint32_t flags) +{ +#ifndef CONFIG_USER_ONLY + /* The semihosting instruction is "break 1". */ + R_TYPE(instr, code); + if (semihosting_enabled() && instr.imm5 =3D=3D 1) { + t_gen_helper_raise_exception(dc, EXCP_SEMIHOST); + return; + } +#endif + + t_gen_helper_raise_exception(dc, EXCP_BREAK); +} + static const Nios2Instruction r_type_instructions[] =3D { INSTRUCTION_ILLEGAL(), INSTRUCTION(eret), /* eret */ @@ -739,7 +754,7 @@ static const Nios2Instruction r_type_instructions[] =3D= { INSTRUCTION(add), /* add */ INSTRUCTION_ILLEGAL(), INSTRUCTION_ILLEGAL(), - INSTRUCTION_FLG(gen_excp, EXCP_BREAK), /* break */ + INSTRUCTION(gen_break), /* break */ INSTRUCTION_ILLEGAL(), INSTRUCTION(nop), /* nop */ INSTRUCTION_ILLEGAL(), --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998784; cv=none; d=zohomail.com; s=zohoarc; b=jBgR4kwLNW4xcCZqbP/r7oEFP3lG8N4dHqVBCcV2HbTiSqvXhIawwA68etr1RoDv2xiGU3up4+I2sc0Huoiwk2m4RYwTZkJpgfEV8GmkVufRzj+Yd+mRwub5pJpQKCVC9eEhbJGyuHYQlXJ1qGkyjhfDrk5Vvw6ewyXzYdFD27Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998784; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f5/eHgJ89Bw1Fi14EqcdKUKLBG0n+ns6jn+rbbcLZws=; b=MO8XYhUjoEa0+hjoMJWcZDoW0Ro2ztKf8w17dr8VGROn/3Q85SpDLWj+dMRtM416Rq5gqJ2IFJYil8xI0k73OKPhZK3VQFzox4BhH2PWu5q7YwgIGvusa22g5kTAe9GfpAVKhh5U0VrXl44iGPbLiSInALiTr15+HVIpZRrr6Eo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998784021120.12797634928427; Tue, 26 Apr 2022 11:46:24 -0700 (PDT) Received: from localhost ([::1]:48178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQCc-0003GA-U7 for importer@patchew.org; Tue, 26 Apr 2022 14:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmn-0002jM-6k for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:41 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:40816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPml-0004SK-A5 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:40 -0400 Received: by mail-pj1-x1030.google.com with SMTP id iq2-20020a17090afb4200b001d93cf33ae9so2839906pjb.5 for ; Tue, 26 Apr 2022 11:19:38 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f5/eHgJ89Bw1Fi14EqcdKUKLBG0n+ns6jn+rbbcLZws=; b=WwtkxSc63TR/3JfuNCDNE27rMTQdesPh+5CUNjXnrkWEsHI0iKJLQuQfrNNSkrLwHx VfZCZ6bHMrLrppMfgaIqGnPaoJHpvuQHsRIYqkbAugQmw1TdIpB93uA8hf/amwpGLo60 6oUobFnDLqnOFA2Y2QsMZ/Rg++FMoeN/0r1drjN76wZt7fvI945yEvXGS4cTwBkW0prd 6U+KtZLvxsBZWdCKNiV7hp77mrWTzBxG+NtJXO0/eG2pfmAp52PWAzq6RuJTKfnWuV4f osMDPUsJudA/pkpj3/dai3YEDvpgn7QvhU4bbxurlgYv9qPWK9m3RrsTmAmAm8sIB8Tq Na+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f5/eHgJ89Bw1Fi14EqcdKUKLBG0n+ns6jn+rbbcLZws=; b=6lBvbr5sEPhMLq5yEtnd+rWJNn8IaFkTmAuy+Lcb62crQpgI+ObYGZKYuvzKIPLbQ2 900Xu0hvgk8iryIwJJ+87ghfxnhawAc4b29I3DqI0kobPTx/yoVNEveYyQW2IAv4c2+4 RKHvussIGTZTM5fwlYgvL+hgsJil/x5D4DxtMyBBgEuZ4EGO8OGTvWPB9dgJhcPOO3m0 m6m6LVT4kJVQabUK2gaP81OJzeFgvV/xgJu6Scr4yH7VTNYBf0ApGxXJLQL/Av3JRquU kQvq6CXNRzdEsZL1biTF30TM4GftUjj/7g+NyGoXqlNNWl7AChArmPIXv7T11taUpILb 8FnQ== X-Gm-Message-State: AOAM531TLhIHDZyAGeb3b55rm5KVfFK1uvLLjA7UQGS7wwBt/BG0klvh e4t/UYneaF3LKvxkUgmJsHw83mjBQ9jvFA== X-Google-Smtp-Source: ABdhPJzfXgx6Lt604q+4azAGwC/K+OUsiZFkoHvwCA9a4f54TMz7D6b82cZwBkg4Z3BG9bbphB+BLw== X-Received: by 2002:a17:902:d1cd:b0:15d:1483:6ed6 with SMTP id g13-20020a170902d1cd00b0015d14836ed6mr12139126plb.58.1650997178004; Tue, 26 Apr 2022 11:19:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 32/68] target/nios2: Clean up nios2_cpu_do_interrupt Date: Tue, 26 Apr 2022 11:18:31 -0700 Message-Id: <20220426181907.103691-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998784532100003 Content-Type: text/plain; charset="utf-8" Split out do_exception and do_iic_irq to handle bulk of the interrupt and exception processing. Parameterize the changes required to cpu state. The status.EH bit, which protects some data against double-faults, is only present with the MMU. Several exception cases did not check for status.EH being set, as required. The status.IH bit, which had been set by EXCP_IRQ, is exclusive to the external interrupt controller, which we do not yet implement. The internal interrupt controller, when the MMU is also present, sets the status.EH bit. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-33-richard.henderson@linaro.org> --- target/nios2/helper.c | 141 +++++++++++++----------------------------- 1 file changed, 44 insertions(+), 97 deletions(-) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 1d17c0379f..63971a8b3c 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -29,6 +29,42 @@ #include "semihosting/semihost.h" =20 =20 +static void do_exception(Nios2CPU *cpu, uint32_t exception_addr, bool is_b= reak) +{ + CPUNios2State *env =3D &cpu->env; + CPUState *cs =3D CPU(cpu); + uint32_t old_status =3D env->ctrl[CR_STATUS]; + uint32_t new_status =3D old_status; + + if ((old_status & CR_STATUS_EH) =3D=3D 0) { + int r_ea =3D R_EA, cr_es =3D CR_ESTATUS; + + if (is_break) { + r_ea =3D R_BA; + cr_es =3D CR_BSTATUS; + } + env->ctrl[cr_es] =3D old_status; + env->regs[r_ea] =3D env->pc + 4; + + if (cpu->mmu_present) { + new_status |=3D CR_STATUS_EH; + } + } + + new_status &=3D ~(CR_STATUS_PIE | CR_STATUS_U); + + env->ctrl[CR_STATUS] =3D new_status; + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], + CR_EXCEPTION, CAUSE, + cs->exception_index); + env->pc =3D exception_addr; +} + +static void do_iic_irq(Nios2CPU *cpu) +{ + do_exception(cpu, cpu->exception_addr, false); +} + void nios2_cpu_do_interrupt(CPUState *cs) { Nios2CPU *cpu =3D NIOS2_CPU(cs); @@ -36,57 +72,20 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 switch (cs->exception_index) { case EXCP_IRQ: - assert(env->ctrl[CR_STATUS] & CR_STATUS_PIE); - qemu_log_mask(CPU_LOG_INT, "interrupt at pc=3D%x\n", env->pc); - - env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; - env->ctrl[CR_STATUS] |=3D CR_STATUS_IH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - - env->regs[R_EA] =3D env->pc + 4; - env->pc =3D cpu->exception_addr; + do_iic_irq(cpu); break; =20 case EXCP_TLBD: if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { qemu_log_mask(CPU_LOG_INT, "TLB MISS (fast) at pc=3D%x\n", env= ->pc); - - /* Fast TLB miss */ - /* Variation from the spec. Table 3-35 of the cpu reference sh= ows - * estatus not being changed for TLB miss but this appears to - * be incorrect. */ - env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; - - env->regs[R_EA] =3D env->pc + 4; - env->pc =3D cpu->fast_tlb_miss_addr; + do_exception(cpu, cpu->fast_tlb_miss_addr, false); } else { qemu_log_mask(CPU_LOG_INT, "TLB MISS (double) at pc=3D%x\n", e= nv->pc); - - /* Double TLB miss */ - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_DBL; - - env->pc =3D cpu->exception_addr; + do_exception(cpu, cpu->exception_addr, false); } break; =20 @@ -94,78 +93,28 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_TLBW: case EXCP_TLBX: qemu_log_mask(CPU_LOG_INT, "TLB PERM at pc=3D%x\n", env->pc); - - env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; } - - env->regs[R_EA] =3D env->pc + 4; - env->pc =3D cpu->exception_addr; + do_exception(cpu, cpu->exception_addr, false); break; =20 case EXCP_SUPERA: case EXCP_SUPERI: case EXCP_SUPERD: qemu_log_mask(CPU_LOG_INT, "SUPERVISOR exception at pc=3D%x\n", en= v->pc); - - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; - env->regs[R_EA] =3D env->pc + 4; - } - - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - - env->pc =3D cpu->exception_addr; + do_exception(cpu, cpu->exception_addr, false); break; =20 case EXCP_ILLEGAL: case EXCP_TRAP: qemu_log_mask(CPU_LOG_INT, "TRAP exception at pc=3D%x\n", env->pc); - - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_ESTATUS] =3D env->ctrl[CR_STATUS]; - env->regs[R_EA] =3D env->pc + 4; - } - - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - - env->pc =3D cpu->exception_addr; + do_exception(cpu, cpu->exception_addr, false); break; =20 case EXCP_BREAK: qemu_log_mask(CPU_LOG_INT, "BREAK exception at pc=3D%x\n", env->pc= ); - - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_BSTATUS] =3D env->ctrl[CR_STATUS]; - env->regs[R_BA] =3D env->pc + 4; - } - - env->ctrl[CR_STATUS] |=3D CR_STATUS_EH; - env->ctrl[CR_STATUS] &=3D ~(CR_STATUS_PIE | CR_STATUS_U); - - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); - - env->pc =3D cpu->exception_addr; + do_exception(cpu, cpu->exception_addr, true); break; =20 case EXCP_SEMIHOST: @@ -175,9 +124,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) break; =20 default: - cpu_abort(cs, "unhandled exception type=3D%d\n", - cs->exception_index); - break; + cpu_abort(cs, "unhandled exception type=3D%d\n", cs->exception_ind= ex); } } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999017; cv=none; d=zohomail.com; s=zohoarc; b=iogIPWmyMgwK8goGtaCoJdMz9nhuoyPNGxiDXmkFgeKfr30NLMKuymdeDJiRCQ4celks7q8iJZpVjU5s3HsZ/25+FHU6cfopudQw3KSBhIRJZqMAQY8oDQj247T1YXsORiJxptipI/0RW26wxbvp+i6xg4NX3/d4pgep+P4CUGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999017; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A1+hFfX+YJ+rRNsAMYCjA2Q5J7nLgy08oqJtBrD3bio=; b=Wfkd34biDpyQPtdi2y3u+yuNwF4OF9lsFk/gMFQjV4pUQOvOOu/g4rl80XfR4nPOqzfSCzX5xsn15Fdde5UoDVBCxVRgT2Rb2MwPksupEVECvrZL2VQIB1PUf4DoEgBLX2ZvySSMhfnSaUIkpPfH8QIQUPwVQ4z+8WVxTPiNwcc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999017991440.190062909591; Tue, 26 Apr 2022 11:50:17 -0700 (PDT) Received: from localhost ([::1]:58818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQGO-0002FO-TS for importer@patchew.org; Tue, 26 Apr 2022 14:50:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmn-0002mA-Vo for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:42 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:40814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmm-0004SV-7u for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:41 -0400 Received: by mail-pl1-x635.google.com with SMTP id k4so19422634plk.7 for ; Tue, 26 Apr 2022 11:19:39 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A1+hFfX+YJ+rRNsAMYCjA2Q5J7nLgy08oqJtBrD3bio=; b=N9tVD146lC91OR9AB1YEauJTpihgsmfbQ9sU3QwN0ZL5HR/wxRK3h56FjtmTVMiU4Z LD+fnTl3kvX/8r8W8LP2p5QUznySyHq1t305HdvdoGkBBQScIbKzlO2Istl07z8r8yub T5famVUUr/wWT5eCLFLoEKFyBaI5kUIzS85iz81Q8q+tfcXTR2gRpgE0nArf0dobYQm5 F+WB6oz7pdYQFHIXOXY+yz6cKE79fU4VyjywrxBz7EInDGFe94ESjieY/v8hrMJTm50Z C4SfCRKmb4K/FwBlFYWDUhigTxdEg3/X6OWeFLrAyaGoOpUGndS9/2wPeUMnOu9HN6Vd 5Xyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A1+hFfX+YJ+rRNsAMYCjA2Q5J7nLgy08oqJtBrD3bio=; b=pJjcLxAjFj6CIsoVRNfhveG5o6xIppnzRMaJoFHDJTdv4Nn7Nn01OqJeB21HEcGC1K MDpjQa9eCnrwqnc5QCR1O/Tbh5NnFT481nw5vRFgfE2zYYiB57WElUYNSUM1H4UIqN5p 7itxTJSnp3m7ya/DbYE8DkQLtoXxlT/WNzcu+CKW821c1iurDJ5YyQ698xC4jCGgT989 AW6C8ZW0gVFll5HxxX8FM7hfZ8vjuCrICYd5xJC8QlPDVn0NaI7GxGjKFpuzwCTEdqb5 kLlBjV+A9UUgbq9PMaHrJ2Am7OzxR2KnOQfGRj0qY+HcBcP4M4XL3iGAW+FHj1/Hgcf0 Umzg== X-Gm-Message-State: AOAM533YF7cMOYSwR9S2wXOvSzzdcTGMyHzudyYUBfCrFCP9n0djFfLQ 4PNP3wdwKl4DWceTzOyvZo2ts6rXHEKYAA== X-Google-Smtp-Source: ABdhPJznpUFVx1rgGFnM3X9ksargTx2a+s+YpG2ORZUSdo5/gE+eNhXyW/uIWdYeYtu/YkXlqt2xUg== X-Received: by 2002:a17:902:e808:b0:15c:ed0d:f11c with SMTP id u8-20020a170902e80800b0015ced0df11cmr17368991plg.1.1650997178888; Tue, 26 Apr 2022 11:19:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 33/68] target/nios2: Hoist CPU_LOG_INT logging Date: Tue, 26 Apr 2022 11:18:32 -0700 Message-Id: <20220426181907.103691-34-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999019563100002 Content-Type: text/plain; charset="utf-8" Performing this early means that we can merge more cases within the non-logging switch statement. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-34-richard.henderson@linaro.org> --- target/nios2/helper.c | 58 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 63971a8b3c..c57ffd64e0 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -70,20 +70,64 @@ void nios2_cpu_do_interrupt(CPUState *cs) Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUNios2State *env =3D &cpu->env; =20 + if (qemu_loglevel_mask(CPU_LOG_INT)) { + const char *name =3D NULL; + + switch (cs->exception_index) { + case EXCP_IRQ: + name =3D "interrupt"; + break; + case EXCP_TLBD: + if (env->ctrl[CR_STATUS] & CR_STATUS_EH) { + name =3D "TLB MISS (double)"; + } else { + name =3D "TLB MISS (fast)"; + } + break; + case EXCP_TLBR: + case EXCP_TLBW: + case EXCP_TLBX: + name =3D "TLB PERM"; + break; + case EXCP_SUPERA: + case EXCP_SUPERD: + name =3D "SUPERVISOR (address)"; + break; + case EXCP_SUPERI: + name =3D "SUPERVISOR (insn)"; + break; + case EXCP_ILLEGAL: + name =3D "ILLEGAL insn"; + break; + case EXCP_TRAP: + name =3D "TRAP insn"; + break; + case EXCP_BREAK: + name =3D "BREAK insn"; + break; + case EXCP_SEMIHOST: + name =3D "SEMIHOST insn"; + break; + } + if (name) { + qemu_log("%s at pc=3D0x%08x\n", name, env->pc); + } else { + qemu_log("Unknown exception %d at pc=3D0x%08x\n", + cs->exception_index, env->pc); + } + } + switch (cs->exception_index) { case EXCP_IRQ: - qemu_log_mask(CPU_LOG_INT, "interrupt at pc=3D%x\n", env->pc); do_iic_irq(cpu); break; =20 case EXCP_TLBD: if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - qemu_log_mask(CPU_LOG_INT, "TLB MISS (fast) at pc=3D%x\n", env= ->pc); env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; do_exception(cpu, cpu->fast_tlb_miss_addr, false); } else { - qemu_log_mask(CPU_LOG_INT, "TLB MISS (double) at pc=3D%x\n", e= nv->pc); env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_DBL; do_exception(cpu, cpu->exception_addr, false); } @@ -92,7 +136,6 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_TLBR: case EXCP_TLBW: case EXCP_TLBX: - qemu_log_mask(CPU_LOG_INT, "TLB PERM at pc=3D%x\n", env->pc); if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; } @@ -102,23 +145,16 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_SUPERA: case EXCP_SUPERI: case EXCP_SUPERD: - qemu_log_mask(CPU_LOG_INT, "SUPERVISOR exception at pc=3D%x\n", en= v->pc); - do_exception(cpu, cpu->exception_addr, false); - break; - case EXCP_ILLEGAL: case EXCP_TRAP: - qemu_log_mask(CPU_LOG_INT, "TRAP exception at pc=3D%x\n", env->pc); do_exception(cpu, cpu->exception_addr, false); break; =20 case EXCP_BREAK: - qemu_log_mask(CPU_LOG_INT, "BREAK exception at pc=3D%x\n", env->pc= ); do_exception(cpu, cpu->exception_addr, true); break; =20 case EXCP_SEMIHOST: - qemu_log_mask(CPU_LOG_INT, "BREAK semihosting at pc=3D%x\n", env->= pc); env->pc +=3D 4; do_nios2_semihosting(env); break; --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999239; cv=none; d=zohomail.com; s=zohoarc; b=lqAiOX4rbq/m+CN10EYR6Q0Ybbbn/+RByZ+j59dp34K0F8tSh9m0rQWdmmBkg0+ZsMCRUy+aWoWfBBHm0pYWFCndTFL1E73pPwUBhbjHdvnbo2vPDsnurXs4HJyj95CIPzEXZcP6qXMkYsPJbC5gAg1Met2wCkcp9tcQDXOFGVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999239; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3aQg/hoAbUd4FyanyKyY4J09ziZifM+SJiSbzB2iG8g=; b=L4/stnzSAlQD3e3UdOmVFyse/npuY8pBsUUBiYTvysOaQK5O1c/zbut4MUIYHY5KPRevlKk2WmuDBJATnpDPWHCMzK+XvKPTSaNxc2KLZG3/m83O7KeY7zjUEVYpjSjeTDUJrtJmfvDMKaVy3Bf6qQZDJ5WCQ2HBg2xJoRw56vc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999239478379.85038753246783; Tue, 26 Apr 2022 11:53:59 -0700 (PDT) Received: from localhost ([::1]:39268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQJy-0008VE-DW for importer@patchew.org; Tue, 26 Apr 2022 14:53:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmo-0002p2-OS for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:42 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:40507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmn-0004Sk-8q for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:42 -0400 Received: by mail-pf1-x435.google.com with SMTP id i24so18692906pfa.7 for ; Tue, 26 Apr 2022 11:19:40 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3aQg/hoAbUd4FyanyKyY4J09ziZifM+SJiSbzB2iG8g=; b=eiPB9tlHIBWQkhf1mTISs6h2qoJU2kjTP1E1bHlyi1jFb1paEoAv+VAb49/3z7/Z9z VzJEwAavGSE7JdOJLT+DzhtTCEgH/KMVGE1kx6cd3eOvy0y++GvgxobKde5ADbVWfKiy WFRGbVM6gb3wUsk2frEsrU6Geu3gySwq516LcMgNX+UqwzetDolqOc2fI1tHwMH8edg1 rjcx17zQTLfz3bpyiwf2PK8tu9T4H31o5tzol4ExNFzGR/TMUehRn43mR471DoK7c3Rj 2Q7je/Ay088pkSOEaP+o627uMT6FER7DF7frTYPT7/N4vuIS7co4y9WYHsoeg9gqNI5y tWuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3aQg/hoAbUd4FyanyKyY4J09ziZifM+SJiSbzB2iG8g=; b=J53qBMyhzKLRJku5iXahQ6cdzYV/vI0uf/rn1geaN7TY9oJN1rrsCHEyA3J/U59Eue EdtVkV8P2WEIjWzrd/4wDPBCAEeXbI4QJdKT7mattiw1LQauF1jm73nZZOTByyi421/K rxn/ZE4wx4FCV/QGJ9zdECRnfaydguwMC6aLpT8kzBPBFf53Yb9PADuAlTHRH8QbblKA eynHH9MGj1ZjhZ73UJMTm+50XBtf9Hu//Pw88TKJTYywBoD/pr/oK/SEbCEsJoYKBBTq UyRsDPATPHmQeIy0DmVHDZhIipbfQmsdQ6Kxg3hfV0GZL/61quZ+VJNuT8bdpLP4JU1Z d5ng== X-Gm-Message-State: AOAM532Q5Svm8RdYX2l/9TPENShb/6smVY+thOoC/VbOA2li/mIDhcPk Z9QoTtvV2P/d5kp+zyWV0uCdb6CkbgjthA== X-Google-Smtp-Source: ABdhPJxlGcVE/rg7NCEK6Pn2uWgaHce1T0+jMgJSNZk30YhbbzyniAI40yD+BhmM21HyVudAPU/B1Q== X-Received: by 2002:a05:6a00:b8b:b0:50d:6080:6be7 with SMTP id g11-20020a056a000b8b00b0050d60806be7mr3501650pfj.56.1650997179959; Tue, 26 Apr 2022 11:19:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 34/68] target/nios2: Handle EXCP_UNALIGN and EXCP_UNALIGND Date: Tue, 26 Apr 2022 11:18:33 -0700 Message-Id: <20220426181907.103691-35-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999240552100003 Content-Type: text/plain; charset="utf-8" While some of the plumbing for misaligned data is present, in the form of nios2_cpu_do_unaligned_access, the hook will not be called because TARGET_ALIGNED_ONLY is not set in configs/targets/nios2-softmmu.mak. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-35-richard.henderson@linaro.org> --- target/nios2/helper.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index c57ffd64e0..25a89724d0 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -99,6 +99,12 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_ILLEGAL: name =3D "ILLEGAL insn"; break; + case EXCP_UNALIGN: + name =3D "Misaligned (data)"; + break; + case EXCP_UNALIGND: + name =3D "Misaligned (destination)"; + break; case EXCP_TRAP: name =3D "TRAP insn"; break; @@ -147,6 +153,8 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_SUPERD: case EXCP_ILLEGAL: case EXCP_TRAP: + case EXCP_UNALIGN: + case EXCP_UNALIGND: do_exception(cpu, cpu->exception_addr, false); break; =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000076; cv=none; d=zohomail.com; s=zohoarc; b=CUQbrNBT5q62AOSIANcmryWMvNI0wDMJLIMMcDPhHL9AOGWDBmmzW1pm74Lu3oEA9IpYHnsi0ztaajS4b+z4tmRj58OwLxEyuVgPsUDq0BHDHDS7nWlOO0Tye/knK7Z8CYUfP+O3QHLHpZYx2QdETUigA+Mv1AnkB+t3WLjGLho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000076; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ysJZrdf3qEL6SmyFziC5eyUqxmIxqoso+UNr/N0Gtr8=; b=Rw1GvlMF2e73JInSOwTSSTxZkWVyARhyeMSBhL1utPClIpFrSJmoMRJZVSVqTvv85WCcZYWoGynnsFf/uhWeiS9aJ/7T97dbXnCjfWFNBncLMO8Tyv+HtmeiTrx1s+NjBOmOjZ77f4j1QyvhCHMI4LLikyTKQoN/Dl0ydGwK9v8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000076079497.83174373562633; Tue, 26 Apr 2022 12:07:56 -0700 (PDT) Received: from localhost ([::1]:44444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQXS-0006Ao-TO for importer@patchew.org; Tue, 26 Apr 2022 15:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmp-0002so-L3 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:43 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:39674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmo-0004Sy-3V for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:43 -0400 Received: by mail-pg1-x536.google.com with SMTP id i62so4557121pgd.6 for ; Tue, 26 Apr 2022 11:19:41 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ysJZrdf3qEL6SmyFziC5eyUqxmIxqoso+UNr/N0Gtr8=; b=bnfNjY32un9c12FVUl6geh2rs5BDwjv7jU7Iaix8oF8lMVvO6MbzuRmgaFnp/Ij2l7 tH7ra7bsOLGcdfNhJkXW+KqkTDo5NLQ2hZBkpEOtp/bT5slJll02ZQSFal8uTwIuilS+ VPjCuBhiF0+9Qf35MNDadXXSt4/m/t0IJXHd5oa8Tjw8egvJFV3+/hiqzCffmPs88r0v uWq4EzzIbkg0TaziEamX0Muq1gvylx/aLZosDKx44/zeuC0BFQa2ysJ8/WOjICYxUGhj Pngdkys40RY7lKmH30dTbRwDC9vy33yHAshPQzsp5/5LySv90eiyR91trufliyNRran1 Nhgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ysJZrdf3qEL6SmyFziC5eyUqxmIxqoso+UNr/N0Gtr8=; b=2j5AC+E447SxMNcvTbvLM7jom6cwKTaDA2gGdkSWYGYLE1ClrmHGUv2OfnVUAR5dV5 KYYL5LQQf1vOPtjg2eKdBA8BpTtgqUpMVAYKxccGqgkRYrPT4ijHma3qfx2Eq9LhgzYI XEl+Splo36D2GDLni649V7P4mllAR9HgoBiyq/jOCyI99sMb1PqXz2FOUbI6AtaMWmQ2 0M4sYT6I6ivzekBAjDX9bfDnVheA90EWhjRSActuUaAj1Y7yGQyt0bGfmb9ibEH59QcZ zxsdjLO3nlULMZG6OBZHafBb4OHg58b9jsdcDcUClP0zsx1RT0GrwMNAL+fhAiBiCazQ 7fhg== X-Gm-Message-State: AOAM5326Ko7MkG3muNThg8IT3547ZcKb3s76qNIkZyTVvFODUmJt3d25 c2VcVK8GWYWGcKBod2rVHqsV90+q62BziA== X-Google-Smtp-Source: ABdhPJz2wEyX6v1CbL4R+p/mNlo/3fMx6T1YRZtQQuvXrxvwvITtWYgrV9NP0qQiZzMr8Xkzp1b8NA== X-Received: by 2002:a62:fb0e:0:b0:505:fd9e:9218 with SMTP id x14-20020a62fb0e000000b00505fd9e9218mr26300262pfm.78.1650997180873; Tue, 26 Apr 2022 11:19:40 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 35/68] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt Date: Tue, 26 Apr 2022 11:18:34 -0700 Message-Id: <20220426181907.103691-36-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000076350100001 Content-Type: text/plain; charset="utf-8" The register is entirely read-only for software, and we do not implement ECC, so we need not deposit the cause into an existing value; just create a new value from scratch. Furthermore, exception.CAUSE is not written for break exceptions. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-36-richard.henderson@linaro.org> --- target/nios2/helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 25a89724d0..3d9869453b 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -54,9 +54,10 @@ static void do_exception(Nios2CPU *cpu, uint32_t excepti= on_addr, bool is_break) new_status &=3D ~(CR_STATUS_PIE | CR_STATUS_U); =20 env->ctrl[CR_STATUS] =3D new_status; - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(env->ctrl[CR_EXCEPTION], - CR_EXCEPTION, CAUSE, - cs->exception_index); + if (!is_break) { + env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(0, CR_EXCEPTION, CAUSE, + cs->exception_index); + } env->pc =3D exception_addr; } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650998963; cv=none; d=zohomail.com; s=zohoarc; b=I+h3rO2WBIbqmmtwUvVMZ+TsFJNEK7UJfd7ANE7UtkMRDFO5AJfG9TCfgnTe+A2D/1A5BkBSgcofR/cz1brwkVf8l7jEmPdV1JGIgMk3Sr70bPszfhgk3omcl1fDMX9s9S1r7kXQ1ep9LQWKm1/ItMxPX9s9oowVbplCT8XTRUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650998963; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xHxvfyaHHNAh6ZFog8b1i7xhm5MEp5/7nB+TsCbtI6Y=; b=BaNQxy5nvYkPN4uLr+cFWWJxLD3bxCLL/TJUEF4h4G6AT7NxbkEqN+27OyO2aSo7kQ6NDt9Iqy+mn3rEUwYu7Z741vaDWL/MKnaNU3Ngo2NMQ4EuhrrPXQo9aJKlg8snNyxUSHljCx1PzmmQB7Ia73i0jOU6As2QajiyX0Z1QaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650998962985239.56961279616314; Tue, 26 Apr 2022 11:49:22 -0700 (PDT) Received: from localhost ([::1]:57056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQFV-00012M-I9 for importer@patchew.org; Tue, 26 Apr 2022 14:49:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmr-0002y5-4c for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:45 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:40498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmp-0004TE-6G for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:44 -0400 Received: by mail-pf1-x42b.google.com with SMTP id i24so18692983pfa.7 for ; Tue, 26 Apr 2022 11:19:42 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xHxvfyaHHNAh6ZFog8b1i7xhm5MEp5/7nB+TsCbtI6Y=; b=YMQPXUxdRw4EfDpQSrhcUW+/H1MzWN9YowZiBdGjl08LDhvt9n3TsEWl5+urPIX6AZ Du5H6ZxjrChmnLBjSVYEYeXH2C3am3wt7UxWVDlRABacrwI4PJjadUxzELc+OLtbl+8n xqUqpt0PciBszzdBQJXnLLrHLe+z/2oBvo6cgEF6OveB2Q7S4IeDxRX3d+w/iRk6/CNO yC7mX2GbNM++4HyzKpVoRyb/YI7zQ2aH/lWN7DUi5dAeHd/U8mOlVyAEl8OoOZi2BbSV 8Gj6Aee9mapbdQXEPfIU86rH8A6Aqr3ZaU4fbrefIcWGLaPwHe13Em91e0cMAlEgoNXs qSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xHxvfyaHHNAh6ZFog8b1i7xhm5MEp5/7nB+TsCbtI6Y=; b=gvSexDQnKC+Cnm/0HQIkTkAdUgVUcwbB4bfgyRn5YVAjWBPcS1dWKuhn/1qTjBylT4 oNTbw7I8JcLWhHS36vZrJMmKMolSVgX91WHSqIwZO3jWdxTTl1uHkTwaprehv+oeCNfH xfN0ZG/y1W5fDB8cZxl7D99qSiZAt1H+rzg2hotcQgzEAwSJv2bV8ZJ1/UXU3x1v11a+ H/7puFNTW4bb4/Vdmv3LsETYY1/RqlG+S72qSAHx8uTHsUCcRLELMtCJKJg/gF1ldqB9 tCVxiVArB1fNSXHH2aqvy2IntJjy7EHuQ/bECNnbU8HExbJomwalF+en82RaPz49sIjy DgwA== X-Gm-Message-State: AOAM530zGeCKHZeHt3p1JbWn4BOZ9M9qFdvwiq61VV0Ak3cpk2CYMgaf KAPUjA5/ek01sIT6mznDxEB5KLAo8HqauQ== X-Google-Smtp-Source: ABdhPJz1PTlaG89ZLfMSFGwXEtEox1hGg4LckXVmEPON1lunict3oZLhcWKfY18jkX/UQcyAl5KSAQ== X-Received: by 2002:a05:6a00:278d:b0:50d:5320:9ef4 with SMTP id bd13-20020a056a00278d00b0050d53209ef4mr5870965pfb.50.1650997181784; Tue, 26 Apr 2022 11:19:41 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 36/68] target/nios2: Clean up handling of tlbmisc in do_exception Date: Tue, 26 Apr 2022 11:18:35 -0700 Message-Id: <20220426181907.103691-37-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650998965106100001 Content-Type: text/plain; charset="utf-8" The 4 lower bits, D, PERM, BAD, DBL, are unconditionally set on any exception with EH=3D0, or so says Table 42 (Processor Status After Taking Exception). We currently do not set PERM or BAD at all, and only set/clear DBL for tlb miss, and do not clear DBL for any other exception. It is a bit confusing to set D in tlb_fill and the rest during do_interrupt, so move the setting of D to do_interrupt as well. To do this, split EXP_TLBD into two cases, EXCP_TLB_X and EXCP_TLB_D, which allows us to distinguish them during do_interrupt. Choose a value for EXCP_TLB_D such that when truncated it produces the correct value for exception.CAUSE. Rename EXCP_TLB[RWX] to EXCP_PERM_[RWX], to emphasize that the exception is permissions related. Rename EXCP_SUPER[AD] to EXCP_SUPERA_[DX] to emphasize that they are both "supervisor address" exceptions, data and execute. Retain the setting of tlbmisc.WE for the fast-tlb-miss path, as it is being relied upon, but remove it from the permission path. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-37-richard.henderson@linaro.org> --- target/nios2/cpu.h | 13 +++--- target/nios2/helper.c | 97 +++++++++++++++++++++++++++++-------------- 2 files changed, 73 insertions(+), 37 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 01cead5502..0027416742 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -166,13 +166,14 @@ FIELD(CR_TLBMISC, EE, 24, 1) #define EXCP_UNALIGN 6 #define EXCP_UNALIGND 7 #define EXCP_DIV 8 -#define EXCP_SUPERA 9 +#define EXCP_SUPERA_X 9 #define EXCP_SUPERI 10 -#define EXCP_SUPERD 11 -#define EXCP_TLBD 12 -#define EXCP_TLBX 13 -#define EXCP_TLBR 14 -#define EXCP_TLBW 15 +#define EXCP_SUPERA_D 11 +#define EXCP_TLB_X 12 +#define EXCP_TLB_D (0x1000 | EXCP_TLB_X) +#define EXCP_PERM_X 13 +#define EXCP_PERM_R 14 +#define EXCP_PERM_W 15 #define EXCP_MPUI 16 #define EXCP_MPUD 17 =20 diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 3d9869453b..4d9085f22f 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -29,7 +29,8 @@ #include "semihosting/semihost.h" =20 =20 -static void do_exception(Nios2CPU *cpu, uint32_t exception_addr, bool is_b= reak) +static void do_exception(Nios2CPU *cpu, uint32_t exception_addr, + uint32_t tlbmisc_set, bool is_break) { CPUNios2State *env =3D &cpu->env; CPUState *cs =3D CPU(cpu); @@ -48,6 +49,16 @@ static void do_exception(Nios2CPU *cpu, uint32_t excepti= on_addr, bool is_break) =20 if (cpu->mmu_present) { new_status |=3D CR_STATUS_EH; + + /* + * There are 4 bits that are always written. + * Explicitly clear them, to be set via the argument. + */ + env->ctrl[CR_TLBMISC] &=3D ~(CR_TLBMISC_D | + CR_TLBMISC_PERM | + CR_TLBMISC_BAD | + CR_TLBMISC_DBL); + env->ctrl[CR_TLBMISC] |=3D tlbmisc_set; } } =20 @@ -63,13 +74,14 @@ static void do_exception(Nios2CPU *cpu, uint32_t except= ion_addr, bool is_break) =20 static void do_iic_irq(Nios2CPU *cpu) { - do_exception(cpu, cpu->exception_addr, false); + do_exception(cpu, cpu->exception_addr, 0, false); } =20 void nios2_cpu_do_interrupt(CPUState *cs) { Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUNios2State *env =3D &cpu->env; + uint32_t tlbmisc_set =3D 0; =20 if (qemu_loglevel_mask(CPU_LOG_INT)) { const char *name =3D NULL; @@ -78,20 +90,21 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_IRQ: name =3D "interrupt"; break; - case EXCP_TLBD: + case EXCP_TLB_X: + case EXCP_TLB_D: if (env->ctrl[CR_STATUS] & CR_STATUS_EH) { name =3D "TLB MISS (double)"; } else { name =3D "TLB MISS (fast)"; } break; - case EXCP_TLBR: - case EXCP_TLBW: - case EXCP_TLBX: + case EXCP_PERM_R: + case EXCP_PERM_W: + case EXCP_PERM_X: name =3D "TLB PERM"; break; - case EXCP_SUPERA: - case EXCP_SUPERD: + case EXCP_SUPERA_X: + case EXCP_SUPERA_D: name =3D "SUPERVISOR (address)"; break; case EXCP_SUPERI: @@ -129,38 +142,57 @@ void nios2_cpu_do_interrupt(CPUState *cs) do_iic_irq(cpu); break; =20 - case EXCP_TLBD: - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_TLBMISC] &=3D ~CR_TLBMISC_DBL; - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; - do_exception(cpu, cpu->fast_tlb_miss_addr, false); + case EXCP_TLB_D: + tlbmisc_set =3D CR_TLBMISC_D; + /* fall through */ + case EXCP_TLB_X: + if (env->ctrl[CR_STATUS] & CR_STATUS_EH) { + tlbmisc_set |=3D CR_TLBMISC_DBL; + /* + * Normally, we don't write to tlbmisc unless !EH, + * so do it manually for the double-tlb miss exception. + */ + env->ctrl[CR_TLBMISC] &=3D ~(CR_TLBMISC_D | + CR_TLBMISC_PERM | + CR_TLBMISC_BAD); + env->ctrl[CR_TLBMISC] |=3D tlbmisc_set; + do_exception(cpu, cpu->exception_addr, 0, false); } else { - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_DBL; - do_exception(cpu, cpu->exception_addr, false); + tlbmisc_set |=3D CR_TLBMISC_WE; + do_exception(cpu, cpu->fast_tlb_miss_addr, tlbmisc_set, false); } break; =20 - case EXCP_TLBR: - case EXCP_TLBW: - case EXCP_TLBX: - if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) =3D=3D 0) { - env->ctrl[CR_TLBMISC] |=3D CR_TLBMISC_WE; + case EXCP_PERM_R: + case EXCP_PERM_W: + tlbmisc_set =3D CR_TLBMISC_D; + /* fall through */ + case EXCP_PERM_X: + tlbmisc_set |=3D CR_TLBMISC_PERM; + if (!(env->ctrl[CR_STATUS] & CR_STATUS_EH)) { + tlbmisc_set |=3D CR_TLBMISC_WE; } - do_exception(cpu, cpu->exception_addr, false); + do_exception(cpu, cpu->exception_addr, tlbmisc_set, false); + break; + + case EXCP_SUPERA_D: + case EXCP_UNALIGN: + tlbmisc_set =3D CR_TLBMISC_D; + /* fall through */ + case EXCP_SUPERA_X: + case EXCP_UNALIGND: + tlbmisc_set |=3D CR_TLBMISC_BAD; + do_exception(cpu, cpu->exception_addr, tlbmisc_set, false); break; =20 - case EXCP_SUPERA: case EXCP_SUPERI: - case EXCP_SUPERD: case EXCP_ILLEGAL: case EXCP_TRAP: - case EXCP_UNALIGN: - case EXCP_UNALIGND: - do_exception(cpu, cpu->exception_addr, false); + do_exception(cpu, cpu->exception_addr, 0, false); break; =20 case EXCP_BREAK: - do_exception(cpu, cpu->exception_addr, true); + do_exception(cpu, cpu->exception_addr, 0, true); break; =20 case EXCP_SEMIHOST: @@ -215,7 +247,7 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, { Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUNios2State *env =3D &cpu->env; - unsigned int excp =3D EXCP_TLBD; + unsigned int excp; target_ulong vaddr, paddr; Nios2MMULookup lu; unsigned int hit; @@ -242,7 +274,8 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, if (probe) { return false; } - cs->exception_index =3D EXCP_SUPERA; + cs->exception_index =3D (access_type =3D=3D MMU_INST_FETCH + ? EXCP_SUPERA_X : EXCP_SUPERA_D); env->ctrl[CR_BADADDR] =3D address; cpu_loop_exit_restore(cs, retaddr); } @@ -263,8 +296,10 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, i= nt size, } =20 /* Permission violation */ - excp =3D (access_type =3D=3D MMU_DATA_LOAD ? EXCP_TLBR : - access_type =3D=3D MMU_DATA_STORE ? EXCP_TLBW : EXCP_TLBX); + excp =3D (access_type =3D=3D MMU_DATA_LOAD ? EXCP_PERM_R : + access_type =3D=3D MMU_DATA_STORE ? EXCP_PERM_W : EXCP_PER= M_X); + } else { + excp =3D (access_type =3D=3D MMU_INST_FETCH ? EXCP_TLB_X: EXCP_TLB= _D); } =20 if (probe) { --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999659; cv=none; d=zohomail.com; s=zohoarc; b=aDuiapTtPsL3j4RNJEfc1Dhwwky80i40BsORRIStTnZC/SCOEuFKwsA846pBYm1PGE+074nBuLsMVgtKyYiRn+CiWL4EJZheXl/C5kbV6zzy9fczXaY4B34P1HVTr4+ZZZlAQLlvCOZcU5I+Vtj9KALCe0je8smbOx7hdilMbd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999659; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b91HmxjG0u6CLiTBN86Gl9ydinvbPQB9WXtZ8LXqaK4=; b=HzaxJl7Pz7tQAYlnKtiD+geV/IC+UO9n4yNqFI95ChE26lfn3NMzUVQcGwjN1b3WvGT6c3M7QTgK0KF+U5+Yab75DyBtnuRg3bijDY9EZ3Iw+fznkgWq0jWIHvymygcYSeGlFXrlVWIHbYc2okSjz6OCsGLvqOznSRXgkre0hkg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999659089844.4823388357061; Tue, 26 Apr 2022 12:00:59 -0700 (PDT) Received: from localhost ([::1]:56378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQQj-0003Fy-NT for importer@patchew.org; Tue, 26 Apr 2022 15:00:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPms-00033L-LX for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:46 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:46858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmq-0004TZ-FD for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:46 -0400 Received: by mail-pg1-x52f.google.com with SMTP id q12so16705168pgj.13 for ; Tue, 26 Apr 2022 11:19:44 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b91HmxjG0u6CLiTBN86Gl9ydinvbPQB9WXtZ8LXqaK4=; b=azMJpw5AH1F8OZ4O33jYLdnWrEMOWpPIFsunDNCRTBWgol1xe9Hogxb+Y2tyEL7NlI A/tZOMheXN9pKdyolIZbSTPLFY4IaB+LXbE6nKtSF2BGikuW5jh5UZFPrs0tODjsezco zTmDVpv60H5mbwYN/wu7QvY8YkCqn1dHExCFxGH7FzXcvd1kf9bNLGMuwxWSsI+iW5M3 /dU80tCIwuNJ9dMV0Tvr08PXNs+8p/rNM6zXuoF33xaiy6wmcvYwt3JviRjZXPgdJlZh ap3nwTbIMvftNPIfBGfe7XM+KjmCIN6jRo//zMqcbKCgH8htOxjHMPOCPOZKNf51kdT4 JQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b91HmxjG0u6CLiTBN86Gl9ydinvbPQB9WXtZ8LXqaK4=; b=nhv0uikPn1Y1YTOwcFxV6of/ol434I+h62lhzhv9mCnqIoS/Ww6e/uU4LAIVA8cRqm 669v6l5hpmOPPZOzj4JaNvBWN0jIs18fhjFGj3UziWWc6dD5UOXD4cCEiRwKMgeEMi6r Gws2SWSoI4xGlj3yo5e0UlsodIFhGkKe/hUIH5/Et8DwzqSjyfFR0iTHO//jCXOfv6vr YnPJP+8ucld+anC7hIX7DmVYxgzYsKlhZlf2EzjsZLZjCsBp7N3i6kiHqanmZEfITC3K sFDTZX67qRwlLu8Ds66OEhHxfLPYY2G9oXe+30S5lrjQ75yNLS8Czbw4o4ExOuWOLdgn m5Kw== X-Gm-Message-State: AOAM530tXCt+4YX9O94N1SEJQnxy3/ax/5lHe+LXDJMLOWV8qeYk/wWW 9RkXhvz5RZbHks1vNLTMnJHbquMFNIBISA== X-Google-Smtp-Source: ABdhPJzP6LdnM8Fl80ULNpJ30/7D4lnoG1WKfcdn2ynJU8rQ30eLN1r4Y1cC4Dnb4fVI9ApxuJJ+9Q== X-Received: by 2002:a65:6942:0:b0:378:9365:5963 with SMTP id w2-20020a656942000000b0037893655963mr20339288pgq.142.1650997183018; Tue, 26 Apr 2022 11:19:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 37/68] target/nios2: Prevent writes to read-only or reserved control fields Date: Tue, 26 Apr 2022 11:18:36 -0700 Message-Id: <20220426181907.103691-38-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999661129100001 Content-Type: text/plain; charset="utf-8" Create an array of masks which detail the writable and readonly bits for each control register. Apply them when writing to control registers, including the write to status during eret. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-38-richard.henderson@linaro.org> --- target/nios2/cpu.h | 13 +++++ target/nios2/cpu.c | 100 +++++++++++++++++++++++++++++++++------ target/nios2/op_helper.c | 9 ++++ target/nios2/translate.c | 80 ++++++++++++++++++++++++------- 4 files changed, 171 insertions(+), 31 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 0027416742..da85d82faa 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -190,6 +190,11 @@ struct CPUArchState { int error_code; }; =20 +typedef struct { + uint32_t writable; + uint32_t readonly; +} ControlRegState; + /** * Nios2CPU: * @env: #CPUNios2State @@ -213,9 +218,17 @@ struct ArchCPU { uint32_t reset_addr; uint32_t exception_addr; uint32_t fast_tlb_miss_addr; + + /* Bits within each control register which are reserved or readonly. */ + ControlRegState cr_state[NUM_CR_REGS]; }; =20 =20 +static inline bool nios2_cr_reserved(const ControlRegState *s) +{ + return (s->writable | s->readonly) =3D=3D 0; +} + void nios2_tcg_init(void); void nios2_cpu_do_interrupt(CPUState *cs); void dump_mmu(CPUNios2State *env); diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index fce16a2e77..b3c5ae681c 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -102,6 +102,64 @@ static ObjectClass *nios2_cpu_class_by_name(const char= *cpu_model) return object_class_by_name(TYPE_NIOS2_CPU); } =20 +static void realize_cr_status(CPUState *cs) +{ + Nios2CPU *cpu =3D NIOS2_CPU(cs); + + /* Begin with all fields of all registers are reserved. */ + memset(cpu->cr_state, 0, sizeof(cpu->cr_state)); + + /* + * The combination of writable and readonly is the set of all + * non-reserved fields. We apply writable as a mask to bits, + * and merge in existing readonly bits, before storing. + */ +#define WR_REG(C) cpu->cr_state[C].writable =3D -1 +#define RO_REG(C) cpu->cr_state[C].readonly =3D -1 +#define WR_FIELD(C, F) cpu->cr_state[C].writable |=3D R_##C##_##F##_MASK +#define RO_FIELD(C, F) cpu->cr_state[C].readonly |=3D R_##C##_##F##_MASK + + WR_FIELD(CR_STATUS, PIE); + WR_REG(CR_ESTATUS); + WR_REG(CR_BSTATUS); + RO_REG(CR_CPUID); + RO_REG(CR_EXCEPTION); + WR_REG(CR_BADADDR); + + /* TODO: These control registers are not present with the EIC. */ + WR_REG(CR_IENABLE); + RO_REG(CR_IPENDING); + + if (cpu->mmu_present) { + WR_FIELD(CR_STATUS, U); + WR_FIELD(CR_STATUS, EH); + + WR_FIELD(CR_PTEADDR, VPN); + WR_FIELD(CR_PTEADDR, PTBASE); + + RO_FIELD(CR_TLBMISC, D); + RO_FIELD(CR_TLBMISC, PERM); + RO_FIELD(CR_TLBMISC, BAD); + RO_FIELD(CR_TLBMISC, DBL); + WR_FIELD(CR_TLBMISC, PID); + WR_FIELD(CR_TLBMISC, WE); + WR_FIELD(CR_TLBMISC, RD); + WR_FIELD(CR_TLBMISC, WAY); + + WR_REG(CR_TLBACC); + } + + /* + * TODO: ECC (config, eccinj) and MPU (config, mpubase, mpuacc) are + * unimplemented, so their corresponding control regs remain reserved. + */ + +#undef WR_REG +#undef RO_REG +#undef WR_FIELD +#undef RO_FIELD +} + static void nios2_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); @@ -114,6 +172,7 @@ static void nios2_cpu_realizefn(DeviceState *dev, Error= **errp) return; } =20 + realize_cr_status(cs); qemu_init_vcpu(cs); cpu_reset(cs); =20 @@ -147,23 +206,26 @@ static void nios2_cpu_disas_set_info(CPUState *cpu, d= isassemble_info *info) static int nios2_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, = int n) { Nios2CPU *cpu =3D NIOS2_CPU(cs); - CPUClass *cc =3D CPU_GET_CLASS(cs); CPUNios2State *env =3D &cpu->env; + uint32_t val; =20 - if (n > cc->gdb_num_core_regs) { + if (n < 32) { /* GP regs */ + val =3D env->regs[n]; + } else if (n =3D=3D 32) { /* PC */ + val =3D env->pc; + } else if (n < 49) { /* Status regs */ + unsigned cr =3D n - 33; + if (nios2_cr_reserved(&cpu->cr_state[cr])) { + val =3D 0; + } else { + val =3D env->ctrl[n - 33]; + } + } else { + /* Invalid regs */ return 0; } =20 - if (n < 32) { /* GP regs */ - return gdb_get_reg32(mem_buf, env->regs[n]); - } else if (n =3D=3D 32) { /* PC */ - return gdb_get_reg32(mem_buf, env->pc); - } else if (n < 49) { /* Status regs */ - return gdb_get_reg32(mem_buf, env->ctrl[n - 33]); - } - - /* Invalid regs */ - return 0; + return gdb_get_reg32(mem_buf, val); } =20 static int nios2_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, in= t n) @@ -171,17 +233,25 @@ static int nios2_cpu_gdb_write_register(CPUState *cs,= uint8_t *mem_buf, int n) Nios2CPU *cpu =3D NIOS2_CPU(cs); CPUClass *cc =3D CPU_GET_CLASS(cs); CPUNios2State *env =3D &cpu->env; + uint32_t val; =20 if (n > cc->gdb_num_core_regs) { return 0; } + val =3D ldl_p(mem_buf); =20 if (n < 32) { /* GP regs */ - env->regs[n] =3D ldl_p(mem_buf); + env->regs[n] =3D val; } else if (n =3D=3D 32) { /* PC */ - env->pc =3D ldl_p(mem_buf); + env->pc =3D val; } else if (n < 49) { /* Status regs */ - env->ctrl[n - 33] =3D ldl_p(mem_buf); + unsigned cr =3D n - 33; + /* ??? Maybe allow the debugger to write to readonly fields. */ + val &=3D cpu->cr_state[cr].writable; + val |=3D cpu->cr_state[cr].readonly & env->ctrl[cr]; + env->ctrl[cr] =3D val; + } else { + g_assert_not_reached(); } =20 return 4; diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index 08ed3b4598..49fccf2c2c 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -34,6 +34,15 @@ void helper_raise_exception(CPUNios2State *env, uint32_t= index) #ifndef CONFIG_USER_ONLY void helper_eret(CPUNios2State *env, uint32_t new_status, uint32_t new_pc) { + Nios2CPU *cpu =3D env_archcpu(env); + + /* + * Both estatus and bstatus have no constraints on write; + * do not allow reserved fields in status to be set. + * TODO: more than this is required for shadow registers. + */ + new_status &=3D cpu->cr_state[CR_STATUS].writable; + env->ctrl[CR_STATUS] =3D new_status; env->pc =3D new_pc; cpu_loop_exit(env_cpu(env)); diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 97e531529f..b8d75207a4 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -102,6 +102,7 @@ typedef struct DisasContext { TCGv_i32 zero; target_ulong pc; int mem_idx; + const ControlRegState *cr_state; } DisasContext; =20 static TCGv cpu_R[NUM_GP_REGS]; @@ -471,17 +472,26 @@ static void callr(DisasContext *dc, uint32_t code, ui= nt32_t flags) /* rC <- ctlN */ static void rdctl(DisasContext *dc, uint32_t code, uint32_t flags) { - R_TYPE(instr, code); - TCGv t1, t2; - if (!gen_check_supervisor(dc)) { return; } =20 +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + R_TYPE(instr, code); + TCGv t1, t2; + if (unlikely(instr.c =3D=3D R_ZERO)) { return; } =20 + /* Reserved registers read as zero. */ + if (nios2_cr_reserved(&dc->cr_state[instr.imm5])) { + tcg_gen_movi_tl(cpu_R[instr.c], 0); + return; + } + switch (instr.imm5) { case CR_IPENDING: /* @@ -505,6 +515,7 @@ static void rdctl(DisasContext *dc, uint32_t code, uint= 32_t flags) offsetof(CPUNios2State, ctrl[instr.imm5])); break; } +#endif } =20 /* ctlN <- rA */ @@ -519,6 +530,14 @@ static void wrctl(DisasContext *dc, uint32_t code, uin= t32_t flags) #else R_TYPE(instr, code); TCGv v =3D load_gpr(dc, instr.a); + uint32_t ofs =3D offsetof(CPUNios2State, ctrl[instr.imm5]); + uint32_t wr =3D dc->cr_state[instr.imm5].writable; + uint32_t ro =3D dc->cr_state[instr.imm5].readonly; + + /* Skip reserved or readonly registers. */ + if (wr =3D=3D 0) { + return; + } =20 switch (instr.imm5) { case CR_PTEADDR: @@ -530,17 +549,35 @@ static void wrctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) case CR_TLBMISC: gen_helper_mmu_write_tlbmisc(cpu_env, v); break; - case CR_IPENDING: - /* ipending is read only, writes ignored. */ - break; case CR_STATUS: case CR_IENABLE: /* If interrupts were enabled using WRCTL, trigger them. */ dc->base.is_jmp =3D DISAS_UPDATE; /* fall through */ default: - tcg_gen_st_tl(v, cpu_env, - offsetof(CPUNios2State, ctrl[instr.imm5])); + if (wr =3D=3D -1) { + /* The register is entirely writable. */ + tcg_gen_st_tl(v, cpu_env, ofs); + } else { + /* + * The register is partially read-only or reserved: + * merge the value. + */ + TCGv n =3D tcg_temp_new(); + + tcg_gen_andi_tl(n, v, wr); + + if (ro !=3D 0) { + TCGv o =3D tcg_temp_new(); + tcg_gen_ld_tl(o, cpu_env, ofs); + tcg_gen_andi_tl(o, o, ro); + tcg_gen_or_tl(n, n, o); + tcg_temp_free(o); + } + + tcg_gen_st_tl(n, cpu_env, ofs); + tcg_temp_free(n); + } break; } #endif @@ -818,9 +855,11 @@ static void nios2_tr_init_disas_context(DisasContextBa= se *dcbase, CPUState *cs) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); CPUNios2State *env =3D cs->env_ptr; + Nios2CPU *cpu =3D env_archcpu(env); int page_insns; =20 dc->mem_idx =3D cpu_mmu_index(env, false); + dc->cr_state =3D cpu->cr_state; =20 /* Bound the number of insns to execute to those left on the page. */ page_insns =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; @@ -932,16 +971,25 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int = flags) } =20 #if !defined(CONFIG_USER_ONLY) - for (i =3D 0; i < NUM_CR_REGS; i++) { - qemu_fprintf(f, "%9s=3D%8.8x ", cr_regnames[i], env->ctrl[i]); - if ((i + 1) % 4 =3D=3D 0) { - qemu_fprintf(f, "\n"); + int j; + + for (i =3D j =3D 0; i < NUM_CR_REGS; i++) { + if (!nios2_cr_reserved(&cpu->cr_state[i])) { + qemu_fprintf(f, "%9s=3D%8.8x ", cr_regnames[i], env->ctrl[i]); + if (++j % 4 =3D=3D 0) { + qemu_fprintf(f, "\n"); + } } } - qemu_fprintf(f, " mmu write: VPN=3D%05X PID %02X TLBACC %08X\n", - env->mmu.pteaddr_wr & R_CR_PTEADDR_VPN_MASK, - FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID), - env->mmu.tlbacc_wr); + if (j % 4 !=3D 0) { + qemu_fprintf(f, "\n"); + } + if (cpu->mmu_present) { + qemu_fprintf(f, " mmu write: VPN=3D%05X PID %02X TLBACC %08X\n", + env->mmu.pteaddr_wr & R_CR_PTEADDR_VPN_MASK, + FIELD_EX32(env->mmu.tlbmisc_wr, CR_TLBMISC, PID), + env->mmu.tlbacc_wr); + } #endif qemu_fprintf(f, "\n\n"); } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999440; cv=none; d=zohomail.com; s=zohoarc; b=mp342gMvtz0P8oT7Lod9CJuK4w//RHpM77pFO3tcSjZjv27UcV9wenHLj7v1uqTPvgQAqgjcO8VWrAotuZWkciRnIklmUYQEXVM9nveIOPKYHAXEnEILC6HTAAAyOrR4LWbmsTbGG5SR+YZtaqUaZZ3FU2ZLnNDMe4DwWGOrTK8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999440; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6dVu0MpYoFXbOmuVcXqDRhoCvO23S5v7zkXark59YIw=; b=J0bBIayOQKY2R06OD35P3WINmtd78XILSOgBZVr/38qaRJr/7qL1GfIGuKnasSfKWecnadqdZN/1EUbgWOoOQzJDeWNu/sjDjQH1D18laZckaX9xZ7ED2QBPFmfQOICXnXZ5s+zaPb+cA4MbziMW1lI3GNe3AIEALBW50gMVB1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999440353237.24115493953013; Tue, 26 Apr 2022 11:57:20 -0700 (PDT) Received: from localhost ([::1]:47896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQND-0005yX-BL for importer@patchew.org; Tue, 26 Apr 2022 14:57:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPms-00033I-JU for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:46 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:44822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmr-0004Tf-4c for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:46 -0400 Received: by mail-pg1-x532.google.com with SMTP id v10so5640995pgl.11 for ; Tue, 26 Apr 2022 11:19:44 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6dVu0MpYoFXbOmuVcXqDRhoCvO23S5v7zkXark59YIw=; b=zl6l809aLyU0x6SE05p9h/omgMzN1xnp4c86qm7k90GTTSyH5/xZnsIZmwc2M7Gy1s JIbfHY+QbHrgVFbUPs8wKORyOIlvlFk3DwC85vqXvd798XTQ41mgtBtC3VgI2rSvhYCM pOiZUNOka2dwbDGks4fYXHf47qTXNUy0LRZte468INJBGz58+Su011Q7LJGttcyRa7Y4 PxLFs58gKVWEHcC2XPW4ocGUX9y6fMmLxOVqWw7WfOc6EShu+qvcazSmVt7M43MFqpL+ E3GtCNuNhzZhXBu6RJVuPB+ENWU1nKCA+CvWsH/aMWx1ndufht4djlkQUk/043Bexrv8 wKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6dVu0MpYoFXbOmuVcXqDRhoCvO23S5v7zkXark59YIw=; b=kj8SOPLMRCy/xOmnJp1IGNNMKVbupSB3kJ0F+TZfcrQWx7GEGcSzuVktqS3UL4R6gf iAcPa2dyYFB3WYZx+hYmPl3YnBFpJDJqTsYU3kX3AOzBrtU3rYPg3bImZf9AsReeEwaq gr73LMrmjjU09k1uD4Eu/PdxkHGmgnCCOK3HYAzhIbU2SD0D75bWoOhFjkAfDXKBoDbI 1EcZf4GGVjlVyIGODgOvqiXWIbZM3xTbs9FLVxro162RQ7c/Sff37/Pm4x6a20jN1tzR l9nEQwGY3bXfqSVqb909YUhKPKLs97LImo5axWQeVgmrkShQxEXEcfldlcQ4A4J+ZE6T r7MA== X-Gm-Message-State: AOAM530ZBY2+ZZms2C1GqVkpjTyNvBudmSjhDNtlEv9d+zi+TVZArI6I WIZ2RX2crS0X2qXfWpjiVGKFQ1eWfiiFyA== X-Google-Smtp-Source: ABdhPJwb7XDlA0W6ScDRt9XIna112CsZyUeK1SJwLcoPNtqitaD53F/axofdDOzWSNMCz5B4oooY7A== X-Received: by 2002:a65:6b8e:0:b0:39d:6760:1cd5 with SMTP id d14-20020a656b8e000000b0039d67601cd5mr20712079pgw.379.1650997183867; Tue, 26 Apr 2022 11:19:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 38/68] target/nios2: Implement cpuid Date: Tue, 26 Apr 2022 11:18:37 -0700 Message-Id: <20220426181907.103691-39-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999441182100001 Content-Type: text/plain; charset="utf-8" Copy the existing cpu_index into the space reserved for CR_CPUID. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-39-richard.henderson@linaro.org> --- target/nios2/cpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index b3c5ae681c..a0c3e97d72 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -163,6 +163,7 @@ static void realize_cr_status(CPUState *cs) static void nios2_cpu_realizefn(DeviceState *dev, Error **errp) { CPUState *cs =3D CPU(dev); + Nios2CPU *cpu =3D NIOS2_CPU(cs); Nios2CPUClass *ncc =3D NIOS2_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 @@ -176,6 +177,9 @@ static void nios2_cpu_realizefn(DeviceState *dev, Error= **errp) qemu_init_vcpu(cs); cpu_reset(cs); =20 + /* We have reserved storage for cpuid; might as well use it. */ + cpu->env.ctrl[CR_CPUID] =3D cs->cpu_index; + ncc->parent_realize(dev, errp); } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000164; cv=none; d=zohomail.com; s=zohoarc; b=TXNus4j8rjdBI0A9SIODJQnD9Y26iUnxI/Bs/zePchxAfizDpnCeOk0f1fG/cH6vGeeo5FpUtnVu9n8GX2R0APH3cOTA8AtDwb4bqfFueZbCHYBeSdyLSSudakOY734YD5+DNsMTZ+h/oNW+pbYVkV1pmnroXGAqkyD8r0j+Cs0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000164; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xZiQ5sI/cjyhT5QWt0cEWlmc3OyTlqSds1eKWRRIBd0=; b=ZMbPFqdR8nKdnP69HFeRiaQNa+51FBWf2FU979TqR74JPc3dqRuYob6Pad3vmyYVAraMerVVedsvIKEvn93EHcyFUijR633jIZl0+PRUOLzqxm1z/suwy21RJc37ZN1uQHTTWACARi0Nc4LPy0Tv7rBBbok1KGuzEsBw6PSGCvw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000164216643.1411263104936; Tue, 26 Apr 2022 12:09:24 -0700 (PDT) Received: from localhost ([::1]:48922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQYt-0000oR-8b for importer@patchew.org; Tue, 26 Apr 2022 15:09:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPmt-00036x-J2 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:47 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:42544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPmr-0004Tr-WB for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:19:47 -0400 Received: by mail-pg1-x52c.google.com with SMTP id bg9so16714677pgb.9 for ; Tue, 26 Apr 2022 11:19:45 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id j7-20020a056a00130700b004b9f7cd94a4sm16482827pfu.56.2022.04.26.11.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xZiQ5sI/cjyhT5QWt0cEWlmc3OyTlqSds1eKWRRIBd0=; b=oWKXsm6Fvpz4owPvl7ah9WpanGyQFjkx7XSPNHrXpZ6V6nckqLMmciJ6MAcY84tSmE bBwXqKYUKX/QAXpXC4+/8lLUxEYT1aufk5qoTMvUAvg+rjFMjfZk4CWzHBy+M4EuABkd OjCmDkyF5+hGj0aXTwAXcn6sLK9dBonvr0M3efoLo5KSZeaxSIRXXxvGFSr4OZF0Gkjv jpTmI6btkvgaS8MVvtfSxwYExOXV9hiZJTEvnaaGhIybZj+dZ6szRlfYkPZKTPYowjMg XFXzqy35vn/epgehLCvb7QwwIdUNg0xtNjULGetwwsdqmqePKvMRHsmIciK5qTspOuG3 rh6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xZiQ5sI/cjyhT5QWt0cEWlmc3OyTlqSds1eKWRRIBd0=; b=WITKrBaUGsDGOQ3b8RyopGYUX3WE9h1OTxfKUEjso/othg8b9e9SXmKTu27iFThobk AySjPVCNVz8ykk93d/8D00F+n8vDIZ2ORyNc8UyJAFua9m2hehuBxupYp2nKod3tonvF KS/BnObxN1V0crReAu3eOr+CB1rh/bU74qcwlKBsCY7QBWGgdc5ihLfZ2mRScfV3e9aM NO1p2iDYyWFsTWoXBtPk54mxYJxHdEZV8dOX6NnAfERayX4jXN0l2oTXtzpFdRHMXA1K YxduHrnEZl5sLkLHSPt7IEbGhfJYVzgkiSXHukkkuu/UBu6CkA13NxvWA2y0ZHq4xtH4 Tg+Q== X-Gm-Message-State: AOAM5310XF4HUMTDTFHMaqfLtaafiLzSAV2XUNDzM3FQrTQ91eWiyda7 qkP+laGFMRh2JcJVRDov8TTHYeUmkRORfw== X-Google-Smtp-Source: ABdhPJyUrKh+Aho88Ye8Whu0c6P+acAPu16v8OH9n2mPjXIEoH6SGun7yLve2OxjqcKt65xdnfm5Rw== X-Received: by 2002:a05:6a00:1d24:b0:50c:ec18:5085 with SMTP id a36-20020a056a001d2400b0050cec185085mr24219178pfx.60.1650997184740; Tue, 26 Apr 2022 11:19:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 39/68] target/nios2: Implement CR_STATUS.RSIE Date: Tue, 26 Apr 2022 11:18:38 -0700 Message-Id: <20220426181907.103691-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000165037100001 Content-Type: text/plain; charset="utf-8" Without EIC, this bit is RES1. So set the bit at reset, and add it to the readonly fields of CR_STATUS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-40-richard.henderson@linaro.org> --- target/nios2/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index a0c3e97d72..7d734280d1 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -54,9 +54,9 @@ static void nios2_cpu_reset(DeviceState *dev) =20 #if defined(CONFIG_USER_ONLY) /* Start in user mode with interrupts enabled. */ - env->ctrl[CR_STATUS] =3D CR_STATUS_U | CR_STATUS_PIE; + env->ctrl[CR_STATUS] =3D CR_STATUS_RSIE | CR_STATUS_U | CR_STATUS_PIE; #else - env->ctrl[CR_STATUS] =3D 0; + env->ctrl[CR_STATUS] =3D CR_STATUS_RSIE; #endif } =20 @@ -127,6 +127,7 @@ static void realize_cr_status(CPUState *cs) WR_REG(CR_BADADDR); =20 /* TODO: These control registers are not present with the EIC. */ + RO_FIELD(CR_STATUS, RSIE); WR_REG(CR_IENABLE); RO_REG(CR_IPENDING); =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000303; cv=none; d=zohomail.com; s=zohoarc; b=Y/GR8ezLzOu+7Y1zYiYKSpw1FMjdVV6PKkwbc//jBu/XKY5+BPBN4MqRZfFA2Kjxhc567kRE1qmpiBgnj9cCgB2UXjxxFuSBjjYVhS0/oPsUUvI3ABoeHfUdr6PYWvGMEu50OXqzJhKNeoFbz9/6Nnxp8TisWujwPMYuHa7MhXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000303; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uxB1TVMzBFwMcUq22tF+jwRMYyOH+mG1cEPhaGtvWVM=; b=D2fcK/T1mk+lhhUXVCQuCH1YzVRtKms9iB0RaY8AHE0zFOiDie5WvBO7x7KKnX9nTM7pxsGQ8NBeYPdsz5sGgrYRumyKUvqgUKaCW3baWhFI1dKkVV2yL9uiRB1/mwP7Zh7E0va2Yn918Cht7lNlacAmkqMsk9kNO56YfsyWX7Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16510003038311021.606578671543; Tue, 26 Apr 2022 12:11:43 -0700 (PDT) Received: from localhost ([::1]:53722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQb8-0004CJ-5D for importer@patchew.org; Tue, 26 Apr 2022 15:11:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpo-0001nM-TZ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:49 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:51907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpn-0005Kz-ER for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:48 -0400 Received: by mail-pj1-x102e.google.com with SMTP id p6so3878334pjm.1 for ; Tue, 26 Apr 2022 11:22:47 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uxB1TVMzBFwMcUq22tF+jwRMYyOH+mG1cEPhaGtvWVM=; b=wryWSAE4bXPxBUs54AexZGJw+ycSbv+CSCyjOZdU3apDxUcs2jYf/ye+2y3HcQyx3a 2Alp5j3g2U+MqUKHLHPlquJmhGqDAzP8WDV48U9mgDSEuwX1cz7pA7H/6690//EnjoiF xM09+CZy5Ksw/enIH6i5hpz6MNLr1joCW8wNbwFMevW9yf8XS1502yuYq1VemeAVKj7l GAMleiMK8np+OFSnz425he13VCdgtA0Ynq59gJtvM8XM0qZYcWmHoO0mZFtnjotT+KDf OGLTkEeRjkjX1UrLE6noXW65GP2IaxI7eSa1SHRv6eNN+4w3WhhRchbYQA/kTgRrLadX 1aoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uxB1TVMzBFwMcUq22tF+jwRMYyOH+mG1cEPhaGtvWVM=; b=LCepr8TZkk88hXBIkuymCM/1ocQ+rhqmOUnlzdE6YZFaCe6gSgskIo/EDC6fwJjtML brQOhhOGTUs7yInHLSouLR62DkN+3ltZsRSFNaAqlj2eSxZMK5bYx0LT0sx1bFhD9ObE RTiNDd1ygmt5VgdFJOBp3YWE0Wp+XSTYzSkYONK3cxMfsY25bpJ5lnwRp6ro/20Kq2py QS0Xvn6Vd8tp/EmipUWTt15UlV09mfPnMjJpBdON2ycvTI0IMXwIUtte/+bkTHYKCz4r D69/aS85wSuvGu77wKd2gnXiCYa5eBR26cAtNbYAzZWYulEoE/ALPQTzr6mdfPlSMYD+ iQWg== X-Gm-Message-State: AOAM532DAU+Yrx+4via4cUv3cIsyUfCNlBVuysZQLtPgHxhPs/VsE0l2 OlgA8E3MmNa4uOVSHr3xHrAtHyZWE1G/8g== X-Google-Smtp-Source: ABdhPJyyZwxamer0RwkYNwudfki7ErZtNWPlWF7VoyZBnxJdKKxr+DlchI4ZIu55d0KUQIl5HYkcBw== X-Received: by 2002:a17:902:7fc9:b0:15b:d408:5b19 with SMTP id t9-20020a1709027fc900b0015bd4085b19mr23883919plb.12.1650997366024; Tue, 26 Apr 2022 11:22:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 40/68] target/nios2: Remove CPU_INTERRUPT_NMI Date: Tue, 26 Apr 2022 11:18:39 -0700 Message-Id: <20220426181907.103691-41-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000305558100003 Content-Type: text/plain; charset="utf-8" This interrupt bit is never set, so testing it in nios2_cpu_has_work is pointless. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-41-richard.henderson@linaro.org> --- target/nios2/cpu.h | 2 -- target/nios2/cpu.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index da85d82faa..08284d7927 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -177,8 +177,6 @@ FIELD(CR_TLBMISC, EE, 24, 1) #define EXCP_MPUI 16 #define EXCP_MPUD 17 =20 -#define CPU_INTERRUPT_NMI CPU_INTERRUPT_TGT_EXT_3 - struct CPUArchState { uint32_t regs[NUM_GP_REGS]; uint32_t ctrl[NUM_CR_REGS]; diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 7d734280d1..58e6ad0462 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -36,7 +36,7 @@ static void nios2_cpu_set_pc(CPUState *cs, vaddr value) =20 static bool nios2_cpu_has_work(CPUState *cs) { - return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI= ); + return cs->interrupt_request & CPU_INTERRUPT_HARD; } =20 static void nios2_cpu_reset(DeviceState *dev) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000503; cv=none; d=zohomail.com; s=zohoarc; b=l9g8gyOnCRLlR1xtpjzl9uhs3bi4bMTNTPrx/3YYiaILntOaB6d/E0cCfz+v7t9Cv/eSiJ5ivHWBBBztL9iDlPd1Pb2cS2RvxXXyFl2kQYIFyW8M1CWZnvnAsWlwsL1zEA3SFckGE1TkLvZ5UK6UEJUia9B2CoLlqkYZRyTQFqQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000503; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6QGUpYO4ZAdRmNsQF40A07J1Y/QTqFdfV+kNvg7ol84=; b=gcqXJ72VxpTCR7rrT1mOj6ksxhmQ00tEhweWj+QNR0uJ1P0BHNyGMe/kxBpgwQBPyVDW+yb+q2UvSFDpKlXod7qv5xpV2K+KiB9SZ/aDtI1eM03VmbSpI7mW9geXtUJJtk9rRRku+X77CONv82ks3Ev9lZXOKPMk7tvJOoUiiSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000503306844.6412177813141; Tue, 26 Apr 2022 12:15:03 -0700 (PDT) Received: from localhost ([::1]:34150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQeM-0001gy-7g for importer@patchew.org; Tue, 26 Apr 2022 15:15:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpq-0001ns-JX for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:36364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpo-0005LT-CJ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:50 -0400 Received: by mail-pj1-x102a.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso2876923pjb.1 for ; Tue, 26 Apr 2022 11:22:47 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6QGUpYO4ZAdRmNsQF40A07J1Y/QTqFdfV+kNvg7ol84=; b=KJM5JZJrQGZPyfA9LRZasdwu+QSeMQSTdeV53zeawwl084SlZNcFnXkqDN2XRQHH4O AuZpzYNGTaBbb9yZHk/nnJRe+ng0OcWu9LTZyPEI/oZEDYheE2ZfSgl9c5dDzpDRU9yM 3cOJUr200uFKDmm7uXstwUQDXcnL3DEfD7YFrp/C7G201aQY3H+l3RZTniJdZ7BwFHQT g0z2s26HA3TX+GMS54r+a6zPBZ6JZu73QEjAWWu0QKUp9FpEMsvc8ilQZozWWLhCi9Fy tFNl8l+CJBo/qfC6/ipt9GX8v55lWq1k6h6Qn4nCJwyO4M1Wpdi0ZLLPG2qVKUPm07L7 lyxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6QGUpYO4ZAdRmNsQF40A07J1Y/QTqFdfV+kNvg7ol84=; b=uZNINvbdG6TUAhOS3NZenfc+G6+ZAjwtpnJlV4Jqn+LI7CJ3HIHaPDaTSmv0r2UjXK L3tgFmzH39eotj+lE+DpdfJXyOrbgEeiDkU/RNXD+aqcrThY0BgmdLTfy9QcrCj/wT4b bQabz1vyZAYGA1gz0OPT3+HImSaUgI0ii/qd7ICwyZQOdoiGoe578nzNPtk+svhYKFe7 cHtWc9Wf0jbImnCiCid9BsyuJHJBwomLmUEeYO8Zl7YGEtZs+P76GpOmdis+CbkaFpB2 YT00V+xZt7Fk42Ri2IZ4ZVTTmqflxg9pxoT8kI7HnxWfYq+5UkiUbtCQejhQIfoFb6xP asdg== X-Gm-Message-State: AOAM531+O93jf4Ar1u9Hpn8UnjY0WueSB+S3JF7oAdKuu9h0jVbH/ci1 WxtXwASq3boE8soKlri6IbUNELgdtXWEIw== X-Google-Smtp-Source: ABdhPJzI5yMrToMG/QjnSZ8PW2eIDnJ2+Mil9df0zwRUTP1CgKuFhLqq/W2S0yB6q/DBnNQGucATrQ== X-Received: by 2002:a17:902:a583:b0:15d:197b:9259 with SMTP id az3-20020a170902a58300b0015d197b9259mr10919111plb.51.1650997366923; Tue, 26 Apr 2022 11:22:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 41/68] target/nios2: Support division error exception Date: Tue, 26 Apr 2022 11:18:40 -0700 Message-Id: <20220426181907.103691-42-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000505125100003 Content-Type: text/plain; charset="utf-8" Division may (optionally) raise a division exception. Since the linux kernel has been prepared for this for some time, enable it by default. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-42-richard.henderson@linaro.org> --- target/nios2/cpu.h | 2 ++ target/nios2/helper.h | 2 ++ linux-user/nios2/cpu_loop.c | 4 +++ target/nios2/cpu.c | 1 + target/nios2/helper.c | 4 +++ target/nios2/op_helper.c | 29 ++++++++++++++++++ target/nios2/translate.c | 60 +++++++++++++------------------------ 7 files changed, 62 insertions(+), 40 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 08284d7927..4d63006ffe 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -207,7 +207,9 @@ struct ArchCPU { CPUNegativeOffsetState neg; CPUNios2State env; =20 + bool diverr_present; bool mmu_present; + uint32_t pid_num_bits; uint32_t tlb_num_ways; uint32_t tlb_num_entries; diff --git a/target/nios2/helper.h b/target/nios2/helper.h index 525b6b685b..6f5ec60b0d 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -19,6 +19,8 @@ */ =20 DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) +DEF_HELPER_FLAGS_3(divs, TCG_CALL_NO_WG, s32, env, s32, s32) +DEF_HELPER_FLAGS_3(divu, TCG_CALL_NO_WG, i32, env, i32, i32) =20 #if !defined(CONFIG_USER_ONLY) DEF_HELPER_3(eret, noreturn, env, i32, i32) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index c5e68ac048..11ecb71843 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -38,6 +38,10 @@ void cpu_loop(CPUNios2State *env) /* just indicate that signals should be handled asap */ break; =20 + case EXCP_DIV: + force_sig_fault(TARGET_SIGFPE, TARGET_FPE_INTDIV, env->pc); + break; + case EXCP_TRAP: /* * TODO: This advance should be done in the translator, as diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 58e6ad0462..54e7071907 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -263,6 +263,7 @@ static int nios2_cpu_gdb_write_register(CPUState *cs, u= int8_t *mem_buf, int n) } =20 static Property nios2_properties[] =3D { + DEFINE_PROP_BOOL("diverr_present", Nios2CPU, diverr_present, true), DEFINE_PROP_BOOL("mmu_present", Nios2CPU, mmu_present, true), /* ALTR,pid-num-bits */ DEFINE_PROP_UINT32("mmu_pid_num_bits", Nios2CPU, pid_num_bits, 8), diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 4d9085f22f..c5a2dd65b1 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -119,6 +119,9 @@ void nios2_cpu_do_interrupt(CPUState *cs) case EXCP_UNALIGND: name =3D "Misaligned (destination)"; break; + case EXCP_DIV: + name =3D "DIV error"; + break; case EXCP_TRAP: name =3D "TRAP insn"; break; @@ -187,6 +190,7 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 case EXCP_SUPERI: case EXCP_ILLEGAL: + case EXCP_DIV: case EXCP_TRAP: do_exception(cpu, cpu->exception_addr, 0, false); break; diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index 49fccf2c2c..a19b504b0e 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -31,6 +31,35 @@ void helper_raise_exception(CPUNios2State *env, uint32_t= index) cpu_loop_exit(cs); } =20 +static void maybe_raise_div(CPUNios2State *env, uintptr_t ra) +{ + Nios2CPU *cpu =3D env_archcpu(env); + CPUState *cs =3D env_cpu(env); + + if (cpu->diverr_present) { + cs->exception_index =3D EXCP_DIV; + cpu_loop_exit_restore(cs, ra); + } +} + +int32_t helper_divs(CPUNios2State *env, int32_t num, int32_t den) +{ + if (unlikely(den =3D=3D 0) || unlikely(den =3D=3D -1 && num =3D=3D INT= 32_MIN)) { + maybe_raise_div(env, GETPC()); + return num; /* undefined */ + } + return num / den; +} + +uint32_t helper_divu(CPUNios2State *env, uint32_t num, uint32_t den) +{ + if (unlikely(den =3D=3D 0)) { + maybe_raise_div(env, GETPC()); + return num; /* undefined */ + } + return num / den; +} + #ifndef CONFIG_USER_ONLY void helper_eret(CPUNios2State *env, uint32_t new_status, uint32_t new_pc) { diff --git a/target/nios2/translate.c b/target/nios2/translate.c index b8d75207a4..b27269bf08 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -654,59 +654,39 @@ gen_r_shift_s(ror, rotr_tl) static void divs(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, (code)); + TCGv dest; =20 - /* Stores into R_ZERO are ignored */ - if (unlikely(instr.c =3D=3D R_ZERO)) { - return; + if (instr.c =3D=3D R_ZERO) { + dest =3D tcg_temp_new(); + } else { + dest =3D cpu_R[instr.c]; } =20 - TCGv t0 =3D tcg_temp_new(); - TCGv t1 =3D tcg_temp_new(); - TCGv t2 =3D tcg_temp_new(); - TCGv t3 =3D tcg_temp_new(); + gen_helper_divs(dest, cpu_env, + load_gpr(dc, instr.a), load_gpr(dc, instr.b)); =20 - tcg_gen_ext32s_tl(t0, load_gpr(dc, instr.a)); - tcg_gen_ext32s_tl(t1, load_gpr(dc, instr.b)); - tcg_gen_setcondi_tl(TCG_COND_EQ, t2, t0, INT_MIN); - tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, -1); - tcg_gen_and_tl(t2, t2, t3); - tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, 0); - tcg_gen_or_tl(t2, t2, t3); - tcg_gen_movi_tl(t3, 0); - tcg_gen_movcond_tl(TCG_COND_NE, t1, t2, t3, t2, t1); - tcg_gen_div_tl(cpu_R[instr.c], t0, t1); - tcg_gen_ext32s_tl(cpu_R[instr.c], cpu_R[instr.c]); - - tcg_temp_free(t3); - tcg_temp_free(t2); - tcg_temp_free(t1); - tcg_temp_free(t0); + if (instr.c =3D=3D R_ZERO) { + tcg_temp_free(dest); + } } =20 static void divu(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, (code)); + TCGv dest; =20 - /* Stores into R_ZERO are ignored */ - if (unlikely(instr.c =3D=3D R_ZERO)) { - return; + if (instr.c =3D=3D R_ZERO) { + dest =3D tcg_temp_new(); + } else { + dest =3D cpu_R[instr.c]; } =20 - TCGv t0 =3D tcg_temp_new(); - TCGv t1 =3D tcg_temp_new(); - TCGv t2 =3D tcg_const_tl(0); - TCGv t3 =3D tcg_const_tl(1); + gen_helper_divu(dest, cpu_env, + load_gpr(dc, instr.a), load_gpr(dc, instr.b)); =20 - tcg_gen_ext32u_tl(t0, load_gpr(dc, instr.a)); - tcg_gen_ext32u_tl(t1, load_gpr(dc, instr.b)); - tcg_gen_movcond_tl(TCG_COND_EQ, t1, t1, t2, t3, t1); - tcg_gen_divu_tl(cpu_R[instr.c], t0, t1); - tcg_gen_ext32s_tl(cpu_R[instr.c], cpu_R[instr.c]); - - tcg_temp_free(t3); - tcg_temp_free(t2); - tcg_temp_free(t1); - tcg_temp_free(t0); + if (instr.c =3D=3D R_ZERO) { + tcg_temp_free(dest); + } } =20 static void trap(DisasContext *dc, uint32_t code, uint32_t flags) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000101; cv=none; d=zohomail.com; s=zohoarc; b=XOpnYLBEmCj9DWE+t0DVEooIERO2Zm3zMOPLwodBK7vS1nuJpy3s+F3XYmRL8Gi3r9SCbuAPnOg0mAIZt7vIcNZGNfF2CWtNYoX06B6SKmZpVfmwaT6+wmrjhwcRrfo8mjYb7B8KFHiMlb7/8OokZfktFKTMJuhbXyvw06MS/Ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000101; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jeDOlvgCVk+y2B//qRod3Wvk+Oo9Yi7Y8REDz4Pr8oM=; b=A6WIcjW+gxNOMTrmd/NFErooYN0ek95JFHd51m11wXDZCEB6kf7cnxAX9JhA9R9tAFz0ymabjXUATS3X38UesPTpDzk5yJGHZsiHHD8WbFNjZ3oN4iwPdDvdQQoRoQS2nREsHRWwHjBgdgMzH8ZqLv0SrUWZFF7rPssGoXZYmJw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000101538946.4363522619076; Tue, 26 Apr 2022 12:08:21 -0700 (PDT) Received: from localhost ([::1]:45738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQXs-00073c-JL for importer@patchew.org; Tue, 26 Apr 2022 15:08:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpq-0001nt-TT for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:40840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpp-0005Lx-7N for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:50 -0400 Received: by mail-pj1-x1032.google.com with SMTP id iq2-20020a17090afb4200b001d93cf33ae9so2848312pjb.5 for ; Tue, 26 Apr 2022 11:22:48 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jeDOlvgCVk+y2B//qRod3Wvk+Oo9Yi7Y8REDz4Pr8oM=; b=dmni/nSE9YRVpvUqP9arGePVhTwsLLzzlEAaN2JjhwMu3XLxHBW5muMDLH7i/feUsZ iPpyj4rnQbjvTg8iCHrF3qLysStJLMal5zQxZWnoySaBtAvH8TxrWBjkneagL6LJ4FYO P98xdozoGzr1tBoddbkOw/S6igSqgGwkqn5ZgLsFc6qQ1LlHA07HdipcOrgTKtMlGXv7 2qFeVCpbrnxCNmgA/5MzC6sEuVQWC3+PbAKlez4iewcFEnGSgYuoePfxERDRoqP3iIaS ME7fb69k0Z9DOyNA0+dTVhXxywR+W7x1KDteU/m9L2wsBRRqZZFH3ntwnkm0C8uhku1S lcjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jeDOlvgCVk+y2B//qRod3Wvk+Oo9Yi7Y8REDz4Pr8oM=; b=RxYjLZr515Bdz0R/9awhVS5Evspk13bkMP3HyuWAggnrF7+k/HLx3N5TqnaQFn474z nauBFzzP8JhvCTR4Up/b/f3PXxnUJlsfh88Q5PqF19r/bIEH1HrTmr9sjpMxcopV7Dzd mrNLeaQXHW6TxHp8J8ZraKquTHMQRKo1+pnVKbiNqaNUg/jmmKuDFZ6v0rSjsdeySh1c 1DCA8IWrpizdCIOywI6ZTNKAjrkWRjelrn7TH1qwNnL+UT/PamuxOf7ozbtsLPz2HCI+ RWWirjU8WV4BgnGggoLHOfEcsH60eHshQtFxDvBDmklKHlethgr5q36uFcrWppB3Nii6 OGCw== X-Gm-Message-State: AOAM5326rX7FCvBBYceKoaOvmqu+8VzIiJLwdnZ/NibqgUnXXKAzfsrB 5h/eJbbeVCZL6LeVpXDpSbQT5tSuKCdyGQ== X-Google-Smtp-Source: ABdhPJwDp0gPKGMRkn5QuY37dJScETTqC41jJHClXKeHLuEyrbFqdNU5P/A6AiXADqCokItHj3o+YA== X-Received: by 2002:a17:90a:ca89:b0:1d9:7d1a:c337 with SMTP id y9-20020a17090aca8900b001d97d1ac337mr11892923pjt.88.1650997367941; Tue, 26 Apr 2022 11:22:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 42/68] target/nios2: Use tcg_constant_tl Date: Tue, 26 Apr 2022 11:18:41 -0700 Message-Id: <20220426181907.103691-43-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000102477100001 Content-Type: text/plain; charset="utf-8" Replace current uses of tcg_const_tl, and remove the frees. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-43-richard.henderson@linaro.org> --- target/nios2/translate.c | 30 ++++++------------------------ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index b27269bf08..f33015f942 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -99,7 +99,6 @@ =20 typedef struct DisasContext { DisasContextBase base; - TCGv_i32 zero; target_ulong pc; int mem_idx; const ControlRegState *cr_state; @@ -125,31 +124,20 @@ static uint8_t get_opxcode(uint32_t code) return instr.opx; } =20 -static TCGv load_zero(DisasContext *dc) +static TCGv load_gpr(DisasContext *dc, unsigned reg) { - if (!dc->zero) { - dc->zero =3D tcg_const_i32(0); - } - return dc->zero; -} - -static TCGv load_gpr(DisasContext *dc, uint8_t reg) -{ - if (likely(reg !=3D R_ZERO)) { - return cpu_R[reg]; - } else { - return load_zero(dc); + assert(reg < NUM_GP_REGS); + if (unlikely(reg =3D=3D R_ZERO)) { + return tcg_constant_tl(0); } + return cpu_R[reg]; } =20 static void t_gen_helper_raise_exception(DisasContext *dc, uint32_t index) { - TCGv_i32 tmp =3D tcg_const_i32(index); - tcg_gen_movi_tl(cpu_pc, dc->pc); - gen_helper_raise_exception(cpu_env, tmp); - tcg_temp_free_i32(tmp); + gen_helper_raise_exception(cpu_env, tcg_constant_i32(index)); dc->base.is_jmp =3D DISAS_NORETURN; } =20 @@ -876,14 +864,8 @@ static void nios2_tr_translate_insn(DisasContextBase *= dcbase, CPUState *cs) return; } =20 - dc->zero =3D NULL; - instr =3D &i_type_instructions[op]; instr->handler(dc, code, instr->flags); - - if (dc->zero) { - tcg_temp_free(dc->zero); - } } =20 static void nios2_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000620; cv=none; d=zohomail.com; s=zohoarc; b=ZW1NmUSOUpVMQKvzAIYnb7gY9kgivGVRbFBphlfxXVhX972j2oq9MNEWuJJKI6uEALa6dZMh9auVwqhDAQhX4A0pQ7tyO/x5IDuFgTI4em1HjIK4yHQl+/mI4969hclBeoXthp+RjZkRp4ojaoSyBGXybtfGkBBu2jF85IolBEI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000620; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1DWNIJERXpZmtblRaXcb0XPGH7uKHZT6j2hdc+1VfWU=; b=SQnnr3sdqqSi8+V2tBsRKTTt6qgNiNu0zCkz/rrHOGfqaun9FEsudiYdJ7cZ/dunscVfktc7Av/QYU+YByaWT1Pawzc3bxdV7zabureKIv64/TY+5x1BnDRnwidHIv8UB4/7Z2LkNCFz84UbFC3ThCnbV2W2AgvIqXL1J3iPNss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000620355957.2421447009868; Tue, 26 Apr 2022 12:17:00 -0700 (PDT) Received: from localhost ([::1]:38332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQgE-0004ZZ-Sw for importer@patchew.org; Tue, 26 Apr 2022 15:16:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpr-0001nv-Up for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:34662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpq-0005MM-9t for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:51 -0400 Received: by mail-pf1-x429.google.com with SMTP id a11so7479479pff.1 for ; Tue, 26 Apr 2022 11:22:49 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1DWNIJERXpZmtblRaXcb0XPGH7uKHZT6j2hdc+1VfWU=; b=lQ3SMUA15RscWulhrEmMAzLqxPIB/uVaZKFlJvSB+3qmMcSwgixY8k8MkFteoGC8Lo YmDPuVkFK4YopQH4i5eCR8qVhnVMYkR/UQciZLbQ6D6m/5gbazBInjtDv8vT2q5AG+LL Ta4F+LvlcOypzjLzjSYHqDsQkbYtdhT3ypmrsSa+/2l8fRxX7msx5BN+O+u8wBteJqVh fDILOdWBpJSe1zXq8ikbnc9tx//+7dKGPKEfG+RJoAnvoor6dOMWRQvNqisZ1A+S8rH2 QVj4s6IFkvmm+/Xnc9eSF/TcnrV3DLeVDxEBuHovUV695E7GbdbD+Gbi5+Mg4G1qv/25 pxLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1DWNIJERXpZmtblRaXcb0XPGH7uKHZT6j2hdc+1VfWU=; b=x7tv3hKbeZY/JkZx9uoJkOMoqVRbdXmbga631CAkW5yCP+SUa4KBI5g8uEg5/uZHjE e4BbFz7scBHe2IpJHEWdTbh17CsyKZe+7I5ETyn1n4o8dcv2GvK2w9yzZu0MXjFABqsV GpmILD8koHbgXNMVj1J/5fcuD6eA0L3mvq6yolHJcqB8qRy9/jDJcMFNsLmMPOxfhzv0 d2p9h5hq4T33q+6c/jiC5fpJTusVNha9DsYr0ixxCb1CuBWQP5B7AJ+gsVDbv4VW1ELu AhTqhh7s6cEIq4A2ykGhHpeaTIvbBW0TlIaav1E3b2RbMox3tp19fOyrVmMc4P2oIDz9 wd9A== X-Gm-Message-State: AOAM531AkZJS5hEZONADIILPpWaj3tnJPbe6+nIJzP8tpHKWAJAbw4ba 5uCQaRHo3pgF91WZPAnf7gvjYO/fMeMvrA== X-Google-Smtp-Source: ABdhPJwKZ4Ju6mq4kc5bgHt1vdwz4T8A1FV28n0ZxVU3gm+89rUEDiqFykIvw7p65NnMdCdUrEwntg== X-Received: by 2002:a05:6a00:1d24:b0:50c:f8b5:974d with SMTP id a36-20020a056a001d2400b0050cf8b5974dmr21479759pfx.76.1650997368673; Tue, 26 Apr 2022 11:22:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 43/68] target/nios2: Split out named structs for [IRJ]_TYPE Date: Tue, 26 Apr 2022 11:18:42 -0700 Message-Id: <20220426181907.103691-44-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000621833100001 Content-Type: text/plain; charset="utf-8" Currently the structures are anonymous within the macro. Pull them out to standalone types. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-44-richard.henderson@linaro.org> --- target/nios2/translate.c | 48 ++++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f33015f942..a3c63dbbbd 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -53,16 +53,18 @@ #define INSN_R_TYPE 0x3A =20 /* I-Type instruction parsing */ +typedef struct { + uint8_t op; + union { + uint16_t u; + int16_t s; + } imm16; + uint8_t b; + uint8_t a; +} InstrIType; + #define I_TYPE(instr, code) \ - struct { \ - uint8_t op; \ - union { \ - uint16_t u; \ - int16_t s; \ - } imm16; \ - uint8_t b; \ - uint8_t a; \ - } (instr) =3D { \ + InstrIType (instr) =3D { \ .op =3D extract32((code), 0, 6), \ .imm16.u =3D extract32((code), 6, 16), \ .b =3D extract32((code), 22, 5), \ @@ -70,15 +72,17 @@ } =20 /* R-Type instruction parsing */ +typedef struct { + uint8_t op; + uint8_t imm5; + uint8_t opx; + uint8_t c; + uint8_t b; + uint8_t a; +} InstrRType; + #define R_TYPE(instr, code) \ - struct { \ - uint8_t op; \ - uint8_t imm5; \ - uint8_t opx; \ - uint8_t c; \ - uint8_t b; \ - uint8_t a; \ - } (instr) =3D { \ + InstrRType (instr) =3D { \ .op =3D extract32((code), 0, 6), \ .imm5 =3D extract32((code), 6, 5), \ .opx =3D extract32((code), 11, 6), \ @@ -88,11 +92,13 @@ } =20 /* J-Type instruction parsing */ +typedef struct { + uint8_t op; + uint32_t imm26; +} InstrJType; + #define J_TYPE(instr, code) \ - struct { \ - uint8_t op; \ - uint32_t imm26; \ - } (instr) =3D { \ + InstrJType (instr) =3D { \ .op =3D extract32((code), 0, 6), \ .imm26 =3D extract32((code), 6, 26), \ } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000695; cv=none; d=zohomail.com; s=zohoarc; b=MaLlqxITv7rGu2Yoyqb1+v89ycNLPCuHhP46l3j07U9kc4vyKajdizKPdodVE4l+l8Y7A6IxKlawkSYbpzbV0qcQve15bzwX6SCx79RHnBrIn/lciA4ciEKatkCdoyDpTepMRXq+2A1s4R5dPWaRQn7M1pg/O0Wm53If3LYSDx8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000695; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mYrrK9wMFTiFo0vQpejbJip6v2871lt8Lm0SZNjZ9fM=; b=IVfQQzAAerWaO3CNZFLlvu7ItaA/4fzVY2kphsroUC4QRHAs02adh351lav399Py9kmuSAUzqIcMG36C1IPczJRLwbDVc8GOBj0vmKjZwJiicjNKsJ/ShfKRqRVhslufubYoHO9b1IbcwtgQvUSFmQYvk6QqxkUKmN7v3HhnOwE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000695716674.4090533900825; Tue, 26 Apr 2022 12:18:15 -0700 (PDT) Received: from localhost ([::1]:42596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQhS-0007QA-JO for importer@patchew.org; Tue, 26 Apr 2022 15:18:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPps-0001nx-M7 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:39860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpr-0005Mw-1N for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:52 -0400 Received: by mail-pj1-x1029.google.com with SMTP id bd19-20020a17090b0b9300b001d98af6dcd1so2848601pjb.4 for ; Tue, 26 Apr 2022 11:22:50 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mYrrK9wMFTiFo0vQpejbJip6v2871lt8Lm0SZNjZ9fM=; b=V/P+yKyg/Kh6Ls2rYjzegeFFl1sgVIm6BrmqqWtghCGfyKxlzjU1QwJQYZdQ+XYwei A59rWEEzypFjWfMjD51y2BKfnakPLgd3pGOE6o5IZQJTvc5DsDyZ+WpIpQ35op6Oh8xH /vECJBCDZSNaCOOmQaGa0u1jfR1kKxB9bGyigk05K3K0aTVr/gVyOY8AmTN1fWSwHNtS L6j9gfNrfRLlhk2oHJX/tQWg4EAmr4grbJGrGSaCTBhQYHA0wJS09W2GJg+Z9nl81CA/ ikPiGcCvNRLSu+qAtQ5djfEaaN1udGlhurDmc9oXhljyxjN9zflge2PjNZwrSJjTxHb7 0YFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mYrrK9wMFTiFo0vQpejbJip6v2871lt8Lm0SZNjZ9fM=; b=OYqHLcKHb8VBDOhOhMRWqWXdZv+Y9NxlSdwh6lMNxTnqLsL7wifQ33L+hfAYIjy6nY V6uY50b5iuBjckqlaiBqHJ/TD5u1BNDnYmkO1o7noQ+0r7rnJJJbK2y87UahVIIZgjly nBC94hkd/zhM5CyXr31qqW7e/xiG8V9gfjhIAWdv8JDDzE5uDl44mesH6CMPsJBonoYA 40ydZjQeG41gKTLlaE14skG+gTysTGEq5DrMYv/YeKxy/sV8JapoZFYtAqmlovBwF4GD +l7kLdoTYs1zEcHAlqloB4WxbhB69WFT+zYlKBadYIPQOJ9aUkUYX6YYtuGhPal0EAZt tnXA== X-Gm-Message-State: AOAM533ke8zfAZzooJHcmTzSVIs/AHO7XFjYQG4Q7dvohpxAX9f4wxk3 KKb+ylkuDVFCNDJSdL8pRQ7bfBVJrJs1dQ== X-Google-Smtp-Source: ABdhPJw6y8IyyzI74EYwFlLhIzqWkZCl1vj0TxqfyIeAFQFufS3Gsk8hS0aq7ecmOCYrwFWzhNRf+w== X-Received: by 2002:a17:902:9887:b0:151:6e1c:7082 with SMTP id s7-20020a170902988700b001516e1c7082mr24091460plp.162.1650997369487; Tue, 26 Apr 2022 11:22:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 44/68] target/nios2: Split out helpers for gen_i_cmpxx Date: Tue, 26 Apr 2022 11:18:43 -0700 Message-Id: <20220426181907.103691-45-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000696290100001 Content-Type: text/plain; charset="utf-8" Do as little work as possible within the macro. Split out helper functions and pass in arguments instead. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 34 +++++++++++++++++++++++++++------- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index a3c63dbbbd..86978ba47a 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -71,6 +71,18 @@ typedef struct { .a =3D extract32((code), 27, 5), \ } =20 +typedef target_ulong ImmFromIType(const InstrIType *); + +static target_ulong imm_unsigned(const InstrIType *i) +{ + return i->imm16.u; +} + +static target_ulong imm_signed(const InstrIType *i) +{ + return i->imm16.s; +} + /* R-Type instruction parsing */ typedef struct { uint8_t op; @@ -268,15 +280,23 @@ static void gen_bxx(DisasContext *dc, uint32_t code, = uint32_t flags) } =20 /* Comparison instructions */ -#define gen_i_cmpxx(fname, op3) = \ -static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ -{ = \ - I_TYPE(instr, (code)); = \ - tcg_gen_setcondi_tl(flags, cpu_R[instr.b], cpu_R[instr.a], (op3)); = \ +static void do_i_cmpxx(DisasContext *dc, uint32_t insn, + TCGCond cond, ImmFromIType *imm) +{ + I_TYPE(instr, insn); + + if (likely(instr.b !=3D R_ZERO)) { + tcg_gen_setcondi_tl(cond, cpu_R[instr.b], + load_gpr(dc, instr.a), imm(&instr)); + } } =20 -gen_i_cmpxx(gen_cmpxxsi, instr.imm16.s) -gen_i_cmpxx(gen_cmpxxui, instr.imm16.u) +#define gen_i_cmpxx(fname, imm) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_i_cmpxx(dc, code, flags, imm); } + +gen_i_cmpxx(gen_cmpxxsi, imm_signed) +gen_i_cmpxx(gen_cmpxxui, imm_unsigned) =20 /* Math/logic instructions */ #define gen_i_math_logic(fname, insn, resimm, op3) = \ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999191; cv=none; d=zohomail.com; s=zohoarc; b=ZpAkRqqbiDUqZBNrxteE4zfgc+5tHsKOjv/XQw1SgaXiD8tiG6L2XbtsqwoD+gHXTh4kTq79YuJJZd6/QFjM9LCGXxIjCWq4VYVwAoG76/8yIpJs/NK98zop5K7F1z46B63tAtCLwMBinPLpqUcM37/3yDermL83f8iW45XnQ4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999191; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FlFue1M2dS8hFiD6a8SYA5F/GKJcQIyumbShiHs2wTE=; b=M/GYKynQLf3rTyF13YvMOz64L6tivypHzS+xNUIKYqgsqmnOTW0+TpvLAFEWGgv0lSTH7XJJ88xRm81n/WqhTfdnnR7lMBv3D9AeyEUGZ/ETQ76fQf716SV4SLlD0Kct4wXyqaHx/GeRHICra+uUYUgheBmKSfMRpCN/TIUpBz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999191908465.17389410496503; Tue, 26 Apr 2022 11:53:11 -0700 (PDT) Received: from localhost ([::1]:37742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQJC-0007RZ-SL for importer@patchew.org; Tue, 26 Apr 2022 14:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpt-0001ny-46 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:41745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpr-0005NU-Gi for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:52 -0400 Received: by mail-pj1-x102e.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so3318731pjf.0 for ; Tue, 26 Apr 2022 11:22:51 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlFue1M2dS8hFiD6a8SYA5F/GKJcQIyumbShiHs2wTE=; b=Uomhn9aj6pFMmbiHGAsTQ2srtXyNYpdtoxmJy7ZIRnnJhNfFMAg4FeJoLipMr4gfhL zfTbuA7EXQsZeSi1Dqny6ztQivavLOzPIv7Pd/HUXURRNdNxBYAkefBCgLzN4hph7XEG BPn/ZjbFgA+v+9xVDlwODtcjlBclPJUp6NWbjSBok0CN1ggieflkLJYFekFhB8ghWJDo H75vBzGl1/e+02og8B3BebI/5ZoVG4ekYNjjQBIizgHnTyHWqSZb0lFCJoI9QExoanX0 qKI3YgUCKtWU6jMkPjeraEyZSk3FazmI8gf45wqmpqy82NfGM1hPna1KooQ4cZCswJWZ wtzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlFue1M2dS8hFiD6a8SYA5F/GKJcQIyumbShiHs2wTE=; b=xz0LWmODGz7qsMB8B916dbZ7CgvzFIm2ImazZ8MAngpDAYqIcugDFBGuaj5ocvliGW a+plyPgd8VSb0gOLlExgkuobM7QWmbYu7LeXoOlUgOHPgAeHYmFIIDe5K8pV0+tUhaw8 FnO6fzCzxZ4Uh6SI4y4x0W+gGMru1JjujxbT7cxQ03rIS8HKXlZgomE+p/2yqd1PwWai MAkvinTETsCIu7DHyomptdC4lLri9jEqTzQ7e2dIxeF2wurzm7pt7KauDGL+wQJbJQyO x1VyX4WpvUQmP2vTjr9jVJqSdQyozPojceTsWHDKtU+9yk0i1jEch2T3voKtBIh1BiK7 SnCg== X-Gm-Message-State: AOAM530mbHkDqJnolxqcZbloHzqHRxEehWbxVrdkNNt7YoQHcqNU5JPk NUYmZA6ACXl3brgwVsyG4a1idH4mPZG7oA== X-Google-Smtp-Source: ABdhPJxkmma4NG2px0odKH5TSTyf2uf/GUMtvRSwxPYu+YUO24UnzLfrMiUfnD6nn9zJgTnHipvdLQ== X-Received: by 2002:a17:90b:350d:b0:1d9:eca0:5be with SMTP id ls13-20020a17090b350d00b001d9eca005bemr2337722pjb.175.1650997370294; Tue, 26 Apr 2022 11:22:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 45/68] target/nios2: Split out helpers for gen_i_math_logic Date: Tue, 26 Apr 2022 11:18:44 -0700 Message-Id: <20220426181907.103691-46-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999192358100001 Content-Type: text/plain; charset="utf-8" Do as little work as possible within the macro. Split out helper functions and pass in arguments instead. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 58 +++++++++++++++++++++++++++------------- 1 file changed, 39 insertions(+), 19 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 86978ba47a..aa570b6d79 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -83,6 +83,11 @@ static target_ulong imm_signed(const InstrIType *i) return i->imm16.s; } =20 +static target_ulong imm_shifted(const InstrIType *i) +{ + return i->imm16.u << 16; +} + /* R-Type instruction parsing */ typedef struct { uint8_t op; @@ -115,6 +120,8 @@ typedef struct { .imm26 =3D extract32((code), 6, 26), \ } =20 +typedef void GenFn2i(TCGv, TCGv, target_long); + typedef struct DisasContext { DisasContextBase base; target_ulong pc; @@ -299,29 +306,42 @@ gen_i_cmpxx(gen_cmpxxsi, imm_signed) gen_i_cmpxx(gen_cmpxxui, imm_unsigned) =20 /* Math/logic instructions */ -#define gen_i_math_logic(fname, insn, resimm, op3) = \ -static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ -{ = \ - I_TYPE(instr, (code)); = \ - if (unlikely(instr.b =3D=3D R_ZERO)) { /* Store to R_ZERO is ignored *= / \ - return; = \ - } else if (instr.a =3D=3D R_ZERO) { /* MOVxI optimizations */ = \ - tcg_gen_movi_tl(cpu_R[instr.b], (resimm) ? (op3) : 0); = \ - } else { = \ - tcg_gen_##insn##_tl(cpu_R[instr.b], cpu_R[instr.a], (op3)); = \ - } = \ +static void do_i_math_logic(DisasContext *dc, uint32_t insn, + GenFn2i *fn, ImmFromIType *imm, + bool x_op_0_eq_x) +{ + I_TYPE(instr, insn); + target_ulong val; + + if (unlikely(instr.b =3D=3D R_ZERO)) { + /* Store to R_ZERO is ignored -- this catches the canonical NOP. */ + return; + } + + val =3D imm(&instr); + + if (instr.a =3D=3D R_ZERO) { + /* This catches the canonical expansions of movi and movhi. */ + tcg_gen_movi_tl(cpu_R[instr.b], x_op_0_eq_x ? val : 0); + } else { + fn(cpu_R[instr.b], cpu_R[instr.a], val); + } } =20 -gen_i_math_logic(addi, addi, 1, instr.imm16.s) -gen_i_math_logic(muli, muli, 0, instr.imm16.s) +#define gen_i_math_logic(fname, insn, x_op_0, imm) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_i_math_logic(dc, code, tcg_gen_##insn##_tl, imm, x_op_0); } =20 -gen_i_math_logic(andi, andi, 0, instr.imm16.u) -gen_i_math_logic(ori, ori, 1, instr.imm16.u) -gen_i_math_logic(xori, xori, 1, instr.imm16.u) +gen_i_math_logic(addi, addi, 1, imm_signed) +gen_i_math_logic(muli, muli, 0, imm_signed) =20 -gen_i_math_logic(andhi, andi, 0, instr.imm16.u << 16) -gen_i_math_logic(orhi , ori, 1, instr.imm16.u << 16) -gen_i_math_logic(xorhi, xori, 1, instr.imm16.u << 16) +gen_i_math_logic(andi, andi, 0, imm_unsigned) +gen_i_math_logic(ori, ori, 1, imm_unsigned) +gen_i_math_logic(xori, xori, 1, imm_unsigned) + +gen_i_math_logic(andhi, andi, 0, imm_shifted) +gen_i_math_logic(orhi , ori, 1, imm_shifted) +gen_i_math_logic(xorhi, xori, 1, imm_shifted) =20 /* Prototype only, defined below */ static void handle_r_type_instr(DisasContext *dc, uint32_t code, --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999926; cv=none; d=zohomail.com; s=zohoarc; b=AXBxqtGRXi7J1TVSTIYGnNiwhNaM9KBjA8jMjO+eWZc9ZkPpbrL3qbHBNenMtOVNvN0PZ3MRxcjir/2HwrLPSU0geaGLhKuorpnaH0y9dsAOZnsDNBoucFFaaAd+ytDwRb5lPkcf153IRhkuTZwT9ZKPhSv4YXuT6hL2PrjQJtk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999926; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yxKaaQdEBaOQz5dOpNmfl+nzRcffEVAUl93wsbbxQeM=; b=D9TJ2sqd6TdkneLAAA3kRy+T1x3eDTsSfa99WKDdhY1tsRfEF+wDzByTHoj4ijGAQrouu3RIjubHxgDRZ4g6fpWOlVNshS3sCts1A1BwsqZaw4JUJ0eMvLVhFUsBw16CnibGGfEFqLFsVn1lkV/1kcFGTVTUUJv6AtRZtfb/S2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999926373225.09805754675574; Tue, 26 Apr 2022 12:05:26 -0700 (PDT) Received: from localhost ([::1]:37214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQV3-00017F-BF for importer@patchew.org; Tue, 26 Apr 2022 15:05:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpu-0001o0-NV for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:46052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPps-0005O8-SU for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:54 -0400 Received: by mail-pj1-x1029.google.com with SMTP id n33-20020a17090a5aa400b001d28f5ee3f9so3274867pji.4 for ; Tue, 26 Apr 2022 11:22:52 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yxKaaQdEBaOQz5dOpNmfl+nzRcffEVAUl93wsbbxQeM=; b=w+GgHKi9a/LBRlAxB3zJsXrL8wsoq5yuTEBXzrxauKrU9Dbzw5+bkN7mf55Q63jCiy N4vs6HsAd5f9obYGBebr+H5zWlgyGEIobq9CUhv83OUO2Di1Ad5DwOwosJxpzt9nKFnB y1jfJ917l4yOUfrbq3hDQX+GkdhfwPnmUGGWXzo+TJfGDvzWR1lE+1Razpw2RCTdDsLG gZf096ylxkD/Ck9a1sLI/EBOeWLcDkrdHOmx5K72dItgBe2rvDX94Z2pitdRMAiYdT5s +cUhFuopP/k4Q4YXJ2zWAhzSG3qXDZ7baE/jDPh9X231fgnI6TlTea3JizQGgp4tU5iV zukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yxKaaQdEBaOQz5dOpNmfl+nzRcffEVAUl93wsbbxQeM=; b=5pErSELDqzhw3RiQcdDhNaVjmal1Xln/R3fQ4BKb8PFfPg1RsUr5y3z18RQjYACgWw hCUepiLkAOWbHK6ADyjxhmfrS8oHlZzNiRwLvdUQYYxNUZppUFvPCxyA8z/kbtnP2De4 NJ8PrFXFYf+whyq8EC9J6gEd2qEnmzmcoQv4BZnu9ltDCn0eOt+54aaGBWrJDIHnMrpJ KbvAkCZo0RXWS0J9We7aZ7RkJa8UIbl+5pCv++cT2HSGW/FiE9Y99OOgA2BGxyZZ1p0f 71At8KsNiACcwoSlBniLd86tgrkoNM0FL5ZKI7QPViUClWCtB+yzmMCu1PjJv2QuKUpP ltkw== X-Gm-Message-State: AOAM5315msL889aergLy0u7O1XZjuaGZNSl0gL67nh6QYdQhNWxvH3Kt M1CNqOvvJHT1SB/4yUfNGoZzYhBUewd8kQ== X-Google-Smtp-Source: ABdhPJwndwtZv+OiBiaGyWdo7vNWhG1EwMqTx/x1YlnqUc/MXIcmHNPqzpu4xIQdc/3vLh4tqqoL8w== X-Received: by 2002:a17:903:241:b0:15c:ee52:cbf2 with SMTP id j1-20020a170903024100b0015cee52cbf2mr16817256plh.10.1650997371201; Tue, 26 Apr 2022 11:22:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 46/68] target/nios2: Split out helpers for gen_r_math_logic Date: Tue, 26 Apr 2022 11:18:45 -0700 Message-Id: <20220426181907.103691-47-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999927027100001 Content-Type: text/plain; charset="utf-8" Split the macro in two, one for reg/imm and one for reg/reg. Do as little work as possible within the macros; split out helper functions and pass in arguments instead. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 54 ++++++++++++++++++++++++++-------------- 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index aa570b6d79..4f52606516 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -121,6 +121,7 @@ typedef struct { } =20 typedef void GenFn2i(TCGv, TCGv, target_long); +typedef void GenFn3(TCGv, TCGv, TCGv); =20 typedef struct DisasContext { DisasContextBase base; @@ -628,28 +629,45 @@ static void gen_cmpxx(DisasContext *dc, uint32_t code= , uint32_t flags) } =20 /* Math/logic instructions */ -#define gen_r_math_logic(fname, insn, op3) = \ -static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ -{ = \ - R_TYPE(instr, (code)); = \ - if (likely(instr.c !=3D R_ZERO)) { = \ - tcg_gen_##insn(cpu_R[instr.c], load_gpr((dc), instr.a), (op3)); = \ - } = \ +static void do_ri_math_logic(DisasContext *dc, uint32_t insn, GenFn2i *fn) +{ + R_TYPE(instr, insn); + + if (likely(instr.c !=3D R_ZERO)) { + fn(cpu_R[instr.c], load_gpr(dc, instr.a), instr.imm5); + } } =20 -gen_r_math_logic(add, add_tl, load_gpr(dc, instr.b)) -gen_r_math_logic(sub, sub_tl, load_gpr(dc, instr.b)) -gen_r_math_logic(mul, mul_tl, load_gpr(dc, instr.b)) +static void do_rr_math_logic(DisasContext *dc, uint32_t insn, GenFn3 *fn) +{ + R_TYPE(instr, insn); =20 -gen_r_math_logic(and, and_tl, load_gpr(dc, instr.b)) -gen_r_math_logic(or, or_tl, load_gpr(dc, instr.b)) -gen_r_math_logic(xor, xor_tl, load_gpr(dc, instr.b)) -gen_r_math_logic(nor, nor_tl, load_gpr(dc, instr.b)) + if (likely(instr.c !=3D R_ZERO)) { + fn(cpu_R[instr.c], load_gpr(dc, instr.a), load_gpr(dc, instr.b)); + } +} =20 -gen_r_math_logic(srai, sari_tl, instr.imm5) -gen_r_math_logic(srli, shri_tl, instr.imm5) -gen_r_math_logic(slli, shli_tl, instr.imm5) -gen_r_math_logic(roli, rotli_tl, instr.imm5) +#define gen_ri_math_logic(fname, insn) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_ri_math_logic(dc, code, tcg_gen_##insn##_tl); } + +#define gen_rr_math_logic(fname, insn) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_rr_math_logic(dc, code, tcg_gen_##insn##_tl); } + +gen_rr_math_logic(add, add) +gen_rr_math_logic(sub, sub) +gen_rr_math_logic(mul, mul) + +gen_rr_math_logic(and, and) +gen_rr_math_logic(or, or) +gen_rr_math_logic(xor, xor) +gen_rr_math_logic(nor, nor) + +gen_ri_math_logic(srai, sari) +gen_ri_math_logic(srli, shri) +gen_ri_math_logic(slli, shli) +gen_ri_math_logic(roli, rotli) =20 #define gen_r_mul(fname, insn) \ static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) \ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999422; cv=none; d=zohomail.com; s=zohoarc; b=RtV+k6r+CnMOrdCgYGlyUYPz6h7sqTLz4gwajSL4fTUBbqTqrAnhxQuuw6Ii/Ek9Df827WaqiK1MWQmQ3YtL7O/3IcIv9GX8Jh55e92HIL8DF48ygnM7s2rjVmwFCZGt5hDyjtKmpiR8u9kfYH0+OlzOAX+tbt8nspKpuexs7T0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999422; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=90FS4A3L0e+HZIc9EHaI5AkuPRk/8PsmEOmUrAtpCKw=; b=c+a5Od3YSuiscsl8/t+z/ILJwJd062nDAFAYaGfgsnlN4Wjwsz0q0Q5cpFoz9UNVENu8EAGmenDGi+XXjn92bn3F72MkXfzTHUzLgqMzNENB/obg8wuwQJ7oByT9UXQ22jz5uGrQlkdKifEmFXGtf/X3Nd5MkgTPvbyjBpJbmMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16509994229151005.4778239282189; Tue, 26 Apr 2022 11:57:02 -0700 (PDT) Received: from localhost ([::1]:46288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQMv-0004w6-OI for importer@patchew.org; Tue, 26 Apr 2022 14:57:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpv-0001pn-Gl for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:56 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:38788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpt-0005Oj-Hf for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:55 -0400 Received: by mail-pf1-x42b.google.com with SMTP id b15so18719351pfm.5 for ; Tue, 26 Apr 2022 11:22:52 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=90FS4A3L0e+HZIc9EHaI5AkuPRk/8PsmEOmUrAtpCKw=; b=SYZqSfEwESzozRy2FZ5oOXy2rh0lymvvRpVp0kuGeUpfPY8VPr8LH2l8hW6Bh0fBVd rXyzh+edeRCWyrMZ9LZbA2f9YEMohy1xyVbh7t0hmbE3v0DmkKNHc3FK1xT3xSvzRo++ lpC/oKSJJ2hzyWnw9v7i3ISmN6yQwcrvUxW27/BJlwgiKkk8+sSfzXpNahAzFfmA090a /V9lbJi1WjlrpRopaEdTkUqnRdJwa/7ScUxfDmCPlj7W76crVn/eoUJ6LWeSNunv0sit jX+313dnRN7ZkdxMpiSlDNqHL2Zg4UqhS13WytyjNrqtJZIzZRpsPlhDOnThzkV7hIdG wQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=90FS4A3L0e+HZIc9EHaI5AkuPRk/8PsmEOmUrAtpCKw=; b=4fxk/8vah/yspuopBlzgIHEbPz4+Rw+dhmkRAH5NPJHGCx4Z7lPj2McgwhNyqkEN/b KjdqmPNDQrCFQCqhssE/8+iG8YuY+AUf209AzF0eQtshPjkB4pj0l7mfsGEC1bdRPLTs FTe34vguKe443SsO4fadnJBZ7hI85/harKljra8SgrDQ/Q1+DEjw91rxiAd5LvyYhG5k 1+zdpoxOy76LdEfYD0/KrgkGg1z5RdN4+9SiBF4i/HT+s8gi5CYuHk0AMwbqO4DLIVln u2D4kBaFf81qdyn1HJUHA274VCsRmk4pcWtwXPfEbg+UfvrzsiVT7FMCp6dYRKJBH/Di BW/g== X-Gm-Message-State: AOAM5312hkRO1t6XXaqYTagWtEtC9SQJx8vQvR42NI+CXZNUzwGUulX/ QFOMUTxdOdVMRHzePfueXg2uoEDuB+iugQ== X-Google-Smtp-Source: ABdhPJxOv2JDDpeiMi6PiRfPvx7D6j4nvmrpYpyNKCxqzEDCj0DHpcC/ZtaD3Sb/gSMPb2sitd1a4g== X-Received: by 2002:a63:de53:0:b0:3aa:8b0:b690 with SMTP id y19-20020a63de53000000b003aa08b0b690mr21012412pgi.580.1650997372047; Tue, 26 Apr 2022 11:22:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 47/68] target/nios2: Split out helpers for gen_rr_mul_high Date: Tue, 26 Apr 2022 11:18:46 -0700 Message-Id: <20220426181907.103691-48-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999425063100001 Content-Type: text/plain; charset="utf-8" Rename the macro from gen_r_mul, because these are the multiply variants that produce a high-part result. Do as little work as possible within the macro; split out helper functions and pass in arguments instead. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 4f52606516..5979427c8e 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -122,6 +122,7 @@ typedef struct { =20 typedef void GenFn2i(TCGv, TCGv, target_long); typedef void GenFn3(TCGv, TCGv, TCGv); +typedef void GenFn4(TCGv, TCGv, TCGv, TCGv); =20 typedef struct DisasContext { DisasContextBase base; @@ -669,21 +670,25 @@ gen_ri_math_logic(srli, shri) gen_ri_math_logic(slli, shli) gen_ri_math_logic(roli, rotli) =20 -#define gen_r_mul(fname, insn) \ -static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) \ -{ \ - R_TYPE(instr, (code)); \ - if (likely(instr.c !=3D R_ZERO)) { \ - TCGv t0 =3D tcg_temp_new(); \ - tcg_gen_##insn(t0, cpu_R[instr.c], \ - load_gpr(dc, instr.a), load_gpr(dc, instr.b)); \ - tcg_temp_free(t0); \ - } \ +static void do_rr_mul_high(DisasContext *dc, uint32_t insn, GenFn4 *fn) +{ + R_TYPE(instr, insn); + + if (likely(instr.c !=3D R_ZERO)) { + TCGv discard =3D tcg_temp_new(); + fn(discard, cpu_R[instr.c], load_gpr(dc, instr.a), + load_gpr(dc, instr.b)); + tcg_temp_free(discard); + } } =20 -gen_r_mul(mulxss, muls2_tl) -gen_r_mul(mulxuu, mulu2_tl) -gen_r_mul(mulxsu, mulsu2_tl) +#define gen_rr_mul_high(fname, insn) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_rr_mul_high(dc, code, tcg_gen_##insn##_tl); } + +gen_rr_mul_high(mulxss, muls2) +gen_rr_mul_high(mulxuu, mulu2) +gen_rr_mul_high(mulxsu, mulsu2) =20 #define gen_r_shift_s(fname, insn) = \ static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000774; cv=none; d=zohomail.com; s=zohoarc; b=BG0eoDdPouiVQQ3INvNl43CzCr2mc+3sM9yy6vx1oMm4aGSqgq6a2Gc3mjvDMHxUKkTDyV35ZsKolG+JR+GUMhx6876Y5nbZG5oaMHypDxWiaDdmWmYb6+YO6K7AqoQ6UgrPorshEw9Y6mLmsDkl27exQgply9xm2Bjku+Y9FFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000774; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=puwqanA1QPFvLkvLJfGYt1sTnByIkGWrO6X4uNsWXMs=; b=UGvLzQcxF6L42twEhtPUYt0Hb1AJfow72jR//VIYtv6Re9b5Ur5cwHToT/rBLl3P4bnWqvAbSp1NX+L/B8aiM8wM6lM2qQlHNJvbbx5PAJb7Fqjic3rCVG5Abas56VWDWr5WJjfy4h7ZpZbD36f/zHh9Y1Cq81YUEfoJ1HIqGm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000774660320.8693732310004; Tue, 26 Apr 2022 12:19:34 -0700 (PDT) Received: from localhost ([::1]:45818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQij-00018C-8a for importer@patchew.org; Tue, 26 Apr 2022 15:19:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpw-0001po-7n for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:56 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:44835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpu-0005PE-EQ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:55 -0400 Received: by mail-pg1-x52e.google.com with SMTP id v10so5647632pgl.11 for ; Tue, 26 Apr 2022 11:22:54 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=puwqanA1QPFvLkvLJfGYt1sTnByIkGWrO6X4uNsWXMs=; b=EH+jfnIkVys1xf9YxFCfF3rIQnJvYCwB6q6YEhHGzR8ZIS+g4QBkI54ah6lKnHVxd4 YGH+6XKYEibbjyxO5xA1nX7nqtyJ+jp/70YWANOJD6WLQwo7X3uxJbe1I13ix9AVMOQA 1Le4Lj6q7nqaMzZsmUvPLBmxo/Att2NaXcZKyqATfSZl/cCcbUP7IJgLJAvWKe+gkWMO uX5N7L/LELSS50yrTj8ix9Sd99yv746GjQFEm0lzq4Y+cy29FHLVigECX0P/hxRuJ7FL Ucb0eKseQMzeTHCAWG7N42mGn6Mcc20zaNg2TwqtO0/w4VkmrWsya0gNeqeLzWG56Y7R +FwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=puwqanA1QPFvLkvLJfGYt1sTnByIkGWrO6X4uNsWXMs=; b=p/bTtkuv9FKAUWKmIpLhq/FIjlLhjzvdwC4DbbPYs2htJ8V2y+yUekDG40Cep9ewEr ONSll0uF07LlY2qoFiK5sa9k0Mab7f3Bm0K/v2MqhUQFFLSgj0p2wowCVeGbjVYuSiwd +a3iqWTNjiB+/yEYPiUq3mynwD7kW0LrYlMbfFxlFLDLCE5k2urwYKJ2igmX8TwkGaQL h2GWosqddn/KeSm4Eqms5kE2Z2fb7seAtHFDm9dGbeUmUAYaHyWX/yIVg9U+UAb952ED QGgF+XBA2uuvk05Jq1bVIsnrroBqNhN5CR5vdsKZbDDN7y1CPSuSHmhv3sP/rtXl6Qq5 wQBg== X-Gm-Message-State: AOAM532y3ysYE1xhPXu4uydwsvhD/kFb9KOYsPkPq/ueusaHbWjbCd5A 3d8BnIjmtM/P69Ee7y7kYBAHonZJq/cHSQ== X-Google-Smtp-Source: ABdhPJy/MkNcGLhleC+HdidGIi9Kg10gJ24MXsiyHzyW8czMaBC5HwA+rSfB/nrEUruyZuXd1M/1GA== X-Received: by 2002:a63:ee0d:0:b0:39d:8637:6706 with SMTP id e13-20020a63ee0d000000b0039d86376706mr20725966pgi.510.1650997373070; Tue, 26 Apr 2022 11:22:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 48/68] target/nios2: Split out helpers for gen_rr_shift Date: Tue, 26 Apr 2022 11:18:47 -0700 Message-Id: <20220426181907.103691-49-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000776890100001 Content-Type: text/plain; charset="utf-8" Do as little work as possible within the macro. Split out helper functions and pass in arguments instead. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 5979427c8e..f2dcaa3fbb 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -690,23 +690,28 @@ gen_rr_mul_high(mulxss, muls2) gen_rr_mul_high(mulxuu, mulu2) gen_rr_mul_high(mulxsu, mulsu2) =20 -#define gen_r_shift_s(fname, insn) = \ -static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ -{ = \ - R_TYPE(instr, (code)); = \ - if (likely(instr.c !=3D R_ZERO)) { = \ - TCGv t0 =3D tcg_temp_new(); = \ - tcg_gen_andi_tl(t0, load_gpr((dc), instr.b), 31); = \ - tcg_gen_##insn(cpu_R[instr.c], load_gpr((dc), instr.a), t0); = \ - tcg_temp_free(t0); = \ - } = \ +static void do_rr_shift(DisasContext *dc, uint32_t insn, GenFn3 *fn) +{ + R_TYPE(instr, insn); + + if (likely(instr.c !=3D R_ZERO)) { + TCGv sh =3D tcg_temp_new(); + + tcg_gen_andi_tl(sh, load_gpr(dc, instr.b), 31); + fn(cpu_R[instr.c], load_gpr(dc, instr.a), sh); + tcg_temp_free(sh); + } } =20 -gen_r_shift_s(sra, sar_tl) -gen_r_shift_s(srl, shr_tl) -gen_r_shift_s(sll, shl_tl) -gen_r_shift_s(rol, rotl_tl) -gen_r_shift_s(ror, rotr_tl) +#define gen_rr_shift(fname, insn) = \ + static void (fname)(DisasContext *dc, uint32_t code, uint32_t flags) = \ + { do_rr_shift(dc, code, tcg_gen_##insn##_tl); } + +gen_rr_shift(sra, sar) +gen_rr_shift(srl, shr) +gen_rr_shift(sll, shl) +gen_rr_shift(rol, rotl) +gen_rr_shift(ror, rotr) =20 static void divs(DisasContext *dc, uint32_t code, uint32_t flags) { --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000347; cv=none; d=zohomail.com; s=zohoarc; b=IbWkgGeZqco9Aj3qx8DXlwVDTgYtyyNMJYirEc1F5SMEjwavI2RifYTOEmUa+/KEUM2l5UD7jTQKGKBcpyQ+10sJxgL3wT5S5ZJ7GOjmFsateKwDYWmT8aFijd3zmM7o4GQEu8QXU/rI4cqDuUiSG3tFOo6lohWJuDy5cYFXTdM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000347; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uR4zZV3657JN1hsGHyvkuesYvOqGujxYVfmhutLiFKw=; b=SNNTn4xS+VYJwG85uWGet5iDpoEt4Pow8g3053L+2oD4MMA1WG4/1p5T7HLySUeabWybFvEllUx/9tz2DnQat0US20wUhtpA75uG7uf1W7JXhx+0EItPEnImmlc8xOE7M/IL7z5dTKW6bFNJ7kuD33bXxGPRCbPi3H9T1OshMYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000347308176.04386658995622; Tue, 26 Apr 2022 12:12:27 -0700 (PDT) Received: from localhost ([::1]:57216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQbq-0006dn-6F for importer@patchew.org; Tue, 26 Apr 2022 15:12:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpx-0001qz-FX for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:58 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:38686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpv-0005Pj-CV for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:57 -0400 Received: by mail-pj1-x1035.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so933338pjb.3 for ; Tue, 26 Apr 2022 11:22:54 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uR4zZV3657JN1hsGHyvkuesYvOqGujxYVfmhutLiFKw=; b=HB7lNb2h4mhRqJB3uGePRGK/XRW9ynXWLXZ1ELFaHfBkpqn03bZ1ygEzBEYG4djPbR IEJKWXcZHLJifh6O5F31n5z9QlCVzcZSenUVkNAiZTupkS6vZl16UxXPb9DYBYIZ4Jmi FOP0JothQGdlCSfop5d6gYmmu3vheno+DPkT4ApeJnKaYdP4OqDE170Fe04SDRRcVAKN hkwoCI1p2N0DE4RHQlraRaRUOMDq/ntoTG9JafawfDtxjhPekofXXpZ9gEp/YVJTWGzd RLr7THeNP+fwL306/1TqGFGeXEhptjFha8Y2uHrkNm5AzUS2csmuNh9YIbBOIIenqGFW 4f/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uR4zZV3657JN1hsGHyvkuesYvOqGujxYVfmhutLiFKw=; b=uVmVvySeyEFUjMCw6uKAPAhZlMICP1gIp3rSpknKT5botT2BlON+dYgU7FC/v2ynPp MbJE/gR5xBavkSKI0u89ny7PXO1roWMx/fHj0bO5NMFWhKKpjgj8W+emxBed1kOHg4jn fVs/ZRqhuoqlwL1cN912rgDWfVhtPwCtlBl8ikvZ5i32oFrfjISeDV+ZHg7Rtk8np4TH Ct8tfuDIEsf1KK7UKZHgxFxESJbAAO432Dnxm0og2BrBceJE7rVH9BHI2W6ZGccCB6zS yJcUQ7ZimiHRH8mCJ262TIk66sFS7UkW7XtI41O/Gy4KfM3n0OydNq5L+cinr5mPU76i tp0Q== X-Gm-Message-State: AOAM533kyNOkZBM9N+iPxE4nnvGHNGab4YkCis1NGVN2wvjQP/IloIMh rnavmxcSenJ3Yajo2VEHo9g8nyaye/B6kw== X-Google-Smtp-Source: ABdhPJy4APytLfAcHGSidplAHdTCyap5nYX5Y67wMz50iVHpeJRbWwls8ink7Ow29PVoFXkQCSgl2A== X-Received: by 2002:a17:903:189:b0:15d:356a:5590 with SMTP id z9-20020a170903018900b0015d356a5590mr4893533plg.72.1650997373890; Tue, 26 Apr 2022 11:22:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 49/68] target/nios2: Introduce dest_gpr Date: Tue, 26 Apr 2022 11:18:48 -0700 Message-Id: <20220426181907.103691-50-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000347817100001 Content-Type: text/plain; charset="utf-8" Constrain all references to cpu_R[] to load_gpr and dest_gpr. This will be required for supporting shadow register sets. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-46-richard.henderson@linaro.org> --- target/nios2/translate.c | 144 +++++++++++++-------------------------- 1 file changed, 49 insertions(+), 95 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f2dcaa3fbb..e2742a8556 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -128,6 +128,7 @@ typedef struct DisasContext { DisasContextBase base; target_ulong pc; int mem_idx; + TCGv sink; const ControlRegState *cr_state; } DisasContext; =20 @@ -160,6 +161,18 @@ static TCGv load_gpr(DisasContext *dc, unsigned reg) return cpu_R[reg]; } =20 +static TCGv dest_gpr(DisasContext *dc, unsigned reg) +{ + assert(reg < NUM_GP_REGS); + if (unlikely(reg =3D=3D R_ZERO)) { + if (dc->sink =3D=3D NULL) { + dc->sink =3D tcg_temp_new(); + } + return dc->sink; + } + return cpu_R[reg]; +} + static void t_gen_helper_raise_exception(DisasContext *dc, uint32_t index) { @@ -218,7 +231,7 @@ static void jmpi(DisasContext *dc, uint32_t code, uint3= 2_t flags) =20 static void call(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_movi_tl(cpu_R[R_RA], dc->base.pc_next); + tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); jmpi(dc, code, flags); } =20 @@ -231,27 +244,10 @@ static void gen_ldx(DisasContext *dc, uint32_t code, = uint32_t flags) I_TYPE(instr, code); =20 TCGv addr =3D tcg_temp_new(); - TCGv data; - - /* - * WARNING: Loads into R_ZERO are ignored, but we must generate the - * memory access itself to emulate the CPU precisely. Load - * from a protected page to R_ZERO will cause SIGSEGV on - * the Nios2 CPU. - */ - if (likely(instr.b !=3D R_ZERO)) { - data =3D cpu_R[instr.b]; - } else { - data =3D tcg_temp_new(); - } + TCGv data =3D dest_gpr(dc, instr.b); =20 tcg_gen_addi_tl(addr, load_gpr(dc, instr.a), instr.imm16.s); tcg_gen_qemu_ld_tl(data, addr, dc->mem_idx, flags); - - if (unlikely(instr.b =3D=3D R_ZERO)) { - tcg_temp_free(data); - } - tcg_temp_free(addr); } =20 @@ -281,7 +277,7 @@ static void gen_bxx(DisasContext *dc, uint32_t code, ui= nt32_t flags) I_TYPE(instr, code); =20 TCGLabel *l1 =3D gen_new_label(); - tcg_gen_brcond_tl(flags, cpu_R[instr.a], cpu_R[instr.b], l1); + tcg_gen_brcond_tl(flags, load_gpr(dc, instr.a), load_gpr(dc, instr.b),= l1); gen_goto_tb(dc, 0, dc->base.pc_next); gen_set_label(l1); gen_goto_tb(dc, 1, dc->base.pc_next + (instr.imm16.s & -4)); @@ -293,11 +289,8 @@ static void do_i_cmpxx(DisasContext *dc, uint32_t insn, TCGCond cond, ImmFromIType *imm) { I_TYPE(instr, insn); - - if (likely(instr.b !=3D R_ZERO)) { - tcg_gen_setcondi_tl(cond, cpu_R[instr.b], - load_gpr(dc, instr.a), imm(&instr)); - } + tcg_gen_setcondi_tl(cond, dest_gpr(dc, instr.b), + load_gpr(dc, instr.a), imm(&instr)); } =20 #define gen_i_cmpxx(fname, imm) = \ @@ -324,9 +317,9 @@ static void do_i_math_logic(DisasContext *dc, uint32_t = insn, =20 if (instr.a =3D=3D R_ZERO) { /* This catches the canonical expansions of movi and movhi. */ - tcg_gen_movi_tl(cpu_R[instr.b], x_op_0_eq_x ? val : 0); + tcg_gen_movi_tl(dest_gpr(dc, instr.b), x_op_0_eq_x ? val : 0); } else { - fn(cpu_R[instr.b], cpu_R[instr.a], val); + fn(dest_gpr(dc, instr.b), load_gpr(dc, instr.a), val); } } =20 @@ -434,7 +427,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) #else TCGv tmp =3D tcg_temp_new(); tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_ESTATUS])); - gen_helper_eret(cpu_env, tmp, cpu_R[R_EA]); + gen_helper_eret(cpu_env, tmp, load_gpr(dc, R_EA)); tcg_temp_free(tmp); =20 dc->base.is_jmp =3D DISAS_NORETURN; @@ -444,8 +437,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) /* PC <- ra */ static void ret(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_mov_tl(cpu_pc, cpu_R[R_RA]); - + tcg_gen_mov_tl(cpu_pc, load_gpr(dc, R_RA)); dc->base.is_jmp =3D DISAS_JUMP; } =20 @@ -464,7 +456,7 @@ static void bret(DisasContext *dc, uint32_t code, uint3= 2_t flags) #else TCGv tmp =3D tcg_temp_new(); tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_BSTATUS])); - gen_helper_eret(cpu_env, tmp, cpu_R[R_BA]); + gen_helper_eret(cpu_env, tmp, load_gpr(dc, R_BA)); tcg_temp_free(tmp); =20 dc->base.is_jmp =3D DISAS_NORETURN; @@ -477,7 +469,6 @@ static void jmp(DisasContext *dc, uint32_t code, uint32= _t flags) R_TYPE(instr, code); =20 tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); - dc->base.is_jmp =3D DISAS_JUMP; } =20 @@ -486,9 +477,7 @@ static void nextpc(DisasContext *dc, uint32_t code, uin= t32_t flags) { R_TYPE(instr, code); =20 - if (likely(instr.c !=3D R_ZERO)) { - tcg_gen_movi_tl(cpu_R[instr.c], dc->base.pc_next); - } + tcg_gen_movi_tl(dest_gpr(dc, instr.c), dc->base.pc_next); } =20 /* @@ -500,7 +489,7 @@ static void callr(DisasContext *dc, uint32_t code, uint= 32_t flags) R_TYPE(instr, code); =20 tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); - tcg_gen_movi_tl(cpu_R[R_RA], dc->base.pc_next); + tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); =20 dc->base.is_jmp =3D DISAS_JUMP; } @@ -516,15 +505,11 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) g_assert_not_reached(); #else R_TYPE(instr, code); - TCGv t1, t2; - - if (unlikely(instr.c =3D=3D R_ZERO)) { - return; - } + TCGv t1, t2, dest =3D dest_gpr(dc, instr.c); =20 /* Reserved registers read as zero. */ if (nios2_cr_reserved(&dc->cr_state[instr.imm5])) { - tcg_gen_movi_tl(cpu_R[instr.c], 0); + tcg_gen_movi_tl(dest, 0); return; } =20 @@ -542,12 +527,12 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) t2 =3D tcg_temp_new(); tcg_gen_ld_tl(t1, cpu_env, offsetof(CPUNios2State, ctrl[CR_IPENDIN= G])); tcg_gen_ld_tl(t2, cpu_env, offsetof(CPUNios2State, ctrl[CR_IENABLE= ])); - tcg_gen_and_tl(cpu_R[instr.c], t1, t2); + tcg_gen_and_tl(dest, t1, t2); tcg_temp_free(t1); tcg_temp_free(t2); break; default: - tcg_gen_ld_tl(cpu_R[instr.c], cpu_env, + tcg_gen_ld_tl(dest, cpu_env, offsetof(CPUNios2State, ctrl[instr.imm5])); break; } @@ -623,29 +608,21 @@ static void wrctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) static void gen_cmpxx(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, code); - if (likely(instr.c !=3D R_ZERO)) { - tcg_gen_setcond_tl(flags, cpu_R[instr.c], cpu_R[instr.a], - cpu_R[instr.b]); - } + tcg_gen_setcond_tl(flags, dest_gpr(dc, instr.c), + load_gpr(dc, instr.a), load_gpr(dc, instr.b)); } =20 /* Math/logic instructions */ static void do_ri_math_logic(DisasContext *dc, uint32_t insn, GenFn2i *fn) { R_TYPE(instr, insn); - - if (likely(instr.c !=3D R_ZERO)) { - fn(cpu_R[instr.c], load_gpr(dc, instr.a), instr.imm5); - } + fn(dest_gpr(dc, instr.c), load_gpr(dc, instr.a), instr.imm5); } =20 static void do_rr_math_logic(DisasContext *dc, uint32_t insn, GenFn3 *fn) { R_TYPE(instr, insn); - - if (likely(instr.c !=3D R_ZERO)) { - fn(cpu_R[instr.c], load_gpr(dc, instr.a), load_gpr(dc, instr.b)); - } + fn(dest_gpr(dc, instr.c), load_gpr(dc, instr.a), load_gpr(dc, instr.b)= ); } =20 #define gen_ri_math_logic(fname, insn) = \ @@ -673,13 +650,11 @@ gen_ri_math_logic(roli, rotli) static void do_rr_mul_high(DisasContext *dc, uint32_t insn, GenFn4 *fn) { R_TYPE(instr, insn); + TCGv discard =3D tcg_temp_new(); =20 - if (likely(instr.c !=3D R_ZERO)) { - TCGv discard =3D tcg_temp_new(); - fn(discard, cpu_R[instr.c], load_gpr(dc, instr.a), - load_gpr(dc, instr.b)); - tcg_temp_free(discard); - } + fn(discard, dest_gpr(dc, instr.c), + load_gpr(dc, instr.a), load_gpr(dc, instr.b)); + tcg_temp_free(discard); } =20 #define gen_rr_mul_high(fname, insn) = \ @@ -693,14 +668,11 @@ gen_rr_mul_high(mulxsu, mulsu2) static void do_rr_shift(DisasContext *dc, uint32_t insn, GenFn3 *fn) { R_TYPE(instr, insn); + TCGv sh =3D tcg_temp_new(); =20 - if (likely(instr.c !=3D R_ZERO)) { - TCGv sh =3D tcg_temp_new(); - - tcg_gen_andi_tl(sh, load_gpr(dc, instr.b), 31); - fn(cpu_R[instr.c], load_gpr(dc, instr.a), sh); - tcg_temp_free(sh); - } + tcg_gen_andi_tl(sh, load_gpr(dc, instr.b), 31); + fn(dest_gpr(dc, instr.c), load_gpr(dc, instr.a), sh); + tcg_temp_free(sh); } =20 #define gen_rr_shift(fname, insn) = \ @@ -716,39 +688,15 @@ gen_rr_shift(ror, rotr) static void divs(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, (code)); - TCGv dest; - - if (instr.c =3D=3D R_ZERO) { - dest =3D tcg_temp_new(); - } else { - dest =3D cpu_R[instr.c]; - } - - gen_helper_divs(dest, cpu_env, + gen_helper_divs(dest_gpr(dc, instr.c), cpu_env, load_gpr(dc, instr.a), load_gpr(dc, instr.b)); - - if (instr.c =3D=3D R_ZERO) { - tcg_temp_free(dest); - } } =20 static void divu(DisasContext *dc, uint32_t code, uint32_t flags) { R_TYPE(instr, (code)); - TCGv dest; - - if (instr.c =3D=3D R_ZERO) { - dest =3D tcg_temp_new(); - } else { - dest =3D cpu_R[instr.c]; - } - - gen_helper_divu(dest, cpu_env, + gen_helper_divu(dest_gpr(dc, instr.c), cpu_env, load_gpr(dc, instr.a), load_gpr(dc, instr.b)); - - if (instr.c =3D=3D R_ZERO) { - tcg_temp_free(dest); - } } =20 static void trap(DisasContext *dc, uint32_t code, uint32_t flags) @@ -938,8 +886,14 @@ static void nios2_tr_translate_insn(DisasContextBase *= dcbase, CPUState *cs) return; } =20 + dc->sink =3D NULL; + instr =3D &i_type_instructions[op]; instr->handler(dc, code, instr->flags); + + if (dc->sink) { + tcg_temp_free(dc->sink); + } } =20 static void nios2_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000833; cv=none; d=zohomail.com; s=zohoarc; b=RjSMhMgOhLfF/4DPXSJZYg7+T0NYvWJtN5+cKoy2HxMPlVdMpVwYLmI7+HwIKR9KaoyxY4R7ZYQjkouVWZQLflteVwfgCLxaSRHPLlGJVgqM+nYSsXN/sLblQBy24a/57nRFn9kf4ghhk13qwwqCmlK+VQoasgDQd8D8M3mjp8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000833; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rtZqSMWwTH4bx7pviC4q7DdFYgGahnZ3eKlGOA25mWs=; b=bCMOJxT3eSM+OGcu3CyaBb2mfaA+f1zdlSlXDhTkf3jjC6OTpMFFgEtvite41qSOH+1Wepv0w8nfV0f15RhO5ldzRSyCa/P4rhGClQGtKtKD07VCIANsKoOkq/dtKDTWKtCR3Rx9tM7W1tmqcJB7inXxUt7qhSgpZOowXcgsdnM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16510008331981018.3115285432579; Tue, 26 Apr 2022 12:20:33 -0700 (PDT) Received: from localhost ([::1]:49158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQjg-0003Ko-76 for importer@patchew.org; Tue, 26 Apr 2022 15:20:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpx-0001r0-Gk for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:58 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:41752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpv-0005QQ-VK for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:57 -0400 Received: by mail-pj1-x1035.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so3318892pjf.0 for ; Tue, 26 Apr 2022 11:22:55 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rtZqSMWwTH4bx7pviC4q7DdFYgGahnZ3eKlGOA25mWs=; b=MMp+XOBYzZwfNLBZo+x0xBr5LJ2oUwNH8xKjtkmyKWP5YGpDsi+wKET7GVlsRDzmI3 6faLq/8eP+bbAcddcRd/gOs7q7CYJlV7bPFdS8HLwXDejuEELBewzyc2mNzNBl8E3Mfe i3bumTuu5lrmfQcV8vdEjYnECX9hZLEIKs0a5+OGcgADIT9yYaoQGcYJY5bM7v4bWjSP PSrLvFVcWBoxX1t6zjACMUoOSVuISdd8+bOaIvELNnR4r8YB8RDYKBWLorKlhaMOyizd rk6obj3IQdq4u3gm4L8+mqR5ittPc06C4tk3WzxKNPJ7jDgw+gQywfDUnL/58FkJA3Rq ARTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rtZqSMWwTH4bx7pviC4q7DdFYgGahnZ3eKlGOA25mWs=; b=OwILA8SE9OQokMUXxfgnmXJwvTX3FuHhK57+M/WwSxPtEyzE86GVx0StdpTSPQjEYK 23kXxOM50hUOoaNg0ZCJPbtjMlzriZdM/+jsvnWiYjyUZVLxvRyiKJn/Kz5sxkkUWAmP MKAAKuu2A20fIOnDTW0CD1oHQWtcoFWi0AG10yHOIMiD1bTeKwYbyIcoSVdli2zP69UU wXx//RvATTnTRJ9AEVi345+r0+XTRWjcfUb4QZ7NHP0/ZmsoUfDvKP8da4D9SXm/hSB+ COEOk/7Xj4ol1s4Xh/IqZBOZKcz+XWjZZfg1b/OI8AcPEdMAdQz0GKeKb77jRxLDsy++ w1QQ== X-Gm-Message-State: AOAM530r090HwvoVAwKSvA2FsmqKz9HuAl21AqSyCYbarHjfoD0kEFQE UE/O+bRaYnaZ6BX86Wg+JTVvd6iNwOUs/Q== X-Google-Smtp-Source: ABdhPJwb/nVS9ZDHmlWaZQ+YYc7Xabd7vKH7rzcDBdsZOq3ROjVUaYnbvwzE+EZURr3VJElq3QRJzw== X-Received: by 2002:a17:902:ea4f:b0:158:5013:1403 with SMTP id r15-20020a170902ea4f00b0015850131403mr24511855plg.75.1650997374681; Tue, 26 Apr 2022 11:22:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 50/68] target/nios2: Drop CR_STATUS_EH from tb->flags Date: Tue, 26 Apr 2022 11:18:49 -0700 Message-Id: <20220426181907.103691-51-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000835221100001 Content-Type: text/plain; charset="utf-8" There's nothing about EH that affects translation, so there's no need to include it in tb->flags. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-47-richard.henderson@linaro.org> --- target/nios2/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 4d63006ffe..477a661f17 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -272,7 +272,7 @@ static inline void cpu_get_tb_cpu_state(CPUNios2State *= env, target_ulong *pc, { *pc =3D env->pc; *cs_base =3D 0; - *flags =3D env->ctrl[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U); + *flags =3D env->ctrl[CR_STATUS] & CR_STATUS_U; } =20 #endif /* NIOS2_CPU_H */ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000910; cv=none; d=zohomail.com; s=zohoarc; b=Van3Iu5Mk6ZHO1onoFnIYbF2iGMAvtNkAH6czhsPnBtuwR55vVCjFu701F93iVThXBZHTEyVDHzE3Xyn5eH3bVrUYlQju+4kzpNpEUQYybHIcNiDj0Fz7vzOxLbX93JchYWiZlHIVm+ah5y0o8IJHXh8HQheIjAKqHzVJ0ZMueQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000910; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3qxaCTAb9LNwU3nym8tcsfcPLahPlRpIRpMaVcx2cxM=; b=gpp5IIZkMbJKwf2Sk5F5FkLvG2w+xpRKsysJyqdQJO8u6ewIAd6McyL20ApGs0M4AvAqC5rWJFSZ/DiZmmQvFYnQyg+O0uPhpItOCbotkbXfjn0zuaVqveU/XuxKuJgtYie/OHUM4rHWGXI0HZlFB4yKmBpmnhD40jJf9t+2c5A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000910853827.6229002552235; Tue, 26 Apr 2022 12:21:50 -0700 (PDT) Received: from localhost ([::1]:52504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQkv-0005db-R7 for importer@patchew.org; Tue, 26 Apr 2022 15:21:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpy-0001r3-NM for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:58 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:44746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpw-0005RF-Q1 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:58 -0400 Received: by mail-pj1-x102e.google.com with SMTP id m14-20020a17090a34ce00b001d5fe250e23so3278247pjf.3 for ; Tue, 26 Apr 2022 11:22:56 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3qxaCTAb9LNwU3nym8tcsfcPLahPlRpIRpMaVcx2cxM=; b=mvTchj3xjtD8zks+a17nSiJv8fHUt6k4MMHS1RtrE+hdv1/lWozzan63FRKjDNHy/5 6/pDdTz2wxTPlzxq1ChefXsxqqBa02XH/a9iXw9FUN4lWRW0r2Nkux4kPJBZfq7EjFxx DbWCgvBocBphBzabg3lDDaV0cCRy6JoCTM/7BiiioIoGxxagLrrBDxzVOpTkTGsAfAE5 cJ/t8RPu52WUCHRTzgm6g96R7SCplMRVCCG0fIV+8NudtBOAbNVyYECeOhkuk2E54+hX lgf+BbJ3xzBIUolu9Hwb3Z9pVNhWtIwku+peqwYB/6RLxkSBuCrzEp7kVqmcrjccFTCy q8Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3qxaCTAb9LNwU3nym8tcsfcPLahPlRpIRpMaVcx2cxM=; b=zBDULBwDSt5mrb8rdK1yAyKvSxov6imdhV8Jora2wC0alI7iJYI6QSJpARaNjTpK2B 9DuIhyMoZefIHU67rw7Sie3HUwQmQFCLfyV71DVWpna7rKPoWV1ZjMAOIIm4C+DFAeHy OMfqM4IHzzNt/Bl1cvTOH8cbwuX4bDGMBW9BlR8SAE1Qim9XXa+unLbunsbrqpHTgPJe zGIDpfhsBEuEXIpUX4rqhwgcRAR7UmX4IGQ1stG67y8ye24CyAYKe6/F4ggI8/ePVJMN K6XCP+P8PEgNV0htFmkU2Qg8uiybJ+iby2B3cweG2U3/oUvbkPSVM8Ikzs6Ivr2GRZgB 4xFA== X-Gm-Message-State: AOAM533zm7sCEOD+AujbId/KYynTXRehIPthpfueA0kqcxnfjsUlJ7F8 wfIoX9/Vxvp+ah5WBE+A4uwky2Obaq6efg== X-Google-Smtp-Source: ABdhPJwE/kPJ6VZbxCOjWHfPhXp0K22bTSiX/VqIFnlugsMZbQdCrAgj659gWxPBms3yAT7J/Y5Qew== X-Received: by 2002:a17:902:da88:b0:15d:3dae:b0a4 with SMTP id j8-20020a170902da8800b0015d3daeb0a4mr3140853plx.75.1650997375560; Tue, 26 Apr 2022 11:22:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 51/68] target/nios2: Enable unaligned traps for system mode Date: Tue, 26 Apr 2022 11:18:50 -0700 Message-Id: <20220426181907.103691-52-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000912037100001 Content-Type: text/plain; charset="utf-8" Unaligned traps are optional, but required with an mmu. Turn them on always, because the fallback behaviour undefined. Enable alignment checks in the config file. Unwind the guest pc properly from do_unaligned_access. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-48-richard.henderson@linaro.org> --- configs/targets/nios2-softmmu.mak | 1 + target/nios2/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configs/targets/nios2-softmmu.mak b/configs/targets/nios2-soft= mmu.mak index 9a372f0717..1e93b54cd1 100644 --- a/configs/targets/nios2-softmmu.mak +++ b/configs/targets/nios2-softmmu.mak @@ -1 +1,2 @@ TARGET_ARCH=3Dnios2 +TARGET_ALIGNED_ONLY=3Dy diff --git a/target/nios2/helper.c b/target/nios2/helper.c index c5a2dd65b1..2e9fea4a01 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -241,8 +241,8 @@ void nios2_cpu_do_unaligned_access(CPUState *cs, vaddr = addr, CPUNios2State *env =3D &cpu->env; =20 env->ctrl[CR_BADADDR] =3D addr; - env->ctrl[CR_EXCEPTION] =3D FIELD_DP32(0, CR_EXCEPTION, CAUSE, EXCP_UN= ALIGN); - helper_raise_exception(env, EXCP_UNALIGN); + cs->exception_index =3D EXCP_UNALIGN; + cpu_loop_exit_restore(cs, retaddr); } =20 bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, int size, --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001054; cv=none; d=zohomail.com; s=zohoarc; b=IeFWzH4XvLP7gk0lbgF2omyM8lcb0Hx4eLBKmqAAN4HHhL4sDlWp+YPcRxQYiIu0BAOFifuHHb6MZSyjSolie8CVwxd/N5wmmigCtpc8P8qCr4NplLcu9czwfCaf1Sq2X8Z5IlzHOn03V8Ba9hn1ghQ4TIpV1HwPEWDvPM/IuZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001054; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FydhLHa4yRdKoi+QMZFm3ACoytrW9DGPCspIkMaQe9I=; b=ILgnivG6RZ9+OLMYjZjqCOV2xWEAi7N9BfA1eu7YuZBN4+J2/8+u/qxX9kRrVuTEP3EVA7s2I70bdXnizrXdzrASSyBEjUywy/dJ9C29c8UkmAG3i8M+ri9pvW/omZ9bVZ0L5ggbrS6I5jN7xJTcFKbM6DBqv64mglmFAXDSnP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001054311860.9045574087268; Tue, 26 Apr 2022 12:24:14 -0700 (PDT) Received: from localhost ([::1]:59106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQnE-0001Zp-F7 for importer@patchew.org; Tue, 26 Apr 2022 15:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPpz-0001rc-6i for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:01 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:46850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpx-0005Rs-JQ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:58 -0400 Received: by mail-pj1-x1032.google.com with SMTP id u6-20020a17090a1f0600b001d86bd69427so3268659pja.5 for ; Tue, 26 Apr 2022 11:22:57 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FydhLHa4yRdKoi+QMZFm3ACoytrW9DGPCspIkMaQe9I=; b=UEanv7dasubxQge87dL0Fakxp502DYRAjTJIHVkkH9kNJa+VF3FmkUSi9SnkRzf5SL Sg5kqdvtVEdRg4yev1LuBuqS3E9wEFnpPGWJNKLf+IHKjB6WQd7hudR5SDq2qKZ6SJhh 7gKfCb6gkWPV2yo7RGLL+WdQHAPlYy31an9gDrlaRziyqYbU1KMDYTyk9I9ZRPrlL7Dd AEIfydJrKUZ5pc0rQjGuw5w/Ig2RQawaJ+R3ZUkAa/dC4sBauOWZyw6JH56nYG/IB7rZ vaIlPxJ20Dy0QesoRHe8dBW1gPmOlmXI5a8Jvtvt6fMzK95j+gMi1uoWnnPnVq4+31Cc DXDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FydhLHa4yRdKoi+QMZFm3ACoytrW9DGPCspIkMaQe9I=; b=VFBZ9zfxZf/mE1HUG3PqYP0i2ZwJ4GMvXYOJcc+g1vMig/paOmqt5bdWDLq0dIZ1nZ /+sjlabDpHoOasqJ38l9TLT5AVJA2PRh2Roi+a/RF1fHy9EYdWOn2iHYZRwyN1EX1nEP 7Znw9mEfvassDFJlKtCD7K0j1lMvaPvDyieeF+FVN5smKcDSaFqGElos+GRFf/Oa81mS xsI05ND0EufbVQ0Y7YX/mnfbJhNZwFJUDIgeYRxnVdgUWtyt73fmiO1lARa4JZHOKE2S o92+AmMgH/NeDx4Ux3UKTGv1h/TuC8onwssHLPxCa1GsvtJZT5SNeoSeJ/Top7NlEp71 +7kA== X-Gm-Message-State: AOAM5330Hypn41K5nBLjkH2G13bpiqeCi79BSJgRkHfHa/H4VCQDnKRQ 95XojJVamTJNICCEdQ73sS/KWrDz3I2qRA== X-Google-Smtp-Source: ABdhPJww8O0tOLjfV78J9tazr/nJ0hlOC43DlBUVChLgFWIggT7JChvu4A5tJIOZG574zAZgTTtAFw== X-Received: by 2002:a17:902:6ac7:b0:150:24d6:b2ee with SMTP id i7-20020a1709026ac700b0015024d6b2eemr24976450plt.168.1650997376254; Tue, 26 Apr 2022 11:22:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 52/68] target/nios2: Create gen_jumpr Date: Tue, 26 Apr 2022 11:18:51 -0700 Message-Id: <20220426181907.103691-53-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001056577100001 Content-Type: text/plain; charset="utf-8" Split out a function to perform an indirect branch. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-49-richard.henderson@linaro.org> --- target/nios2/translate.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index e2742a8556..8616813365 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -36,7 +36,6 @@ #include "semihosting/semihost.h" =20 /* is_jmp field values */ -#define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ #define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically= */ =20 #define INSTRUCTION_FLG(func, flags) { (func), (flags) } @@ -195,6 +194,16 @@ static void gen_goto_tb(DisasContext *dc, int n, uint3= 2_t dest) } } =20 +static void gen_jumpr(DisasContext *dc, int regno, bool is_call) +{ + tcg_gen_mov_tl(cpu_pc, load_gpr(dc, regno)); + if (is_call) { + tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); + } + tcg_gen_exit_tb(NULL, 0); + dc->base.is_jmp =3D DISAS_NORETURN; +} + static void gen_excp(DisasContext *dc, uint32_t code, uint32_t flags) { t_gen_helper_raise_exception(dc, flags); @@ -437,8 +446,7 @@ static void eret(DisasContext *dc, uint32_t code, uint3= 2_t flags) /* PC <- ra */ static void ret(DisasContext *dc, uint32_t code, uint32_t flags) { - tcg_gen_mov_tl(cpu_pc, load_gpr(dc, R_RA)); - dc->base.is_jmp =3D DISAS_JUMP; + gen_jumpr(dc, R_RA, false); } =20 /* @@ -468,8 +476,7 @@ static void jmp(DisasContext *dc, uint32_t code, uint32= _t flags) { R_TYPE(instr, code); =20 - tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); - dc->base.is_jmp =3D DISAS_JUMP; + gen_jumpr(dc, instr.a, false); } =20 /* rC <- PC + 4 */ @@ -488,10 +495,7 @@ static void callr(DisasContext *dc, uint32_t code, uin= t32_t flags) { R_TYPE(instr, code); =20 - tcg_gen_mov_tl(cpu_pc, load_gpr(dc, instr.a)); - tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); - - dc->base.is_jmp =3D DISAS_JUMP; + gen_jumpr(dc, instr.a, true); } =20 /* rC <- ctlN */ @@ -909,11 +913,6 @@ static void nios2_tr_tb_stop(DisasContextBase *dcbase,= CPUState *cs) tcg_gen_exit_tb(NULL, 0); break; =20 - case DISAS_JUMP: - /* The jump will already have updated the PC register */ - tcg_gen_exit_tb(NULL, 0); - break; - case DISAS_NORETURN: /* nothing more to generate */ break; --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999863; cv=none; d=zohomail.com; s=zohoarc; b=ndt6Y1uiwTsiCFj/enE15RORuKnOqGG2uIz+A6JwQoy2X2mK+7UAOYgn+DKftAE0lxuu5270NOUzRkJEeiPG0jcdHNKcjXiuKd6bJXIjautHNeXLpGPdsu140Y/8h6qPQPfTOwMKEmyYafWoQxAEn1XWEKmBzPeb7frJ/cpfISY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999863; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=M42Ymd8NhUXswzBIpA0GWB4WiO6wzm8wN551Ya1dgKHkwJp4hdt0fansNh5LMojEg5Lcq/rJJPB1jS74NEDPi+GSAuNfT2yrhz8Nm8N6/TeigFvQ5eUhOKeMmALsbnHwzn4YEBRj/mMLfJG9LHyu2Tw3EtcCRCD+k4EsII0XoRI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999863337488.2606021175685; Tue, 26 Apr 2022 12:04:23 -0700 (PDT) Received: from localhost ([::1]:34948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQU2-00080T-7Q for importer@patchew.org; Tue, 26 Apr 2022 15:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq0-0001rq-6V for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:36689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpy-0005Sb-AP for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:22:59 -0400 Received: by mail-pl1-x62b.google.com with SMTP id q8so7842845plx.3 for ; Tue, 26 Apr 2022 11:22:57 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=oO381OdIPVQRnBJG9j5lE3c4+mN7lc0q5Ag+dC3TSCCGgCiWRYNHxIH1UaWYS3VSvk jS5iBa13mYN/Q/2ICk9fjYTSeuknKi6scbVtm1riWsIxptHAirmtK31sYzNGNScvyVr5 MEANgxSbMB6qb+4a2lfAr1mpjbQvDxQQ92dH3KSPvcRfEF9BVRqmzshqfCI8FxxRuUND 3OESMCOkHkfq4d2nZO8DHlMQkuIfuVWSXXAE/CLrOVS3MhERQh9SP/ryw9sGBfFK3NEb oC0XZOblaV22c21Z9KSZS730ZMBQ7botU45FOVWbX/cT3ZoKgliVe1x2Z4+Krnn4kZPa UHBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ECkUiferYymqY4Z15uQTs5z/1lpHpfnUwzpraAW+MmE=; b=gSpJeRJVg4WbhWoVi3eyuj8JEBztkl2ck6VnNNADUf4In4uNMmPxLGoh+9VBwgEOrC Td9FTI5BS2QmChJT4J3uT7d2KfuzC59aVkzS0WHOrt287dFivr98n6j4lOHNzJVqw3m4 jbzjjU20aVV0FH4d+eOlgu8Lciku6iaW/1gScaHmqZroU/SswhMkT02IYkUUuygLyWNR a37y3eR6j9YKFsZAJIYP/AbzBARDf/92E6S4Jtu+5eg7N0vAftuKO0qnWnDZngMhF2gO ZmojLf1Drui0xJDI91OTmZDqG2Ra/edHFveSQP5wb6Vs5x8m4MqEkqFgERJjc65+TT0E QA8w== X-Gm-Message-State: AOAM533S6pbIo9L4BvB1gS0rim8T7H93MbFIGo67lhxPFJQtR/r17d6t OmJFtj/UcIszCGJAHYM86Cdu3BlG7U7VzQ== X-Google-Smtp-Source: ABdhPJy8RnUH9MMW6L/4qMmjcWPlSXshBriAUYOUxjE5oHY88ufh5NB4pqy5/43irlLtkVJE5btE6A== X-Received: by 2002:a17:902:bf0a:b0:15c:df1b:f37d with SMTP id bi10-20020a170902bf0a00b0015cdf1bf37dmr19462963plb.90.1650997377049; Tue, 26 Apr 2022 11:22:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 53/68] target/nios2: Hoist set of is_jmp into gen_goto_tb Date: Tue, 26 Apr 2022 11:18:52 -0700 Message-Id: <20220426181907.103691-54-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999864744100001 Content-Type: text/plain; charset="utf-8" Rather than force all callers to set this, do it within the subroutine. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-50-richard.henderson@linaro.org> --- target/nios2/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 8616813365..a55270cefa 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -192,6 +192,7 @@ static void gen_goto_tb(DisasContext *dc, int n, uint32= _t dest) tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(NULL, 0); } + dc->base.is_jmp =3D DISAS_NORETURN; } =20 static void gen_jumpr(DisasContext *dc, int regno, bool is_call) @@ -235,7 +236,6 @@ static void jmpi(DisasContext *dc, uint32_t code, uint3= 2_t flags) { J_TYPE(instr, code); gen_goto_tb(dc, 0, (dc->pc & 0xF0000000) | (instr.imm26 << 2)); - dc->base.is_jmp =3D DISAS_NORETURN; } =20 static void call(DisasContext *dc, uint32_t code, uint32_t flags) @@ -278,7 +278,6 @@ static void br(DisasContext *dc, uint32_t code, uint32_= t flags) I_TYPE(instr, code); =20 gen_goto_tb(dc, 0, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp =3D DISAS_NORETURN; } =20 static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) @@ -290,7 +289,6 @@ static void gen_bxx(DisasContext *dc, uint32_t code, ui= nt32_t flags) gen_goto_tb(dc, 0, dc->base.pc_next); gen_set_label(l1); gen_goto_tb(dc, 1, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp =3D DISAS_NORETURN; } =20 /* Comparison instructions */ --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000902; cv=none; d=zohomail.com; s=zohoarc; b=ewj86SXhDrjFoCYkhLikfHOLoatZErOfgeGivjWBX64R7UAV6aMbwpyBHwSEdxW0mpNNgh4ZP7wbfz+K9mO/xq++LsXws3fHpXrzVu8LimhdRawlxp/XieYyr2uSdSM6VLYXPTvtolGSOcjNye2jdtpfyP67vAev8QVL33b6EEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000902; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q5lQ3QQmzEghJch5edn2tjFgDaTVnAJ5/vXlb5qvEBk=; b=LL8hKZoRyErEFETeWzqRqiz2mCHtBfvEd/6derLoqMW+s/G3AxfYTefXpScr/sMbDnjH8uFTHVqQcXAGkj7fUyg+lc4qtIyHZWYSy7XKvzMGcHFwJ4p0pGrYwx1psSh5HvknX2ft1QrO7bid8wGfqwjVTZR/TjW0qKwBCG8YJT4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000902849796.2767199397266; Tue, 26 Apr 2022 12:21:42 -0700 (PDT) Received: from localhost ([::1]:51888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQkn-0005EK-FN for importer@patchew.org; Tue, 26 Apr 2022 15:21:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq1-0001s1-Dh for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:33523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPpz-0005TD-UE for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:01 -0400 Received: by mail-pl1-x62f.google.com with SMTP id c23so31033860plo.0 for ; Tue, 26 Apr 2022 11:22:58 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5lQ3QQmzEghJch5edn2tjFgDaTVnAJ5/vXlb5qvEBk=; b=OJQl0xec91YW6WB8y4DLhAS9sN7e/Te4p4ZcA0F5mb1589SCRDwL4GS22+/S2vl2EX Bh5AWzkn8RI3iwqSBjJAmYEcUZ44rDboF+lJMK7h4pDcQeQvKm9MFWNYBOyZuEBw/ypX Psq5yuISnjrrU5WeUQKyDoJSa/0wV2g1codkE0maUrKmIM8vdxC7EJ8tXGl5n1FXhdPj or6ydsPC5HQxtzVAeHK/hDMowtfQxMmZAXflQlD2sfMtfCTu/CU1rVPYitPPjNQ9QyTl t+tzYhj3xM1XTDj45b2bMkeTHLWIQKzY/T0iDpo7KRQEVbKKzlDJYEVa8qxIgiN3ytWf A0LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5lQ3QQmzEghJch5edn2tjFgDaTVnAJ5/vXlb5qvEBk=; b=z0HUsvShn5JYhsAGfzeX74FUP6z/eiceHpm75YA7S8LXswfjjhmPVxClMxcRxds3UX dLMdUSWPiltMJWyYBt9zA4VgrzPQhynRDI3tBmXkGCpqHejAkEBr7YUrmcDENXfLMWO+ BOHomMRAFh0dQcLpyn4/R7HY6+E2CO+JonaNUvafIQXlQdVZgazNrfFVmhaQY9QWsBhf kNkvpAE1BFQHzCQqw2LgSJKYXje2q/0oNvOdV2yE4CtHJnlvgPF8ZGiS3qynBknPJjuu kueANXcZVQTeKpUa9MBlll9VRqpojneAefBIwT8dbuV/KrenHiGc/UUZn4ZWXJMDorIi +SHw== X-Gm-Message-State: AOAM532GN9wCa7joTOWb78JvjSAvOpUZHCMiQ6S5tThohxQOJKQapBgd 85l9vrWmzBrBlcRYBLHS4+9uiIciCeW45A== X-Google-Smtp-Source: ABdhPJwKF8HkI5iEflnG/awNIQg2/5pC5cFKhwBtwOk02YJPfoJ0oEw1PWmrkLYgrPN1icCngx/9VA== X-Received: by 2002:a17:902:7610:b0:158:89a5:fc5a with SMTP id k16-20020a170902761000b0015889a5fc5amr25217934pll.116.1650997377968; Tue, 26 Apr 2022 11:22:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 54/68] target/nios2: Use gen_goto_tb for DISAS_TOO_MANY Date: Tue, 26 Apr 2022 11:18:53 -0700 Message-Id: <20220426181907.103691-55-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000903848100001 Content-Type: text/plain; charset="utf-8" Depending on the reason for ending the TB, we can chain to the next TB because the PC is constant. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-51-richard.henderson@linaro.org> --- target/nios2/translate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index a55270cefa..87f3e57d4c 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -905,8 +905,11 @@ static void nios2_tr_tb_stop(DisasContextBase *dcbase,= CPUState *cs) /* Indicate where the next block should start */ switch (dc->base.is_jmp) { case DISAS_TOO_MANY: + gen_goto_tb(dc, 0, dc->base.pc_next); + break; + case DISAS_UPDATE: - /* Save the current PC back into the CPU register */ + /* Save the current PC, and return to the main loop. */ tcg_gen_movi_tl(cpu_pc, dc->base.pc_next); tcg_gen_exit_tb(NULL, 0); break; --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000767; cv=none; d=zohomail.com; s=zohoarc; b=QLr4Fpu+MIP4gmrAp1XHvzAcIQG6aopg1EvFaM2toLiY0cc6gpREZu0PRhmXr28tNJKgiwJV0loBCLHVKjltR0X5q4G/O2A63cmNiQeVjnWZ5EJAYd1uYriW7AZZJiVYJ+UB2lhMsYdZvO+5b2QuApaAbQF0HoJ6d2NGfEk+mnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000767; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RUgiA6Oi5P+ooqWxIlZ6MCSz3k6th6h8Ep/asqMDiZk=; b=HBplksqV5YpkZDg9piGcxzYK1+MEdD50hEGpQkCihjqayXal1RqbvXxRtq1cP5A2C1TvMhoLlyuSChg8A/zgTvJiIEK76LEilPBSxhpt/2RP5NgAHcRQdti0kAa6hW6ZKxzVmTGHQl9a372vzBoUQ61F2qWJP45ppvTr0v+LgbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165100076735925.023228055496816; Tue, 26 Apr 2022 12:19:27 -0700 (PDT) Received: from localhost ([::1]:45342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQia-0000pN-Km for importer@patchew.org; Tue, 26 Apr 2022 15:19:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq2-0001s9-2v for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:37611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq0-0005Tx-HE for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:01 -0400 Received: by mail-pj1-x102d.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so2870420pju.2 for ; Tue, 26 Apr 2022 11:23:00 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RUgiA6Oi5P+ooqWxIlZ6MCSz3k6th6h8Ep/asqMDiZk=; b=TQK5iG/7ibfodsiCXURCfUt9stc1W0OW4XjYHTX5F8y+6Log2X23qnlT9OECpO3c0G dE4JKq3p88YmMIAspLqQdTPK0ikWsY0MTGTRcL5VWiyRVcjf0q99vp6K+a1SUyg553hm g4w23YTJcobsN7sR+JlvRb035j6aV6HlbGX2Zdc6lVy3KJm0KCt1ir9Ii4DkhyV1twKK vrw8vwrfHE3V05DzQFby8eawuTsUGP1/SssDxThdFkPmOwoLqiOjLQVjnkMAsAra9oF1 aEweWPi7EfxrVpfUcHTaqqV0Bk1z/97FwfYXF92C4HH4HrLJvrdwspbJ3z5XUaV+deKY /lbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RUgiA6Oi5P+ooqWxIlZ6MCSz3k6th6h8Ep/asqMDiZk=; b=wiGuPN85xpHtnOtxcECPGGmkTcVoXQBl0k9txsbXeO60QkROtUiLCpnI1vIbhkSYRJ MnWX3ghPmg3UNLU7K7/UwqHU07HAWN5tmls0+vzvUBM60ZJGTLLxgWNcVYs0NeGZ70M0 NRNUeNYSSaEM1/KkkAHrtXdSlDcbP2WSkL6BuOng9guePdXtA+vifqmYFDiUxF/5m7VA MadHMaIQkfhanigup55OUF31ZyMn+wMK0j0mdLBv/fFzbfPSoWVWNSIDeoqroc37jEPa hnKGvK0VVwWoWEnXJ+yeRLlNsLFn5+WUU0D65Ov4ceDK3F5X0/ERQxM4N8BzweOuoZ/K RlpQ== X-Gm-Message-State: AOAM530t2xkkuTsPZ/Mwf3Th+bTtk9s/2ghvwydmd9tBWI6NBZ25sYbw UVEXtgSC1lt+K1M2roREd5nI/esDn2Pkfg== X-Google-Smtp-Source: ABdhPJxBWfDWYSasqy/+xlTVzxVzp0+ePG7yF2hk9doNrK3b1cK4g95WlD9nlIjb5SNqs4cQQVQY9Q== X-Received: by 2002:a17:902:768c:b0:155:e4a2:1f09 with SMTP id m12-20020a170902768c00b00155e4a21f09mr24065967pll.43.1650997378805; Tue, 26 Apr 2022 11:22:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 55/68] target/nios2: Use tcg_gen_lookup_and_goto_ptr Date: Tue, 26 Apr 2022 11:18:54 -0700 Message-Id: <20220426181907.103691-56-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000768743100001 Content-Type: text/plain; charset="utf-8" Use lookup_and_goto_ptr for indirect chaining between TBs. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-52-richard.henderson@linaro.org> --- target/nios2/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 87f3e57d4c..a3e87beba4 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -190,7 +190,7 @@ static void gen_goto_tb(DisasContext *dc, int n, uint32= _t dest) tcg_gen_exit_tb(tb, n); } else { tcg_gen_movi_tl(cpu_pc, dest); - tcg_gen_exit_tb(NULL, 0); + tcg_gen_lookup_and_goto_ptr(); } dc->base.is_jmp =3D DISAS_NORETURN; } @@ -201,7 +201,7 @@ static void gen_jumpr(DisasContext *dc, int regno, bool= is_call) if (is_call) { tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); } - tcg_gen_exit_tb(NULL, 0); + tcg_gen_lookup_and_goto_ptr(); dc->base.is_jmp =3D DISAS_NORETURN; } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650999615; cv=none; d=zohomail.com; s=zohoarc; b=LBA+H408FnuUFBGQunZ7IqpUX6WGvcFoB7tsgrDcdcrjtgMWtjSf0/S8f1d83UjknyeBvHgDGz7S6ivmujsU+oxQl7DwVMDtnU5kXqXx9WjwQ/56AlguQmB1OUSVXxSQHtUxd6vBEpb9rEAdnVfQ5GiSM0EuqRgNNIw+YE0KfHE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650999615; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EjEvoq47mgxbhwOkPjY+lzICTw8tSYJC5nzrZvKsO9E=; b=ABfJXz0jGnLMB8nBWllM7rDaK5mIYz6l1wf1wzp3/41+MPC4pIbfD/pjrGb/W2d0Vmxbhe8Od/4KcPxDytxI/7Ray93c9DoD3wNtPD7u1LDgbfFEewdXXjpLEerDnJnGO+EmdmBlwSCH4r9v1q7PcwkUIZdKSsyCUOkxPqJ4Zjw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650999615322540.991236745618; Tue, 26 Apr 2022 12:00:15 -0700 (PDT) Received: from localhost ([::1]:54762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQQ1-00028k-Tm for importer@patchew.org; Tue, 26 Apr 2022 15:00:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq3-0001sB-1W for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:37578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq1-0005UD-0S for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:02 -0400 Received: by mail-pl1-x630.google.com with SMTP id b12so16231630plg.4 for ; Tue, 26 Apr 2022 11:23:00 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EjEvoq47mgxbhwOkPjY+lzICTw8tSYJC5nzrZvKsO9E=; b=eUEwaLrbr0Gb8Ot2KghReSEr6GonJrQlWYyYTbuJGg7PYv4IE8KvHQkRCgy6tSep8e 3jVXLQQIpxgqTZI67uP6u9UHwreMmBj6rJRqXqoyelPcbY7PM/3WtvUO4OXPAyrVPQhF 4f2Fa//1P4wVvGnKfJN7ma6CNNM62ZZzTsOuxjbxnAOMgOlj1pTQ31U5sL51cYr5xe6q FJwp7KleYGV1e+0do+3HJyNXLpehDUDDX8rf8rtFhWnro0mbvDV4mVyaWPcHtQIqcLU2 GtDRLh9btaxrNVyKtbpoG1tj2t++SzzJKHsil2j1xsUmUW869S5H3X2Nz/aetabps/ah LuWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EjEvoq47mgxbhwOkPjY+lzICTw8tSYJC5nzrZvKsO9E=; b=16DuyG8dSSB0faM/AOiz0iGPqyWKmJ/l/FYYcfU/1KbYeJibCzCrjsm/0thWQtDjre 0uI6uhwUPQWft6UXhAeCqcFO+xfbVt3yrYMK9W2F4CX2LuzWWxoJt9QFH1EGWnrpowZo t8kxNsxNisg569QLhLTMrZ1JN84AvFN1wpvrVAoI7eq2VS9bIoU64kgrP7B9U0mb4r4V WLs5Vr3p3vMzthyckTGibPE7d5T60l9CId2PYd7gWyd7wsdhvQzICMyJBJgi1klRe93S A0DO2fEt6w7zM5yvtnBhEoq/phtCJhlB5SWrbITPsdYLiX+HnxgxvPYbj3rYGf1DObXb t91Q== X-Gm-Message-State: AOAM533jmEhfDzSB1G0qUwKuYsG6KGifK0uAKDtGZkwhvx15VSSqI1n+ 8wE4L4A27VqhJQvPxS+qrWpUUnX+M8VWHw== X-Google-Smtp-Source: ABdhPJzezMrExOVyPz64mn0rHOwgy878TZdV5DHj5e8+k9x98I5AUrTv2hk1CrlQDzwqrGdgUyFarw== X-Received: by 2002:a17:902:eb91:b0:15d:1f88:d993 with SMTP id q17-20020a170902eb9100b0015d1f88d993mr9128891plg.17.1650997379656; Tue, 26 Apr 2022 11:22:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 56/68] target/nios2: Implement Misaligned destination exception Date: Tue, 26 Apr 2022 11:18:55 -0700 Message-Id: <20220426181907.103691-57-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650999616857100001 Content-Type: text/plain; charset="utf-8" Indirect branches, plus eret and bret optionally raise an exception when branching to a misaligned address. The exception is required when an mmu is enabled, but enable it always because the fallback behaviour is not documented (though presumably it discards low bits). For the purposes of the linux-user cpu loop, if EXCP_UNALIGN (misaligned data) were to arrive, it would be treated the same as EXCP_UNALIGND (misaligned destination). See the !defined(CONFIG_NIOS2_ALIGNMENT_TRAP) block in kernel/traps.c. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-53-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 6 ++++++ target/nios2/op_helper.c | 9 ++++++++- target/nios2/translate.c | 15 ++++++++++++++- 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 11ecb71843..30a27f252b 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -42,6 +42,12 @@ void cpu_loop(CPUNios2State *env) force_sig_fault(TARGET_SIGFPE, TARGET_FPE_INTDIV, env->pc); break; =20 + case EXCP_UNALIGN: + case EXCP_UNALIGND: + force_sig_fault(TARGET_SIGBUS, TARGET_BUS_ADRALN, + env->ctrl[CR_BADADDR]); + break; + case EXCP_TRAP: /* * TODO: This advance should be done in the translator, as diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index a19b504b0e..38a71a1f2d 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -64,6 +64,13 @@ uint32_t helper_divu(CPUNios2State *env, uint32_t num, u= int32_t den) void helper_eret(CPUNios2State *env, uint32_t new_status, uint32_t new_pc) { Nios2CPU *cpu =3D env_archcpu(env); + CPUState *cs =3D env_cpu(env); + + if (unlikely(new_pc & 3)) { + env->ctrl[CR_BADADDR] =3D new_pc; + cs->exception_index =3D EXCP_UNALIGND; + cpu_loop_exit_restore(cs, GETPC()); + } =20 /* * Both estatus and bstatus have no constraints on write; @@ -74,6 +81,6 @@ void helper_eret(CPUNios2State *env, uint32_t new_status,= uint32_t new_pc) =20 env->ctrl[CR_STATUS] =3D new_status; env->pc =3D new_pc; - cpu_loop_exit(env_cpu(env)); + cpu_loop_exit(cs); } #endif /* !CONFIG_USER_ONLY */ diff --git a/target/nios2/translate.c b/target/nios2/translate.c index a3e87beba4..794b763d8a 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -197,11 +197,24 @@ static void gen_goto_tb(DisasContext *dc, int n, uint= 32_t dest) =20 static void gen_jumpr(DisasContext *dc, int regno, bool is_call) { - tcg_gen_mov_tl(cpu_pc, load_gpr(dc, regno)); + TCGLabel *l =3D gen_new_label(); + TCGv test =3D tcg_temp_new(); + TCGv dest =3D load_gpr(dc, regno); + + tcg_gen_andi_tl(test, dest, 3); + tcg_gen_brcondi_tl(TCG_COND_NE, test, 0, l); + tcg_temp_free(test); + + tcg_gen_mov_tl(cpu_pc, dest); if (is_call) { tcg_gen_movi_tl(dest_gpr(dc, R_RA), dc->base.pc_next); } tcg_gen_lookup_and_goto_ptr(); + + gen_set_label(l); + tcg_gen_st_tl(dest, cpu_env, offsetof(CPUNios2State, ctrl[CR_BADADDR])= ); + t_gen_helper_raise_exception(dc, EXCP_UNALIGND); + dc->base.is_jmp =3D DISAS_NORETURN; } =20 --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000611; cv=none; d=zohomail.com; s=zohoarc; b=narJQrPxu90X1kdWCvQorMwMZUVAQkbbr7pbRSp04xVJ5B6O3Ccm/sa1xrXWJ3IV4c5GdLDDk+7Nbp/MNuE/PB3fR6GxxyRmvIzpWK0/dMzZY46s0AlGygEe3IKvphiIzmJnPtmsDZJsJXE1Y+3ltVxYUnCOGNqvrNmMI31dsEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000611; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WyhHAN4kOdv5SP0UNYKZ/8CoTfSLfS0tLNbV671G8UI=; b=Zipsc4k1gUHRoqrPhCtX6iIiYWQnmAmUreEN1dXAS0hk8pFsAn0n9j5OMBAAjMv/J2W90MSUBMxVbhDvgtq/1YWVfavZckqy1jx7wKBedRguCgFx8psd2csVkeLZLmRNTGyRytbcATc9Cw9J25fMl4B0WqeEA06QaOFgGopo8fI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651000611509401.16906076356895; Tue, 26 Apr 2022 12:16:51 -0700 (PDT) Received: from localhost ([::1]:37814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQg5-0004C9-P5 for importer@patchew.org; Tue, 26 Apr 2022 15:16:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq4-0001sD-IN for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:46063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq2-0005V0-My for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: by mail-pj1-x1034.google.com with SMTP id n33-20020a17090a5aa400b001d28f5ee3f9so3275232pji.4 for ; Tue, 26 Apr 2022 11:23:01 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WyhHAN4kOdv5SP0UNYKZ/8CoTfSLfS0tLNbV671G8UI=; b=YwOMQoQnHGljzXhFZfPtKbCkJ8FJBDmaf07NbGUd6cP1xTibHqeP1Dw13FCkLnBqhY LCJX4IqKh6BL+eyh2yLdWRHNLFyelp7UW6nFtswI2pT4sgxS8z3Dq1P8K36HEVSIhNtw PhmL07AwY8xdEItJFg4soDVHvZGR5vrIwTAHDUwO8c8MPJWQNcTHUfuMzQCFjVIL3vyR LZoEY1vQB4yU+7HOqxTr4WjrFpIfjJ8pqJl2Qqcbd++GSIQ3/pbnWbZgVEZ4B1S7AkS6 eAFH1MKBMCWhQU+FlGnSwdgo0tJ8SE/dbBrBSygYABVhAM0cQ9EyrekBwrU3njMqqIgh xIpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WyhHAN4kOdv5SP0UNYKZ/8CoTfSLfS0tLNbV671G8UI=; b=RZWb4qvZsBfqxg//o/CNHK11e3xzUtTSgpJJooYyXZRupeQNPG1KneYQz7NkWX9YoS r8nay0KGdxTruVs/c4GtM4PRM1J1WCWxM56ukuRpQ93WRi9JMLcipiYRKwTw13RuInbU 0fmHu4EGQ5EopGKl3sefFl96/O/mPd0p0X4p9hxUXVVzr1XEvzKyBjMi6LMou3us17qU RfaS8SIx9uXCL6ZGMEF/hvwy5WEdqs4PfkEQ1M2r3ro73jOKWeS0LnLwo1Cvx0Kg4ihU tmncNJvo9L2ASAb+ucnD9xH/xfWkPz+oH+3rj5H2tgT9/9ZdZ7upYS59CXpjBiUPdTxT Sz0Q== X-Gm-Message-State: AOAM5310DR/B1ePtiC6Mc3hbdHbvAiYlgKi5iwGycdq4sJ3FuxRJyBwo arNUhfNyeoCWGXsEs7/htdDPmZzfqvWiVA== X-Google-Smtp-Source: ABdhPJxp/hEFdTIvjFR5D1YvFX8xz3GDotrcrEzwHtknMVbjJT3t0OIeqell4tqaFCL2s5ke0oII8w== X-Received: by 2002:a17:902:8608:b0:158:c532:d8b2 with SMTP id f8-20020a170902860800b00158c532d8b2mr24668327plo.46.1650997380700; Tue, 26 Apr 2022 11:23:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 57/68] target/nios2: Introduce shadow register sets Date: Tue, 26 Apr 2022 11:18:56 -0700 Message-Id: <20220426181907.103691-58-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000612018100001 Content-Type: text/plain; charset="utf-8" Do not actually enable them so far, in terms of being able to change the current register set, but add all of the plumbing to address them. Do not enable them for user-only. Add an env->regs pointer that handles the indirection to the current register set. The naming of the pointer hides the difference between old and new, user-only and sysemu. From the notes on wrprs, which states that r0 must be initialized before use in shadow register sets, infer that R_ZERO is *not* hardwired to zero in shadow register sets, but that it is still read-only. Introduce tbflags bit R0_0 to track that it has been properly set to zero. Adjust load_gpr to reflect this. At the same time we might as well special case crs =3D=3D 0 to avoid the indirection through env->regs during translation as well; this is intended to be the most common case for non-interrupt handlers. Init env->regs at reset. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-54-richard.henderson@linaro.org> --- target/nios2/cpu.h | 29 ++++++++++++++++++- target/nios2/cpu.c | 4 ++- target/nios2/translate.c | 61 ++++++++++++++++++++++++++++++++++------ 3 files changed, 83 insertions(+), 11 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 477a661f17..f6efaa79b3 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -60,6 +60,11 @@ struct Nios2CPUClass { #define NUM_GP_REGS 32 #define NUM_CR_REGS 32 =20 +#ifndef CONFIG_USER_ONLY +/* 63 shadow register sets; index 0 is the primary register set. */ +#define NUM_REG_SETS 64 +#endif + /* General purpose register aliases */ enum { R_ZERO =3D 0, @@ -178,7 +183,13 @@ FIELD(CR_TLBMISC, EE, 24, 1) #define EXCP_MPUD 17 =20 struct CPUArchState { +#ifdef CONFIG_USER_ONLY uint32_t regs[NUM_GP_REGS]; +#else + uint32_t shadow_regs[NUM_REG_SETS][NUM_GP_REGS]; + /* Pointer into shadow_regs for the current register set. */ + uint32_t *regs; +#endif uint32_t ctrl[NUM_CR_REGS]; uint32_t pc; =20 @@ -229,6 +240,14 @@ static inline bool nios2_cr_reserved(const ControlRegS= tate *s) return (s->writable | s->readonly) =3D=3D 0; } =20 +static inline void nios2_update_crs(CPUNios2State *env) +{ +#ifndef CONFIG_USER_ONLY + unsigned crs =3D FIELD_EX32(env->ctrl[CR_STATUS], CR_STATUS, CRS); + env->regs =3D env->shadow_regs[crs]; +#endif +} + void nios2_tcg_init(void); void nios2_cpu_do_interrupt(CPUState *cs); void dump_mmu(CPUNios2State *env); @@ -267,12 +286,20 @@ typedef Nios2CPU ArchCPU; =20 #include "exec/cpu-all.h" =20 +FIELD(TBFLAGS, CRS0, 0, 1) /* Set if CRS =3D=3D 0. */ +FIELD(TBFLAGS, U, 1, 1) /* Overlaps CR_STATUS_U */ +FIELD(TBFLAGS, R0_0, 2, 1) /* Set if R0 =3D=3D 0. */ + static inline void cpu_get_tb_cpu_state(CPUNios2State *env, target_ulong *= pc, target_ulong *cs_base, uint32_t *f= lags) { + unsigned crs =3D FIELD_EX32(env->ctrl[CR_STATUS], CR_STATUS, CRS); + *pc =3D env->pc; *cs_base =3D 0; - *flags =3D env->ctrl[CR_STATUS] & CR_STATUS_U; + *flags =3D (env->ctrl[CR_STATUS] & CR_STATUS_U) + | (crs ? 0 : R_TBFLAGS_CRS0_MASK) + | (env->regs[0] ? 0 : R_TBFLAGS_R0_0_MASK); } =20 #endif /* NIOS2_CPU_H */ diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 54e7071907..d043c02fcd 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -48,15 +48,17 @@ static void nios2_cpu_reset(DeviceState *dev) =20 ncc->parent_reset(dev); =20 - memset(env->regs, 0, sizeof(env->regs)); memset(env->ctrl, 0, sizeof(env->ctrl)); env->pc =3D cpu->reset_addr; =20 #if defined(CONFIG_USER_ONLY) /* Start in user mode with interrupts enabled. */ env->ctrl[CR_STATUS] =3D CR_STATUS_RSIE | CR_STATUS_U | CR_STATUS_PIE; + memset(env->regs, 0, sizeof(env->regs)); #else env->ctrl[CR_STATUS] =3D CR_STATUS_RSIE; + nios2_update_crs(env); + memset(env->shadow_regs, 0, sizeof(env->shadow_regs)); #endif } =20 diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 794b763d8a..363f2ea3ca 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -127,12 +127,16 @@ typedef struct DisasContext { DisasContextBase base; target_ulong pc; int mem_idx; + uint32_t tb_flags; TCGv sink; const ControlRegState *cr_state; } DisasContext; =20 static TCGv cpu_R[NUM_GP_REGS]; static TCGv cpu_pc; +#ifndef CONFIG_USER_ONLY +static TCGv cpu_crs_R[NUM_GP_REGS]; +#endif =20 typedef struct Nios2Instruction { void (*handler)(DisasContext *dc, uint32_t code, uint32_t flags); @@ -154,22 +158,47 @@ static uint8_t get_opxcode(uint32_t code) static TCGv load_gpr(DisasContext *dc, unsigned reg) { assert(reg < NUM_GP_REGS); - if (unlikely(reg =3D=3D R_ZERO)) { + + /* + * With shadow register sets, register r0 does not necessarily contain= 0, + * but it is overwhelmingly likely that it does -- software is supposed + * to have set r0 to 0 in every shadow register set before use. + */ + if (unlikely(reg =3D=3D R_ZERO) && FIELD_EX32(dc->tb_flags, TBFLAGS, R= 0_0)) { return tcg_constant_tl(0); } - return cpu_R[reg]; + if (FIELD_EX32(dc->tb_flags, TBFLAGS, CRS0)) { + return cpu_R[reg]; + } +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + return cpu_crs_R[reg]; +#endif } =20 static TCGv dest_gpr(DisasContext *dc, unsigned reg) { assert(reg < NUM_GP_REGS); + + /* + * The spec for shadow register sets isn't clear, but we assume that + * writes to r0 are discarded regardless of CRS. + */ if (unlikely(reg =3D=3D R_ZERO)) { if (dc->sink =3D=3D NULL) { dc->sink =3D tcg_temp_new(); } return dc->sink; } - return cpu_R[reg]; + if (FIELD_EX32(dc->tb_flags, TBFLAGS, CRS0)) { + return cpu_R[reg]; + } +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + return cpu_crs_R[reg]; +#endif } =20 static void t_gen_helper_raise_exception(DisasContext *dc, @@ -225,7 +254,7 @@ static void gen_excp(DisasContext *dc, uint32_t code, u= int32_t flags) =20 static bool gen_check_supervisor(DisasContext *dc) { - if (dc->base.tb->flags & CR_STATUS_U) { + if (FIELD_EX32(dc->tb_flags, TBFLAGS, U)) { /* CPU in user mode, privileged instruction called, stop. */ t_gen_helper_raise_exception(dc, EXCP_SUPERI); return false; @@ -335,7 +364,7 @@ static void do_i_math_logic(DisasContext *dc, uint32_t = insn, =20 val =3D imm(&instr); =20 - if (instr.a =3D=3D R_ZERO) { + if (instr.a =3D=3D R_ZERO && FIELD_EX32(dc->tb_flags, TBFLAGS, R0_0)) { /* This catches the canonical expansions of movi and movhi. */ tcg_gen_movi_tl(dest_gpr(dc, instr.b), x_op_0_eq_x ? val : 0); } else { @@ -865,6 +894,7 @@ static void nios2_tr_init_disas_context(DisasContextBas= e *dcbase, CPUState *cs) =20 dc->mem_idx =3D cpu_mmu_index(env, false); dc->cr_state =3D cpu->cr_state; + dc->tb_flags =3D dc->base.tb->flags; =20 /* Bound the number of insns to execute to those left on the page. */ page_insns =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; @@ -999,13 +1029,26 @@ void nios2_cpu_dump_state(CPUState *cs, FILE *f, int= flags) =20 void nios2_tcg_init(void) { - int i; +#ifndef CONFIG_USER_ONLY + TCGv_ptr crs =3D tcg_global_mem_new_ptr(cpu_env, + offsetof(CPUNios2State, regs), "= crs"); =20 - for (i =3D 0; i < NUM_GP_REGS; i++) { - cpu_R[i] =3D tcg_global_mem_new(cpu_env, - offsetof(CPUNios2State, regs[i]), + for (int i =3D 0; i < NUM_GP_REGS; i++) { + cpu_crs_R[i] =3D tcg_global_mem_new(crs, 4 * i, gr_regnames[i]); + } + +#define offsetof_regs0(N) offsetof(CPUNios2State, shadow_regs[0][N]) +#else +#define offsetof_regs0(N) offsetof(CPUNios2State, regs[N]) +#endif + + for (int i =3D 0; i < NUM_GP_REGS; i++) { + cpu_R[i] =3D tcg_global_mem_new(cpu_env, offsetof_regs0(i), gr_regnames[i]); } + +#undef offsetof_regs0 + cpu_pc =3D tcg_global_mem_new(cpu_env, offsetof(CPUNios2State, pc), "pc"); } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000975; cv=none; d=zohomail.com; s=zohoarc; b=nQlA7qUa3B+jzcpejrZ/2pntBw/CEDuVC1mahtrHZHu1OvYwORakcCtG0ZmN6dKy8VQ8yWDbW60C63qkZ3jbnVSNauyeJiGE/ETn7i5pIfidf7pT53HGoaiXGYAd+DYgq/ZY+9LSUdn+Nbt5elh/GB4/o4+ji+89UDOeShKmA0I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000975; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LKJfP1L1JthCk9j8S3dyGmOEwjYZHFg6bDruhwKHIGY=; b=GdyQQuQvyxvp9G0QPCgdBLMnROF7MHPS0gPsB/WxkC/ezMEzfrz15LVfItsmOiAJVcGQPSJImAYB0EQGRP9MtusuYJLvhsrs+oBhxPhAJa0zx2CNfThe2hYRmy5+XX/AaJAcoKaNur07GYWrHsFNKgvmlILsZMwoe44NkTnhKw4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165100097569473.56937104582619; Tue, 26 Apr 2022 12:22:55 -0700 (PDT) Received: from localhost ([::1]:55748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQly-0007mB-IF for importer@patchew.org; Tue, 26 Apr 2022 15:22:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq4-0001sO-VB for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:05 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:36354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq3-0005Vj-3l for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:04 -0400 Received: by mail-pf1-x42c.google.com with SMTP id z16so18714118pfh.3 for ; Tue, 26 Apr 2022 11:23:02 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LKJfP1L1JthCk9j8S3dyGmOEwjYZHFg6bDruhwKHIGY=; b=KLzTVlDDlO/eP7fMCfK+b8S6NioFcL0w2Q7BUY0ihqwO0PQkV0YyvWSCKWBkyEo7GR Zei485bLbrOzsRyjsFWPUMs3/A32JyBpX+P7e/n1hjuGCKwjn51XP23ny0RJLsbTZB1l NEKlxSAqdMwsbbA8rSDld5nyLDLARMzYtI1u5xIcvhZpFR9vteyHZDvrdSQVidWRa7vy Qk21dXTR4PZT3nhKGj6FzmS/HaO7DRdHDWx0tSCztCNBNQh78tLDzVF3nG42VKpXUiTk +04qLvw6fnx7ik+woT7VgWbqkFbb1PGH81mKNwQvJhWAQTG6bRLMiRHGgqiRbLxpX4Xv kiBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LKJfP1L1JthCk9j8S3dyGmOEwjYZHFg6bDruhwKHIGY=; b=RMEZ22tQ8S6pxkIVziQ9cwzpAKb/FcVHIGSoTxX4JS/EIRbs9Ac2+L74vlsdQoQEX0 gaABen3gbwL+MxG6S4FcHERkzPiacDJ2qYj3Gg2tgRMya153f3VoVHLagmWO/Y3ZvN4a C7BVFzYlzsavigBLhFElNHMPMKtg50Hs/8vtCPQESbU4tB/sdaSdOGjbRsD7ZhIEsMtJ ZOxawPfkQqNplkUcKbQQJJJ3OpNpl+M4HWqf2RbfT5F8gTVlLuiKA/XU6ay5HQXz6h6C M9OpfgeY212xe1aEYBOk7e3nnwPDWoYpbwkoD1IaqwDylQvl8CKOjwyhjGC3jPoDFTCg Xgvw== X-Gm-Message-State: AOAM5328xXzF6QI4dc1P0OF3o6G7MSjZdRf9uG48lSW+TKmqDrxuM1Ol 1ucD3KP7ZgllQ3rZe2XO+PZ4ssjAwaFczw== X-Google-Smtp-Source: ABdhPJyNVzcOjPblukPvrkDP0KKgfET2Pzf1c2D77TMfKXpJ8GpbpHerZ4eFcMOI0mQTOPTnQwp8mA== X-Received: by 2002:a62:d155:0:b0:50d:3c4e:37ec with SMTP id t21-20020a62d155000000b0050d3c4e37ecmr12942254pfl.60.1650997381663; Tue, 26 Apr 2022 11:23:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 58/68] target/nios2: Implement rdprs, wrprs Date: Tue, 26 Apr 2022 11:18:57 -0700 Message-Id: <20220426181907.103691-59-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000976238100001 Content-Type: text/plain; charset="utf-8" Implement these out of line, so that tcg global temps (aka the architectural registers) are synced back to tcg storage as required. This makes sure that we get the proper results when status.PRS =3D=3D status.CRS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-55-richard.henderson@linaro.org> --- target/nios2/cpu.h | 1 + target/nios2/helper.h | 2 ++ target/nios2/op_helper.c | 16 +++++++++++ target/nios2/translate.c | 57 ++++++++++++++++++++++++++++++++++++++-- 4 files changed, 74 insertions(+), 2 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index f6efaa79b3..cca821cf80 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -220,6 +220,7 @@ struct ArchCPU { =20 bool diverr_present; bool mmu_present; + bool eic_present; =20 uint32_t pid_num_bits; uint32_t tlb_num_ways; diff --git a/target/nios2/helper.h b/target/nios2/helper.h index 6f5ec60b0d..1648d76ade 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -24,6 +24,8 @@ DEF_HELPER_FLAGS_3(divu, TCG_CALL_NO_WG, i32, env, i32, i= 32) =20 #if !defined(CONFIG_USER_ONLY) DEF_HELPER_3(eret, noreturn, env, i32, i32) +DEF_HELPER_FLAGS_2(rdprs, TCG_CALL_NO_WG, i32, env, i32) +DEF_HELPER_3(wrprs, void, env, i32, i32) DEF_HELPER_2(mmu_write_tlbacc, void, env, i32) DEF_HELPER_2(mmu_write_tlbmisc, void, env, i32) DEF_HELPER_2(mmu_write_pteaddr, void, env, i32) diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index 38a71a1f2d..a3164f5356 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -83,4 +83,20 @@ void helper_eret(CPUNios2State *env, uint32_t new_status= , uint32_t new_pc) env->pc =3D new_pc; cpu_loop_exit(cs); } + +/* + * RDPRS and WRPRS are implemented out of line so that if PRS =3D=3D CRS, + * all of the tcg global temporaries are synced back to ENV. + */ +uint32_t helper_rdprs(CPUNios2State *env, uint32_t regno) +{ + unsigned prs =3D FIELD_EX32(env->ctrl[CR_STATUS], CR_STATUS, PRS); + return env->shadow_regs[prs][regno]; +} + +void helper_wrprs(CPUNios2State *env, uint32_t regno, uint32_t val) +{ + unsigned prs =3D FIELD_EX32(env->ctrl[CR_STATUS], CR_STATUS, PRS); + env->shadow_regs[prs][regno] =3D val; +} #endif /* !CONFIG_USER_ONLY */ diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 363f2ea3ca..e566175db5 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -130,6 +130,7 @@ typedef struct DisasContext { uint32_t tb_flags; TCGv sink; const ControlRegState *cr_state; + bool eic_present; } DisasContext; =20 static TCGv cpu_R[NUM_GP_REGS]; @@ -387,6 +388,27 @@ gen_i_math_logic(andhi, andi, 0, imm_shifted) gen_i_math_logic(orhi , ori, 1, imm_shifted) gen_i_math_logic(xorhi, xori, 1, imm_shifted) =20 +/* rB <- prs.rA + sigma(IMM16) */ +static void rdprs(DisasContext *dc, uint32_t code, uint32_t flags) +{ + if (!dc->eic_present) { + t_gen_helper_raise_exception(dc, EXCP_ILLEGAL); + return; + } + if (!gen_check_supervisor(dc)) { + return; + } + +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + I_TYPE(instr, code); + TCGv dest =3D dest_gpr(dc, instr.b); + gen_helper_rdprs(dest, cpu_env, tcg_constant_i32(instr.a)); + tcg_gen_addi_tl(dest, dest, instr.imm16.s); +#endif +} + /* Prototype only, defined below */ static void handle_r_type_instr(DisasContext *dc, uint32_t code, uint32_t flags); @@ -448,7 +470,7 @@ static const Nios2Instruction i_type_instructions[] =3D= { INSTRUCTION_FLG(gen_stx, MO_SL), /* stwio */ INSTRUCTION_FLG(gen_bxx, TCG_COND_LTU), /* bltu */ INSTRUCTION_FLG(gen_ldx, MO_UL), /* ldwio */ - INSTRUCTION_UNIMPLEMENTED(), /* rdprs */ + INSTRUCTION(rdprs), /* rdprs */ INSTRUCTION_ILLEGAL(), INSTRUCTION_FLG(handle_r_type_instr, 0), /* R-Type */ INSTRUCTION_NOP(), /* flushd */ @@ -648,6 +670,36 @@ static void wrctl(DisasContext *dc, uint32_t code, uin= t32_t flags) #endif } =20 +/* prs.rC <- rA */ +static void wrprs(DisasContext *dc, uint32_t code, uint32_t flags) +{ + if (!dc->eic_present) { + t_gen_helper_raise_exception(dc, EXCP_ILLEGAL); + return; + } + if (!gen_check_supervisor(dc)) { + return; + } + +#ifdef CONFIG_USER_ONLY + g_assert_not_reached(); +#else + R_TYPE(instr, code); + gen_helper_wrprs(cpu_env, tcg_constant_i32(instr.c), + load_gpr(dc, instr.a)); + /* + * The expected write to PRS[r0] is 0, from CRS[r0]. + * If not, and CRS =3D=3D PRS (which we cannot tell from here), + * we may now have a non-zero value in our current r0. + * By ending the TB, we re-evaluate tb_flags and find out. + */ + if (instr.c =3D=3D 0 + && (instr.a !=3D 0 || !FIELD_EX32(dc->tb_flags, TBFLAGS, R0_0))) { + dc->base.is_jmp =3D DISAS_UPDATE; + } +#endif +} + /* Comparison instructions */ static void gen_cmpxx(DisasContext *dc, uint32_t code, uint32_t flags) { @@ -793,7 +845,7 @@ static const Nios2Instruction r_type_instructions[] =3D= { INSTRUCTION_ILLEGAL(), INSTRUCTION(slli), /* slli */ INSTRUCTION(sll), /* sll */ - INSTRUCTION_UNIMPLEMENTED(), /* wrprs */ + INSTRUCTION(wrprs), /* wrprs */ INSTRUCTION_ILLEGAL(), INSTRUCTION(or), /* or */ INSTRUCTION(mulxsu), /* mulxsu */ @@ -895,6 +947,7 @@ static void nios2_tr_init_disas_context(DisasContextBas= e *dcbase, CPUState *cs) dc->mem_idx =3D cpu_mmu_index(env, false); dc->cr_state =3D cpu->cr_state; dc->tb_flags =3D dc->base.tb->flags; + dc->eic_present =3D cpu->eic_present; =20 /* Bound the number of insns to execute to those left on the page. */ page_insns =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001030; cv=none; d=zohomail.com; s=zohoarc; b=EzRRmstSCCufi7rJC6tWhYYbf6J1h8/xeN3iaUtSQm7w5LK1Hu66mp1FEGE74DtK72/yzWTxWd8M4pqRGt0Sb446hCDoHKvTPWJDsLqAwwmBXO5TQ10L3DogIgq60HziX6Pgj9y+zsaIeyYgGfBCrlf61vTmlSlWF5No6KZufK8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001030; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f3naWy5W9s9QUNBHvEd2IV7OasikpkGCP8dcpLW6o6A=; b=jfmDRjRRaAVIia2xIz+bF8wiQIA4S3QMqt/n0/Bc5LEsdOddJND9y/I6/L/f//yLOi8/Z5tzIrdQ0NkovWrJTP0Kehgbf11GYifGS8G9zSv7kAlI9amlibJ+0mYlcUQj5R+9rnPoNg0kUZtLLo0KVYs3YKtcPuHrSpcVprC6gFg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001030748293.6139845489482; Tue, 26 Apr 2022 12:23:50 -0700 (PDT) Received: from localhost ([::1]:58526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQmr-0001Cw-95 for importer@patchew.org; Tue, 26 Apr 2022 15:23:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq6-0001wJ-6x for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:06 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:43618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq3-0005WD-N2 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:05 -0400 Received: by mail-pl1-x632.google.com with SMTP id d15so30989882pll.10 for ; Tue, 26 Apr 2022 11:23:03 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f3naWy5W9s9QUNBHvEd2IV7OasikpkGCP8dcpLW6o6A=; b=r+ZcJTyedtMurRSO1bGPvTL5hY5ZnQoqRVK+OQEKtIIs6Ph4kOpF5vqK0p4JfG8/Uu bSscVyeRjN619oO+8bXVcp6M3f6HsaTUCd8GvRIOWtg/WM52O+QszbF4IwgoP8H7ZWiA ntnLq37uVgace2xvjxujo0Pnizt97fDAAxQgZuP/lYgvyAykVk3LTmXOwGcjoJ+4OmbQ Vxiw+FAHSXoeDNvcug8ngAhi2E1+tCSMaMKvg0l1LO0QYidG2pXOWIcNa11WxlD5Leg/ 1YVvbizpgWxkkrYLQswoxiW6eiFZzNhyLGkHESbinyhT1K8DvyWFG4B0E6L3Fhj+t1DR fQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f3naWy5W9s9QUNBHvEd2IV7OasikpkGCP8dcpLW6o6A=; b=Uf2jHfgkRWbZhJEV1+uhbK27FLJeUZMHZUb4mg3nUm1AU9cN3h7Ti0Wg3WBWbZc9kO 9RRUQfQQT9kRFTnAzyctoEr/wdUwmxeolkgg2/ppanI+YNcTTuyF8zKKCaJoXMbWuTKe j7nmBYbAMmNNoLzEJ5xEsJEd2i7QT/RxVTaF7bCPErhtSuYfuAGp52PaeS2ECNRCH2je Xn5eTQYLiF/RUdmMWwN8rQ20VlKO9ZbSwmoHJzGqsJqrp4TSaGsOROovN1Xum9s0EN1M ayZZjTuT9rraAsGu1ROFf6628DpqfbJH1mAokDVukNuXlGuhHW9RSob6hsGpiQXJra7Q 28Cg== X-Gm-Message-State: AOAM531NQlreYdfMY3ofVKJih7zl/uNKEc7ZpPJVE3h3WDeBmzkPkw6w /ZsRunVHPjdPnh922PZkchfRZG7fkp+0bg== X-Google-Smtp-Source: ABdhPJz5qkjWM14ucxkvFtpXDxB1wjtLX7P3nfXcBBdoojSBO0gBcnthVo83p/gGseesgjiAcLMuxQ== X-Received: by 2002:a17:902:e34b:b0:15d:4d1:614 with SMTP id p11-20020a170902e34b00b0015d04d10614mr13877277plc.14.1650997382476; Tue, 26 Apr 2022 11:23:02 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 59/68] target/nios2: Update helper_eret for shadow registers Date: Tue, 26 Apr 2022 11:18:58 -0700 Message-Id: <20220426181907.103691-60-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001032573100001 Content-Type: text/plain; charset="utf-8" When CRS =3D 0, we restore from estatus; otherwise from sstatus. Update for the new CRS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-56-richard.henderson@linaro.org> --- target/nios2/cpu.h | 1 + target/nios2/op_helper.c | 10 +++++++--- target/nios2/translate.c | 13 ++++++++----- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index cca821cf80..eb171a33e6 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -82,6 +82,7 @@ enum { R_FP =3D 28, R_EA =3D 29, R_BA =3D 30, + R_SSTATUS =3D 30, R_RA =3D 31, }; =20 diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index a3164f5356..94040102f4 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -73,14 +73,18 @@ void helper_eret(CPUNios2State *env, uint32_t new_statu= s, uint32_t new_pc) } =20 /* - * Both estatus and bstatus have no constraints on write; + * None of estatus, bstatus, or sstatus have constraints on write; * do not allow reserved fields in status to be set. - * TODO: more than this is required for shadow registers. + * When shadow registers are enabled, eret *does* restore CRS. + * Rather than testing eic_present to decide, mask CRS out of + * the set of readonly fields. */ - new_status &=3D cpu->cr_state[CR_STATUS].writable; + new_status &=3D cpu->cr_state[CR_STATUS].writable | + (cpu->cr_state[CR_STATUS].readonly & R_CR_STATUS_CRS_MAS= K); =20 env->ctrl[CR_STATUS] =3D new_status; env->pc =3D new_pc; + nios2_update_crs(env); cpu_loop_exit(cs); } =20 diff --git a/target/nios2/translate.c b/target/nios2/translate.c index e566175db5..b52f98180d 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -496,11 +496,14 @@ static void eret(DisasContext *dc, uint32_t code, uin= t32_t flags) #ifdef CONFIG_USER_ONLY g_assert_not_reached(); #else - TCGv tmp =3D tcg_temp_new(); - tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_ESTATUS])); - gen_helper_eret(cpu_env, tmp, load_gpr(dc, R_EA)); - tcg_temp_free(tmp); - + if (FIELD_EX32(dc->tb_flags, TBFLAGS, CRS0)) { + TCGv tmp =3D tcg_temp_new(); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPUNios2State, ctrl[CR_ESTATU= S])); + gen_helper_eret(cpu_env, tmp, load_gpr(dc, R_EA)); + tcg_temp_free(tmp); + } else { + gen_helper_eret(cpu_env, load_gpr(dc, R_SSTATUS), load_gpr(dc, R_E= A)); + } dc->base.is_jmp =3D DISAS_NORETURN; #endif } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001204; cv=none; d=zohomail.com; s=zohoarc; b=du6MmgBdShxu5U9XVvYVrJuTIwe4cE35TLQFHKufTX5G+T0JQkINkPyn5BdEHZfxclWq3WLUOkTe/kzW4JX5r3iLoULpWrHIBd77iPbe6zEJAsOGEo06t38CCEctHeH1GQnZp03TL6XSjGxhr+ndCNIpwULzm4tZ+KfYZ8hSzl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001204; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gvOrFvBE98DeoM6VCwJFK5z8shR3DGS8mknWCcWIlII=; b=GXxrTOHuDh//kW3rxSPh1dzcKr5ya6TmcJCsUhpmiPOXVxvl+0OvvN6K6BDFqdQYOTTWxLeUotIi54BIm46aKn1nvW1kP871VtSiP+p/JxozT0Y4Q83cN+7w8e82Fpl18KgQCmZVK9itstpJHTnDUcIm4P+jc6kWPuaqpCgsK+8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001204555537.7845053772071; Tue, 26 Apr 2022 12:26:44 -0700 (PDT) Received: from localhost ([::1]:37222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQpf-0005sn-G5 for importer@patchew.org; Tue, 26 Apr 2022 15:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq6-0001y7-OQ for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:06 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:45817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq4-0005Wj-J1 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:06 -0400 Received: by mail-pg1-x535.google.com with SMTP id k29so16711363pgm.12 for ; Tue, 26 Apr 2022 11:23:04 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gvOrFvBE98DeoM6VCwJFK5z8shR3DGS8mknWCcWIlII=; b=XmAj/wkwepVDJ9tC70Ni+WbPqWbSU/efVStdaZ3dTYpqDVUewvEbL3Jq1r0o5j8JlW LL7aRMHE3HDedTo5mAJ2tyDuD5huf/mjuDVKhexRjfZN48qXPvtL8fulQ5FAxum/SrNL d/IEsSU6OZ2IDohzUN+jmlFX0yCskS69BU7tFa/rZOzD2byNK9Xy1DoYQG4uI3DEq5hx wSzpe9swAEW+seL9d0RumZNt33Abm8J+EGF+b4D2NSB6B+EBcDhRd7fay96l4Bg3PC1z Jh7XJoUz91nhZwPSbO9NtvxsVcE7GvIheu1l05ry8OWjj6OnwCOolImItLwv778mqEV2 oU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gvOrFvBE98DeoM6VCwJFK5z8shR3DGS8mknWCcWIlII=; b=RwrLzi4Yb1/5afIaxz3FVHBBsUaKgDpWtxxWAPwe345c8Ehj9oTONc+AUwLnFOhVEy G9Bt3/2xrCQQpfE2vzmtkukxo+iruWEoLDzMM6LXKv/QpG5AY45/PWJuETzCAbqAlyxD O8GxF0VSVOK+Vb9vQVq230bgmqnNpuKM1Qvr5wMQYXkuWvs1qEU75N5g71GQATcoD/wg DAsGcSYdAbR9l+3o2gBsvhaq6Wxqo9J7aBWyrVx6y28ZIz1BS4CBCT2rCZ+mfNep7kt8 Jfk57tUQHTmQvLZLJXK548y0CsLupi8+LUD+DLGTTzHsJizJYlnAzNS5e3vZGD1BEcRg Nsyg== X-Gm-Message-State: AOAM531+7TbG4NS3HAPsU+769Do9cs3HoUHTK7ls72/VjDFcwm0V6RzE QnNr0RJoD9Ados834fQ2zRZzeE3+Eqb+ZA== X-Google-Smtp-Source: ABdhPJxmMD3oCecFBsnCu4+4tYLlqM/88Y8oQqCktRPrjs+5HWE+qyfraJIdtzqjy3oMJCtK0DEn5g== X-Received: by 2002:a05:6a00:b51:b0:50d:5b6b:d66e with SMTP id p17-20020a056a000b5100b0050d5b6bd66emr4438291pfo.22.1650997383203; Tue, 26 Apr 2022 11:23:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 60/68] target/nios2: Implement EIC interrupt processing Date: Tue, 26 Apr 2022 11:18:59 -0700 Message-Id: <20220426181907.103691-61-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001205458100001 Content-Type: text/plain; charset="utf-8" This is the cpu side of the operation. Register one irq line, called EIC. Split out the rather different processing to a separate function. Delay initialization of gpio irqs until realize. We need to provide a window after init in which the board can set eic_present. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-57-richard.henderson@linaro.org> --- target/nios2/cpu.h | 8 ++++ target/nios2/cpu.c | 92 +++++++++++++++++++++++++++++++++---------- target/nios2/helper.c | 51 +++++++++++++++++++++++- 3 files changed, 129 insertions(+), 22 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index eb171a33e6..5474b1c404 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -114,6 +114,7 @@ FIELD(CR_STATUS, CRS, 10, 6) FIELD(CR_STATUS, PRS, 16, 6) FIELD(CR_STATUS, NMI, 22, 1) FIELD(CR_STATUS, RSIE, 23, 1) +FIELD(CR_STATUS, SRS, 31, 1) /* only in sstatus */ =20 #define CR_STATUS_PIE R_CR_STATUS_PIE_MASK #define CR_STATUS_U R_CR_STATUS_U_MASK @@ -121,6 +122,7 @@ FIELD(CR_STATUS, RSIE, 23, 1) #define CR_STATUS_IH R_CR_STATUS_IH_MASK #define CR_STATUS_NMI R_CR_STATUS_NMI_MASK #define CR_STATUS_RSIE R_CR_STATUS_RSIE_MASK +#define CR_STATUS_SRS R_CR_STATUS_SRS_MASK =20 FIELD(CR_EXCEPTION, CAUSE, 2, 5) FIELD(CR_EXCEPTION, ECCFTL, 31, 1) @@ -234,6 +236,12 @@ struct ArchCPU { =20 /* Bits within each control register which are reserved or readonly. */ ControlRegState cr_state[NUM_CR_REGS]; + + /* External Interrupt Controller Interface */ + uint32_t rha; /* Requested handler address */ + uint32_t ril; /* Requested interrupt level */ + uint32_t rrs; /* Requested register set */ + bool rnmi; /* Requested nonmaskable interrupt */ }; =20 =20 diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index d043c02fcd..19b2409974 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -63,7 +63,19 @@ static void nios2_cpu_reset(DeviceState *dev) } =20 #ifndef CONFIG_USER_ONLY -static void nios2_cpu_set_irq(void *opaque, int irq, int level) +static void eic_set_irq(void *opaque, int irq, int level) +{ + Nios2CPU *cpu =3D opaque; + CPUState *cs =3D CPU(cpu); + + if (level) { + cpu_interrupt(cs, CPU_INTERRUPT_HARD); + } else { + cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); + } +} + +static void iic_set_irq(void *opaque, int irq, int level) { Nios2CPU *cpu =3D opaque; CPUNios2State *env =3D &cpu->env; @@ -87,15 +99,6 @@ static void nios2_cpu_initfn(Object *obj) =20 #if !defined(CONFIG_USER_ONLY) mmu_init(&cpu->env); - - /* - * These interrupt lines model the IIC (internal interrupt - * controller). QEMU does not currently support the EIC - * (external interrupt controller) -- if we did it would be - * a separate device in hw/intc with a custom interface to - * the CPU, and boards using it would not wire up these IRQ lines. - */ - qdev_init_gpio_in_named(DEVICE(cpu), nios2_cpu_set_irq, "IRQ", 32); #endif } =20 @@ -128,10 +131,18 @@ static void realize_cr_status(CPUState *cs) RO_REG(CR_EXCEPTION); WR_REG(CR_BADADDR); =20 - /* TODO: These control registers are not present with the EIC. */ - RO_FIELD(CR_STATUS, RSIE); - WR_REG(CR_IENABLE); - RO_REG(CR_IPENDING); + if (cpu->eic_present) { + WR_FIELD(CR_STATUS, RSIE); + RO_FIELD(CR_STATUS, NMI); + WR_FIELD(CR_STATUS, PRS); + RO_FIELD(CR_STATUS, CRS); + WR_FIELD(CR_STATUS, IL); + WR_FIELD(CR_STATUS, IH); + } else { + RO_FIELD(CR_STATUS, RSIE); + WR_REG(CR_IENABLE); + RO_REG(CR_IPENDING); + } =20 if (cpu->mmu_present) { WR_FIELD(CR_STATUS, U); @@ -170,6 +181,14 @@ static void nios2_cpu_realizefn(DeviceState *dev, Erro= r **errp) Nios2CPUClass *ncc =3D NIOS2_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 +#ifndef CONFIG_USER_ONLY + if (cpu->eic_present) { + qdev_init_gpio_in_named(DEVICE(cpu), eic_set_irq, "EIC", 1); + } else { + qdev_init_gpio_in_named(DEVICE(cpu), iic_set_irq, "IRQ", 32); + } +#endif + cpu_exec_realizefn(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); @@ -187,17 +206,48 @@ static void nios2_cpu_realizefn(DeviceState *dev, Err= or **errp) } =20 #ifndef CONFIG_USER_ONLY +static bool eic_take_interrupt(Nios2CPU *cpu) +{ + CPUNios2State *env =3D &cpu->env; + const uint32_t status =3D env->ctrl[CR_STATUS]; + + if (cpu->rnmi) { + return !(status & CR_STATUS_NMI); + } + if (!(status & CR_STATUS_PIE)) { + return false; + } + if (cpu->ril <=3D FIELD_EX32(status, CR_STATUS, IL)) { + return false; + } + if (cpu->rrs !=3D FIELD_EX32(status, CR_STATUS, CRS)) { + return true; + } + return status & CR_STATUS_RSIE; +} + +static bool iic_take_interrupt(Nios2CPU *cpu) +{ + CPUNios2State *env =3D &cpu->env; + + if (!(env->ctrl[CR_STATUS] & CR_STATUS_PIE)) { + return false; + } + return env->ctrl[CR_IPENDING] & env->ctrl[CR_IENABLE]; +} + static bool nios2_cpu_exec_interrupt(CPUState *cs, int interrupt_request) { Nios2CPU *cpu =3D NIOS2_CPU(cs); - CPUNios2State *env =3D &cpu->env; =20 - if ((interrupt_request & CPU_INTERRUPT_HARD) && - (env->ctrl[CR_STATUS] & CR_STATUS_PIE) && - (env->ctrl[CR_IPENDING] & env->ctrl[CR_IENABLE])) { - cs->exception_index =3D EXCP_IRQ; - nios2_cpu_do_interrupt(cs); - return true; + if (interrupt_request & CPU_INTERRUPT_HARD) { + if (cpu->eic_present + ? eic_take_interrupt(cpu) + : iic_take_interrupt(cpu)) { + cs->exception_index =3D EXCP_IRQ; + nios2_cpu_do_interrupt(cs); + return true; + } } return false; } diff --git a/target/nios2/helper.c b/target/nios2/helper.c index 2e9fea4a01..e256d1528e 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -37,6 +37,10 @@ static void do_exception(Nios2CPU *cpu, uint32_t excepti= on_addr, uint32_t old_status =3D env->ctrl[CR_STATUS]; uint32_t new_status =3D old_status; =20 + /* With shadow regs, exceptions are always taken into CRS 0. */ + new_status &=3D ~R_CR_STATUS_CRS_MASK; + env->regs =3D env->shadow_regs[0]; + if ((old_status & CR_STATUS_EH) =3D=3D 0) { int r_ea =3D R_EA, cr_es =3D CR_ESTATUS; =20 @@ -60,6 +64,14 @@ static void do_exception(Nios2CPU *cpu, uint32_t excepti= on_addr, CR_TLBMISC_DBL); env->ctrl[CR_TLBMISC] |=3D tlbmisc_set; } + + /* + * With shadow regs, and EH =3D=3D 0, PRS is set from CRS. + * At least, so says Table 3-9, and some other text, + * though Table 3-38 says otherwise. + */ + new_status =3D FIELD_DP32(new_status, CR_STATUS, PRS, + FIELD_EX32(old_status, CR_STATUS, CRS)); } =20 new_status &=3D ~(CR_STATUS_PIE | CR_STATUS_U); @@ -77,6 +89,39 @@ static void do_iic_irq(Nios2CPU *cpu) do_exception(cpu, cpu->exception_addr, 0, false); } =20 +static void do_eic_irq(Nios2CPU *cpu) +{ + CPUNios2State *env =3D &cpu->env; + uint32_t old_status =3D env->ctrl[CR_STATUS]; + uint32_t new_status =3D old_status; + uint32_t old_rs =3D FIELD_EX32(old_status, CR_STATUS, CRS); + uint32_t new_rs =3D cpu->rrs; + + new_status =3D FIELD_DP32(new_status, CR_STATUS, CRS, new_rs); + new_status =3D FIELD_DP32(new_status, CR_STATUS, IL, cpu->ril); + new_status =3D FIELD_DP32(new_status, CR_STATUS, NMI, cpu->rnmi); + new_status &=3D ~(CR_STATUS_RSIE | CR_STATUS_U); + new_status |=3D CR_STATUS_IH; + + if (!(new_status & CR_STATUS_EH)) { + new_status =3D FIELD_DP32(new_status, CR_STATUS, PRS, old_rs); + if (new_rs =3D=3D 0) { + env->ctrl[CR_ESTATUS] =3D old_status; + } else { + if (new_rs !=3D old_rs) { + old_status |=3D CR_STATUS_SRS; + } + env->shadow_regs[new_rs][R_SSTATUS] =3D old_status; + } + env->shadow_regs[new_rs][R_EA] =3D env->pc + 4; + } + + env->ctrl[CR_STATUS] =3D new_status; + nios2_update_crs(env); + + env->pc =3D cpu->rha; +} + void nios2_cpu_do_interrupt(CPUState *cs) { Nios2CPU *cpu =3D NIOS2_CPU(cs); @@ -142,7 +187,11 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 switch (cs->exception_index) { case EXCP_IRQ: - do_iic_irq(cpu); + if (cpu->eic_present) { + do_eic_irq(cpu); + } else { + do_iic_irq(cpu); + } break; =20 case EXCP_TLB_D: --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001246; cv=none; d=zohomail.com; s=zohoarc; b=ESbaXeJrZFStH1B5Fc1y5CqQ9MYlMd0dB+xvmr61PdmghsC9CkDrfbDFsw5D9+qBnpLdZjJcwP0g1SGVgc/qcSyXX5ABaGpK+H+Qq5Xt8f/b61wuj94gfWZYLuchTNLCkzh0RTwm+AFw8vHHdeRv+VBG9DCxXU7UIAr0f8BZ2BE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001246; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yl/OU+S3BuL9gmKdF4oRGlZZLlU0MEz8InOzJS1D9S0=; b=CQz1a0iWqi/gT+nVNq3iRsHIO7ysQ9IQXfI4YxRo9mku1ptKtjMl03+lrJd94xD6Dg55fouMxKL5LQGiQOqftYFmQg38WgYu5YD0ky1MgLp131J0YnG/6oBXShwNdeEtXG0iaA2c2o65Rr+u2DLnPaf3A8YEvsgj3WbrNRW1i98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001246550681.0369791110483; Tue, 26 Apr 2022 12:27:26 -0700 (PDT) Received: from localhost ([::1]:39440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQqL-0007NR-Ij for importer@patchew.org; Tue, 26 Apr 2022 15:27:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq7-0001z0-7D for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:07 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:41522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq5-0005XG-BV for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:06 -0400 Received: by mail-pg1-x535.google.com with SMTP id t13so16729734pgn.8 for ; Tue, 26 Apr 2022 11:23:04 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yl/OU+S3BuL9gmKdF4oRGlZZLlU0MEz8InOzJS1D9S0=; b=IsmpfebIxpBr0Gj4Cv+gfa2ct/Itja5rMPrWyGRr2KlJdTZL7cvhrIWTi3zZPDAwl5 Lz5Ig7ZLb5sIKsQplETgzB1cxeCvTpmS/3fCVz5IsgTJdxlO14S+jVCIbRWYAxxBd8aV 4/BxdVcFRP+an9V2lG3cIc3PymcNyTHqYDngDgzdG6DOSXeTvPAMg+SUm3BTxwUF/hZh fLvUPI8CmpCq48XpECZt6SEKwmCpJSmOta1/n0d5a5csLiT4j3rkXfaDmbKi2pxhC6Dy EXPNcad8L9oBKOF3rw6lDllSs14x2jzgd4wJxxZO1X+Byx33OJBgdzalmJTPib0JqGd5 rYIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yl/OU+S3BuL9gmKdF4oRGlZZLlU0MEz8InOzJS1D9S0=; b=RpNx5bMW+8d+5Fk3hZKzEjOW5j0SopvYRs6ZE7cA6MjbaVhi9dwsQvhf36GniMcWU9 TVa9YiRrZWIxv+udC6sT9grcPDYLq9nDghT3ZGuFYIM/Lrwz/803VkcowKOKJg3YLTWs soDItrD8zfNKj45O0oGmir/cv9Zbuseu9ixgnKtHoTngGnYvsA437fP+Ks5u54AEcsJ0 gOj11/5/pG6uHEWuB+fB80CERzysIltOlwTY79lYd3iLkL2lEc7WW3Vv4VZG59pMuJH2 ILOug8ujP3WSxT/NaMa7szrEa2W/YSlIDv/eTCjWhbUX4bjIFKeqVf4+Njti122awhD6 Fiig== X-Gm-Message-State: AOAM531fLm83ddov/OUk2juHjz/VchCq34YWOqTxldkhXqWpSyFiCFfS fLCAMbwF6iuRk3C9RTUqVK7WwkjY06pAsw== X-Google-Smtp-Source: ABdhPJzxA2ZfbiA8gsBFI19vG2C4jQgSEbbvScmCtYH+i3bcZWopdHtQqqimKlGlElZaiwQ7Jvjotg== X-Received: by 2002:a05:6a00:851:b0:50d:62f6:5494 with SMTP id q17-20020a056a00085100b0050d62f65494mr3045836pfk.75.1650997384043; Tue, 26 Apr 2022 11:23:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 61/68] target/nios2: Advance pc when raising exceptions Date: Tue, 26 Apr 2022 11:19:00 -0700 Message-Id: <20220426181907.103691-62-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001247701100001 Content-Type: text/plain; charset="utf-8" The exception return address for nios2 is the instruction after the one that was executing at the time of the exception. We have so far implemented this by advancing the pc during the process of raising the exception. It is perhaps a little less confusing to do this advance in the translator (and helpers) when raising the exception in the first place, so that we may more closely match kernel sources. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-58-richard.henderson@linaro.org> --- target/nios2/cpu.h | 2 ++ linux-user/nios2/cpu_loop.c | 8 ++------ target/nios2/helper.c | 13 +++++++------ target/nios2/op_helper.c | 18 ++++++++++++++++-- target/nios2/translate.c | 6 +++--- 5 files changed, 30 insertions(+), 17 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index 5474b1c404..f85581ee56 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -266,6 +266,8 @@ hwaddr nios2_cpu_get_phys_page_debug(CPUState *cpu, vad= dr addr); G_NORETURN void nios2_cpu_do_unaligned_access(CPUState *cpu, vaddr addr, MMUAccessType access_type, i= nt mmu_idx, uintptr_t retaddr); +G_NORETURN void nios2_cpu_loop_exit_advance(CPUNios2State *env, + uintptr_t retaddr); =20 void do_nios2_semihosting(CPUNios2State *env); =20 diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 30a27f252b..a5e86990e2 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -39,6 +39,8 @@ void cpu_loop(CPUNios2State *env) break; =20 case EXCP_DIV: + /* Match kernel's handle_diverror_c(). */ + env->pc -=3D 4; force_sig_fault(TARGET_SIGFPE, TARGET_FPE_INTDIV, env->pc); break; =20 @@ -49,12 +51,6 @@ void cpu_loop(CPUNios2State *env) break; =20 case EXCP_TRAP: - /* - * TODO: This advance should be done in the translator, as - * hardware produces an advanced pc as part of all exceptions. - */ - env->pc +=3D 4; - switch (env->error_code) { case 0: qemu_log_mask(CPU_LOG_INT, "\nSyscall\n"); diff --git a/target/nios2/helper.c b/target/nios2/helper.c index e256d1528e..bb3b09e5a7 100644 --- a/target/nios2/helper.c +++ b/target/nios2/helper.c @@ -49,7 +49,7 @@ static void do_exception(Nios2CPU *cpu, uint32_t exceptio= n_addr, cr_es =3D CR_BSTATUS; } env->ctrl[cr_es] =3D old_status; - env->regs[r_ea] =3D env->pc + 4; + env->regs[r_ea] =3D env->pc; =20 if (cpu->mmu_present) { new_status |=3D CR_STATUS_EH; @@ -113,7 +113,7 @@ static void do_eic_irq(Nios2CPU *cpu) } env->shadow_regs[new_rs][R_SSTATUS] =3D old_status; } - env->shadow_regs[new_rs][R_EA] =3D env->pc + 4; + env->shadow_regs[new_rs][R_EA] =3D env->pc; } =20 env->ctrl[CR_STATUS] =3D new_status; @@ -187,6 +187,8 @@ void nios2_cpu_do_interrupt(CPUState *cs) =20 switch (cs->exception_index) { case EXCP_IRQ: + /* Note that PC is advanced for interrupts as well. */ + env->pc +=3D 4; if (cpu->eic_present) { do_eic_irq(cpu); } else { @@ -249,7 +251,6 @@ void nios2_cpu_do_interrupt(CPUState *cs) break; =20 case EXCP_SEMIHOST: - env->pc +=3D 4; do_nios2_semihosting(env); break; =20 @@ -291,7 +292,7 @@ void nios2_cpu_do_unaligned_access(CPUState *cs, vaddr = addr, =20 env->ctrl[CR_BADADDR] =3D addr; cs->exception_index =3D EXCP_UNALIGN; - cpu_loop_exit_restore(cs, retaddr); + nios2_cpu_loop_exit_advance(env, retaddr); } =20 bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, int size, @@ -330,7 +331,7 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, cs->exception_index =3D (access_type =3D=3D MMU_INST_FETCH ? EXCP_SUPERA_X : EXCP_SUPERA_D); env->ctrl[CR_BADADDR] =3D address; - cpu_loop_exit_restore(cs, retaddr); + nios2_cpu_loop_exit_advance(env, retaddr); } } =20 @@ -367,5 +368,5 @@ bool nios2_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, =20 cs->exception_index =3D excp; env->ctrl[CR_BADADDR] =3D address; - cpu_loop_exit_restore(cs, retaddr); + nios2_cpu_loop_exit_advance(env, retaddr); } diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index 94040102f4..2e30d0a908 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -31,6 +31,20 @@ void helper_raise_exception(CPUNios2State *env, uint32_t= index) cpu_loop_exit(cs); } =20 +void nios2_cpu_loop_exit_advance(CPUNios2State *env, uintptr_t retaddr) +{ + CPUState *cs =3D env_cpu(env); + + /* + * Note that PC is advanced for all hardware exceptions. + * Do this here, rather than in restore_state_to_opc(), + * lest we affect QEMU internal exceptions, like EXCP_DEBUG. + */ + cpu_restore_state(cs, retaddr, true); + env->pc +=3D 4; + cpu_loop_exit(cs); +} + static void maybe_raise_div(CPUNios2State *env, uintptr_t ra) { Nios2CPU *cpu =3D env_archcpu(env); @@ -38,7 +52,7 @@ static void maybe_raise_div(CPUNios2State *env, uintptr_t= ra) =20 if (cpu->diverr_present) { cs->exception_index =3D EXCP_DIV; - cpu_loop_exit_restore(cs, ra); + nios2_cpu_loop_exit_advance(env, ra); } } =20 @@ -69,7 +83,7 @@ void helper_eret(CPUNios2State *env, uint32_t new_status,= uint32_t new_pc) if (unlikely(new_pc & 3)) { env->ctrl[CR_BADADDR] =3D new_pc; cs->exception_index =3D EXCP_UNALIGND; - cpu_loop_exit_restore(cs, GETPC()); + nios2_cpu_loop_exit_advance(env, GETPC()); } =20 /* diff --git a/target/nios2/translate.c b/target/nios2/translate.c index b52f98180d..3a037a68cc 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -202,10 +202,10 @@ static TCGv dest_gpr(DisasContext *dc, unsigned reg) #endif } =20 -static void t_gen_helper_raise_exception(DisasContext *dc, - uint32_t index) +static void t_gen_helper_raise_exception(DisasContext *dc, uint32_t index) { - tcg_gen_movi_tl(cpu_pc, dc->pc); + /* Note that PC is advanced for all hardware exceptions. */ + tcg_gen_movi_tl(cpu_pc, dc->base.pc_next); gen_helper_raise_exception(cpu_env, tcg_constant_i32(index)); dc->base.is_jmp =3D DISAS_NORETURN; } --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001197; cv=none; d=zohomail.com; s=zohoarc; b=EYf+rgWrRDwHgnffMNgHR19l+jQOIeVU11DngX5+ZdE8LqV7NTU/oxQX51vqLaIITSmgbhmFNcY52xaPdiy84XwPvoIIllINnBDD7X7N8X+ofI7MJ3G4EOYwQiToiUzwugrLgQOiGL7beBHlwt1nnEEpNi5GuwwLYxIySH3rgpU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001197; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KOjXySDL0Ufzbbr9M/xH36yPYqmTAVv3+nLLoSnWdKg=; b=MxTH+xGk4aAHc4nxyKvMygKLqHQngybpd2KpssV6MO8FpqLteTG174A3rUm/XeP3JAUbIAibi/WLty+YnE293jtk54Sk5XKRIs//lk+i4pRcVW/sxJK1T5ckPm5XxkWbhOIR5pgKNvHERPSj5VdEbN71NrZQJ+Zo+1N5fMn0VNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001197735260.97044242022037; Tue, 26 Apr 2022 12:26:37 -0700 (PDT) Received: from localhost ([::1]:36780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQpY-0005XT-Nh for importer@patchew.org; Tue, 26 Apr 2022 15:26:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq8-00021S-1S for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:08 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:34345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq6-0005Xy-Ds for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:07 -0400 Received: by mail-pg1-x52e.google.com with SMTP id z21so9090297pgj.1 for ; Tue, 26 Apr 2022 11:23:05 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KOjXySDL0Ufzbbr9M/xH36yPYqmTAVv3+nLLoSnWdKg=; b=UJrMN+YN2G5/nZwMajwxxBO6zBQd1IPosswxAj7XsHP4Az4kKQSyReHKlw6bMUeWE1 Cp/5fJDCI0x4OERPYD9ZSw6XHBEYaBbYgrERFJ9bz858/3qnxteZaUguMAHMBvWt055e yPR/vVG7qRD9CItnLap0rwDei7dmSIK3T2wAXvSvDiJWr0fHZgyFGv8CFAkWtND9deRB CSrcLhd/g7D/ES63+VAHFyvAPaFL71cOYaWrMOgr+0cBr7O9gGcCa9VGqfclpr4gX7TJ pnAZFuBBG3X1LC2WzwfmmMhE+yoqXCubweJKT23ctVJMc4keSH4gUfeSM3e6OHHdAsUt 6ZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KOjXySDL0Ufzbbr9M/xH36yPYqmTAVv3+nLLoSnWdKg=; b=Ubw1iLb+GReCK78Q0SnndVZevw8Fn7vE4CV3XQzLdCOWdD5UbVFr5tGJhu7tByQ65f A5JulSsqq7Sxh6qjehnqj6lIfbMX7ZQ7QCJ4TgJ0M3mBd5SMK19qD/4l4aR9Dhl5dlAD j2fEommYZFgSonl8xKOUlOpzFtiw8u9Ly8pi5EiGkA+PvGZ5zxn2gmFNQxkAhV/pZpBU R875oNHSbE6blFZTBZ3xSV8g8tEQ4yYOp+f5JMN6CHHp90jinNgULIyoKur01N5zHXwT tQu/+/kJX249y6gHiilRQ5cccgFlYuc/TqeX4qJGfEiauXe2MHsFvJ/slSuHi77DPcm9 hEYQ== X-Gm-Message-State: AOAM5316it3vHLGnJqzp/oT9WmwXVhVd2S8zuAslfsEuwUsDwp/nmgjk kUivO35EWtalcab7RprQuRMzSMQAcSML4g== X-Google-Smtp-Source: ABdhPJxt3K8YaVZqJ2+pV+S1LLVWC9U1i08SEvmvPWSOkx5wKAeHqPefu1gwXozxbzP+ndwjFWBTow== X-Received: by 2002:a05:6a00:1494:b0:50d:4b12:8dfa with SMTP id v20-20020a056a00149400b0050d4b128dfamr8225749pfu.43.1650997384932; Tue, 26 Apr 2022 11:23:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 62/68] linux-user/nios2: Handle various SIGILL exceptions Date: Tue, 26 Apr 2022 11:19:01 -0700 Message-Id: <20220426181907.103691-63-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001199418100001 Content-Type: text/plain; charset="utf-8" We missed out on a couple of exception types that may legitimately be raised by a userland program. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-59-richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a5e86990e2..da77ede76b 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -50,6 +50,18 @@ void cpu_loop(CPUNios2State *env) env->ctrl[CR_BADADDR]); break; =20 + case EXCP_ILLEGAL: + case EXCP_UNIMPL: + /* Match kernel's handle_illegal_c(). */ + env->pc -=3D 4; + force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC, env->pc); + break; + case EXCP_SUPERI: + /* Match kernel's handle_supervisor_instr(). */ + env->pc -=3D 4; + force_sig_fault(TARGET_SIGILL, TARGET_ILL_PRVOPC, env->pc); + break; + case EXCP_TRAP: switch (env->error_code) { case 0: --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001356827335.84332713551294; Tue, 26 Apr 2022 12:29:16 -0700 (PDT) Received: from localhost ([::1]:43894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQs7-0001uw-Q0 for importer@patchew.org; Tue, 26 Apr 2022 15:29:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPqA-00029m-96 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:10 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:46879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq7-0005Yh-JL for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:09 -0400 Received: by mail-pg1-x533.google.com with SMTP id q12so16711969pgj.13 for ; Tue, 26 Apr 2022 11:23:07 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P3V+FtoVYZUI41p0htZymMgazIyPkYC70RlRxt6vbn8=; b=Suf5odGW3wGqA6xPuypoZBSursj7b5Ki5n3h8YDMcH7ld2Ko0Ft+3zO7DhZfcAqnmX 5m48mZlYAfhxKTczQBxfzEuiiaGulTaYXB7cFbhynZQmcDcONZtCY1UDopqPF3E5uINP zwjm6H5VikkT6oJ3Tes66z5X4NACVUlbwZ8/N6hFkYBxPd+gdkwL4wMr1H4krA/Mi/bD kDusMUSyV7u67Esl8T2zOyUlkc2NUPy2KM3CdbloLrcBUtwL51n11ZdpdKSK4sRMuAlu 7I2q7kYQE24C7hd/ta+HtZymU34UgRW7W1fr5lvYMZ0taQwc2fB+imDV+SOwnsX+4c0e s3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P3V+FtoVYZUI41p0htZymMgazIyPkYC70RlRxt6vbn8=; b=k9VsOqlxII+K/nhfp4eOPNCZSI/Ifs4beHyuYrsPjASv3WJiqWAWIP5ysi/cG5/XyY BfHf650dCcbBfd3IWuJyG2sHC7pTYZsNDsL2EyHCBsF1mMXHHiufJqNOc76ORtrYIAby xpxKAyUrx+JIcLbva5aWg0gAAlBPaPQ1d4X7lyUTNDISVapYIY7M/Oha+G7+yj0DDKf5 zhT2VqqXQC3GIPqnpIezs3wYMNKpFaTqP+KgP7+/Rpe9Owh//ewjMlTmCzZcorJ6E57M OTpoEJt7b0zJORakcW1n0NdYvcvkwJiO7GcVgOp+dLPm/SsHGtx8v9qqXXbf6uCc+j5u x9gw== X-Gm-Message-State: AOAM5304ygle22eTvQLxCdmjIzzScEUuAerXsMaQCeHqBrGBLBMtKJ+s pi/Q3w0NBiK0pYrHSZl65F6SB4UlF/vNIA== X-Google-Smtp-Source: ABdhPJypqw3kZ6lqEt2s9Q0QZSAcM/ROFGd90PYUn2ONJiBAbDVcKxDOqdgS1p6T6LAiGLYkyQMYyA== X-Received: by 2002:a63:e116:0:b0:3ab:812a:d5b8 with SMTP id z22-20020a63e116000000b003ab812ad5b8mr5166932pgh.457.1650997386090; Tue, 26 Apr 2022 11:23:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 63/68] hw/intc: Vectored Interrupt Controller (VIC) Date: Tue, 26 Apr 2022 11:19:02 -0700 Message-Id: <20220426181907.103691-64-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Amir Gonnen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1651001357624100001 From: Amir Gonnen Implement nios2 Vectored Interrupt Controller (VIC). VIC is connected to EIC. It needs to update rha, ril, rrs and rnmi fields on Nios2CPU before raising an IRQ. For that purpose, VIC has a "cpu" property which should refer to the nios2 cpu and set by the board that connects VIC. Reviewed-by: Peter Maydell Signed-off-by: Amir Gonnen Message-Id: <20220303153906.2024748-5-amir.gonnen@neuroblade.ai> [rth: Split out nios2_vic.h] Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-60-richard.henderson@linaro.org> --- include/hw/intc/nios2_vic.h | 64 ++++++++ hw/intc/nios2_vic.c | 313 ++++++++++++++++++++++++++++++++++++ hw/intc/Kconfig | 3 + hw/intc/meson.build | 1 + 4 files changed, 381 insertions(+) create mode 100644 include/hw/intc/nios2_vic.h create mode 100644 hw/intc/nios2_vic.c diff --git a/include/hw/intc/nios2_vic.h b/include/hw/intc/nios2_vic.h new file mode 100644 index 0000000000..af1517a967 --- /dev/null +++ b/include/hw/intc/nios2_vic.h @@ -0,0 +1,64 @@ +/* + * Vectored Interrupt Controller for nios2 processor + * + * Copyright (c) 2022 Neuroblade + * + * Interface: + * QOM property "cpu": link to the Nios2 CPU (must be set) + * Unnamed GPIO inputs 0..NIOS2_VIC_MAX_IRQ-1: input IRQ lines + * IRQ should be connected to nios2 IRQ0. + * + * Reference: "Embedded Peripherals IP User Guide + * for Intel=C2=AE Quartus=C2=AE Prime Design Suite: 21.4" + * Chapter 38 "Vectored Interrupt Controller Core" + * See: https://www.intel.com/content/www/us/en/docs/programmable/683130/2= 1-4/vectored-interrupt-controller-core.html + * + * Permission is hereby granted, free of charge, to any person obtaining a= copy + * of this software and associated documentation files (the "Software"), t= o deal + * in the Software without restriction, including without limitation the r= ights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or se= ll + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included= in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS= OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OT= HER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING= FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS = IN + * THE SOFTWARE. + */ + +#ifndef HW_INTC_NIOS2_VIC +#define HW_INTC_NIOS2_VIC + +#define TYPE_NIOS2_VIC "nios2-vic" +OBJECT_DECLARE_SIMPLE_TYPE(Nios2VIC, NIOS2_VIC) + +#define NIOS2_VIC_MAX_IRQ 32 + +struct Nios2VIC { + /*< private >*/ + SysBusDevice parent_obj; + + /*< public >*/ + qemu_irq output_int; + + /* properties */ + CPUState *cpu; + MemoryRegion csr; + + uint32_t int_config[NIOS2_VIC_MAX_IRQ]; + uint32_t vic_config; + uint32_t int_raw_status; + uint32_t int_enable; + uint32_t sw_int; + uint32_t vic_status; + uint32_t vec_tbl_base; + uint32_t vec_tbl_addr; +}; + +#endif /* HW_INTC_NIOS2_VIC */ diff --git a/hw/intc/nios2_vic.c b/hw/intc/nios2_vic.c new file mode 100644 index 0000000000..cf63212a88 --- /dev/null +++ b/hw/intc/nios2_vic.c @@ -0,0 +1,313 @@ +/* + * Vectored Interrupt Controller for nios2 processor + * + * Copyright (c) 2022 Neuroblade + * + * Interface: + * QOM property "cpu": link to the Nios2 CPU (must be set) + * Unnamed GPIO inputs 0..NIOS2_VIC_MAX_IRQ-1: input IRQ lines + * IRQ should be connected to nios2 IRQ0. + * + * Reference: "Embedded Peripherals IP User Guide + * for Intel=C2=AE Quartus=C2=AE Prime Design Suite: 21.4" + * Chapter 38 "Vectored Interrupt Controller Core" + * See: https://www.intel.com/content/www/us/en/docs/programmable/683130/2= 1-4/vectored-interrupt-controller-core.html + * + * Permission is hereby granted, free of charge, to any person obtaining a= copy + * of this software and associated documentation files (the "Software"), t= o deal + * in the Software without restriction, including without limitation the r= ights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or se= ll + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included= in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS= OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OT= HER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING= FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS = IN + * THE SOFTWARE. + */ + +#include "qemu/osdep.h" + +#include "hw/irq.h" +#include "hw/qdev-properties.h" +#include "hw/sysbus.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qemu/bitops.h" +#include "qemu/log.h" +#include "qom/object.h" +#include "hw/intc/nios2_vic.h" +#include "cpu.h" + + +enum { + INT_CONFIG0 =3D 0, + INT_CONFIG31 =3D 31, + INT_ENABLE =3D 32, + INT_ENABLE_SET =3D 33, + INT_ENABLE_CLR =3D 34, + INT_PENDING =3D 35, + INT_RAW_STATUS =3D 36, + SW_INTERRUPT =3D 37, + SW_INTERRUPT_SET =3D 38, + SW_INTERRUPT_CLR =3D 39, + VIC_CONFIG =3D 40, + VIC_STATUS =3D 41, + VEC_TBL_BASE =3D 42, + VEC_TBL_ADDR =3D 43, + CSR_COUNT /* Last! */ +}; + +/* Requested interrupt level (INT_CONFIG[0:5]) */ +static inline uint32_t vic_int_config_ril(const Nios2VIC *vic, int irq_num) +{ + return extract32(vic->int_config[irq_num], 0, 6); +} + +/* Requested NMI (INT_CONFIG[6]) */ +static inline uint32_t vic_int_config_rnmi(const Nios2VIC *vic, int irq_nu= m) +{ + return extract32(vic->int_config[irq_num], 6, 1); +} + +/* Requested register set (INT_CONFIG[7:12]) */ +static inline uint32_t vic_int_config_rrs(const Nios2VIC *vic, int irq_num) +{ + return extract32(vic->int_config[irq_num], 7, 6); +} + +static inline uint32_t vic_config_vec_size(const Nios2VIC *vic) +{ + return 1 << (2 + extract32(vic->vic_config, 0, 3)); +} + +static inline uint32_t vic_int_pending(const Nios2VIC *vic) +{ + return (vic->int_raw_status | vic->sw_int) & vic->int_enable; +} + +static void vic_update_irq(Nios2VIC *vic) +{ + Nios2CPU *cpu =3D NIOS2_CPU(vic->cpu); + uint32_t pending =3D vic_int_pending(vic); + int irq =3D -1; + int max_ril =3D 0; + /* Note that if RIL is 0 for an interrupt it is effectively disabled */ + + vic->vec_tbl_addr =3D 0; + vic->vic_status =3D 0; + + if (pending =3D=3D 0) { + qemu_irq_lower(vic->output_int); + return; + } + + for (int i =3D 0; i < NIOS2_VIC_MAX_IRQ; i++) { + if (pending & BIT(i)) { + int ril =3D vic_int_config_ril(vic, i); + if (ril > max_ril) { + irq =3D i; + max_ril =3D ril; + } + } + } + + if (irq < 0) { + qemu_irq_lower(vic->output_int); + return; + } + + vic->vec_tbl_addr =3D irq * vic_config_vec_size(vic) + vic->vec_tbl_ba= se; + vic->vic_status =3D irq | BIT(31); + + /* + * In hardware, the interface between the VIC and the CPU is via the + * External Interrupt Controller interface, where the interrupt contro= ller + * presents the CPU with a packet of data containing: + * - Requested Handler Address (RHA): 32 bits + * - Requested Register Set (RRS) : 6 bits + * - Requested Interrupt Level (RIL) : 6 bits + * - Requested NMI flag (RNMI) : 1 bit + * In our emulation, we implement this by writing the data directly to + * fields in the CPU object and then raising the IRQ line to tell + * the CPU that we've done so. + */ + + cpu->rha =3D vic->vec_tbl_addr; + cpu->ril =3D max_ril; + cpu->rrs =3D vic_int_config_rrs(vic, irq); + cpu->rnmi =3D vic_int_config_rnmi(vic, irq); + + qemu_irq_raise(vic->output_int); +} + +static void vic_set_irq(void *opaque, int irq_num, int level) +{ + Nios2VIC *vic =3D opaque; + + vic->int_raw_status =3D deposit32(vic->int_raw_status, irq_num, 1, !!l= evel); + vic_update_irq(vic); +} + +static void nios2_vic_reset(DeviceState *dev) +{ + Nios2VIC *vic =3D NIOS2_VIC(dev); + + memset(&vic->int_config, 0, sizeof(vic->int_config)); + vic->vic_config =3D 0; + vic->int_raw_status =3D 0; + vic->int_enable =3D 0; + vic->sw_int =3D 0; + vic->vic_status =3D 0; + vic->vec_tbl_base =3D 0; + vic->vec_tbl_addr =3D 0; +} + +static uint64_t nios2_vic_csr_read(void *opaque, hwaddr offset, unsigned s= ize) +{ + Nios2VIC *vic =3D opaque; + int index =3D offset / 4; + + switch (index) { + case INT_CONFIG0 ... INT_CONFIG31: + return vic->int_config[index - INT_CONFIG0]; + case INT_ENABLE: + return vic->int_enable; + case INT_PENDING: + return vic_int_pending(vic); + case INT_RAW_STATUS: + return vic->int_raw_status; + case SW_INTERRUPT: + return vic->sw_int; + case VIC_CONFIG: + return vic->vic_config; + case VIC_STATUS: + return vic->vic_status; + case VEC_TBL_BASE: + return vic->vec_tbl_base; + case VEC_TBL_ADDR: + return vic->vec_tbl_addr; + default: + return 0; + } +} + +static void nios2_vic_csr_write(void *opaque, hwaddr offset, uint64_t valu= e, + unsigned size) +{ + Nios2VIC *vic =3D opaque; + int index =3D offset / 4; + + switch (index) { + case INT_CONFIG0 ... INT_CONFIG31: + vic->int_config[index - INT_CONFIG0] =3D value; + break; + case INT_ENABLE: + vic->int_enable =3D value; + break; + case INT_ENABLE_SET: + vic->int_enable |=3D value; + break; + case INT_ENABLE_CLR: + vic->int_enable &=3D ~value; + break; + case SW_INTERRUPT: + vic->sw_int =3D value; + break; + case SW_INTERRUPT_SET: + vic->sw_int |=3D value; + break; + case SW_INTERRUPT_CLR: + vic->sw_int &=3D ~value; + break; + case VIC_CONFIG: + vic->vic_config =3D value; + break; + case VEC_TBL_BASE: + vic->vec_tbl_base =3D value; + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, + "nios2-vic: write to invalid CSR address %#" + HWADDR_PRIx "\n", offset); + } + + vic_update_irq(vic); +} + +static const MemoryRegionOps nios2_vic_csr_ops =3D { + .read =3D nios2_vic_csr_read, + .write =3D nios2_vic_csr_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4 } +}; + +static void nios2_vic_realize(DeviceState *dev, Error **errp) +{ + Nios2VIC *vic =3D NIOS2_VIC(dev); + + if (!vic->cpu) { + /* This is a programming error in the code using this device */ + error_setg(errp, "nios2-vic 'cpu' link property was not set"); + return; + } + + sysbus_init_irq(SYS_BUS_DEVICE(dev), &vic->output_int); + qdev_init_gpio_in(dev, vic_set_irq, NIOS2_VIC_MAX_IRQ); + + memory_region_init_io(&vic->csr, OBJECT(dev), &nios2_vic_csr_ops, vic, + "nios2.vic.csr", CSR_COUNT * sizeof(uint32_t)); + sysbus_init_mmio(SYS_BUS_DEVICE(dev), &vic->csr); +} + +static Property nios2_vic_properties[] =3D { + DEFINE_PROP_LINK("cpu", Nios2VIC, cpu, TYPE_CPU, CPUState *), + DEFINE_PROP_END_OF_LIST() +}; + +static const VMStateDescription nios2_vic_vmstate =3D { + .name =3D "nios2-vic", + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]){ + VMSTATE_UINT32_ARRAY(int_config, Nios2VIC, 32), + VMSTATE_UINT32(vic_config, Nios2VIC), + VMSTATE_UINT32(int_raw_status, Nios2VIC), + VMSTATE_UINT32(int_enable, Nios2VIC), + VMSTATE_UINT32(sw_int, Nios2VIC), + VMSTATE_UINT32(vic_status, Nios2VIC), + VMSTATE_UINT32(vec_tbl_base, Nios2VIC), + VMSTATE_UINT32(vec_tbl_addr, Nios2VIC), + VMSTATE_END_OF_LIST() + }, +}; + +static void nios2_vic_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->reset =3D nios2_vic_reset; + dc->realize =3D nios2_vic_realize; + dc->vmsd =3D &nios2_vic_vmstate; + device_class_set_props(dc, nios2_vic_properties); +} + +static const TypeInfo nios2_vic_info =3D { + .name =3D TYPE_NIOS2_VIC, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(Nios2VIC), + .class_init =3D nios2_vic_class_init, +}; + +static void nios2_vic_register_types(void) +{ + type_register_static(&nios2_vic_info); +} + +type_init(nios2_vic_register_types); diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig index a7cf301eab..eded1b557e 100644 --- a/hw/intc/Kconfig +++ b/hw/intc/Kconfig @@ -84,3 +84,6 @@ config GOLDFISH_PIC =20 config M68K_IRQC bool + +config NIOS2_VIC + bool diff --git a/hw/intc/meson.build b/hw/intc/meson.build index d6d012fb26..8b35139f82 100644 --- a/hw/intc/meson.build +++ b/hw/intc/meson.build @@ -62,3 +62,4 @@ specific_ss.add(when: ['CONFIG_KVM', 'CONFIG_XIVE'], if_true: files('spapr_xive_kvm.c')) specific_ss.add(when: 'CONFIG_GOLDFISH_PIC', if_true: files('goldfish_pic.= c')) specific_ss.add(when: 'CONFIG_M68K_IRQC', if_true: files('m68k_irqc.c')) +specific_ss.add(when: 'CONFIG_NIOS2_VIC', if_true: files('nios2_vic.c')) --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001350; cv=none; d=zohomail.com; s=zohoarc; b=m3wCK3N0mTRi/+fn8K0Ez4hGdbc31BFa3Gf0Pn557Dj+AQI9roGJFoR9/kqL23svn2ZwaoY++nM0qgvClE9xViFry5kWwQsniHVgBgXgOVwYyFRY1tJvljTWYhphM7w4U4TtkU65zqsSC/ugV6jA2ao3cQBcmdqVjln91HmSImQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001350; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XkXB1ypOZ++skoQkKVtL7/x09Njvxh9gdGNburiKDjs=; b=jfYeOM9U28+p28Yx6e3iAOI+E26Hcp2yQacjj97KiS7ptk1gxIT+O3pEmfI+voilfTBJHziuT6BHZPxQKW8ZbIJvj4CZSQ/gPvgu6wkJZHdzbeJsh54UjUlQxWKpFYnRZCldUMgMYqpWeywsmEapa4XlGSAp7PVV05LpN3I8VzU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001350299908.4535054725575; Tue, 26 Apr 2022 12:29:10 -0700 (PDT) Received: from localhost ([::1]:43358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQs1-0001XP-5K for importer@patchew.org; Tue, 26 Apr 2022 15:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPq9-00028H-Tq for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:09 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:38421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq8-0005Z2-8s for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:09 -0400 Received: by mail-pg1-x52a.google.com with SMTP id s137so16744970pgs.5 for ; Tue, 26 Apr 2022 11:23:07 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XkXB1ypOZ++skoQkKVtL7/x09Njvxh9gdGNburiKDjs=; b=AMdsVkQjDWZTwlJUvXawdRs6Ibr8PdEFbz+V6hAAjMVf0S2o/tYeg0btW94KCYZE4s um+7IskdKCJGyEQ3cXXMgSCJ8qslHV4z07HLCzbjViEM330mtuC4IMiDAH9YXL9fhUgB oHqBQjd5nEchnB/9QTrNBvApZUZ9qk+gOCORdPJwoc3lPvZbJ6dbZmtZySatMSggSQMt uPiMBKYY/elnbYaWsmhGXqQ5QZyG2aFMgIGoiFHLMEhyF/SilN0zeVF8drQ2twAgS61j d1wetpm5TGYbiyOQrEbu/ZuGe4IpbS4Bg4iL/9MD5NVZkX2QIh8l5/zINaOt7evQuxON VXkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XkXB1ypOZ++skoQkKVtL7/x09Njvxh9gdGNburiKDjs=; b=dZwgnU0rQ1JTnVJ85SJBDNkwaeNYzVLonc9i2kr6ciOeQHjcDMBHy1+aHOdV3c2nse DmCJ0Y7wqRAu7LN5K+94Pv3Z7ohi2o/b4SxuEE3RroH6mN1v957VI9Nwz+Pp2ROOoVL0 H/xAt6g4iaMHTi+agJvnht4Slhf0W4auJOMhwMwBk+C3W1chkwxCajKtbureLilOC9Dg yMGny65JUyk8so0B96c6Mp7DQTMxhfIKQMIWwCK5TyeRDu2v4Q84qmT+ThK7vPNSpZWT zvOVqg6tZmA3Nk2rvBTcSHMdWn5SQz7hiLznDAAuIh1DYuD2LjIJzFYO76E7UbjyWTnM IYDQ== X-Gm-Message-State: AOAM532r3rHd1z85e2FKpvwuEbXLvFmM11rsJ8iITkdSsfBUiJSq0yh8 wnChwVrm6/+K7IQBnmN53oCjq7sXTDwjNQ== X-Google-Smtp-Source: ABdhPJxzN2W50vER1uo1/bv4ilM9j9SnVSLw+dvYFn8T16icptIGU++/HEMXxZVwG9vNSFt5L7kBTg== X-Received: by 2002:a63:197:0:b0:3aa:9c7a:b269 with SMTP id 145-20020a630197000000b003aa9c7ab269mr20485182pgb.158.1650997387003; Tue, 26 Apr 2022 11:23:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 64/68] hw/nios2: Introduce Nios2MachineState Date: Tue, 26 Apr 2022 11:19:03 -0700 Message-Id: <20220426181907.103691-65-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001351451100001 Content-Type: text/plain; charset="utf-8" We want to move data from the heap into Nios2MachineState, which is not possible with DEFINE_MACHINE. Reviewed-by: Mark Cave-Ayland Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-61-richard.henderson@linaro.org> --- hw/nios2/10m50_devboard.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index 3d1205b8bd..bdc3ffd50d 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -36,6 +36,13 @@ =20 #include "boot.h" =20 +struct Nios2MachineState { + MachineState parent_obj; +}; + +#define TYPE_NIOS2_MACHINE MACHINE_TYPE_NAME("10m50-ghrd") +OBJECT_DECLARE_TYPE(Nios2MachineState, MachineClass, NIOS2_MACHINE) + #define BINARY_DEVICE_TREE_FILE "10m50-devboard.dtb" =20 static void nios2_10m50_ghrd_init(MachineState *machine) @@ -105,11 +112,24 @@ static void nios2_10m50_ghrd_init(MachineState *machi= ne) BINARY_DEVICE_TREE_FILE, NULL); } =20 -static void nios2_10m50_ghrd_machine_init(struct MachineClass *mc) +static void nios2_10m50_ghrd_class_init(ObjectClass *oc, void *data) { + MachineClass *mc =3D MACHINE_CLASS(oc); + mc->desc =3D "Altera 10M50 GHRD Nios II design"; mc->init =3D nios2_10m50_ghrd_init; mc->is_default =3D true; } =20 -DEFINE_MACHINE("10m50-ghrd", nios2_10m50_ghrd_machine_init); +static const TypeInfo nios2_10m50_ghrd_type_info =3D { + .name =3D TYPE_NIOS2_MACHINE, + .parent =3D TYPE_MACHINE, + .instance_size =3D sizeof(Nios2MachineState), + .class_init =3D nios2_10m50_ghrd_class_init, +}; + +static void nios2_10m50_ghrd_type_init(void) +{ + type_register_static(&nios2_10m50_ghrd_type_info); +} +type_init(nios2_10m50_ghrd_type_init); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651000066; cv=none; d=zohomail.com; s=zohoarc; b=IiGAfNFglG2kX6JaM3ixdlnhA5yJ9Jv+n8u4ijnBZGlfhx5wYpNVlbERc5kgRwv7DHvZkhTZeTn4L/g5k/kTL6roLR+zNPU/g9a0lw4ElMrgUN65RaLWtF/prtw2ApWRGsn8Id9u22uNTkycxIV3o1XoP7veTHv1mUU/aLRb6ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651000066; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zhY6IsLbZViijjLfLFhbBpoo7RTXZotmcRSvMZEYx1c=; b=QhZqRVX1Mlp7Xv6bn21zqDzAnaiOd+K3Y6aXXzO8E2OwvADBVKM8DryvtfZJjJUEbuHxtqS2iWrv9EwGXZOwbY/1WHtvbAEbf8i6l1HO9VzqEUmRGAO3hirR50wFXD8v+/jrANehlkxMdOoI8C07ZuF6Ced1TCN0qJl6VAv5ws8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165100006693673.29883650051568; Tue, 26 Apr 2022 12:07:46 -0700 (PDT) Received: from localhost ([::1]:43628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQXJ-0005cj-Re for importer@patchew.org; Tue, 26 Apr 2022 15:07:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPqB-0002BB-7I for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:11 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:43613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPq9-0005ZO-4B for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:10 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d15so30990082pll.10 for ; Tue, 26 Apr 2022 11:23:08 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zhY6IsLbZViijjLfLFhbBpoo7RTXZotmcRSvMZEYx1c=; b=kB7uM1eR1iXTlyyVSB+DQZdgxL3yjE4Bq5uDgmUhifIrlYxN9DfKCoi3zyE3K2+tjr G4H7gUYVB/WyNh91BQhGLw5N0UlL0HI2CSMHSZzb8wmvFy3ZR0wDi9Q9s4VHgk6w/j/l MApyi4n1s2bcXlT9brQN4oY9lVvkFKM5vfjqWQzpyLibx7VUAafjp/AGsR0axEUaA+RG WM0z9m/tKa2DGuLyxmYmBi4Pt6m/qFOnKODDwAgoccabRtJPfLLBa354n1/hBUyAN4wK 7m8cq1TfVBpZtoHo5BUcTW2Gu6QoDHbm018ETKgP/euli+hsKY4ee91pJnRioMNBhCs1 S+3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zhY6IsLbZViijjLfLFhbBpoo7RTXZotmcRSvMZEYx1c=; b=4M6IhuIbOhN9Ti4l4/lMgrQBUC+oIa0gYOYQDyLElKlGChCGRWzPUu9E6a8yZgJJ9S xYAIHL68d0LMwwiCCMSuB7LkvlacmcpTAfSMlwjyB1YsWxY55DGh1uh4aj8SZFmlazbZ 9ib8j9Bwn/waMIqIGThR5x/5VVWfuwT1+OoRUaPB8FljGgOjlVWmJoz3MJl9emhewknC XzfKV7xWtCQpQPb+bba5hlEjsqITJ9KJWy5uYT2EevDI2JxpvIrx75RkM8+Oax/Ff2M0 eUPRewkHu+XHnYEaXiGbpwNY1HRys5jgMPkr0CocIk8l1oYv+gPXt1Jq9dcsPYBOA/5D 2VdA== X-Gm-Message-State: AOAM531RWXfiCoDHvIj8P+aVgxw03yUDfU1+c01OliEDXK+5FWRGDh39 CLo82tv+uURFqOO+S2V/cyJLKyH8o5Sjtg== X-Google-Smtp-Source: ABdhPJxJX+0+cZzl3h5tHTIZ7JXjMM2zBjg5HoCW+WdfsJD28YMJsz1Th5KnjhY0qO5NZ++moqGQeg== X-Received: by 2002:a17:902:ab43:b0:156:6f38:52b3 with SMTP id ij3-20020a170902ab4300b001566f3852b3mr24540276plb.135.1650997387841; Tue, 26 Apr 2022 11:23:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 65/68] hw/nios2: Move memory regions into Nios2Machine Date: Tue, 26 Apr 2022 11:19:04 -0700 Message-Id: <20220426181907.103691-66-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651000068480100001 Content-Type: text/plain; charset="utf-8" Convert to contiguous allocation, as much as possible so far. The two timer objects are not exposed for subobject allocation. Reviewed-by: Mark Cave-Ayland Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-62-richard.henderson@linaro.org> --- hw/nios2/10m50_devboard.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index bdc3ffd50d..dda4ab2bf5 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -38,6 +38,11 @@ =20 struct Nios2MachineState { MachineState parent_obj; + + MemoryRegion phys_tcm; + MemoryRegion phys_tcm_alias; + MemoryRegion phys_ram; + MemoryRegion phys_ram_alias; }; =20 #define TYPE_NIOS2_MACHINE MACHINE_TYPE_NAME("10m50-ghrd") @@ -47,13 +52,10 @@ OBJECT_DECLARE_TYPE(Nios2MachineState, MachineClass, NI= OS2_MACHINE) =20 static void nios2_10m50_ghrd_init(MachineState *machine) { + Nios2MachineState *nms =3D NIOS2_MACHINE(machine); Nios2CPU *cpu; DeviceState *dev; MemoryRegion *address_space_mem =3D get_system_memory(); - MemoryRegion *phys_tcm =3D g_new(MemoryRegion, 1); - MemoryRegion *phys_tcm_alias =3D g_new(MemoryRegion, 1); - MemoryRegion *phys_ram =3D g_new(MemoryRegion, 1); - MemoryRegion *phys_ram_alias =3D g_new(MemoryRegion, 1); ram_addr_t tcm_base =3D 0x0; ram_addr_t tcm_size =3D 0x1000; /* 1 kiB, but QEMU limit is 4 kiB */ ram_addr_t ram_base =3D 0x08000000; @@ -62,22 +64,22 @@ static void nios2_10m50_ghrd_init(MachineState *machine) int i; =20 /* Physical TCM (tb_ram_1k) with alias at 0xc0000000 */ - memory_region_init_ram(phys_tcm, NULL, "nios2.tcm", tcm_size, + memory_region_init_ram(&nms->phys_tcm, NULL, "nios2.tcm", tcm_size, &error_abort); - memory_region_init_alias(phys_tcm_alias, NULL, "nios2.tcm.alias", - phys_tcm, 0, tcm_size); - memory_region_add_subregion(address_space_mem, tcm_base, phys_tcm); + memory_region_init_alias(&nms->phys_tcm_alias, NULL, "nios2.tcm.alias", + &nms->phys_tcm, 0, tcm_size); + memory_region_add_subregion(address_space_mem, tcm_base, &nms->phys_tc= m); memory_region_add_subregion(address_space_mem, 0xc0000000 + tcm_base, - phys_tcm_alias); + &nms->phys_tcm_alias); =20 /* Physical DRAM with alias at 0xc0000000 */ - memory_region_init_ram(phys_ram, NULL, "nios2.ram", ram_size, + memory_region_init_ram(&nms->phys_ram, NULL, "nios2.ram", ram_size, &error_abort); - memory_region_init_alias(phys_ram_alias, NULL, "nios2.ram.alias", - phys_ram, 0, ram_size); - memory_region_add_subregion(address_space_mem, ram_base, phys_ram); + memory_region_init_alias(&nms->phys_ram_alias, NULL, "nios2.ram.alias", + &nms->phys_ram, 0, ram_size); + memory_region_add_subregion(address_space_mem, ram_base, &nms->phys_ra= m); memory_region_add_subregion(address_space_mem, 0xc0000000 + ram_base, - phys_ram_alias); + &nms->phys_ram_alias); =20 /* Create CPU -- FIXME */ cpu =3D NIOS2_CPU(cpu_create(TYPE_NIOS2_CPU)); --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1651001501; cv=none; d=zohomail.com; s=zohoarc; b=hWcNk6+3Kd7BNCojOkTHFmwb4agOS9ERAGbWmhTd3A4B6VCjvcBmZIUyGqlzMIuHsIALMAfVizFosfRkANSbJKy9k1/J+vjpD7s9Qs0JgpdbEc/yYYC19LBvFdN+rRmN7TsdLGLmVC8NbJa18tMjcvqY2q+DIBM4H5Qr9kg+nPA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651001501; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I9okil5+kJgTqcKaRaU/YcxpruIY39QBJzH8pAf+TqE=; b=cSZHFT1MAPlyiFpUtML0j61VSD+j8bDer42v+OrFh9VEuNCQbuTSNwNrrsK/lhfx86ADHYn6FUh9SR8S9Jfx3A1LoevGfzMNU95zV1mprX7lvPH6QRiP5cHPHSEN85bo98+2O4q3CML7sELknL5lWU8q7Fl0DZ+zimCjm26/jZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165100150130124.38134200366153; Tue, 26 Apr 2022 12:31:41 -0700 (PDT) Received: from localhost ([::1]:50532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQuQ-0006Kt-HM for importer@patchew.org; Tue, 26 Apr 2022 15:31:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPqB-0002Dj-TC for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:11 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:36735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPqA-0005Zh-3P for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:11 -0400 Received: by mail-pg1-x52e.google.com with SMTP id g3so16109287pgg.3 for ; Tue, 26 Apr 2022 11:23:09 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I9okil5+kJgTqcKaRaU/YcxpruIY39QBJzH8pAf+TqE=; b=VFVGVo6q7wEhMHeMtx/WuHBY7iCITmkXOppRqsoIFltDLuuw2zH0EwMJVoH06ljYVd pcoiYMBSID+ffDKxb/NvGrj6DXj8EidcWR37Ltm0AfWQwXeBi8Jq63MuGX9JzLiPoC2e RGG8upRqP3M4LTbiktLM6DK82YAJl3VFXvsTgvVuzEneF04zt6KipfQdoQOSQ3AW96Aa q/IafA5JaMWfEK0FmX1VEBwOI3lRJ4pAeVRMt9YV7o+OhX5jdWbRDk0hUd92Mm7iiM5e fWRWgzOW4F0MhzDF3IO8Q3QXNUFZoIFQTd6JfkUi7cJTwj7ZRa9ElYtw2kIWJMWlHErW dgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I9okil5+kJgTqcKaRaU/YcxpruIY39QBJzH8pAf+TqE=; b=bSsl+FGZodO+OFU/ZmMpg7CloRR8RY4qaiAb8eM/sd5AZ11rC62YU6c7gpeI0ClKtf X/Qsk8pXhbcsO5nGJw+EQ2qXztIYwTiiY7mi0cfLhwC5P3rCjDpHcqd485tkhpQ3KSRB D2JnBk8yOWN9h4MBThAn2awvBfbUebrBhp+qsASIUTFMxFltjeF1ZXXGkqf2KLpxFWaO NafFtbsUSM1E4VYz82GwHj+nmfJkts+nuaxrP+qFS6HkRy7j6IyZRZRXodPyPTf6a9z/ W41gIViolnAWSpHDaNM56BFFzPIy4NQyGBFTb+igLhyrti8ts9zag2jSgx2WPD9VKsED UsAQ== X-Gm-Message-State: AOAM53368R6eOuByVbGHwPA41kO6gEwf67TST9Lb5JWQIz+14yk8puRQ S/8bPrpwtfKm9vMlbd9N88azNRxxqWwKhQ== X-Google-Smtp-Source: ABdhPJxzrpfOtyUA8IprwCZicWOTQ2GM1Q8zqXoxlV4+Xwb56CNyxKZfWyZYV4klYr/2wI26Yw6zQg== X-Received: by 2002:a63:8bc2:0:b0:3ab:b53:ab4e with SMTP id j185-20020a638bc2000000b003ab0b53ab4emr13717745pge.423.1650997388746; Tue, 26 Apr 2022 11:23:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 66/68] hw/nios2: Machine with a Vectored Interrupt Controller Date: Tue, 26 Apr 2022 11:19:05 -0700 Message-Id: <20220426181907.103691-67-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amir Gonnen , Mark Cave-Ayland Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1651001501933100001 Content-Type: text/plain; charset="utf-8" From: Amir Gonnen Demonstrate how to use nios2 VIC on a machine. Introduce a new machine property to attach a VIC. When VIC is present, let the CPU know that it should use the External Interrupt Interface instead of the Internal Interrupt Interface. The devices on the machine are attached to the VIC and not directly to cpu. To allow VIC update EIC fields, we set the "cpu" property of the VIC with a reference to the nios2 cpu. [rth: Put a property on the 10m50-ghrd machine, rather than create a new machine class.] Reviewed-by: Mark Cave-Ayland Signed-off-by: Amir Gonnen Message-Id: <20220303153906.2024748-6-amir.gonnen@neuroblade.ai> Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-63-richard.henderson@linaro.org> --- hw/nios2/10m50_devboard.c | 61 +++++++++++++++++++++++++++++++++------ hw/nios2/Kconfig | 1 + 2 files changed, 53 insertions(+), 9 deletions(-) diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index dda4ab2bf5..91383fb097 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -27,6 +27,7 @@ =20 #include "hw/sysbus.h" #include "hw/char/serial.h" +#include "hw/intc/nios2_vic.h" #include "hw/qdev-properties.h" #include "sysemu/sysemu.h" #include "hw/boards.h" @@ -43,6 +44,8 @@ struct Nios2MachineState { MemoryRegion phys_tcm_alias; MemoryRegion phys_ram; MemoryRegion phys_ram_alias; + + bool vic; }; =20 #define TYPE_NIOS2_MACHINE MACHINE_TYPE_NAME("10m50-ghrd") @@ -81,10 +84,39 @@ static void nios2_10m50_ghrd_init(MachineState *machine) memory_region_add_subregion(address_space_mem, 0xc0000000 + ram_base, &nms->phys_ram_alias); =20 - /* Create CPU -- FIXME */ - cpu =3D NIOS2_CPU(cpu_create(TYPE_NIOS2_CPU)); - for (i =3D 0; i < 32; i++) { - irq[i] =3D qdev_get_gpio_in_named(DEVICE(cpu), "IRQ", i); + /* Create CPU. We need to set eic_present between init and realize. */ + cpu =3D NIOS2_CPU(object_new(TYPE_NIOS2_CPU)); + + /* Enable the External Interrupt Controller within the CPU. */ + cpu->eic_present =3D nms->vic; + + /* Configure new exception vectors. */ + cpu->reset_addr =3D 0xd4000000; + cpu->exception_addr =3D 0xc8000120; + cpu->fast_tlb_miss_addr =3D 0xc0000100; + + qdev_realize_and_unref(DEVICE(cpu), NULL, &error_fatal); + + if (nms->vic) { + DeviceState *dev =3D qdev_new(TYPE_NIOS2_VIC); + MemoryRegion *dev_mr; + qemu_irq cpu_irq; + + object_property_set_link(OBJECT(dev), "cpu", OBJECT(cpu), &error_f= atal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); + + cpu_irq =3D qdev_get_gpio_in_named(DEVICE(cpu), "EIC", 0); + sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, cpu_irq); + for (int i =3D 0; i < 32; i++) { + irq[i] =3D qdev_get_gpio_in(dev, i); + } + + dev_mr =3D sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0); + memory_region_add_subregion(address_space_mem, 0x18002000, dev_mr); + } else { + for (i =3D 0; i < 32; i++) { + irq[i] =3D qdev_get_gpio_in_named(DEVICE(cpu), "IRQ", i); + } } =20 /* Register: Altera 16550 UART */ @@ -105,15 +137,22 @@ static void nios2_10m50_ghrd_init(MachineState *machi= ne) sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xe0000880); sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq[5]); =20 - /* Configure new exception vectors and reset CPU for it to take effect= . */ - cpu->reset_addr =3D 0xd4000000; - cpu->exception_addr =3D 0xc8000120; - cpu->fast_tlb_miss_addr =3D 0xc0000100; - nios2_load_kernel(cpu, ram_base, ram_size, machine->initrd_filename, BINARY_DEVICE_TREE_FILE, NULL); } =20 +static bool get_vic(Object *obj, Error **errp) +{ + Nios2MachineState *nms =3D NIOS2_MACHINE(obj); + return nms->vic; +} + +static void set_vic(Object *obj, bool value, Error **errp) +{ + Nios2MachineState *nms =3D NIOS2_MACHINE(obj); + nms->vic =3D value; +} + static void nios2_10m50_ghrd_class_init(ObjectClass *oc, void *data) { MachineClass *mc =3D MACHINE_CLASS(oc); @@ -121,6 +160,10 @@ static void nios2_10m50_ghrd_class_init(ObjectClass *o= c, void *data) mc->desc =3D "Altera 10M50 GHRD Nios II design"; mc->init =3D nios2_10m50_ghrd_init; mc->is_default =3D true; + + object_class_property_add_bool(oc, "vic", get_vic, set_vic); + object_class_property_set_description(oc, "vic", + "Set on/off to enable/disable the Vectored Interrupt Controller"); } =20 static const TypeInfo nios2_10m50_ghrd_type_info =3D { diff --git a/hw/nios2/Kconfig b/hw/nios2/Kconfig index b10ea640da..4748ae27b6 100644 --- a/hw/nios2/Kconfig +++ b/hw/nios2/Kconfig @@ -3,6 +3,7 @@ config NIOS2_10M50 select NIOS2 select SERIAL select ALTERA_TIMER + select NIOS2_VIC =20 config NIOS2_GENERIC_NOMMU bool --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001388489257.319289903185; Tue, 26 Apr 2022 12:29:48 -0700 (PDT) Received: from localhost ([::1]:46048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQsc-0003Jx-Sc for importer@patchew.org; Tue, 26 Apr 2022 15:29:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPqD-0002J9-2p for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:13 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:42689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPqA-0005aA-Ty for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:12 -0400 Received: by mail-pj1-x1034.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so3287982pjm.1 for ; Tue, 26 Apr 2022 11:23:10 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GHtsbCUzbAiXNRerrkvBm4mS8/nCv8DYGfSujqy0xTQ=; b=LlxEP5Ges+CY+DlfOsB3aMJa9DkGpzx8dEZSJIusxgJrOAD6XRueKJDvaCz6VBWkgi uvFhlc20AYA4ZUHE6LD4xuMV8pVWFHRK84fVwS8Piy1POlXTLZQXz9FjCHsrfadQE1OI arY2g95GYIF/kPmnEJxP5QAsxTsA9BR/tXTABn/+8jmBe79hYCJRfi5K0opPx7UiPr42 INod69EFcSJ2R6VQvlTl26iYM9THwILSjTA037Z6D1K/pwfE23Gpj99mezPUR0aZGelh Gqqy1U2eElr7TyrCmKaPxLHTauPzlkE2jgrrOfT5/eD/SMAIslRI0OIc8MR6MsWl0F3j ztOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GHtsbCUzbAiXNRerrkvBm4mS8/nCv8DYGfSujqy0xTQ=; b=YD25n0bbB9TyfbKGVSvhFWDUk+CAKmvJQjHlkhMwJ6LJBQSq7JjgGl51+3hhxKv1SN AYXnE0t8QebjPw5TPe2o/WvaZJ/yDg4jo/Ixj3chEM/Of6i6qvZnt5Lb/FGZUDqBr8sB T5xCsDy+E7xOHfUeXruEggmWuNa3Xwiv20RfapUCz+T75ukeoPzWEqQz+C+FxCEaQm4O /lVd4PkHBe/6ZOk9cPas9Hw8SItLEmBL0/JAFDPYngH1xGCbfL5ZAhvDGE42rJHFRKUS HRp+xXEpddU7YA1JOQ5aHIEBo0kwN6j2SwFKUfVS+wxRap+kkgKmJzq+Aj98lyK+qiiE oJkQ== X-Gm-Message-State: AOAM530f3JceOymorCdtLEFzaJm9ud9iIPFWUrLW+DXRRVDjL3jLYG0c KPPgtfK7QQTfS3AocPxhWp405DIj6RqPiQ== X-Google-Smtp-Source: ABdhPJzgEsdT00gWNqPMbwM3S9gsk8TXREmY9thHd6TN/X9sdmMxnoLJ73oEJr6WBIoii5Pwl8lAew== X-Received: by 2002:a17:903:248:b0:155:ecb7:dfaf with SMTP id j8-20020a170903024800b00155ecb7dfafmr24819435plh.84.1650997389589; Tue, 26 Apr 2022 11:23:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 67/68] tests/tcg/nios2: Add semihosting multiarch tests Date: Tue, 26 Apr 2022 11:19:06 -0700 Message-Id: <20220426181907.103691-68-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1651001389861100001 Add runtime supporting the nios2-semi.c interface. Execute the hello and memory multiarch tests. Cc: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220421151735.31996-64-richard.henderson@linaro.org> --- tests/tcg/nios2/semicall.h | 28 +++ tests/tcg/nios2/10m50-ghrd.ld | 66 +++++++ tests/tcg/nios2/Makefile.softmmu-target | 32 ++++ tests/tcg/nios2/boot.S | 218 ++++++++++++++++++++++++ tests/tcg/nios2/intr.S | 31 ++++ 5 files changed, 375 insertions(+) create mode 100644 tests/tcg/nios2/semicall.h create mode 100644 tests/tcg/nios2/10m50-ghrd.ld create mode 100644 tests/tcg/nios2/Makefile.softmmu-target create mode 100644 tests/tcg/nios2/boot.S create mode 100644 tests/tcg/nios2/intr.S diff --git a/tests/tcg/nios2/semicall.h b/tests/tcg/nios2/semicall.h new file mode 100644 index 0000000000..6ad4978099 --- /dev/null +++ b/tests/tcg/nios2/semicall.h @@ -0,0 +1,28 @@ +/* + * Nios2 semihosting interface. + * + * Copyright Linaro Ltd 2022 + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef SEMICALL_H +#define SEMICALL_H + +#define HOSTED_EXIT 0 +#define HOSTED_INIT_SIM 1 +#define HOSTED_OPEN 2 +#define HOSTED_CLOSE 3 +#define HOSTED_READ 4 +#define HOSTED_WRITE 5 +#define HOSTED_LSEEK 6 +#define HOSTED_RENAME 7 +#define HOSTED_UNLINK 8 +#define HOSTED_STAT 9 +#define HOSTED_FSTAT 10 +#define HOSTED_GETTIMEOFDAY 11 +#define HOSTED_ISATTY 12 +#define HOSTED_SYSTEM 13 + +#define semihosting_call break 1 + +#endif /* SEMICALL_H */ diff --git a/tests/tcg/nios2/10m50-ghrd.ld b/tests/tcg/nios2/10m50-ghrd.ld new file mode 100644 index 0000000000..7db0d59ad7 --- /dev/null +++ b/tests/tcg/nios2/10m50-ghrd.ld @@ -0,0 +1,66 @@ +/* + * Link script for the Nios2 10m50-ghrd board. + * + * Copyright Linaro Ltd 2022 + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +MEMORY +{ + tpf (rx) : ORIGIN =3D 0xc0000000, LENGTH =3D 1K + ram (rwx) : ORIGIN =3D 0xc8000000, LENGTH =3D 128M +} + +PHDRS +{ + RAM PT_LOAD; +} + +ENTRY(_start) +EXTERN(_start) +EXTERN(_interrupt) +EXTERN(_fast_tlb_miss) + +SECTIONS +{ + /* Begin at the (hardcoded) _interrupt entry point. */ + .text 0xc8000120 : { + *(.text.intr) + *(.text .text.* .gnu.linkonce.t.*) + } >ram :RAM + + .rodata : ALIGN(4) { + *(.rodata .rodata.* .gnu.linkonce.r.*) + } > ram :RAM + + .eh_frame_hdr : ALIGN (4) { + KEEP (*(.eh_frame_hdr)) + *(.eh_frame_entry .eh_frame_entry.*) + } >ram :RAM + .eh_frame : ALIGN (4) { + KEEP (*(.eh_frame)) *(.eh_frame.*) + } >ram :RAM + + .data : ALIGN(4) { + *(.shdata) + *(.data .data.* .gnu.linkonce.d.*) + . =3D ALIGN(4); + _gp =3D ABSOLUTE(. + 0x8000); + *(.got.plt) *(.got) + *(.lit8) + *(.lit4) + *(.sdata .sdata.* .gnu.linkonce.s.*) + } >ram :RAM + + .bss : ALIGN(4) { + __bss_start =3D ABSOLUTE(.); + *(.sbss .sbss.* .gnu.linkonce.sb.*) + *(.scommon) + *(.bss .bss.* .gnu.linkonce.b.*) + *(COMMON) + . =3D ALIGN(4); + __bss_end =3D ABSOLUTE(.); + } >ram :RAM + + __stack =3D ORIGIN(ram) + LENGTH(ram); +} diff --git a/tests/tcg/nios2/Makefile.softmmu-target b/tests/tcg/nios2/Make= file.softmmu-target new file mode 100644 index 0000000000..cea27472a6 --- /dev/null +++ b/tests/tcg/nios2/Makefile.softmmu-target @@ -0,0 +1,32 @@ +# +# Nios2 system tests +# +# Copyright Linaro Ltd 2022 +# SPDX-License-Identifier: GPL-2.0-or-later +# + +NIOS2_SYSTEM_SRC =3D $(SRC_PATH)/tests/tcg/nios2 +VPATH +=3D $(NIOS2_SYSTEM_SRC) + +# These objects provide the basic boot code and helper functions for all t= ests +CRT_OBJS =3D boot.o intr.o $(MINILIB_OBJS) +LINK_SCRIPT =3D $(NIOS2_SYSTEM_SRC)/10m50-ghrd.ld + +CFLAGS +=3D -nostdlib -g -O0 $(MINILIB_INC) +LDFLAGS +=3D -Wl,-T$(LINK_SCRIPT) -static -nostdlib $(CRT_OBJS) -lgcc + +%.o: %.S + $(call quiet-command, $(CC) $(CFLAGS) $(EXTRA_CFLAGS) -x assembler-with-c= pp -c $< -o $@, AS, $@) + +%.o: %.c + $(call quiet-command, $(CC) $(CFLAGS) $(EXTRA_CFLAGS) -c $< -o $@, CC, $@) + +# Build and link the tests +%: %.o $(LINK_SCRIPT) $(CRT_OBJS) + $(call quiet-command, $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)= , LD, $@) + +# FIXME: nios2 semihosting writes to stdout, not a chardev +QEMU_OPTS =3D -M 10m50-ghrd,vic=3Don -semihosting >$@.out -kernel + +memory: CFLAGS+=3D-DCHECK_UNALIGNED=3D0 +TESTS +=3D $(MULTIARCH_TESTS) diff --git a/tests/tcg/nios2/boot.S b/tests/tcg/nios2/boot.S new file mode 100644 index 0000000000..f6771cbc81 --- /dev/null +++ b/tests/tcg/nios2/boot.S @@ -0,0 +1,218 @@ +/* + * Minimal Nios2 system boot code. + * + * Copyright Linaro Ltd 2022 + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "semicall.h" + + .text + .set noat + +_start: + /* Linker script defines stack at end of ram. */ + movia sp, __stack + + /* Install trampoline to _fast_tlb_miss at hardcoded vector. */ + movia r4, 0xc0000100 + movia r5, _ftm_tramp + movi r6, .L__ftm_end - _ftm_tramp + call memcpy + + /* Zero the bss to satisfy C. */ + movia r4, __bss_start + movia r6, __bss_end + sub r6, r6, r4 + movi r5, 0 + call memset + + /* Test! */ + call main + + /* Exit with main's return value. */ + movi r4, HOSTED_EXIT + mov r5, r2 + semihosting_call + + .globl _start + .type _start, @function + .size _start, . - _start + +_ftm_tramp: + movia et, _fast_tlb_miss + jmp et +.L__ftm_end: + + .type _ftm_tramp, @function + .size _ftm_tramp, . - _ftm_tramp + +#define dst r4 +#define src r5 +#define len r6 + +memcpy: + /* Store return value right away, per API */ + mov r2, dst + + /* Check for both dst and src aligned. */ + or at, dst, src + andi at, at, 3 + bne at, zero, .L_mc_test1 + + /* Copy blocks of 8. */ + + movi at, 8 + bltu len, at, .L_mc_test4 + +.L_mc_loop8: + ldw r8, 0(src) + ldw r9, 4(src) + addi src, src, 8 + addi dst, dst, 8 + subi len, len, 8 + stw r8, -8(dst) + stw r9, -4(dst) + bgeu len, at, .L_mc_loop8 + + /* Copy final aligned block of 4. */ + +.L_mc_test4: + movi at, 4 + bltu len, at, .L_mc_test1 + + ldw r8, 0(src) + addi src, src, 4 + addi dst, dst, 4 + subi len, len, 4 + stw r8, -4(dst) + + /* Copy single bytes to finish. */ + +.L_mc_test1: + beq len, zero, .L_mc_done + +.L_mc_loop1: + ldb r8, 0(src) + addi src, src, 1 + addi dst, dst, 1 + subi len, len, 1 + stb r8, -1(dst) + bne len, zero, .L_mc_loop1 + +.L_mc_done: + ret + +#undef dst +#undef src +#undef len + + .global memcpy + .type memcpy, @function + .size memcpy, . - memcpy + +#define dst r4 +#define val r5 +#define len r6 + +memset: + /* Store return value right away, per API */ + mov r2, dst + + /* Check for small blocks; fall back to bytewise. */ + movi r3, 8 + bltu len, r3, .L_ms_test1 + + /* Replicate the byte across the word. */ + andi val, val, 0xff + slli at, val, 8 + or val, val, at + slli at, val, 16 + or val, val, at + + /* Check for destination alignment; realign if needed. */ + andi at, dst, 3 + bne at, zero, .L_ms_align + + /* Set blocks of 8. */ + +.L_ms_loop8: + stw val, 0(dst) + stw val, 4(dst) + addi dst, dst, 8 + subi len, len, 8 + bgeu len, r3, .L_ms_loop8 + + /* Set final aligned block of 4. */ + +.L_ms_test4: + movi at, 4 + bltu len, at, .L_ms_test1 + + stw r8, 0(dst) + addi dst, dst, 4 + subi len, len, 4 + stw r8, -4(dst) + + /* Set single bytes to finish. */ + +.L_ms_test1: + beq len, zero, .L_ms_done + +.L_ms_loop1: + stb r8, 0(dst) + addi dst, dst, 1 + subi len, len, 1 + bne len, zero, .L_ms_loop1 + +.L_ms_done: + ret + + /* Realign for a large block, len >=3D 8. */ +.L_ms_align: + andi at, dst, 1 + beq at, zero, 2f + + stb val, 0(dst) + addi dst, dst, 1 + subi len, len, 1 + +2: andi at, dst, 2 + beq at, zero, 4f + + sth val, 0(dst) + addi dst, dst, 2 + subi len, len, 2 + +4: bgeu len, r3, .L_ms_loop8 + br .L_ms_test4 + +#undef dst +#undef val +#undef len + + .global memset + .type memset, @function + .size memset, . - memset + +/* + * void __sys_outc(char c); + */ +__sys_outc: + subi sp, sp, 16 + stb r4, 0(sp) /* buffer[0] =3D c */ + movi at, 1 + stw at, 4(sp) /* STDOUT_FILENO */ + stw sp, 8(sp) /* buffer */ + stw at, 12(sp) /* len */ + + movi r4, HOSTED_WRITE + addi r5, sp, 4 + semihosting_call + + addi sp, sp, 16 + ret + + .global __sys_outc + .type __sys_outc, @function + .size __sys_outc, . - __sys_outc diff --git a/tests/tcg/nios2/intr.S b/tests/tcg/nios2/intr.S new file mode 100644 index 0000000000..c1730692ba --- /dev/null +++ b/tests/tcg/nios2/intr.S @@ -0,0 +1,31 @@ +/* + * Minimal Nios2 system boot code -- exit on interrupt. + * + * Copyright Linaro Ltd 2022 + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "semicall.h" + + .section .text.intr, "ax" + .global _interrupt + .type _interrupt, @function + +_interrupt: + rdctl r5, exception /* extract exception.CAUSE */ + srli r5, r5, 2 + movi r4, HOSTED_EXIT + semihosting_call + + .size _interrupt, . - _interrupt + + .text + .global _fast_tlb_miss + .type _fast_tlb_miss, @function + +_fast_tlb_miss: + movi r5, 32 + movi r4, HOSTED_EXIT + semihosting_call + + .size _fast_tlb_miss, . - _fast_tlb_miss --=20 2.34.1 From nobody Mon Feb 9 18:31:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1651001483648187.6343283383476; Tue, 26 Apr 2022 12:31:23 -0700 (PDT) Received: from localhost ([::1]:49898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njQuA-0005uK-Hp for importer@patchew.org; Tue, 26 Apr 2022 15:31:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njPqD-0002JD-6N for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:13 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:38790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njPqB-0005aP-JL for qemu-devel@nongnu.org; Tue, 26 Apr 2022 14:23:12 -0400 Received: by mail-pf1-x42b.google.com with SMTP id b15so18720100pfm.5 for ; Tue, 26 Apr 2022 11:23:11 -0700 (PDT) Received: from stoup.. (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id k187-20020a636fc4000000b003983a01b896sm13585053pgc.90.2022.04.26.11.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tcLPTrmVAgcHh5+H71eXJcJTiRdrPyiIekcsE1dJrc8=; b=NkDEQcnxrmJljVO1IlTpBPl7bu/pDDMXEdlIWE8eBOUzseZ+y3Mr0xb7gAgArBwMSm 1Q2PQXApYWZczc6xU5CGFlTMLkvs+OBGVN0bXhovDhL+y+bZyQt2qdjw0HCIyqO6wJag p5dUuMOYkxQkGuvSl/eLJZ8VABbc1Du4XZi/G/Yl67sUXFDlvx6ha0VfvR7Bms+48wz4 N6ty35yWSDJvQSdFnG+3mN5N5OaMlg7ziQVa47c+l1E5etgoe9RTu0zuZhhYTfDQ0lz5 TYtwTMa6ighWJZKga3Y1iI2PelVWANQQCdx7WKULiJpApztm9nSn8c/CqPFbF8+mxDbG h98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tcLPTrmVAgcHh5+H71eXJcJTiRdrPyiIekcsE1dJrc8=; b=QiZSXVu/+pZsEVqjh3DBtKnBsEh8UeLgrK8ffMceprb16SMKHFqtdxTF9xgS5EVbSt PpyHyRHTDTN11lpELemlsM34sOquE8B+CGA54I/gakuZIIVGmOZlGjTP25hKisMUC3sy il2GF5GtWvYPSyLjeOeMbQ4XH/HtqHRZ8Zd9EDGdLCshVPchEdVS7M4mRCQEqwMccoFw 781zmM4+l1dK3dH3MT8kTqZWoT5ClIZ6lz76wzTgasx6bBiKv95NqdAbHrpqRQE5mROu FheBjjC4kFlw249zyxAAxS7peAXvaw3lyKPRS5k8yj0aBBswAnhb+2nY+o1Mr5yC8pAF WROg== X-Gm-Message-State: AOAM5312nUJyeSh1RfazwVbh0xOuGtqeA4IWBJeATndM6Prdn4fgvmoh eZ0hOUu2EZG8q0NWtmDoSJilXWYwG+0PXg== X-Google-Smtp-Source: ABdhPJziiwPULRXdAmwaOU9EqPsdbtpbuKmJ0AjR+1xUOll8mghwLzyUMGLqi5zOel/Nj+79QRM5pg== X-Received: by 2002:a63:6a85:0:b0:398:9e2b:afd6 with SMTP id f127-20020a636a85000000b003989e2bafd6mr20925433pgc.582.1650997390392; Tue, 26 Apr 2022 11:23:10 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 68/68] tests/tcg/nios2: Add test-shadow-1 Date: Tue, 26 Apr 2022 11:19:07 -0700 Message-Id: <20220426181907.103691-69-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426181907.103691-1-richard.henderson@linaro.org> References: <20220426181907.103691-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1651001485660100001 Add a regression test for tcg indirect global lowering. This appeared with nios2, with cps !=3D 0, so that we use indirection into the shadow register set. An indirect call verifies alignment of rA. The use of rA was live across the brcond leading to a tcg_debug_assert failure. Cc: Alex Benn=C3=A9e Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20220421151735.31996-65-richard.henderson@linaro.org> --- tests/tcg/nios2/Makefile.softmmu-target | 1 + tests/tcg/nios2/test-shadow-1.S | 40 +++++++++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 tests/tcg/nios2/test-shadow-1.S diff --git a/tests/tcg/nios2/Makefile.softmmu-target b/tests/tcg/nios2/Make= file.softmmu-target index cea27472a6..c3d0594a39 100644 --- a/tests/tcg/nios2/Makefile.softmmu-target +++ b/tests/tcg/nios2/Makefile.softmmu-target @@ -30,3 +30,4 @@ QEMU_OPTS =3D -M 10m50-ghrd,vic=3Don -semihosting >$@.out= -kernel =20 memory: CFLAGS+=3D-DCHECK_UNALIGNED=3D0 TESTS +=3D $(MULTIARCH_TESTS) +TESTS +=3D test-shadow-1 diff --git a/tests/tcg/nios2/test-shadow-1.S b/tests/tcg/nios2/test-shadow-= 1.S new file mode 100644 index 0000000000..79ef69db12 --- /dev/null +++ b/tests/tcg/nios2/test-shadow-1.S @@ -0,0 +1,40 @@ +/* + * Regression test for TCG indirect global lowering. + * + * Copyright Linaro Ltd 2022 + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "semicall.h" + + .text + .set noat + .align 2 + .globl main + .type main, @function + +main: + /* Initialize r0 in shadow register set 1. */ + movhi at, 1 /* PRS=3D1, CRS=3D0, RSIE=3D0, PIE=3D0 */ + wrctl status, at + wrprs zero, zero + + /* Change current register set to 1. */ + movi at, 1 << 10 /* PRS=3D0, CRS=3D1, RSIE=3D0, PIE=3D0 */ + wrctl estatus, at + movia ea, 1f + eret + + /* Load address for callr, then end TB. */ +1: movia at, 3f + br 2f + + /* Test case! TCG abort on indirect lowering across brcond. */ +2: callr at + + /* exit(0) */ +3: movi r4, HOSTED_EXIT + movi r5, 0 + semihosting_call + + .size main, . - main --=20 2.34.1