From nobody Mon Feb 9 02:28:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1650561099; cv=none; d=zohomail.com; s=zohoarc; b=OAq/pG/HsztJncd9S1jMwCDB7wIG8/465ysfLF7vQZYaxKHe99ULrRi/HnA01wlPpTFsWjmYk2MZMZ6VFL3T5l7veSzToF3JwPzGwp0y99hpwWecUTv1eWfEE6TChmmnACQvPzDv1lNkePo3LCntM65oCS8CXAS4aixtOTITAi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650561099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gm6M/9vMLd2rlWG8UOLPBQD6mNmwEBg2Ik27t/XFW/c=; b=RV55AQ+FUzIGwv6n/jnJqOR+fk8JSMglwwGYr8j3XuL9LmoyQ7Y6da0wZL4uVs/8tNfthNJ3WMkkUfzsCIYx1gToChJ+eYYy4aY+uZqppP7hIE55tEm/bwsaKh+Sw8u5H0C3QR6Pf3PVHcWHpL4E2JJk7FblRmkQICkQ1DZJrnc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650561099157389.25515739612774; Thu, 21 Apr 2022 10:11:39 -0700 (PDT) Received: from localhost ([::1]:44266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhaLB-0005hK-12 for importer@patchew.org; Thu, 21 Apr 2022 13:11:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhZrW-0007cH-61 for qemu-devel@nongnu.org; Thu, 21 Apr 2022 12:40:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:57275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhZrT-00032G-Q2 for qemu-devel@nongnu.org; Thu, 21 Apr 2022 12:40:57 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-R38aDsbiNEepRkQQvB4m8A-1; Thu, 21 Apr 2022 12:40:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71968101AA47 for ; Thu, 21 Apr 2022 16:40:53 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.39.195.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id A9B3E40D016E; Thu, 21 Apr 2022 16:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650559255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gm6M/9vMLd2rlWG8UOLPBQD6mNmwEBg2Ik27t/XFW/c=; b=A6pVtx1XYGw+2IvMQBzoWCzejv6McjD28rIV3nwPfsiJrd15nrby1x4ytAPwUVEXhwk3RU 6kySxC/e3hPUeGGwekYM5EBp7fJBOafO9qrvUYmQGF5yM/khn0Gky5dOEzv0ZhgfpsAflQ vOIenybhqlqG68N+kkTvrFR21Dzg2PY= X-MC-Unique: R38aDsbiNEepRkQQvB4m8A-1 From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, peterx@redhat.com, berrange@redhat.com Subject: [PULL 03/18] tests: print newline after QMP response in qtest logs Date: Thu, 21 Apr 2022 17:40:28 +0100 Message-Id: <20220421164043.209703-4-dgilbert@redhat.com> In-Reply-To: <20220421164043.209703-1-dgilbert@redhat.com> References: <20220421164043.209703-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1650561100191100001 From: Daniel P. Berrang=C3=A9 The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next QMP command appears in the same line as the previous QMP response. Reviewed-by: Thomas Huth Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20220310171821.3724080-5-berrange@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tests/qtest/libqtest.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index ac89b80d11..2e9dd4d77f 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -624,10 +624,13 @@ QDict *qmp_fd_receive(int fd) } =20 if (log) { - len =3D write(2, &c, 1); + g_assert(write(2, &c, 1) =3D=3D 1); } json_message_parser_feed(&qmp.parser, &c, 1); } + if (log) { + g_assert(write(2, "\n", 1) =3D=3D 1); + } json_message_parser_destroy(&qmp.parser); =20 return qmp.response; --=20 2.35.1