From nobody Tue May 21 08:21:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650551571307906.9218079504718; Thu, 21 Apr 2022 07:32:51 -0700 (PDT) Received: from localhost ([::1]:38418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhXrV-0002sP-UX for importer@patchew.org; Thu, 21 Apr 2022 10:32:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhXjf-0004qI-NI for qemu-devel@nongnu.org; Thu, 21 Apr 2022 10:24:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhXjd-0002wO-4R for qemu-devel@nongnu.org; Thu, 21 Apr 2022 10:24:42 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-412-Zr8myBriNfK1IbcU9oUDRA-1; Thu, 21 Apr 2022 10:24:37 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3279F29DD990; Thu, 21 Apr 2022 14:24:37 +0000 (UTC) Received: from localhost (unknown [10.39.194.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2DEE40CFD22; Thu, 21 Apr 2022 14:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650551079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3W8uguSEAEwm4KrhtVtCxoLif7KPYjYRYk+SlDjIjGo=; b=Yv2s/ZJHdcihrBDU8n7uPGxdoJ+wFQAgG9V8NnUVqBii8zUHJuzSxv83k1ty0Q0r3y85X/ oaRfjTcdAFTdxSHt8reAhEtlXH9gI1AC9bGXm8On2eYnYX4VB8pNLiKTqLm5CF55Ot5cNA pyM0s4hjrSUlFuz8e2OYpBD0S4F5ryg= X-MC-Unique: Zr8myBriNfK1IbcU9oUDRA-1 From: Hanna Reitz To: qemu-block@nongnu.org Subject: [PATCH] iotests/108: Fix when missing user_allow_other Date: Thu, 21 Apr 2022 16:24:35 +0200 Message-Id: <20220421142435.569600-1-hreitz@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Hanna Reitz , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1650551572156100001 Content-Type: text/plain; charset="utf-8" FUSE exports' allow-other option defaults to "auto", which means that it will try passing allow_other as a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know about the fallback occurring), and so when allow_other does not work (primarily when /etc/fuse.conf does not contain user_allow_other), this error message will appear and break the reference output. We do not need allow_other here, though, so we can just pass allow-other=3Doff to fix that. Reported-by: Markus Armbruster Signed-off-by: Hanna Reitz Tested-by: Eric Blake Tested-by: Markus Armbruster --- tests/qemu-iotests/108 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 688d3ae8f6..9e923d6a59 100755 --- a/tests/qemu-iotests/108 +++ b/tests/qemu-iotests/108 @@ -326,7 +326,7 @@ else =20 $QSD \ --blockdev file,node-name=3Dexport-node,filename=3D"$TEST_IMG" \ - --export fuse,id=3Dfuse-export,node-name=3Dexport-node,mountpoint= =3D"$export_mp",writable=3Don,growable=3Doff \ + --export fuse,id=3Dfuse-export,node-name=3Dexport-node,mountpoint= =3D"$export_mp",writable=3Don,growable=3Doff,allow-other=3Doff \ --pidfile "$TEST_DIR/qsd.pid" \ --daemonize fi --=20 2.35.1