From nobody Tue Feb 10 06:43:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650549662444102.99349189113173; Thu, 21 Apr 2022 07:01:02 -0700 (PDT) Received: from localhost ([::1]:47470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhXMj-0003C4-1T for importer@patchew.org; Thu, 21 Apr 2022 10:01:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhXCm-0003EJ-II for qemu-devel@nongnu.org; Thu, 21 Apr 2022 09:50:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhXCk-00067d-GX for qemu-devel@nongnu.org; Thu, 21 Apr 2022 09:50:44 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-416-GvQBTdeZMniUSolwQgP6PA-1; Thu, 21 Apr 2022 09:50:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B716E80159B; Thu, 21 Apr 2022 13:50:37 +0000 (UTC) Received: from localhost (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id D034D145B99C; Thu, 21 Apr 2022 13:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650549041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tG6e3wxrRfYTP/3XF750OQ7rTUwvynv/Ev+Pj/rZzLA=; b=JsH5ZkZspWRSMK1PRho1LhLk+s+3rm8lQXVD7UBfwfNmBHFmkDt4cStnAHqPDbCn3aHJdR vFggEcd4QyCQ3KQLcESsUPtKhihSqncCkc+cGOi9RBM0p+Vv1TPkFiVGTk+F7MzEFzmhPP Qd/r/sZWSsnTVLF+kaygeuRipfAy7Uk= X-MC-Unique: GvQBTdeZMniUSolwQgP6PA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 10/30] intc/exynos4210_gic: replace snprintf() with g_strdup_printf() Date: Thu, 21 Apr 2022 17:49:20 +0400 Message-Id: <20220421134940.2887768-11-marcandre.lureau@redhat.com> In-Reply-To: <20220421134940.2887768-1-marcandre.lureau@redhat.com> References: <20220421134940.2887768-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "open list:Exynos" , richard.henderson@linaro.org, Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1650549664074100001 From: Marc-Andr=C3=A9 Lureau While at it, replace '%x' with '%u' as suggested by Philippe Mathieu-Daud= =C3=A9. Also fixes a GCC 12.0.1 -Wformat-overflow false-positive. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20220420132624.2439741-16-marcandre.lureau@redhat.com> --- hw/intc/exynos4210_gic.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c index bc73d1f11524..f8dd719caa1e 100644 --- a/hw/intc/exynos4210_gic.c +++ b/hw/intc/exynos4210_gic.c @@ -289,10 +289,6 @@ static void exynos4210_gic_realize(DeviceState *dev, E= rror **errp) Object *obj =3D OBJECT(dev); Exynos4210GicState *s =3D EXYNOS4210_GIC(obj); SysBusDevice *sbd =3D SYS_BUS_DEVICE(obj); - const char cpu_prefix[] =3D "exynos4210-gic-alias_cpu"; - const char dist_prefix[] =3D "exynos4210-gic-alias_dist"; - char cpu_alias_name[sizeof(cpu_prefix) + 3]; - char dist_alias_name[sizeof(cpu_prefix) + 3]; SysBusDevice *gicbusdev; uint32_t n =3D s->num_cpu; uint32_t i; @@ -322,8 +318,10 @@ static void exynos4210_gic_realize(DeviceState *dev, E= rror **errp) */ assert(n <=3D EXYNOS4210_NCPUS); for (i =3D 0; i < n; i++) { + g_autofree char *cpu_alias_name =3D g_strdup_printf("exynos4210-gi= c-alias_cpu%u", i); + g_autofree char *dist_alias_name =3D g_strdup_printf("exynos4210-g= ic-alias_dist%u", i); + /* Map CPU interface per SMP Core */ - sprintf(cpu_alias_name, "%s%x", cpu_prefix, i); memory_region_init_alias(&s->cpu_alias[i], obj, cpu_alias_name, sysbus_mmio_get_region(gicbusdev, 1), @@ -333,7 +331,6 @@ static void exynos4210_gic_realize(DeviceState *dev, Er= ror **errp) EXYNOS4210_EXT_GIC_CPU_GET_OFFSET(i), &s->cpu_alias[i]); =20 /* Map Distributor per SMP Core */ - sprintf(dist_alias_name, "%s%x", dist_prefix, i); memory_region_init_alias(&s->dist_alias[i], obj, dist_alias_name, sysbus_mmio_get_region(gicbusdev, 0), --=20 2.36.0