From nobody Tue Feb 10 19:18:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1650223745; cv=none; d=zohomail.com; s=zohoarc; b=kFayyWtB+uluYtbiWB8j+djAKjBBwIwuSUrPCOPGbTXGq5tEFxh1SBE9qDikp7hfSOq+qo6khqaJpsRC0xoxlCTqmdGVMpG+E6pmtoFcIAfdVidcGcTJrtlj9sKFqQyDP6a1qTDc/Y45kbIU80Njxgl99Mtks4ElE0MKp94JFBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650223745; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Fn+CbJP06y71kazZpVgJUGNoM8u0gdfQl47vBhG5p2I=; b=HkTi5GHnoXZ1oZ/sOy7kip7jxteAqe5ovpUx0M0XWYs/eVtsBjcv2Om2rpgxTHEFbsYJRCnfTkTIdA/zycwcoDL1YV3JPBrkCLLTdjJlLDXJ3s5Nv1zN3D2sUT1ZDX9CG3afMe4GttkHtkswZss999CVQ0wwPZ12TQvf+hUJ2xI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1650223745877136.6022975286279; Sun, 17 Apr 2022 12:29:05 -0700 (PDT) Received: from localhost ([::1]:38046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngAa0-0003sz-Dl for importer@patchew.org; Sun, 17 Apr 2022 15:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng9fo-0000Yn-K7 for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:31:00 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:35660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng9fl-0001ri-Mk for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:31:00 -0400 Received: by mail-pl1-x62b.google.com with SMTP id b7so1134851plh.2 for ; Sun, 17 Apr 2022 11:30:52 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id on10-20020a17090b1d0a00b001d08a7d569csm8154011pjb.56.2022.04.17.11.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 11:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fn+CbJP06y71kazZpVgJUGNoM8u0gdfQl47vBhG5p2I=; b=AGUI7rN0DEVkKQlb73Cih/fwlNin2ZEIoAIDq8fKMX/PdUbBk+ip7eWnUCpJEqoagf NuFj4Z0Mc5RNVUyLHhOLg93aR/M/JQ1HC9mJ/bZ1fHuUYqHyJM+inPS85h/g41TbZO6M hV7yn1qKHJ917ogBtsang5nusQwGHkjtkGd2X8HaoZQfd+7UWuPaRkh5yFcInRgXnJBm 46FAICzEnUTILhECAkyjBxOAWEC0W8GsRggSLzWOtJy0XFkGBtYugsLdC5q2LXqBH6Tc iy6mxBfw7kCczzPKrsJ2jQYiMj6aBWf6F+hiojtfm7dz73RDYrFiyY7Y9OMUqvRfg9np 4EDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fn+CbJP06y71kazZpVgJUGNoM8u0gdfQl47vBhG5p2I=; b=TK6P1macM/ydlXVEfrBnt6xNtypOv/n7fJmofa3+Q6SAI//ecwjYhOXQ6Fv45Mkgx2 PTI4qPA3yZB4fEJyU4NngiVIoPIhfbrNpCtnf8ZqMsLSHSw3qYTcXmpk6gf/2//m+dWW 5+fB9kHYdxZWAan8EOGAT77Ep1tR3PS3M4VzXmPOABUnhy1q0mgDGqv7hugh3NnIYleW uMTNFGF1xJzlCxp2t6BDI6yCPsBp9DplQNn6Xc/LJQ1wlo7jA6eHrHb8JGZ7gpWjPEQA 3B0D5FFz0JaCOybJL+A4qP4i9D0HbW5Eae+yTsfkET199FLCfY2AZkoNv/nFAfxbh185 oYkA== X-Gm-Message-State: AOAM531cEfwdfUQb5R/mL2oejd+xsrpzZvb5/PoWKwKXZILnHC4DB11T DjILXk2Do022pXUhKCGzXCvaNQFZsKjrmg== X-Google-Smtp-Source: ABdhPJwVFjrcaVsn8fhBltPBgCrQ3IFHVE5e2MWO/sK85DJN8Xikqb3BxEUT9bg1tEyaxmpce87uwQ== X-Received: by 2002:a17:90a:70cf:b0:1cb:a31e:a2c1 with SMTP id a15-20020a17090a70cf00b001cba31ea2c1mr14774177pjm.94.1650220251657; Sun, 17 Apr 2022 11:30:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 37/39] util/log: Rename QemuLogFile to RCUCloseFILE Date: Sun, 17 Apr 2022 11:30:17 -0700 Message-Id: <20220417183019.755276-38-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220417183019.755276-1-richard.henderson@linaro.org> References: <20220417183019.755276-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1650223747198100001 s/QemuLogFile/RCUCloseFILE/ s/qemu_logfile_free/rcu_close_file/ Emphasize that this is only a carrier for passing a pointer to call_rcu for closing, and not the real logfile. Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- util/log.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/util/log.c b/util/log.c index 21da961d8d..eb6e85b2f0 100644 --- a/util/log.c +++ b/util/log.c @@ -29,15 +29,15 @@ #include "qemu/rcu.h" =20 =20 -typedef struct QemuLogFile { +typedef struct RCUCloseFILE { struct rcu_head rcu; FILE *fd; -} QemuLogFile; +} RCUCloseFILE; =20 /* Mutex covering the other global_* variables. */ static QemuMutex global_mutex; static char *global_filename; -static QemuLogFile *global_file; +static RCUCloseFILE *global_file; =20 int qemu_loglevel; static int log_append =3D 0; @@ -52,7 +52,7 @@ bool qemu_log_enabled(void) /* Returns true if qemu_log() will write somewhere other than stderr. */ bool qemu_log_separate(void) { - QemuLogFile *logfile; + RCUCloseFILE *logfile; bool res =3D false; =20 rcu_read_lock(); @@ -68,7 +68,7 @@ bool qemu_log_separate(void) =20 FILE *qemu_log_trylock(void) { - QemuLogFile *logfile; + RCUCloseFILE *logfile; =20 rcu_read_lock(); logfile =3D qatomic_rcu_read(&global_file); @@ -108,14 +108,12 @@ static void __attribute__((__constructor__)) startup(= void) qemu_mutex_init(&global_mutex); } =20 -static void qemu_logfile_free(QemuLogFile *logfile) +static void rcu_close_file(RCUCloseFILE *r) { - g_assert(logfile); - - if (logfile->fd !=3D stderr) { - fclose(logfile->fd); + if (r->fd !=3D stderr) { + fclose(r->fd); } - g_free(logfile); + g_free(r); } =20 /* enable or disable low levels log */ @@ -124,7 +122,7 @@ static bool qemu_set_log_internal(const char *filename,= bool changed_name, { bool need_to_open_file; bool daemonized; - QemuLogFile *logfile; + RCUCloseFILE *logfile; =20 QEMU_LOCK_GUARD(&global_mutex); logfile =3D global_file; @@ -178,7 +176,7 @@ static bool qemu_set_log_internal(const char *filename,= bool changed_name, =20 if (logfile && (!need_to_open_file || changed_name)) { qatomic_rcu_set(&global_file, NULL); - call_rcu(logfile, qemu_logfile_free, rcu); + call_rcu(logfile, rcu_close_file, rcu); logfile =3D NULL; } =20 @@ -196,7 +194,7 @@ static bool qemu_set_log_internal(const char *filename,= bool changed_name, if (daemonized) { dup2(fileno(fd), STDERR_FILENO); fclose(fd); - /* This will skip closing logfile in qemu_logfile_free. */ + /* This will skip closing logfile in rcu_close_file. */ fd =3D stderr; } } else { @@ -207,7 +205,7 @@ static bool qemu_set_log_internal(const char *filename,= bool changed_name, =20 log_append =3D 1; =20 - logfile =3D g_new0(QemuLogFile, 1); + logfile =3D g_new0(RCUCloseFILE, 1); logfile->fd =3D fd; qatomic_rcu_set(&global_file, logfile); } --=20 2.25.1