From nobody Mon Feb 9 06:31:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1649319290; cv=none; d=zohomail.com; s=zohoarc; b=Gztp+10sPumYoCD/DDtDdoa0bG3LUTrCeInfC5C3hcQJCQg60dQF7fRLKbdgF9dAxXY+V3ljyb7F2zDIm/EWyT407SLimQRGwBnDQD8IYAE5kG/kwL/lJcRP/trLgqqP6qX/I6URJOAyRInKq7G9xu9dDkf5IN6HgFMBzfpPh88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649319290; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mA0f+Fz0lfkMvDaAT3J/7EYMK1R0oqUHYMp9kWalNNw=; b=k3kTR05g2exKe9oHIywsfaf97iJwsrOJPqRWH/TbQN3ovkzn2UGpA+YWAK/9XnguY5qpSWxLOSCQC2pf8EJnD9VZFSeOAEIk/KkJz/kmtzDXnlNy0wq2QsvAJE/g8gBrntoOGjcjQYr5KL8mcDcR9QzqFhT6MqnQciwLa+25Uk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1649319290278276.88138076194025; Thu, 7 Apr 2022 01:14:50 -0700 (PDT) Received: from localhost ([::1]:40980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncNI0-0001Zz-LN for importer@patchew.org; Thu, 07 Apr 2022 04:14:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncNEZ-0000kh-91 for qemu-devel@nongnu.org; Thu, 07 Apr 2022 04:11:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41594) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncNEW-0000CD-Aw for qemu-devel@nongnu.org; Thu, 07 Apr 2022 04:11:14 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-bJ-KOQz9Ow6JEcIIscEjnw-1; Thu, 07 Apr 2022 04:11:10 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E889C85A5BC for ; Thu, 7 Apr 2022 08:11:09 +0000 (UTC) Received: from f35-work.redhat.com (unknown [10.39.194.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42D37C27E9A; Thu, 7 Apr 2022 08:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649319070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mA0f+Fz0lfkMvDaAT3J/7EYMK1R0oqUHYMp9kWalNNw=; b=CEQPpMk9fqwij2ZfKEK8NklUR0t+1+GtCTkUBd7TVVXyssLWM3eIhoJxVDXI4QNtz5F0Ca MMtGJ3yfspLAA+zfowhsuPgKkYe/xTNO+nGIlt/QQjkCRcEWkiNxLGIluoHNOBBMTBZXNU 8As8m89Gv2bV02ldyUslopjG53mP+ks= X-MC-Unique: bJ-KOQz9Ow6JEcIIscEjnw-1 From: Mauro Matteo Cascella To: qemu-devel@nongnu.org Subject: [PATCH v2] display/qxl-render: fix race condition in qxl_cursor (CVE-2021-4207) Date: Thu, 7 Apr 2022 10:11:06 +0200 Message-Id: <20220407081106.343235-1-mcascell@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mcascell@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mcascell@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mcascell@redhat.com, kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1649319292472100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Avoid fetching 'width' and 'height' a second time to prevent possible race condition. Refer to security advisory https://starlabs.sg/advisories/22-4207/ for more information. Fixes: CVE-2021-4207 Signed-off-by: Mauro Matteo Cascella Reviewed-by: Marc-Andr=C3=A9 Lureau --- v2: - fix CVE id (CVE-2021-4207 instead of CVE-2022-4207) hw/display/qxl-render.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index d28849b121..237ed293ba 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-render.c @@ -266,7 +266,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCur= sor *cursor, } break; case SPICE_CURSOR_TYPE_ALPHA: - size =3D sizeof(uint32_t) * cursor->header.width * cursor->header.= height; + size =3D sizeof(uint32_t) * c->width * c->height; qxl_unpack_chunks(c->data, size, qxl, &cursor->chunk, group_id); if (qxl->debug > 2) { cursor_print_ascii_art(c, "qxl/alpha"); --=20 2.35.1