From nobody Mon Feb 9 03:16:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1648780162; cv=none; d=zohomail.com; s=zohoarc; b=Nc2GsYGTJPnikzpTUXnDb5DmV/Win8F8dA4bep0ZT5HS2njQ3IxECCLrY1/j/SltiADfif+rMYehhoL7556SWtYzqmxg4g64WbAvEliLY+RHEuo48uUodEZAwnGpyORZVJspHvIbqOa8yUS/0sntvWO0uur2tPySZGfhznhyyCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648780162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=eugiayE55MF6iO8DOTok7j2QntmtmWkVacMz0ErL3zI=; b=GkjK1/s/SJ1BcjDL6CcORKdVWhI1Rocz63kMC+8xcMcRVeGyU7ssv7qyw1E4qO8KAXEvlekpKuEsRLDc64MNBpm80Zwb83DZr8FruRBwkdGoLAxg7tWNFkkwOhqpb1vdKxn6Fy1OYdKeEDnBuq76ozUF4GxMXUeH+NrP6JWwDfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648780162913362.5389821174822; Thu, 31 Mar 2022 19:29:22 -0700 (PDT) Received: from localhost ([::1]:50932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na72O-0004yz-PW for importer@patchew.org; Thu, 31 Mar 2022 22:29:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na71e-0004KH-0Q for qemu-devel@nongnu.org; Thu, 31 Mar 2022 22:28:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na71b-000567-Vh for qemu-devel@nongnu.org; Thu, 31 Mar 2022 22:28:33 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-151-mEsXRCfDM72tSCq9ExWDxg-1; Thu, 31 Mar 2022 22:28:29 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B4782800173 for ; Fri, 1 Apr 2022 02:28:29 +0000 (UTC) Received: from localhost.localdomain (ovpn-13-216.pek2.redhat.com [10.72.13.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4571D401E67; Fri, 1 Apr 2022 02:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648780111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eugiayE55MF6iO8DOTok7j2QntmtmWkVacMz0ErL3zI=; b=KBDOeEEgGfTojRA2tOpzIvEHYqFF4JCDAx+b7unPZaHxNJa7Kl+HLUu8tzll/Sh30wcnNB waMBy2AiGJETxvZy6xITfr9PTP1C8N/NLJ5BYsXT4nxrg59K7tMFVwCdcDSHeoVbeCVmu2 e7BC/T2uCRLOAgXpIvrSB9xBJBvAMPY= X-MC-Unique: mEsXRCfDM72tSCq9ExWDxg-1 From: Jason Wang To: mst@redhat.com, peterx@redhat.com Subject: [PATCH] intel-iommu: correct the value used for error_setg_errno() Date: Fri, 1 Apr 2022 10:28:24 +0800 Message-Id: <20220401022824.9337-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1648780165853100001 Content-Type: text/plain; charset="utf-8"; x-default="true" error_setg_errno() expects a normal errno value, not a negated one, so we should use ENOTSUP instead of -ENOSUP. Fixes: Coverity CID 1487174 Fixes: ("intel_iommu: support snoop control") Signed-off-by: Jason Wang Reviewed-by: Peter Maydell Reviewed-by: Peter Xu --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index c64aa81a83..e05d69a2c0 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3032,7 +3032,7 @@ static int vtd_iommu_notify_flag_changed(IOMMUMemoryR= egion *iommu, =20 /* TODO: add support for VFIO and vhost users */ if (s->snoop_control) { - error_setg_errno(errp, -ENOTSUP, + error_setg_errno(errp, ENOTSUP, "Snoop Control with vhost or VFIO is not supporte= d"); return -ENOTSUP; } --=20 2.25.1