From nobody Fri Dec 19 20:34:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=openvz.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648683573646243.79270357768348; Wed, 30 Mar 2022 16:39:33 -0700 (PDT) Received: from localhost ([::1]:48914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZhuW-0004ih-8n for importer@patchew.org; Wed, 30 Mar 2022 19:39:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZft4-0008Fc-3P for qemu-devel@nongnu.org; Wed, 30 Mar 2022 17:29:54 -0400 Received: from [2a00:1450:4864:20::143] (port=46024 helo=mail-lf1-x143.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZft0-0003Jv-HF for qemu-devel@nongnu.org; Wed, 30 Mar 2022 17:29:53 -0400 Received: by mail-lf1-x143.google.com with SMTP id p10so32198792lfa.12 for ; Wed, 30 Mar 2022 14:29:49 -0700 (PDT) Received: from fedora.. ([185.215.60.153]) by smtp.gmail.com with ESMTPSA id y3-20020a056512044300b0044a9bda3242sm1057573lfk.90.2022.03.30.14.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7CR4tpKwUbqNCp3vPghajNadmUDfn2CftEskMgZuONo=; b=ucriP8HbMlr64lT07ALgEJQt1aAegJQS7SVcMbGPwQvt4MFX/+jVqHYSAoi8eDv+zE RvakHHacpYBhJrCtiKWu2jnGrz/5vTTOE5QkCrPFuvLEx0bn7KSSh+1X4T49wqhiRdpm pEM8zG4v+ifzDFvDA7bEN0BaRNrVHuoyP/buw7WjnybsSM9cZkw4zafKqeX7TUiyxfgE SEwoduH3ksgZgyvlrNy+q6AeiFn/iJhLzVfoNGoAbN8ikiFl39KQN7JDOOsIAMns4lBz dKoE9Y/SVapj7P9Whl8aKWTmFbGG20Ui5c7wKi1hNlHYOeVEvcLSr+abdE6vr35IB5LL r0zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7CR4tpKwUbqNCp3vPghajNadmUDfn2CftEskMgZuONo=; b=05yvSYEcqBSl6Eb28au9IJ05QMNwszP4uqRZ4GRlifspYnkUNCWjnOnvPq2zxD74pj wFoW2uffD62xJj0w8MFmCa9REHOkUtX5wz4rSUqehToC/wn89NqpE5w8DaZmPSqM3ONu Cki29e1qDXNKy1vIKcfyDIAwxuYHyxwOv07bvvNcv3Wwq1MxOezDdmlaPtM6mv3jQSgg 8r8Ruk0WwFkJ2EdEfMD9SKUJqUIm0zzIHd06ZEJtZU1R+zBTm4/9I6TAwRep434HnUiq wbrjCiNGjSBk+K+qBaYK5vijkRrYlrM4mFukJtET1VxaxizqRR372M8s8QZVLco/UcQm wHMg== X-Gm-Message-State: AOAM53049LXLTvFqeLV+K/J8CQUhmMq1KmAH+bENRzvS5Fqj+LHBg2JK 0sizt1YnMIX1oTyWYOotDtmceA== X-Google-Smtp-Source: ABdhPJwhRhl+I0uVtCJPHa/aGzh/egb21Ze4nW56WHaB8Kxz6ecFXWaJ01oZr4SvfkSxc1fBhEOQ4A== X-Received: by 2002:a05:6512:3a81:b0:44a:616f:f75b with SMTP id q1-20020a0565123a8100b0044a616ff75bmr8450895lfu.2.1648675786923; Wed, 30 Mar 2022 14:29:46 -0700 (PDT) From: Vladimir Sementsov-Ogievskiy X-Google-Original-From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v5 25/45] blockdev: qmp_transaction: refactor loop to classic for Date: Thu, 31 Mar 2022 00:28:42 +0300 Message-Id: <20220330212902.590099-26-vsementsov@openvz.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330212902.590099-1-vsementsov@openvz.org> References: <20220330212902.590099-1-vsementsov@openvz.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::143 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::143; envelope-from=vladimir.sementsov-ogievskiy@openvz.org; helo=mail-lf1-x143.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 30 Mar 2022 19:17:25 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, v.sementsov-og@mail.ru, qemu-devel@nongnu.org, Markus Armbruster , hreitz@redhat.com, vsementsov@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648683574068100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 177f3ff989..b44f0ca101 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2386,7 +2386,7 @@ void qmp_transaction(TransactionActionList *actions, struct TransactionProperties *properties, Error **errp) { - TransactionActionList *act =3D actions; + TransactionActionList *act; JobTxn *block_job_txn =3D NULL; Error *local_err =3D NULL; Transaction *tran =3D tran_new(); @@ -2405,14 +2405,11 @@ void qmp_transaction(TransactionActionList *actions, bdrv_drain_all(); =20 /* We don't do anything in this loop that commits us to the operations= */ - while (NULL !=3D act) { - TransactionAction *dev_info =3D NULL; + for (act =3D actions; act; act =3D act->next) { + TransactionAction *dev_info =3D act->value; const BlkActionOps *ops; BlkActionState *state; =20 - dev_info =3D act->value; - act =3D act->next; - assert(dev_info->type < ARRAY_SIZE(actions_map)); =20 ops =3D &actions_map[dev_info->type]; --=20 2.35.1