From nobody Sun Feb 8 06:04:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164867439856891.40316947057966; Wed, 30 Mar 2022 14:06:38 -0700 (PDT) Received: from localhost ([::1]:49520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZfWX-0006WF-DU for importer@patchew.org; Wed, 30 Mar 2022 17:06:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZfUv-0003HE-DK; Wed, 30 Mar 2022 17:04:57 -0400 Received: from [2607:f8b0:4864:20::32e] (port=34391 helo=mail-ot1-x32e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZfUt-0003J1-Ny; Wed, 30 Mar 2022 17:04:57 -0400 Received: by mail-ot1-x32e.google.com with SMTP id n19-20020a9d7113000000b005cd9cff76c3so15779899otj.1; Wed, 30 Mar 2022 14:04:55 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id t19-20020a05687044d300b000de4e33171csm9988617oai.34.2022.03.30.14.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p//+aQh/WyFlQZ0jwYqkJQu/+QJtwDv0P3hrdxIZ2mY=; b=cvlB7n9Hfuy9YhV0YqvjCBAj39d26C7eneFkOd7V8ANZd/8cdnCkIB93zsE+f9aUxm TM4TPjW3ZjB0MAz5Y+RMHfuTCXp//jM+b8+U8/mYU9+Te72g8XIatjj5L9lpZGo4lWVA X0+RLCV00XrXTU370GGW4ostVad7qCY9wUbw92lxGIO8xjISEFeDI3k9ZbSx6958owHF IX4q33UhTU70n/cvR7artToBKM6UjK9DgkcoFj2PvL+aLhsankOovP5Ct/zZFGNbtIqA 7wv1IgGSxgHwJWwPrB3ESWdXI36njq/+TQ5w2cvSzOVAYWT3HLku7zhwba7ku0hX/QDy hptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p//+aQh/WyFlQZ0jwYqkJQu/+QJtwDv0P3hrdxIZ2mY=; b=zpNi4SQB0cqn21jYNNoMiSaVF48ujb0bY5sZ6qqYR16JQczAGlOVQA3C+ItBB6YBk8 hcUp7ER07yFjDJhY8DBmjRar2GzUrFDd8S4MOTAG41XqAl2Wb3sX4kVTeHK24YFEKGRc L1ujEf8FHCv4EsookVhlesBSgVVqh4CGKsIu17JaVDClXbG9PC7PYHkKVToTv/BTx2B0 BmwIERF+9MiBV2AhczII9q3nu7ALjUTLfpx7ewi0SsQECx9R4xsybZTl12z2W4XXxRFl 6BkQekOozHRCSp4iGsunUpV1JfSBCP1gZaQ2iFl1YztI3GhdqIHAY1ojC0jNQ1wfV+A0 UBoQ== X-Gm-Message-State: AOAM5328I3E861nRwnQJb42th3jWA01dZYjdT+iHXXEqZ4TqVZkjKN4D f06LaslT6900gT8KjeSOsirOgAx2RM4= X-Google-Smtp-Source: ABdhPJxYf8SSZK8puC/WzTsj1bRofqJfA5Q/wLVFKn5qTXlZQTaFldNFgCxX4JicjIQfpEOJ/E9wVg== X-Received: by 2002:a9d:6e89:0:b0:5b2:4c01:2210 with SMTP id a9-20020a9d6e89000000b005b24c012210mr4263910otr.85.1648674294147; Wed, 30 Mar 2022 14:04:54 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH 1/4] target/ppc: initialize 'reg_val' in kvm_get_one_spr() Date: Wed, 30 Mar 2022 18:04:40 -0300 Message-Id: <20220330210443.597500-2-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330210443.597500-1-danielhb413@gmail.com> References: <20220330210443.597500-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::32e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=danielhb413@gmail.com; helo=mail-ot1-x32e.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648674399390100001 Content-Type: text/plain; charset="utf-8" Valgrind isn't convinced that we are initializing the values we assign to env->spr[spr] because it doesn't understand that the 'reg_val' union is being written by the kvm_vcpu_ioctl() that follows (via struct kvm_one_reg). This results in Valgrind complaining about uninitialized values every time we use env->spr in a conditional, like this instance: =3D=3D707578=3D=3D Thread 1: =3D=3D707578=3D=3D Conditional jump or move depends on uninitialised value(= s) =3D=3D707578=3D=3D at 0xA10A40: hreg_compute_hflags_value (helper_regs.c= :106) =3D=3D707578=3D=3D by 0xA10C9F: hreg_compute_hflags (helper_regs.c:173) =3D=3D707578=3D=3D by 0xA110F7: hreg_store_msr (helper_regs.c:262) =3D=3D707578=3D=3D by 0xA051A3: ppc_cpu_reset (cpu_init.c:7168) =3D=3D707578=3D=3D by 0xD4730F: device_transitional_reset (qdev.c:799) =3D=3D707578=3D=3D by 0xD4A11B: resettable_phase_hold (resettable.c:182) =3D=3D707578=3D=3D by 0xD49A77: resettable_assert_reset (resettable.c:60) =3D=3D707578=3D=3D by 0xD4994B: resettable_reset (resettable.c:45) =3D=3D707578=3D=3D by 0xD458BB: device_cold_reset (qdev.c:296) =3D=3D707578=3D=3D by 0x48FBC7: cpu_reset (cpu-common.c:114) =3D=3D707578=3D=3D by 0x97B5EB: spapr_reset_vcpu (spapr_cpu_core.c:38) =3D=3D707578=3D=3D by 0x97BABB: spapr_cpu_core_reset (spapr_cpu_core.c:2= 09) =3D=3D707578=3D=3D Uninitialised value was created by a stack allocation =3D=3D707578=3D=3D at 0xB11F08: kvm_get_one_spr (kvm.c:543) Initializing 'reg_val' has no impact in the logic and makes Valgrind output more bearable. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/kvm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index dc93b99189..ce1b926e8c 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -543,10 +543,12 @@ static void kvm_get_one_spr(CPUState *cs, uint64_t id= , int spr) { PowerPCCPU *cpu =3D POWERPC_CPU(cs); CPUPPCState *env =3D &cpu->env; - union { + union reg_val { uint32_t u32; uint64_t u64; - } val; + }; + /* Init reg_val to avoid "uninitialised value" Valgrind warnings */ + union reg_val val =3D {0}; struct kvm_one_reg reg =3D { .id =3D id, .addr =3D (uintptr_t) &val, --=20 2.35.1 From nobody Sun Feb 8 06:04:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648674415663411.8115764273574; Wed, 30 Mar 2022 14:06:55 -0700 (PDT) Received: from localhost ([::1]:50004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZfWo-0006qp-AU for importer@patchew.org; Wed, 30 Mar 2022 17:06:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZfUx-0003MT-5o; Wed, 30 Mar 2022 17:04:59 -0400 Received: from [2001:4860:4864:20::2d] (port=35992 helo=mail-oa1-x2d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZfUv-0003JQ-PN; Wed, 30 Mar 2022 17:04:58 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-df22f50e0cso6068174fac.3; Wed, 30 Mar 2022 14:04:57 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id t19-20020a05687044d300b000de4e33171csm9988617oai.34.2022.03.30.14.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hp7pjMYBS7VgheOvT8RWUomiLcmb/XAPpz8sgeGR9mI=; b=qXjUYGgGpEJNJH2PrME6R5JtP+fs33RH6v4YzNj+g8IGVznQLl5/2cGk+Su6/lJYfw qMBWI1Zoy1waXRdgcZagpx0dz+0XTrIJnpDhyZEmBuVTD0ikxg3K4AzCIBtWiJzaYcIb K233woca2vZxuefKnUt9Pu6eMDh6g9Ju+ZxJhJc0xX93ewo0rR84pl2qoLZWv+vol2RD x+YbQ01QHjqbuvE/Mx20xif2DB+BJVt52EdtRih33CMtDKCvNqV+yVU7mQ26JS8qntYV 4gfLcPzXwAqxPf0JUIVwnUCMl5TEvCodhXboHpSpDF64nREMOeBqYeqlPwJwsfPdv8op mAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hp7pjMYBS7VgheOvT8RWUomiLcmb/XAPpz8sgeGR9mI=; b=R2cgw29Iw2ar3nHQ0kwRdQneoAxTu+V5FCr7glpTQ0k6sA6Ks5HSAxKyHrvJ2oiSd6 oJAN/lmtlpY/RwjZTlze5CePgH4HZ2mYB7nd/srCSE9IJk/THR+2iEnJ4iW6AEWB2ZNq ZED2/CuHxrTUXfVxgzFCCGO3rFHz4NdIr75B1oz9bknPKSwFD3ur7wAU4povs13AwyKk wKVa7m3YByljuxtmAN6nkV6MvEkRvmiNZRcRHgO3wY4HVV+0WMisNp/NOOOA/f2klbO3 ZJGMj62eV7+49DH7aImiLBtYcR5thPh9WfFNXLQcBvAQyp4YQRlMLoQvkMDgYMmpx4OG abaw== X-Gm-Message-State: AOAM532ioqus+ksziNYwjRq7LhvnoeOFeHVhyLZEH36Pz7sBf0SqYEFH m5RrO+YE7focZRXxYCc4EHdWEDAyLwo= X-Google-Smtp-Source: ABdhPJzN7JDIbDAlUFIK8meFg4rjsxpKKOWiY/SYpgg4jU+Uf6I4A1AkgEka1iEMtdkdzqTUsdHPCw== X-Received: by 2002:a05:6871:5cd:b0:de:b44:5045 with SMTP id v13-20020a05687105cd00b000de0b445045mr928812oan.193.1648674296112; Wed, 30 Mar 2022 14:04:56 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH 2/4] target/ppc: init 'lpcr' in kvmppc_enable_cap_large_decr() Date: Wed, 30 Mar 2022 18:04:41 -0300 Message-Id: <20220330210443.597500-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330210443.597500-1-danielhb413@gmail.com> References: <20220330210443.597500-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::2d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x2d.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648674417781100001 Content-Type: text/plain; charset="utf-8" 'lpcr' is used as an input of kvm_get_one_reg(). Valgrind doesn't understand that and it returns warnings as such for this function: =3D=3D55240=3D=3D Thread 1: =3D=3D55240=3D=3D Conditional jump or move depends on uninitialised value(s) =3D=3D55240=3D=3D at 0xB011E4: kvmppc_enable_cap_large_decr (kvm.c:2546) =3D=3D55240=3D=3D by 0x92F28F: cap_large_decr_cpu_apply (spapr_caps.c:52= 3) =3D=3D55240=3D=3D by 0x930C37: spapr_caps_cpu_apply (spapr_caps.c:921) =3D=3D55240=3D=3D by 0x955D3B: spapr_reset_vcpu (spapr_cpu_core.c:73) =3D=3D55240=3D=3D by 0x95612B: spapr_cpu_core_reset (spapr_cpu_core.c:20= 9) =3D=3D55240=3D=3D by 0x95619B: spapr_cpu_core_reset_handler (spapr_cpu_c= ore.c:218) =3D=3D55240=3D=3D by 0xD3605F: qemu_devices_reset (reset.c:69) =3D=3D55240=3D=3D by 0x92112B: spapr_machine_reset (spapr.c:1641) =3D=3D55240=3D=3D by 0x4FBD63: qemu_system_reset (runstate.c:444) =3D=3D55240=3D=3D by 0x62812B: qdev_machine_creation_done (machine.c:124= 7) =3D=3D55240=3D=3D by 0x5064C3: qemu_machine_creation_done (vl.c:2725) =3D=3D55240=3D=3D by 0x5065DF: qmp_x_exit_preconfig (vl.c:2748) =3D=3D55240=3D=3D Uninitialised value was created by a stack allocation =3D=3D55240=3D=3D at 0xB01158: kvmppc_enable_cap_large_decr (kvm.c:2540) Init 'lpcr' to avoid this warning. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index ce1b926e8c..9fb13b23d8 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2539,7 +2539,7 @@ int kvmppc_get_cap_large_decr(void) int kvmppc_enable_cap_large_decr(PowerPCCPU *cpu, int enable) { CPUState *cs =3D CPU(cpu); - uint64_t lpcr; + uint64_t lpcr =3D 0; =20 kvm_get_one_reg(cs, KVM_REG_PPC_LPCR_64, &lpcr); /* Do we need to modify the LPCR? */ --=20 2.35.1 From nobody Sun Feb 8 06:04:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648674418978402.91023381282616; Wed, 30 Mar 2022 14:06:58 -0700 (PDT) Received: from localhost ([::1]:50348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZfWr-00074q-Va for importer@patchew.org; Wed, 30 Mar 2022 17:06:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZfUz-0003Tn-Ed; Wed, 30 Mar 2022 17:05:01 -0400 Received: from [2001:4860:4864:20::2b] (port=39092 helo=mail-oa1-x2b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZfUx-0003Ji-UO; Wed, 30 Mar 2022 17:05:01 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-deb9295679so16093303fac.6; Wed, 30 Mar 2022 14:04:59 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id t19-20020a05687044d300b000de4e33171csm9988617oai.34.2022.03.30.14.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zCeHPx+YPPizP4RoU57Q+beNMp8uzlcZWD496c9+7uY=; b=hk8RE61HY9/HDl6oEX+MeJ3qFwPPoe2cODHKVEhWQ6ePZplxN5G2idEZgzyEgwk3Jo FEIHeIgnsxn7HxAY13iulWmcX/GgdyzB0Zemu6t4NMSWWLWxHnZyasNde7IgHDkWuZ4S BEUJC67FDWEHK/4ScfYO3NseOj3EL08GjXCqwFaUVcO+vVjDzwoROuR69+4i5UZYL9Bm p2jr3hZAlkKAl+mMJPs1JBqK9gMsmpHRZHwgrtxgGPGtTPRq9zmTsynhd6TIrMwohfyR bmh21TOoghlE0hANN9U4WJv3VPFpSR1ANZMfO8zn5LI5fZX0Mw4MwM+SxfpM8UJ8MVHo ar1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zCeHPx+YPPizP4RoU57Q+beNMp8uzlcZWD496c9+7uY=; b=nj0NuI28phh9hNjkmSgrwRC30qbCQGiUB44CoakNH7ILN5T6y+H0k4pdagCmNv/czA Lmv7qzR8AegxloHR8fkQWDXefF33tgVloYYJ76BDL0j7MQrD746vmz7rXzL0MQG+anQc xTNmupZbiL7+eVkyKPWHUP/5GqDi4AWleQ6MND8/zegJ7MjgKwjjT3Ew5Qk2WH5ch3IU whlKv72u8f2flyAubJWe9BpVcTmQi4zWghWNNWctOaePU78gpz0cNgSSfkk+bQTIA8yB SctTeB3U4cl0Z7bdpmsYUcciB6FfQpli7zDPE/G/pD/sFUe7m6Nmb0t3Aq243xMdC8U2 7g4Q== X-Gm-Message-State: AOAM533s0a9/IeZeTEZ09gO/h8RfcjZaFQGF8AeWFfybczB5/rPsJxFq muBx07MiiZRIv4jmC+M/+tEmXwcyvIc= X-Google-Smtp-Source: ABdhPJwRxYP8KvWiWE9GJN8fYLWpk8A7HJNATnl5Ts4Itx3+dm/FIGNT3sDO4MO5Bm88c1wl44TAKA== X-Received: by 2002:a05:6870:d24c:b0:de:243b:7ac3 with SMTP id h12-20020a056870d24c00b000de243b7ac3mr903425oac.97.1648674298260; Wed, 30 Mar 2022 14:04:58 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH 3/4] target/ppc: init 'sregs' in kvmppc_put_books_sregs() Date: Wed, 30 Mar 2022 18:04:42 -0300 Message-Id: <20220330210443.597500-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330210443.597500-1-danielhb413@gmail.com> References: <20220330210443.597500-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::2b (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x2b.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648674419516100005 Content-Type: text/plain; charset="utf-8" Init 'sregs' to avoid Valgrind complaints about uninitialized bytes from kvmppc_put_books_sregs(): =3D=3D54059=3D=3D Thread 3: =3D=3D54059=3D=3D Syscall param ioctl(generic) points to uninitialised byte= (s) =3D=3D54059=3D=3D at 0x55864E4: ioctl (in /usr/lib64/libc.so.6) =3D=3D54059=3D=3D by 0xD1FA23: kvm_vcpu_ioctl (kvm-all.c:3053) =3D=3D54059=3D=3D by 0xAFB18B: kvmppc_put_books_sregs (kvm.c:891) =3D=3D54059=3D=3D by 0xAFB47B: kvm_arch_put_registers (kvm.c:949) =3D=3D54059=3D=3D by 0xD1EDA7: do_kvm_cpu_synchronize_post_init (kvm-all= .c:2766) =3D=3D54059=3D=3D by 0x481AF3: process_queued_cpu_work (cpus-common.c:34= 3) =3D=3D54059=3D=3D by 0x4EF247: qemu_wait_io_event_common (cpus.c:412) =3D=3D54059=3D=3D by 0x4EF343: qemu_wait_io_event (cpus.c:436) =3D=3D54059=3D=3D by 0xD21E83: kvm_vcpu_thread_fn (kvm-accel-ops.c:54) =3D=3D54059=3D=3D by 0xFFEBF3: qemu_thread_start (qemu-thread-posix.c:55= 6) =3D=3D54059=3D=3D by 0x54E6DC3: start_thread (in /usr/lib64/libc.so.6) =3D=3D54059=3D=3D by 0x5596C9F: clone (in /usr/lib64/libc.so.6) =3D=3D54059=3D=3D Address 0x799d1cc is on thread 3's stack =3D=3D54059=3D=3D in frame #2, created by kvmppc_put_books_sregs (kvm.c:85= 1) =3D=3D54059=3D=3D Uninitialised value was created by a stack allocation =3D=3D54059=3D=3D at 0xAFAEB0: kvmppc_put_books_sregs (kvm.c:851) This happens because Valgrind does not consider the 'sregs' initialization done by kvm_vcpu_ioctl() at the end of the function. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 9fb13b23d8..657e735f9d 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -852,7 +852,7 @@ static int kvm_put_vpa(CPUState *cs) int kvmppc_put_books_sregs(PowerPCCPU *cpu) { CPUPPCState *env =3D &cpu->env; - struct kvm_sregs sregs; + struct kvm_sregs sregs =3D {0}; int i; =20 sregs.pvr =3D env->spr[SPR_PVR]; --=20 2.35.1 From nobody Sun Feb 8 06:04:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648674577289540.1082187164251; Wed, 30 Mar 2022 14:09:37 -0700 (PDT) Received: from localhost ([::1]:57602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZfZQ-0003ZF-BO for importer@patchew.org; Wed, 30 Mar 2022 17:09:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZfV1-0003bR-90; Wed, 30 Mar 2022 17:05:03 -0400 Received: from [2001:4860:4864:20::2f] (port=43158 helo=mail-oa1-x2f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZfUz-0003Jw-RS; Wed, 30 Mar 2022 17:05:02 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-df02f7e2c9so10889967fac.10; Wed, 30 Mar 2022 14:05:01 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id t19-20020a05687044d300b000de4e33171csm9988617oai.34.2022.03.30.14.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lL7H2QIk1rs7GW6yHadg7JRxQ47pjPye7VdUjbYVtaU=; b=HznvaKMIC4K7QhhDxQJO4jf/D0/UnTAexrd6bgAWselWDFvl4nLo2CHXkRmKv2iv55 /xCHoeTLgxoMnoOdKX/jd6k91DJQNOzjj/uZwJUstSHD5J7lL6Y8LzOFWsAF9MXUdW5F 7BqGsiI8u5kxEIR5Ad/CDC02d0/MWwV1hRiYzZVf9TOcu1b82kMV/+WvQgBWcUZUm6xk hvaT+OnH+1Ti0hvxQ0kMHCCeXwei8RDFKGMNLOc64yZdpFqBPkWvdQxjaaUcCUde0lix EgAT16xr7fPYPXK9UtuYpDR1RJQetkOo8l2bT9FgWsD+lfONfWDaELz2gUI5lcUExMhh a1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lL7H2QIk1rs7GW6yHadg7JRxQ47pjPye7VdUjbYVtaU=; b=zKnoXFUZKBW+ra9CgFOzYby/luC19v9nyoKb86H9BSrbq0WLoSVFawG/6hKJRGosS5 ToJE/feg/WkSjtbDDejertKsTb0H9rTYsZN9pbC28UbqM8Cn3xydBUft9A/lWYOXRuv6 o3+Whz3JxihSlszKvDA7sUm41EN6d+xhNti6FznRHLdh061WagWXGWAIYoG89wN1QUG6 xxd/d2SE+TviRimQXbV2XVT9nIBgcHVCcIdhD71ufTW8zy+zec425U1+iFJIOwxtlnU7 UDNgPHA6j2xED5H5dMRfFueS4JlO8HBhtW5nvQwI8PFdVLKQ6a9ffIXqMqqNzuqAbiVg 3nMg== X-Gm-Message-State: AOAM5312DWAwIUmUT1tuI0bHc8D01Uxm4jwJcctO8PJbDdRtyhkHg9FA qw9NU3lhqunwerbB77cmOKFgLQJZtns= X-Google-Smtp-Source: ABdhPJwRHzx/7AYf8ZGD08jsWoooxc4dh6CBsXGrFvpdpubxYEUdtzfRb/sGhk0CD00scL0JorjJ+w== X-Received: by 2002:a05:6870:1683:b0:dd:cdf2:47d6 with SMTP id j3-20020a056870168300b000ddcdf247d6mr978821oae.50.1648674300289; Wed, 30 Mar 2022 14:05:00 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH 4/4] target/ppc: init 'rmmu_info' in kvm_get_radix_page_info() Date: Wed, 30 Mar 2022 18:04:43 -0300 Message-Id: <20220330210443.597500-5-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330210443.597500-1-danielhb413@gmail.com> References: <20220330210443.597500-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::2f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2f; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x2f.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648674578631100003 Content-Type: text/plain; charset="utf-8" Init the struct to avoid Valgrind complaints about unitialized bytes, such as this one: =3D=3D39549=3D=3D Syscall param ioctl(generic) points to uninitialised byte= (s) =3D=3D39549=3D=3D at 0x55864E4: ioctl (in /usr/lib64/libc.so.6) =3D=3D39549=3D=3D by 0xD1F7EF: kvm_vm_ioctl (kvm-all.c:3035) =3D=3D39549=3D=3D by 0xAF8F5B: kvm_get_radix_page_info (kvm.c:276) =3D=3D39549=3D=3D by 0xB00533: kvmppc_host_cpu_class_init (kvm.c:2369) =3D=3D39549=3D=3D by 0xD3DCE7: type_initialize (object.c:366) =3D=3D39549=3D=3D by 0xD3FACF: object_class_foreach_tramp (object.c:1071) =3D=3D39549=3D=3D by 0x502757B: g_hash_table_foreach (in /usr/lib64/libg= lib-2.0.so.0.7000.5) =3D=3D39549=3D=3D by 0xD3FC1B: object_class_foreach (object.c:1093) =3D=3D39549=3D=3D by 0xB0141F: kvm_ppc_register_host_cpu_type (kvm.c:261= 3) =3D=3D39549=3D=3D by 0xAF87E7: kvm_arch_init (kvm.c:157) =3D=3D39549=3D=3D by 0xD1E2A7: kvm_init (kvm-all.c:2595) =3D=3D39549=3D=3D by 0x8E6E93: accel_init_machine (accel-softmmu.c:39) =3D=3D39549=3D=3D Address 0x1fff00e208 is on thread 1's stack =3D=3D39549=3D=3D in frame #2, created by kvm_get_radix_page_info (kvm.c:2= 67) =3D=3D39549=3D=3D Uninitialised value was created by a stack allocation =3D=3D39549=3D=3D at 0xAF8EE8: kvm_get_radix_page_info (kvm.c:267) Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 657e735f9d..f22cf75ade 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -267,7 +267,7 @@ struct ppc_radix_page_info *kvm_get_radix_page_info(voi= d) { KVMState *s =3D KVM_STATE(current_accel()); struct ppc_radix_page_info *radix_page_info; - struct kvm_ppc_rmmu_info rmmu_info; + struct kvm_ppc_rmmu_info rmmu_info =3D {0}; int i; =20 if (!kvm_check_extension(s, KVM_CAP_PPC_MMU_RADIX)) { --=20 2.35.1