From nobody Tue Feb 10 08:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1648646083231868.2495245583989; Wed, 30 Mar 2022 06:14:43 -0700 (PDT) Received: from localhost ([::1]:42722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZY9q-0002u2-2H for importer@patchew.org; Wed, 30 Mar 2022 09:14:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZXse-0006oU-Az; Wed, 30 Mar 2022 08:56:59 -0400 Received: from beetle.greensocs.com ([5.135.226.135]:41058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZXsb-0004Zb-9m; Wed, 30 Mar 2022 08:56:54 -0400 Received: from crumble.bar.greensocs.com (unknown [172.17.10.6]) by beetle.greensocs.com (Postfix) with ESMTPS id 10E1621EBF; Wed, 30 Mar 2022 12:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1648645009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cuMqYjKLUiOJpMyaEYbHpLc1NjYNYXkz7u4Bj2qu9+0=; b=AF5vgjPKJfLfOCE8JJV0wIHVMssFOH9O+283ap/NOqh3nvzncFwiViz4w2H1j70ovAdUCk H6zETNsRK3hmb/k2LH1knxYvkM2faq77tkaDrymyqd8xr8xTI/GixhEENC+/1AMd/14Bwa srv/dw8yRP2afosiJbf2Wx2P+i7a9us= From: Damien Hedde To: qemu-devel@nongnu.org Subject: [RFC PATCH 06/18] hw/cpu/cluster: remove cluster_id now that gdbstub is updated Date: Wed, 30 Mar 2022 14:56:27 +0200 Message-Id: <20220330125639.201937-7-damien.hedde@greensocs.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220330125639.201937-1-damien.hedde@greensocs.com> References: <20220330125639.201937-1-damien.hedde@greensocs.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam: Yes Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.135.226.135; envelope-from=damien.hedde@greensocs.com; helo=beetle.greensocs.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Peter Maydell , Bin Meng , qemu-riscv@nongnu.org, Alistair Francis , mark.burton@greensocs.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Eduardo Habkost , qemu-arm@nongnu.org, Palmer Dabbelt , Vijai Kumar K , "Edgar E. Iglesias" , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1648646085057100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Damien Hedde --- include/hw/cpu/cluster.h | 7 ------- hw/cpu/cluster.c | 7 ------- 2 files changed, 14 deletions(-) diff --git a/include/hw/cpu/cluster.h b/include/hw/cpu/cluster.h index 2125765f21..6704434cc0 100644 --- a/include/hw/cpu/cluster.h +++ b/include/hw/cpu/cluster.h @@ -60,17 +60,10 @@ OBJECT_DECLARE_TYPE(CPUClusterState, CPUClusterClass, C= PU_CLUSTER) =20 /** * CPUClusterState: - * @cluster_id: The cluster ID. This value is for internal use only and sh= ould - * not be exposed directly to the user or to the guest. - * - * State of a CPU cluster. */ struct CPUClusterState { /*< private >*/ CpusState parent_obj; - - /*< public >*/ - uint32_t cluster_id; }; =20 /** diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c index 3daf897bd9..51da6ce3a9 100644 --- a/hw/cpu/cluster.c +++ b/hw/cpu/cluster.c @@ -42,7 +42,6 @@ static int add_cpu_to_cluster(Object *obj, void *opaque) static void cpu_cluster_realize(DeviceState *dev, Error **errp) { CPUClusterClass *ccc =3D CPU_CLUSTER_GET_CLASS(dev); - CPUClusterState *cluster =3D CPU_CLUSTER(dev); CpusState *base =3D CPUS(dev); Object *cluster_obj =3D OBJECT(dev); =20 @@ -64,12 +63,6 @@ static void cpu_cluster_realize(DeviceState *dev, Error = **errp) =20 /* realize base class (will set cluster field to true) */ ccc->parent_realize(dev, errp); - - /* - * Temporarily copy the cluster id from the base class as - * gdbstub still uses our field. - */ - cluster->cluster_id =3D base->cluster_index; } =20 static void cpu_cluster_class_init(ObjectClass *klass, void *data) --=20 2.35.1