From nobody Mon Feb 9 08:05:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647899055; cv=none; d=zohomail.com; s=zohoarc; b=Qb9ilcsFANLMwfxOyp56tjdmQ5pcIv7QNoEkDW9IU2KrRQGaS5ododfDkyIpLNSKva1juTg7QEJ7HKGOhpiSqlozWgl6eOtrYVCjdrDIKZbHqFoqVMq8HCKLyEP0fe/OmrYt3jMM0m27cXB2/a0n14MY0+q195IRciCU9sNiTfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647899055; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0SgXAWFOWDLwA7FDLllMePxZxsyCzX/iGb5U8mOnV+4=; b=NmTUKvWt70RCd+cmWJqzYiCi1zwxzRYYkC2fzDW/heFUXYHK6djD0q/5/9Q1+SXeZZJMszHaGz1bKKBGGux5ywFozQN3dEbbJ6rT8dm1r9qOaXZ6aSkQni2baOrnvTWUq/ybYaII7UVEP4uHI46lUtdQ7aB5+7SYDuL46OQGkBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647899055651360.63340541496325; Mon, 21 Mar 2022 14:44:15 -0700 (PDT) Received: from localhost ([::1]:52316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWPp1-00078J-Dy for importer@patchew.org; Mon, 21 Mar 2022 17:44:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmk-00050j-9m for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmf-0006NQ-W9 for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:53 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-mM_FiFMsPXeN93rNeLjCaQ-1; Mon, 21 Mar 2022 17:41:38 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2EF918E53C5; Mon, 21 Mar 2022 21:41:37 +0000 (UTC) Received: from blue.redhat.com (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8523644198E; Mon, 21 Mar 2022 21:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647898909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0SgXAWFOWDLwA7FDLllMePxZxsyCzX/iGb5U8mOnV+4=; b=XgRkiGXth72mtBbk5iunhys4Gq/bx8LAC89qRFaZrjUIHiwcSpPnVZt3DFqMgbk/TSjZDJ fiqLw2lDnbMLIhrdiOauXWhWJ5nDgbYrZ9u5QWvwalotOcaklNzACHUViRKy3YeLrm2Fp1 CkN0tRKWQQPaCyhGLuPP1LEU1uxSh1M= X-MC-Unique: mM_FiFMsPXeN93rNeLjCaQ-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 1/3] MAINTAINERS: change Vladimir's email address Date: Mon, 21 Mar 2022 16:41:32 -0500 Message-Id: <20220321214134.597006-2-eblake@redhat.com> In-Reply-To: <20220321214134.597006-1-eblake@redhat.com> References: <20220321214134.597006-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647899085205100001 Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy Old vsementsov@virtuozzo.com is not accessible anymore. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20220316092702.426629-1-v.sementsov-og@mail.ru> Signed-off-by: Eric Blake --- MAINTAINERS | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9aed5f3e04e4..cc364afef733 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2507,7 +2507,7 @@ F: scsi/* Block Jobs M: John Snow -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy L: qemu-block@nongnu.org S: Supported F: blockjob.c @@ -2546,7 +2546,7 @@ T: git https://repo.or.cz/qemu/armbru.git block-next Dirty Bitmaps M: Eric Blake -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy R: John Snow L: qemu-block@nongnu.org S: Supported @@ -2770,13 +2770,13 @@ F: scripts/*.py F: tests/*.py Benchmark util -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy S: Maintained F: scripts/simplebench/ T: git https://src.openvz.org/scm/~vsementsov/qemu.git simplebench Transactions helper -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy S: Maintained F: include/qemu/transactions.h F: util/transactions.c @@ -3360,7 +3360,7 @@ F: block/iscsi-opts.c Network Block Device (NBD) M: Eric Blake -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy L: qemu-block@nongnu.org S: Maintained F: block/nbd* @@ -3456,7 +3456,7 @@ F: block/dmg.c parallels M: Stefan Hajnoczi M: Denis V. Lunev -M: Vladimir Sementsov-Ogievskiy +M: Vladimir Sementsov-Ogievskiy L: qemu-block@nongnu.org S: Supported F: block/parallels.c --=20 2.35.1 From nobody Mon Feb 9 08:05:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647899030512291.06828039695154; Mon, 21 Mar 2022 14:43:50 -0700 (PDT) Received: from localhost ([::1]:51938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWPoa-0006t2-U7 for importer@patchew.org; Mon, 21 Mar 2022 17:43:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmi-00050A-Ki for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmf-0006JO-TP for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:51 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-AxEU3sliNfKzuPGicOQr1Q-1; Mon, 21 Mar 2022 17:41:40 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 976681C0906F; Mon, 21 Mar 2022 21:41:38 +0000 (UTC) Received: from blue.redhat.com (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 304B044198E; Mon, 21 Mar 2022 21:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647898901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCTcHVbYb1YfYF08FZ/Qz/RAMPM8ZaRDECqKU9dIBJI=; b=dSDhR6A7ftQbJttFBkgJjjpCOlh90PQ5LrFI6XL2YL8n522O4ALo1uL0419pvAAE5NeFV5 yxqI/fDlygbBVEmH6L2MAh75BVRhgTE8VcvkjhHfhDERUAC7pp9aTUsjk1lHVAI7GOCngW b03zvkifPAj0fPC2BRnCwidfj7eTxD8= X-MC-Unique: AxEU3sliNfKzuPGicOQr1Q-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 2/3] docs: Consistent typography for options of qemu-nbd Date: Mon, 21 Mar 2022 16:41:33 -0500 Message-Id: <20220321214134.597006-3-eblake@redhat.com> In-Reply-To: <20220321214134.597006-1-eblake@redhat.com> References: <20220321214134.597006-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , "open list:Network Block Dev..." Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1647899032084100001 Prefer the :option:`--name` form when cross-referencing other options from the qemu-nbd documentation. Signed-off-by: Eric Blake Message-Id: <20220314203818.3681277-2-eblake@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/tools/qemu-nbd.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/tools/qemu-nbd.rst b/docs/tools/qemu-nbd.rst index 2b8c90c35498..4c950f61998e 100644 --- a/docs/tools/qemu-nbd.rst +++ b/docs/tools/qemu-nbd.rst @@ -27,7 +27,7 @@ Options .. program:: qemu-nbd *filename* is a disk image filename, or a set of block -driver options if ``--image-opts`` is specified. +driver options if :option:`--image-opts` is specified. *dev* is an NBD device. @@ -165,9 +165,9 @@ driver options if ``--image-opts`` is specified. .. option:: --tls-creds=3DID Enable mandatory TLS encryption for the server by setting the ID - of the TLS credentials object previously created with the --object - option; or provide the credentials needed for connecting as a client - in list mode. + of the TLS credentials object previously created with the + :option:`--object` option; or provide the credentials needed for + connecting as a client in list mode. .. option:: --tls-hostname=3Dhostname @@ -176,11 +176,11 @@ driver options if ``--image-opts`` is specified. against information in the server provided certificate. Sometimes it might be required to override the hostname used to perform this check. For example, if the NBD client is using a tunnel from localhost - to connect to the remote server, the `--tls-hostname` option should + to connect to the remote server, the :option:`--tls-hostname` option sho= uld be used to set the officially expected hostname of the remote NBD server. This can also be used if accessing NBD over a UNIX socket where there is no inherent hostname available. This is only permitted - when acting as a NBD client with the `--list` option. + when acting as a NBD client with the :option:`--list` option. .. option:: --fork --=20 2.35.1 From nobody Mon Feb 9 08:05:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164789924207752.893950251360366; Mon, 21 Mar 2022 14:47:22 -0700 (PDT) Received: from localhost ([::1]:58194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWPs0-0002vc-Nq for importer@patchew.org; Mon, 21 Mar 2022 17:47:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmk-00050k-9Z for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:29620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPmf-0006M5-UW for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:41:53 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-393-LHo12okxMlWJEK7_HXbzUg-1; Mon, 21 Mar 2022 17:41:43 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 727C4851785; Mon, 21 Mar 2022 21:41:40 +0000 (UTC) Received: from blue.redhat.com (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7D9344198F; Mon, 21 Mar 2022 21:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647898906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFUkW4449ePvuDQ+5BOXtvf2hWWsWgUMixtARwJpjXE=; b=aysUvwkaSPdjZn2d8ZEFMpruy6ScPaoSqrdeFOohwmIt5oiVISZflAIkBkX9JUdCC4q/A4 erv6A4hHzBbaxahGXgwXF6H3wKXhTs059ln9coO61zCJ+HvFXAE8H62cUmrm79ce3mnth4 iohWfpk3/PGUoIqiYIdf20R5varWeNo= X-MC-Unique: LHo12okxMlWJEK7_HXbzUg-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 3/3] block/nbd.c: Fixed IO request coroutine not being wakeup when kill NBD server Date: Mon, 21 Mar 2022 16:41:34 -0500 Message-Id: <20220321214134.597006-4-eblake@redhat.com> In-Reply-To: <20220321214134.597006-1-eblake@redhat.com> References: <20220321214134.597006-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , "open list:Network Block Dev..." , Rao Lei , Hanna Reitz , Vladimir Sementsov-Ogievskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1647899243335100001 Content-Type: text/plain; charset="utf-8" From: Rao Lei During the IO stress test, the IO request coroutine has a probability that = is can't be awakened when the NBD server is killed. The GDB stack is as follows: (gdb) bt 0 0x00007f2ff990cbf6 in __ppoll (fds=3D0x55575de85000, nfds=3D1, timeout= =3D, sigmask=3D0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:44 1 0x000055575c302e7c in qemu_poll_ns (fds=3D0x55575de85000, nfds=3D1, time= out=3D599999603140) at ../util/qemu-timer.c:348 2 0x000055575c2d3c34 in fdmon_poll_wait (ctx=3D0x55575dc480f0, ready_list= =3D0x7ffd9dd1dae0, timeout=3D599999603140) at ../util/fdmon-poll.c:80 3 0x000055575c2d350d in aio_poll (ctx=3D0x55575dc480f0, blocking=3Dtrue) a= t ../util/aio-posix.c:655 4 0x000055575c16eabd in bdrv_do_drained_begin(bs=3D0x55575dee7fe0, recursi= ve=3Dfalse, parent=3D0x0, ignore_bds_parents=3Dfalse, poll=3Dtrue)at ../blo= ck/io.c:474 5 0x000055575c16eba6 in bdrv_drained_begin (bs=3D0x55575dee7fe0) at ../blo= ck/io.c:480 6 0x000055575c1aff33 in quorum_del_child (bs=3D0x55575dee7fe0, child=3D0x5= 5575dcea690, errp=3D0x7ffd9dd1dd08) at ../block/quorum.c:1130 7 0x000055575c14239b in bdrv_del_child (parent_bs=3D0x55575dee7fe0, child= =3D0x55575dcea690, errp=3D0x7ffd9dd1dd08) at ../block.c:7705 8 0x000055575c12da28 in qmp_x_blockdev_change(parent=3D0x55575df404c0 "col= o-disk0", has_child=3Dtrue, child=3D0x55575de867f0 "children.1", has_node= =3Dfalse, no de=3D0x0, errp=3D0x7ffd9dd1dd08) at ../blockdev.c:3676 9 0x000055575c258435 in qmp_marshal_x_blockdev_change (args=3D0x7f2fec0081= 90, ret=3D0x7f2ff7b0bd98, errp=3D0x7f2ff7b0bd90) at qapi/qapi-commands-bloc= k-core.c :1675 10 0x000055575c2c6201 in do_qmp_dispatch_bh (opaque=3D0x7f2ff7b0be30) at ..= /qapi/qmp-dispatch.c:129 11 0x000055575c2ebb1c in aio_bh_call (bh=3D0x55575dc429c0) at ../util/async= .c:141 12 0x000055575c2ebc2a in aio_bh_poll (ctx=3D0x55575dc480f0) at ../util/asyn= c.c:169 13 0x000055575c2d2d96 in aio_dispatch (ctx=3D0x55575dc480f0) at ../util/aio= -posix.c:415 14 0x000055575c2ec07f in aio_ctx_dispatch (source=3D0x55575dc480f0, callbac= k=3D0x0, user_data=3D0x0) at ../util/async.c:311 15 0x00007f2ff9e7cfbd in g_main_context_dispatch () at /lib/x86_64-linux-gn= u/libglib-2.0.so.0 16 0x000055575c2fd581 in glib_pollfds_poll () at ../util/main-loop.c:232 17 0x000055575c2fd5ff in os_host_main_loop_wait (timeout=3D0) at ../util/ma= in-loop.c:255 18 0x000055575c2fd710 in main_loop_wait (nonblocking=3D0) at ../util/main-l= oop.c:531 19 0x000055575bfa7588 in qemu_main_loop () at ../softmmu/runstate.c:726 20 0x000055575bbee57a in main (argc=3D60, argv=3D0x7ffd9dd1e0e8, envp=3D0x7= ffd9dd1e2d0) at ../softmmu/main.c:50 (gdb) qemu coroutine 0x55575e16aac0 0 0x000055575c2ee7dc in qemu_coroutine_switch (from_=3D0x55575e16aac0, to_= =3D0x7f2ff830fba0, action=3DCOROUTINE_YIELD) at ../util/coroutine-ucontext.= c:302 1 0x000055575c2fe2a9 in qemu_coroutine_yield () at ../util/qemu-coroutine.= c:195 2 0x000055575c2fe93c in qemu_co_queue_wait_impl (queue=3D0x55575dc46170, l= ock=3D0x7f2b32ad9850) at ../util/qemu-coroutine-lock.c:56 3 0x000055575c17ddfb in nbd_co_send_request (bs=3D0x55575ebfaf20, request= =3D0x7f2b32ad9920, qiov=3D0x55575dfc15d8) at ../block/nbd.c:478 4 0x000055575c17f931 in nbd_co_request (bs=3D0x55575ebfaf20, request=3D0x7= f2b32ad9920, write_qiov=3D0x55575dfc15d8) at ../block/nbd.c:1182 5 0x000055575c17fe14 in nbd_client_co_pwritev (bs=3D0x55575ebfaf20, offset= =3D403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, flags=3D0) at ../b= lock/nbd.c:1284 6 0x000055575c170d25 in bdrv_driver_pwritev (bs=3D0x55575ebfaf20, offset= =3D403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, qiov_offset=3D0, f= lags=3D0) at ../block/io.c:1264 7 0x000055575c1733b4 in bdrv_aligned_pwritev (child=3D0x55575dff6890, req=3D0x7f2b32ad9ad0, offset=3D403487858688, b= ytes=3D4538368, align=3D1, qiov=3D0x55575dfc15d8, qiov_offset=3D0, flags=3D= 0) at ../block/io.c:2126 8 0x000055575c173c67 in bdrv_co_pwritev_part (child=3D0x55575dff6890, offs= et=3D403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, qiov_offset=3D0,= flags=3D0) at ../block/io.c:2314 9 0x000055575c17391b in bdrv_co_pwritev (child=3D0x55575dff6890, offset=3D= 403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, flags=3D0) at ../bloc= k/io.c:2233 10 0x000055575c1ee506 in replication_co_writev (bs=3D0x55575e9824f0, sector= _num=3D788062224, remaining_sectors=3D8864, qiov=3D0x55575dfc15d8, flags=3D= 0) at ../block/replication.c:270 11 0x000055575c170eed in bdrv_driver_pwritev (bs=3D0x55575e9824f0, offset= =3D403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, qiov_offset=3D0, f= lags=3D0) at ../block/io.c:1297 12 0x000055575c1733b4 in bdrv_aligned_pwritev (child=3D0x55575dcea690, req=3D0x7f2b32ad9e00, offset=3D403487858688, b= ytes=3D4538368, align=3D512, qiov=3D0x55575dfc15d8, qiov_offset=3D0, flags= =3D0) at ../block/io.c:2126 13 0x000055575c173c67 in bdrv_co_pwritev_part (child=3D0x55575dcea690, offs= et=3D403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, qiov_offset=3D0,= flags=3D0) at ../block/io.c:2314 14 0x000055575c17391b in bdrv_co_pwritev (child=3D0x55575dcea690, offset=3D= 403487858688, bytes=3D4538368, qiov=3D0x55575dfc15d8, flags=3D0) at ../bloc= k/io.c:2233 15 0x000055575c1aeffa in write_quorum_entry (opaque=3D0x7f2fddaf8c50) at ..= /block/quorum.c:699 16 0x000055575c2ee4db in coroutine_trampoline (i0=3D1578543808, i1=3D21847)= at ../util/coroutine-ucontext.c:173 17 0x00007f2ff9855660 in __start_context () at ../sysdeps/unix/sysv/linux/x= 86_64/__start_context.S:91 When we do failover in COLO mode, QEMU will hang while it is waiting for the in-flight IO. From the call trace, we can see the IO request coroutine has yielded in nbd_co_send_request(). When we kill the NBD server, it will = never be wake up. Actually, when we do IO stress test, it will have a lot of requests in free_sema queue. When the NBD server is killed, current MAX_NBD_REQUESTS finishes with errors but they wake up at most MAX_NBD_REQEUSTS from the queue. So, let's move qemu_co_queue_next out to fix this issue. Signed-off-by: Lei Rao Message-Id: <20220309074844.275450-1-lei.rao@intel.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nbd.c b/block/nbd.c index 34b9429de387..567872ac5338 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -533,8 +533,8 @@ err: if (i !=3D -1) { s->requests[i].coroutine =3D NULL; s->in_flight--; - qemu_co_queue_next(&s->free_sema); } + qemu_co_queue_next(&s->free_sema); } qemu_co_mutex_unlock(&s->send_mutex); return rc; --=20 2.35.1