From nobody Wed May 15 16:16:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=2; a=rsa-sha256; t=1647872450; cv=pass; d=zohomail.com; s=zohoarc; b=B040+r98N3xio6SbTWzW0BmkH8zl/wmfKnpRybNmtV0hgehQWEoNCk8Hv2sAAdvVG3ZjFmID9hTXW9McS401OtxgMZZot1n45Br+MOSCb17SC8Lauix6j4FBA5plCNI/vzlKHOCx7xYLK1vpjErd5JcH5OhPkgIHSVq5xEWid1Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647872450; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sY8w2P2t4x8VdRK7Lv2C+ZZz462dHOfHvSBQcFRHxhY=; b=UTvBnDsM8/w+7eaPaE4ZdABr+GdifErwnugBlcUIau7sHHp+qsC2nMvTGFoe+CTQGLLjXUZ/ZMIbzUEradhpiP9pxc8dRz5pKsnHqFUXuJiLrZWCIf73Ah+v43RCLMvv5czwYK46vaK7YSLzpiwkV517OGZ7XvEl+kInlvU/hzM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647872450377753.5828351864026; Mon, 21 Mar 2022 07:20:50 -0700 (PDT) Received: from localhost ([::1]:40966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIts-00069v-Pc for importer@patchew.org; Mon, 21 Mar 2022 10:20:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWIns-0008Ud-1r for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:14548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInp-0002R4-Ix for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:35 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCw9ln022265; Mon, 21 Mar 2022 14:14:20 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew5kckd1t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:20 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LE5cUb051515; Mon, 21 Mar 2022 14:14:19 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by userp3020.oracle.com with ESMTP id 3exawgse9r-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:19 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) by BN6PR1001MB2258.namprd10.prod.outlook.com (2603:10b6:405:2f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 14:14:18 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15]) by SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15%5]) with mapi id 15.20.5081.018; Mon, 21 Mar 2022 14:14:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=sY8w2P2t4x8VdRK7Lv2C+ZZz462dHOfHvSBQcFRHxhY=; b=zwmd2QBkgebUwtAYohuM81dGXw3urpcJhMpoYllj1v2z7zThoKKtZh7/gnehpf+MtA62 YGjhoajleLTyUGH6FStyo35aTRGLH7A5qtbh5OlnyuJ2CHDfAGhUO0iIE0K9XGRQJNk+ RO29ErLLtU8dl1NsBQX5DG3RCN9/rYZo/cbXyhfO4rFfyTtKzGHP6i7BN7qTr4e4HF4E ORF44fR+xpgwQ+MgMyKmnoefl1AufcvgROen1Ye14KAVgBz3066W69y38YfKx1C/FSKY fBnSjhmhwcAKVBouZNxKB9hqhBbPku7V+TvF5Mu8TcFZdgmNSAF+adZk92PleyetMlN0 pA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kthslV34ZuKKLHDvWprllxyTafaiHEyKaLp5qovffO5LuzBGHTnmMFZ7jb/6YgU9jgZLgyRZNEDV2TUkj4Di6GpSHsQVoVxPP0f+hFNK9mXxGEuSOb3mcQwvOc9bn+vPPWTfV7rrnwpc8mxebeahjGpOvC1eHozNflYSGpznu3GtDSVZh11tIB1hc0zg9EzB1busPaAZtfVtxla/SqED9YtQE7NC9ahVQ41Q2MKfKc5F4yy/yNrLXUCy5AhmfMT7jMJlIysVIBpi5YISCI13rT9VjmubQOiql6B0Ob/YUbvu4lriMfliEsWGgUddT+k9y+BQPH1nyDyHca4eFTbAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sY8w2P2t4x8VdRK7Lv2C+ZZz462dHOfHvSBQcFRHxhY=; b=myVCct7fqcPPkX+cstfglXyCAjhhcVlkdrA7p95uJQL8gg1g4cK5eKzf76bG2pqkKuqpABDyF5exxcfU7jN6dFYrSxeiSyCSBM2fhzIcyeFCQ6nj/fwvmo1BhY2b2PRNrS0Zt8oJcTYgK7ulB9FkK1yo4FdawhX+8VfGCm3sgGO/5ArDTRkJx8stSWZLIyzVVbFEpE/B+AM9YA+jIFcYNkZC7TVvKwYrgw3WcvEh3mrZXk/Kof5BP3+M9CnSgPvjVRHi0gCYU4BkIcRbZATnkvsNcqlAmQwhRaE1t/YmgbH7R4TVqd7vRueLsWPvfM2MoIKKLw51dDdBlq/sjF6M5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sY8w2P2t4x8VdRK7Lv2C+ZZz462dHOfHvSBQcFRHxhY=; b=RbevLrh65k+SGl6heu9/pVNZfUl/63N1yEpb/rFxtXojroXbX+HhOk3nmotP/aa4dBCuv1DrQMYMMBeml1u/I49/aTM5lyP32RzQZd3TlXRJ6tZcbi+PDKd64GO5dsXo5eEv5x6RNR5JCQ4tlb8s7XKNsqGxViAm1cEH8Y1YbMg= From: Mark Kanda To: qemu-devel@nongnu.org Subject: [PATCH v3 1/5] accel: Introduce AccelOpsClass::destroy_vcpu_thread() Date: Mon, 21 Mar 2022 09:14:05 -0500 Message-Id: <20220321141409.3112932-2-mark.kanda@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220321141409.3112932-1-mark.kanda@oracle.com> References: <20220321141409.3112932-1-mark.kanda@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR03CA0096.namprd03.prod.outlook.com (2603:10b6:5:333::29) To SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f0a7474-c24a-48f4-060a-08da0b45161e X-MS-TrafficTypeDiagnostic: BN6PR1001MB2258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XbeU4/DRcuh2tw3qPeDCINIXcoN6W+3pnveyfcUfkQUJ1f3q/J9BTQXL+ml2iTyR+PgVggopxB0IpzPQ36an3YUKHnim4/uLgJvUOC5PLWRUtj6hSm9pY1u1IoVhrhSRmxaYy7fq2lAI7SIkODbVmXg9s8HM1DLuSB1b6xsUheqlzVGWpmGdaLcKRgtmh3YQG4oLjjWmmhT3LUgiyx9J3NwLRTWHtUSAuRB/WvpRUHcUCFRDJtP82vO+3Cb7l1WI06rwvoZEdqmKrax72DK+K+76TDHO0AFCAyl/n8BS1eZU6xlgQS2FutiycClcoQAUgQd+8R6EbHVbFSJ3rPJhRlbEOoJGPgP/dSZaIs6BTZ+zQVh20Duk/mBpqxjr93jJ9LQfR4Rvt3D0K1imtsDU8J9t0fgMz1uj4vy6Q+nD/+Z6m9kdPVNcaK+VKHssoZ5wcm2x8SlX5/TpKFKUDUQdcgPjQAW389cfmRqWsYZ3CBiRILV1kycQnBxb6Ans2eoT+oD0yfv6w90kQQzXGPMsOZh0NVTrAGD+4QrdkebllSxlLtqe6EuZq5KlnwmYMmAKNSVJiPUNCAnE5Vvis4rRe1pPMEBpzU8/FZCzWVHniKY00dxUYSWY1vsLRU4h64J2auuq9ELpYMKbejwDHAN/oAbFryZTYFo8Ybit72viQytDfB4MlRPgTcE0oDRLT+85s3wdTwfumUNUmCtVDi2G0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR10MB5841.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(2616005)(2906002)(6506007)(508600001)(6666004)(66476007)(316002)(186003)(66556008)(66946007)(83380400001)(6916009)(44832011)(26005)(1076003)(8676002)(4326008)(6512007)(86362001)(52116002)(6486002)(5660300002)(8936002)(38100700002)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2Z5VWNwWUVyT09QUERLNXJFMDdQUEhqdVMxdEJ4KzJlY2FFd3A2RHZLZWFi?= =?utf-8?B?dVVSaE9nbHk4MFlKcDE3QzhOOWplR0RYaTBpSnlHWjhyelN5ZVc5YU5pUnl4?= =?utf-8?B?OElqU3h3dmN2WGdwcWFLTFpHdUwvSXd5M2hmaUNJOGJLOTJsQXJoamhpTW8z?= =?utf-8?B?emxjdjBlQWx5WjFqMmJ5eWU3SUpIaUhFMytpNkYraVo5YkZkL255ZENaSzV5?= =?utf-8?B?alRiUXJ1QUdHUUpJeUFkVFNSSTJ1cHZEeDRhSHZOYUdqeFlaaWNwbGZsV09W?= =?utf-8?B?S1hwenA2M2dCVUVvN016OU1vYWIyUXlBT01RNjlKY3ZXb2U3TkljbkVrTzdJ?= =?utf-8?B?L254Y2szQ3ZXem1rRG8wK3pCeXJkSE42akh0c1BndzcwWTk5RkU3dUFvU050?= =?utf-8?B?eG4zN0V6NVRhQ25QMUNoSzlRbTR4MUhOQ1JhK0g3OWQ2Uk92bkxKeUt6T3k3?= =?utf-8?B?SmJHYjMxMm0zNnU0KzgyeG03RlZtV2FTVUIxOWl1dXNUVm9lRXpWZWJIWVlN?= =?utf-8?B?VElPZUxxcVFlNGNzd0lVWSsxMlV5UUlENUtNaCtUMlQ3c0ZvN1M2aUh0U3BF?= =?utf-8?B?M2ZHWmdDcmZ3QnRzRjZvM1ZLVEpQQ0o1Rk9sc3Z6YXFWNi95dEVoaWQ2bDQ5?= =?utf-8?B?SjlaejhSSkRhbEZZUUlkYkNsRkdjdTF1RElZdktzRHp6SVZTbVBHREF2WG5w?= =?utf-8?B?THRzZTZsMFZLbExHcUVJOXFZOXV6eHlKV2RzRDdpU3UvdFZKdFFKdnlBTFpI?= =?utf-8?B?RmtFWjc1aE5FQ2dHb243bUJ3akZrQ2NSZG51SGdIODFtL3EzK016dDJSOFhH?= =?utf-8?B?cnVyU0NvNFJ3VGF1d0duNDRwbFZkUXR2RTNPSkU4WGJJT3Nydk4xSS9PN1lU?= =?utf-8?B?eFhQM2FXcDZqOUV1alExR3lXQWtCR284VWluWTlOeFpDRktaUkIvU3hzRXRt?= =?utf-8?B?N0R2VHRxZjhERlRaTTlPZW9oSEhwUnl2d2pOb2pXaXNIaTBiM09La1VvK3VF?= =?utf-8?B?bmpqNWd4d2JuWXNoTUllbXE1VmlxZkRHT2JNWjNzeEVSMzRPYVpZNGFlUkpX?= =?utf-8?B?Y3FOOW5KUWN1N0lMbGhXVDVKbmw2bk1VdzU1dHViaDczUG1lczRRUU9vd3E3?= =?utf-8?B?RnJ0Nk9kdXJFZ3E1alZhdFJHaTQvcnBWL21oMUZrTmovMTJRZmdWVWdsdTRw?= =?utf-8?B?clo2aEtnK3dWeGlIc094RFgxR25EbXR3a1hET1BNRjBKS0hxT3RwMWE5NExW?= =?utf-8?B?ZzMxcDVlR1VLOXY4b3R6eXBaamg4NFFPVXJUUzM2cE44RVA0K1BKc2psZUY2?= =?utf-8?B?SHNqOVpOZ1dlLzFoSU5tQTFZcUV5dTd4OUd3dC83Y3ZsWmtKUkFnK1FOaXF5?= =?utf-8?B?MnlURXQvT09OSzd5b1crbWUrcWxZQ2gxKytDUjhQbVB3bjRFQ2R4b09FN2k0?= =?utf-8?B?V3RuNHBzYWpJY1lpdFVsK3JwR08xSjNTcmRXcWxxbHVpbFp0OThid2hsc0JP?= =?utf-8?B?L3daL0JONE1lYy9Rc0IvQjFWbnk2OFZwUHBZSnJidEF2TW9WRWEvWkxXTnpr?= =?utf-8?B?R2Q4ZTYycnFPVitrb1NuL2FKZldpZjZoM1lPbEd6RnFpN0NHTncrSHByb1h2?= =?utf-8?B?YjJYY1BsR25OdDJDMUhZM0JyVjlGL1lnaFFtQkEvRTM0ekpJVnplOUJ5aW1C?= =?utf-8?B?OU5lNWVGMnUzQlhYd3RuMVpuU3YrdmE4VVJadHVHUWpmdEdxK1pTL3hHcUhC?= =?utf-8?B?NnAzeENRVFFvYmVBM2ZVOTluMFZ1WEtJVFpQL0RJZFIybTNjVlZwQm1sYkxR?= =?utf-8?B?TEpvUVZ3cU14SzJUM0ZaODlhTHNTL3NMaHFULzNuTHVDc2lFZU1uK09SSDlK?= =?utf-8?B?WFJyNnlHemk4MTRWT1BzbEpiYU04YmRGQXpzaWI2WXk5bkdHSWlzT3h2LzFz?= =?utf-8?B?UWNWMVBJUEZwUGxlcFEvUWRyTzBWWm5JSU51TjMxVG1tRXViaHFScEtZMktX?= =?utf-8?B?dVIxL1JzcmxnPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0a7474-c24a-48f4-060a-08da0b45161e X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5841.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 14:14:17.9311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ZZ3jNk3xgTHN3W9Qin+moXENrZLJqFZSiPWrr9Gv6P5ALjMTKNYPh513+A1bb+whPikH/8U0rTVq7D2AXBRdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210091 X-Proofpoint-GUID: hXcTJZ42F9FNFRZBLHkRa3n7N3i4EBsk X-Proofpoint-ORIG-GUID: hXcTJZ42F9FNFRZBLHkRa3n7N3i4EBsk Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=mark.kanda@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.onmicrosoft.com) X-ZM-MESSAGEID: 1647872451117100001 Add destroy_vcpu_thread() to AccelOps as a method for vcpu thread cleanup. This will be used in subsequent patches. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Mark Kanda Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/sysemu/accel-ops.h | 1 + softmmu/cpus.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/sysemu/accel-ops.h b/include/sysemu/accel-ops.h index 6013c9444c..e296b27b82 100644 --- a/include/sysemu/accel-ops.h +++ b/include/sysemu/accel-ops.h @@ -31,6 +31,7 @@ struct AccelOpsClass { bool (*cpus_are_resettable)(void); =20 void (*create_vcpu_thread)(CPUState *cpu); /* MANDATORY NON-NULL */ + void (*destroy_vcpu_thread)(CPUState *cpu); void (*kick_vcpu_thread)(CPUState *cpu); bool (*cpu_thread_is_idle)(CPUState *cpu); =20 diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 7b75bb66d5..622f8b4608 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -609,6 +609,9 @@ void cpu_remove_sync(CPUState *cpu) qemu_mutex_unlock_iothread(); qemu_thread_join(cpu->thread); qemu_mutex_lock_iothread(); + if (cpus_accel->destroy_vcpu_thread) { + cpus_accel->destroy_vcpu_thread(cpu); + } } =20 void cpus_register_accel(const AccelOpsClass *ops) --=20 2.27.0 From nobody Wed May 15 16:16:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=2; a=rsa-sha256; t=1647872474; cv=pass; d=zohomail.com; s=zohoarc; b=MW4KtYg0s9tUhowpq0tOSuShBXBSlFZZar3h3+4YQdMUwkUCU8G6oqeSZobDElyotK8eK9Lm/YnBFV1WhSk3sY9uE1cIuvClX3nIxlygl0wxQdvETYO8dCNngONCS6SARoDQtLGF1hIwKz+IhTkN+tIjw7LTIbTBJ5+HyXqdHM0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647872474; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UkMvu7R+yeVsyIM0RED3+6tZA4l5brwWXK5uUWdUC7Y=; b=AVtQcjLbbyi2rAQyO87sdsDpOdomFIa1EzvB7OSswmZzIJJVeC1XJn7tfidtcNg6grEIcEBkteAr7H+yZf9G4EKxcaX/pujrum1bw/rVncn2S95Dv2CoB//TcV5G9VkEsHV9/UWrTSxGsCNucu8hh2yC78Xv1R/tfUdFwOJZmxQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647872474468127.01444428770333; Mon, 21 Mar 2022 07:21:14 -0700 (PDT) Received: from localhost ([::1]:42180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIuH-00076A-Bt for importer@patchew.org; Mon, 21 Mar 2022 10:21:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInq-0008U3-Ba for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:15868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInn-0002RH-K5 for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:33 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCw7O5006207; Mon, 21 Mar 2022 14:14:22 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew6ss3cy6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LE5cKg051488; Mon, 21 Mar 2022 14:14:21 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by userp3020.oracle.com with ESMTP id 3exawgsea8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:21 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) by BN6PR1001MB2258.namprd10.prod.outlook.com (2603:10b6:405:2f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 14:14:19 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15]) by SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15%5]) with mapi id 15.20.5081.018; Mon, 21 Mar 2022 14:14:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=UkMvu7R+yeVsyIM0RED3+6tZA4l5brwWXK5uUWdUC7Y=; b=FprvGfCEgu2qqMwckRCUBfy0qQe7XIvYZLyuKvwmmpRNswCQzpQSrf2Tk88UoUhd9sPD cPFmInKaTG/9soFxP0+37soFuw4tf4jQog98W4oYPWLYQs94vNu2cprUJwo4kjSrqjk/ OULLIhRE2OpVshHR498FumRdm7G+Sw9DgSTKoBNzWDv/XQTjqTcTQgdaxp17q9Snfuvo m/mvjwdsxyiLXLg5Rd2vce/pF+tHMdoYpHKXWU3cVVpeY1fg3OYWUhvzeFv5Olr8UoK2 DX08Ma1NYLMe0vPLvgrpJE1k4mZNNEqhzTJI0jtquO6Kb230Y7nrQUewE/BnowCf09Jh PA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SF7CRJMSnukFvCaGI4Cg13y91/qMCNb3g413u6tzBSxnEUHjjNOGHtctC7VL2aHF5j3zOBsnDncUoDIJN6YIvLGCzaF5vj8eUoxifTGF66yLVu/vnGqHBI/jqhX+PUoQxB2la2Wg8hZ+kbCikFLmz/21O/9CT4hZiBTdNxyju2zduBvLpMifuaIQOBc/bAehmZ2OUXlyvNAUZW6A3iXDWU+WlPsw4vu4QETN7fp0tadIM7N2TCkR+zKPirZcELJvMCrN+VvB5XVuXBEjKs1t3Dk9uoF601lOgoZ9mxf0Yo1gNX4qt5neljRik3qMp4hW/aUelyj8ybwkrP7kXiSJlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UkMvu7R+yeVsyIM0RED3+6tZA4l5brwWXK5uUWdUC7Y=; b=K+AexoHNJidcX9tShCjJ51uPjtuA7NA0o5/py+o8ceKAO8wg2TNXN5DhQemhENXPUFrEkFau2exdS431RLJs/0R4OtCaYo0mCLBWurvUrt1zhziaqQUcIdPYowAj4kp/prWR+8EwkeboLg0s5azGqRNcrdib1u6Nr9DE3+86QX4RL94D7hMo+4KEP62K0xWdlGWDkqSdikqnt7FuK4Do4HH6tOAQNFwKjEHOCixuQXWyPOO1JhKkvIMGkhkM/mJg5KsCbHiu5yLQicxZvqmPuexwVDQhHLUuEmJt5UsUPuGbqo8iZKiUlQVletZg1lPLPQ69O7KiA4evHUOy6SB8KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UkMvu7R+yeVsyIM0RED3+6tZA4l5brwWXK5uUWdUC7Y=; b=Tm1LQnD+puBF6x63B/gUeCPtdOSfjJJFsymM6bM4HyNjacxS85vtMuBU/uJY8z3rkkjf8Y5DKZOtrCQI019Lua6oNi4zbfLZGOr/LQ/qyVysahxAAUsYAV2T8gwDLbThVaNaZQ6mwNGak2xG34Z/lN4JlVg1QYvk5tuzY25DaBg= From: Mark Kanda To: qemu-devel@nongnu.org Subject: [PATCH v3 2/5] softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread() Date: Mon, 21 Mar 2022 09:14:06 -0500 Message-Id: <20220321141409.3112932-3-mark.kanda@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220321141409.3112932-1-mark.kanda@oracle.com> References: <20220321141409.3112932-1-mark.kanda@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR03CA0096.namprd03.prod.outlook.com (2603:10b6:5:333::29) To SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8865769b-88ba-458a-dca0-08da0b45168b X-MS-TrafficTypeDiagnostic: BN6PR1001MB2258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qyKVZdVX1IYd2aKzu4E1PnbwVS30e+To0kW4R9PzjEfR1zuSxYR5pOQhMtvbV0qY10PaTi8rF9G3dTWQzUq5eRbW5alS2pbjgv4YAHUFBaWzpwWol/PQy8V5EZCiYbL3Fv+otiFKvbn4aJQh4tLytd7ErmKliedzGV6RgScC1PY0zbdD9ql3seqwiTsPY/uYQKSquWb/QHQKbCATAiGdjhhSLH9uAZ7oMuN5PdP/5/alKcflyFXJklW/zwdWr1gi1n8wyOEdr1qdyGLj1GGq8qhFpa8h0FfASk1FIVbnBdLit/H6+8XmbH4Xiu+s/9y6PulkpEPrVIKJge4ameJaSflnFQtxCY8yuMJIaBoZ/1Qk5Hlmoi4gvJmXWnMO2XL4zGCGgkfxzUkC8wnPUOamq5WldMofaILgukchmtky/+KPSrsES2zHN14iSAAVW08V7LX/GLP+8C57q3WmOW4MSq2SJ1M/rtrjB4gEG45PJVL9+yzjkjaK4OFzRjbh/WJHm0TFaFCyNxR3sbN2/VzdRUNNVWjiP7hLX6He43rjFDofeoZ1nQBlOkzL6DisUXpyOK/8VYSwJd13QwNJnSkODeYyxOePyEXzf6Qzgmaj/zDRdxQk3d2od5TEYKD8Ye3Z1b7gwTMis5+u5g47tfrZfjWl1uNbpGmGFDJKUyesihgUqaN/1tI06oo4OX9M+z6iibPjVgICIUrZMqFm3gnT9mGiLSQgIqU+fp/HNooOGro= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR10MB5841.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(2616005)(2906002)(6506007)(508600001)(6666004)(66476007)(316002)(186003)(66556008)(66946007)(83380400001)(6916009)(44832011)(26005)(1076003)(8676002)(4326008)(6512007)(86362001)(52116002)(6486002)(5660300002)(8936002)(38100700002)(38350700002)(41533002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yE4K3pkREx/InfCrmLwcxYX2Q06W9vIhKf8qIxSHbGbOV6k9AwCN1fIC1/si?= =?us-ascii?Q?BsUKN6Y3JwvoJ3l8ogVceUxWn0eDhaCwH5Sy6bUj+9SRWj6HoknEYCLIhjoq?= =?us-ascii?Q?3H/ftYQOYyGpNST9CeMEX48vBQ/GtR+uAhTI/ZSted2wqkUAkhqkqrIfEUeL?= =?us-ascii?Q?ferv2ayARxjj9x3zKIzfKHFSkFPpPQp4SYc8G21NHWY1kndswHr58NHmoYdP?= =?us-ascii?Q?43WWlaoRJ3uRhhGPLsiZk2c60aQRPKeYrK4rNoKQoY8GB3Ntvk0lNE2rw6KS?= =?us-ascii?Q?BPvJRyIK8SBefMG3pi13nDBrKmlvJgleD7+2f1E9m6oGxSYCed6jjujWJOc4?= =?us-ascii?Q?tXIOr7EHMhlVAUTiSRAfpNwWs5EDfx/y0drOM6hZvYA0Yke7VeILVxAauXoi?= =?us-ascii?Q?bKsHsZHaq1Cgq6G9D9QHTqSy6aQq40Yo1Eq3YcFZ10nbaj1nwRFovJE4DHWT?= =?us-ascii?Q?E9aj4Qwpud6e6nx1WhY4xWH+MYrWQyrp2Ajm7sxlZSnJOkgIDmLOE8Z6DlFB?= =?us-ascii?Q?tdgeYBKlZWFEN0eeb2Cw6m/Ij1wU7yooJbrSNqCJoqrpUFxawaxLnSSh9fd3?= =?us-ascii?Q?3a2hQv8E/LIME49CiC9iixikQJ0XAUCh8vVAncVfFNtf2xvhLHjFqapNyi6s?= =?us-ascii?Q?uX1shCZjMvhxJVetXZdDMHCd6Ml4m3eRdbR6vICWl8JTNSGZT3Yl3JuBLIoS?= =?us-ascii?Q?vPaQmHVlnCtydkcuJFiTxhKyvh9c7JvrgPTwfOe4Mt8FOQUPRoVLr6r+7QeQ?= =?us-ascii?Q?K0xgsbaeLMcGIkEQTwIzfDyb08JZKBF+J9ox2tX/LEXjDy9wwueVQm+pfQbU?= =?us-ascii?Q?CFbLRtqnAHxxHOBuk0cO7By5OtWOJUzFk3JZU/XGf8AyszTB6LhOS6ViOvzU?= =?us-ascii?Q?T8rjRSJGH262kbn/g/Ur220Nv25dsfH/aS/gXR5v5sAXfG+6onxUi8vjqaoF?= =?us-ascii?Q?OsqM8lxshG1b7OolAfn/HGkTUfaSVoRcCgAjKMcUtL4dfCq1XO433ZDCTUXX?= =?us-ascii?Q?lwfbix0L2lGqJP4SIuiiFumHLAWGTe12aIgmS+zMYvhIiBhS4MyCrYGtxMy1?= =?us-ascii?Q?6qXq/VmT6a0pWVVR3YhRVNQ3uGytscwGq5O1TSdwBvhnhhMVBcN0VKh8w0BL?= =?us-ascii?Q?buGIejg8ts/mdK3GS/pih2n9RfDMGd2MpPTlJtPTWaIMwrInWzU2KiIH0Noh?= =?us-ascii?Q?vB5Ydpbr+SwKsPtKaNCvVxMujae0QHUM9neQdb22/mSjwre+Yo4MK2dx+u8F?= =?us-ascii?Q?PVYkNhvQxbLqC6QgAxEATB12OVNj8Vc8EzbOWDjMn6EZDAHAG0j1kKz4Ukqh?= =?us-ascii?Q?6KPd3DXHMZ7RUWhC9I8QPMrv8fB4NWwX8pp//4mp1rOubmwRtR46XqJokeOY?= =?us-ascii?Q?8F7h4gBxnzFmbDo6waW4maYTzn/jsVjw0GMqGq71I/bNNRRvLY0OLszA4p4B?= =?us-ascii?Q?OUgWITLSOMxL5dqadJJ57vbe/E5IIkYgumwH79HCDarSeUBRBJ8tFA=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8865769b-88ba-458a-dca0-08da0b45168b X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5841.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 14:14:18.6353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g7MHpKOLzZm7KE4ymZ8I6Tdq8qSTcUVOcRPLuPf/+mDiIHt4HNlaY3Ae/vVs50+gz6siEwy0yR8wWUtBDnXhQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210091 X-Proofpoint-ORIG-GUID: LW37XsPijQ5mt7V8eyrjd1b0TLa6GccT X-Proofpoint-GUID: LW37XsPijQ5mt7V8eyrjd1b0TLa6GccT Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=mark.kanda@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.onmicrosoft.com) X-ZM-MESSAGEID: 1647872475966100003 Content-Type: text/plain; charset="utf-8" Free cpu->thread in a new AccelOpsClass::destroy_vcpu_thread() handler generic_destroy_vcpu_thread(). vCPU hotunplug related leak reported by Valgrind: =3D=3D102631=3D=3D 8 bytes in 1 blocks are definitely lost in loss record 1= ,037 of 8,555 =3D=3D102631=3D=3D at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117) =3D=3D102631=3D=3D by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so= .0.5600.4) =3D=3D102631=3D=3D by 0x92443A: kvm_start_vcpu_thread (kvm-accel-ops.c:6= 8) =3D=3D102631=3D=3D by 0x4505C2: qemu_init_vcpu (cpus.c:643) =3D=3D102631=3D=3D by 0x76B4D1: x86_cpu_realizefn (cpu.c:6520) =3D=3D102631=3D=3D by 0x9344A7: device_set_realized (qdev.c:531) =3D=3D102631=3D=3D by 0x93E329: property_set_bool (object.c:2273) =3D=3D102631=3D=3D by 0x93C2F8: object_property_set (object.c:1408) =3D=3D102631=3D=3D by 0x940796: object_property_set_qobject (qom-qobject= .c:28) =3D=3D102631=3D=3D by 0x93C663: object_property_set_bool (object.c:1477) =3D=3D102631=3D=3D by 0x933D3B: qdev_realize (qdev.c:333) =3D=3D102631=3D=3D by 0x455EC4: qdev_device_add_from_qdict (qdev-monitor= .c:713) Signed-off-by: Mark Kanda Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/accel-common.c | 6 ++++++ accel/hvf/hvf-accel-ops.c | 1 + accel/kvm/kvm-accel-ops.c | 1 + accel/qtest/qtest.c | 1 + accel/tcg/tcg-accel-ops.c | 1 + accel/xen/xen-all.c | 1 + include/sysemu/accel-ops.h | 2 ++ target/i386/hax/hax-accel-ops.c | 1 + target/i386/nvmm/nvmm-accel-ops.c | 1 + target/i386/whpx/whpx-accel-ops.c | 1 + 10 files changed, 16 insertions(+) diff --git a/accel/accel-common.c b/accel/accel-common.c index 7b8ec7e0f7..623df43cc3 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -28,6 +28,7 @@ =20 #include "cpu.h" #include "hw/core/accel-cpu.h" +#include "sysemu/accel-ops.h" =20 #ifndef CONFIG_USER_ONLY #include "accel-softmmu.h" @@ -135,3 +136,8 @@ static void register_accel_types(void) } =20 type_init(register_accel_types); + +void generic_destroy_vcpu_thread(CPUState *cpu) +{ + g_free(cpu->thread); +} diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 54457c76c2..b23a67881c 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -467,6 +467,7 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, v= oid *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D hvf_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->kick_vcpu_thread =3D hvf_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D hvf_cpu_synchronize_post_reset; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index c4244a23c6..5a7a9ae79c 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -89,6 +89,7 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, voi= d *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D kvm_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->cpu_thread_is_idle =3D kvm_vcpu_thread_is_idle; ops->cpus_are_resettable =3D kvm_cpus_are_resettable; ops->synchronize_post_reset =3D kvm_cpu_synchronize_post_reset; diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index f6056ac836..ba8573fc2c 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -51,6 +51,7 @@ static void qtest_accel_ops_class_init(ObjectClass *oc, v= oid *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D dummy_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->get_virtual_clock =3D qtest_get_virtual_clock; }; =20 diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index ea7dcad674..527592c4d7 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -94,6 +94,7 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) =20 static void tcg_accel_ops_init(AccelOpsClass *ops) { + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; if (qemu_tcg_mttcg_enabled()) { ops->create_vcpu_thread =3D mttcg_start_vcpu_thread; ops->kick_vcpu_thread =3D mttcg_kick_vcpu_thread; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 69aa7d018b..0efda554cc 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -220,6 +220,7 @@ static void xen_accel_ops_class_init(ObjectClass *oc, v= oid *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D dummy_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; } =20 static const TypeInfo xen_accel_ops_type =3D { diff --git a/include/sysemu/accel-ops.h b/include/sysemu/accel-ops.h index e296b27b82..fac7d6b34e 100644 --- a/include/sysemu/accel-ops.h +++ b/include/sysemu/accel-ops.h @@ -46,4 +46,6 @@ struct AccelOpsClass { int64_t (*get_elapsed_ticks)(void); }; =20 +/* free vcpu thread structures */ +void generic_destroy_vcpu_thread(CPUState *cpu); #endif /* ACCEL_OPS_H */ diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-op= s.c index 136630e9b2..b6ef246cbb 100644 --- a/target/i386/hax/hax-accel-ops.c +++ b/target/i386/hax/hax-accel-ops.c @@ -79,6 +79,7 @@ static void hax_accel_ops_class_init(ObjectClass *oc, voi= d *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D hax_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->kick_vcpu_thread =3D hax_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D hax_cpu_synchronize_post_reset; diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-acce= l-ops.c index f788f75289..ff9033127a 100644 --- a/target/i386/nvmm/nvmm-accel-ops.c +++ b/target/i386/nvmm/nvmm-accel-ops.c @@ -88,6 +88,7 @@ static void nvmm_accel_ops_class_init(ObjectClass *oc, vo= id *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D nvmm_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->kick_vcpu_thread =3D nvmm_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D nvmm_cpu_synchronize_post_reset; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index 1d30e4e2ed..f4ec6b3518 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -93,6 +93,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, vo= id *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D whpx_start_vcpu_thread; + ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; =20 --=20 2.27.0 From nobody Wed May 15 16:16:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=2; a=rsa-sha256; t=1647872473; cv=pass; d=zohomail.com; s=zohoarc; b=UwXAetKB7TJmWI8iNgjEF/qgvLms0Q7h4m965er6Z3MQBktD9WuRLLKqLJjo1TOMC8W/ZsRl1irJAhg01n2pNTyLlyHcsGhG1V6NY4BgnwAO5M5+lhaf55eN2jEjx+qg31DZzXwdeVYpNdx86PiS9ROqrp2odIS6tAlqc5FZrjQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647872473; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PotJIymLkPD7qEHT0b0viq1CcKI6l3095/ds7wdhELQ=; b=FOZcVGGJlHP7HXvREHt++Il61f4qsSvoGTocvoVL2wm0PYAjxzC1v7XEUsBhqucU10BGk4AeL2i9SYkq1YJ2BS+37Jfq0RFkRfj1mjmXVXcDn2STmEdfyqak0ZdcoCL4QBG9bKHwvZHzkFDXlg5ciA7C/NJGQdVOYpFkIrZMp5E= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647872473341415.7075521243744; Mon, 21 Mar 2022 07:21:13 -0700 (PDT) Received: from localhost ([::1]:42016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIuG-000703-4a for importer@patchew.org; Mon, 21 Mar 2022 10:21:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInr-0008UZ-Qm for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:17564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInn-0002RS-Vq for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:34 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCw7O7006207; Mon, 21 Mar 2022 14:14:23 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew6ss3cya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LE5cKh051488; Mon, 21 Mar 2022 14:14:21 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by userp3020.oracle.com with ESMTP id 3exawgsea8-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:21 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) by BN6PR1001MB2258.namprd10.prod.outlook.com (2603:10b6:405:2f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 14:14:19 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15]) by SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15%5]) with mapi id 15.20.5081.018; Mon, 21 Mar 2022 14:14:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=PotJIymLkPD7qEHT0b0viq1CcKI6l3095/ds7wdhELQ=; b=KegC7auTztLGOp55q6JWKkJ+IFHtgug/70YT4pL4lg8rCZc6qaxeHMJm1REeOLDuXl5k g5zHi4T0wZKr/Kjq8XC/ETjnlnH8jUN1Sj+NqJO+iB5UoVloXhXSADQLEErIl9DcRN0S ier9XMJjvROnIyWxis7hocgfdGwb5lOj93TpOE/ud3FMH5pkxDEq2SnCsBYK3pDD6GXA AYXRXx1S7IZukjgKt04Qj4B4Y3SlmXEz0LAYW6iCvfVildfVky1LTlqDdvQuEFlSAPpR 4T/UjKhgsA+4HFPFbywq+s4Gp3R/xbUuo58wUKkC7DAeyl25xOgU0V/84kCkSgaNq+iN wg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+Fy/b+p+hsIShxFqRCyQ1EunWq5kpHlrqqEemTIV4nRnWvj0UqfRdV6iTyoTqrDNRpE6djZtA9t+LxW9Ul4EXFI7F3Mq590PqcFRM2FHjsUOhJG/K1O/oEgCrUALL2rIL0zRd0iIrywJ4R0zVb6ZICBds4H8JLyFFpVPfAKt9ZqlFDBKMQEjjGqxpH4exsBfnOoe6ovboUNSlHPjrw1CB9n6Aap8lT5ssreR/0Nv0+r8eVKT+qF1ob4BTgnqG0xjth05VHRXajNc196tSF2Wes/jK2w0jp6ALL+/SrDu8DvpEItPCsNFsLq21E71UEQbbHZUiogqpYHIWhCJVZWTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PotJIymLkPD7qEHT0b0viq1CcKI6l3095/ds7wdhELQ=; b=ZCFxOxxtGJ9g8+DI81M1FKmyB9rLyzRo59/EiXRmCcIhnjkFV4JZFzHVdhXf/G23JhiSTqqtELESpd9uwV1E2afeBwrcc0xVPHVFUTjFAHPSIsM6TmE7QnQ7/GagsiZrS4KlDizJGrwNdALCotFkHKxNDauymIEuO+c2o/FpBliaWOU2F6p901FHt43hG2dGennAFFalXKAIV6JFrF3U/NP5QCvGECIopIag5KAwSnlJmhbxl6+hAFLvBwTqGyBhMChzfdsIvWe+7SOF98fM8JgORrjAAtXiPy3hCDNR5vHbSyFl4nxGFEhiIYwSELY7oc0ampghs8AjX9ZAfNfljw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PotJIymLkPD7qEHT0b0viq1CcKI6l3095/ds7wdhELQ=; b=svsMGNxUSLkPQtBFOFqw9TsxAKTa9V09GlQomELQA4cY/tdS9Ode3PVBXJH+/BB65kIvrNp7dzaYFiF9bVJEYoDGfvGi4PxRKVGt1qIA+PD90bDp34SnfU4hkNCql0RfKz4LmwB5ObN6/A3qowaXzU24cOotHrpR3BVP0kaa92g= From: Mark Kanda To: qemu-devel@nongnu.org Subject: [PATCH v3 3/5] softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread() Date: Mon, 21 Mar 2022 09:14:07 -0500 Message-Id: <20220321141409.3112932-4-mark.kanda@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220321141409.3112932-1-mark.kanda@oracle.com> References: <20220321141409.3112932-1-mark.kanda@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR03CA0096.namprd03.prod.outlook.com (2603:10b6:5:333::29) To SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2deb7145-dd04-4575-83a3-08da0b4516f9 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XOccuIjpP61uYWFrLivqdehWO+BVcKA1X54g5j35JZ/4I8tbhD7U+Ao82gNCcOyMbIR5NjpuBV8oLWTvx4nyEc+YfX+hYY5vIqXQ5SEmTl8cE2DnXI7+e+QBu1iWilYvToOhIA9vPMidxsdWEmrOnTw4Kq7w4/SDzIVS9PG0niT6iDuPTp1o3VY8JUrdlSYUTLZUQrB516XtWa000UgtUsVYYe6LYCqeO0CtHUs3XlxnedPagF6DGXJab5BQE2psMf6HPJ9bci4m9+c6Hd6M5IO4F8uqZGUTLaG+Y35/xnCtvfhpYA4D7xAMnuVa8cKsqhb0f02ZSUdDfSGpJZNhYWv7zV/4LaKGzJsfmdpoGF6Npxt8qBmyf6VQsoyIZrKEXjGIaEw/upn442wNRuy3mCIDcNi5lUa/wUkisFGTHB2bHHEJK6+2UIkMM80mDTBXahIHoNPpmf9zWA3sWcx0YMPZQQVx/pBB+QVMVq3WtI+8dURkzjWS2tzjVGvsdyoS37h3QLvCEt85ZBh2idgenVnEp79Abr4J6keWwC5+2Gg/wcAal03SD7QBKhqGmpZZuS3XFVQWn6BN3BnFXrXp0sf3/hHh7MMIKyyPfGUmSkEi53b42TUdfAF0uEl48f/6nCi/ABtfNd3eTR8d5FT3yzL+JglxHKqzCtuX+sZdojVGHf3Owbjp0nQ7aS27Gqrse0ALS4gyx1aORVRaKA3NkpN0gIgQ0WwKoWYC2Z6mrAM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR10MB5841.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(2616005)(2906002)(6506007)(508600001)(6666004)(66476007)(316002)(186003)(66556008)(66946007)(83380400001)(6916009)(44832011)(26005)(1076003)(8676002)(4326008)(6512007)(86362001)(52116002)(6486002)(5660300002)(8936002)(38100700002)(38350700002)(41533002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XmR3YY2lmSgiT4fpwNzAVs7caXhHOJa8XPfD7ePcwjZjDZQgE3AaiCXm/Qc5?= =?us-ascii?Q?MZpmaO1J8RZxQpXH71d6346XUoYl2/cGA5cZCk2yl07T/Br/XnbgtcFmugsF?= =?us-ascii?Q?hqkt8x6sswZfLCQiYjs7ft3K+rmR7d4VIoybRwAh8AcSKqbGalNrbSfjK765?= =?us-ascii?Q?EmZq4XcK5JncXU44n54T+BkhohPzfAo3Tjeks+MGu9yzWOG6mHwMkrt0QOQ+?= =?us-ascii?Q?doMjUYX09eJpRKmsl81MkLvarNCGCTFxOvIFNLKQbykMpHB27dPY7TjHRI5j?= =?us-ascii?Q?7TPo7Yy1aUYKLHEHMOO7G3QcV5z2ipt5nl/j5Hls3ufR3vL301LLlVcaZuZY?= =?us-ascii?Q?MXUPWxzBUEXoXvea4Nc5JJCUTebFEtPGU0RgXWHu7W5dieKMgNCDgZdmXUP6?= =?us-ascii?Q?ULUlFtUq8Ax7BAJrWE/nGWXcROPgfndbPZTd19U48QjVm3Hzu9CkBCMclB26?= =?us-ascii?Q?+hsq4WwsZAay93B1iZumNNQ+UtQ8LA+kLud+gMoTfpbl08Vxcw8dXnJoYmmS?= =?us-ascii?Q?6EwMf7WV1u4jODLimGD2ArAICDiwxAwQ0L53os1ydyL1jZt/ZDnlqnVNqEqb?= =?us-ascii?Q?cGJr7OIfUbMISdCHy9MKH0eyTWIKZbp9CXJzf3ChtZGIjDTkTUuuG9DqNRQB?= =?us-ascii?Q?t8O7cxcObGQQ6fjzb6QLAQ8nlsIQksFUcgsaIds3g8RTUieBZbsChzM1oHh5?= =?us-ascii?Q?Qmn/45BS1X0F3njabVblobkWdfzlO0K71wkqaTARbUeEkd7/iOiPRPZWWGMP?= =?us-ascii?Q?wHFD4a//dRfNxeRl/4xyW51MX2JiclEl53UFWcweh3Ow6RokwxYFlzaiepha?= =?us-ascii?Q?bSK+s7g+cdfvm+22kAjH8znFOcQLlFbBi1weBuY91U7ItX141OONp6zXosEc?= =?us-ascii?Q?mqSmh1CQSdeQ6XVCr7tjyuNcoZsnlgrnvGAjdyDVc+Zr9Orsw2GohyxAC0Kp?= =?us-ascii?Q?bm81Isu7USur6p/cfY7ZYiHHBjH4pXUSpcn8yL1mKZ3qheA3F1TVfwkDbyqt?= =?us-ascii?Q?L9MzMmb9s8Zy+NdI/2mfphDxNg5N0NPEzYPSUz4a1rEVmYcaW2jrJQ6pand+?= =?us-ascii?Q?1X6GwxVJFOsjpYCse1NbXOG61zZ6pLr06fkbhE4FS/BBiM3ld7xlpanwQBFq?= =?us-ascii?Q?3zephH60IloeWX3gpHqOr9zMgUDUd4I2eK/hEUWCY3csAcez4VPsKr834NX2?= =?us-ascii?Q?XDSorhyEikWTb/R5xpI1TXRbkEtlJo+vVPkJV7+8WV4LD9LvFdGssBJuw2Nl?= =?us-ascii?Q?EihOzZpMyOUraMlYAaRfY+3rqwJl9MeRqZbgf3xQ1YfrXaVSAaU2JLgzXbKd?= =?us-ascii?Q?WXgBWa1xAhinUZlb4Ur7wmfonXc0ygFdv2TDiPMO1WvSB9z3xyGrRY44MUMS?= =?us-ascii?Q?VHVFwnT2PkdaBgRcwE0JyYCRu/K71K8fEwN+DRw9Hu+2/C8MEn+3TDEujdR3?= =?us-ascii?Q?tt4/rdZtG33HJ4LGdmiplLwdNZ6qB1ObnOIKhm6XrAMh96oUa1/Lhg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2deb7145-dd04-4575-83a3-08da0b4516f9 X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5841.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 14:14:19.4008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5pCASNb0O+sfAQNxa47X1OeDF7ATPkfZ2P4UdCPJsDFWa0rJqpKfT401Q3M6+LlHT8hJhp93ew4AzFtxsjAigg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210091 X-Proofpoint-ORIG-GUID: wApLM5RS8qK52IiRhuiPTkIaGFwLhqVa X-Proofpoint-GUID: wApLM5RS8qK52IiRhuiPTkIaGFwLhqVa Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=mark.kanda@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.onmicrosoft.com) X-ZM-MESSAGEID: 1647872473985100001 Content-Type: text/plain; charset="utf-8" vCPU hotunplug related leak reported by Valgrind: =3D=3D102631=3D=3D 56 bytes in 1 blocks are definitely lost in loss record = 5,089 of 8,555 =3D=3D102631=3D=3D at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117) =3D=3D102631=3D=3D by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so= .0.5600.4) =3D=3D102631=3D=3D by 0x924452: kvm_start_vcpu_thread (kvm-accel-ops.c:6= 9) =3D=3D102631=3D=3D by 0x4505C2: qemu_init_vcpu (cpus.c:643) =3D=3D102631=3D=3D by 0x76B4D1: x86_cpu_realizefn (cpu.c:6520) =3D=3D102631=3D=3D by 0x9344A7: device_set_realized (qdev.c:531) =3D=3D102631=3D=3D by 0x93E329: property_set_bool (object.c:2273) =3D=3D102631=3D=3D by 0x93C2F8: object_property_set (object.c:1408) =3D=3D102631=3D=3D by 0x940796: object_property_set_qobject (qom-qobject= .c:28) =3D=3D102631=3D=3D by 0x93C663: object_property_set_bool (object.c:1477) =3D=3D102631=3D=3D by 0x933D3B: qdev_realize (qdev.c:333) =3D=3D102631=3D=3D by 0x455EC4: qdev_device_add_from_qdict (qdev-monitor= .c:713) Signed-off-by: Mark Kanda --- accel/accel-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/accel-common.c b/accel/accel-common.c index 623df43cc3..297d4e4ef1 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -140,4 +140,5 @@ type_init(register_accel_types); void generic_destroy_vcpu_thread(CPUState *cpu) { g_free(cpu->thread); + g_free(cpu->halt_cond); } --=20 2.27.0 From nobody Wed May 15 16:16:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=2; a=rsa-sha256; t=1647872206; cv=pass; d=zohomail.com; s=zohoarc; b=UFh86ikUS2ziIAqiMHZkPFKbBw8ryqr4giudl1PYOWO2iObBzFKR3psgy6/iJZ6bwgnmzy2xI1ExIaanaRyrQ/IklFwWwEZKsnLUSK7MpgsCngCZg+GK1gOnW9Rt+N5iybQ9zjlggmu2BIwW9TvQfnSbapxuL+NVssCt4NwpEd4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647872206; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BBXfA7q7lQksCSxnsxqRR7C7Fy4/CuFBSBN4efH+JcY=; b=l9vyBl7egfBy9zU/cRfGiK6AnAW5NVLjoaVdiMMzPUsj5ZZdJuv4NlUarDWZAgnKEjW9xVsg8FNPE72G3PYO++bItyCcvygnrmJxjPUEtyk0FQCSfLB8Qw0sf7HDWzQQgOMgGMdVdRsVW15Obdqw0FaiW+70L76dBw5cQEZdHYU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647872206285564.0775244277181; Mon, 21 Mar 2022 07:16:46 -0700 (PDT) Received: from localhost ([::1]:35662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIpw-0002Ow-SH for importer@patchew.org; Mon, 21 Mar 2022 10:16:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInr-0008Ua-Pz for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:17292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWIno-0002RQ-78 for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:34 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCwAFQ010833; Mon, 21 Mar 2022 14:14:23 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew5y1uecx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:23 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LE5cKi051488; Mon, 21 Mar 2022 14:14:22 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by userp3020.oracle.com with ESMTP id 3exawgsea8-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:21 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) by BN6PR1001MB2258.namprd10.prod.outlook.com (2603:10b6:405:2f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 14:14:20 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15]) by SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15%5]) with mapi id 15.20.5081.018; Mon, 21 Mar 2022 14:14:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=BBXfA7q7lQksCSxnsxqRR7C7Fy4/CuFBSBN4efH+JcY=; b=UedfjF4aQGKcdQXKtls9ouvqnb+cotyiAassl1XOKNAZVKDbD9Mi/ynewDmal2iGq1u/ DtDWnuRhwXFZ62kQUXVGOz7uKoUVM9of64RZa7IHPYL/DcVq42EUbY30tl7jxv0PWpAC +ywaqLo3L0zVn25QkKwDZZ1R5mws1qkZAJRLGSlo/S9wxmNkHDclAVXL/hGjFPClfwGy xz4YrHlkDUyYNj2lGyKD7FkNrRdsVeeFZbVs6+e/uxIpGkmaooLzjuywolV2qrDJ5E4u dcR+xRcuXXXfhB6ZiLcyKz2lf4TUdXcSdjbfz9MBzyzEzfOXoo7rkl+DKKYt33PjMaKs Cg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9gmx5D/aBNt6R7zTugFNobTDnpYuD3CyrDgBwqP/AF184OcWw5p9bGz6bEtsy85MgyjSO1Vc+4l/b4jyw12JvUB3/cgmGCrg2gl19vZ3i1jvrHCUZ+u8TIOdaBuyeDbcXStIUKxVd8bDXQouc9gfuTGxh7htdkhKIN9O2rtZTTY01rRLEOEl0IHxzkijbJdDGmRKA5WMnr2CeTsNak5svAGJN7W7yDGZ03sOYn+uzoP35OyZpT+APSZ3Pcanwa+bcL+AO0XV8TyuM/p+qMnrZTfSVAdYjI+0aQfvfdsJkMISUMXJiPvgcX4isVmX6c48rSSydahpEbmhnNwO0fXYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BBXfA7q7lQksCSxnsxqRR7C7Fy4/CuFBSBN4efH+JcY=; b=I+Iwkqq6hhTyjugIVxgyTyaFdtGzf8kImE967r1J3F6zXR8BAPCtF9KdFFuXuZML5v9qcvrkP5tM66R6DDY9KqxIrHe6dhBzBaE4cx6aKZLE1xWU6Na6EcWLwMb7t4hLOwzp/KBGnvKb4X/Jus5qua5FZZFOj1iesdXFkD0MwCpyrWFQVPSD+I/HXxFG2OZEOG4VAlXqGS5xBXnFctJZpQYQilltklmIADtlCyYTqQrYKX9ahZBVKpJo+RXc/DnXbgjtzzH38qjjDYYZ+vY41RX/LcOfARsoqU2wDRJSy9kpciBdpm3Fgy9FqXGP1hzztfCGuRv81iyEEmR65WG+cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBXfA7q7lQksCSxnsxqRR7C7Fy4/CuFBSBN4efH+JcY=; b=eA0x1Ziy3fIgmI9oR/xedulQ1bdtztbAOW0oKwEyOxu6VB75PXeuAX/IFNa1kTjgT4hm4pl4Kbtyan8HfWU91RQDzE+LnU9XGWWF6EYcysixc8YXEYYQdtGWapbkLSSsvDa7hugXQqmGn4eU7MN6VX/ekxQB/5szxoPHwTMFuMI= From: Mark Kanda To: qemu-devel@nongnu.org Subject: [PATCH v3 4/5] cpu: Free cpu->cpu_ases in cpu_address_space_destroy() Date: Mon, 21 Mar 2022 09:14:08 -0500 Message-Id: <20220321141409.3112932-5-mark.kanda@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220321141409.3112932-1-mark.kanda@oracle.com> References: <20220321141409.3112932-1-mark.kanda@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR03CA0096.namprd03.prod.outlook.com (2603:10b6:5:333::29) To SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be5581ed-02c4-4750-3d41-08da0b451769 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: soghq5xHlQakWzVYxO5mQK2RSJV7lX8Uiq90VF7FiA60/jsZi1xHOo9ytRMhFSB9HmK7ki2063yb65p28EbUOhOsH4H6YOSMzr68vzQYnHawRNPE38GOCd9u5qa578PgXDHJhkem5L7Sp3dhrKuVew6j1d+ECPRbPLRtn4SNCkeX0rsAyAaE2bcJEo2e/68GC1Xdzxzp/9IuATxKYeaJHklmCi7iJJ/t5YHNn50/cIKp2KydmdT3o7uDwo7Njwlvu0qkg6zt4EwOE49pr3PrXtMzOx0HBczOqcKZpT+r1fSTzeVHtONQeSKYFUPOEAniNMjEOd18ivTWemChDmvTFMEIi6xV9HBP6Fg/0lMuRw17komZmfPw5JGv/G0SsCOuINFZPyxfZPKfTM1k50ewu32J7n4a5AaXDtpT6DX0apdNEPfRcGiy/dmOziXfM0C3i8iJvQZqr6dqOFcUBZgvzXSU5c6G3s1fjeW+G+VUOqnt5meBP3eTWldpbSmXFM2QD8AmmkkPX4Mkm8VtcM/qDegGzbtq60OJYyC9ye3B+G2IeMMv0y1MZhCcppUvH2+0iR7zjmcs124DqxhN+dUaHSjDF8IuzVOGf+pj+ExS1PBzUe/zUDvDLomvn39/5n7yEPXtgZDj+hGyTPDvqQyQ6jfcZMVhGu885B5k+LjglNG7QB0rYnniXqlu8KbX+h8HPEq7vMRnKyRshs0hDMt+Zg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR10MB5841.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(2616005)(2906002)(6506007)(508600001)(6666004)(66476007)(316002)(186003)(66556008)(66946007)(83380400001)(6916009)(44832011)(26005)(1076003)(8676002)(4326008)(6512007)(86362001)(52116002)(6486002)(5660300002)(8936002)(38100700002)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rj2+rpirgzJ9NS9qND/SwiTMEsOPhM5QlP1+DwfqUBDwqxK5gZpPqqGFGged?= =?us-ascii?Q?Rlms5L85RyRxkO/1Le9d3HkbukLJp52OAyQpxLb5IL/+FYcx7GDxr+HB7g7c?= =?us-ascii?Q?b7wVclcwI2gg+q4zpipdzgu4HVjBsB73llNEo0i/vj0y6KxLUBVsUfMy/F1t?= =?us-ascii?Q?C+qVKo3MQLTHsmIu15dwfe9EWZ+UJ/spvnjJJarnY9eg1c3jc4NQfssb9Mm6?= =?us-ascii?Q?40smEhA7yr1vT2SHRhmQADuh0uBI22nU/GpATbEBmT3eHJhkP/oYC8ParQts?= =?us-ascii?Q?zYxyIMwoQ0cxWDlsMWfJ88nAkMXxY7k9638WbjcAFip91DeqysqZv3FDa7pf?= =?us-ascii?Q?7zKxsGBTdbOP4l1EUZN09ejEdSXxEdPMo5eQAMAy/prhU2WJDpRx3U7Dm6PL?= =?us-ascii?Q?w4+DV6BkJGnRhEtAmuRVnuCHIQpFJIZgGE8SKYq2zJiVGzUgfMrvu7Nq3Ef8?= =?us-ascii?Q?a/2KULBsgI5DgG+ATARScLwbXm4Bh/iZk7OkfdSCU1t4hicgGDUWGKQBZhd/?= =?us-ascii?Q?GbkGTqnWHYKRRVQj+mzQVCrEdaI3BK2G9F38OVDDXvLW+vfdU9vmIq1qgUxl?= =?us-ascii?Q?H3Lln5JXjeb7eYMIwVr+kpC5u/SJ1LUIcNXEL0ZjAZWJfj7QK65xGy4JXlAh?= =?us-ascii?Q?NDoldQZ6IXLo1tLkUgVCYs3jhBgFq55Zed2Aig1lL8Xh0zbaIqZs87qNgb5R?= =?us-ascii?Q?qWHPfcDzwLlca5mKRsfYkq8xl9F/0c0bmSMaNajAzWbHXul+Tbr+TuTxyrCF?= =?us-ascii?Q?MLEc5UWwOTaHrClUmYVGSFPh+qLPH8OqsD+zzQMamiFfHHSkBDHXpXCSExa/?= =?us-ascii?Q?uNNPxTxVyOYiELYjVWESIIwKvJSOf5NJIG0FNxNLhWEsVCIX1/ddYrvDQUlB?= =?us-ascii?Q?czExrtjPX/5IO9ZnV3EtW3dzYwM1be5waP8vhKToV/k8MQB5yu5UOHnPuFz+?= =?us-ascii?Q?WaZ5oKuRFXgu6eZXoGgjeCfNFxllrNSHgDWBfe1nbxNK8DIzoTEH8mK6/9dN?= =?us-ascii?Q?hm7Zmy7/nLWPkmeoZuV0GZo8EYtqDIbAcUDn/yuWxnq84kLmf7dlmRzM/hwI?= =?us-ascii?Q?gXSm6oTPrbUD2swxs8aYlqeqMNJSRYs3RFa1pssIV0LxxSAw6cQSDwuRvoD/?= =?us-ascii?Q?1gvNXgiGQ1CIRP4jn+joYxHx4bl0VEfZG/oN5xV27YFyMe6/224yX2rMjrQu?= =?us-ascii?Q?rfjC2uarry01Cq6HsSXRYe0hDn0vUCnB5WNNnRA+DQaQ2VGKfOfPXznJNYGY?= =?us-ascii?Q?B6ZDvx+seqAtZvUIQ/ZcP/T0A9AfzyP6NycT7J/hfaJdq+/8inkyqX9tL7Cn?= =?us-ascii?Q?altXjhzjeSD0+gecxDJ6G34EpzZ9aaizJK6MHZMrMcI4e8xTTsb+G9o7kpCI?= =?us-ascii?Q?Ldl5BC+e545WUv4/1qjiUZokHZRwNguX5GRtO0g1nf1sDonYCUQz3u5+HySd?= =?us-ascii?Q?WDqdqokYPcZPhV1CHGFBBUr+QyGkPddvdUDzDf1wgnNUO2VJ/Rjl4w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: be5581ed-02c4-4750-3d41-08da0b451769 X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5841.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 14:14:20.0861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mnWOLvpafOIGJ+IVtllBFhXdOjps4HIc3cFXw9BlOlN4AzhZqtQkfen7Tts78KBxLGrmM7miRbKMGTOMSo6hJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210091 X-Proofpoint-GUID: sR7ywv6AJnTNVBBNJ5C8po8O4Hag23qq X-Proofpoint-ORIG-GUID: sR7ywv6AJnTNVBBNJ5C8po8O4Hag23qq Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=mark.kanda@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.onmicrosoft.com) X-ZM-MESSAGEID: 1647872208449100001 Content-Type: text/plain; charset="utf-8" Create cpu_address_space_destroy() to free a CPU's cpu_ases list. vCPU hotunplug related leak reported by Valgrind: =3D=3D132362=3D=3D 216 bytes in 1 blocks are definitely lost in loss record= 7,119 of 8,549 =3D=3D132362=3D=3D at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117) =3D=3D132362=3D=3D by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so= .0.5600.4) =3D=3D132362=3D=3D by 0x7E34AF: cpu_address_space_init (physmem.c:751) =3D=3D132362=3D=3D by 0x45053E: qemu_init_vcpu (cpus.c:635) =3D=3D132362=3D=3D by 0x76B4A7: x86_cpu_realizefn (cpu.c:6520) =3D=3D132362=3D=3D by 0x9343ED: device_set_realized (qdev.c:531) =3D=3D132362=3D=3D by 0x93E26F: property_set_bool (object.c:2273) =3D=3D132362=3D=3D by 0x93C23E: object_property_set (object.c:1408) =3D=3D132362=3D=3D by 0x9406DC: object_property_set_qobject (qom-qobject= .c:28) =3D=3D132362=3D=3D by 0x93C5A9: object_property_set_bool (object.c:1477) =3D=3D132362=3D=3D by 0x933C81: qdev_realize (qdev.c:333) =3D=3D132362=3D=3D by 0x455E9A: qdev_device_add_from_qdict (qdev-monitor= .c:713) Signed-off-by: Mark Kanda Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- cpu.c | 1 + include/exec/cpu-common.h | 7 +++++++ softmmu/physmem.c | 5 +++++ 3 files changed, 13 insertions(+) diff --git a/cpu.c b/cpu.c index be1f8b074c..59352a1487 100644 --- a/cpu.c +++ b/cpu.c @@ -174,6 +174,7 @@ void cpu_exec_unrealizefn(CPUState *cpu) tcg_exec_unrealizefn(cpu); } =20 + cpu_address_space_destroy(cpu); cpu_list_remove(cpu); } =20 diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 50a7d2912e..b17ad61ae4 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -111,6 +111,13 @@ size_t qemu_ram_pagesize_largest(void); */ void cpu_address_space_init(CPUState *cpu, int asidx, const char *prefix, MemoryRegion *mr); +/** + * cpu_address_space_destroy: + * @cpu: CPU for this address space + * + * Cleanup CPU's cpu_ases list. + */ +void cpu_address_space_destroy(CPUState *cpu); =20 void cpu_physical_memory_rw(hwaddr addr, void *buf, hwaddr len, bool is_write); diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 43ae70fbe2..aec61ca07a 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -762,6 +762,11 @@ void cpu_address_space_init(CPUState *cpu, int asidx, } } =20 +void cpu_address_space_destroy(CPUState *cpu) +{ + g_free(cpu->cpu_ases); +} + AddressSpace *cpu_get_address_space(CPUState *cpu, int asidx) { /* Return the AddressSpace corresponding to the specified index */ --=20 2.27.0 From nobody Wed May 15 16:16:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=2; a=rsa-sha256; t=1647872631; cv=pass; d=zohomail.com; s=zohoarc; b=TCwwsCZilh2mf5p4HNDr8EBkdeVaW8S0pGi+Uw2ygpsdv+59xHPXHeZsJc73XDzkKC53AuRfuytXyx7mAGutQWUf36DiHAtH5lSt1hMMp7CJT+IWXO6MNmkslDSqtQ8DVjZxHPJXyPruytPDU6raBDo0An6WWoSZ8IcffZr0sGs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647872631; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NwW9/0J08o9mptHOQqQPH2TfCYDcpXPmu8kOGWqy9e4=; b=fHtRLLergw8oxFvd3sLUj/h0EFMyxIbtAbXIXzM7gx2qLQGpY/D7of6e6F0CoIDWaE9Qp5njoHQgt8CDekXrenWXaHOwtPbcNCIyJ8sju9+yuGLKkhU+8bAuhJgKiW/lUyDRL5cwpU8xX5etVGBQCiaso7J1U8p5CWWGyHz56Hw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=oracle.com); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647872631937651.0410478013281; Mon, 21 Mar 2022 07:23:51 -0700 (PDT) Received: from localhost ([::1]:48540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIwo-00031E-7W for importer@patchew.org; Mon, 21 Mar 2022 10:23:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInr-0008Ub-PZ for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:36 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:14542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWIno-0002R5-69 for qemu-devel@nongnu.org; Mon, 21 Mar 2022 10:14:34 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22LCw9ls022265; Mon, 21 Mar 2022 14:14:26 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew5kckd20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22LE5cKk051488; Mon, 21 Mar 2022 14:14:22 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by userp3020.oracle.com with ESMTP id 3exawgsea8-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Mar 2022 14:14:22 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) by BN6PR1001MB2258.namprd10.prod.outlook.com (2603:10b6:405:2f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 14:14:20 +0000 Received: from SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15]) by SA1PR10MB5841.namprd10.prod.outlook.com ([fe80::85a0:903e:852d:6c15%5]) with mapi id 15.20.5081.018; Mon, 21 Mar 2022 14:14:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=NwW9/0J08o9mptHOQqQPH2TfCYDcpXPmu8kOGWqy9e4=; b=wC2/oHdHXxc7B+PSy6djnEY93/BaBCeyvIxd/s+hXFxa/jMLkxvJTNke3IOIE98sTKoy wzYI5lwFS4eVVk+GpdQGE6nCJEyLL04Y9O5fzjB5a+2SqOuDg2V0lJXU1OgrCWY7xhdm EDXRFY1/3ohNNo3k+7asW6iScOu9il2R02nat/KynJAFronZrlaIBVkXVD+G5Ao0G7em Q/dA8p4e3Rp6skXoTjrLLfiPfnEmmC7Mlx/Wu5o8zxTEav3ccVrkyijXKp/yohhPZLp9 awsbaVrw6vhyk3NERjfoGF5jn29uPvaDQ/5K5dmF7iLKlU4ZPp7nZYjIOio8D3TdRtAT yg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OW3CLBvCDaAlTCBwmX+9CK5GEzhIdFUayTbkvruTWtqx1dNNsq9/1ZaYvh3jbr0v3SP2eZGmHFpxP3gVYo2bN7ySOgBeFUtmLPng71Mj/QtMHAECwocpdZLb8KDQr1CCH2qWMaYOhdXhskmEPJzIJ32cazzZZPob102YZFW9wwV5UefV6PiHLw8x7IwDe//6XmEXMo7crlsPAv8kLM6n6Kfj3Ne1/vBc4tCrM83hUzPAP9njJfn6n9Swt/5lu8JQSK2R7D7+ZMXyQpI0h8tDWO5TyZi/h8Wsesj1k6a/FASogjYhOjiFiMvODoI2dJPhHKML0NfFDgRAbqu/PMFU5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwW9/0J08o9mptHOQqQPH2TfCYDcpXPmu8kOGWqy9e4=; b=HhsHxR8qGkHb1XNcjijON+D8oeKrbYEDX0GuabBPxLbsAj8GlI9D9+/IKbpcNBUFPyiN9vzoJE4H7r7O6ugs3IsrulUPCwjPUHTewyZRl4zchSq0BO7balsuMPwVzVYTz1TPTL0qhYK5ccgo4Utzn34B1SX7/SoctcoQS6vCIzoQHkRkuLmYUPdZubK9qaZyHSipvLSfFavA6ew0ePB2zyTGIZZdN+FSKS+9c0+TQcPMbyBu6HwDiF+QdzW1ajKphzAW05ldY47f1S2Gg2jol125l3bDRpRyg+OT816bts315vKETSnoBCtIhv2WSNRipN1O10mS9tndK5KUzPn+Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwW9/0J08o9mptHOQqQPH2TfCYDcpXPmu8kOGWqy9e4=; b=jq6iIOAXru3BSgkDvmsd0xJmyIoaxNsbbiVplcMdTOaYwYReMIoC1XzW/r4WDK9ScJJarmKb83mpG+TIR6noy5WRnvLYEsFmVSXzzPqpu3/9+5G7caodNB9iQUDSg8VZWsk+oZ0K80OhVsA9nu8iPXEYhgfPqKoGgqfrPfsuzOU= From: Mark Kanda To: qemu-devel@nongnu.org Subject: [PATCH v3 5/5] i386/cpu: Free env->xsave_buf in KVM and HVF destory_vcpu_thread routines Date: Mon, 21 Mar 2022 09:14:09 -0500 Message-Id: <20220321141409.3112932-6-mark.kanda@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220321141409.3112932-1-mark.kanda@oracle.com> References: <20220321141409.3112932-1-mark.kanda@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR03CA0096.namprd03.prod.outlook.com (2603:10b6:5:333::29) To SA1PR10MB5841.namprd10.prod.outlook.com (2603:10b6:806:22b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5c1df8a-9f47-4c3d-835a-08da0b4517d6 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2258:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VELyGiVYV7Pm3apq80ac3/0I2ML7nyRc+7nLyQp/uP1X+f6QcH/Xg+4KCsUG46Rr2rAM15zs40MKQLNYJXIpFh7vALc8dHOQlpDf2VEsu3hVWoYSCvn8nk//KhrBrDh3u6by5La75GWUypjEsuHZye5jjB97XbhGMRB/en+dsj873Pv3tjIpRmZWP945byjAN6Sz+xsMdXLMvIjZmGB7J5Y7lQHFjNa/M+tj13vtJKBBGU7GN3/bFX+qyTcuXdczcKr/5DkoDJuaEol+cPk9iz1Q3Y7AYKrN86lNEBeD+VV0I5oZyj+mUD01Q4EgcuwQgkAg0VbT9UsiW3hQe8OKVW5G0n0hzNeaRnNX/0ebPsEU+7PT1WgPqQ+VHl7rydlwz1HNvD1APcOsXJPeH0aMzW/1kuAVXwcWYt6P4LNOdSyynxHVedLR5Y2IJBNJ802TiAceFO0oTUm2WCaNw6hXzvFXoCwOZ3Dr4zA/UVhrR3rbI5iIPnOaRA9CsYLxthdoDVLdfj2OL3MJWmJlxpTcT3GoB9v/XPUNj+rP07IjDESZJw+68+lFWhVLlplCmHrf6p+rkkQf8OtL9+OvYFbWx9FQNLORRCd2NjMwokiogk1uqEO55ksRFHGeogns+GMnVyCRSwHfYn7Tbk7mRwIDjnId8vYdSciHVMB5FpAhHlKQUfwtU7Lepsi+vmBG/6aISZfLKe4qh8yHY3wiIHcDvw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR10MB5841.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(36756003)(2616005)(2906002)(6506007)(508600001)(6666004)(66476007)(316002)(186003)(66556008)(66946007)(83380400001)(6916009)(44832011)(26005)(1076003)(8676002)(4326008)(6512007)(86362001)(52116002)(6486002)(5660300002)(8936002)(38100700002)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fFq69HD6l+Gv5k6yQs15r9tBelwPPu7Ik+BlEXDvEVC0qLi4dbyDNBC2UR7A?= =?us-ascii?Q?D2LeoK0QYKgqZJA3ePaIgFGip5RUGGiPx5s8XHRvriUDqbUch/bU5R2CDDmi?= =?us-ascii?Q?DLh9tb90MoG+0HPPvw4dEqX9bGTz2K/Wp6DXImX2YtvaLXF7zm5sMujPyNAH?= =?us-ascii?Q?qCGAVtnzB5V5ltPH4OonCO9wEII4wmFHxw4tffPOdL9TmLjK++6dA8rrqYY9?= =?us-ascii?Q?FqzmKejfKBNsG42E+X7CKthkCvns6CvlHj44tTiqDy7CCBYkgDdL94leu2V0?= =?us-ascii?Q?WeNbOa8qQ+0Q0u+eqYLWkfp469d16TislAfo67FdGxCP2UQEYREQoTzcymo5?= =?us-ascii?Q?KSUQEq5eN65/GAKGNNCT7MouffPiyFUE9qRU7YlnNfF3ourKAXVSa8mPbZFh?= =?us-ascii?Q?zN+i2b/P9k6FkS8t+oT2cWP9LV+qPgONRZTpwmopQ0NcrStOoptZvwKcS0Ug?= =?us-ascii?Q?8uQaQEcJPCzXaEbaPiVRv23LnCx3s2niS4UG9gaAQmMei433Zs+3ZSYpbIBT?= =?us-ascii?Q?4O7sF0dE+ugv0NTdFNwfD6j0rXbL+FYaUE+VSrupq1LUwARgw1yDi6nZNySr?= =?us-ascii?Q?H7fQvkj0GtXcarwv7HAcnYNDTlrxyOLyxQeacdISTt8KuWwmXQa2WnMI5i+9?= =?us-ascii?Q?kUZZhhOwD3oE0tPL8k5Vi4I1NJnXPNXZLIiKSFvxS6Ep990dk+ZWQFoUr5Cp?= =?us-ascii?Q?zFrqD5nqWPunLF9vt13Awq35p4HLyXUSYIKwG4TQRctSStJqu/voivAiaGus?= =?us-ascii?Q?lpC5mm0TUVUXZVfArWNgHkk220R+0zm0SfLCr5Ng99aLGRb5u5r6AirisLP1?= =?us-ascii?Q?ARP3t72ImVGAl9SHVARxY4D4+NQuDBEJNp9RRrsWMIfA/ud93OeeBPymBRsB?= =?us-ascii?Q?/WpDGCZi9t2wZwBzsBqP//v2IJlPKgvUsYGG3kqQbBSuPmzhABM1ISNdf3cV?= =?us-ascii?Q?0oMSMkwiOghARdMF1Uq/2vRTpbXyhRMHdpGq4dZGqavc6nQXJaSFhIFQMiVJ?= =?us-ascii?Q?u7GUp61r8AkCyJgqn6CR8iYsFhqPC86YSRfJQqVii67GQ1t4STbc2Ne0wm4f?= =?us-ascii?Q?m+8xngAbbzpT4BP34QY4mnbZbbak0TARlrQPwBf9kp4Ry4n3+5XjyIZgscWB?= =?us-ascii?Q?UckN365RO1SiEafhiwQj0jG8j9JkBMArgI7uoNve1VtBiNPkcy5UMGrmdFlk?= =?us-ascii?Q?FUHZz6xeYiMR4l2wFXHp+OdWL/651UqyMUnFpFOsyUAejhf2/PXRTjEDmTvt?= =?us-ascii?Q?Eo2w29cJPHLv5e1bH+HJcbYuLphDZFxPnBLZDUwFwg7EMkjdZKAdwxkvNNj0?= =?us-ascii?Q?TgKvCo72HWyY/03Jn96TUWqzDO9RSqn3VKGjNnpZ4d45B4OHA50cPLo7BVxy?= =?us-ascii?Q?ivR+dZdHgC+GGe7g1t77yWxclPrnE1sEC4Q1scR6mcJWeMrXrfMLSHRdqAAX?= =?us-ascii?Q?+XvpLgKiVRdmowpOvr1uQ2BxA4E15aUxeqS4NcU2MHnGWzpDYe0OMg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5c1df8a-9f47-4c3d-835a-08da0b4517d6 X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5841.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 14:14:20.8023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DgatYsBHUGkbPlm/JvRqAyj1tLI5UDv2DfR7G2jXrWGPkJhijyZKX+u6DEk5xbsDo6bmHHXUdyROYK9lTBwa7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10292 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203210091 X-Proofpoint-GUID: _iPvyKmIyBySkXlAUtIZhfjOdEHER6sP X-Proofpoint-ORIG-GUID: _iPvyKmIyBySkXlAUtIZhfjOdEHER6sP Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=mark.kanda@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @oracle.onmicrosoft.com) X-ZM-MESSAGEID: 1647872634372100001 Content-Type: text/plain; charset="utf-8" Create KVM and HVF specific destory_vcpu_thread() routines to free env->xsave_buf. vCPU hotunplug related leak reported by Valgrind: =3D=3D132362=3D=3D 4,096 bytes in 1 blocks are definitely lost in loss reco= rd 8,440 of 8,549 =3D=3D132362=3D=3D at 0x4C3B15F: memalign (vg_replace_malloc.c:1265) =3D=3D132362=3D=3D by 0x4C3B288: posix_memalign (vg_replace_malloc.c:142= 9) =3D=3D132362=3D=3D by 0xB41195: qemu_try_memalign (memalign.c:53) =3D=3D132362=3D=3D by 0xB41204: qemu_memalign (memalign.c:73) =3D=3D132362=3D=3D by 0x7131CB: kvm_init_xsave (kvm.c:1601) =3D=3D132362=3D=3D by 0x7148ED: kvm_arch_init_vcpu (kvm.c:2031) =3D=3D132362=3D=3D by 0x91D224: kvm_init_vcpu (kvm-all.c:516) =3D=3D132362=3D=3D by 0x9242C9: kvm_vcpu_thread_fn (kvm-accel-ops.c:40) =3D=3D132362=3D=3D by 0xB2EB26: qemu_thread_start (qemu-thread-posix.c:5= 56) =3D=3D132362=3D=3D by 0x7EB2159: start_thread (in /usr/lib64/libpthread-= 2.28.so) =3D=3D132362=3D=3D by 0x9D45DD2: clone (in /usr/lib64/libc-2.28.so) Signed-off-by: Mark Kanda Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- accel/hvf/hvf-accel-ops.c | 11 ++++++++++- accel/kvm/kvm-accel-ops.c | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b23a67881c..bc53890352 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -462,12 +462,21 @@ static void hvf_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); } =20 +static void hvf_destroy_vcpu_thread(CPUState *cpu) +{ + X86CPU *x86_cpu =3D X86_CPU(cpu); + CPUX86State *env =3D &x86_cpu->env; + + g_free(env->xsave_buf); + generic_destroy_vcpu_thread(cpu); +} + static void hvf_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D hvf_start_vcpu_thread; - ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; + ops->destroy_vcpu_thread =3D hvf_destroy_vcpu_thread; ops->kick_vcpu_thread =3D hvf_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D hvf_cpu_synchronize_post_reset; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 5a7a9ae79c..0345a30139 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -74,6 +74,15 @@ static void kvm_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); } =20 +static void kvm_destroy_vcpu_thread(CPUState *cpu) +{ + X86CPU *x86_cpu =3D X86_CPU(cpu); + CPUX86State *env =3D &x86_cpu->env; + + g_free(env->xsave_buf); + generic_destroy_vcpu_thread(cpu); +} + static bool kvm_vcpu_thread_is_idle(CPUState *cpu) { return !kvm_halt_in_kernel(); @@ -89,7 +98,7 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, voi= d *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D kvm_start_vcpu_thread; - ops->destroy_vcpu_thread =3D generic_destroy_vcpu_thread; + ops->destroy_vcpu_thread =3D kvm_destroy_vcpu_thread; ops->cpu_thread_is_idle =3D kvm_vcpu_thread_is_idle; ops->cpus_are_resettable =3D kvm_cpus_are_resettable; ops->synchronize_post_reset =3D kvm_cpu_synchronize_post_reset; --=20 2.27.0