From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796554; cv=none; d=zohomail.com; s=zohoarc; b=em9uMzOMNMRD3xTdkCZsGaq83BaDkSJyfpJEb4D8+Icy3yknMMhY+9+mJtJ3u6KH6DeUcrCjnjQqdgZckcsGHrufh00mp1XyYFkfinOC0KeNtorZCgonmAnxjFKbbXOHy5kfewHIvV59veGZ0Mm5maSVL2uWeki5xr52BtGYkho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796554; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0QkXC8NBloa4lQ1dJr9n5F8IaX751sw3OjPlQ3q4G5M=; b=VqOkx7UcUj7skK6dVW4Mtm1/0QlSOBQ3Il8BqsduLMI7OOazNULxY113qVs4ptNS6mszcKDtGr0E14AKAQ5fgMa9qA9CPutAxgPSUVhV+2aWV2FJ+54cQyRWJ93vieUF9vLVe6YIalj725Z1ZgYg0tLh2T5HudD+mhCHFTGoJgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796554704220.70962324181107; Sun, 20 Mar 2022 10:15:54 -0700 (PDT) Received: from localhost ([::1]:57792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVz9m-0002u8-W7 for importer@patchew.org; Sun, 20 Mar 2022 13:15:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5h-0008Jb-NB for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:41 -0400 Received: from [2607:f8b0:4864:20::1034] (port=56074 helo=mail-pj1-x1034.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5f-0003Pm-Fm for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:41 -0400 Received: by mail-pj1-x1034.google.com with SMTP id e3so11256262pjm.5 for ; Sun, 20 Mar 2022 10:11:39 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0QkXC8NBloa4lQ1dJr9n5F8IaX751sw3OjPlQ3q4G5M=; b=IUNtxrArwdd6X13tTr7XaTLoskrITi858kDgSZzVI20oFinaGMzllLB2rOu8mpn/zY bRY/7/NOH75+hAFWcDESbPg5Yw3yNH4+s7vF6scnuqPQvD6o35QOLVxZm2e7rFb0Jyu3 mLtHN05YkIeIMnPXhUW2epT9gpkJqOF0kkmBXDwriBfYkGunPU8kvbafstue+/mBwJN/ eE985p9ir0ha8241XV1TC7EMaFCQwIbAJW6eWNRiCS7XrGZC768ViEkbER/8IS7xDWfw TxVcjWDnicy5JzgmTJEnRmgkXnL3D+tMwtB2uJIrlPkPgjorQ5cr4nsey11X1zbeq0bu NVNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0QkXC8NBloa4lQ1dJr9n5F8IaX751sw3OjPlQ3q4G5M=; b=JjsFbG+WWVNGyqm7HHkTdEJ0HJF2pQ3IG66qPYZ0WKribnnlBbSsdmIx8Xp1s03Nr4 jL1QRxSSaeEOT/zPYvKVLKNMGvQC6KtBfjHOgBXSoQoevyJhLDi3cyUHayheIwdSNrfF 53fR/QMDyf8eO4/PoGGskPGjQriAVTWY8RYzBksea/U4l/ePzVhnhGgvyWnhTJi09uGK CE0qqsGG3vuuZDgealu0kY4+j9FIIqfbjvsmS9rOL9CzwKAwgvPX2V/+dpNQNUjCa8zp Tv+xyeluPk381OMtI2CGM4jwcLQ3mS08d7gdmuQhNsRgVdh1eWGqAQIrz5iChUZzI7On 1cSA== X-Gm-Message-State: AOAM53097cAzovaia8ORc00UBWOrEYdPAStAD94kCnPvfcLUPlUZxhYt NbYezKL738BZ72Q5ZCG4e3VKwFUb+SM6lw== X-Google-Smtp-Source: ABdhPJz8PAdwcBUv9olNP7WDXxR/BGncXC8WIsc6l9IBxPqv5mTX8bWpJa8/l01QXdg1PnX4WLagzg== X-Received: by 2002:a17:90b:1642:b0:1c6:c6d0:fbfa with SMTP id il2-20020a17090b164200b001c6c6d0fbfamr11556396pjb.218.1647796297552; Sun, 20 Mar 2022 10:11:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 01/36] util/log: Drop manual log buffering Date: Sun, 20 Mar 2022 10:11:00 -0700 Message-Id: <20220320171135.2704502-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1034 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796560364100001 Content-Type: text/plain; charset="utf-8" This buffering was introduced during the Paleozoic: 9fa3e853531. There has never been an explanation as to why we may not allow glibc to allocate the file buffer itself. We certainly have many other uses of mmap and malloc during user-only startup, so presumably whatever the issue was, it has been fixed during the preceeding 18 years. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- include/qemu/log.h | 1 - bsd-user/main.c | 1 - linux-user/main.c | 1 - util/log.c | 21 ++++----------------- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 9b80660207..08b0cd0bb3 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -148,7 +148,6 @@ typedef struct QEMULogItem { extern const QEMULogItem qemu_log_items[]; =20 void qemu_set_log(int log_flags); -void qemu_log_needs_buffers(void); void qemu_set_log_filename(const char *filename, Error **errp); void qemu_set_dfilter_ranges(const char *ranges, Error **errp); bool qemu_log_in_addr_range(uint64_t addr); diff --git a/bsd-user/main.c b/bsd-user/main.c index 88d347d05e..08f43af235 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -405,7 +405,6 @@ int main(int argc, char **argv) } =20 /* init debug */ - qemu_log_needs_buffers(); qemu_set_log_filename(log_file, &error_fatal); if (log_mask) { int mask; diff --git a/linux-user/main.c b/linux-user/main.c index fbc9bcfd5f..2b06350688 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -679,7 +679,6 @@ int main(int argc, char **argv, char **envp) =20 log_mask =3D last_log_mask | (enable_strace ? LOG_STRACE : 0); if (log_mask) { - qemu_log_needs_buffers(); qemu_set_log(log_mask); } =20 diff --git a/util/log.c b/util/log.c index 2ee1500bee..ffa66a267e 100644 --- a/util/log.c +++ b/util/log.c @@ -72,8 +72,6 @@ static void qemu_logfile_free(QemuLogFile *logfile) g_free(logfile); } =20 -static bool log_uses_own_buffers; - /* enable or disable low levels log */ void qemu_set_log(int log_flags) { @@ -121,29 +119,18 @@ void qemu_set_log(int log_flags) assert(!is_daemonized()); logfile->fd =3D stderr; } - /* must avoid mmap() usage of glibc by setting a buffer "by hand" = */ - if (log_uses_own_buffers) { - static char logfile_buf[4096]; =20 - setvbuf(logfile->fd, logfile_buf, _IOLBF, sizeof(logfile_buf)); - } else { #if defined(_WIN32) - /* Win32 doesn't support line-buffering, so use unbuffered out= put. */ - setvbuf(logfile->fd, NULL, _IONBF, 0); + /* Win32 doesn't support line-buffering, so use unbuffered output.= */ + setvbuf(logfile->fd, NULL, _IONBF, 0); #else - setvbuf(logfile->fd, NULL, _IOLBF, 0); + setvbuf(logfile->fd, NULL, _IOLBF, 0); #endif - log_append =3D 1; - } + log_append =3D 1; qatomic_rcu_set(&qemu_logfile, logfile); } } =20 -void qemu_log_needs_buffers(void) -{ - log_uses_own_buffers =3D true; -} - /* * Allow the user to include %d in their logfile which will be * substituted with the current PID. This is useful for debugging many --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796551792199.09257669246654; Sun, 20 Mar 2022 10:15:51 -0700 (PDT) Received: from localhost ([::1]:57750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVz9i-0002s9-Ek for importer@patchew.org; Sun, 20 Mar 2022 13:15:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5h-0008Jc-QD for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:41 -0400 Received: from [2607:f8b0:4864:20::534] (port=43649 helo=mail-pg1-x534.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5g-0003Ps-D5 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:41 -0400 Received: by mail-pg1-x534.google.com with SMTP id c2so8730734pga.10 for ; Sun, 20 Mar 2022 10:11:39 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M/ctxNkdA4F57t1BuSuDblrpi1g8LEQZufq5SItlXL0=; b=FTL3iscay29zfTO59XP5jdSUPfXHxDQfZdKkj6nIakoCG6zEs5DElh8MOkziyJq+z+ u3/XHQHMEbSpO/TZALlN7aNtXR/wev8yeUJh2MIKMlZCkgmMddDPWKIbSQ96vGD5ciSN jcFvzzbP8I5/goeybHnwWnvhvw5zqKF+vDRomZD7ptJy//NGXAk50VtvoiNesuCv06eb Xa8A2eUjyjcbmySFZOD89TGzcGMEfKNi0d7ApYeXPrYu4Vd4Bt6PETp0b0C5kRJcHqWU r/MFxBpBqZqDKno8nLWgWCRhLhlRs3FOt9bW14omwJunqYMwwNqhc3JBnyAuAo2ZxAoY OQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M/ctxNkdA4F57t1BuSuDblrpi1g8LEQZufq5SItlXL0=; b=TsEenF28HVEsiXGB2gnJHWjqAyaSPSck0A4dXwWL4eMS6xu4juC3HcVTAHfAHma2dh NZtZGYQPFL1COlFcGTiPKdoWSsXtlob9LHeRwBeFjyGGN/gwS/mu5UrAtintTQuQC3Np vmveODr7bQsI7O0qNVS3cxK+oMWvGcFKbSx/t35tM63UV8LAbLkKkQDi22uAWCZIRIxZ LoC3HLQCvKhe9ccjxUWfMBKRvSrMT0oGv90KUYEaDzm1bM0hS3FCe4cRu3/aAS/ekNt8 QuRalT0jyvwgjeaL9hykxYE7moPCwQ6M81MRaEY8qT3xEvql0VXI2dHfBb+Z19H7KNBT Cgdw== X-Gm-Message-State: AOAM530XSphRyv3tEv0XvXwgTK+esC2SGlo046vf4p27fOpAeCduhBeN hfS9o87VK4pKka8jqGDywWXc9eZh91CBbA== X-Google-Smtp-Source: ABdhPJysiu6cMrwmBO/wFmsFUFQJNjytov2KyNUs6pot+UlXK0fezKTEY2hQQdUR6mFzVPr0s2mAdw== X-Received: by 2002:a05:6a00:1799:b0:4f7:37cd:d03e with SMTP id s25-20020a056a00179900b004f737cdd03emr19951563pfg.10.1647796298588; Sun, 20 Mar 2022 10:11:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 02/36] target/hexagon: Remove qemu_set_log in hexagon_translate_init Date: Sun, 20 Mar 2022 10:11:01 -0700 Message-Id: <20220320171135.2704502-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::534 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x534.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taylor Simpson , alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1647796553360100001 Content-Type: text/plain; charset="utf-8" This code appears to be trying to make sure there is a logfile. But that's already true -- the logfile will either be set by -D, or will be stderr. In either case, not appropriate here. Cc: Taylor Simpson Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- target/hexagon/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index b6f541ecb2..98f1452cad 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -874,12 +874,6 @@ void hexagon_translate_init(void) =20 opcode_init(); =20 - if (HEX_DEBUG) { - if (!qemu_logfile) { - qemu_set_log(qemu_loglevel); - } - } - for (i =3D 0; i < TOTAL_PER_THREAD_REGS; i++) { hex_gpr[i] =3D tcg_global_mem_new(cpu_env, offsetof(CPUHexagonState, gpr[i]), --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796758; cv=none; d=zohomail.com; s=zohoarc; b=URiyI4XLcqnYBeDuoKB+a+LZk2fqCpwQ4Khk75UUnb7WDPLS+i8hqRjmBotpwySnJfWS0IjCFTzWgmsJg7MoIelOXUjF6bt7omem+te+iT6VGH+Hy2BwK0yQ6hKwePT1P81+fY4Pu3fmUWgxw9wq8IXuUm4V0Ofj+B5jvGLE/iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796758; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b2ya2A1S2MCUsCKLp1XEUHbTLCi7pkZD7YHsJk5p0As=; b=i5QG65F/ClkEamYWiyIVdF8BgXJTB00ASbxJzzFlwvnep/RFsCHemK+c+GInafyNvmkhe+57BBc8LD9wv2wX50+fXTl7iJVLHOq6y0Pv/+ocpPUAzTjcLlThg2QdbsHwJ2lZ2YXr+haH7CP8ug0xILvlYswgRjhpXVetv4Zy+7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796758763759.2653361674729; Sun, 20 Mar 2022 10:19:18 -0700 (PDT) Received: from localhost ([::1]:38060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzD3-0000C6-K6 for importer@patchew.org; Sun, 20 Mar 2022 13:19:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5j-0008Ju-0y for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:45 -0400 Received: from [2607:f8b0:4864:20::1030] (port=45828 helo=mail-pj1-x1030.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5h-0003Q6-9U for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:42 -0400 Received: by mail-pj1-x1030.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so12524633pjl.4 for ; Sun, 20 Mar 2022 10:11:40 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b2ya2A1S2MCUsCKLp1XEUHbTLCi7pkZD7YHsJk5p0As=; b=iUwwjRQMsUrAZcnFxnhCZ+NMvTBPzOZQl/4LKpTwXCriBx3VVeBB/NBnpW+KS9BBpE CsbOgtX7zzjGFwYw0G8PnQLUO6fPOlZFGFRg1OHrLxcf9Y620M8tba5Udm3WS3bQwHoe lAJpfa8/Y/03sGoqBvjKPbHPGtYcdZMUpgt+m8i2QF6HQ+Lspp6uFTWcxw1Veo/t52d+ IBBrpMZoTZm2obIKQkcpmIs/P/9e8BTfhecR9oy2lX7aZM2HpiPjRm77pYHexQ9PnMCn /ZG0sPf3l5ThlP8rPXi6/Expp5apAt3UMRt7KphL4hLGvuW85df0Zn+Lc3ggkUQwpvUR wcXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b2ya2A1S2MCUsCKLp1XEUHbTLCi7pkZD7YHsJk5p0As=; b=MkOXPmISuEFhTANOotMsB0eHYWRQTqnI2ejeJFaVQlA1Lz6+ZniOHBGhZFtwmXZqNG fdTSWQ5i/1e4y4EgX7110cJXP/0OCnAlbXqfJLiNbBGGoWxrYV0OBRWhwmESL8je16/H 2HrhYkaHEH84C5asgyS8Eo5lTmOP1w3BX/m4OVmoJjmSVs3JQ/TgLb1L90zh7SeDGV8s elUHl9jp2qJTqLslmYjeiVw2qoXAG7M59R3uNHm4DXWogTcfkVlB0qv4BdxhOVS6qU/M bVlo6laJKOkEN7V+KfBOwfctwK9mTpNTzmNVvMa1OTYKXb/tULNy5m0wyqPUGYZb9Hkf axXw== X-Gm-Message-State: AOAM532DIXAjPz32giZxwjBAooZlq7rpihQ7rpJLjYW1pvdhhCbJ7YYv lh7jRTflvrbVXjN1nlL+TkYx28oJN98jYg== X-Google-Smtp-Source: ABdhPJxEECvR/DJ96Pailr59ZrsfbTb75yR+EAhcVYaPlUF2QSyXgW1Gd4fQrfv+XXAwNEwqowPv7w== X-Received: by 2002:a17:90b:4b4b:b0:1be:fd9a:c279 with SMTP id mi11-20020a17090b4b4b00b001befd9ac279mr32567083pjb.83.1647796299913; Sun, 20 Mar 2022 10:11:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 03/36] util/log: Pass Error pointer to qemu_set_log Date: Sun, 20 Mar 2022 10:11:02 -0700 Message-Id: <20220320171135.2704502-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1030 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796760491100001 Content-Type: text/plain; charset="utf-8" Do not force exit within qemu_set_log. Pass an Error value back up the stack as per usual. Signed-off-by: Richard Henderson --- include/qemu/log.h | 2 +- bsd-user/main.c | 2 +- linux-user/main.c | 2 +- monitor/misc.c | 7 ++++++- qemu-img.c | 2 +- qemu-io.c | 2 +- qemu-nbd.c | 2 +- scsi/qemu-pr-helper.c | 2 +- softmmu/vl.c | 4 ++-- storage-daemon/qemu-storage-daemon.c | 2 +- tests/unit/test-logging.c | 2 +- util/log.c | 10 +++++----- 12 files changed, 22 insertions(+), 17 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 08b0cd0bb3..64f28785ae 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -147,7 +147,7 @@ typedef struct QEMULogItem { =20 extern const QEMULogItem qemu_log_items[]; =20 -void qemu_set_log(int log_flags); +void qemu_set_log(int log_flags, Error **errp); void qemu_set_log_filename(const char *filename, Error **errp); void qemu_set_dfilter_ranges(const char *ranges, Error **errp); bool qemu_log_in_addr_range(uint64_t addr); diff --git a/bsd-user/main.c b/bsd-user/main.c index 08f43af235..0c8aa1ae90 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -414,7 +414,7 @@ int main(int argc, char **argv) qemu_print_log_usage(stdout); exit(1); } - qemu_set_log(mask); + qemu_set_log(mask, &error_fatal); } =20 if (optind >=3D argc) { diff --git a/linux-user/main.c b/linux-user/main.c index 2b06350688..6aed4929ab 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -679,7 +679,7 @@ int main(int argc, char **argv, char **envp) =20 log_mask =3D last_log_mask | (enable_strace ? LOG_STRACE : 0); if (log_mask) { - qemu_set_log(log_mask); + qemu_set_log(log_mask, &error_fatal); } =20 if (!trace_init_backends()) { diff --git a/monitor/misc.c b/monitor/misc.c index b1839cb8ee..8e8b8e18c7 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -429,6 +429,7 @@ static void hmp_log(Monitor *mon, const QDict *qdict) { int mask; const char *items =3D qdict_get_str(qdict, "items"); + Error *err =3D NULL; =20 if (!strcmp(items, "none")) { mask =3D 0; @@ -439,7 +440,11 @@ static void hmp_log(Monitor *mon, const QDict *qdict) return; } } - qemu_set_log(mask); + + qemu_set_log(mask, &err); + if (err) { + error_report_err(err); + } } =20 static void hmp_singlestep(Monitor *mon, const QDict *qdict) diff --git a/qemu-img.c b/qemu-img.c index 5dffb3e616..498f6d3646 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -5442,7 +5442,7 @@ int main(int argc, char **argv) exit(1); } trace_init_file(); - qemu_set_log(LOG_TRACE); + qemu_set_log(LOG_TRACE, &error_fatal); =20 /* find the command */ for (cmd =3D img_cmds; cmd->name !=3D NULL; cmd++) { diff --git a/qemu-io.c b/qemu-io.c index 3924639b92..49957a980e 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -634,7 +634,7 @@ int main(int argc, char **argv) exit(1); } trace_init_file(); - qemu_set_log(LOG_TRACE); + qemu_set_log(LOG_TRACE, &error_fatal); =20 /* initialize commands */ qemuio_add_command(&quit_cmd); diff --git a/qemu-nbd.c b/qemu-nbd.c index 713e7557a9..bf9c5fedce 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -804,7 +804,7 @@ int main(int argc, char **argv) exit(1); } trace_init_file(); - qemu_set_log(LOG_TRACE); + qemu_set_log(LOG_TRACE, &error_fatal); =20 socket_activation =3D check_socket_activation(); if (socket_activation =3D=3D 0) { diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index f281daeced..1f2a84c534 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -1001,7 +1001,7 @@ int main(int argc, char **argv) exit(EXIT_FAILURE); } trace_init_file(); - qemu_set_log(LOG_TRACE); + qemu_set_log(LOG_TRACE, &error_fatal); =20 #ifdef CONFIG_MPATH dm_init(); diff --git a/softmmu/vl.c b/softmmu/vl.c index 0b81f61535..73296015af 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2569,9 +2569,9 @@ static void qemu_process_early_options(void) qemu_print_log_usage(stdout); exit(1); } - qemu_set_log(mask); + qemu_set_log(mask, &error_fatal); } else { - qemu_set_log(0); + qemu_set_log(0, &error_fatal); } =20 qemu_add_default_firmwarepath(); diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-sto= rage-daemon.c index dd18b2cde8..cdaf69f764 100644 --- a/storage-daemon/qemu-storage-daemon.c +++ b/storage-daemon/qemu-storage-daemon.c @@ -392,7 +392,7 @@ int main(int argc, char *argv[]) if (!trace_init_backends()) { return EXIT_FAILURE; } - qemu_set_log(LOG_TRACE); + qemu_set_log(LOG_TRACE, &error_fatal); =20 qemu_init_main_loop(&error_fatal); process_options(argc, argv, false); diff --git a/tests/unit/test-logging.c b/tests/unit/test-logging.c index ccb819f193..93c6d666e8 100644 --- a/tests/unit/test-logging.c +++ b/tests/unit/test-logging.c @@ -123,7 +123,7 @@ static void test_logfile_write(gconstpointer data) * In cases where a logging backend other than log is used, * this is needed. */ - qemu_set_log(CPU_LOG_TB_OUT_ASM); + qemu_set_log(CPU_LOG_TB_OUT_ASM, &error_abort); file_path =3D g_build_filename(dir, "qemu_test_log_write0.log", NULL); file_path1 =3D g_build_filename(dir, "qemu_test_log_write1.log", NULL); =20 diff --git a/util/log.c b/util/log.c index ffa66a267e..00773ab717 100644 --- a/util/log.c +++ b/util/log.c @@ -73,7 +73,7 @@ static void qemu_logfile_free(QemuLogFile *logfile) } =20 /* enable or disable low levels log */ -void qemu_set_log(int log_flags) +void qemu_set_log(int log_flags, Error **errp) { bool need_to_open_file =3D false; QemuLogFile *logfile; @@ -103,9 +103,9 @@ void qemu_set_log(int log_flags) if (logfilename) { logfile->fd =3D fopen(logfilename, log_append ? "a" : "w"); if (!logfile->fd) { - g_free(logfile); - perror(logfilename); - _exit(1); + error_setg_errno(errp, errno, "Error opening logfile %s", + logfilename); + return; } /* In case we are a daemon redirect stderr to logfile */ if (is_daemonized()) { @@ -159,7 +159,7 @@ void qemu_set_log_filename(const char *filename, Error = **errp) } =20 qemu_log_close(); - qemu_set_log(qemu_loglevel); + qemu_set_log(qemu_loglevel, errp); } =20 /* Returns true if addr is in our debug filter or no filter defined --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796725; cv=none; d=zohomail.com; s=zohoarc; b=W3pK8PeWbupiSH+iNqdathx2WkqTcys63Qo18g/O/nc5d30YOb9eNLe2LETiQINPgMu0uklKVqeu0qNg4tEPeJvoWsTZSc0GfGDzrUhcuXEMFx2Je7tSmBpycTXcDPZHB+fTU0d6feR1G58P+CF2ilszluVJFCvDv4ksewcmBqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796725; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3tVjuQw+/CoLqgI+CPACWtQapf8H6hrbx2q6SrEHdT0=; b=TjxZOd11DOlbsWVwwVP1QHGzdJjm1IE7vD5ojOYyhdsFpBjavO+jwWtQXSnV4bpuLPSGknEKNN/RM+if6iHbQ2qEAMODfHZCr77cau3CtBSxoJ4308sjSsBr7zmUyhFpRVwYzICtmqXJwzaIq0wQVym1Y71vINbACrFr/gTpR00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796725333586.5089279296833; Sun, 20 Mar 2022 10:18:45 -0700 (PDT) Received: from localhost ([::1]:37810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzCW-0008T6-CF for importer@patchew.org; Sun, 20 Mar 2022 13:18:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5j-0008Jw-VI for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:45 -0400 Received: from [2607:f8b0:4864:20::42f] (port=33474 helo=mail-pf1-x42f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5i-0003QJ-3K for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:43 -0400 Received: by mail-pf1-x42f.google.com with SMTP id s42so13739822pfg.0 for ; Sun, 20 Mar 2022 10:11:41 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3tVjuQw+/CoLqgI+CPACWtQapf8H6hrbx2q6SrEHdT0=; b=v2I1qxEx1BDTBGsmT1JLooy8xjBo8HT1b9xXdVwScsORoy0NiawfCSJRgX1kliul+V MFS2gL9pkuvuKBHt8jZqV3PY6toKQU567K2FmgnrJ3Yu4f6ZwcS8N0fseVp9g0bOTvGR 0dUNbELk93KpmzydSiJDVo5i7O8vHeN3VqdfvrN/OrUqYbQ3B9V8KbadkCpxVl0Jz6ns rsciYjcmBfQoTLXyHlNFGU9nLw4v3/EhPVw23wK9SU3LI9aoke91uF4COcDDFQMRBazJ 8bQIcnWSjtqYkAJI4lwXFH06nRP6GvrV8i2PdJ7WIfj3vPlSVC/2nMqSx2e0ExzoiB5J gdSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3tVjuQw+/CoLqgI+CPACWtQapf8H6hrbx2q6SrEHdT0=; b=4Kp+jhznXqICPDRLH6NNFP33Vnvse9LUf04Jy2fMGyabt+YBAF+46zwB86G6USV0dC bKat/3v2MGJVuyA0brVMVvhpsHevlMFydi3hYZX2qCkFiRXZxKdywHSaV5/mLHGbQGTP 8R1F+DVcope6ua7MFaFZhS0Sk/1ruTG4WslJvAdwLBrK56d5Fm6bUA0kI0fCHTmApiq6 5PXOrsREKzAEK214tQ6pqFAaBHRqKRDbxLRrGp31l0+aPZH9Cw6ykhtQjHPRnBpCFL7a CNmiYLXNyqi4ZzIZIxK6Zw8q4LYdZI0TF/QNFVsZ6+xQUgHpN7npddGNEGSFAmdTUDxj U3/w== X-Gm-Message-State: AOAM532hT6If40DWe7VAV5P5w/bBHpS+xlpdzqX82ZzRM+Am44qaCl8g TA6TGyhY5l8GwcdUBMZf1nmSCUtJDtY9uw== X-Google-Smtp-Source: ABdhPJxJQnnP8bKzzckQKQSdzEpa8R/0WoSzEzN/1FnZVT+oC7TvAcAPSQwe0fX9yBookQFRJmf4vA== X-Received: by 2002:a05:6a00:1944:b0:4fa:952b:48cd with SMTP id s4-20020a056a00194400b004fa952b48cdmr3031902pfk.10.1647796300839; Sun, 20 Mar 2022 10:11:40 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 04/36] os-posix: Use qemu_log_enabled Date: Sun, 20 Mar 2022 10:11:03 -0700 Message-Id: <20220320171135.2704502-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796726188100001 Content-Type: text/plain; charset="utf-8" Do not reference qemu_logfile directly; use the predicate provided by qemu/log.h. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- os-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os-posix.c b/os-posix.c index 24692c8593..20d31fc518 100644 --- a/os-posix.c +++ b/os-posix.c @@ -292,7 +292,7 @@ void os_setup_post(void) dup2(fd, 0); dup2(fd, 1); /* In case -D is given do not redirect stderr to /dev/null */ - if (!qemu_logfile) { + if (!qemu_log_enabled()) { dup2(fd, 2); } =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796765; cv=none; d=zohomail.com; s=zohoarc; b=gY7fiI6fKMOPkokfJSLq1aV7gWKfURMVy9CrTbsdpV7p2ajAGs2UfLcqaBHckABBRqIoshbBMB3Tia8C6dzSTiK7JqAwtwNEVw1eHqBVG5PpL1y+M+FK99MvFNwNHHWPpPsRMfKumHElTnjsMdMkVUN+0tP1GsiWQ5TilYmVhs4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796765; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4kTl/W0nqOk5wuB3SJo0d0RYWr70TQFHqQ4WUsLcxUk=; b=bNECLZxTgvs5L9Q8IsiqO0Of9oF1mfPB+77gdP1j0vJkeJaVK6hP3i5OTTNOsBCVgorNs1kcDtoPEkw7u3+bRYEN6vDnKJRypg0R2fbVSMpGRyQDubS7SVrvQDpkdSmI36zwfsPIA1SpCLFgvuWVnsGHxA4caToQ2bL11sokTZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796765293206.23226055763985; Sun, 20 Mar 2022 10:19:25 -0700 (PDT) Received: from localhost ([::1]:38210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzDA-0000If-BL for importer@patchew.org; Sun, 20 Mar 2022 13:19:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5l-0008KQ-Sj for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:45 -0400 Received: from [2607:f8b0:4864:20::633] (port=46965 helo=mail-pl1-x633.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5i-0003QZ-Tk for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:44 -0400 Received: by mail-pl1-x633.google.com with SMTP id w4so10855992ply.13 for ; Sun, 20 Mar 2022 10:11:42 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4kTl/W0nqOk5wuB3SJo0d0RYWr70TQFHqQ4WUsLcxUk=; b=M3P3Yk0MiS+YZPPtSqOjllT5zVJ1uK+JS/97MRHfoad8QVLnOlZS+TiqNPBVsZU270 kGjYNAJSbNVGFiHnefpkbrJTeud6AB14jZrOofJ2XvCQX+0D+g9kdL3xrwWMiSBV9YH1 j6I2YqypQff3+qxR/KqvIKNaE4yrq6tezk0etgGmgCX3wL5n5H3HcZLbqXLGzcPAX3I0 gZ+pi1Br5VOCpUxxgu8KscoxRZNzlbF23XtQOCDyd709dByOnR6jWqA3hnf46kkdMtXg ms1IBTk8UI0CV6cj835JIVPw4uIA/+Cczb2KIU1e7l6JMYd9gdbLqqkbR7jrtxpurmI1 y0Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4kTl/W0nqOk5wuB3SJo0d0RYWr70TQFHqQ4WUsLcxUk=; b=MkIJn2t/FqXhDQEJv32ThzGEWPo9TdvugAD3+UoX8RaeEwv07Zz5JNFVkDupszZiTa t9+3RXfX2Zh/sqH8augFFn0YpjUUrcLsNb/1UGPLfuDGRZ55aOgQtrgTtp4E2mkBDwb2 RCq7OkrxgNaMpQ3Q/d+7MI4iCXyv0asNx2cyILJPIi617SGr8sInv6flelF+5gDQ+5Z8 kDlp3cg7mAz20wX2249t1+Fnq8SdLlUKGER1kDQ7Mk1TrSpuLIJH9dSw+LEi2vzSuC5i JsAj1OdGQAp+/mde+Q4pW3w5Uh5nzwaQ0oKK22sn+xnCxrUQvU4PZ8CJjTDLeO6LuXVi cX4Q== X-Gm-Message-State: AOAM530GI9fwbnCGERsNQ1Kb/pRyaCgBK1nV3sYeY9pmNh5c/M8jyNd6 r7LnUNtuI4QLrzqFLibrnKwl/k7mqLUCXw== X-Google-Smtp-Source: ABdhPJw9koSJs/Wm4tRiWZvDgompChBYfrI22p7A7yOFI24Ajffyq6vt1PN+ijEGoSyc34DPoxxF6Q== X-Received: by 2002:a17:903:228f:b0:154:5350:be02 with SMTP id b15-20020a170903228f00b001545350be02mr2168616plh.53.1647796301670; Sun, 20 Mar 2022 10:11:41 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 05/36] util/log: Move qemu_log_lock, qemu_log_unlock out of line Date: Sun, 20 Mar 2022 10:11:04 -0700 Message-Id: <20220320171135.2704502-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::633 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796766558100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/log.h | 28 +++------------------------- util/log.c | 23 +++++++++++++++++++++++ 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 64f28785ae..10e284291c 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -65,32 +65,10 @@ static inline bool qemu_log_separate(void) /* LOG_STRACE is used for user-mode strace logging. */ #define LOG_STRACE (1 << 19) =20 -/* Lock output for a series of related logs. Since this is not needed - * for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we - * assume that qemu_loglevel_mask has already been tested, and that - * qemu_loglevel is never set when qemu_logfile is unset. - */ +/* Lock/unlock output. */ =20 -static inline FILE *qemu_log_lock(void) -{ - QemuLogFile *logfile; - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - qemu_flockfile(logfile->fd); - return logfile->fd; - } else { - return NULL; - } -} - -static inline void qemu_log_unlock(FILE *fd) -{ - if (fd) { - qemu_funlockfile(fd); - } - rcu_read_unlock(); -} +FILE *qemu_log_lock(void); +void qemu_log_unlock(FILE *fd); =20 /* Logging functions: */ =20 diff --git a/util/log.c b/util/log.c index 00773ab717..248db6211e 100644 --- a/util/log.c +++ b/util/log.c @@ -34,6 +34,29 @@ int qemu_loglevel; static int log_append =3D 0; static GArray *debug_regions; =20 +/* Lock/unlock output. */ + +FILE *qemu_log_lock(void) +{ + QemuLogFile *logfile; + rcu_read_lock(); + logfile =3D qatomic_rcu_read(&qemu_logfile); + if (logfile) { + qemu_flockfile(logfile->fd); + return logfile->fd; + } else { + return NULL; + } +} + +void qemu_log_unlock(FILE *fd) +{ + if (fd) { + qemu_funlockfile(fd); + } + rcu_read_unlock(); +} + /* Return the number of characters emitted. */ int qemu_log(const char *fmt, ...) { --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796988; cv=none; d=zohomail.com; s=zohoarc; b=VYk2ekSqa86Z/WgC629Jkl9JcXzRGU8utpCHA2Xclui/VZmxt9AvWX06A111V82zKg2aVXWxzv3uYGM20tzRdgPHS8OnaI1cKuLhOv+ERBmzgx7QiUftzem6sTaaD0FfKB0sjdZPChLG7YL/1j+zXpL8X5wkhVcF4U8V/VsjOsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796988; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AiGXKmM5Cv0Fdfz4VnJTiU6gz9cUezs0SPdSZR5WJXA=; b=ZpUqVlb1b1xRVJvr4R4DS2mHTBO26/mJgq3vSZXGfuIRGAySRcjAYocKi78hY9IFtjpTaeP/ppNmTd3RzQXf8auPJ9Pt6wbjUwP1fVcWampXggO6UKNkFEwMMoS3wl7L+sAraXjmEAf9zsfRkeRx6mNmJG4x33KN0d1RF9ys6tY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796988449438.3596972247635; Sun, 20 Mar 2022 10:23:08 -0700 (PDT) Received: from localhost ([::1]:46776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzGl-000645-3Z for importer@patchew.org; Sun, 20 Mar 2022 13:23:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5l-0008KR-TL for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:45 -0400 Received: from [2607:f8b0:4864:20::52b] (port=33514 helo=mail-pg1-x52b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5j-0003Qe-O4 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:44 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 6so8741555pgg.0 for ; Sun, 20 Mar 2022 10:11:43 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AiGXKmM5Cv0Fdfz4VnJTiU6gz9cUezs0SPdSZR5WJXA=; b=F160S3K/J48W+34HwvHGEi2w7IO1lXA6+C3AXYSIsvRVDt4Dx1nheHumuqD6Xh46fw pYnCdMRDC62bytTuEtjsMV5GIBiuqVVvNXtGb/6kL2BJwCGbfQW3BsbgzARHIvvOe0JN dQ6FE+6FelVt2t6SqrwAF89fYD9sfEJn9nLrurOrCzEsgtZMh6nfhRvScvwiKI9lWexz PrIVlu3XwtKdQxCj2qviGUDXKM1UQjNl+rnCwlDpqFaN3Nqr/KgiDQUIP3+1NwZmE6Bc dcUDSMGwhlGx2VLQRXGs7c06P+TcaOqK8/kBjtyY1aBgY4aevPWIXfmIVHqoXxf/POD5 yd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AiGXKmM5Cv0Fdfz4VnJTiU6gz9cUezs0SPdSZR5WJXA=; b=SXZgwq0XDnfZa1USwuHl1pY6uRJ7dj+H0SH7qbsJB94sLXVb1vxYQ8Anprq9p9kXrm WgrwE0jB99Murdg6RKm/gr+sfNdESMk0KIe/C39zE5XOpOmA/EegkJ42ThGEl6ut9+Ip v9iccHyDMqoeKG/T2+vRf4orjgzzNuUhXshWgniI5wWHPNgKJ443kv7aeyWnqIEGG1Bm piDKjmcKsP8dA8mfwk5HJODSRISTN6vc8LZO/+zTWXcQDkXzZvRIJ+MALbthth9nmKMx CMY+2ZZwO03ROgf0v6R21xiOTAARFMtGOhikU2cRR9cxsb6d5y5bxd6nrOZGqm4Tz8Vp wTIA== X-Gm-Message-State: AOAM530iG4buz8S6qU2ECZML32lIOxZnGl/n9MNL0O0nG/LG90Vhpljy RmXgB+BklmxIIpii6PwEPQCnsSHcNqMHSA== X-Google-Smtp-Source: ABdhPJxMNrKHXmPFGKVT/MAvtb8fXSg/ab7TvxxVnJTKEhghqMl/B8sKE1nG5smllntRpigG9ZJTcg== X-Received: by 2002:a05:6a00:814:b0:4f7:4c6:1227 with SMTP id m20-20020a056a00081400b004f704c61227mr20241967pfk.54.1647796302389; Sun, 20 Mar 2022 10:11:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 06/36] util/log: Treat qemu_log_lock like trylock Date: Sun, 20 Mar 2022 10:11:05 -0700 Message-Id: <20220320171135.2704502-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52b (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796989930100003 Content-Type: text/plain; charset="utf-8" Do not require qemu_log_unlock to be called when qemu_log_lock returns NULL. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- util/log.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/log.c b/util/log.c index 248db6211e..b1651d8122 100644 --- a/util/log.c +++ b/util/log.c @@ -39,12 +39,14 @@ static GArray *debug_regions; FILE *qemu_log_lock(void) { QemuLogFile *logfile; + rcu_read_lock(); logfile =3D qatomic_rcu_read(&qemu_logfile); if (logfile) { qemu_flockfile(logfile->fd); return logfile->fd; } else { + rcu_read_unlock(); return NULL; } } @@ -53,8 +55,8 @@ void qemu_log_unlock(FILE *fd) { if (fd) { qemu_funlockfile(fd); + rcu_read_unlock(); } - rcu_read_unlock(); } =20 /* Return the number of characters emitted. */ --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796969; cv=none; d=zohomail.com; s=zohoarc; b=aJROTUiP8fi4hmG/SaK24od+7oNeHHFsFQmrsnW7QxSdJmvEXe3rSmucX450b0QGWcIxyu4cfd7Q683pNumgFE9pQAHA5vKTfUuMT9kw7xUWZu4epnGPiAzqdQrxk1/9YzJswJcEc/+pJ6Q1Fhxes/ruIa2ncx06BT6sVFJNmv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796969; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J1dSl4TTW2l9haojZKtDE3xV0KCAHP/jmJTof7woW9Y=; b=m/dyZvCV5Z1Cc82xGRQRo0lvg4Iy7470pp5MWNqFArCVbnrzusmq5rmoZQqJgfVtPm7yu6FYBkgq8/683YowRyKuVEkmQPzh433+tAn3ahPPq6YiKv0n0ykQgzUaVuj/fdKOPPvWP3YMCylBl+Lw8UGu9nb2E9jFnYmcBJR1Asw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796969521636.799658076335; Sun, 20 Mar 2022 10:22:49 -0700 (PDT) Received: from localhost ([::1]:46380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzGS-0005nT-0Q for importer@patchew.org; Sun, 20 Mar 2022 13:22:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5n-0008Lk-IF for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:47 -0400 Received: from [2607:f8b0:4864:20::532] (port=35759 helo=mail-pg1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5l-0003Qn-K0 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:46 -0400 Received: by mail-pg1-x532.google.com with SMTP id e6so8737180pgn.2 for ; Sun, 20 Mar 2022 10:11:44 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J1dSl4TTW2l9haojZKtDE3xV0KCAHP/jmJTof7woW9Y=; b=G3Zx6dmWTDj3rdH7H5Zzsiei+VsMlRBdn5ump6JYSnDHw7m/W6ssIub/PxMwr20Zud yhJbqbnvQXxy0GyosxouG3qihWKYvoBPDMZPar/MGV2KJpty9jJUMzQbSVhuk7WL8jHW SIYRI+bc6qjcszOSKGah1fKXvwL9oEy5CUaYFg+MkSqhopNKoMsmKkmJFSbx+g5dhKZq o+0S0PehzgYmtYeSpvUuOpF/a8b4i6f2KDczyj1hE5Pa8BVmMVdxU7/PZ4N3u4AKZ1oc QVfCsgilgH9C+dDh9pC1cBaJ6OdYh8AhKjy1tEXwSAegoyCqCZuBtPRniVPQLqDj+yM8 9KEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J1dSl4TTW2l9haojZKtDE3xV0KCAHP/jmJTof7woW9Y=; b=qh5MvREFmkFuUrt80a6DH+8IOcnjfXctbm0PpX8VRQRrido/RkeUGVwliNxe/fWS3S ZIQ9BNn2Bv+qJ8AcvrJkocB71dA2VQ6mJnWmxOj3ni14wTZCX2QOG/tfyIA94Y4MpTzU 8ty//Iv7LzgUYf7KyyQYXXLCIqDojQnxBQGsQebI5XmWz+CVNQgO0pb1Rg8xBM5U8o1/ cOs+ppyZ/39/gh8UAqA2ckOdCAvjKLZvKWrbcf6QOu1WJr7AwblJwSNF4x8/8e+N6NLR hg64NNRed+UOJwmdw6JrE2/hlfQ1i6WtQBBm+Sj+5f27tvKucxarUPxrP6vzBNxdJsyT 4QOg== X-Gm-Message-State: AOAM532IDG/ifR0wyeYJGMkCjUMEZDuqPiZjqYBJ9f2c8zIii37iTDfD dk+pmX2yU1FcgTge3f5+bCHVU2LZWGAQYA== X-Google-Smtp-Source: ABdhPJxXMBpkcykVo18sISt1zlvE2uxrLgjrfECUsEsT3V8NL7Vy5Zyd2elX5eCQIrjFrK6s7oJIyg== X-Received: by 2002:a63:4766:0:b0:382:6cc2:c0d3 with SMTP id w38-20020a634766000000b003826cc2c0d3mr3234343pgk.6.1647796303299; Sun, 20 Mar 2022 10:11:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 07/36] hw/xen: Split out xen_pv_output_msg Date: Sun, 20 Mar 2022 10:11:06 -0700 Message-Id: <20220320171135.2704502-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::532 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796971960100001 Content-Type: text/plain; charset="utf-8" Do not replicate the individual logging statements. Use qemu_log_lock/unlock instead of qemu_log directly. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- hw/xen/xen_pvdev.c | 44 ++++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index 8ab458922a..355bbda60d 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -196,34 +196,38 @@ const char *xenbus_strstate(enum xenbus_state state) * 2 =3D=3D noisy debug messages (logfile only). * 3 =3D=3D will flood your log (logfile only). */ +static void xen_pv_output_msg(struct XenLegacyDevice *xendev, + FILE *f, const char *fmt, va_list args) +{ + if (xendev) { + fprintf(f, "xen be: %s: ", xendev->name); + } else { + fprintf(f, "xen be core: "); + } + vfprintf(f, fmt, args); +} + void xen_pv_printf(struct XenLegacyDevice *xendev, int msg_level, const char *fmt, ...) { + FILE *logfile; va_list args; =20 - if (xendev) { - if (msg_level > xendev->debug) { - return; - } - qemu_log("xen be: %s: ", xendev->name); - if (msg_level =3D=3D 0) { - fprintf(stderr, "xen be: %s: ", xendev->name); - } - } else { - if (msg_level > debug) { - return; - } - qemu_log("xen be core: "); - if (msg_level =3D=3D 0) { - fprintf(stderr, "xen be core: "); - } + if (msg_level > (xendev ? xendev->debug : debug)) { + return; } - va_start(args, fmt); - qemu_log_vprintf(fmt, args); - va_end(args); + + logfile =3D qemu_log_lock(); + if (logfile) { + va_start(args, fmt); + xen_pv_output_msg(xendev, logfile, fmt, args); + va_end(args); + qemu_log_unlock(logfile); + } + if (msg_level =3D=3D 0) { va_start(args, fmt); - vfprintf(stderr, fmt, args); + xen_pv_output_msg(xendev, stderr, fmt, args); va_end(args); } qemu_log_flush(); --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797224; cv=none; d=zohomail.com; s=zohoarc; b=arStIBXSS895vI1p5cBoYyPwSPozCvy/K1GU3Bg0bC2/EotMV3Nimq+A7BcQ7D7J5EH/4PVwgI7QhjPgdjTIwWRRBuwShU13zpVow5Wl2CIMtMuOepfvgIcNEZYbmi9bkId+iv2rj1RJu61/zR5uf18mf7BHr/6mMwgDlKgToGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797224; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XymUoOZu9qgmLYieG14wpZ+N97PZ7+UZcXb+KUhmS5o=; b=HyzAIBB+I40/Fi/OeZ06LpmK5sjkyrXoZMevKk+rWT2P0IP7IACdZKCl+DZIE2Xh4uDzFk9ncuR8bUtzqx7JPBI7iq4+jrkfIBzdVeFmpKS2HY1BuQBbel+tDIkswHJ2Jcj1DudkiZz/UCb2DQWRVSvu2BGG5Nq1g5is0q5rQh8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797224059620.239449490279; Sun, 20 Mar 2022 10:27:04 -0700 (PDT) Received: from localhost ([::1]:55422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzKY-0003Yg-VE for importer@patchew.org; Sun, 20 Mar 2022 13:27:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5n-0008MQ-TR for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:47 -0400 Received: from [2607:f8b0:4864:20::52d] (port=33516 helo=mail-pg1-x52d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5l-0003R0-Jy for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:47 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 6so8741591pgg.0 for ; Sun, 20 Mar 2022 10:11:45 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XymUoOZu9qgmLYieG14wpZ+N97PZ7+UZcXb+KUhmS5o=; b=JjLtsCQCsYlpOF/T7oGcQRL4/U/UrPZ88oUx//99vfN4Cl5uHynTW41LgI10ufFUmj j2ENoz1Z10wfwaF6Qw3EbHxiaKEiIs9vpkL+rK2FIFUKUAt6wHA4wHadMZyw9WN54qjg wZTMzhwr393Qij6F6vuWrK65V+/hjqXdzCf5CbD6y21lHwmL0otUwLp9reDvO3maQ5az YstjWk4W1XMFv72e4uS+mYPsfnOcQwrHH+OP+8332YKlDqcoWu+a4DpCZzkCoEPseexS F/oHoZ7xfXFiqMACCkCBh466QNxaOmumXAEgEhXVF2gOdNy6KMYHHQcGoR7vv3BS8Yqp rZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XymUoOZu9qgmLYieG14wpZ+N97PZ7+UZcXb+KUhmS5o=; b=j9NP0J2PJDQTta7Tspd3SWPqIFbA9XPfrINwe/9erZANslrh9doIsEubpV/o4uGHGD nTpFFxKICTLUig2gVHNCvvMO4gYbsXCoLXy+ApjFVNqaiLOEJ88xtuR0HAjla0Ktuhww cwjVg9lEISMstNuMNtbQy0D+KeZS4RRhAmvLrMAYahlK5+cBtNFVBJSvG7rE9ocVNSgq QFoT9SePKIqqJa+KaJqODEV+xljj9NmAlWA6ARhYVkKJeJBhDJnRt730qSu5Gkw2pEhM IPzdSwGjZOSy9A9PvzukDLDMixxhWOWXsyoQl5NAvLsQzGURlGFJhQe5xeLs3LVjvjMC 79vQ== X-Gm-Message-State: AOAM5315d56l4ycWiylp7IhS9lzy6aTstJOPu6xWsGhZcxG6k7eHkHDP 4fUTHvE6iqdTBtpLFWoxt2kyEJ6G6nI4rA== X-Google-Smtp-Source: ABdhPJxwHBHmEJDr0bxs6zzU4anmXKcnHP5+XSr641fkDcmlyYzpkQVqEL9vQmIVum0xNk8pQfcelg== X-Received: by 2002:a05:6a00:2311:b0:4e1:52bf:e466 with SMTP id h17-20020a056a00231100b004e152bfe466mr20438407pfh.77.1647796304125; Sun, 20 Mar 2022 10:11:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 08/36] *: Use fprintf between qemu_log_lock/unlock Date: Sun, 20 Mar 2022 10:11:07 -0700 Message-Id: <20220320171135.2704502-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797225351100003 Content-Type: text/plain; charset="utf-8" Inside qemu_log, we perform qemu_log_lock/unlock, which need not be done if we have already performed the lock beforehand. Always check the result of qemu_log_lock -- only checking qemu_loglevel_mask races with the acquisition of the lock on the logfile. Signed-off-by: Richard Henderson --- include/exec/log.h | 2 +- accel/tcg/cpu-exec.c | 16 ++--- accel/tcg/translate-all.c | 117 +++++++++++++++++++----------------- accel/tcg/translator.c | 10 +-- cpu.c | 8 +-- hw/net/can/can_sja1000.c | 25 ++++---- net/can/can_socketcan.c | 24 ++++---- target/i386/tcg/translate.c | 14 +++-- tcg/tcg.c | 74 +++++++++++++---------- 9 files changed, 158 insertions(+), 132 deletions(-) diff --git a/include/exec/log.h b/include/exec/log.h index 3c7fa65ead..6a53199d44 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -73,7 +73,7 @@ static inline void log_page_dump(const char *operation) { FILE *logfile =3D qemu_log_lock(); if (logfile) { - qemu_log("page layout changed following %s\n", operation); + fprintf(logfile, "page layout changed following %s\n", operation); page_dump(logfile); } qemu_log_unlock(logfile); diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index c997c2e8e0..7bc489101f 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -216,16 +216,18 @@ static inline void log_cpu_exec(target_ulong pc, CPUS= tate *cpu, #if defined(DEBUG_DISAS) if (qemu_loglevel_mask(CPU_LOG_TB_CPU)) { FILE *logfile =3D qemu_log_lock(); - int flags =3D 0; + if (logfile) { + int flags =3D 0; =20 - if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) { - flags |=3D CPU_DUMP_FPU; - } + if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) { + flags |=3D CPU_DUMP_FPU; + } #if defined(TARGET_I386) - flags |=3D CPU_DUMP_CCOP; + flags |=3D CPU_DUMP_CCOP; #endif - log_cpu_state(cpu, flags); - qemu_log_unlock(logfile); + log_cpu_state(cpu, flags); + qemu_log_unlock(logfile); + } } #endif /* DEBUG_DISAS */ } diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 5971cd53ab..4af7455522 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1529,68 +1529,75 @@ TranslationBlock *tb_gen_code(CPUState *cpu, if (qemu_loglevel_mask(CPU_LOG_TB_OUT_ASM) && qemu_log_in_addr_range(tb->pc)) { FILE *logfile =3D qemu_log_lock(); - int code_size, data_size; - const tcg_target_ulong *rx_data_gen_ptr; - size_t chunk_start; - int insn =3D 0; + if (logfile) { + int code_size, data_size; + const tcg_target_ulong *rx_data_gen_ptr; + size_t chunk_start; + int insn =3D 0; =20 - if (tcg_ctx->data_gen_ptr) { - rx_data_gen_ptr =3D tcg_splitwx_to_rx(tcg_ctx->data_gen_ptr); - code_size =3D (const void *)rx_data_gen_ptr - tb->tc.ptr; - data_size =3D gen_code_size - code_size; - } else { - rx_data_gen_ptr =3D 0; - code_size =3D gen_code_size; - data_size =3D 0; - } - - /* Dump header and the first instruction */ - qemu_log("OUT: [size=3D%d]\n", gen_code_size); - qemu_log(" -- guest addr 0x" TARGET_FMT_lx " + tb prologue\n", - tcg_ctx->gen_insn_data[insn][0]); - chunk_start =3D tcg_ctx->gen_insn_end_off[insn]; - log_disas(tb->tc.ptr, chunk_start); - - /* - * Dump each instruction chunk, wrapping up empty chunks into - * the next instruction. The whole array is offset so the - * first entry is the beginning of the 2nd instruction. - */ - while (insn < tb->icount) { - size_t chunk_end =3D tcg_ctx->gen_insn_end_off[insn]; - if (chunk_end > chunk_start) { - qemu_log(" -- guest addr 0x" TARGET_FMT_lx "\n", - tcg_ctx->gen_insn_data[insn][0]); - log_disas(tb->tc.ptr + chunk_start, chunk_end - chunk_star= t); - chunk_start =3D chunk_end; + if (tcg_ctx->data_gen_ptr) { + rx_data_gen_ptr =3D tcg_splitwx_to_rx(tcg_ctx->data_gen_pt= r); + code_size =3D (const void *)rx_data_gen_ptr - tb->tc.ptr; + data_size =3D gen_code_size - code_size; + } else { + rx_data_gen_ptr =3D 0; + code_size =3D gen_code_size; + data_size =3D 0; } - insn++; - } =20 - if (chunk_start < code_size) { - qemu_log(" -- tb slow paths + alignment\n"); - log_disas(tb->tc.ptr + chunk_start, code_size - chunk_start); - } + /* Dump header and the first instruction */ + fprintf(logfile, "OUT: [size=3D%d]\n", gen_code_size); + fprintf(logfile, + " -- guest addr 0x" TARGET_FMT_lx " + tb prologue\n", + tcg_ctx->gen_insn_data[insn][0]); + chunk_start =3D tcg_ctx->gen_insn_end_off[insn]; + disas(logfile, tb->tc.ptr, chunk_start); =20 - /* Finally dump any data we may have after the block */ - if (data_size) { - int i; - qemu_log(" data: [size=3D%d]\n", data_size); - for (i =3D 0; i < data_size / sizeof(tcg_target_ulong); i++) { - if (sizeof(tcg_target_ulong) =3D=3D 8) { - qemu_log("0x%08" PRIxPTR ": .quad 0x%016" TCG_PRIlx = "\n", - (uintptr_t)&rx_data_gen_ptr[i], rx_data_gen_p= tr[i]); - } else if (sizeof(tcg_target_ulong) =3D=3D 4) { - qemu_log("0x%08" PRIxPTR ": .long 0x%08" TCG_PRIlx "= \n", - (uintptr_t)&rx_data_gen_ptr[i], rx_data_gen_p= tr[i]); - } else { - qemu_build_not_reached(); + /* + * Dump each instruction chunk, wrapping up empty chunks into + * the next instruction. The whole array is offset so the + * first entry is the beginning of the 2nd instruction. + */ + while (insn < tb->icount) { + size_t chunk_end =3D tcg_ctx->gen_insn_end_off[insn]; + if (chunk_end > chunk_start) { + fprintf(logfile, " -- guest addr 0x" TARGET_FMT_lx "\= n", + tcg_ctx->gen_insn_data[insn][0]); + disas(logfile, tb->tc.ptr + chunk_start, + chunk_end - chunk_start); + chunk_start =3D chunk_end; + } + insn++; + } + + if (chunk_start < code_size) { + fprintf(logfile, " -- tb slow paths + alignment\n"); + disas(logfile, tb->tc.ptr + chunk_start, + code_size - chunk_start); + } + + /* Finally dump any data we may have after the block */ + if (data_size) { + int i; + fprintf(logfile, " data: [size=3D%d]\n", data_size); + for (i =3D 0; i < data_size / sizeof(tcg_target_ulong); i+= +) { + if (sizeof(tcg_target_ulong) =3D=3D 8) { + fprintf(logfile, + "0x%08" PRIxPTR ": .quad 0x%016" TCG_PRI= lx "\n", + (uintptr_t)&rx_data_gen_ptr[i], rx_data_ge= n_ptr[i]); + } else if (sizeof(tcg_target_ulong) =3D=3D 4) { + fprintf(logfile, + "0x%08" PRIxPTR ": .long 0x%08" TCG_PRIl= x "\n", + (uintptr_t)&rx_data_gen_ptr[i], rx_data_ge= n_ptr[i]); + } else { + qemu_build_not_reached(); + } } } + fprintf(logfile, "\n"); + qemu_log_flush(); + qemu_log_unlock(logfile); } - qemu_log("\n"); - qemu_log_flush(); - qemu_log_unlock(logfile); } #endif =20 diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index f06c314266..90da944dab 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -140,10 +140,12 @@ void translator_loop(const TranslatorOps *ops, DisasC= ontextBase *db, if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) && qemu_log_in_addr_range(db->pc_first)) { FILE *logfile =3D qemu_log_lock(); - qemu_log("----------------\n"); - ops->disas_log(db, cpu); - qemu_log("\n"); - qemu_log_unlock(logfile); + if (logfile) { + fprintf(logfile, "----------------\n"); + ops->disas_log(db, cpu); + fprintf(logfile, "\n"); + qemu_log_unlock(logfile); + } } #endif } diff --git a/cpu.c b/cpu.c index be1f8b074c..159d0b0d1d 100644 --- a/cpu.c +++ b/cpu.c @@ -401,10 +401,10 @@ void cpu_abort(CPUState *cpu, const char *fmt, ...) cpu_dump_state(cpu, stderr, CPU_DUMP_FPU | CPU_DUMP_CCOP); if (qemu_log_separate()) { FILE *logfile =3D qemu_log_lock(); - qemu_log("qemu: fatal: "); - qemu_log_vprintf(fmt, ap2); - qemu_log("\n"); - log_cpu_state(cpu, CPU_DUMP_FPU | CPU_DUMP_CCOP); + fprintf(logfile, "qemu: fatal: "); + vfprintf(logfile, fmt, ap2); + fprintf(logfile, "\n"); + cpu_dump_state(cpu, logfile, CPU_DUMP_FPU | CPU_DUMP_CCOP); qemu_log_flush(); qemu_log_unlock(logfile); qemu_log_close(); diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index 3ba803e947..919e93664d 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -246,22 +246,23 @@ int can_sja_accept_filter(CanSJA1000State *s, =20 static void can_display_msg(const char *prefix, const qemu_can_frame *msg) { - int i; FILE *logfile =3D qemu_log_lock(); =20 - qemu_log("%s%03X [%01d] %s %s", - prefix, - msg->can_id & QEMU_CAN_EFF_MASK, - msg->can_dlc, - msg->can_id & QEMU_CAN_EFF_FLAG ? "EFF" : "SFF", - msg->can_id & QEMU_CAN_RTR_FLAG ? "RTR" : "DAT"); + if (logfile) { + fprintf(logfile, "%s%03X [%01d] %s %s", + prefix, + msg->can_id & QEMU_CAN_EFF_MASK, + msg->can_dlc, + msg->can_id & QEMU_CAN_EFF_FLAG ? "EFF" : "SFF", + msg->can_id & QEMU_CAN_RTR_FLAG ? "RTR" : "DAT"); =20 - for (i =3D 0; i < msg->can_dlc; i++) { - qemu_log(" %02X", msg->data[i]); + for (int i =3D 0; i < msg->can_dlc; i++) { + fprintf(logfile, " %02X", msg->data[i]); + } + fprintf(logfile, "\n"); + qemu_log_flush(); + qemu_log_unlock(logfile); } - qemu_log("\n"); - qemu_log_flush(); - qemu_log_unlock(logfile); } =20 static void buff2frame_pel(const uint8_t *buff, qemu_can_frame *frame) diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 4b68f60c6b..ae19d35001 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -75,20 +75,22 @@ QEMU_BUILD_BUG_ON(offsetof(qemu_can_frame, data) =20 static void can_host_socketcan_display_msg(struct qemu_can_frame *msg) { - int i; FILE *logfile =3D qemu_log_lock(); - qemu_log("[cansocketcan]: %03X [%01d] %s %s", - msg->can_id & QEMU_CAN_EFF_MASK, - msg->can_dlc, - msg->can_id & QEMU_CAN_EFF_FLAG ? "EFF" : "SFF", - msg->can_id & QEMU_CAN_RTR_FLAG ? "RTR" : "DAT"); =20 - for (i =3D 0; i < msg->can_dlc; i++) { - qemu_log(" %02X", msg->data[i]); + if (logfile) { + fprintf(logfile, "[cansocketcan]: %03X [%01d] %s %s", + msg->can_id & QEMU_CAN_EFF_MASK, + msg->can_dlc, + msg->can_id & QEMU_CAN_EFF_FLAG ? "EFF" : "SFF", + msg->can_id & QEMU_CAN_RTR_FLAG ? "RTR" : "DAT"); + + for (int i =3D 0; i < msg->can_dlc; i++) { + fprintf(logfile, " %02X", msg->data[i]); + } + fprintf(logfile, "\n"); + qemu_log_flush(); + qemu_log_unlock(logfile); } - qemu_log("\n"); - qemu_log_flush(); - qemu_log_unlock(logfile); } =20 static void can_host_socketcan_read(void *opaque) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 2a94d33742..7b75e79e2b 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2581,14 +2581,16 @@ static void gen_unknown_opcode(CPUX86State *env, Di= sasContext *s) =20 if (qemu_loglevel_mask(LOG_UNIMP)) { FILE *logfile =3D qemu_log_lock(); - target_ulong pc =3D s->pc_start, end =3D s->pc; + if (logfile) { + target_ulong pc =3D s->pc_start, end =3D s->pc; =20 - qemu_log("ILLOPC: " TARGET_FMT_lx ":", pc); - for (; pc < end; ++pc) { - qemu_log(" %02x", cpu_ldub_code(env, pc)); + fprintf(logfile, "ILLOPC: " TARGET_FMT_lx ":", pc); + for (; pc < end; ++pc) { + fprintf(logfile, " %02x", cpu_ldub_code(env, pc)); + } + fprintf(logfile, "\n"); + qemu_log_unlock(logfile); } - qemu_log("\n"); - qemu_log_unlock(logfile); } } =20 diff --git a/tcg/tcg.c b/tcg/tcg.c index 33a97eabdb..42c1620ec6 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -757,31 +757,35 @@ void tcg_prologue_init(TCGContext *s) #ifdef DEBUG_DISAS if (qemu_loglevel_mask(CPU_LOG_TB_OUT_ASM)) { FILE *logfile =3D qemu_log_lock(); - qemu_log("PROLOGUE: [size=3D%zu]\n", prologue_size); - if (s->data_gen_ptr) { - size_t code_size =3D s->data_gen_ptr - s->code_gen_ptr; - size_t data_size =3D prologue_size - code_size; - size_t i; + if (logfile) { + fprintf(logfile, "PROLOGUE: [size=3D%zu]\n", prologue_size); + if (s->data_gen_ptr) { + size_t code_size =3D s->data_gen_ptr - s->code_gen_ptr; + size_t data_size =3D prologue_size - code_size; + size_t i; =20 - log_disas(s->code_gen_ptr, code_size); + disas(logfile, s->code_gen_ptr, code_size); =20 - for (i =3D 0; i < data_size; i +=3D sizeof(tcg_target_ulong)) { - if (sizeof(tcg_target_ulong) =3D=3D 8) { - qemu_log("0x%08" PRIxPTR ": .quad 0x%016" PRIx64 "\n= ", - (uintptr_t)s->data_gen_ptr + i, - *(uint64_t *)(s->data_gen_ptr + i)); - } else { - qemu_log("0x%08" PRIxPTR ": .long 0x%08x\n", - (uintptr_t)s->data_gen_ptr + i, - *(uint32_t *)(s->data_gen_ptr + i)); + for (i =3D 0; i < data_size; i +=3D sizeof(tcg_target_ulon= g)) { + if (sizeof(tcg_target_ulong) =3D=3D 8) { + fprintf(logfile, + "0x%08" PRIxPTR ": .quad 0x%016" PRIx64 = "\n", + (uintptr_t)s->data_gen_ptr + i, + *(uint64_t *)(s->data_gen_ptr + i)); + } else { + fprintf(logfile, + "0x%08" PRIxPTR ": .long 0x%08x\n", + (uintptr_t)s->data_gen_ptr + i, + *(uint32_t *)(s->data_gen_ptr + i)); + } } + } else { + disas(logfile, s->code_gen_ptr, prologue_size); } - } else { - log_disas(s->code_gen_ptr, prologue_size); + fprintf(logfile, "\n"); + qemu_log_flush(); + qemu_log_unlock(logfile); } - qemu_log("\n"); - qemu_log_flush(); - qemu_log_unlock(logfile); } #endif =20 @@ -4201,10 +4205,12 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *t= b) if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP) && qemu_log_in_addr_range(tb->pc))) { FILE *logfile =3D qemu_log_lock(); - qemu_log("OP:\n"); - tcg_dump_ops(s, false); - qemu_log("\n"); - qemu_log_unlock(logfile); + if (logfile) { + fprintf(logfile, "OP:\n"); + tcg_dump_ops(s, false); + fprintf(logfile, "\n"); + qemu_log_unlock(logfile); + } } #endif =20 @@ -4246,10 +4252,12 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *t= b) if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP_IND) && qemu_log_in_addr_range(tb->pc))) { FILE *logfile =3D qemu_log_lock(); - qemu_log("OP before indirect lowering:\n"); - tcg_dump_ops(s, false); - qemu_log("\n"); - qemu_log_unlock(logfile); + if (logfile) { + fprintf(logfile, "OP before indirect lowering:\n"); + tcg_dump_ops(s, false); + fprintf(logfile, "\n"); + qemu_log_unlock(logfile); + } } #endif /* Replace indirect temps with direct temps. */ @@ -4267,10 +4275,12 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *t= b) if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP_OPT) && qemu_log_in_addr_range(tb->pc))) { FILE *logfile =3D qemu_log_lock(); - qemu_log("OP after optimization and liveness analysis:\n"); - tcg_dump_ops(s, true); - qemu_log("\n"); - qemu_log_unlock(logfile); + if (logfile) { + fprintf(logfile, "OP after optimization and liveness analysis:= \n"); + tcg_dump_ops(s, true); + fprintf(logfile, "\n"); + qemu_log_unlock(logfile); + } } #endif =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796986; cv=none; d=zohomail.com; s=zohoarc; b=NWKaAT0NUpZhaSs/3rHeyz4nSjGaUO7pGdPYydkR/ylJCKz/ssBydS9LJNarhSw2a5gkpLRKewadSKPWBTE8NwF4QHxfC0n1YjJXQvZ4Ig+c1WhJX3bz0xVns/ksMmu2G5Sx8WfWbmGcouQ+bmBm0ArMB+HGPMYdwUDzaZsvwu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796986; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SnloB92roRJjW2I8fqc6iuhCF5tiad3l4/Mv7JIcEjs=; b=aSbnWWsYXEyxeNGkqqxe9Ib27fIdlksU2UiaVTUNjQ7HXD181qfzVR7hg75xY9RMSJc1YGJuWzJ2tggerlBCPf98Kt682Poh7o2yFtkKsYYI67NkO1s3vE5v3O4QS8H0ObyETvS/WqIWTQLVOgJrvcKGqbiPRw1gofWqN5I4E8M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164779698599980.2760953345221; Sun, 20 Mar 2022 10:23:05 -0700 (PDT) Received: from localhost ([::1]:46650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzGh-0005zZ-Sx for importer@patchew.org; Sun, 20 Mar 2022 13:23:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0008PM-Di for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:51 -0400 Received: from [2607:f8b0:4864:20::42b] (port=35392 helo=mail-pf1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5n-0003R7-9q for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:48 -0400 Received: by mail-pf1-x42b.google.com with SMTP id a5so13704330pfv.2 for ; Sun, 20 Mar 2022 10:11:46 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SnloB92roRJjW2I8fqc6iuhCF5tiad3l4/Mv7JIcEjs=; b=aD6sl379pgxtG2JFd3jm4jd6gnwfnJsMebiguKUJ9iQKdXcEXQFi4wWbfq4IooTCbj l5PNrvZeVMuBj1jMErRWUAF8C3t9fIfvT8hno0A40rTWlS3aSgju6j9FN4Ht0hN86SzR wMWmPsuLY6v0HebKnjMmW5fosM/gF1T1uRo2mVjM/8MM6TUCM/4jyV+4HGsNpgnvBW+o svJ3/pkZEXXA56BjQRE4+MG78HWLxfoF6v5Xa7JBH8JEdxo0Zvl2/TQKA6Dh1XampEFa J7r4Vo8gClT68ufBLvGLl/G4/OXVzH2BPIRP1hr6tb62fJFOR3OSFWSdwI56D6yUOB8R rvvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SnloB92roRJjW2I8fqc6iuhCF5tiad3l4/Mv7JIcEjs=; b=SrFBalrRD9OrU/tGCYLmXD5srDdt4SbUWHfH+rvvshr6PkvQePZTKHV9WXs0/2+dAT ea4MM995+j9+WRDl0BKokrUhTQ+YV8SyE2HzFf+1pIq7sWP1NOHW0GEcLZRBVRiygLLj gIGP5YuEbxxYyz+sThcnuiEdzDgBv/UMQfFADaWMvDgds70TpCO8g42kXHu5/XSwrUui Md2IdBU2bykP6fiaCU7x6D+SiWpv2gSkCZzQ9uV6P8jTRKu2DLvzbxXNPjIXK/w+4AID luDX03/2119BRULMsOVSnQ8sWFPGiWip+5o4yB5l3PcZK9E52N9MV+o7/Ss7Z+ViQFu/ flTA== X-Gm-Message-State: AOAM533/Wy3Xf6C+PzrfzB9Jwuuh4ZB+lPalQb1hgfVymc05d3CdwgIQ 7JCZT//II8SEJZamfsmbs/Yd+YDKV/KhGw== X-Google-Smtp-Source: ABdhPJwvBAUCrxqYe6gzrwwA8xacmBb4vMfOHn3JrbiufgO13qoTQbP+6AgQHNwVffMo4Vg4LVgi6A== X-Received: by 2002:a63:4e5d:0:b0:381:f11:59f6 with SMTP id o29-20020a634e5d000000b003810f1159f6mr15333118pgl.565.1647796305154; Sun, 20 Mar 2022 10:11:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 09/36] util/log: Remove qemu_log_vprintf Date: Sun, 20 Mar 2022 10:11:08 -0700 Message-Id: <20220320171135.2704502-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42b (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796987941100001 Content-Type: text/plain; charset="utf-8" This function is no longer used. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- include/qemu/log.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 10e284291c..6e45b31253 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -72,21 +72,6 @@ void qemu_log_unlock(FILE *fd); =20 /* Logging functions: */ =20 -/* vfprintf-like logging function - */ -static inline void GCC_FMT_ATTR(1, 0) -qemu_log_vprintf(const char *fmt, va_list va) -{ - QemuLogFile *logfile; - - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - vfprintf(logfile->fd, fmt, va); - } - rcu_read_unlock(); -} - /* log only if a bit is set on the current loglevel mask: * @mask: bit to check in the mask * @fmt: printf-style format string --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797221; cv=none; d=zohomail.com; s=zohoarc; b=Ba5XHCVtTi9Yhs/3uIIX/NZTXkjaMejpSqBa9g16mm9v3TVW+A6KVEWrgsd4hg69vx+RgqHXceuSX1c+eRVBbxUvkuK087tiIxUzadHM+DdShx7pwsR91r7I4fwx2FxkBBYx8DAvM7OPXc8TaWJgwVU3zFGs8dAw6DhTCH6Xof4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797221; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OBLJhIXzKI/cdzhRUD5EzFRORqxgtBTHvf3b9Zw2Xz8=; b=gykZjnsJ3MGqE8ZFDnneM09BnCCCfgcIgUImjFoaJqg+IQhvu/l2Xapb2AJfJRL0BLiPJEvnaYgBzXSsDSbIY+gUitOPbvjU3WwpW4qLn1P6BWiB6tMLomyB6CuLqosT9ilKkJDLz664J4yLETPzP0iP7c4wXfpxjI2XJLqaXI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16477972214577.771067566908869; Sun, 20 Mar 2022 10:27:01 -0700 (PDT) Received: from localhost ([::1]:55254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzKW-0003S4-F7 for importer@patchew.org; Sun, 20 Mar 2022 13:27:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0008Pt-Jk for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:51 -0400 Received: from [2607:f8b0:4864:20::102d] (port=37611 helo=mail-pj1-x102d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5n-0003RQ-D4 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:49 -0400 Received: by mail-pj1-x102d.google.com with SMTP id mz9-20020a17090b378900b001c657559290so12183216pjb.2 for ; Sun, 20 Mar 2022 10:11:47 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OBLJhIXzKI/cdzhRUD5EzFRORqxgtBTHvf3b9Zw2Xz8=; b=gA0XEASGAR2s3DczN5S+O7hBXAp9WJpQj0ednhOmArxnoJvwMV67yUodOt5nYetRcS 2Mh8JeiCA+O+Rxllt4zS+5ita3/24T2YmvYjFerm79eCGHSmmAOaq6ZZUL4Zyhkhz+xe WeX+Af3MShNKvtVm4sOKqU6m7YLwH7S3JYPfX6Bs+kNkVxZu7J/Np+wNQHjwhyC+/fRA Bs4dUlfJmHeI3QcAWfO3u20vmr4dqzfzGipwi0LsXpZR/CenrmvhGo42yO58JxFlnq/r gnIXn+dOTODiSxkj845EXC46Bv8kr/p7OqrG0ttbMuFTgAwcETv01rYS78ORxdRlByl2 EIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OBLJhIXzKI/cdzhRUD5EzFRORqxgtBTHvf3b9Zw2Xz8=; b=3ktrFpci/jxFL5FceV238AH7LNqxbgZHUw8N3NLPS6Bo4+FK1PYXdCm4yW3iRf1Sot yc8Xkzv5CIzJxuE8zlNrwF1KIRqlk6bB8FN1UlHh5KToaWUoAfGTQdvGuI4NrnoAbOD8 vGMKexC2TcDchTOkuz9cMKdiiZH40UqtUWiLll3RCoLygspXU5bYud1cXcG1wpepG79L eLup+jfeklN3K7NkESuiVJ/L72uiDrQZl1701v16EU7XGI180nZGWyUdOXI34u9tDFba gytWMU52HCCvpMSVW4eGP+q4hN1mnXJ78x+RtdHeu2PsuXUppjv2Bzb8VpONCXA/hvX1 yH5w== X-Gm-Message-State: AOAM532weg/ciuIUajwWrEfNdWCA+5c0AP8I2ZVGiwPvxKIkzB7b7AeA C/5w6pZcmnotPXqD87Dr5W+ia5IE0vBQPA== X-Google-Smtp-Source: ABdhPJwvKJ/vGrm4aeP0blmxAqLr7nMHwuQqolGf1lR1raKAKSjPIBfzCazmDUBnhVI5iwSSUZUMQQ== X-Received: by 2002:a17:902:f544:b0:153:bb8a:9374 with SMTP id h4-20020a170902f54400b00153bb8a9374mr9316144plf.154.1647796306043; Sun, 20 Mar 2022 10:11:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 10/36] tcg: Pass the locked filepointer to tcg_dump_ops Date: Sun, 20 Mar 2022 10:11:09 -0700 Message-Id: <20220320171135.2704502-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797223629100001 Content-Type: text/plain; charset="utf-8" We have already looked up and locked the filepointer. Use fprintf instead of qemu_log directly for output in and around tcg_dump_ops. Signed-off-by: Richard Henderson --- tcg/tcg.c | 109 ++++++++++++++++++++++++++---------------------------- 1 file changed, 52 insertions(+), 57 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 42c1620ec6..1e27367af6 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1808,7 +1808,11 @@ static inline TCGReg tcg_regset_first(TCGRegSet d) } } =20 -static void tcg_dump_ops(TCGContext *s, bool have_prefs) +/* Return only the number of characters output -- no error return. */ +#define ne_fprintf(...) \ + ({ int ret_ =3D fprintf(__VA_ARGS__); ret_ >=3D 0 ? ret_ : 0; }) + +static void tcg_dump_ops(TCGContext *s, FILE *f, bool have_prefs) { char buf[128]; TCGOp *op; @@ -1824,7 +1828,7 @@ static void tcg_dump_ops(TCGContext *s, bool have_pre= fs) =20 if (c =3D=3D INDEX_op_insn_start) { nb_oargs =3D 0; - col +=3D qemu_log("\n ----"); + col +=3D ne_fprintf(f, "\n ----"); =20 for (i =3D 0; i < TARGET_INSN_START_WORDS; ++i) { target_ulong a; @@ -1833,7 +1837,7 @@ static void tcg_dump_ops(TCGContext *s, bool have_pre= fs) #else a =3D op->args[i]; #endif - col +=3D qemu_log(" " TARGET_FMT_lx, a); + col +=3D ne_fprintf(f, " " TARGET_FMT_lx, a); } } else if (c =3D=3D INDEX_op_call) { const TCGHelperInfo *info =3D tcg_call_info(op); @@ -1844,7 +1848,7 @@ static void tcg_dump_ops(TCGContext *s, bool have_pre= fs) nb_iargs =3D TCGOP_CALLI(op); nb_cargs =3D def->nb_cargs; =20 - col +=3D qemu_log(" %s ", def->name); + col +=3D ne_fprintf(f, " %s ", def->name); =20 /* * Print the function name from TCGHelperInfo, if available. @@ -1852,15 +1856,15 @@ static void tcg_dump_ops(TCGContext *s, bool have_p= refs) * but the actual function pointer comes from the plugin. */ if (func =3D=3D info->func) { - col +=3D qemu_log("%s", info->name); + col +=3D ne_fprintf(f, "%s", info->name); } else { - col +=3D qemu_log("plugin(%p)", func); + col +=3D ne_fprintf(f, "plugin(%p)", func); } =20 - col +=3D qemu_log(",$0x%x,$%d", info->flags, nb_oargs); + col +=3D ne_fprintf(f, ",$0x%x,$%d", info->flags, nb_oargs); for (i =3D 0; i < nb_oargs; i++) { - col +=3D qemu_log(",%s", tcg_get_arg_str(s, buf, sizeof(bu= f), - op->args[i])); + col +=3D ne_fprintf(f, ",%s", tcg_get_arg_str(s, buf, size= of(buf), + op->args[i])); } for (i =3D 0; i < nb_iargs; i++) { TCGArg arg =3D op->args[nb_oargs + i]; @@ -1868,34 +1872,32 @@ static void tcg_dump_ops(TCGContext *s, bool have_p= refs) if (arg !=3D TCG_CALL_DUMMY_ARG) { t =3D tcg_get_arg_str(s, buf, sizeof(buf), arg); } - col +=3D qemu_log(",%s", t); + col +=3D ne_fprintf(f, ",%s", t); } } else { - col +=3D qemu_log(" %s ", def->name); + col +=3D ne_fprintf(f, " %s ", def->name); =20 nb_oargs =3D def->nb_oargs; nb_iargs =3D def->nb_iargs; nb_cargs =3D def->nb_cargs; =20 if (def->flags & TCG_OPF_VECTOR) { - col +=3D qemu_log("v%d,e%d,", 64 << TCGOP_VECL(op), - 8 << TCGOP_VECE(op)); + col +=3D ne_fprintf(f, "v%d,e%d,", 64 << TCGOP_VECL(op), + 8 << TCGOP_VECE(op)); } =20 k =3D 0; for (i =3D 0; i < nb_oargs; i++) { - if (k !=3D 0) { - col +=3D qemu_log(","); - } - col +=3D qemu_log("%s", tcg_get_arg_str(s, buf, sizeof(buf= ), - op->args[k++])); + const char *sep =3D k ? "," : ""; + col +=3D ne_fprintf(f, "%s%s", sep, + tcg_get_arg_str(s, buf, sizeof(buf), + op->args[k++])); } for (i =3D 0; i < nb_iargs; i++) { - if (k !=3D 0) { - col +=3D qemu_log(","); - } - col +=3D qemu_log("%s", tcg_get_arg_str(s, buf, sizeof(buf= ), - op->args[k++])); + const char *sep =3D k ? "," : ""; + col +=3D ne_fprintf(f, "%s%s", sep, + tcg_get_arg_str(s, buf, sizeof(buf), + op->args[k++])); } switch (c) { case INDEX_op_brcond_i32: @@ -1910,9 +1912,9 @@ static void tcg_dump_ops(TCGContext *s, bool have_pre= fs) case INDEX_op_cmpsel_vec: if (op->args[k] < ARRAY_SIZE(cond_name) && cond_name[op->args[k]]) { - col +=3D qemu_log(",%s", cond_name[op->args[k++]]); + col +=3D ne_fprintf(f, ",%s", cond_name[op->args[k++]]= ); } else { - col +=3D qemu_log(",$0x%" TCG_PRIlx, op->args[k++]); + col +=3D ne_fprintf(f, ",$0x%" TCG_PRIlx, op->args[k++= ]); } i =3D 1; break; @@ -1927,12 +1929,12 @@ static void tcg_dump_ops(TCGContext *s, bool have_p= refs) unsigned ix =3D get_mmuidx(oi); =20 if (op & ~(MO_AMASK | MO_BSWAP | MO_SSIZE)) { - col +=3D qemu_log(",$0x%x,%u", op, ix); + col +=3D ne_fprintf(f, ",$0x%x,%u", op, ix); } else { const char *s_al, *s_op; s_al =3D alignment_name[(op & MO_AMASK) >> MO_ASHI= FT]; s_op =3D ldst_name[op & (MO_BSWAP | MO_SSIZE)]; - col +=3D qemu_log(",%s%s,%u", s_al, s_op, ix); + col +=3D ne_fprintf(f, ",%s%s,%u", s_al, s_op, ix); } i =3D 1; } @@ -1950,9 +1952,9 @@ static void tcg_dump_ops(TCGContext *s, bool have_pre= fs) name =3D bswap_flag_name[flags]; } if (name) { - col +=3D qemu_log(",%s", name); + col +=3D ne_fprintf(f, ",%s", name); } else { - col +=3D qemu_log(",$0x%" TCG_PRIlx, flags); + col +=3D ne_fprintf(f, ",$0x%" TCG_PRIlx, flags); } i =3D k =3D 1; } @@ -1967,49 +1969,42 @@ static void tcg_dump_ops(TCGContext *s, bool have_p= refs) case INDEX_op_brcond_i32: case INDEX_op_brcond_i64: case INDEX_op_brcond2_i32: - col +=3D qemu_log("%s$L%d", k ? "," : "", - arg_label(op->args[k])->id); + col +=3D ne_fprintf(f, "%s$L%d", k ? "," : "", + arg_label(op->args[k])->id); i++, k++; break; default: break; } for (; i < nb_cargs; i++, k++) { - col +=3D qemu_log("%s$0x%" TCG_PRIlx, k ? "," : "", op->ar= gs[k]); + col +=3D ne_fprintf(f, "%s$0x%" TCG_PRIlx, k ? "," : "", + op->args[k]); } } =20 if (have_prefs || op->life) { - - QemuLogFile *logfile; - - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - for (; col < 40; ++col) { - putc(' ', logfile->fd); - } + for (; col < 40; ++col) { + putc(' ', f); } - rcu_read_unlock(); } =20 if (op->life) { unsigned life =3D op->life; =20 if (life & (SYNC_ARG * 3)) { - qemu_log(" sync:"); + ne_fprintf(f, " sync:"); for (i =3D 0; i < 2; ++i) { if (life & (SYNC_ARG << i)) { - qemu_log(" %d", i); + ne_fprintf(f, " %d", i); } } } life /=3D DEAD_ARG; if (life) { - qemu_log(" dead:"); + ne_fprintf(f, " dead:"); for (i =3D 0; life; ++i, life >>=3D 1) { if (life & 1) { - qemu_log(" %d", i); + ne_fprintf(f, " %d", i); } } } @@ -2020,28 +2015,28 @@ static void tcg_dump_ops(TCGContext *s, bool have_p= refs) TCGRegSet set =3D op->output_pref[i]; =20 if (i =3D=3D 0) { - qemu_log(" pref=3D"); + ne_fprintf(f, " pref=3D"); } else { - qemu_log(","); + ne_fprintf(f, ","); } if (set =3D=3D 0) { - qemu_log("none"); + ne_fprintf(f, "none"); } else if (set =3D=3D MAKE_64BIT_MASK(0, TCG_TARGET_NB_REG= S)) { - qemu_log("all"); + ne_fprintf(f, "all"); #ifdef CONFIG_DEBUG_TCG } else if (tcg_regset_single(set)) { TCGReg reg =3D tcg_regset_first(set); - qemu_log("%s", tcg_target_reg_names[reg]); + ne_fprintf(f, "%s", tcg_target_reg_names[reg]); #endif } else if (TCG_TARGET_NB_REGS <=3D 32) { - qemu_log("%#x", (uint32_t)set); + ne_fprintf(f, "%#x", (uint32_t)set); } else { - qemu_log("%#" PRIx64, (uint64_t)set); + ne_fprintf(f, "%#" PRIx64, (uint64_t)set); } } } =20 - qemu_log("\n"); + putc('\n', f); } } =20 @@ -4207,7 +4202,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) FILE *logfile =3D qemu_log_lock(); if (logfile) { fprintf(logfile, "OP:\n"); - tcg_dump_ops(s, false); + tcg_dump_ops(s, logfile, false); fprintf(logfile, "\n"); qemu_log_unlock(logfile); } @@ -4254,7 +4249,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) FILE *logfile =3D qemu_log_lock(); if (logfile) { fprintf(logfile, "OP before indirect lowering:\n"); - tcg_dump_ops(s, false); + tcg_dump_ops(s, logfile, false); fprintf(logfile, "\n"); qemu_log_unlock(logfile); } @@ -4277,7 +4272,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) FILE *logfile =3D qemu_log_lock(); if (logfile) { fprintf(logfile, "OP after optimization and liveness analysis:= \n"); - tcg_dump_ops(s, true); + tcg_dump_ops(s, logfile, true); fprintf(logfile, "\n"); qemu_log_unlock(logfile); } --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797615; cv=none; d=zohomail.com; s=zohoarc; b=Gn9h7kVGaBFUh+jHC245SVzkh32m58n0Ebx0D90yRwF+TbLjSzI5Qc2pI4J//Pk8Pzmq1fuOm7uzdwK+uIGghvx9cu7OBXCaZH0zQ32R7i1EBVoJkbvMu+0DAMMJww6ckr/Z5p+fwsXxiMyQeXbxBOP/90DX6yyIFQaKAnulIuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797615; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V9+EaOr/1vXn37zvEYgcVW2CiCTUfDr4DYqxTsoYhfw=; b=TpNAanp/6Q8gkmfXSN8MCEWQW+Uz/vUOQ89aEEHq02JGOaDykj7kLK+DCQlCnF7002tolVCsD4AT4RjtQ6N1sA14afJUumt5zzfNSSewNvmTMNy9nDJMTYtvNT8VQ+ovVCazQK7Lcd/5IHSkqQ3QQqdCqJH7ezNK8k4DCccYmiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797615096111.95439534621107; Sun, 20 Mar 2022 10:33:35 -0700 (PDT) Received: from localhost ([::1]:44394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzQt-0006gB-IL for importer@patchew.org; Sun, 20 Mar 2022 13:33:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0008UF-E1 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:55 -0400 Received: from [2607:f8b0:4864:20::102e] (port=35577 helo=mail-pj1-x102e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0003Rc-57 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: by mail-pj1-x102e.google.com with SMTP id mj15-20020a17090b368f00b001c637aa358eso14578451pjb.0 for ; Sun, 20 Mar 2022 10:11:47 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V9+EaOr/1vXn37zvEYgcVW2CiCTUfDr4DYqxTsoYhfw=; b=E33d3vsi3l0HjbemdUavvIntflo2LmKa3UVOnrmvQ2Y7IL8QTbWRPsSdfGdii/YBT+ 4u6kNsVLn707eWkw6nPStIR8nI6trrsgN5Vgt+9trncbPkg/ytcx2/goBEB6TU0D+02w 5Hd/F9iNF5EkWFYUq0cHrSsYh0RQUHvBBOq6n8JkdsaUulM6TsbtRxE4XqefSJCXs8fa QR+GZQYN9Gnog1SkAzgILSQwQlzOYmgDYeHONycqXUgT65hHVuK5cSRP5kVo48KXAku8 lLH8PdIhri/EFalwvKv4cdf0kmZzEhGtjTIq42a8U2uKy36ZlEO+OkRuH/8sWGB8s5Kf a3vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V9+EaOr/1vXn37zvEYgcVW2CiCTUfDr4DYqxTsoYhfw=; b=lcHNwFKqzUhzHKe5ifcG4M+xEBYHDyIu3y0S/mIBPdklSbjkK9nwb6sxKMf8EQERFv q3QmfRU65dht/pKPD+PtvRuBLhyG8n8nvjlX74yt0QZa5AIGcTOtjkPx3XhzWs2YPxUU 1V/TYIGOI0caaLoAj2SmjpFJlr4W0Wfwk3GlePjKblz+4maG0cKJ8Vlu6XlrxxKi5mES 05Eg8XfLC9Ve2WG7l/TSLpmTbi4Vrd2ywAolIb+vTWNLLsmxyGMmtMHU2mckelFdONgD kYxuYIgvVx8Sab8hVZjWlnXln2T58AJ2OGC6yo6mVLfZVwGgWwcqKAh4CWGrZmgdVGFH hK4g== X-Gm-Message-State: AOAM531TRSxfBqgkB4l+3RLmufLqw89Yp3ShORRgZBNE2dW+Y/uFibKx EMtKvxP0A1Gpb97ZTi8J72KGd+NSb/JkSQ== X-Google-Smtp-Source: ABdhPJw+BI3l8iyfJT0osDrm3G4KyJUBCQfEvfb4IxPBsSsBxzwFiTfC7AfIlQ7omCttGNWcTlkKGQ== X-Received: by 2002:a17:903:2305:b0:154:4aa2:e800 with SMTP id d5-20020a170903230500b001544aa2e800mr3551074plh.167.1647796306911; Sun, 20 Mar 2022 10:11:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 11/36] exec/translator: Pass the locked filepointer to disas_log hook Date: Sun, 20 Mar 2022 10:11:10 -0700 Message-Id: <20220320171135.2704502-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797642994100001 Content-Type: text/plain; charset="utf-8" We have fetched and locked the logfile in translator_loop. Pass the filepointer down to the disas_log hook so that it need not be fetched and locked again. Signed-off-by: Richard Henderson --- include/exec/translator.h | 2 +- accel/tcg/translator.c | 2 +- target/alpha/translate.c | 7 ++++--- target/arm/translate-a64.c | 6 +++--- target/arm/translate.c | 7 ++++--- target/avr/translate.c | 7 ++++--- target/cris/translate.c | 7 ++++--- target/hexagon/translate.c | 7 ++++--- target/hppa/translate.c | 15 ++++++++------- target/i386/tcg/translate.c | 6 +++--- target/m68k/translate.c | 7 ++++--- target/microblaze/translate.c | 7 ++++--- target/mips/tcg/translate.c | 7 ++++--- target/nios2/translate.c | 7 ++++--- target/openrisc/translate.c | 7 ++++--- target/ppc/translate.c | 7 ++++--- target/riscv/translate.c | 10 ++++++---- target/rx/translate.c | 7 ++++--- target/s390x/tcg/translate.c | 11 ++++++----- target/sh4/translate.c | 7 ++++--- target/sparc/translate.c | 7 ++++--- target/tricore/translate.c | 7 ++++--- target/xtensa/translate.c | 7 ++++--- 23 files changed, 92 insertions(+), 72 deletions(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index 9bc46eda59..31d3fa76ff 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -118,7 +118,7 @@ typedef struct TranslatorOps { void (*insn_start)(DisasContextBase *db, CPUState *cpu); void (*translate_insn)(DisasContextBase *db, CPUState *cpu); void (*tb_stop)(DisasContextBase *db, CPUState *cpu); - void (*disas_log)(const DisasContextBase *db, CPUState *cpu); + void (*disas_log)(const DisasContextBase *db, CPUState *cpu, FILE *f); } TranslatorOps; =20 /** diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 90da944dab..7d1505b239 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -142,7 +142,7 @@ void translator_loop(const TranslatorOps *ops, DisasCon= textBase *db, FILE *logfile =3D qemu_log_lock(); if (logfile) { fprintf(logfile, "----------------\n"); - ops->disas_log(db, cpu); + ops->disas_log(db, cpu, logfile); fprintf(logfile, "\n"); qemu_log_unlock(logfile); } diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 66768ab47a..b1f78cff53 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -3027,10 +3027,11 @@ static void alpha_tr_tb_stop(DisasContextBase *dcba= se, CPUState *cpu) } } =20 -static void alpha_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) +static void alpha_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps alpha_tr_ops =3D { diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index d1a59fad9c..87ae8b7571 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -14962,12 +14962,12 @@ static void aarch64_tr_tb_stop(DisasContextBase *= dcbase, CPUState *cpu) } =20 static void aarch64_tr_disas_log(const DisasContextBase *dcbase, - CPUState *cpu) + CPUState *cpu, FILE *logfile) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 - qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dc->base.pc_first)); + target_disas(logfile, cpu, dc->base.pc_first, dc->base.tb->size); } =20 const TranslatorOps aarch64_translator_ops =3D { diff --git a/target/arm/translate.c b/target/arm/translate.c index bf2196b9e2..783a43b4ae 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -9891,12 +9891,13 @@ static void arm_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cpu) } } =20 -static void arm_tr_disas_log(const DisasContextBase *dcbase, CPUState *cpu) +static void arm_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 - qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dc->base.pc_first)); + target_disas(logfile, cpu, dc->base.pc_first, dc->base.tb->size); } =20 static const TranslatorOps arm_translator_ops =3D { diff --git a/target/avr/translate.c b/target/avr/translate.c index af8a3e0f9c..dc9c3d6bcc 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -3015,10 +3015,11 @@ static void avr_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cs) } } =20 -static void avr_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void avr_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cs, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps avr_tr_ops =3D { diff --git a/target/cris/translate.c b/target/cris/translate.c index 3656cd6db1..ac101344a3 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -3268,11 +3268,12 @@ static void cris_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cpu) } } =20 -static void cris_tr_disas_log(const DisasContextBase *dcbase, CPUState *cp= u) +static void cris_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { if (!DISAS_CRIS) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } } =20 diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 98f1452cad..d4fc92f7e9 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -833,10 +833,11 @@ static void hexagon_tr_tb_stop(DisasContextBase *dcba= se, CPUState *cpu) } } =20 -static void hexagon_tr_disas_log(const DisasContextBase *dcbase, CPUState = *cpu) +static void hexagon_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 =20 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 5c0b1eb274..c24d3ce3b8 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -4305,29 +4305,30 @@ static void hppa_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cs) } } =20 -static void hppa_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void hppa_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { target_ulong pc =3D dcbase->pc_first; =20 #ifdef CONFIG_USER_ONLY switch (pc) { case 0x00: - qemu_log("IN:\n0x00000000: (null)\n"); + fprintf(logfile, "IN:\n0x00000000: (null)\n"); return; case 0xb0: - qemu_log("IN:\n0x000000b0: light-weight-syscall\n"); + fprintf(logfile, "IN:\n0x000000b0: light-weight-syscall\n"); return; case 0xe0: - qemu_log("IN:\n0x000000e0: set-thread-pointer-syscall\n"); + fprintf(logfile, "IN:\n0x000000e0: set-thread-pointer-syscall\n"); return; case 0x100: - qemu_log("IN:\n0x00000100: syscall\n"); + fprintf(logfile, "IN:\n0x00000100: syscall\n"); return; } #endif =20 - qemu_log("IN: %s\n", lookup_symbol(pc)); - log_target_disas(cs, pc, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(pc)); + target_disas(logfile, cs, pc, dcbase->tb->size); } =20 static const TranslatorOps hppa_tr_ops =3D { diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 7b75e79e2b..f905a34bd7 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -8692,12 +8692,12 @@ static void i386_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cpu) } =20 static void i386_tr_disas_log(const DisasContextBase *dcbase, - CPUState *cpu) + CPUState *cpu, FILE *logfile) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 - qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dc->base.pc_first)); + target_disas(logfile, cpu, dc->base.pc_first, dc->base.tb->size); } =20 static const TranslatorOps i386_tr_ops =3D { diff --git a/target/m68k/translate.c b/target/m68k/translate.c index af43c8eab8..4026572ed8 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -6257,10 +6257,11 @@ static void m68k_tr_tb_stop(DisasContextBase *dcbas= e, CPUState *cpu) } } =20 -static void m68k_tr_disas_log(const DisasContextBase *dcbase, CPUState *cp= u) +static void m68k_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps m68k_tr_ops =3D { diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 2561b904b9..bf01384d33 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1833,10 +1833,11 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CP= UState *cs) } } =20 -static void mb_tr_disas_log(const DisasContextBase *dcb, CPUState *cs) +static void mb_tr_disas_log(const DisasContextBase *dcb, + CPUState *cs, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcb->pc_first)); - log_target_disas(cs, dcb->pc_first, dcb->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcb->pc_first)); + target_disas(logfile, cs, dcb->pc_first, dcb->tb->size); } =20 static const TranslatorOps mb_tr_ops =3D { diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index b82a7ec6ad..6de5b66650 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -16141,10 +16141,11 @@ static void mips_tr_tb_stop(DisasContextBase *dcb= ase, CPUState *cs) } } =20 -static void mips_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void mips_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cs, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps mips_tr_ops =3D { diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f89271dbed..89b97ef520 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -833,10 +833,11 @@ static void nios2_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cs) } } =20 -static void nios2_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) +static void nios2_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps nios2_tr_ops =3D { diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index ca79e609da..7b8ad43d5f 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -1687,12 +1687,13 @@ static void openrisc_tr_tb_stop(DisasContextBase *d= cbase, CPUState *cs) } } =20 -static void openrisc_tr_disas_log(const DisasContextBase *dcbase, CPUState= *cs) +static void openrisc_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { DisasContext *s =3D container_of(dcbase, DisasContext, base); =20 - qemu_log("IN: %s\n", lookup_symbol(s->base.pc_first)); - log_target_disas(cs, s->base.pc_first, s->base.tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(s->base.pc_first)); + target_disas(logfile, cs, s->base.pc_first, s->base.tb->size); } =20 static const TranslatorOps openrisc_tr_ops =3D { diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 408ae26173..e0c9f74da4 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7769,10 +7769,11 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cs) } } =20 -static void ppc_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void ppc_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cs, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps ppc_tr_ops =3D { diff --git a/target/riscv/translate.c b/target/riscv/translate.c index fac998a6b5..6495726302 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1155,18 +1155,20 @@ static void riscv_tr_tb_stop(DisasContextBase *dcba= se, CPUState *cpu) } } =20 -static void riscv_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) +static void riscv_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { #ifndef CONFIG_USER_ONLY RISCVCPU *rvcpu =3D RISCV_CPU(cpu); CPURISCVState *env =3D &rvcpu->env; #endif =20 - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); #ifndef CONFIG_USER_ONLY - qemu_log("Priv: "TARGET_FMT_ld"; Virt: "TARGET_FMT_ld"\n", env->priv, = env->virt); + fprintf(logfile, "Priv: "TARGET_FMT_ld"; Virt: "TARGET_FMT_ld"\n", + env->priv, env->virt); #endif - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps riscv_tr_ops =3D { diff --git a/target/rx/translate.c b/target/rx/translate.c index 5db8f79a82..c8a8991a63 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -2342,10 +2342,11 @@ static void rx_tr_tb_stop(DisasContextBase *dcbase,= CPUState *cs) } } =20 -static void rx_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void rx_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { - qemu_log("IN:\n"); /* , lookup_symbol(dcbase->pc_first)); */ - log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cs, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps rx_tr_ops =3D { diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 5acfc0ff9b..1e7f470c4b 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -6660,16 +6660,17 @@ static void s390x_tr_tb_stop(DisasContextBase *dcba= se, CPUState *cs) } } =20 -static void s390x_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= s) +static void s390x_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 if (unlikely(dc->ex_value)) { - /* ??? Unfortunately log_target_disas can't use host memory. */ - qemu_log("IN: EXECUTE %016" PRIx64, dc->ex_value); + /* ??? Unfortunately target_disas can't use host memory. */ + fprintf(logfile, "IN: EXECUTE %016" PRIx64, dc->ex_value); } else { - qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cs, dc->base.pc_first, dc->base.tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dc->base.pc_first)); + target_disas(logfile, cs, dc->base.pc_first, dc->base.tb->size); } } =20 diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 43bc88b7b3..f1b190e7cf 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -2352,10 +2352,11 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cs) } } =20 -static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs) +static void sh4_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cs, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cs, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cs, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps sh4_tr_ops =3D { diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 4c7c7b5347..2e28222d31 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5901,10 +5901,11 @@ static void sparc_tr_tb_stop(DisasContextBase *dcba= se, CPUState *cs) } } =20 -static void sparc_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) +static void sparc_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps sparc_tr_ops =3D { diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 417edbd3f0..d170500fa5 100644 --- a/target/tricore/translate.c +++ b/target/tricore/translate.c @@ -8861,10 +8861,11 @@ static void tricore_tr_tb_stop(DisasContextBase *dc= base, CPUState *cpu) } } =20 -static void tricore_tr_disas_log(const DisasContextBase *dcbase, CPUState = *cpu) +static void tricore_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps tricore_tr_ops =3D { diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index b1491ed625..a9e69c4153 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -1296,10 +1296,11 @@ static void xtensa_tr_tb_stop(DisasContextBase *dcb= ase, CPUState *cpu) } } =20 -static void xtensa_tr_disas_log(const DisasContextBase *dcbase, CPUState *= cpu) +static void xtensa_tr_disas_log(const DisasContextBase *dcbase, + CPUState *cpu, FILE *logfile) { - qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); - log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); + fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); + target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); } =20 static const TranslatorOps xtensa_translator_ops =3D { --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797384; cv=none; d=zohomail.com; s=zohoarc; b=L/Scc4qVqMFDmfClXGtLQwS7UVDFLkCR3eINXAStROsB/QxjDfgxXqkxtx+JjujzmDcWFyZBGdOd+OouEyi2cgp69FDdKuDaxlZ7ogX8AGFCJUgp6pWXzOpamN2fKtAJTDMcWfEzaMm3R4fONOHd1qKIKQmv7v/1iVG/l8nzzx8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797384; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fCluu6SAceuICVILsHlila9mg06bMaWRED/sDhgyEaA=; b=Y0kjTANRmm7E+nWJnSNVdTphQAVIW9fhxQbr/O7zvkqS+G2VsRIZb0FQPlpIYh61Qbg0KQs+zClPSzremUmC5ptyqbAOQLcuQNY+zz+pgD1APjIieXC0Z2drPGmWQvNtndz69abOSBJMwQLjdRSyoYnEHbNwtC2q+dhOhRHM21U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797384596771.0670796565312; Sun, 20 Mar 2022 10:29:44 -0700 (PDT) Received: from localhost ([::1]:35772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzN9-0000nC-AA for importer@patchew.org; Sun, 20 Mar 2022 13:29:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0008U2-C8 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:55 -0400 Received: from [2607:f8b0:4864:20::630] (port=33610 helo=mail-pl1-x630.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0003S5-At for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: by mail-pl1-x630.google.com with SMTP id t22so10919148plo.0 for ; Sun, 20 Mar 2022 10:11:48 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fCluu6SAceuICVILsHlila9mg06bMaWRED/sDhgyEaA=; b=yyfXStKLgRELxO6ob4by7e4wGGY+wkFkuV2GEEVIw5N/v6eSmUlxU84j0EOhzFyA3c BKWP56k7iVZgPD3aJodfB9EbXWTSGIbWvHbvce1c24xvrYwZoxU7n9nLsIlQ83eMyj4L HMCsfndQgAoMApxSy2x0ZwBmGpDP1Z0pH6N4BV4lxZKlbJptc8L375/KGw8vOBBUQm/7 LW4/1ZIP+rDzwVQzkYjJE2U04CQgAUzMc2FrG0opkVNhTk899dfZR/FOFWE9Lf+c28Z2 gY0fxCbtjPbVpdNdgN5qOxG24uVl2BPmlnIqEHkPLJDoBE0EJO3Hoy6kzrowtLZHUb9+ QQ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fCluu6SAceuICVILsHlila9mg06bMaWRED/sDhgyEaA=; b=5jCP31eVp1ZSc5JkUrIDi4SphF2zKraWALFjVDzgOilOue6HcrKw/JdliTzrR2WTZ+ sxz5FKT1DL+NN5Auuqiu1ZADQw63f23zuTe+oqEvlCzu0hUBbA7ZtZ/FpEDd0GufzbLE jurdNdgpNYf18i9aSDQrdU5TCUx1G+SCP+J5eOAMKQTQUIEu8Us52oCdXRblx2yrpIRv 7MSgX2lJPCcB6SkM+lP4SP+04Zl0aW2QVakxB9ykh82qYffD2+7ofZC3IlHvDvNBDDcl ZAJZQCSZ5eTPR12qZlkqknxY+XAF+ZzYqKvjLArju+/0/E83Y9wpcHAhKc3kh7E3OMZm /sDw== X-Gm-Message-State: AOAM5301qkcqntEOzNWHeTsvnTYe5JvyDoGIe4EPFSvjJRuTo4MbwluB omqLWZNWlOpenR3nXCMVQE9Z01+NPsSPHQ== X-Google-Smtp-Source: ABdhPJz8HeAhrISEI9Qbcd6saM+xnw62Cdea5R0CyC0F0KuRT/lcIrARihOnn4w8QcrCpZYR0qBuIw== X-Received: by 2002:a17:902:ce8a:b0:154:361b:48d1 with SMTP id f10-20020a170902ce8a00b00154361b48d1mr6401406plg.72.1647796307722; Sun, 20 Mar 2022 10:11:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 12/36] exec/log: Remove log_disas and log_target_disas Date: Sun, 20 Mar 2022 10:11:11 -0700 Message-Id: <20220320171135.2704502-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::630 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797386865100001 Content-Type: text/plain; charset="utf-8" These functions are no longer used. Signed-off-by: Richard Henderson --- include/exec/log.h | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/include/exec/log.h b/include/exec/log.h index 6a53199d44..d131a3140d 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -43,30 +43,6 @@ static inline void log_cpu_state_mask(int mask, CPUState= *cpu, int flags) } =20 #ifdef NEED_CPU_H -/* disas() and target_disas() to qemu_logfile: */ -static inline void log_target_disas(CPUState *cpu, target_ulong start, - target_ulong len) -{ - QemuLogFile *logfile; - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - target_disas(logfile->fd, cpu, start, len); - } - rcu_read_unlock(); -} - -static inline void log_disas(const void *code, unsigned long size) -{ - QemuLogFile *logfile; - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - disas(logfile->fd, code, size); - } - rcu_read_unlock(); -} - #if defined(CONFIG_USER_ONLY) /* page_dump() output to the log file: */ static inline void log_page_dump(const char *operation) --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796562; cv=none; d=zohomail.com; s=zohoarc; b=KI68GcqG/8HXjz/MTAedgG7NWp6ano59WBTyOt9SBY8UXXUOuxVkls65ZTgNcZOANq1J+il+/qcNkbk5V4qR767PVvu0bQ+uGJEmuOJPKTdYGC3GqeyGXrPmz29dcnQNmxyknILCzJ4IrTZOjcojgjn257NGbmbHw1webvYv4tQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796562; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=m2wELzqwzIys+kYsrbnyazUddQSXjpVVFOxKU26m/b5pUJwvYActhvY08M8uBSe04/XJ6mMb2FTuc1Qu2kKYMBuhE6Lrc+oRlNSMvIRfTIarIQuUyLaM3JiRoIiizGHrkaGMAmgkBvJ7OHR1xs8f+SO9zywMXWJUAMWaXa9VPdg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796562091786.8005081028449; Sun, 20 Mar 2022 10:16:02 -0700 (PDT) Received: from localhost ([::1]:57884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVz9t-0002xh-1n for importer@patchew.org; Sun, 20 Mar 2022 13:16:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5s-0008Qv-Nx for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: from [2607:f8b0:4864:20::632] (port=38695 helo=mail-pl1-x632.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0003SE-AV for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:52 -0400 Received: by mail-pl1-x632.google.com with SMTP id n18so10885288plg.5 for ; Sun, 20 Mar 2022 10:11:49 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=AqI/QYvs1iFbSj6GhvU6rcWDKefh9916SfT7qzjRMFTUTGqmxe+lcZX+B6W1+8Mtn5 5IdZhMVGEcLTLG2SHg2SxIubRoJ+cE3/LJ1qG69zl9hy2YBVTpru9fEU9+L2Xqt2kOfk Ut0NiYTvjgZHILqj9QmB1vqwdg8g9X1/KnjQNEFNmABz9JhYJoiCsJQFHRFw5nWWNw64 smcvfzZ9uT1k1WFEtyJLBXAMcJCj0nPL8OMjk5VITNRtVGCQC0y0gOYnoJcG192lhRQm VnDGfg0QhaaVlRUrDLVjRdX5L1KzrQbLVD8hnuBaFy6F+aXcon2x2zEKfOGLu1l5+0Ix HEJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=nbOopZ5GUk773eUvoQJvBejEhw1Ymrqhj9frvV3A9BJ9ZRVoIyP0z8iddlz2oYX67C xchxDxnuLQBksk26uD04RNWwtPDH/ino00U5P/RWiC2D7KYyChX++IrjFlqKpsVwAjDo lMy0qjY0DfDVwkdz7V00arY7vSthKRE5itHqq+NFeq5itjphVzGikDanEuDJzMI0xo7T GxfCdzJYDb04wK2kY2VeXleGYiBcZxAvrH0UEWILL3aJwvQUNYi8GDci0Ud6T4Vlp1MB SxlD55+ZV2y4Cgt2BMcDJaFVAvaBieQQfgTxQP+Cy9nFiXpMaeSyw14XnnE+gXV2YT1m EBBg== X-Gm-Message-State: AOAM531FHpka/AAAXqushbyWLmGqVa6/bJMztJ2/bf50+3duoD0LuDoK jiq1vOezIKQlJG3LzFh4f5KUEp1K7+UASA== X-Google-Smtp-Source: ABdhPJy2VkBCGMRstskuQMdy8qhP+OttTjsj7mQ2QsWZPwpdf+l8IaLlRFdXV4CGlXsTJtlVUpVduQ== X-Received: by 2002:a17:902:ab10:b0:153:b520:dbbe with SMTP id ik16-20020a170902ab1000b00153b520dbbemr9314935plb.55.1647796308606; Sun, 20 Mar 2022 10:11:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 13/36] accel/tcg: Use cpu_dump_state between qemu_log_lock/unlock Date: Sun, 20 Mar 2022 10:11:12 -0700 Message-Id: <20220320171135.2704502-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::632 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796563080100001 Content-Type: text/plain; charset="utf-8" Inside log_cpu_state, we perform qemu_log_lock/unlock, which need not be done if we have already performed the lock beforehand. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7bc489101f..8b7d6ae9b9 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -225,7 +225,7 @@ static inline void log_cpu_exec(target_ulong pc, CPUSta= te *cpu, #if defined(TARGET_I386) flags |=3D CPU_DUMP_CCOP; #endif - log_cpu_state(cpu, flags); + cpu_dump_state(cpu, logfile, flags); qemu_log_unlock(logfile); } } --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797220; cv=none; d=zohomail.com; s=zohoarc; b=Ip0rhrm2c5pvD15cmf+3DmKrpQPVKKJkbqwQ2z+2CnE6f2NxMHp2zpjydrek8H4Ah/MAO5Z6njA01iN+DgUIuWFw62lWdIv1ih45xaOlfzaK+p5t3RW5tlwZBmrbXrhGwcixd5NBO8NkwZVKsYDghcwDtu9l/qij/d5Zg+xvS0o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797220; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gN673K8AiC7tUSgFbelgmQvdK3DgFVdFgWV8e2JASA4=; b=MWf7zifIx97/QMEsIpb56S3RiGN3QbpLyh0/e64yueuEuiLW8cIt9zp4GIaE3CnGYBryTK0UNWFmyddyZ+h0jSKKzgMQHJY220KDsBR7dqq4ohF2Dq6b/rLnC3ctJXHqQ2+1abVA5wiylAZVHh8GU/Rz1odHkpIpFPGHvEOcrsg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797220862572.4898878165322; Sun, 20 Mar 2022 10:27:00 -0700 (PDT) Received: from localhost ([::1]:55356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzKV-0003WE-S6 for importer@patchew.org; Sun, 20 Mar 2022 13:26:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0008U8-Dp for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:55 -0400 Received: from [2607:f8b0:4864:20::62d] (port=42803 helo=mail-pl1-x62d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0003SI-Ay for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: by mail-pl1-x62d.google.com with SMTP id p17so10876541plo.9 for ; Sun, 20 Mar 2022 10:11:50 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gN673K8AiC7tUSgFbelgmQvdK3DgFVdFgWV8e2JASA4=; b=vyd/vnm5J3FNcVJHa610l2KBke3GWQFNJd18+GQ3c66b9V5FOW7qkRjP+YTOHmx6F8 NRPRhxrQDGPw6l7NOXRPvFK7tj5YOW+H7AH4Nkxucm0wSL+VvahhzLw90mdeToT2Lwkn ZnjacEb3PjPW/xvQZA+WdEtsGl+QguL8NUvb9gvwqmaUhDhqMGO+sY1ZL3YHdZlreC9d i4fXuOdFZk5N23cJO8Zm4Mhd490d0ey/QY9t7MW5MbS6CezvsDSed5NHKOnKxYexkt+5 0TUeVufhPm/zz4VCI+8RFtKjvnOBoLTqGNBiIYjoRCVQWCchCX7j3weZp0rZYBZe1hbA bpVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gN673K8AiC7tUSgFbelgmQvdK3DgFVdFgWV8e2JASA4=; b=smTwemENyfsSpoEhoHmOVyrp2wi/8C/Mlrm3TBoTYTQ2KJI77kaNaxRFGMJaXE9cda Nb8EXBsQ362OI4U/pSYBfRxIFbHif/zW+/4/xTLGWBCxVZg3kMUfAbCD2I1Gla7OMFVS d5tLGrA2IL2unhpAfw/y7EzH5SU2VEW/F9ZV0319vwerMDRWhQFi9CUlQPF5es9wR2lb aRSyrfq9Arwouee+pXk99gbtFocMccGto/lj9pT2+yDrc6iEDhV/uQsDnrE4rWfn1DiW 3e6N+bskEANDcUAwQMLMd4O/DkYiq8t047S00ha3kBnNmvB9VRbDRmziP1OLgfps3anK Q/Dg== X-Gm-Message-State: AOAM5326rjLh3XpkyzbVgitJyY4AvfwJf3hl6K3q5nMKh8AExVk/pzqh WkIHOxVazB3yKm/dZ3GZvzoz2Hw9EVgFAw== X-Google-Smtp-Source: ABdhPJwloAWDmSYgQ2YqRGBNEwV16KyAfzOCIt0sZEcq9zbK8+SINGBIHlMrpq4tcywTPxwWL7fluA== X-Received: by 2002:a17:902:a38a:b0:153:c6e:4dea with SMTP id x10-20020a170902a38a00b001530c6e4deamr9162477pla.110.1647796309426; Sun, 20 Mar 2022 10:11:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 14/36] target/nios2: Remove log_cpu_state from reset Date: Sun, 20 Mar 2022 10:11:13 -0700 Message-Id: <20220320171135.2704502-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797221298100001 Content-Type: text/plain; charset="utf-8" This is redundant with the logging done in cpu_common_reset. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/cpu.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 6975ae4bdb..b0877cb39e 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -46,11 +46,6 @@ static void nios2_cpu_reset(DeviceState *dev) Nios2CPUClass *ncc =3D NIOS2_CPU_GET_CLASS(cpu); CPUNios2State *env =3D &cpu->env; =20 - if (qemu_loglevel_mask(CPU_LOG_RESET)) { - qemu_log("CPU Reset (CPU %d)\n", cs->cpu_index); - log_cpu_state(cs, 0); - } - ncc->parent_reset(dev); =20 memset(env->regs, 0, sizeof(uint32_t) * NUM_CORE_REGS); --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796986; cv=none; d=zohomail.com; s=zohoarc; b=iYEzhgvJQWqmEs7KoWLqTe74nke3GuoYIn5u+6Q17hojonAfZ+q7lxFaTWHnMkTiyl8ECmSGnM6mng9YEgveba5NJzgdu7IOh5YBSPaUaXbDbAjUQQcIY0u1WBj/JVaHO2RO3+NoxbqtzAtaiUQG7TxF+eWwoP/c/Wu/xUb0Etw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796986; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nPJER5VpJQWDzK3DbfrzuAnOWSXda5Fj/5jRAuARZxU=; b=aNG/xTfnW2Fex2Ip4604WWExEYbeIKsgFKAJABvgcCB5+T24qu464/yDNeEeWWjzR9/BmW6ex00u6+CO52PQRZwkGEs9oByBx+cNPg6xTansZhBCffv7GoZidjMj9N7B5fL2r3noHMxx9bVcQNhf0HGABDgVAH53Nr4NUIbtl+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647796986661341.88460035722676; Sun, 20 Mar 2022 10:23:06 -0700 (PDT) Received: from localhost ([::1]:46800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzGl-00064w-54 for importer@patchew.org; Sun, 20 Mar 2022 13:23:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0008UD-E7 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:55 -0400 Received: from [2607:f8b0:4864:20::1034] (port=33973 helo=mail-pj1-x1034.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5s-0003SR-2v for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: by mail-pj1-x1034.google.com with SMTP id o68-20020a17090a0a4a00b001c686a48263so6075212pjo.1 for ; Sun, 20 Mar 2022 10:11:51 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nPJER5VpJQWDzK3DbfrzuAnOWSXda5Fj/5jRAuARZxU=; b=mI+cOOnt9YT5V5agfVxk9gCjYvnKZCLR2ij/AGdqfuc8751CE0moLz3d7ErkQKbolu sybH+W/s67DAyhWYHSm5YechTSHkh6MhP7MueJJv/GiFjqZ650NVf7Pny3PPa6b0h+an 82wouplwImGIhZ7er4VNem3YbnU00TKuEh/qUSXGgrJJisEpK8jmJhO0tEjjzjYoIkX1 Om/GcFgNVkzvAsk6QsXg0Y/BFNoAO/7RkVkqYNLiFHHj/U0KQwv17YHI/PQe2KgJw1kq 0HdzEP+SIeGFn8oRmTRymE5BkMvemKGW8jLYRxoKaGjSKm+mL468l8YDf9RkA6nSugvk 2gLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nPJER5VpJQWDzK3DbfrzuAnOWSXda5Fj/5jRAuARZxU=; b=QeXSZmCiWRQbyM6xJEVH+8DoTbRSq6Eey1RX5BIyvlK6XYFVMrk1HuznBBYyMiG71y Y5nZJSpHRpR9XL+0aMrdBsIciIy3eZtVno7iSdAt/3iLvgG5/KE3xArlmGUaFOl/moqP qE8RbROctsrmdsTVO4SL4+oZuDT8gxyGeTRtaCadGWLX0GsLUV1GjVHhCi7jZL0p604j z8swQvYGg1nmrToz7VSdbjNd4OXgYV/asEcXaIHYqygnwWemdElopFQM3CrqZN649s4/ 6hbkMakzAv4LSHx7EutiEOFA8gvrhCUawDs+3gDnpd6FbOPvyNYtJHqPlA5KC4qIH/J5 2dJA== X-Gm-Message-State: AOAM533G3hmofMlvepG+8eFMia6plZDxyyOcVjVyKAKRID43xsVqa8u6 BDTxWBjErqnsOGb1SHDF6SPPAMWZNHpDeg== X-Google-Smtp-Source: ABdhPJwiko/gInfmrtImZ4gSFm70OCFPd8aNMndnUcyzvlf/uYKZMOqWmo2jY1tj9n1k4NiSs48Jyg== X-Received: by 2002:a17:902:9a46:b0:14e:ea0f:28cf with SMTP id x6-20020a1709029a4600b0014eea0f28cfmr9138390plv.43.1647796310392; Sun, 20 Mar 2022 10:11:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 15/36] util/log: Use qemu_log_lock/unlock in qemu_log Date: Sun, 20 Mar 2022 10:11:14 -0700 Message-Id: <20220320171135.2704502-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1034 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797011600100001 Content-Type: text/plain; charset="utf-8" Avoid using QemuLogFile and RCU directly. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- util/log.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/util/log.c b/util/log.c index b1651d8122..3ec6e90575 100644 --- a/util/log.c +++ b/util/log.c @@ -62,23 +62,22 @@ void qemu_log_unlock(FILE *fd) /* Return the number of characters emitted. */ int qemu_log(const char *fmt, ...) { + FILE *f =3D qemu_log_lock(); int ret =3D 0; - QemuLogFile *logfile; =20 - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { + if (f) { va_list ap; + va_start(ap, fmt); - ret =3D vfprintf(logfile->fd, fmt, ap); + ret =3D vfprintf(f, fmt, ap); va_end(ap); + qemu_log_unlock(f); =20 /* Don't pass back error results. */ if (ret < 0) { ret =3D 0; } } - rcu_read_unlock(); return ret; } =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647796765; cv=none; d=zohomail.com; s=zohoarc; b=cDjPq6/s70zWrYHMv3AJKseNaeWjb948Jf/keMXb1CCVW+fnXzmPOubyK0wDQYtMS8GgtT2mDNJH+0JGGpWHS+qFHWavSGdVEPNc7/3228e5FUZpG5TdhX1r4TDDECZupoeC5zRpd27q40nEkK7y2jywWw0G3esD0AH+6Al1dnE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647796765; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zBy/sQij0prDNPCZW6KqDJ1PqyHxGR1GI9KNvJm6bVE=; b=G3xaa1oM3sZjrPameAgJ4ygIngxJtnjZj0ovyYmBbvID0WP85ntYOiDGWnlmDPmUl5pyBB8VpXwzXIGcaUxgwxSkYXTHefSZrVYMVbX0AtJ9JN4X39tcJdoPvQlO6FNOpZC5y3BRGgQQ6n4I/QDdbt4E2Ni5GojH+FIwBLPSYL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164779676524751.17770257756922; Sun, 20 Mar 2022 10:19:25 -0700 (PDT) Received: from localhost ([::1]:38250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzD9-0000KG-9l for importer@patchew.org; Sun, 20 Mar 2022 13:19:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0008US-FI for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:57 -0400 Received: from [2607:f8b0:4864:20::529] (port=33513 helo=mail-pg1-x529.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5s-0003Sg-H5 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:54 -0400 Received: by mail-pg1-x529.google.com with SMTP id 6so8741718pgg.0 for ; Sun, 20 Mar 2022 10:11:52 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zBy/sQij0prDNPCZW6KqDJ1PqyHxGR1GI9KNvJm6bVE=; b=D2ElIB7Bosv8Yx3dNUnf2GOvHXX3BI07A6j3MD3Hyk7jCFXvoO1l2oMbpzKQ/hEtGf uSz39pffNmCr6IRMzHjQ7GuBNIgTiUuIYpWpLcO1GN9tyC9nE3S5s8xz8316ltRb9dN6 vfeyaveGPS5vT0o/vI5d/Ep1tJkuJsvvFJy6sFAUtPOojIIzr6knoLQVTCE6lSTzqipt FJZl7mMGwNfVlKbBYKCr5SpMkhH96WwAB+uNyOe2dvaZIr/5KvnPCqeI24FkSDmYu+C9 eWm9EBBSonZWIINQeb7TNOVc8N6B+Wvdn/w3JsdoIXRIF2e2evZ3BlpxePjhlc51rMUh ez7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zBy/sQij0prDNPCZW6KqDJ1PqyHxGR1GI9KNvJm6bVE=; b=EKYQz+WmzS3IMf3celEmZRFMo9sa0T2vJDe5IpwUsSCMeT0rx50D1Cpd3iPhBrpZqS uiDkfjexCDHpwiamdrJXCADO7HP43cO5zM3lwqOfLdhSQybeGuHMXJVWHrTRLE1Z9Wjm 3+9YpsqVIEVNnmQ1dV8lMlqxrttmSTihJvWkw8gksRA5ny5br5ilT3ytiJlg/3uZgJCg VQzkCfr+IiY/PpDwWhTp5UPDlKGGe7SlF5gbVFMUSqPuYAlGFPuUY1JYvqTW1BCcjDhh Dl5bc5DD53Kmt8RFBDqaTMyC5+0T+GdEzZhgbxWH+S1zo1M99paF5Tz5xv1t2ghIo6DM L2jA== X-Gm-Message-State: AOAM532vHRba8p2O1h2ZlqdTo3zH53Nt/cjldRw4sHeNxNNhHDD7OcWJ 1kOPcEdz7YSDjzuraxcfEyZm7DdBW/Wgiw== X-Google-Smtp-Source: ABdhPJyX5j9Xix4I+WqDlGq5trXeCUzfTVF1Me9FvMwopSPTQtztnk6StUi5pYTZnkDytve6Igbtbg== X-Received: by 2002:a05:6a00:ad2:b0:4f1:2734:a3d9 with SMTP id c18-20020a056a000ad200b004f12734a3d9mr20343057pfl.61.1647796311278; Sun, 20 Mar 2022 10:11:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 16/36] util/log: Remove qemu_log_flush Date: Sun, 20 Mar 2022 10:11:15 -0700 Message-Id: <20220320171135.2704502-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::529 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647796766560100002 Content-Type: text/plain; charset="utf-8" All uses flush output immediately before or after qemu_log_unlock. Instead of a separate call, move the flush into qemu_log_unlock. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/log.h | 2 -- accel/tcg/translate-all.c | 1 - cpu.c | 1 - hw/net/can/can_sja1000.c | 1 - hw/xen/xen_pvdev.c | 1 - net/can/can_socketcan.c | 1 - tcg/tcg.c | 1 - util/log.c | 14 +------------- 8 files changed, 1 insertion(+), 21 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 6e45b31253..10578ba21c 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -121,8 +121,6 @@ int qemu_str_to_log_mask(const char *str); */ void qemu_print_log_usage(FILE *f); =20 -/* fflush() the log file */ -void qemu_log_flush(void); /* Close the log file */ void qemu_log_close(void); =20 diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 4af7455522..837f50f5b9 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1595,7 +1595,6 @@ TranslationBlock *tb_gen_code(CPUState *cpu, } } fprintf(logfile, "\n"); - qemu_log_flush(); qemu_log_unlock(logfile); } } diff --git a/cpu.c b/cpu.c index 159d0b0d1d..054f21b307 100644 --- a/cpu.c +++ b/cpu.c @@ -405,7 +405,6 @@ void cpu_abort(CPUState *cpu, const char *fmt, ...) vfprintf(logfile, fmt, ap2); fprintf(logfile, "\n"); cpu_dump_state(cpu, logfile, CPU_DUMP_FPU | CPU_DUMP_CCOP); - qemu_log_flush(); qemu_log_unlock(logfile); qemu_log_close(); } diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index 919e93664d..3d144508a2 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -260,7 +260,6 @@ static void can_display_msg(const char *prefix, const q= emu_can_frame *msg) fprintf(logfile, " %02X", msg->data[i]); } fprintf(logfile, "\n"); - qemu_log_flush(); qemu_log_unlock(logfile); } } diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index 355bbda60d..9095080b0d 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -230,7 +230,6 @@ void xen_pv_printf(struct XenLegacyDevice *xendev, int = msg_level, xen_pv_output_msg(xendev, stderr, fmt, args); va_end(args); } - qemu_log_flush(); } =20 void xen_pv_evtchn_event(void *opaque) diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index ae19d35001..47743e5fd9 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -88,7 +88,6 @@ static void can_host_socketcan_display_msg(struct qemu_ca= n_frame *msg) fprintf(logfile, " %02X", msg->data[i]); } fprintf(logfile, "\n"); - qemu_log_flush(); qemu_log_unlock(logfile); } } diff --git a/tcg/tcg.c b/tcg/tcg.c index 1e27367af6..e5d45eca9f 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -783,7 +783,6 @@ void tcg_prologue_init(TCGContext *s) disas(logfile, s->code_gen_ptr, prologue_size); } fprintf(logfile, "\n"); - qemu_log_flush(); qemu_log_unlock(logfile); } } diff --git a/util/log.c b/util/log.c index 3ec6e90575..73597c40c0 100644 --- a/util/log.c +++ b/util/log.c @@ -54,6 +54,7 @@ FILE *qemu_log_lock(void) void qemu_log_unlock(FILE *fd) { if (fd) { + fflush(fd); qemu_funlockfile(fd); rcu_read_unlock(); } @@ -277,19 +278,6 @@ out: g_strfreev(ranges); } =20 -/* fflush() the log file */ -void qemu_log_flush(void) -{ - QemuLogFile *logfile; - - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - fflush(logfile->fd); - } - rcu_read_unlock(); -} - /* Close the log file */ void qemu_log_close(void) { --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797823; cv=none; d=zohomail.com; s=zohoarc; b=A8msp+0OfQhdmbaQz63AjbkdMLq3SlSSRf9su0K8+1LOCbbLPF7HkXcgX8+Dob7LrPRiTSOJNAxgTjwN42OfH79yyKHoUcnPzhm5SvEwlV2/kx6Waw7EzdQVWMnyGIx/6KoNaGHthWdpm7LTi98+MYX6JzJlAXrCqQMspB2Z7qY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797823; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WUo/UXugquCgKpGx2VP7SOTX0x7aIWwccomkB6QAm9Q=; b=bP9GrIl/jM1bq5QKjeO8HskNrOWtGFXa5akM1Oej7V5u5bzR8eBLn4qS+RMj05AEJIQva6jPx1+TjWwWAmLgviArJNmMl5OaRedg3nz6bvRNPoySmACZkf7cpYNRipPn/rw+PCOHfhQDbDQwBuL0c1Rayh3oht+dMFBKXZuFvJI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797823846583.5647056591905; Sun, 20 Mar 2022 10:37:03 -0700 (PDT) Received: from localhost ([::1]:52944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzUE-0003ye-K0 for importer@patchew.org; Sun, 20 Mar 2022 13:37:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5x-0008W2-CO for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: from [2607:f8b0:4864:20::52b] (port=45993 helo=mail-pg1-x52b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0003St-3j for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:56 -0400 Received: by mail-pg1-x52b.google.com with SMTP id o13so8738104pgc.12 for ; Sun, 20 Mar 2022 10:11:52 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WUo/UXugquCgKpGx2VP7SOTX0x7aIWwccomkB6QAm9Q=; b=lR7xrozeJMnsVVDvJU+Wu9VdwiRnknyIPcGLcXTET0IivLgLR8vHlWLYb6Y+PXr9sl 3bObCfPTT/XUKq5qcBwE7QpjaXjlN7IUxQQeXtIBm9m3vIomdaAXdgw706pEfmpj/jmQ 1Gc620efJ7g6GT/GoicY40S1zaWPKPRLLSTVhct6e/3DEymC1DnM86UMHwceDjJCdi8L xzVyWqbq7nvPnNdoalTgmXr+Zh2ddG6Q8RN/75WDQG9Gx21laCrf0FZKlpF0i8h71nn/ ijjih8ypzFTDftXRO7H7bg4kglVU6UMnPc+rmtp9YIFEE+EFA+c52FNZUEBoQONMmXZf z6Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WUo/UXugquCgKpGx2VP7SOTX0x7aIWwccomkB6QAm9Q=; b=RnmxuyQdVjSLCab/3OvckPWWU0orz47702uZIzuWLrkDiqajCtwhJEo8eIW6eoPWRG D6KDAvHUDVICn3hRSAhiAm48sqx1bOuBNuEs41uZUuV5tx5p8jD+8N25nofqC5Br7MYq UrBb+Mo5/AP9oG7mUn6/sK4dzJADH254cCeDbxxGpUSToUULEjAtdpJz61GCSadtN7JY BPZvkdp5psUuEwwpRw1FfR7t7L4QxkBnH+vCBBnQrssVOrCDM+tluqPK+ijd5AJlC24D 5GdHzBpgG7cdANUEZgYNE1YbyzD2nKjuDIuHsRwfaEYMFvWmrGGLqPLks7y+Q5CFGHLL ao9g== X-Gm-Message-State: AOAM531A0BxUk5dbPtg0ex9fUSQ8HFyQGgdJKOY779LZ2B13l7vnlAuV zbCzKBzrKW/cW66Rbe1JrzfvFsi6cZNQ4Q== X-Google-Smtp-Source: ABdhPJxwXzrQALyQGXz0JNwzwcQaGf1TiGSKRegPZgd+J1ylAh7rstCCNrE5wfIeaabDdSmEdODM7Q== X-Received: by 2002:a65:6942:0:b0:378:9365:5963 with SMTP id w2-20020a656942000000b0037893655963mr15235347pgq.142.1647796312098; Sun, 20 Mar 2022 10:11:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 17/36] util/log: Drop call to setvbuf Date: Sun, 20 Mar 2022 10:11:16 -0700 Message-Id: <20220320171135.2704502-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52b (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797824709100003 Content-Type: text/plain; charset="utf-8" Now that the log buffer is flushed after every qemu_log_unlock, which includes every call to qemu_log, we do not need to force line buffering (or unbuffering for windows). Block buffer the entire loggable unit. Signed-off-by: Richard Henderson --- util/log.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/util/log.c b/util/log.c index 73597c40c0..be20ae6c1c 100644 --- a/util/log.c +++ b/util/log.c @@ -145,12 +145,6 @@ void qemu_set_log(int log_flags, Error **errp) logfile->fd =3D stderr; } =20 -#if defined(_WIN32) - /* Win32 doesn't support line-buffering, so use unbuffered output.= */ - setvbuf(logfile->fd, NULL, _IONBF, 0); -#else - setvbuf(logfile->fd, NULL, _IOLBF, 0); -#endif log_append =3D 1; qatomic_rcu_set(&qemu_logfile, logfile); } --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797216; cv=none; d=zohomail.com; s=zohoarc; b=G4bjraq2gi6ECgSrRi5XwWBGO51Fc9cUU2KQqysxB1uVxT5gSL74xcIunMYE21JlrUlVVnavBi766G9Z6IjCKd23k0Hmzd5KujWfOO4tuBWLrBdnywinodNcO3RrQrSEm8lV3kNnrKhjGBOIpOr2qUmGMa2MEL51zOywW943C3w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797216; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=91XMdGfqxA7BvJwgW6QHFNJ0sL3SZqCOihIKSdvbIRg=; b=Syxcp70KQpK5gqJrffaVSMSrmNvC5k5phvz4w5OWPPBFoTYxSgxD9FYapQyBDFoN6iAt/yN50brrIfD099P7MZwaxCfnoDnHuB2Q5PYTL/DWl0tYHhuEQlgVeqx5IEuZj8owKKQPMbzQG7qP/aU3FGCQILo5b0wTFFNsKXsRObk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797216120111.57207324610124; Sun, 20 Mar 2022 10:26:56 -0700 (PDT) Received: from localhost ([::1]:54884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzKR-0003Bb-1R for importer@patchew.org; Sun, 20 Mar 2022 13:26:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5x-0008W3-Cj for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: from [2607:f8b0:4864:20::631] (port=42807 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0003TA-4U for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:56 -0400 Received: by mail-pl1-x631.google.com with SMTP id p17so10876604plo.9 for ; Sun, 20 Mar 2022 10:11:53 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=91XMdGfqxA7BvJwgW6QHFNJ0sL3SZqCOihIKSdvbIRg=; b=GFmnPbA+Foj745z27nMHc1bIyzNzpu+5gAxboDYLKfD2eWqq8t2ejszgpHHjphuQIp 85UFuXLN1vISyAGUn3HbTI8efQqqLgNekyzN2PnjSZeF6TEtJK0xqRTo7WdhxKL3uuxO Fue7osoDJ7qsSqNRYWKtKadAVJcqg9l+Rg2TYg2Fj78cEuj6EGZDTXjuyN2Iog+TwOQM ozVwlttJZdqsCscF4SS85pACcdsOtz5Bzf9R84i1rLftxWgj24R4OXMnkdyUq6iD6/tJ POxaGytPu0fw/heJAgVG92+GiPl9QkY3VwsZ61VfB/B8lZgXugeLe43e0kTeqGZ3Dika 5vnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=91XMdGfqxA7BvJwgW6QHFNJ0sL3SZqCOihIKSdvbIRg=; b=kJWsixn5Eiemvc1IDjpS9uBaHHtPTmlnfUZAFqXhz7L0th41IbNPD/evstr0vZJSlb egvxHJjR0EU7anyy6CuuNWj6o3PhWVvElYhlkcrM+27k8fjakMA274+KxeO8XieErupt 2i/X1NTfl6kCi9TWyj16FxcihNHjvi/XznBxNYY4UT4hW5znVg5gSD0XoIfEIZ2ihrvA B220Rt/kB90DMCYnUoJlT2fqXKF++xIEWEPmEY0xDFxR33JQr7eM5LMyk6QODrMV+1SJ 6t23Xy64mByqlaS6wEEMZ14XiU14EJCWdwmMV34Knb8HhWNrVMFM+5X8rTQGZ4w6caSE FcOg== X-Gm-Message-State: AOAM531uYZNzzk9IQpb7/T3ZDggSyYylWl8fJaaw+pM+TdV76EI5/1Uo 0FXMaYfPGyzhwq9RW/uEx9cooNiSEaLkoQ== X-Google-Smtp-Source: ABdhPJzBLjPtrYu+VNI+QvmgW1JHEOiDHhBy5MOZ/tmAkIK+1/8aOll0MZub32KydghYGQJWZ8/bsA== X-Received: by 2002:a17:90a:1b65:b0:1c6:5bc5:99b4 with SMTP id q92-20020a17090a1b6500b001c65bc599b4mr25072202pjq.177.1647796313112; Sun, 20 Mar 2022 10:11:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 18/36] bsd-user: Expand log_page_dump inline Date: Sun, 20 Mar 2022 10:11:17 -0700 Message-Id: <20220320171135.2704502-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797218288100001 Content-Type: text/plain; charset="utf-8" We have extra stuff to log at the same time. Hoist the qemu_log_lock/unlock to the caller and use fprintf. Signed-off-by: Richard Henderson --- bsd-user/main.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 0c8aa1ae90..d25d1c6015 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -503,20 +503,25 @@ int main(int argc, char **argv) g_free(target_environ); =20 if (qemu_loglevel_mask(CPU_LOG_PAGE)) { - qemu_log("guest_base %p\n", (void *)guest_base); - log_page_dump("binary load"); + FILE *f =3D qemu_log_lock(); =20 - qemu_log("start_brk 0x" TARGET_ABI_FMT_lx "\n", info->start_brk); - qemu_log("end_code 0x" TARGET_ABI_FMT_lx "\n", info->end_code); - qemu_log("start_code 0x" TARGET_ABI_FMT_lx "\n", + fprintf(f, "guest_base %p\n", (void *)guest_base); + fprintf(f, "page layout changed following binary load\n"); + page_dump(f); + + fprintf(f, "start_brk 0x" TARGET_ABI_FMT_lx "\n", info->start_br= k); + fprintf(f, "end_code 0x" TARGET_ABI_FMT_lx "\n", info->end_code= ); + fprintf(f, "start_code 0x" TARGET_ABI_FMT_lx "\n", info->start_code); - qemu_log("start_data 0x" TARGET_ABI_FMT_lx "\n", + fprintf(f, "start_data 0x" TARGET_ABI_FMT_lx "\n", info->start_data); - qemu_log("end_data 0x" TARGET_ABI_FMT_lx "\n", info->end_data); - qemu_log("start_stack 0x" TARGET_ABI_FMT_lx "\n", + fprintf(f, "end_data 0x" TARGET_ABI_FMT_lx "\n", info->end_data= ); + fprintf(f, "start_stack 0x" TARGET_ABI_FMT_lx "\n", info->start_stack); - qemu_log("brk 0x" TARGET_ABI_FMT_lx "\n", info->brk); - qemu_log("entry 0x" TARGET_ABI_FMT_lx "\n", info->entry); + fprintf(f, "brk 0x" TARGET_ABI_FMT_lx "\n", info->brk); + fprintf(f, "entry 0x" TARGET_ABI_FMT_lx "\n", info->entry); + + qemu_log_unlock(f); } =20 /* build Task State */ --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797370; cv=none; d=zohomail.com; s=zohoarc; b=SaYuVZJU2PUJYOy2g5RQEf+Lrtkj5MsWPlDKKsi4EbEXc7ftzQZd7sdCU7bfxak7LxuGGg2OV6uqukCuFNQhT0P4D9ndlw4fu2JXSgTKkqc1SjHs39w2vIZcMsdbESdHiT9EYa4wySGlY2K5zOIcbTqmo6Pk4YSLS+Db6GtwEYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797370; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RfLYamEZLpY31Sx1p2zuEUJmtGPv8qgDD0cZ+FUaGoI=; b=gFrthk8zFCgIfVrIQ1bTerLmBRZgjHijdjnqD8++JV9FRGVIFwQxTQ79bE3dG8PVFxoabTPKvNb7zGjlWPbe44/76Dk6iX1L5K1puzt/lKVgN3Az98bEubMCehAlA1zesTH2mVcMQIMJuGiGjnBK/FCzqrGJDULRSrturk1kR8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16477973707046.553870796381148; Sun, 20 Mar 2022 10:29:30 -0700 (PDT) Received: from localhost ([::1]:35092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzMw-0000Lv-Ve for importer@patchew.org; Sun, 20 Mar 2022 13:29:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5y-0008WA-HO for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: from [2607:f8b0:4864:20::529] (port=40489 helo=mail-pg1-x529.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5v-0003TK-5Z for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:57 -0400 Received: by mail-pg1-x529.google.com with SMTP id w21so5045109pgm.7 for ; Sun, 20 Mar 2022 10:11:54 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RfLYamEZLpY31Sx1p2zuEUJmtGPv8qgDD0cZ+FUaGoI=; b=xDeMtjPn7K80IMXve9W5HqQK/tXiUFtg7XrmPqUe2Of09BlEFsrj93ZYlN86r0K8uj CtDZkSouY5f4zr7HgkjOknQ27Tri1bGmSagmk7O2n96FCxKrDxRZpAaroFXBn6GtSjVN wRqa49ySzXiKZ+/gl9Sd6yhUYCQA/X4ptXm5vOyx1LLMM50LHwrdE/ChVbw2KOlDUEjQ mnxXh6lhOVoOStA35k/h8r3og3zovgqRPnTixTwYYBTwLl1MON+p5H4iOcPs8C9LBfuP ViI6l9sVpY8aALE/na7ABC3LTymY44QuJnWXOpHqCYDGjDH89poamk5vk1ttBgbwk1Xp clag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RfLYamEZLpY31Sx1p2zuEUJmtGPv8qgDD0cZ+FUaGoI=; b=vACrAVU02+DT5j/w6GQJn4+9TJwvALyksawFO18D/kwfeBua6r9Zg6/J11Zwgb+MXS ZwkWqdw7CJrNM/BNiKbmM9FXU56yf7Io0bVKf2u8geVBh6P8iHtma+exbnXOgH3Q43LO KX2Flh9ZFLd2e1RrgHHS9HtRTEaeXwJBuJc0LYw4XdrspHmxal5eJ0iQkhWS2rPo5Sy2 9GrSz/9Cd6lwhC9c0i/Khy1TIAvBSrlDA74gfxfXLOOWDDsbfKbx6z3c4qAFu4TrIsbW 5wzbnedvRg1KWb642LMTU9YItzB86Q+3opypZjbLgIfh1IsOQ5ywx+41b1XdYdE8OrG6 KFZA== X-Gm-Message-State: AOAM533lCjHWgXl6iNAR/VnPz1OpLHnCxNFuFRMXTSjG5n4cKnaZPUg+ QG/6fVjcv0SufUN+wjEa6FtCasaR5hJ4DQ== X-Google-Smtp-Source: ABdhPJz3ynuSS4H9Q2BuzbhwC3NQNjwBcodqMn16IJKyJfZ/0eolBQmsOTl0OdI5F9CCP/7pTb3sQA== X-Received: by 2002:a63:7d5d:0:b0:34c:17:6174 with SMTP id m29-20020a637d5d000000b0034c00176174mr15682508pgn.133.1647796313965; Sun, 20 Mar 2022 10:11:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 19/36] linux-user: Expand log_page_dump inline Date: Sun, 20 Mar 2022 10:11:18 -0700 Message-Id: <20220320171135.2704502-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::529 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797372860100001 Content-Type: text/plain; charset="utf-8" We have extra stuff to log at the same time. Hoist the qemu_log_lock/unlock to the caller and use fprintf. Signed-off-by: Richard Henderson --- include/exec/log.h | 15 --------------- linux-user/main.c | 43 +++++++++++++++++++++++++++++-------------- linux-user/mmap.c | 7 ++++++- 3 files changed, 35 insertions(+), 30 deletions(-) diff --git a/include/exec/log.h b/include/exec/log.h index d131a3140d..ad0a40cfeb 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -42,19 +42,4 @@ static inline void log_cpu_state_mask(int mask, CPUState= *cpu, int flags) } } =20 -#ifdef NEED_CPU_H -#if defined(CONFIG_USER_ONLY) -/* page_dump() output to the log file: */ -static inline void log_page_dump(const char *operation) -{ - FILE *logfile =3D qemu_log_lock(); - if (logfile) { - fprintf(logfile, "page layout changed following %s\n", operation); - page_dump(logfile); - } - qemu_log_unlock(logfile); -} -#endif -#endif - #endif diff --git a/linux-user/main.c b/linux-user/main.c index 6aed4929ab..2bdee78019 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -857,21 +857,36 @@ int main(int argc, char **argv, char **envp) g_free(target_environ); =20 if (qemu_loglevel_mask(CPU_LOG_PAGE)) { - qemu_log("guest_base %p\n", (void *)guest_base); - log_page_dump("binary load"); + FILE *f =3D qemu_log_lock(); + if (f) { + fprintf(f, "guest_base %p\n", (void *)guest_base); + fprintf(f, "page layout changed following binary load\n"); + page_dump(f); =20 - qemu_log("start_brk 0x" TARGET_ABI_FMT_lx "\n", info->start_brk); - qemu_log("end_code 0x" TARGET_ABI_FMT_lx "\n", info->end_code); - qemu_log("start_code 0x" TARGET_ABI_FMT_lx "\n", info->start_code= ); - qemu_log("start_data 0x" TARGET_ABI_FMT_lx "\n", info->start_data= ); - qemu_log("end_data 0x" TARGET_ABI_FMT_lx "\n", info->end_data); - qemu_log("start_stack 0x" TARGET_ABI_FMT_lx "\n", info->start_stac= k); - qemu_log("brk 0x" TARGET_ABI_FMT_lx "\n", info->brk); - qemu_log("entry 0x" TARGET_ABI_FMT_lx "\n", info->entry); - qemu_log("argv_start 0x" TARGET_ABI_FMT_lx "\n", info->arg_start); - qemu_log("env_start 0x" TARGET_ABI_FMT_lx "\n", - info->arg_end + (abi_ulong)sizeof(abi_ulong)); - qemu_log("auxv_start 0x" TARGET_ABI_FMT_lx "\n", info->saved_auxv= ); + fprintf(f, "start_brk 0x" TARGET_ABI_FMT_lx "\n", + info->start_brk); + fprintf(f, "end_code 0x" TARGET_ABI_FMT_lx "\n", + info->end_code); + fprintf(f, "start_code 0x" TARGET_ABI_FMT_lx "\n", + info->start_code); + fprintf(f, "start_data 0x" TARGET_ABI_FMT_lx "\n", + info->start_data); + fprintf(f, "end_data 0x" TARGET_ABI_FMT_lx "\n", + info->end_data); + fprintf(f, "start_stack 0x" TARGET_ABI_FMT_lx "\n", + info->start_stack); + fprintf(f, "brk 0x" TARGET_ABI_FMT_lx "\n", + info->brk); + fprintf(f, "entry 0x" TARGET_ABI_FMT_lx "\n", + info->entry); + fprintf(f, "argv_start 0x" TARGET_ABI_FMT_lx "\n", + info->arg_start); + fprintf(f, "env_start 0x" TARGET_ABI_FMT_lx "\n", + info->arg_end + (abi_ulong)sizeof(abi_ulong)); + fprintf(f, "auxv_start 0x" TARGET_ABI_FMT_lx "\n", + info->saved_auxv); + qemu_log_unlock(f); + } } =20 target_set_brk(info->brk); diff --git a/linux-user/mmap.c b/linux-user/mmap.c index c125031b90..1aa343a491 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -630,7 +630,12 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, i= nt target_prot, the_end: trace_target_mmap_complete(start); if (qemu_loglevel_mask(CPU_LOG_PAGE)) { - log_page_dump(__func__); + FILE *f =3D qemu_log_lock(); + if (f) { + fprintf(f, "page layout changed following mmap\n"); + page_dump(f); + qemu_log_unlock(f); + } } tb_invalidate_phys_range(start, start + len); mmap_unlock(); --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797375; cv=none; d=zohomail.com; s=zohoarc; b=kOgoNYxlTAGzs8P/qQ0e0VP+/Oy8pCA2YeWOQAVp5c8PRv9Yl46yCTjh4QuEyPcYCreucKFbAIV6Ix3UEBGnknGwgYMakTEJSyMFstw/oM0FTSoU+AGxoZgUDvz4TATxBuGLGoL0PUHptceh17qSrb3NmhHtAymbibYA9+J5pCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797375; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L87S22rf4qAItkg1Hc+56nj9SIVR24PlTDFBvPEqmNI=; b=LaXapd8sCnT+VRwym3U6Qaq4+9l4MtRpJQuCjS3tp0mkwn5190J1OGa5tfcpnPWBCSRP2YtQx2Z0SQSBjgoZkZRupRoXghNYkGuFF+JnqppfIFQeA/LuhLLsYvA+C8NaV/FB4AiK1R4Q7UnnglF3X1Hw+SXSD0fNTiJKOry5pZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164779737566711.103403052011231; Sun, 20 Mar 2022 10:29:35 -0700 (PDT) Received: from localhost ([::1]:35638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzN2-0000hS-92 for importer@patchew.org; Sun, 20 Mar 2022 13:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5y-0008W9-GP for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: from [2607:f8b0:4864:20::430] (port=39599 helo=mail-pf1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5w-0003Tb-0w for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:57 -0400 Received: by mail-pf1-x430.google.com with SMTP id u22so2278328pfg.6 for ; Sun, 20 Mar 2022 10:11:55 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L87S22rf4qAItkg1Hc+56nj9SIVR24PlTDFBvPEqmNI=; b=cAnFwt6LggNoa2zywcdOwNBqDtulXjZKfZTs9BJ8XqTB+P6kNy0OUdF6H2nXDIFWG+ gN3+HdTslg7rpcRUypYlleh9fTu4i0uETstdD4uB7wFUKjY3iY3C9G8KFROS0zzUD6Ey wV9yuLpk3yYi6WcOHKzMJfrJe6Tox5dEAbbDypNXeet3ZyS37SRpYi22uCPEYdolE7Tr tkXe8kxbnQZ3ZBAY2n4G+am1fcJ1Aalhrw4StCARoKSdf4Oth4ElfsyXOvDghMxPxju3 niw/EEZCpWBku6yDWNXFmGKezHF8ILFxpayZDFV732ewHKLZO+rDSl9+myXFNAA5Am18 8Ymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L87S22rf4qAItkg1Hc+56nj9SIVR24PlTDFBvPEqmNI=; b=ug9S6HLHLcJdikyWdG2DyKx4pCb0PHGT5a3WrDIQk1Ex3CzuVkz61/a57KxRXLRulW +1kdkAFQJEkbFqtn7wZ6JYOXW2BbPrd8BaP2IJyx+glbniCuHcCcQ/wrKyLnnpaNmSsx d4fOO/U4v4LZT/PIgXVXG+SW9sw2WWhg9zp833N9hQ7qT0GN8MbMP5hOydJp6onCqYOh 1Dh88r1yI3gNS4/gWswYGp/dEN6Q+GSPij+YJELBx0L6Zo+qlE76JWGOUPS5VMl1C8fv d8/Cxk2JsbJ04gVF0CcUqo3nvRlfeQ9QGE0yE2ixeSuyQQy67w65cYzswsV5r1B5LvEx uUwQ== X-Gm-Message-State: AOAM530zV0sXfZbQKeZzYHoWB7bmh14Cl4XVJYVChswSrJKhkl91nQds grXBa0QytjxCXv3LXA2RuE5MdXCWBZTJ7w== X-Google-Smtp-Source: ABdhPJwO/rDvwYJlOYFDRNuPlDmkeKEbFd0y/aG//KjUwwUqNDbl2/dbZ+/3rJXTGId6toNewVFtng== X-Received: by 2002:a05:6a00:198c:b0:4f7:7e0f:bfc2 with SMTP id d12-20020a056a00198c00b004f77e0fbfc2mr19519700pfl.44.1647796314800; Sun, 20 Mar 2022 10:11:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 20/36] tests/unit: Do not reference QemuLogFile directly Date: Sun, 20 Mar 2022 10:11:19 -0700 Message-Id: <20220320171135.2704502-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::430 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797402464100004 Content-Type: text/plain; charset="utf-8" Use qemu_log_lock/unlock instead of the raw rcu_read. Signed-off-by: Richard Henderson --- tests/unit/test-logging.c | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/tests/unit/test-logging.c b/tests/unit/test-logging.c index 93c6d666e8..fc22bf40b4 100644 --- a/tests/unit/test-logging.c +++ b/tests/unit/test-logging.c @@ -110,12 +110,10 @@ static void test_parse_path(gconstpointer data) =20 static void test_logfile_write(gconstpointer data) { - QemuLogFile *logfile; - QemuLogFile *logfile2; + FILE *logfile0, *logfile1; gchar const *dir =3D data; - g_autofree gchar *file_path =3D NULL; + g_autofree gchar *file_path0 =3D NULL; g_autofree gchar *file_path1 =3D NULL; - FILE *orig_fd; =20 /* * Before starting test, set log flags, to ensure the file gets @@ -124,29 +122,28 @@ static void test_logfile_write(gconstpointer data) * this is needed. */ qemu_set_log(CPU_LOG_TB_OUT_ASM, &error_abort); - file_path =3D g_build_filename(dir, "qemu_test_log_write0.log", NULL); + file_path0 =3D g_build_filename(dir, "qemu_test_log_write0.log", NULL); file_path1 =3D g_build_filename(dir, "qemu_test_log_write1.log", NULL); =20 /* * Test that even if an open file handle is changed, * our handle remains valid due to RCU. */ - qemu_set_log_filename(file_path, &error_abort); - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - orig_fd =3D logfile->fd; - g_assert(logfile && logfile->fd); - fprintf(logfile->fd, "%s 1st write to file\n", __func__); - fflush(logfile->fd); + qemu_set_log_filename(file_path0, &error_abort); + logfile0 =3D qemu_log_lock(); + g_assert(logfile0); + fprintf(logfile0, "%s 1st write to file\n", __func__); + fflush(logfile0); =20 /* Change the logfile and ensure that the handle is still valid. */ qemu_set_log_filename(file_path1, &error_abort); - logfile2 =3D qatomic_rcu_read(&qemu_logfile); - g_assert(logfile->fd =3D=3D orig_fd); - g_assert(logfile2->fd !=3D logfile->fd); - fprintf(logfile->fd, "%s 2nd write to file\n", __func__); - fflush(logfile->fd); - rcu_read_unlock(); + logfile1 =3D qemu_log_lock(); + g_assert(logfile1); + g_assert(logfile0 !=3D logfile1); + fprintf(logfile0, "%s 2nd write to file\n", __func__); + fflush(logfile0); + qemu_log_unlock(logfile0); + qemu_log_unlock(logfile1); } =20 static void test_logfile_lock(gconstpointer data) --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798338; cv=none; d=zohomail.com; s=zohoarc; b=A61Y6nqFaytSPuOxAsATm4OTGyrxxurQQCK9i1taEiZjtCn5hNesRuqlZxBqUtWi6cc+yH4CqWYFLs1+ohYlHssX+M/Xv153Me48cdN/Q3PGXwMKz2YZK1yET1sml3943PCmUNl1Zku3FFT2O3AYDvNBv9ylnCLAER1d9Xgr2W8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798338; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HY6g2dz/onqNKInKBF8VriYCnDheK410T+QzLO/qQ+A=; b=DjE8r2MGBmQZZdFbTRHRbPR6IHmyGWo/Y7ZrviBOTW5s2HbMs/yq7dWQB7KeuUaktsRKEuP+rgkiYC5Rj3Wg1C8nt22axvbyfm1fKHhVrbGAyyf7KqLx4VX+CTyuBbOvS5x0KYbuIoyl4Ne6UA2IhmJU/jk47PmYen/xVI/BV1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798338940500.0747996199982; Sun, 20 Mar 2022 10:45:38 -0700 (PDT) Received: from localhost ([::1]:33190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzcZ-0001UH-7z for importer@patchew.org; Sun, 20 Mar 2022 13:45:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5y-0008WB-If for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: from [2607:f8b0:4864:20::42b] (port=34765 helo=mail-pf1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5x-0003Tr-4y for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:58 -0400 Received: by mail-pf1-x42b.google.com with SMTP id l8so13701577pfu.1 for ; Sun, 20 Mar 2022 10:11:56 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HY6g2dz/onqNKInKBF8VriYCnDheK410T+QzLO/qQ+A=; b=N0LxrPCJhpe3LVEG3sfYUU6Sfg32w+gmviRiRSf53bK6jVUrGASP0styDXbxwEPg0W kGPL+QDxlIRrGpJPTBjMwbQucKRcq0ShycgbJ9ccBLUk3ak2Mbj+HvzXrW2K930bwzi7 P0TgofFw0aLD0YovpLLdsYjIZmOCkIhXOMdedqXvUW6lLMJ+JJkIpcAI2Pbu0PtW+44h W/7rImjZlcuINyz3NPF+XYByzLcuAOPvtXEGLilYXC020NWFjIT/ZRI0WoAICGMNP21l uvKRJyRU64SKDS7rC1YB0yMvEU/kf9ExgnnO2IhUGjwPe9TDKjuYoHQpgIVO28AuAnxX /fEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HY6g2dz/onqNKInKBF8VriYCnDheK410T+QzLO/qQ+A=; b=KecC2fq/i9/4+c+4MFf+CfBJzHWx7+9HVXdNMTNBQnKmHHcUs1WQJKecos/GLUqn/q HGirR3B0a5L6U4C2XpWuiA1ShmtCozrTn55EqlkZZL1q6NjZW9OZKnyErKmvMB+dNpdD ooUHNqZ4NVyGCsuqVsjFrD7rBZ61BnY1uPTJQcwQPYK2wwabmfTe0tyOHGn14QlO5JlR 4qRy6wHfBIQwqBhnD2+V3wnZa3UOd5P+89DVczK5m+zioZ3DovZoAvjsROIGmVXF2TOZ r5KQqcKXjlRwUoeP6FdTaTf6OPvefI7iaGahI/x7CT7qzu60FbWy5NmznmN5yZWTerqO 1qqw== X-Gm-Message-State: AOAM532cKL+MPGnF5Xqj4lJZpvfU/QIKmHY8eNGxKP1KnPWEnr7wOr5D ontqu85ZwtAyAufDq/oKakziEq4L3w9gsQ== X-Google-Smtp-Source: ABdhPJxv01Vc2tJxlHVT/Bt0gFP4+fPCClDwIyhGLZkuhD20ZGNyn8qbF8We/FVwfnOLvnixWFDudA== X-Received: by 2002:a63:6645:0:b0:382:65eb:1215 with SMTP id a66-20020a636645000000b0038265eb1215mr3918995pgc.337.1647796315599; Sun, 20 Mar 2022 10:11:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 21/36] include/exec/log: Do not reference QemuLogFile directly Date: Sun, 20 Mar 2022 10:11:20 -0700 Message-Id: <20220320171135.2704502-22-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42b (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798364343100001 Content-Type: text/plain; charset="utf-8" Use qemu_log_lock/unlock instead of the raw rcu_read. Signed-off-by: Richard Henderson --- include/exec/log.h | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/include/exec/log.h b/include/exec/log.h index ad0a40cfeb..10d0e809d4 100644 --- a/include/exec/log.h +++ b/include/exec/log.h @@ -15,15 +15,10 @@ */ static inline void log_cpu_state(CPUState *cpu, int flags) { - QemuLogFile *logfile; - - if (qemu_log_enabled()) { - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile) { - cpu_dump_state(cpu, logfile->fd, flags); - } - rcu_read_unlock(); + FILE *f =3D qemu_log_lock(); + if (f) { + cpu_dump_state(cpu, f, flags); + qemu_log_unlock(f); } } =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798738; cv=none; d=zohomail.com; s=zohoarc; b=CDUib+yYuHgVjmXLfHq/DmrHVH6+LeT+Rw3EspPMGHAYj+VTLnlhZeUOYAe7vURuG7skH9Fw0HtAYTZGxSXw/sC6neG2iKcqIPBZ43GrCpjMPCc7V2KGUmebz2Dds1AuDm/0PJwFq3g0LAx/xLpSSC3cLztdbMaJ/WG6F9uNJZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798738; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=THGd3lL3k1TYcfn7NVeHgS8AdzPbg7kpOdsIIF9l+TA=; b=QctIgW+ByIjdKXC5+jvhyOqHKw1ss9XC3vzgzTeOBYdxh+/eMRsfn3PF0wAXfYGWevf5PvrY+Hr5AU6ked88e/MViHaIfuEzQRGAbPW8UjSadgDId9PmVITHsYQjk0Jcoc/1m9+cWtbjx4jWeWwzl26LvpvIfSbqwkZHQ1UOaXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798738078651.11437441764; Sun, 20 Mar 2022 10:52:18 -0700 (PDT) Received: from localhost ([::1]:41820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVziy-0007ZP-MX for importer@patchew.org; Sun, 20 Mar 2022 13:52:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz61-00005l-4f for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:01 -0400 Received: from [2607:f8b0:4864:20::62a] (port=34479 helo=mail-pl1-x62a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5y-0003Tx-7j for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:59 -0400 Received: by mail-pl1-x62a.google.com with SMTP id i11so10197054plr.1 for ; Sun, 20 Mar 2022 10:11:57 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=THGd3lL3k1TYcfn7NVeHgS8AdzPbg7kpOdsIIF9l+TA=; b=gu/J9y3Xbp7DURODPmJkaHY2rvKu0Uhz0c7qBDWYkGBMcIV+VKGB76Wnn6zQiiGg5t FpRsFjn+fBK0E89gBlZtAHZ08Zd0pcJimjNK/JSDfdAHJ0LwLN8fLnkE/x2K0Kn4PjNT tHc8mPIJnT1WrgX09uYstwFvkedUZ+wOqeRZXXh5U3VI61b2U6J0oUoQkU3YeXyIveOv XvyXrHMdRrRqrC4FZE3LjejOSHy7Oq2ikqFl/FIepcjE4YgnWOR9ro5B8/AeP92KZAyO 8/cGiJhLslAiePPepdQs48OeE6/TFSLKF0yM+8fgVrdGO8MQvPNefmRtx9d0Gc0+LKfR tXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=THGd3lL3k1TYcfn7NVeHgS8AdzPbg7kpOdsIIF9l+TA=; b=O78rpJ6QJq+txyDBguxvpQ2yR2jc8/YGkkmfol5X3hl/TRGbstDDwr4gUc9tayXh1e Xbs8DPFbc0146xpRPQifYrQmDzHHzw3MkI/dByGeBvsQORjeg0XhJLCoQYMoNl/i+pe0 ey1kaaHUbl3St7B+ts1LSMJ0ARbSHG8MnrjkJfCyA8vEp2caxqRSAEY6EdccUpSiZcp5 dQ8sKE0QyXkTJ5kHVBVWmUlvaoUKNaZsZiMuFYnApdQrYrjUXMYGWVzHGTLHoKowJeWB a2TmulcQ5wdDOPtFr6j5cGiz9/R92pn/zGZUu3fv/O2ulYrfeRahpkQt4GHQspnFGWX2 50/A== X-Gm-Message-State: AOAM533K0kOqsLL83PVN8FKy2zrON12uHcqXyWl3w/ajoB4yamL15aFH 1OWcn3ZHUAaIHUqPp23/jgAUN4tyWmftvA== X-Google-Smtp-Source: ABdhPJzWjut+X+0wnKhMJi9sUNiict5TMSY0NTgq4VYtBHt9PFrGqMJ1sYMN13LoX7RlgwdHRyYyKg== X-Received: by 2002:a17:902:7781:b0:153:35ef:e3d1 with SMTP id o1-20020a170902778100b0015335efe3d1mr9309074pll.116.1647796316622; Sun, 20 Mar 2022 10:11:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 22/36] include/qemu/log: Move entire implementation out-of-line Date: Sun, 20 Mar 2022 10:11:21 -0700 Message-Id: <20220320171135.2704502-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62a (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798738629100003 Content-Type: text/plain; charset="utf-8" Move QemuLogFile, qemu_logfile, and all inline functions into qemu/log.c. No need to expose these implementation details in the api. Signed-off-by: Richard Henderson --- include/qemu/log.h | 38 ++++---------------------------------- tests/unit/test-logging.c | 1 + util/log.c | 30 +++++++++++++++++++++++++++++- 3 files changed, 34 insertions(+), 35 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 10578ba21c..c63416c9e0 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -3,46 +3,16 @@ =20 /* A small part of this API is split into its own header */ #include "qemu/log-for-trace.h" -#include "qemu/rcu.h" - -typedef struct QemuLogFile { - struct rcu_head rcu; - FILE *fd; -} QemuLogFile; - -/* Private global variable, don't use */ -extern QemuLogFile *qemu_logfile; - =20 /*=20 * The new API: - * */ =20 -/* Log settings checking macros: */ +/* Returns true if qemu_log() will really write somewhere. */ +bool qemu_log_enabled(void); =20 -/* Returns true if qemu_log() will really write somewhere - */ -static inline bool qemu_log_enabled(void) -{ - return qemu_logfile !=3D NULL; -} - -/* Returns true if qemu_log() will write somewhere else than stderr - */ -static inline bool qemu_log_separate(void) -{ - QemuLogFile *logfile; - bool res =3D false; - - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); - if (logfile && logfile->fd !=3D stderr) { - res =3D true; - } - rcu_read_unlock(); - return res; -} +/* Returns true if qemu_log() will write somewhere other than stderr. */ +bool qemu_log_separate(void); =20 #define CPU_LOG_TB_OUT_ASM (1 << 0) #define CPU_LOG_TB_IN_ASM (1 << 1) diff --git a/tests/unit/test-logging.c b/tests/unit/test-logging.c index fc22bf40b4..7016710a74 100644 --- a/tests/unit/test-logging.c +++ b/tests/unit/test-logging.c @@ -30,6 +30,7 @@ #include "qemu-common.h" #include "qapi/error.h" #include "qemu/log.h" +#include "qemu/rcu.h" =20 static void test_parse_range(void) { diff --git a/util/log.c b/util/log.c index be20ae6c1c..7e8b152742 100644 --- a/util/log.c +++ b/util/log.c @@ -26,14 +26,42 @@ #include "trace/control.h" #include "qemu/thread.h" #include "qemu/lockable.h" +#include "qemu/rcu.h" + + +typedef struct QemuLogFile { + struct rcu_head rcu; + FILE *fd; +} QemuLogFile; =20 static char *logfilename; static QemuMutex qemu_logfile_mutex; -QemuLogFile *qemu_logfile; +static QemuLogFile *qemu_logfile; int qemu_loglevel; static int log_append =3D 0; static GArray *debug_regions; =20 +/* Returns true if qemu_log() will really write somewhere. */ +bool qemu_log_enabled(void) +{ + return qemu_logfile !=3D NULL; +} + +/* Returns true if qemu_log() will write somewhere other than stderr. */ +bool qemu_log_separate(void) +{ + QemuLogFile *logfile; + bool res =3D false; + + rcu_read_lock(); + logfile =3D qatomic_rcu_read(&qemu_logfile); + if (logfile && logfile->fd !=3D stderr) { + res =3D true; + } + rcu_read_unlock(); + return res; +} + /* Lock/unlock output. */ =20 FILE *qemu_log_lock(void) --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797597; cv=none; d=zohomail.com; s=zohoarc; b=Aeksu3yJw/GYdldMKo06SnmiTLCYXa+G57hM/cvMpbvdzMTo5qwruIXjO0s2HDx8OQyYWJJ41E4UwRdbFviXyBvBtJAMbbwZInbI1H8xO0QSwP6jRe6/qvkE9bbovEdo+hkM4r/XMbedrQV+pIC82gswXX+bW4N1895LvDxSxbY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797597; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Hu9aRYzYIgbIdzSTEVhW4soYbAG6jLfuaaPgAkD8sGQ=; b=eNJU8yxLOapMmfkHcnMkK39urwMaTEwAakwNAHZ9Ny6ZB5U26ZBhQYa7FL5NBSzuI5GV9nSl7Je/osDPw7/VedG/E2JtS+ICWw7f6obCB40Vl+RsgHnkfew0AHMiqIEDKvp55MlhyDn8SslI4ZeECMptcga9SCmsMnHC2XhYL98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797597068429.2703904677437; Sun, 20 Mar 2022 10:33:17 -0700 (PDT) Received: from localhost ([::1]:43544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzQZ-00067K-0u for importer@patchew.org; Sun, 20 Mar 2022 13:33:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz61-00005p-5U for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:01 -0400 Received: from [2607:f8b0:4864:20::629] (port=38687 helo=mail-pl1-x629.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5y-0003UG-VD for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:00 -0400 Received: by mail-pl1-x629.google.com with SMTP id n18so10885446plg.5 for ; Sun, 20 Mar 2022 10:11:58 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hu9aRYzYIgbIdzSTEVhW4soYbAG6jLfuaaPgAkD8sGQ=; b=Qh8huIxAEYt/Z5x1IVM0vM3opFwm3z+Tgu5TIUEWkya8omECsefqapLtx7I/4ytWK7 YOJnoofFhl9GTJqGxChRneDsU/CzxiBWaYYikeeurItuT8UVJHh8Yo33Jl/6yaJGYykC cRwxxOsOYfc/Rji252uBe6/LlTUli+HPrPSMlqqMnLrTPS7mSlBwsfyhvglNNCpLHpMl WsPGiKysbeKAjL2InlufLz25KM++AUG1r5D5akLelTIisvVJvE5JwGPNhQPUneOnCgYy i1ZKgkSuBdC9xZawhzNm1U4lX1ddclFvm0vg2nBQXzmRlsxY/5r+bmt6l4+H/f4A1CJf UEYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hu9aRYzYIgbIdzSTEVhW4soYbAG6jLfuaaPgAkD8sGQ=; b=Qm+Rof4+u7rBTwCAi6n6CumiLEA/6eYHXP2vEwzasNoKoOSUbg5HwXW6K/QPNywCxB e2AMleDLRKYFT3rSv01AgGsm4H1MZsFQypWEaecUuRH/GwmRpxI/H+D6AXnpu8oxYSVU kaoAl3/cpB85ZNnOtME/IqIEpXwJk6exBzcFRFras7B7pI7V0symMlVWPv67SSTmAPsl WhEOdjAHUMoQU+4EZ4HXVJN6+lN0NT9RrCdcmRu/QIOhs8tPJxjsn/V9riWbHIBbw8LM JrXa5AZAnWCoKwbtY8651b/Gqd23H5UOvnAx7zQHDQXMedY10ouKxVcV00a9A1FTIzSW I5MA== X-Gm-Message-State: AOAM530idZg8+4cYROCrAm4zalQk++pE5/XaRh9iG/6GGEKcS/bzO6Ar nBvhVvqnOFWls8kT/rgaCrkfyojHwVTOUw== X-Google-Smtp-Source: ABdhPJwuxFEZCZ2KKqKC8ioQu0Jd31O/WOGGp05Yj7AyiK6SUD5fYF6yt+8UoUyeyF0Xwv/4Y5waIQ== X-Received: by 2002:a17:90b:4b83:b0:1c7:2497:3800 with SMTP id lr3-20020a17090b4b8300b001c724973800mr31537pjb.225.1647796317666; Sun, 20 Mar 2022 10:11:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 23/36] sysemu/os-win32: Test for and use _lock_file/_unlock_file Date: Sun, 20 Mar 2022 10:11:22 -0700 Message-Id: <20220320171135.2704502-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::629 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797597553100001 Content-Type: text/plain; charset="utf-8" The bug referenced in os-win32.h was fixed in mingw-w64 v6. According to repology, version 5 used by ubuntu 18, which is not yet out of support, so provide a meson link test for it. Signed-off-by: Richard Henderson --- meson.build | 12 ++++++++++++ include/sysemu/os-win32.h | 16 +++++++++------- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index 282e7c4650..f22a09dac5 100644 --- a/meson.build +++ b/meson.build @@ -2018,6 +2018,18 @@ foreach k, v: config_host endif endforeach =20 +# Older versions of MinGW do not import _lock_file and _unlock_file proper= ly. +# This was fixed for v6.0.0 with commit b48e3ac8969d. +if targetos =3D=3D 'windows' + config_host_data.set('HAVE__LOCK_FILE', cc.links(''' + #include + int main(void) { + _lock_file(NULL); + _unlock_file(NULL); + return 0; + }''', name: '_lock_file and _unlock_file')) +endif + ######################## # Target configuration # ######################## diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index 770752222a..649f417d39 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -113,20 +113,22 @@ static inline char *realpath(const char *path, char *= resolved_path) return resolved_path; } =20 -/* ??? Mingw appears to export _lock_file and _unlock_file as the functions - * with which to lock a stdio handle. But something is wrong in the marku= p, - * either in the header or the library, such that we get undefined referen= ces - * to "_imp___lock_file" etc when linking. Since we seem to have no other - * alternative, and the usage within the logging functions isn't critical, - * ignore FILE locking. +/* + * Older versions of MinGW do not import _lock_file and _unlock_file prope= rly. + * This was fixed for v6.0.0 with commit b48e3ac8969d. */ - static inline void qemu_flockfile(FILE *f) { +#ifdef HAVE__LOCK_FILE + _lock_file(f); +#endif } =20 static inline void qemu_funlockfile(FILE *f) { +#ifdef HAVE__LOCK_FILE + _unlock_file(f); +#endif } =20 /* We wrap all the sockets functions so that we can --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797375; cv=none; d=zohomail.com; s=zohoarc; b=TSJUO00/3a53q+PGPnumSQWPWtJltLtOsGGtffYvRN0QtWqtTBdPI7CnPNmQdUkqekytWW7RIHEzi5TV0JJaPMVKCnX8iv/yQVZdCm5EB4qtOGvGDNLHtJTkHbwIc5ml2b1SAoGLFiIiPsT6XYo/DUCJ+3t3Ej01g+AtXIrmOzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797375; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h0xc9BI1YGSLEUvZQaFfOPBOYlCXbsk+XY8xxzjyhJU=; b=DA3sxHwAXqEsdS3Y+XSDqZEf2R9KjCsSeFWuKko2JI03YCIS+/HkVLyAdH6qT0+VF+JzoCSSwcMyoBjx2gQQcw/zA5aCSmNy9RgTqzvsyoHy8OnVRVXP0FANs5tHXYLtawO1Rf8voTtuQaqtnlyYnI84isp4rPzaHz2uAIOIKwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797375534795.9450293108911; Sun, 20 Mar 2022 10:29:35 -0700 (PDT) Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzN2-0000eY-66 for importer@patchew.org; Sun, 20 Mar 2022 13:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz62-0000BV-Oh for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:02 -0400 Received: from [2607:f8b0:4864:20::62e] (port=45648 helo=mail-pl1-x62e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz60-0003UW-T4 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:02 -0400 Received: by mail-pl1-x62e.google.com with SMTP id k6so3717141plg.12 for ; Sun, 20 Mar 2022 10:11:59 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h0xc9BI1YGSLEUvZQaFfOPBOYlCXbsk+XY8xxzjyhJU=; b=m8jE1oJfEWsYEp9Ty2SzzXR/6cSsKE20/7fg9BGdQPoCTv6n2e8abW0VvOdOFU7EVP ueZlsH0GTKVnhZzGLCgMKtE0cUyM5D3FNctQL+/KRqJEQohToNGNK5chg+Tt7XoJA7lq El3DMy6unormZGUgymlRauav4eUoE2eNr1r9haO8LIPD4vJ5BfbUv5XPYFHqn1nUZgkg 3oJqXKShstv/YyD+wzmYVUaW/k0rJn7jdBXP/Ww6hfWu4xR0HSZAvJknXiwLR1drR8Vm QZAGvMKKRGEDL6iJ4ax7daWgpfMHcovYoczhRIWzusHkh3aFn1+IM+FJbozsX0SvcrKE lxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h0xc9BI1YGSLEUvZQaFfOPBOYlCXbsk+XY8xxzjyhJU=; b=GjGCMj8LbBAvFbXXQCS7TYAnf3Zu4UehOBTemOYanGX+iF2R04ZyiKrGQk5+Iw1obB jtYWVKCG+OxWpQslIB8UKBUzyToVnZnvT23cJ2hnCikyzJbQyRC/Ctu2VCwkiV88pZZk ff3g0WKBwusILTv5ZygkB9ASH9T2bd1+2SxwOFGvG6tUgdPjnS+fYteBbek0IyohkBD7 0GbosPuMB2BL+VSKVe9rVBKykBn0CL+i6qGEfRH3MhTcUv9V1XPw4JPO9Ze3TJXYYKy+ coF+3Vc/J37zHef/+iKtZx6jxVfhwphLhGCvbEGdtLr0xVMg3xptbEErpZn/GkVvM+P2 Ksfg== X-Gm-Message-State: AOAM532FuMbGuQ6Img36PeucXX8MMs2t7P5OkmaQavTbPv0usDm5XYgU +hrs9Qx7mbaifYoZpMHla460qv+HnNgzjw== X-Google-Smtp-Source: ABdhPJzIpQpFV/61vG4MMcczKYq3ueKUgLOXXwcpQX1x4jaVZ3OFMaN6FFgQJgH1f7yKf5EiXhEkXw== X-Received: by 2002:a17:90a:4bc2:b0:1b8:cdd3:53e2 with SMTP id u2-20020a17090a4bc200b001b8cdd353e2mr32318943pjl.219.1647796318691; Sun, 20 Mar 2022 10:11:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 24/36] util/log: Introduce qemu_set_log_filename_flags Date: Sun, 20 Mar 2022 10:11:23 -0700 Message-Id: <20220320171135.2704502-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797402461100003 Content-Type: text/plain; charset="utf-8" Provide a function to set both filename and flags at the same time. This is the common case at startup. Signed-off-by: Richard Henderson --- include/qemu/log.h | 1 + util/log.c | 122 ++++++++++++++++++++++++++++----------------- 2 files changed, 77 insertions(+), 46 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index c63416c9e0..ef247776cf 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -82,6 +82,7 @@ extern const QEMULogItem qemu_log_items[]; =20 void qemu_set_log(int log_flags, Error **errp); void qemu_set_log_filename(const char *filename, Error **errp); +void qemu_set_log_filename_flags(const char *name, int flags, Error **errp= ); void qemu_set_dfilter_ranges(const char *ranges, Error **errp); bool qemu_log_in_addr_range(uint64_t addr); int qemu_str_to_log_mask(const char *str); diff --git a/util/log.c b/util/log.c index 7e8b152742..46a0d38d41 100644 --- a/util/log.c +++ b/util/log.c @@ -126,15 +126,58 @@ static void qemu_logfile_free(QemuLogFile *logfile) } =20 /* enable or disable low levels log */ -void qemu_set_log(int log_flags, Error **errp) +static void qemu_set_log_internal(const char *filename, bool changed_name, + int log_flags, Error **errp) { - bool need_to_open_file =3D false; + bool need_to_open_file; QemuLogFile *logfile; =20 - qemu_loglevel =3D log_flags; + QEMU_LOCK_GUARD(&qemu_logfile_mutex); + logfile =3D qemu_logfile; + + if (changed_name) { + char *newname =3D NULL; + + /* + * Allow the user to include %d in their logfile which will be + * substituted with the current PID. This is useful for debugging = many + * nested linux-user tasks but will result in lots of logs. + * + * filename may be NULL. In that case, log output is sent to stderr + */ + if (filename) { + char *pidstr =3D strstr(filename, "%"); + + if (pidstr) { + /* We only accept one %d, no other format strings */ + if (pidstr[1] !=3D 'd' || strchr(pidstr + 2, '%')) { + error_setg(errp, "Bad logfile format: %s", filename); + return; + } + newname =3D g_strdup_printf(filename, getpid()); + } else { + newname =3D g_strdup(filename); + } + } + + g_free(logfilename); + logfilename =3D newname; + filename =3D newname; + + if (logfile) { + qatomic_rcu_set(&qemu_logfile, NULL); + call_rcu(logfile, qemu_logfile_free, rcu); + logfile =3D NULL; + } + } else { + filename =3D logfilename; + } + #ifdef CONFIG_TRACE_LOG - qemu_loglevel |=3D LOG_TRACE; + log_flags |=3D LOG_TRACE; #endif + qemu_loglevel =3D log_flags; + /* * In all cases we only log if qemu_loglevel is set. * Also: @@ -143,70 +186,57 @@ void qemu_set_log(int log_flags, Error **errp) * If we are daemonized, * we will only log if there is a logfilename. */ - if (qemu_loglevel && (!is_daemonized() || logfilename)) { - need_to_open_file =3D true; - } - QEMU_LOCK_GUARD(&qemu_logfile_mutex); - if (qemu_logfile && !need_to_open_file) { - logfile =3D qemu_logfile; + need_to_open_file =3D log_flags && (!is_daemonized() || filename); + + if (logfile && !need_to_open_file) { qatomic_rcu_set(&qemu_logfile, NULL); call_rcu(logfile, qemu_logfile_free, rcu); - } else if (!qemu_logfile && need_to_open_file) { - logfile =3D g_new0(QemuLogFile, 1); - if (logfilename) { - logfile->fd =3D fopen(logfilename, log_append ? "a" : "w"); - if (!logfile->fd) { + return; + } + if (!logfile && need_to_open_file) { + FILE *fd; + + if (filename) { + fd =3D fopen(filename, log_append ? "a" : "w"); + if (!fd) { error_setg_errno(errp, errno, "Error opening logfile %s", - logfilename); + filename); return; } /* In case we are a daemon redirect stderr to logfile */ if (is_daemonized()) { - dup2(fileno(logfile->fd), STDERR_FILENO); - fclose(logfile->fd); + dup2(fileno(fd), STDERR_FILENO); + fclose(fd); /* This will skip closing logfile in qemu_log_close() */ - logfile->fd =3D stderr; + fd =3D stderr; } } else { /* Default to stderr if no log file specified */ assert(!is_daemonized()); - logfile->fd =3D stderr; + fd =3D stderr; } =20 log_append =3D 1; + + logfile =3D g_new0(QemuLogFile, 1); + logfile->fd =3D fd; qatomic_rcu_set(&qemu_logfile, logfile); } } =20 -/* - * Allow the user to include %d in their logfile which will be - * substituted with the current PID. This is useful for debugging many - * nested linux-user tasks but will result in lots of logs. - * - * filename may be NULL. In that case, log output is sent to stderr - */ +void qemu_set_log(int log_flags, Error **errp) +{ + qemu_set_log_internal(NULL, false, log_flags, errp); +} + void qemu_set_log_filename(const char *filename, Error **errp) { - g_free(logfilename); - logfilename =3D NULL; + qemu_set_log_internal(filename, true, qemu_loglevel, errp); +} =20 - if (filename) { - char *pidstr =3D strstr(filename, "%"); - if (pidstr) { - /* We only accept one %d, no other format strings */ - if (pidstr[1] !=3D 'd' || strchr(pidstr + 2, '%')) { - error_setg(errp, "Bad logfile format: %s", filename); - return; - } else { - logfilename =3D g_strdup_printf(filename, getpid()); - } - } else { - logfilename =3D g_strdup(filename); - } - } - - qemu_log_close(); - qemu_set_log(qemu_loglevel, errp); +void qemu_set_log_filename_flags(const char *name, int flags, Error **errp) +{ + qemu_set_log_internal(name, true, flags, errp); } =20 /* Returns true if addr is in our debug filter or no filter defined --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797788; cv=none; d=zohomail.com; s=zohoarc; b=gtmMulNQVEhw1M74kEl3wFQmJvF+OWm9Csu7o8iuuNsvggM8bTRkxTr+TweSlQqaDZr1z05wa7094x3OV0RSnpp8QQ0oOCKkq7jf++Yg8X2Z8DPuT+IqMWmCEqzo3i+tBMXTn6WI3l3PBK3KfscmObrRcVNYbU+Ye/6EmADZgEU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797788; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yC2sireZoOTYAuTYG5JxotkaWGRw4AVLDFu3n1FRWSw=; b=Zd9SbEvLZlzy3UhStlpTxqlOmLmpH3sR2ABa3lTmc9zsbEdYF+b4uvAIZk6Cp60qthY6ynIukd8ZQhAstHmfzPCv2coBlMJX4ePxKyFrO+O8jtGBtmxjjL8M/2XsVvbA8yQkrkQ4Ii9BI/D3F15NDh5vzs/Vyd5x8ybzZNqDj0Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797788451762.813548258281; Sun, 20 Mar 2022 10:36:28 -0700 (PDT) Received: from localhost ([::1]:51878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzTf-0003GY-9Q for importer@patchew.org; Sun, 20 Mar 2022 13:36:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz62-0000AA-EB for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:02 -0400 Received: from [2607:f8b0:4864:20::102a] (port=33964 helo=mail-pj1-x102a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz60-0003Ud-Uq for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:02 -0400 Received: by mail-pj1-x102a.google.com with SMTP id o68-20020a17090a0a4a00b001c686a48263so6075330pjo.1 for ; Sun, 20 Mar 2022 10:12:00 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yC2sireZoOTYAuTYG5JxotkaWGRw4AVLDFu3n1FRWSw=; b=ga9KnqhL47LNO+pd9SEOECHzxpZHT8tgpKN9YEz06NgCaPr/6lCyH2omP9lCJeP+Bs ZzytrAcBTmIrHoZ0jvtncuzUocbLH0zX/YRB+5q344VpsHaSKgzWOvdLnock7HVlSFTr wqAGso3R/xHJwecSNHbqHV0SfQLFuinDvbpOlfDYGIFOC0iQGV1dQ4H4d59Z9NmDdQjh e8vh/y2yoOwF3FZH6qKwkoz90wy6gv3WK1h1UNed8kIfUyB89E4YGOC8wAkjo+1XOfbO 7uKhcPXik+IShYngulX4snz13DXi3TaoLcjz1LdqFJIPXZNRVSWSGyAFpLGP9IWiF7GU QgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yC2sireZoOTYAuTYG5JxotkaWGRw4AVLDFu3n1FRWSw=; b=6DG5bP4RctCIMKbs0bRDaz1iArRq/Av73uYSO2OPSwevUq/rZ3ymmGcDQG/Cf/4vHg z900WAzoVq6SP5EJJ1/Fqqr/4l7ZNSvJMhECtSaGp8zwM0gv7rKuQktP5eJ8xC/SrvLX IlX9L/KqY6Y1DknWKgwOihRlcAiXsKz9dalPWtXCk+py+baHnwUfkRUmFEgZXneyMtDD n9Brz/1dKLpDuMBhk1hh7OmHZodhMLtsHQJfjazKkH5srd8QgIbV8QW2vcTOTHWlSkBw Gl0aD8k73IaDhCF7bp52vxrGrjFRMnK+tw5R/bzEX5pMTa0EPCQMw+oHp11WrgTEejnJ nqqw== X-Gm-Message-State: AOAM533zZgWLamzFmxT6CJQH5lm1db6sE2uk4BQyERm5/5YMQilF3XFL P/aFbRwnQiSDgNp89KMdhoZlB3Vc/ujtPQ== X-Google-Smtp-Source: ABdhPJwEspOaAZbJRPxxBexihn5KPrcrDQfM8LAfddURE6TDn8R6htSrkXX+fKMbcv+pxbzlQrVoew== X-Received: by 2002:a17:90b:38c9:b0:1c7:1ffb:533b with SMTP id nn9-20020a17090b38c900b001c71ffb533bmr640207pjb.220.1647796319663; Sun, 20 Mar 2022 10:11:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 25/36] bsd-user: Use qemu_set_log_filename_flags Date: Sun, 20 Mar 2022 10:11:24 -0700 Message-Id: <20220320171135.2704502-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102a (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797790599100001 Content-Type: text/plain; charset="utf-8" Perform all logfile setup in one step. Signed-off-by: Richard Henderson --- bsd-user/main.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index d25d1c6015..2c8f8d1c19 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -405,16 +405,16 @@ int main(int argc, char **argv) } =20 /* init debug */ - qemu_set_log_filename(log_file, &error_fatal); - if (log_mask) { - int mask; - - mask =3D qemu_str_to_log_mask(log_mask); - if (!mask) { - qemu_print_log_usage(stdout); - exit(1); + { + int mask =3D 0; + if (log_mask) { + mask =3D qemu_str_to_log_mask(log_mask); + if (!mask) { + qemu_print_log_usage(stdout); + exit(1); + } } - qemu_set_log(mask, &error_fatal); + qemu_set_log_filename_flags(log_file, mask, &error_fatal); } =20 if (optind >=3D argc) { --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797692; cv=none; d=zohomail.com; s=zohoarc; b=V2HZbeohxw4o3c1NXL1OZ8HrCEvUdItlb8EFNgRJ36s8BUfjk0Hjz7jDAbzLFIWxX0v8Qk8bZqAeNu+a6B8+TJWoAWv/JzHndHaY9fDzjRTVUBsJyfd6ykD+g10NwT5vf+DVIh8uddwpu5QSPeHuS1b/MHooLMU5cbjBA/DjHpc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797692; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tbvVNjefg+clp9cnxa2dTGnw4THGled3q05yu65oSKo=; b=cgtPGJcTwVvwcNmErIMvEVKKzKPYy3B/9oUQgJl8V3BjXW+PmRNTmy7MBwHOZOcp9LlZ7JxfJHT82Ql4TAcafuR0dBHRJOjP4FDud8XChOeQ3ybtCQ/zDq+rjCh/otPVLoEL9BHOo8FMU5aIlNXZgmLe86N/SJ4fnvEwVKXvOBA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797692347710.5695932381833; Sun, 20 Mar 2022 10:34:52 -0700 (PDT) Received: from localhost ([::1]:46970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzS7-0008Pd-76 for importer@patchew.org; Sun, 20 Mar 2022 13:34:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz63-0000Eg-LF for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:03 -0400 Received: from [2607:f8b0:4864:20::533] (port=40499 helo=mail-pg1-x533.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz61-0003Uu-Vu for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:03 -0400 Received: by mail-pg1-x533.google.com with SMTP id w21so5045268pgm.7 for ; Sun, 20 Mar 2022 10:12:01 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tbvVNjefg+clp9cnxa2dTGnw4THGled3q05yu65oSKo=; b=hqrARsdyXj855FwNSqVrrxSYRCsaLSWD4vBMiFL621BnosRPBDuvANTOIwY2/Bl31U UPotp2yuG3PXcaI/fmrBZ8edO/CnWPpmdc8zCuyCyjeBvZ3vhui3kxAPGWi0M457lB4d FhKh3Ivl7BUv1lm6FeHfN2mSz689Jsvaa8Rg9ZGYXhp4NXs7P2qZdVSNkV/H68YxyKA7 RPTVwQ+4x34j68HfscjRUDE2468MmOCWnGuNyIzg+ZtRGWLCpFrOUEpjFquljqDdly84 aJsymWEXJvkMM4o6xLG5GCF6l8DNdY4hlv/iTtvUJI7J33sRAgrWCtUyNkoA4aLYRCjF mzdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tbvVNjefg+clp9cnxa2dTGnw4THGled3q05yu65oSKo=; b=4sUjBeEcGotJ86sR6meMDPNEKSaFYYQdizZDDvB7f6y1wPCM0gjE2x3ywoYHy6QFsw MCWdj/DdVF0e5H2KtME4CvqvbgAwQWo+49wrVRqpfvrwoD9Ik5Vrpas4ovQSMffUXuqM i8djohxlXeJzUPDVqqU6qtbBC7IsZIwoqmg140G6Uioygv+ghXMdBBUmwUQBoi7iAW/3 lEsh0yX2L+L7AIWsX3E4l6MchWp9AVGhEfDJkGTdKh9SfBdkv9z3z8Poh0fjFqN4FDKm GD3vx39mATefYI3rXmotgWTQIY6KfdRlv2scjJ3nmFw2XE/g6HaO1ge2EaSmXgdj4jHC JeGQ== X-Gm-Message-State: AOAM533OQl88Fg2FWBa3S5EfXWe/q3PMV0u3D9bCPo9Le5lQKveEWdmQ KF540ouSODba5akHRepZGrBtyphQoQ07SA== X-Google-Smtp-Source: ABdhPJyqyIlulEUa99r6zUzca4I3OVJJkzWiRAxGUO5FPCYhWKzCowgILJYGTau0nmP23o0wqzcG8A== X-Received: by 2002:a63:5907:0:b0:382:2f93:5467 with SMTP id n7-20020a635907000000b003822f935467mr9381857pgb.460.1647796320720; Sun, 20 Mar 2022 10:12:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 26/36] linux-user: Use qemu_set_log_filename_flags Date: Sun, 20 Mar 2022 10:11:25 -0700 Message-Id: <20220320171135.2704502-27-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::533 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797694116100001 Content-Type: text/plain; charset="utf-8" Perform all logfile setup in one step. Signed-off-by: Richard Henderson --- linux-user/main.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 2bdee78019..75d13eff97 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -85,6 +85,7 @@ static bool enable_strace; * Used to support command line arguments overriding environment variables. */ static int last_log_mask; +static const char *last_log_filename; =20 /* * When running 32-on-64 we should make sure we can fit all of the possible @@ -257,7 +258,7 @@ static void handle_arg_dfilter(const char *arg) =20 static void handle_arg_log_filename(const char *arg) { - qemu_set_log_filename(arg, &error_fatal); + last_log_filename =3D arg; } =20 static void handle_arg_set_env(const char *arg) @@ -643,7 +644,6 @@ int main(int argc, char **argv, char **envp) int i; int ret; int execfd; - int log_mask; unsigned long max_reserved_va; bool preserve_argv0; =20 @@ -677,10 +677,9 @@ int main(int argc, char **argv, char **envp) =20 optind =3D parse_args(argc, argv); =20 - log_mask =3D last_log_mask | (enable_strace ? LOG_STRACE : 0); - if (log_mask) { - qemu_set_log(log_mask, &error_fatal); - } + qemu_set_log_filename_flags(last_log_filename, + last_log_mask | (enable_strace * LOG_STRAC= E), + &error_fatal); =20 if (!trace_init_backends()) { exit(1); --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798902; cv=none; d=zohomail.com; s=zohoarc; b=C4Lq+/8Rwmf6B/9UML0FVAD+HbiVB9i7K1j5JUODkvw9QU2yhROi25XO8duV9vGWgCNC6vlmfQCtbOI0JEMO9IkcyOyJCpTu2D6wpBUzvo7u+VRDBt4WL5Y0W9o8DvWnhajqnc1z9Ao7Ib4ePOsb2kIpNYIl7jwI6CVtJROYDkk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798902; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=X5VZGVfDRwsa6U5imM3TbqL1rDwZxZr3FYEMX2oqv64=; b=G570KIjLjteh8dmgeuvn8IjBQdwT4eR0x0VVL7BKkz5aEA6eIV4DjprJxMEQs8lr8iRqwXfMGgLqnkHZZtdkU9xt1Pto8/5SxKJaQrI0ThqJBFU1hEgDtEm+16Gnkdlnm7JPS4NvgOiaf0JZMzsB4EsWMaN9x4ZsrCSTk7FKwwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798902676236.49092746792792; Sun, 20 Mar 2022 10:55:02 -0700 (PDT) Received: from localhost ([::1]:49796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzld-0004ZP-E4 for importer@patchew.org; Sun, 20 Mar 2022 13:55:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz64-0000H9-8d for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:04 -0400 Received: from [2607:f8b0:4864:20::1031] (port=45830 helo=mail-pj1-x1031.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz62-0003V1-Rj for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:03 -0400 Received: by mail-pj1-x1031.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so12525038pjl.4 for ; Sun, 20 Mar 2022 10:12:02 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X5VZGVfDRwsa6U5imM3TbqL1rDwZxZr3FYEMX2oqv64=; b=gkvCUH+25Jp/H+u8K+OTbkHDz4ZpZx+i3HazrP92UjrcXmjhlzNvC8NA92KZia3mfa 2ZT42MycZHIDl8s7chTaKesh5WTKZ2UYHcwDGhK3/xyH39xgryJugYP17fF/kO7RASqe sS2e3MBgHx1i+W1Y5E7JLhrq6oVpGEciaiAvWhXl57TDNTGaL0sBkX2rhhBUDgJCvqG7 C/3v6hS0ki+j97+6C+Ka5do5lKbH9Zl68rKBtSmRyz3vV7mpoVMQMA7L2GS3jPpiIf/s 9QmXKmQdF6xwXZoGvDFlYqUiYI4Qo+n/Sl2k7mwHfhPEJQLXOK0GKHlFcO/liBb6jXUK lD7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X5VZGVfDRwsa6U5imM3TbqL1rDwZxZr3FYEMX2oqv64=; b=Yr7aqi8fkV99XKzz6qad/txGbs04KC5XD75ny34Vpv31qIxGI9TVTKjEmsLwQ0YA4L +PXUpaVYH628oUZxUcTLCVG/iWmWkmaDB+9N52xjGxaRIhiTp8UaRV3TPkCrUgsNonHe B5y2dZtgiFLmip6YZm26pgXePNCBhrRXq7aSxOrB5Tx+NtHym7cPP4ElTVBV5m7QhxqK uTTNqUFcOxMxo23jO710GJ5+QQ2S+bI4Kpak0XQVZ6/juRWUtIzgcGAsVHl1QDrR5ANp 8H1F39TGai5HFlGp3onFt/INitEFJ8ZhFLRLkQEv4RxP0kNMh86nOk/r/MKsOSAmVbxA GYNg== X-Gm-Message-State: AOAM533NemXVAxki1G7s2KpgxYsspyhU3VcRekU4cfoqyUVMI/9h7LPT vt56lVjG5zNbbL5BvrYUxPmJ6X4k9M6fSA== X-Google-Smtp-Source: ABdhPJwIax6lmBbL1YsGoh3k78BTzjInKGKZ6AFccJrGGKPm3JoHByHa5tjd4lapnOUo3lvkh73M1g== X-Received: by 2002:a17:90a:4097:b0:1c6:ca92:7a83 with SMTP id l23-20020a17090a409700b001c6ca927a83mr11177526pjg.130.1647796321538; Sun, 20 Mar 2022 10:12:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 27/36] softmmu: Use qemu_set_log_filename_flags Date: Sun, 20 Mar 2022 10:11:26 -0700 Message-Id: <20220320171135.2704502-28-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1031 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798903618100001 Content-Type: text/plain; charset="utf-8" Perform all logfile setup at startup in one step. Signed-off-by: Richard Henderson --- softmmu/vl.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 73296015af..81c91ec7b0 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2559,19 +2559,16 @@ static void qemu_process_early_options(void) #endif =20 /* Open the logfile at this point and set the log mask if necessary. = */ - if (log_file) { - qemu_set_log_filename(log_file, &error_fatal); - } - if (log_mask) { - int mask; - mask =3D qemu_str_to_log_mask(log_mask); - if (!mask) { - qemu_print_log_usage(stdout); - exit(1); + { + int mask =3D 0; + if (log_mask) { + mask =3D qemu_str_to_log_mask(log_mask); + if (!mask) { + qemu_print_log_usage(stdout); + exit(1); + } } - qemu_set_log(mask, &error_fatal); - } else { - qemu_set_log(0, &error_fatal); + qemu_set_log_filename_flags(log_file, mask, &error_fatal); } =20 qemu_add_default_firmwarepath(); --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797613; cv=none; d=zohomail.com; s=zohoarc; b=E19BgM03fmW9rx7qO6fkOlYBacObXh/dCMO9lICTlG2WSJ3B/5Ff40FyHKN/DKV8SVTYZYER7pqGjRAa2dY0o91/sjg1WRUVN0KsaDq+Vf1jV/hHB6BC9grF1HAi6xNh4wj7Ua/Ovw4jigbtR58yiUbklHw58d1QxYd7koHr7kI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797613; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fetZSTEnCJcUQDWQ/liPaUY34R68y2pAl1CfXvkPMCQ=; b=Lz+SqdRE9cySR1F715xZd7SiX24UaNs29JpqpurnDn1xQPt7k5h0po1RvYeoSAEQSKhVzPGxA+z0onVod4cCQ06LBmFiidLoz0ZX2sPQQri/PfAQPqFrCzMne0a/QZC25VPSNFCFMtaTPPIYBiX0w5y4cLkK2JbZ23kuaUxt8OQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797613949382.9498262684941; Sun, 20 Mar 2022 10:33:33 -0700 (PDT) Received: from localhost ([::1]:44132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzQq-0006VB-HI for importer@patchew.org; Sun, 20 Mar 2022 13:33:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz65-0000Ki-3q for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:05 -0400 Received: from [2607:f8b0:4864:20::631] (port=40458 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz63-0003VG-Gt for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:04 -0400 Received: by mail-pl1-x631.google.com with SMTP id h5so10883713plf.7 for ; Sun, 20 Mar 2022 10:12:03 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fetZSTEnCJcUQDWQ/liPaUY34R68y2pAl1CfXvkPMCQ=; b=mmq+r8KGF/9AV6RJGtJlDlPDXpN2T7lt6xZOBChHZSXFDVTcBX0tD2mZcotEMj1R4+ jCZdqCIWMuwRI1no6sqZQyINZnCfzs/FNsvxH6XD/E4Ci1Iusv5hK5mD6qTltT6aP9Ue z95QGIvQCyvzUYg6ntASdg1Lp3/2QYSwidpTkQ+6ybfptRxRuAJSyCvmgziloQbVtlfF g14B0hVzBXUElNsjThdO2eaz3NHK+iR39Mb9IAX9F/PLdF90hRTfePm46L6cjzdRGARu Ta+YuLBQJsIHsqZGU0PKkVkvEfUCdkncYknFJf8SJFnC+oUd2ZlbZXh/jgBXg0ASu6R1 7Euw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fetZSTEnCJcUQDWQ/liPaUY34R68y2pAl1CfXvkPMCQ=; b=txJZ/59q+aCG7HoKkTR+zqge8pGg2SarJzak1E+ZJP8Wdkq/AAmpFJsXvTX5gT08Wl JtnUj92/rQ3mqEHdmQNQEIHnjMPlw6lTspfy9flw+TUvOz7aHIqUjq00+O/+q9yXF7Zj tMbftq2oe3EmjMdW7Gy5is7bbFQJ4gRmTeUOBdgEYThLEoGPIA92OZf2KF8Gq1sXwruL YFQwMK1b19WXYVGrcXutpvBY8lj6Zp85/F5fnddg1x8oqkjK2zLPOzyeA+aL0LfExO+Q ylV99pZNoWK+eB3paft8wldS4F1R8PJOXE/to46etkVGOvUoQz1f5zvXXUxbGvJk6ksl wC+g== X-Gm-Message-State: AOAM531lDVxGbNJ3KsTmh91Zq7aydZFet+9/14AyH0IlcijAIHf8Pahh vN8heVpLMNkK8FBagItb0m2nU6TlYRB67w== X-Google-Smtp-Source: ABdhPJyrdqXyHxEMjwL8fou4FI3yYGojgSRYyhPTiQbkcHze7IxWol33zMlFnCxrHmZubyHv+2Lo3Q== X-Received: by 2002:a17:902:c408:b0:154:4bee:c418 with SMTP id k8-20020a170902c40800b001544beec418mr3229702plk.75.1647796322264; Sun, 20 Mar 2022 10:12:02 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 28/36] util/log: Remove qemu_log_close Date: Sun, 20 Mar 2022 10:11:27 -0700 Message-Id: <20220320171135.2704502-29-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797615444100001 Content-Type: text/plain; charset="utf-8" The only real use is in cpu_abort, where we have just flushed the file via qemu_log_unlock, and are just about to force-crash the application via abort. We do not really need to close the FILE before the abort. The two uses in test-logging.c can be handled with qemu_set_log_filename_flags. Signed-off-by: Richard Henderson --- include/qemu/log.h | 3 --- cpu.c | 1 - tests/unit/test-logging.c | 4 ++-- util/log.c | 17 +---------------- 4 files changed, 3 insertions(+), 22 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index ef247776cf..783faec309 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -92,7 +92,4 @@ int qemu_str_to_log_mask(const char *str); */ void qemu_print_log_usage(FILE *f); =20 -/* Close the log file */ -void qemu_log_close(void); - #endif diff --git a/cpu.c b/cpu.c index 054f21b307..3eb324c1c9 100644 --- a/cpu.c +++ b/cpu.c @@ -406,7 +406,6 @@ void cpu_abort(CPUState *cpu, const char *fmt, ...) fprintf(logfile, "\n"); cpu_dump_state(cpu, logfile, CPU_DUMP_FPU | CPU_DUMP_CCOP); qemu_log_unlock(logfile); - qemu_log_close(); } va_end(ap2); va_end(ap); diff --git a/tests/unit/test-logging.c b/tests/unit/test-logging.c index 7016710a74..4e649e44c5 100644 --- a/tests/unit/test-logging.c +++ b/tests/unit/test-logging.c @@ -170,7 +170,7 @@ static void test_logfile_lock(gconstpointer data) * Initiate a close file and make sure our handle remains * valid since we still have the logfile lock. */ - qemu_log_close(); + qemu_set_log_filename_flags(NULL, 0, &error_abort); fprintf(logfile, "%s 2nd write to file\n", __func__); fflush(logfile); qemu_log_unlock(logfile); @@ -208,7 +208,7 @@ int main(int argc, char **argv) tmp_path, test_logfile_lock); =20 rc =3D g_test_run(); - qemu_log_close(); + qemu_set_log_filename_flags(NULL, 0, &error_abort); drain_call_rcu(); =20 rmdir_full(tmp_path); diff --git a/util/log.c b/util/log.c index 46a0d38d41..691d6d7930 100644 --- a/util/log.c +++ b/util/log.c @@ -207,7 +207,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, if (is_daemonized()) { dup2(fileno(fd), STDERR_FILENO); fclose(fd); - /* This will skip closing logfile in qemu_log_close() */ + /* This will skip closing logfile in qemu_logfile_free. */ fd =3D stderr; } } else { @@ -330,21 +330,6 @@ out: g_strfreev(ranges); } =20 -/* Close the log file */ -void qemu_log_close(void) -{ - QemuLogFile *logfile; - - qemu_mutex_lock(&qemu_logfile_mutex); - logfile =3D qemu_logfile; - - if (logfile) { - qatomic_rcu_set(&qemu_logfile, NULL); - call_rcu(logfile, qemu_logfile_free, rcu); - } - qemu_mutex_unlock(&qemu_logfile_mutex); -} - const QEMULogItem qemu_log_items[] =3D { { CPU_LOG_TB_OUT_ASM, "out_asm", "show generated host assembly code for each compiled TB" }, --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647799027; cv=none; d=zohomail.com; s=zohoarc; b=KD0YP3TCCFna2nkbBERjBCLgjA0e2xmtOS9NA92wM/eSeVHl63dZlTtgOP8+NG8IgchOO1VKWBRoQjfHwQxWf82bfXozV3G1E5ghkkGFL5kI2pJxHWP5/KJBV3c7Qkb5diZrSMEioyF8cxCMMjHllxX+vuIKIcSq+Wc9NQK1tIE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647799027; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bk/zAi7BLJglpoQ02+PCS2bvRMTlUag208O7lg3rkCQ=; b=QGOo/c0KHkeQl3ZvxUweMKYGiT+XTadNLY08TMVoE9kYoyRbc4z23Hf1gYyaEjeYqTFnIZ7/XcpEJwQUxaXo4xR5n26KJ4CN1/9wu+VebFThoyJhMqthZ+Bg5ow/Ib1/ZmRwkfF8in9OwU+ZVVmZLgOOOr6OllVJAzstWX5Mwtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647799027808899.6552230353088; Sun, 20 Mar 2022 10:57:07 -0700 (PDT) Received: from localhost ([::1]:53916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzne-0007TP-SS for importer@patchew.org; Sun, 20 Mar 2022 13:57:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz66-0000Mx-Ko for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:06 -0400 Received: from [2607:f8b0:4864:20::52e] (port=41478 helo=mail-pg1-x52e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz64-0003Vi-Gy for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:05 -0400 Received: by mail-pg1-x52e.google.com with SMTP id o26so8742682pgb.8 for ; Sun, 20 Mar 2022 10:12:04 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bk/zAi7BLJglpoQ02+PCS2bvRMTlUag208O7lg3rkCQ=; b=iDsHyq6pt0hnEnGlxpQcGnartQoiIGXEO7lQ2h5w4KZCwySYV9hj+cf18DqtrDBaUo SbDqtxM3/g6CRXkx67YqqrGLPT8+UNoLkw/7JLxwyBerMI5/uBjwoRwaZiKeCvPIOWLy 9kgTpNXq5Db+geYDIL3KlJoFW9yD14NCZ8GQQm2a6jPQbhQLsPKJ6Nx0BRTxjx8+h5L0 3kYBtcRPR0Hrc1v+Froba5Z232NOWcKgi9HgPuE2yB/onJ4/MJHP5eQgTkLEk23JRZNM 7VyeCfFVM7w2uGGHClbCa/azwK8jp6nWis3uA5W+DfFxtFSGoU0yyj2KOADbdZpznmG8 VxIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bk/zAi7BLJglpoQ02+PCS2bvRMTlUag208O7lg3rkCQ=; b=cLt/6JCeSFZUUqMbdaM1kZja8tNrD8nv+UIRZna5YWxwu+ZVtpujpwB6o0XBLZjhC1 LKEcSBClzig573P1sj5jFd4rbIQGLH9m087H1z7W+YhVNhrMlPu7mJ/i0wbzf8W9nxXu 2OM9sYh3mh5fwZuV1m031OirMNOKktcgo+ID0S+ScraYMX50ntZDtXJW5VKaJbWYjPhC 3yuQH/H7ZlgTD7HdH/RliWhi1ozuvnzu1dKlbZYHo9rurIpJ1FzDKGuD8t+x8OSfqKTT flDjdgBjzNjBZFDIyMxV4hgdWMUZsVs2y2VqXCU/k23hforYFeq2Kr9ZQmTosKVx5JeN hgVQ== X-Gm-Message-State: AOAM530y1GuD7xxhTOIPY1+cRb0Bn/oiOzHTjxMviq4PtEvk1AihaofJ kP9X0yeNcHB71vPzed2Np/6UQbPXehQiKQ== X-Google-Smtp-Source: ABdhPJwLORI2LDOiEK1JeeYDbsbk6NVQmquCLT5THrFJLNp6TSjp3Mieq+c0Q/pGeOBVn0N2GQTsUQ== X-Received: by 2002:a65:4c82:0:b0:380:3aee:6948 with SMTP id m2-20020a654c82000000b003803aee6948mr15178341pgt.527.1647796323164; Sun, 20 Mar 2022 10:12:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 29/36] util/log: Rename logfilename to global_filename Date: Sun, 20 Mar 2022 10:11:28 -0700 Message-Id: <20220320171135.2704502-30-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647799028510100001 Content-Type: text/plain; charset="utf-8" Rename to emphasize this is the file-scope global variable. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/log.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/util/log.c b/util/log.c index 691d6d7930..e559d37369 100644 --- a/util/log.c +++ b/util/log.c @@ -34,7 +34,7 @@ typedef struct QemuLogFile { FILE *fd; } QemuLogFile; =20 -static char *logfilename; +static char *global_filename; static QemuMutex qemu_logfile_mutex; static QemuLogFile *qemu_logfile; int qemu_loglevel; @@ -160,8 +160,8 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, } } =20 - g_free(logfilename); - logfilename =3D newname; + g_free(global_filename); + global_filename =3D newname; filename =3D newname; =20 if (logfile) { @@ -170,7 +170,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, logfile =3D NULL; } } else { - filename =3D logfilename; + filename =3D global_filename; } =20 #ifdef CONFIG_TRACE_LOG @@ -182,9 +182,8 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, * In all cases we only log if qemu_loglevel is set. * Also: * If not daemonized we will always log either to stderr - * or to a file (if there is a logfilename). - * If we are daemonized, - * we will only log if there is a logfilename. + * or to a file (if there is a filename). + * If we are daemonized, we will only log if there is a filename. */ need_to_open_file =3D log_flags && (!is_daemonized() || filename); =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797874; cv=none; d=zohomail.com; s=zohoarc; b=cWiE972Cxfam8sAWBrjD/rEEERmHbumaDSkf75a6lcQWfdvyuARJ/lcKjVPVa9XuwepYl0xTQBbqrN4TIU4kyc5tWvf2hO+dsuU9uFgmtMqKUSCf+YLNPaYFNV8sOmt7rckbMIA1BM2IHhQ+hmWSsDwL4M3eUwc+1JELFrTIHc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797874; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JKSI3UGozDJNBAh+QUx3PhImAK1Aw8+e6IP7+9yTeH4=; b=UuddGBPe6DtniXsUhF+Dykdsu2P8/RkHPZ0wXlaNscQAdEXDWXRPrS9mfVlZqDyctIqGWlzKk5LACRkPbBHEycRgdaGWF/CW0WFxi2v0tVPxkrl7aoYyKg7BV/Mb+W/Drr2Z75qfuQdClx7o9HiA1Yd9jf8drgA417Cx2jf5HBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164779787445964.49306515572209; Sun, 20 Mar 2022 10:37:54 -0700 (PDT) Received: from localhost ([::1]:55322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzV3-0005ZW-D6 for importer@patchew.org; Sun, 20 Mar 2022 13:37:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz67-0000OO-3m for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:07 -0400 Received: from [2607:f8b0:4864:20::631] (port=35668 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz65-0003Vu-Er for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:06 -0400 Received: by mail-pl1-x631.google.com with SMTP id n15so10901626plh.2 for ; Sun, 20 Mar 2022 10:12:05 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JKSI3UGozDJNBAh+QUx3PhImAK1Aw8+e6IP7+9yTeH4=; b=euGRNYuMu54gk93H0zl0aTUrj12Yy4p3/eCuCwxBUmSOJq2DsMFW6j7tLtHn8jUQ+u g4NOxa1yLlcLYC1H8fMA5WKBG6A3jlDjOYQe7clx0uV2yJi7CvJ2gEgGmnG3TLYqXk8Z CKYrxpVPsIBKi7SQtJEs5fNLjp7Tk3sNRjimJh+hUYVxkwyOwwBdKCJwiFTORI40kXod cgzAB5hvegQVapxdcZwXMcMtm9JDhnFW7A9+UbwTp5zCFaBDLvUgvfaMq+x1aS0imjhe rxQYbNrMi7MkIybqPs9hZHa41f/eFZjJWu9zVMknbX1AkBmJ6SVc+tFl4qimtx8p5tou wc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JKSI3UGozDJNBAh+QUx3PhImAK1Aw8+e6IP7+9yTeH4=; b=eIWJhXNUt0QIPaHndkAzsLbB3QeMvdDCIp9V/Oo2J44P77tXp4RnWACDbb1O+sx4hG +qXk2yD2vNPkT1v9Lm8w2NKUnAOo1wMAZApwtZjkw49twTihuOcQbuDiFk1ClwaTpuQW HSmP8CW7mWfjMBrlNC0yZY5WvQlvT/ZhxcA334jvj9Ik4qZ3cCrNN7mUPl2WgBO7LUwt kmrpNPiE7kvSenM1o2eCGO3SIFe6A73v4HqzdeOmrpXOJrs2/CNGkBsw+C0HMzhG0Wjw ez0NeFlIqwBOLp8SMefrFJPY0EMxIzMvM7iExarNOCd/nZiWVOF+VdN572WZI8yo7xiQ HlOQ== X-Gm-Message-State: AOAM530hTdhdFaO7ch1pyNfXThKcuPUxE+OxBY7J8NqZD9wmfsu810aa 9lkt+/7fuh9us49S3NNEWh3Mgr2oxBhB7A== X-Google-Smtp-Source: ABdhPJwZ1Nyqjn6FFXs/RKAs/2HVSy/Lv7+ZS8lYcP4OKeSJ/TZTut2F4oBkUM/xZ08h25TeentQ9A== X-Received: by 2002:a17:90b:390c:b0:1c6:259f:a4cd with SMTP id ob12-20020a17090b390c00b001c6259fa4cdmr32078135pjb.73.1647796324163; Sun, 20 Mar 2022 10:12:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 30/36] util/log: Rename qemu_logfile to global_file Date: Sun, 20 Mar 2022 10:11:29 -0700 Message-Id: <20220320171135.2704502-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797875030100001 Content-Type: text/plain; charset="utf-8" Rename to emphasize this is the file-scope global variable. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/log.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/util/log.c b/util/log.c index e559d37369..0676ce5bd6 100644 --- a/util/log.c +++ b/util/log.c @@ -36,7 +36,7 @@ typedef struct QemuLogFile { =20 static char *global_filename; static QemuMutex qemu_logfile_mutex; -static QemuLogFile *qemu_logfile; +static QemuLogFile *global_file; int qemu_loglevel; static int log_append =3D 0; static GArray *debug_regions; @@ -44,7 +44,7 @@ static GArray *debug_regions; /* Returns true if qemu_log() will really write somewhere. */ bool qemu_log_enabled(void) { - return qemu_logfile !=3D NULL; + return global_file !=3D NULL; } =20 /* Returns true if qemu_log() will write somewhere other than stderr. */ @@ -54,7 +54,7 @@ bool qemu_log_separate(void) bool res =3D false; =20 rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); + logfile =3D qatomic_rcu_read(&global_file); if (logfile && logfile->fd !=3D stderr) { res =3D true; } @@ -69,7 +69,7 @@ FILE *qemu_log_lock(void) QemuLogFile *logfile; =20 rcu_read_lock(); - logfile =3D qatomic_rcu_read(&qemu_logfile); + logfile =3D qatomic_rcu_read(&global_file); if (logfile) { qemu_flockfile(logfile->fd); return logfile->fd; @@ -133,7 +133,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, QemuLogFile *logfile; =20 QEMU_LOCK_GUARD(&qemu_logfile_mutex); - logfile =3D qemu_logfile; + logfile =3D global_file; =20 if (changed_name) { char *newname =3D NULL; @@ -165,7 +165,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, filename =3D newname; =20 if (logfile) { - qatomic_rcu_set(&qemu_logfile, NULL); + qatomic_rcu_set(&global_file, NULL); call_rcu(logfile, qemu_logfile_free, rcu); logfile =3D NULL; } @@ -188,7 +188,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, need_to_open_file =3D log_flags && (!is_daemonized() || filename); =20 if (logfile && !need_to_open_file) { - qatomic_rcu_set(&qemu_logfile, NULL); + qatomic_rcu_set(&global_file, NULL); call_rcu(logfile, qemu_logfile_free, rcu); return; } @@ -219,7 +219,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, =20 logfile =3D g_new0(QemuLogFile, 1); logfile->fd =3D fd; - qatomic_rcu_set(&qemu_logfile, logfile); + qatomic_rcu_set(&global_file, logfile); } } =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798241; cv=none; d=zohomail.com; s=zohoarc; b=n/C/XmG77CLHScwgFRCjICbJIst9JQ2EmZCjo1ZIB8TiMepKYf7NoZZQ5Qt8QrZKs4Cx78vrAIzxUn1qdSIaQ1AqWkx/An+YmrPVXxh4jYvEpaRdSSiPL8iLba12vjI3DZotiONfsjakm87aeZMZNWbFGFvAXUBScgTIVTo+4tA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798241; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=djzZiLuHHr1dL1YPwKuuIKcK6Xvam7Lxv67yyC1ECSo=; b=MKEc3HZkBxcypb+oCBYXokxvi+OZbqMaGLcX6eCWxSJhtLzk6uSgiTTWUwhkjETgGo+yGn/ZUMzOAgljSa16Zq0/Kg24X51auvhts3/qzZZJCC+fRv5qUxXvRe41hlM+W4/V24nRIHEnIBjC4RfN1w5Lh1ZOl+gw1ewJmLKCDPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798241264130.5713142608131; Sun, 20 Mar 2022 10:44:01 -0700 (PDT) Received: from localhost ([::1]:60362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzay-0000gw-Dr for importer@patchew.org; Sun, 20 Mar 2022 13:44:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz67-0000QM-TH for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:07 -0400 Received: from [2607:f8b0:4864:20::62d] (port=42804 helo=mail-pl1-x62d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz66-0003W6-DK for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:07 -0400 Received: by mail-pl1-x62d.google.com with SMTP id p17so10876873plo.9 for ; Sun, 20 Mar 2022 10:12:06 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=djzZiLuHHr1dL1YPwKuuIKcK6Xvam7Lxv67yyC1ECSo=; b=Wy13zcjzhRw/UmQnsSco9nDFFjzFjYfWT1KH3Gh6A4G8t/b57AIgVHIj3iXoxzJEou 0E4OVjOV5P1NFKaqsYg7tNzHymvGfw4R6VIRS9tUUGjf/sSPnc9zObzqrDEkan8UgLGw Du5xr7uzYBQdIBxaUDvBOkx19rsDs+ZRUH/8FVM7gvKhrjjldxzsZ0eirS44birEfSBm 1ssgYAzLT6yHOFf7kJfFlAc893zehOiazsLdmOT5X3JFtKeJoCLNwHITQzJqjGLbgYqq 2xhXmVjOafJBuD10h4rqy+eoyx7gPnF4LdqjceEkSVNMQA3k5KpGIzk9tBhNQg+yDPVN 1YvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=djzZiLuHHr1dL1YPwKuuIKcK6Xvam7Lxv67yyC1ECSo=; b=rgZwjVF+Uuoy4kPQQjil6ZytMro615g90IJpXbs+KEUfKoDWkv/7RiuYgMr+oZxw0G Za9rtcTHWqZC08GRN/cfDs7iNrAeusE2H2BVIYbG9/mxm0mJhd59k/e3W86M6VWMv85+ 5NKghzLoDJgsPZEsvZTWOqXkzK9PxOVSqCY56Y2YsT8BymfeuFN2MbPRhDoVQZsNszuV a2rLalMp1+dHn6igoiEdpicUmXh1r/7/gjneaWsuqoqYmM1A/YpjqQw1MsLk+YwXFvRS BVY8gMroCquND8QgPsGcyS48CNAUY8fxq3jxujcrPAMU7yNG41jA6KVcasgHoap+fnUk pAsw== X-Gm-Message-State: AOAM532VaDBXCoRnZberXA2Jn6x8IrQ+Y1pjtB3jkJNaa4N15k78jghO bkOMlGdqrJ/oYUlDQ+9WJSoLCZ2WmFD5fQ== X-Google-Smtp-Source: ABdhPJyqv39waDqbKopvIIWFBM6D+Tdraz8E5bb338HbMOh9o6Gag8AzWdSpLByBEB1HgfrTDRgVyQ== X-Received: by 2002:a17:902:c949:b0:154:5215:1db1 with SMTP id i9-20020a170902c94900b0015452151db1mr2223793pla.163.1647796325188; Sun, 20 Mar 2022 10:12:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 31/36] util/log: Rename qemu_logfile_mutex to global_mutex Date: Sun, 20 Mar 2022 10:11:30 -0700 Message-Id: <20220320171135.2704502-32-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798243867100001 Content-Type: text/plain; charset="utf-8" Rename to emphasize this covers the file-scope global variables. Signed-off-by: Richard Henderson --- util/log.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/util/log.c b/util/log.c index 0676ce5bd6..42b13e6bf1 100644 --- a/util/log.c +++ b/util/log.c @@ -34,9 +34,11 @@ typedef struct QemuLogFile { FILE *fd; } QemuLogFile; =20 +/* Mutex covering the other global_* variables. */ +static QemuMutex global_mutex; static char *global_filename; -static QemuMutex qemu_logfile_mutex; static QemuLogFile *global_file; + int qemu_loglevel; static int log_append =3D 0; static GArray *debug_regions; @@ -110,9 +112,9 @@ int qemu_log(const char *fmt, ...) return ret; } =20 -static void __attribute__((__constructor__)) qemu_logfile_init(void) +static void __attribute__((__constructor__)) startup(void) { - qemu_mutex_init(&qemu_logfile_mutex); + qemu_mutex_init(&global_mutex); } =20 static void qemu_logfile_free(QemuLogFile *logfile) @@ -132,7 +134,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, bool need_to_open_file; QemuLogFile *logfile; =20 - QEMU_LOCK_GUARD(&qemu_logfile_mutex); + QEMU_LOCK_GUARD(&global_mutex); logfile =3D global_file; =20 if (changed_name) { --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798302; cv=none; d=zohomail.com; s=zohoarc; b=GgcCBmOXDWEwqeST002q4JvOi++FzfvzJgfT2Jf9xUn+eglPOYTwm57+lTWJnmURX9lKYS0l8w7XHDhXBFt4mNpNRjHHsAci5xEApvWa68t9W1Bk0nbSLHJycPm27Vx3/mDD5bIHdMBvFyGdP6o0QiJ8xAIkmxM8LExzm/+ISH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798302; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gCBSdMHIZY9oTeXD1kIq/kpHPvmFkpcjsrAAZS31tWY=; b=V4EceoSxFzdapPmt1QWGqIwMD1my4sfxbj1gL36RqDY7kKynTv1+qv2Dr3Ez+F0QjQhkfksCEOS6Fw/ICr7fLTCYtFy2TW8m4BLxUL8s48mS84guN5TCGaJdNbhflibXb6QsWGAR5f1YhPvuXS0hzPbRsIOlFnxjnKB5hCjDsdU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798302242800.2214352396746; Sun, 20 Mar 2022 10:45:02 -0700 (PDT) Received: from localhost ([::1]:32820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzbx-0001AP-3i for importer@patchew.org; Sun, 20 Mar 2022 13:45:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz68-0000TM-W7 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:11 -0400 Received: from [2607:f8b0:4864:20::531] (port=37783 helo=mail-pg1-x531.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz67-0003WJ-Ae for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:08 -0400 Received: by mail-pg1-x531.google.com with SMTP id bc27so8737071pgb.4 for ; Sun, 20 Mar 2022 10:12:06 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gCBSdMHIZY9oTeXD1kIq/kpHPvmFkpcjsrAAZS31tWY=; b=B/shiz6qIymYhuvpj6wTahnrzdecbRNJ+ZyCC4mKOhd73lbUjNyp3v5htkzLKYMpWN LvSLdaU/Xvbd+QZr+7uVZvNj1Y4c3QJIRGruq2fWYjkwCwlsNjIoPyTdFt43RUKP0/2G Ju+p2iVUIVmUIYjAZa7yNXPFKLNyDq0ClJcQoLlWAwBMe1NVbi6Ej5Mb7ntHIe31uhTt hIy8g3PRQMQCO/hW9UH1uJgpYfkHOBNWtD09yfRtVtFwR4qpl83+r+iwNzfl6BEKFcyn DY1/MKnDK2xukst25SVKYk+8Np2FhIDRv8DeLwl5CtmTrv2xQs21Bll0kOLVu0tQjRgb Ct+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gCBSdMHIZY9oTeXD1kIq/kpHPvmFkpcjsrAAZS31tWY=; b=2O2QAI1X1tTlo/jdXgFv15oMKPPPfVq3ntZiEx3/WAKvTzIEOmMsQPJ8jLSk31idT2 N0f0BI7ifrok59JjIrUxMolO83RD2/NZ63oCvZT4MyIEyWaxsFXpcCh90fI+sgWouIjp dnKFklA+l85AcJXhpr6TjY2pDjYhq1tIEuHra6gKaPSg85ylsxRr016i2j2ag6oNzOgo 3+oVFu1aMRbThY00PzD/PYJ7GpQ77VT6mMFhT8c+WIgR7cn82eTySu7UQ+kr91gyAAyt Q7/KwldOysOFvyR7ZJLehNwt/Gzff8T9KdAinCJ1UbPWIjmhUzv4fRR6E/UnPjDdEk00 W89g== X-Gm-Message-State: AOAM533RXVTtP7B5iMh8ahwDTYHNZZpvDgiDMkQtQ70upkSIT+U+JK07 ZCtY2DXfPKgDHV3I5ViuYAJwZmfq0G7uyQ== X-Google-Smtp-Source: ABdhPJxFLaCvbxeG/crmb68sDqDsdkXWvSxcOYNEmJJZsI4HXJuJlSFdC54mQBAjsddWt/HKxZfrSA== X-Received: by 2002:a63:1223:0:b0:381:32e6:e56b with SMTP id h35-20020a631223000000b0038132e6e56bmr15007259pgl.375.1647796326031; Sun, 20 Mar 2022 10:12:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 32/36] util/log: Hoist the eval of is_daemonized in qemu_set_log_internal Date: Sun, 20 Mar 2022 10:11:31 -0700 Message-Id: <20220320171135.2704502-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::531 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798304122100001 Content-Type: text/plain; charset="utf-8" Only call is_daemonized once. We require the result on all paths after this point. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/log.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/util/log.c b/util/log.c index 42b13e6bf1..f1f6d09c90 100644 --- a/util/log.c +++ b/util/log.c @@ -132,6 +132,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, int log_flags, Error **errp) { bool need_to_open_file; + bool daemonized; QemuLogFile *logfile; =20 QEMU_LOCK_GUARD(&global_mutex); @@ -187,7 +188,8 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, * or to a file (if there is a filename). * If we are daemonized, we will only log if there is a filename. */ - need_to_open_file =3D log_flags && (!is_daemonized() || filename); + daemonized =3D is_daemonized(); + need_to_open_file =3D log_flags && (!daemonized || filename); =20 if (logfile && !need_to_open_file) { qatomic_rcu_set(&global_file, NULL); @@ -205,7 +207,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, return; } /* In case we are a daemon redirect stderr to logfile */ - if (is_daemonized()) { + if (daemonized) { dup2(fileno(fd), STDERR_FILENO); fclose(fd); /* This will skip closing logfile in qemu_logfile_free. */ @@ -213,7 +215,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, } } else { /* Default to stderr if no log file specified */ - assert(!is_daemonized()); + assert(!daemonized); fd =3D stderr; } =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647799104; cv=none; d=zohomail.com; s=zohoarc; b=aK+PWIXBP1I5PuSOnSZ5mKPKMYJF86naIZucUzLBTscK9LUeTOZ0bxg59xjYLuTLF3DNpjQ7rqCPFPqUM/SV8QOPtJ+69LPussKyTkMUfp5OPx2QI8Mz9yy4Xyhx0w1Hu7Q/DqcDHhf5ardaPzh0z8xmsTX+p5aUASJIS/3mzXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647799104; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x13T9/TUVJR5WOXUIsAjX0bOPDpTDGONzFnTqPFV7QM=; b=W9+UXTi1RjDfZTm1FikafDbPPMZN22pRZmN1PlGSr7KDywondHul5JA0ewrmq1wcQdYM9djjfVoFTH2Fh8nbJrVpttFZFv1BPvzp65Jdi2xAqHu4dUit4lv9rDtgnVUi8jpBmgQIpydJX2PirrRscwAUqaEGlep67QJHryZjyRI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647799104618820.9294570959637; Sun, 20 Mar 2022 10:58:24 -0700 (PDT) Received: from localhost ([::1]:56188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzot-0000al-Bt for importer@patchew.org; Sun, 20 Mar 2022 13:58:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz69-0000UB-W2 for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:11 -0400 Received: from [2607:f8b0:4864:20::529] (port=45992 helo=mail-pg1-x529.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz68-0003WY-Dg for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:09 -0400 Received: by mail-pg1-x529.google.com with SMTP id o13so8738411pgc.12 for ; Sun, 20 Mar 2022 10:12:07 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x13T9/TUVJR5WOXUIsAjX0bOPDpTDGONzFnTqPFV7QM=; b=N/rjaEk8feoQityhP/wli9aTjqe5JbWSn402XOk8mY5MeLJW4YLB23tM321QnAdC+K OpifwMWfYSSbexIszPRtvpyMxOuh8042aeUvHtgqfRZlIfMardfFvnRI3FqlS8Z64a47 bkVC2IiFHGF51CHrQQoP/dcTETZcXYIRJkVIdBRJKYf/NAWgGTzVHj7hmA/E1mE8Hb2H k2nH6JWKCNGa7qPfz5THtVMxjluxL567PhvuK8jn7rdMw1z5ozweYBHUL5wdaA2Zo5oR 13aHM6UdGRDEr0eiZa7/thTsTA8ndeXKJqL70hjNXDKV4dsmXS1j0TIq1vlI1VUYMojP 4gIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x13T9/TUVJR5WOXUIsAjX0bOPDpTDGONzFnTqPFV7QM=; b=QcMw9LpGoeZsX3jsvDNjtQINAGAQEdwlShQZN1xD6BHTdx32+4JQS14lNW0PFU+ckA uXdP/iIDLR0Y4RIY9cvO3YPAcNlfe4fNUa8A8M/MOowuc9QG/1WzeaXv2bKJ2l+Ns91K Pi3qlzubGm6pdKMdpNtf4tx7TloLbHqo4fPM2k8ayZIiQX9QKZ2d6lEiLJieB1M/wEkc 2+BEY+qA/DEqoqK7lsMx9MldS70RHEsl8N30ISTKB41YZKBzb+wnsyEJDShLuPBWjTqj vrrLDlv8aXmw8kn/WQwfG6bxIqQCbBYlhbTTXRRSmmWp2Fmxg6J0ogfsRGdetKme38Cm b4IQ== X-Gm-Message-State: AOAM530IIayzEpsNeQhiVaMpZEcSWMBzcf0iZvLJSApAJa4v9aDmpABh 3CNH6QRWpu5kW7QPry4M2Eyx+JwOq9cOZw== X-Google-Smtp-Source: ABdhPJyYMYqESflmF/wBkpDCpxb6PeDHnTmTk6WI5EZcLBRWjTTUQbszfCv7LklMId58nwhg9m4/2A== X-Received: by 2002:a63:ad4d:0:b0:378:4b82:b881 with SMTP id y13-20020a63ad4d000000b003784b82b881mr15525869pgo.282.1647796327064; Sun, 20 Mar 2022 10:12:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 33/36] util/log: Combine two logfile closes Date: Sun, 20 Mar 2022 10:11:32 -0700 Message-Id: <20220320171135.2704502-34-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::529 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647799105012100001 Content-Type: text/plain; charset="utf-8" Merge the close from the changed_name block with the close from the !need_to_open_file block. Signed-off-by: Richard Henderson --- util/log.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/util/log.c b/util/log.c index f1f6d09c90..596de0050f 100644 --- a/util/log.c +++ b/util/log.c @@ -166,12 +166,6 @@ static void qemu_set_log_internal(const char *filename= , bool changed_name, g_free(global_filename); global_filename =3D newname; filename =3D newname; - - if (logfile) { - qatomic_rcu_set(&global_file, NULL); - call_rcu(logfile, qemu_logfile_free, rcu); - logfile =3D NULL; - } } else { filename =3D global_filename; } @@ -191,11 +185,12 @@ static void qemu_set_log_internal(const char *filenam= e, bool changed_name, daemonized =3D is_daemonized(); need_to_open_file =3D log_flags && (!daemonized || filename); =20 - if (logfile && !need_to_open_file) { + if (logfile && (!need_to_open_file || changed_name)) { qatomic_rcu_set(&global_file, NULL); call_rcu(logfile, qemu_logfile_free, rcu); - return; + logfile =3D NULL; } + if (!logfile && need_to_open_file) { FILE *fd; =20 --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798704; cv=none; d=zohomail.com; s=zohoarc; b=PRmMGmSrx3k/GbbJbLylTYa+xldHxGiz+u/8FEUumE8pIGukxzzXzc3TwUQXUuHcCpFRU7SP+P3CUEthXbzI+sdH3t+LPRpmIA9jzfqM8X+jo7UaeivYCiblBcmqLSgeiNd8Dj+T40K6HwmcTrP7k7o3MpdZK6JOG86q/olZ37I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798704; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HX+XPB3fiJw2JeMEDh6SpA1VcXxzUSznHfCOQKqLolk=; b=fBGEGMqQ8UCNHdzmKddJ53VR9uLlqVuA1+IMpG9XjMlv68Ythr2J0LVadpwG1iW0feddLI/9E37Be+U+tSCwnBiyq1YvxkD7oYNfCWa2iLvw+NZArpFtOcnHtPuZulraG0ei6Hwy9v2BHMe9FyUSMQ0KRdcUz07IyeYnexpi8R4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164779870422812.567176715677192; Sun, 20 Mar 2022 10:51:44 -0700 (PDT) Received: from localhost ([::1]:40752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVziQ-0006sA-NU for importer@patchew.org; Sun, 20 Mar 2022 13:51:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz6B-0000UE-9V for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:12 -0400 Received: from [2607:f8b0:4864:20::434] (port=37575 helo=mail-pf1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz69-0003Wr-EE for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:11 -0400 Received: by mail-pf1-x434.google.com with SMTP id t5so13673775pfg.4 for ; Sun, 20 Mar 2022 10:12:09 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HX+XPB3fiJw2JeMEDh6SpA1VcXxzUSznHfCOQKqLolk=; b=DjlLVb6GZCbSdFyEw0mXZZ4IMhKbhvPFBlTIeATr1n7nBqJ9834Zr+Q6ohGOQAi7A+ HSdW0LkSzZTjgspWWu/UtluSQM7FwF0YAORM2RrPc9jWWMnQ4ng9YhU2RL5lqRt2NeJK Rx6GEINtOOoro5qlC5oBVIb9/fEn+4oGrCGPOCBtbXysamsJ79IRuQTLXyjHHKpdQRSm PA/Y2IHLaSeYlf92lDDiLocFJQspKfrE5hP7AC6vuYusAsAGEW06pbWHRaZ30VQRKFtr HarbMetHhNtxjoXBi10ymy/KprCvpvRgwlmUWPKzp3M2YlaQgMKox9Fi95hogUi8uzX0 NTCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HX+XPB3fiJw2JeMEDh6SpA1VcXxzUSznHfCOQKqLolk=; b=oKZc2+Eyt5RJawXvCL2++gVmW1UOXDGq+/VNueTsI0nS9uQzrafwdMGluQd1PyyBXU lvmQT3IYMmqoBAvyLwVWelF2Bcvxn4uHrHnOxWt7HQK0a00DxFPQfRkGKUltYtsC7WY2 xKnu5Nscl812qUr17qnNoY7AfYk5TBFznbV5iSx94Cxb1/eXsTqcM7id9hkPfhznVarI fvAx3vOcOMXZZyAQXubBsMhrIJsWlLorANC3WoThttc7dHmGL0f1ZJBn4V9mc1prFm45 K5bljLDVg/XMSPgmc60UStcFs5R1Tj+uvbs+pp+K7ixJ8AlzpOiNYwc5ndIGwBrC2sTV 2L6g== X-Gm-Message-State: AOAM530rW+Axx6jBdC37woWEO9HKO1liTnTa63pl2s5/PuTYCgLli7sg 0Fw/GaZWkoMJD8qv2aD+NCxVnjTi6m+BPQ== X-Google-Smtp-Source: ABdhPJzfb4BOWi080JrA0+dVOrCPKTwdsMTOgfPZu8JOHJXt8eCmxMTWTZWPh2ofHcee9Z3RTw7blg== X-Received: by 2002:a63:2259:0:b0:382:294c:5bee with SMTP id t25-20020a632259000000b00382294c5beemr10779401pgm.387.1647796327912; Sun, 20 Mar 2022 10:12:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 34/36] util/log: Rename QemuLogFile to RCUCloseFILE Date: Sun, 20 Mar 2022 10:11:33 -0700 Message-Id: <20220320171135.2704502-35-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::434 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798706827100001 Content-Type: text/plain; charset="utf-8" s/QemuLogFile/RCUCloseFILE/ s/qemu_logfile_free/rcu_close_file/ Emphasize that this is only a carrier for passing a pointer to call_rcu for closing, and not the real logfile. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/log.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/util/log.c b/util/log.c index 596de0050f..e966d1091d 100644 --- a/util/log.c +++ b/util/log.c @@ -29,15 +29,15 @@ #include "qemu/rcu.h" =20 =20 -typedef struct QemuLogFile { +typedef struct RCUCloseFILE { struct rcu_head rcu; FILE *fd; -} QemuLogFile; +} RCUCloseFILE; =20 /* Mutex covering the other global_* variables. */ static QemuMutex global_mutex; static char *global_filename; -static QemuLogFile *global_file; +static RCUCloseFILE *global_file; =20 int qemu_loglevel; static int log_append =3D 0; @@ -52,7 +52,7 @@ bool qemu_log_enabled(void) /* Returns true if qemu_log() will write somewhere other than stderr. */ bool qemu_log_separate(void) { - QemuLogFile *logfile; + RCUCloseFILE *logfile; bool res =3D false; =20 rcu_read_lock(); @@ -68,7 +68,7 @@ bool qemu_log_separate(void) =20 FILE *qemu_log_lock(void) { - QemuLogFile *logfile; + RCUCloseFILE *logfile; =20 rcu_read_lock(); logfile =3D qatomic_rcu_read(&global_file); @@ -117,14 +117,12 @@ static void __attribute__((__constructor__)) startup(= void) qemu_mutex_init(&global_mutex); } =20 -static void qemu_logfile_free(QemuLogFile *logfile) +static void rcu_close_file(RCUCloseFILE *r) { - g_assert(logfile); - - if (logfile->fd !=3D stderr) { - fclose(logfile->fd); + if (r->fd !=3D stderr) { + fclose(r->fd); } - g_free(logfile); + g_free(r); } =20 /* enable or disable low levels log */ @@ -133,7 +131,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, { bool need_to_open_file; bool daemonized; - QemuLogFile *logfile; + RCUCloseFILE *logfile; =20 QEMU_LOCK_GUARD(&global_mutex); logfile =3D global_file; @@ -187,7 +185,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, =20 if (logfile && (!need_to_open_file || changed_name)) { qatomic_rcu_set(&global_file, NULL); - call_rcu(logfile, qemu_logfile_free, rcu); + call_rcu(logfile, rcu_close_file, rcu); logfile =3D NULL; } =20 @@ -205,7 +203,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, if (daemonized) { dup2(fileno(fd), STDERR_FILENO); fclose(fd); - /* This will skip closing logfile in qemu_logfile_free. */ + /* This will skip closing logfile in rcu_close_file. */ fd =3D stderr; } } else { @@ -216,7 +214,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, =20 log_append =3D 1; =20 - logfile =3D g_new0(QemuLogFile, 1); + logfile =3D g_new0(RCUCloseFILE, 1); logfile->fd =3D fd; qatomic_rcu_set(&global_file, logfile); } --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647797806; cv=none; d=zohomail.com; s=zohoarc; b=DvySczRUAsOpLXImy5K/60PiH1d8z642+9+yvHnh3eoDNXEbxTLCsOIheG0hFlXQFMKkLvDmTyzZPk9hh+XB5+JC0h0j+n2g300HkMZp7BjEvD7z7bBs9esbb9fDc9WjWbxakikZpR01wR7OtWZhkYjplOeS44lmxsZyO7MZ4v0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647797806; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v5msDAveF1p/6j9G29fbPZtpzPMOaY2gnc7JkYmq63w=; b=cWdzQUoT3pt0cmFipZQjLsvirbToZijQDtkfo7l647ZyUevDnVOdepyB7cXJMf9vGb/egUVa2OyGB44WhD4U4WP0l4iDZ6Yep87Qd3kycqtDOR/qBVj+j7WLxQcm5sQekqolw4ZXl/GyCKbOVZ8Zv1oBMbKiiQwtdRtPkJSavsU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647797806845541.4042970547451; Sun, 20 Mar 2022 10:36:46 -0700 (PDT) Received: from localhost ([::1]:52578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzTz-0003jT-A6 for importer@patchew.org; Sun, 20 Mar 2022 13:36:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz6B-0000Ur-Us for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:13 -0400 Received: from [2607:f8b0:4864:20::433] (port=38464 helo=mail-pf1-x433.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz6A-0003X5-6c for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:11 -0400 Received: by mail-pf1-x433.google.com with SMTP id p5so7544160pfo.5 for ; Sun, 20 Mar 2022 10:12:09 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v5msDAveF1p/6j9G29fbPZtpzPMOaY2gnc7JkYmq63w=; b=PiNw5nvllji+Qd62QygTkiMoibJbavRha09GzDnTFMCVjkSnoatM0plCq4vdNKV9dO oFtdZ0gP5unXBVkvSPlronwPnMAivDU+5/H1bu6Wh1ZbD3ztjC2spW7QYEtSQvrlvG5P e42XgmAhbz4H4y3cQusolSx9k92AUBSHDJ74NslLblnoOizs8QVFXSG4wIWaYgf2oGfY GYYymBVlnLAefORFOcMq2NHKFNgsDO58oChiHgKEwcg0G9NTnzWSDL9sEPtPbjRNGw0o cZmcpNp4950xBBILEBAzqH8svektpXhJsE5+9zIOSLV+Nnod4rWinmyKqSI1x6SdNBfY YkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v5msDAveF1p/6j9G29fbPZtpzPMOaY2gnc7JkYmq63w=; b=t56xEfiA2MLU0gELd+HJuTdVwZI2NuWpLQ4f2JSRKA9N/wFvlhcWln4eGFPCMdm8Bo xh0RBzIwLsJSXnWzyeft6BJRyKZ1xOSx+lSlB654UIMRseMi79GQZrrTFrFODWR9JObD 3seze0bzBM4mXcnxh9oDOiVdaOK9rN9bHskIFt3fE8EGnoWHgv1gqUmIjQQ9i1u6PAeo use3//qJm9mgLhIRkRPOoR364Sk/t6gmfRhBxLaovsPItldCv8eggmuT7D1MEUlsKPuq EI48opR+1tti1C6T3lRRJlokQFQqamdcFS+RZppCOiRCxo56ghAmIIIKNqTv0sNwhHCf 6wgg== X-Gm-Message-State: AOAM533ZWRLzjEAy4BnEpN8mCWrI/EWENLppv7++RhcSpPI94O7h3NQf MER+MCwaKtg2divgXWRd5aKCZsGTNS2oiw== X-Google-Smtp-Source: ABdhPJy9avJ8CPUjOBFIWPIJdnzOTaVo7Y48SKTVoBH31a00NSZ+DDSnhn8TafcIp8WEYVrRkf2gPg== X-Received: by 2002:a05:6a00:140c:b0:4e1:530c:edc0 with SMTP id l12-20020a056a00140c00b004e1530cedc0mr19916610pfu.18.1647796328696; Sun, 20 Mar 2022 10:12:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 35/36] util/log: Limit RCUCloseFILE to file closing Date: Sun, 20 Mar 2022 10:11:34 -0700 Message-Id: <20220320171135.2704502-36-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::433 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x433.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647797823282100001 Content-Type: text/plain; charset="utf-8" Use FILE* for global_file. We can perform an rcu_read on that just as easily as RCUCloseFILE*. This simplifies a couple of places, where previously we required taking the rcu_read_lock simply to avoid racing to dereference RCUCloseFile->fd. Only allocate the RCUCloseFile prior to call_rcu. Signed-off-by: Richard Henderson --- util/log.c | 67 +++++++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 39 deletions(-) diff --git a/util/log.c b/util/log.c index e966d1091d..713a0744be 100644 --- a/util/log.c +++ b/util/log.c @@ -37,7 +37,7 @@ typedef struct RCUCloseFILE { /* Mutex covering the other global_* variables. */ static QemuMutex global_mutex; static char *global_filename; -static RCUCloseFILE *global_file; +static FILE *global_file; =20 int qemu_loglevel; static int log_append =3D 0; @@ -46,46 +46,37 @@ static GArray *debug_regions; /* Returns true if qemu_log() will really write somewhere. */ bool qemu_log_enabled(void) { - return global_file !=3D NULL; + return qatomic_read(&global_file) !=3D NULL; } =20 /* Returns true if qemu_log() will write somewhere other than stderr. */ bool qemu_log_separate(void) { - RCUCloseFILE *logfile; - bool res =3D false; - - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&global_file); - if (logfile && logfile->fd !=3D stderr) { - res =3D true; - } - rcu_read_unlock(); - return res; + FILE *logfile =3D qatomic_read(&global_file); + return logfile && logfile !=3D stderr; } =20 /* Lock/unlock output. */ =20 FILE *qemu_log_lock(void) { - RCUCloseFILE *logfile; + FILE *logfile; =20 rcu_read_lock(); logfile =3D qatomic_rcu_read(&global_file); if (logfile) { - qemu_flockfile(logfile->fd); - return logfile->fd; + qemu_flockfile(logfile); } else { rcu_read_unlock(); - return NULL; } + return logfile; } =20 -void qemu_log_unlock(FILE *fd) +void qemu_log_unlock(FILE *logfile) { - if (fd) { - fflush(fd); - qemu_funlockfile(fd); + if (logfile) { + fflush(logfile); + qemu_funlockfile(logfile); rcu_read_unlock(); } } @@ -93,16 +84,16 @@ void qemu_log_unlock(FILE *fd) /* Return the number of characters emitted. */ int qemu_log(const char *fmt, ...) { - FILE *f =3D qemu_log_lock(); + FILE *logfile =3D qemu_log_lock(); int ret =3D 0; =20 - if (f) { + if (logfile) { va_list ap; =20 va_start(ap, fmt); - ret =3D vfprintf(f, fmt, ap); + ret =3D vfprintf(logfile, fmt, ap); va_end(ap); - qemu_log_unlock(f); + qemu_log_unlock(logfile); =20 /* Don't pass back error results. */ if (ret < 0) { @@ -119,9 +110,7 @@ static void __attribute__((__constructor__)) startup(vo= id) =20 static void rcu_close_file(RCUCloseFILE *r) { - if (r->fd !=3D stderr) { - fclose(r->fd); - } + fclose(r->fd); g_free(r); } =20 @@ -131,7 +120,7 @@ static void qemu_set_log_internal(const char *filename,= bool changed_name, { bool need_to_open_file; bool daemonized; - RCUCloseFILE *logfile; + FILE *logfile; =20 QEMU_LOCK_GUARD(&global_mutex); logfile =3D global_file; @@ -185,37 +174,37 @@ static void qemu_set_log_internal(const char *filenam= e, bool changed_name, =20 if (logfile && (!need_to_open_file || changed_name)) { qatomic_rcu_set(&global_file, NULL); - call_rcu(logfile, rcu_close_file, rcu); + if (logfile !=3D stderr) { + RCUCloseFILE *r =3D g_new0(RCUCloseFILE, 1); + r->fd =3D logfile; + call_rcu(r, rcu_close_file, rcu); + } logfile =3D NULL; } =20 if (!logfile && need_to_open_file) { - FILE *fd; - if (filename) { - fd =3D fopen(filename, log_append ? "a" : "w"); - if (!fd) { + logfile =3D fopen(filename, log_append ? "a" : "w"); + if (!logfile) { error_setg_errno(errp, errno, "Error opening logfile %s", filename); return; } /* In case we are a daemon redirect stderr to logfile */ if (daemonized) { - dup2(fileno(fd), STDERR_FILENO); - fclose(fd); + dup2(fileno(logfile), STDERR_FILENO); + fclose(logfile); /* This will skip closing logfile in rcu_close_file. */ - fd =3D stderr; + logfile =3D stderr; } } else { /* Default to stderr if no log file specified */ assert(!daemonized); - fd =3D stderr; + logfile =3D stderr; } =20 log_append =3D 1; =20 - logfile =3D g_new0(RCUCloseFILE, 1); - logfile->fd =3D fd; qatomic_rcu_set(&global_file, logfile); } } --=20 2.25.1 From nobody Sat May 18 02:06:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647798732; cv=none; d=zohomail.com; s=zohoarc; b=Fq0B0JPqmUyRhOaNCdG8H0eThhkb3JaoCXnzQCcj4sBebxmhexYxnzmvcQsE1uMRXR4nZM8nmx1jKNNJCBkDJypFdSnwWpmz10/5pHoe1LHfcOcBA/cAfLXJ6Qaqr/vw4hie/bobXB0DmZZE1YLHc5vI5eiF2coLtAS/UTUBdfg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647798732; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6BKjhVe9YK8zHmub6rTwH9wtPi9i652/xRGlwJ2BHBo=; b=G3/YjjQleJjCXd6ZZq1td8xr1hxbPL8Z/UiOsVwkVPDFxF/Dmb2nwS3stubhaOj+wGqMttqVG2OONnu4Lp0DppiC0v/ol+PeqEtsao3XgMNxf8EZzYP/vNS/0ZLYIjvEKBSc6NNqZoSOaHNeFW6gLQGpqvSdnvBu7PiwAzfG+XE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647798732451412.20506842307327; Sun, 20 Mar 2022 10:52:12 -0700 (PDT) Received: from localhost ([::1]:41410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVzit-0007JF-Er for importer@patchew.org; Sun, 20 Mar 2022 13:52:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz6C-0000V9-Sc for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:13 -0400 Received: from [2607:f8b0:4864:20::430] (port=43708 helo=mail-pf1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz6A-0003XL-Vv for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:12:12 -0400 Received: by mail-pf1-x430.google.com with SMTP id t2so13637259pfj.10 for ; Sun, 20 Mar 2022 10:12:10 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6BKjhVe9YK8zHmub6rTwH9wtPi9i652/xRGlwJ2BHBo=; b=ErDUB/8ZqoTuLoh6+Jm8ZdyvPbPilwgCSxkF/IhrBrQ968LwARoP0Zeo4drZqKwIns 6vKAF1b5xlC1Vr2o4LCEmIo9lDCo0R2+UgWwmWqYxISiM0qy1KPNv9XUkf5UO5eltFAa aqsUMLbSWEZSrW5bwP/j9SX53Xbzh03q2cZQ5BAJfoxkLYfpcd3nv/tHQfXDSAhyluNV REF3UUyWCKoprsXYBTfUc0bILcdTH/4PdcbEJ/BjmbKtnuU3LFxwMhedgNuawi9gJpQE V4j2xfDZHDPaXGkO7xO6SQ5hN+ZLoeczCYlW5UhI+83/9nHqqzBnQ5wEG8/o34Vw6InT I/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6BKjhVe9YK8zHmub6rTwH9wtPi9i652/xRGlwJ2BHBo=; b=sDZrvs3tcIeatUjGifzR6aMPbnDKnpOmg1YhgIqIMIyjqHwkBL9shwSXdYSniFSVCu +O/O3Rd2AikoITRNe3QRhfPPiZOcq6p2leBH6CnUxQ0aIcmtdCU9XBAM6fULYOhQj0RU VsYik0ezlh/ap+2ZV5Q315caGRjMx9jCUrY3a7yz0oKUty+iIIrIlEewBMSOnR1Ee+4c aXuTY3miarRt/zXVEDKST6ZJg1DbOQF8WggTLIH5NKPlGtSBJl5Lugz2XPKGfX/hv55t yB/0w0XJhrKT4JyPbi7G1xmEMxh3z2y8hkALZZmvpB26r2YmuAjfhvUp2VPiUtr/FpYZ HdzQ== X-Gm-Message-State: AOAM533fqoZQUZWN0FN3eoa88IBkzMyYYP2KHXfiWHNK00ACB1Lv0ttH 9De0lCEEM7gv5qbtoUYxMlfHo5VfUeA76g== X-Google-Smtp-Source: ABdhPJx4+yEdiODJI3HSaTOiLoO+EyKPXCL5pnmRbCyZFlkgqU0vhCzP35iEJzw0pJIgy6I1bcRBeg== X-Received: by 2002:a63:1620:0:b0:375:948e:65bf with SMTP id w32-20020a631620000000b00375948e65bfmr15541465pgl.49.1647796329664; Sun, 20 Mar 2022 10:12:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 36/36] util/log: Support per-thread log files Date: Sun, 20 Mar 2022 10:11:35 -0700 Message-Id: <20220320171135.2704502-37-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::430 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647798734566100001 Content-Type: text/plain; charset="utf-8" Add a new log flag, tid, to turn this feature on. Require the log filename to be set, and to contain %d. Do not allow tid to be turned off once it is on, nor let the filename be change thereafter. This avoids the need for signalling each thread to re-open on a name change. Signed-off-by: Richard Henderson --- include/qemu/log.h | 1 + util/log.c | 130 +++++++++++++++++++++++++++++++++++---------- 2 files changed, 103 insertions(+), 28 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 783faec309..6455e47010 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -34,6 +34,7 @@ bool qemu_log_separate(void); #define CPU_LOG_PLUGIN (1 << 18) /* LOG_STRACE is used for user-mode strace logging. */ #define LOG_STRACE (1 << 19) +#define LOG_PER_THREAD (1 << 20) =20 /* Lock/unlock output. */ =20 diff --git a/util/log.c b/util/log.c index 713a0744be..0da67c55de 100644 --- a/util/log.c +++ b/util/log.c @@ -38,22 +38,34 @@ typedef struct RCUCloseFILE { static QemuMutex global_mutex; static char *global_filename; static FILE *global_file; +static __thread FILE *thread_file; =20 int qemu_loglevel; -static int log_append =3D 0; +static bool log_append; +static bool log_per_thread; static GArray *debug_regions; =20 /* Returns true if qemu_log() will really write somewhere. */ bool qemu_log_enabled(void) { - return qatomic_read(&global_file) !=3D NULL; + return log_per_thread || qatomic_read(&global_file) !=3D NULL; } =20 /* Returns true if qemu_log() will write somewhere other than stderr. */ bool qemu_log_separate(void) { FILE *logfile =3D qatomic_read(&global_file); - return logfile && logfile !=3D stderr; + return log_per_thread || (logfile && logfile !=3D stderr); +} + +static int log_thread_id(void) +{ +#ifdef __linux__ + return gettid(); /* ??? need syscall before glibc 2.30 */ +#else + static int counter; + return qatomic_fetch_inc(&counter); +#endif } =20 /* Lock/unlock output. */ @@ -62,13 +74,27 @@ FILE *qemu_log_lock(void) { FILE *logfile; =20 - rcu_read_lock(); - logfile =3D qatomic_rcu_read(&global_file); - if (logfile) { - qemu_flockfile(logfile); - } else { - rcu_read_unlock(); + logfile =3D thread_file; + if (!logfile) { + if (log_per_thread) { + g_autofree char *filename + =3D g_strdup_printf(global_filename, log_thread_id()); + logfile =3D fopen(filename, "w"); + if (!logfile) { + return NULL; + } + thread_file =3D logfile; + } else { + rcu_read_lock(); + logfile =3D qatomic_rcu_read(&global_file); + if (!logfile) { + rcu_read_unlock(); + return NULL; + } + } } + + qemu_flockfile(logfile); return logfile; } =20 @@ -77,7 +103,9 @@ void qemu_log_unlock(FILE *logfile) if (logfile) { fflush(logfile); qemu_funlockfile(logfile); - rcu_read_unlock(); + if (!log_per_thread) { + rcu_read_unlock(); + } } } =20 @@ -114,40 +142,74 @@ static void rcu_close_file(RCUCloseFILE *r) g_free(r); } =20 +/** + * valid_filename_template: + * + * Validate the filename template. Require %d if per_thread, allow it + * otherwise; require no other % within the template. + * Return 0 if invalid, 1 if stderr, 2 if strdup, 3 if pid printf. + */ +static int valid_filename_template(const char *filename, + bool per_thread, Error **errp) +{ + if (filename) { + char *pidstr =3D strstr(filename, "%"); + + if (pidstr) { + /* We only accept one %d, no other format strings */ + if (pidstr[1] !=3D 'd' || strchr(pidstr + 2, '%')) { + error_setg(errp, "Bad logfile template: %s", filename); + return 0; + } + return per_thread ? 2 : 3; + } + } + if (per_thread) { + error_setg(errp, "Filename template with '%%d' required for 'tid'"= ); + return 0; + } + return filename ? 2 : 1; +} + /* enable or disable low levels log */ static void qemu_set_log_internal(const char *filename, bool changed_name, int log_flags, Error **errp) { bool need_to_open_file; bool daemonized; + bool per_thread; FILE *logfile; =20 QEMU_LOCK_GUARD(&global_mutex); logfile =3D global_file; =20 + per_thread =3D log_flags & LOG_PER_THREAD; + if (changed_name) { char *newname =3D NULL; =20 /* - * Allow the user to include %d in their logfile which will be - * substituted with the current PID. This is useful for debugging = many - * nested linux-user tasks but will result in lots of logs. - * - * filename may be NULL. In that case, log output is sent to stderr + * Once threads start opening their own log files, we have no + * easy mechanism to tell them all to close and re-open. + * There seems little cause to do so either -- this option + * will most often be used at user-only startup. */ - if (filename) { - char *pidstr =3D strstr(filename, "%"); + if (log_per_thread) { + error_setg(errp, "Cannot change log filename after setting 'ti= d'"); + return; + } =20 - if (pidstr) { - /* We only accept one %d, no other format strings */ - if (pidstr[1] !=3D 'd' || strchr(pidstr + 2, '%')) { - error_setg(errp, "Bad logfile format: %s", filename); - return; - } - newname =3D g_strdup_printf(filename, getpid()); - } else { - newname =3D g_strdup(filename); - } + switch (valid_filename_template(filename, per_thread, errp)) { + case 0: + return; /* error */ + case 1: + break; /* stderr */ + case 2: + newname =3D g_strdup(filename); + break; + case 3: + newname =3D g_strdup_printf(filename, getpid()); + break; } =20 g_free(global_filename); @@ -155,8 +217,17 @@ static void qemu_set_log_internal(const char *filename= , bool changed_name, filename =3D newname; } else { filename =3D global_filename; + if (per_thread && !valid_filename_template(filename, true, errp)) { + return; /* error */ + } } =20 + /* Once the per-thread flag is set, it cannot be unset. */ + if (per_thread) { + log_per_thread =3D true; + } + /* The flag itself is not relevant for need_to_open_file. */ + log_flags &=3D ~LOG_PER_THREAD; #ifdef CONFIG_TRACE_LOG log_flags |=3D LOG_TRACE; #endif @@ -165,12 +236,13 @@ static void qemu_set_log_internal(const char *filenam= e, bool changed_name, /* * In all cases we only log if qemu_loglevel is set. * Also: + * If per-thread, open the file for each thread in qemu_log_lock. * If not daemonized we will always log either to stderr * or to a file (if there is a filename). * If we are daemonized, we will only log if there is a filename. */ daemonized =3D is_daemonized(); - need_to_open_file =3D log_flags && (!daemonized || filename); + need_to_open_file =3D log_flags && !per_thread && (!daemonized || file= name); =20 if (logfile && (!need_to_open_file || changed_name)) { qatomic_rcu_set(&global_file, NULL); @@ -355,6 +427,8 @@ const QEMULogItem qemu_log_items[] =3D { #endif { LOG_STRACE, "strace", "log every user-mode syscall, its input, and its result" }, + { LOG_PER_THREAD, "tid", + "open a separate log file per thread; filename must contain '%d'" }, { 0, NULL, NULL }, }; =20 --=20 2.25.1