From nobody Sat May 18 03:21:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1647304010; cv=none; d=zohomail.com; s=zohoarc; b=lC4b6U5oVX6TaIH/tfrF0EiFt0afFMJVUNN89wxf1SQHnPYEm0xYWEFBM5nFT3CvzTZcJfglqzNHvHya5G8KiShFThvmzy381kQ3rtdYigeSQN49dZX/aRWQ+vXW0953AIQv2J1cW2hgRH+msWvulkMRzH2LnqXKhATKGNA57SA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647304010; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=0P+G5wofUd4lFLgDTWOBTe9TXR2dgYzNF2PGbDd1RLU=; b=YIKVgmvle0iXXz4Nxi8ZO0Ie9mteSdQdOws0pOdEZxv6rRvz5byknJhQ62TKXHGUQc8pvTrjv8n5Vhue9OgQH74+dSIYRziLGsL6j+tcYEMDmU3oJN+5TKFbJ14wY4qt6i+bolaKd0S9RzedchWIjQUMSiEm69CyRlpZaYfdoYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647304009993469.6888009310909; Mon, 14 Mar 2022 17:26:49 -0700 (PDT) Received: from localhost ([::1]:60814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTv1T-000413-S9 for importer@patchew.org; Mon, 14 Mar 2022 20:26:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTuzv-0003Cw-CP for qemu-devel@nongnu.org; Mon, 14 Mar 2022 20:25:11 -0400 Received: from [2607:f8b0:4864:20::102c] (port=51045 helo=mail-pj1-x102c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTuzt-0001PR-Cc for qemu-devel@nongnu.org; Mon, 14 Mar 2022 20:25:10 -0400 Received: by mail-pj1-x102c.google.com with SMTP id m22so16371387pja.0 for ; Mon, 14 Mar 2022 17:25:08 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id c18-20020a056a000ad200b004f0f9696578sm24387821pfl.141.2022.03.14.17.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 17:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0P+G5wofUd4lFLgDTWOBTe9TXR2dgYzNF2PGbDd1RLU=; b=zAzvXXXIUI5k01VOgsaHNVrs5faXPXpFSyyDqjRK9hR4Nkj+g6NFhE3dxpBAv5Yy/d qRzLI1WTypOZtbXxcX96NE/stG0ZiSoTFMAKx01riNXu5xKq7CNykrIWE9hiZvhaoklV u5Za+kYnl6Fn4JIHaZrESdqZV7DJmkBBnYuv7k81E6dYxNSPIViq7yGYDY34t/mg+9WV zokuYYzl2WYBU4ixTyFgglWADMQhxBOgqMsMWFX+x2pL04z/VgsRJg11qs4KILR17yBS goG/E0Gb/eM5YjUwYz4zWFah/utiLxzXuWziCZUt9Jnkkn8U97FzcdLT29h8iHIzcMI4 HNlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0P+G5wofUd4lFLgDTWOBTe9TXR2dgYzNF2PGbDd1RLU=; b=GEwJgiZztEWCAmwWGmCn8f6aSKNMtYL/b6vSFB1HpJjg/Elv+rvXNOy2LF4b4GJIwQ K2Nuah5LtA1kKO3ASCrqN7gk7gv1Rpfi26m5CB6XlR6w7UAU2UrjwO45qldL2Z69j+DA sbLusUMGjpOwgPbTRofJps2VWbK7doPvRnf8GbQ7oV1s9mkykqNk7h3FevUUekwY2hFL GAY1RTIM8vfY8iPabEiSCMtxTvZ1ZJaj1PX7RLQuLXweQ8Hr8pP5sTOFNolwtsz9nMNQ KLKZUZV0b6h+lMExkWVQhjJFbFQATZln6jjL7CFysrgnLDzMfdQ1GnD8dxklQ7O0GhJo F8Ew== X-Gm-Message-State: AOAM531NlZ4Ls0PoGgSaQJzho6E4mPapkMcZTcb89CPabio4zwiwM27B vk9MWaV+iFufHaF9t3t++P41g2abQW0kSw== X-Google-Smtp-Source: ABdhPJwK2DSLcK/qcNEEpsXZqeWYJCdZyHqcvxbc5B1uF0VC71SdDoVnCm6EufcrDRSzPjTdg9xWtg== X-Received: by 2002:a17:902:8c81:b0:153:4a6a:52c8 with SMTP id t1-20020a1709028c8100b001534a6a52c8mr13110971plo.120.1647303907647; Mon, 14 Mar 2022 17:25:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH] accel/tcg: Fix cpu_ldq_be_mmu typo Date: Mon, 14 Mar 2022 17:25:06 -0700 Message-Id: <20220315002506.152030-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102c (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1647304011455100001 Content-Type: text/plain; charset="utf-8" In the conversion to cpu_ld_*_mmu, the retaddr parameter was corrupted in the one case of cpu_ldq_be_mmu. Cc: Thomas Huth Resolves: https://gitlab.com/qemu-project/qemu/-/issues/902 Fixes: f83bcecb1 ("accel/tcg: Add cpu_{ld,st}*_mmu interfaces") Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Thomas Huth --- This really should have affected all big-endian guests regardless of the host. I have no idea how the referenced test case fails on s390x and ppc64le hosts, but passes on x86_64 host. r~ --- accel/tcg/cputlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 3b918fe..2035b2a 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -2174,7 +2174,7 @@ uint32_t cpu_ldl_be_mmu(CPUArchState *env, abi_ptr ad= dr, uint64_t cpu_ldq_be_mmu(CPUArchState *env, abi_ptr addr, MemOpIdx oi, uintptr_t ra) { - return cpu_load_helper(env, addr, oi, MO_BEUQ, helper_be_ldq_mmu); + return cpu_load_helper(env, addr, oi, ra, helper_be_ldq_mmu); } =20 uint16_t cpu_ldw_le_mmu(CPUArchState *env, abi_ptr addr, --=20 1.8.3.1