From nobody Mon Feb 9 20:10:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1647266905275540.9113446311216; Mon, 14 Mar 2022 07:08:25 -0700 (PDT) Received: from localhost ([::1]:47938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTlN2-0002YI-Hs for importer@patchew.org; Mon, 14 Mar 2022 10:08:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTktB-0006xF-4w for qemu-devel@nongnu.org; Mon, 14 Mar 2022 09:37:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkt0-0001dK-TL for qemu-devel@nongnu.org; Mon, 14 Mar 2022 09:37:32 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-88-Jrolv5bEPKKC8wbAUGG9ug-1; Mon, 14 Mar 2022 09:37:18 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3FA9E1881214; Mon, 14 Mar 2022 13:37:18 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2007403144; Mon, 14 Mar 2022 13:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647265042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W+UQVjK0peqv17Kl6wC6mjEXPSXSCrhRd6ktu3ciUnM=; b=Dy6/FM8zkSXIu+tDC1BmSclIC2KzU/rb10mnGeFOfGSMz3wbmBiOyfEyij3qBt8PSJsqAi 2/o2PDr29hsY8Vx4QeSqWXQOGGorWg0dJwb5ihjxYec/PH7vBCiC6uT8jzScyqqCLaGRxS bJYvvurJP51ilhJsil8pU1PQ916L2/o= X-MC-Unique: Jrolv5bEPKKC8wbAUGG9ug-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v6 14/18] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext Date: Mon, 14 Mar 2022 09:37:03 -0400 Message-Id: <20220314133707.2206082-15-eesposit@redhat.com> In-Reply-To: <20220314133707.2206082-1-eesposit@redhat.com> References: <20220314133707.2206082-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Emanuele Giuseppe Esposito , Markus Armbruster , qemu-devel@nongnu.org, Hanna Reitz , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1647266907606100001 Content-Type: text/plain; charset="utf-8" We are always using the given bs AioContext, so there is no need to take the job ones (which is identical anyways). This also reduces the point we need to check when protecting job.aio_context field. Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito --- block/commit.c | 4 ++-- block/mirror.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/commit.c b/block/commit.c index c76899f640..99dfc1dacd 100644 --- a/block/commit.c +++ b/block/commit.c @@ -369,7 +369,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, goto fail; } =20 - s->base =3D blk_new(s->common.job.aio_context, + s->base =3D blk_new(bdrv_get_aio_context(bs), base_perms, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED); @@ -381,7 +381,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, s->base_bs =3D base; =20 /* Required permissions are already taken with block_job_add_bdrv() */ - s->top =3D blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL); + s->top =3D blk_new(bdrv_get_aio_context(bs), 0, BLK_PERM_ALL); ret =3D blk_insert_bs(s->top, top, errp); if (ret < 0) { goto fail; diff --git a/block/mirror.c b/block/mirror.c index a7c3bab382..8a975537c0 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1727,7 +1727,7 @@ static BlockJob *mirror_start_job( goto fail; } =20 - s->target =3D blk_new(s->common.job.aio_context, + s->target =3D blk_new(bdrv_get_aio_context(bs), target_perms, target_shared_perms); ret =3D blk_insert_bs(s->target, target, errp); if (ret < 0) { --=20 2.31.1