From nobody Sun Feb 8 18:29:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1646571663; cv=none; d=zohomail.com; s=zohoarc; b=FtsJIAnJwZ789EYt4iOoQGiDVl+LFx/lxCvRAZsizCZVaL2oaTpDs1WQLwyCvYH4LTetA0Bl0WtE+2Nn65HPMV7Tj+abPHU28pAn45xqumWaocaV1zpU57wqkD7H7/OCzMcgr6grYL91f536dxUT7H6gtXARGdw7z/+HI6von7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646571663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=zwXjzSzsl8TDGlKONbb5aSOhR7jvYd4YRdrKNrb6iSw=; b=YwBkhaNOAerWrkbxfZQsOL4CEmmLd1PZ3nhBmIdQFbxww6YQkQMWRWM/kfNbIldWAapwfTxhwZtdHYJIzglKghYHTK2SAle9X0yEM4u35NclIIWY29dvkoqNx/KZW/2SOhmExopCLkK14udrRSRzUTAeuUoIw1ZDdKnb78og7v8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=pass header.from= (p=none dis=none) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1646571663916550.6353470485495; Sun, 6 Mar 2022 05:01:03 -0800 (PST) Received: by mail-wm1-f52.google.com with SMTP id i66so7632564wma.5 for ; Sun, 06 Mar 2022 05:01:03 -0800 (PST) Return-Path: Return-Path: Received: from nuc.lan ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id k13-20020a7bc40d000000b00381890032dfsm15786591wmi.1.2022.03.06.05.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 05:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zwXjzSzsl8TDGlKONbb5aSOhR7jvYd4YRdrKNrb6iSw=; b=FxnNu7NLPeg1OgnE6k/7ZQEup0+z5Ji/e6J246HMimjVB7GZnvc9P5jvjYlJx3+a5c wvDq/hYWm/ZJ9xbfbYEviaIHPpUijwubMyXHlk1NCM1g3tXSvbpI2c76/6VEIEJWayLR VW+VHPzXKHb7uXahIB3Vy3R7b/mR/15qoe8QsbDepG4rIbASd2bBc8nuakp/HU1Vxc0i hikfhSIhR/zb005LLblK8lZ1M8u6j964/CPf1OT6804A9WP6yy0PTOI24cL/v6wTVHdh /GH/Ur0iOA2hfmKLwAdSLv/Ljc42v1f2w/SQECESoRGXiWhWG+KKSzH1ZxXDTgmty4lz ciMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zwXjzSzsl8TDGlKONbb5aSOhR7jvYd4YRdrKNrb6iSw=; b=BeqE7vMQeSrRi/x3NWYy3iXAhoCYzKx2of3jXsViZbDiq+wjZzIa9RbIcaY2IByHq8 CxdDbPHdSQPXqeGnHqwJoIiLuKqsFAW7S9wF9joE8grvILzgoSGVCr4wAvKw3h+ap/Fy /JKUA5xTO22nDLSOi1tyw3mJIOggksWhj03TYWeAXDu9U3JwkIHPYwheE7aOS/Oai7Bz fN+frW9JPRDp0rPx0HrRIS+E6lb/vo0S/dz0wwbA4BYO5szmpvf/HHNQPecxcGERrnCr DctVH7Nuy+o/X6PCd2BBKlpW/Kf/Z5TLJataqKIEamf1b0U+NI72MPf2uzP2vVdB/FZW 4rlw== X-Gm-Message-State: AOAM530HX0oOAygKthgEzUhvZnX0ifKhuwnY6SaQx4p/YsuT7LFbZRrz lM6eyRyBXftjmECXkVl5AyA= X-Google-Smtp-Source: ABdhPJxQ6eGy2jX85GPDbrSbIFNDp0qX7AeWkZ2RtWCZvB8wuIdI6KO/dtUgivXX+mLAtCtQR4w17g== X-Received: by 2002:a05:600c:22c9:b0:381:3b27:89be with SMTP id 9-20020a05600c22c900b003813b2789bemr5671890wmg.83.1646571662127; Sun, 06 Mar 2022 05:01:02 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Thomas Huth , Eduardo Habkost , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 11/33] accel: Introduce AccelOpsClass::cpus_are_resettable() Date: Sun, 6 Mar 2022 13:59:38 +0100 Message-Id: <20220306130000.8104-12-philippe.mathieu.daude@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220306130000.8104-1-philippe.mathieu.daude@gmail.com> References: <20220306130000.8104-1-philippe.mathieu.daude@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1646571666180100001 From: Philippe Mathieu-Daud=C3=A9 Add cpus_are_resettable() to AccelOps, and implement it for the KVM accelerator. Suggested-by: Richard Henderson Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20220207075426.81934-12-f4bug@amsat.org> --- include/sysemu/accel-ops.h | 2 ++ include/sysemu/hw_accel.h | 5 ----- accel/kvm/kvm-accel-ops.c | 6 ++++++ softmmu/cpus.c | 5 ++++- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/include/sysemu/accel-ops.h b/include/sysemu/accel-ops.h index 50c72540c73..6013c9444cc 100644 --- a/include/sysemu/accel-ops.h +++ b/include/sysemu/accel-ops.h @@ -28,6 +28,8 @@ struct AccelOpsClass { /* initialization function called when accel is chosen */ void (*ops_init)(AccelOpsClass *ops); =20 + bool (*cpus_are_resettable)(void); + void (*create_vcpu_thread)(CPUState *cpu); /* MANDATORY NON-NULL */ void (*kick_vcpu_thread)(CPUState *cpu); bool (*cpu_thread_is_idle)(CPUState *cpu); diff --git a/include/sysemu/hw_accel.h b/include/sysemu/hw_accel.h index 01b5ebf442a..22903a55f70 100644 --- a/include/sysemu/hw_accel.h +++ b/include/sysemu/hw_accel.h @@ -23,9 +23,4 @@ void cpu_synchronize_post_reset(CPUState *cpu); void cpu_synchronize_post_init(CPUState *cpu); void cpu_synchronize_pre_loadvm(CPUState *cpu); =20 -static inline bool cpu_check_are_resettable(void) -{ - return kvm_enabled() ? kvm_cpu_check_are_resettable() : true; -} - #endif /* QEMU_HW_ACCEL_H */ diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 95b7b080202..c4244a23c65 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -79,12 +79,18 @@ static bool kvm_vcpu_thread_is_idle(CPUState *cpu) return !kvm_halt_in_kernel(); } =20 +static bool kvm_cpus_are_resettable(void) +{ + return !kvm_enabled() || kvm_cpu_check_are_resettable(); +} + static void kvm_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D kvm_start_vcpu_thread; ops->cpu_thread_is_idle =3D kvm_vcpu_thread_is_idle; + ops->cpus_are_resettable =3D kvm_cpus_are_resettable; ops->synchronize_post_reset =3D kvm_cpu_synchronize_post_reset; ops->synchronize_post_init =3D kvm_cpu_synchronize_post_init; ops->synchronize_state =3D kvm_cpu_synchronize_state; diff --git a/softmmu/cpus.c b/softmmu/cpus.c index b17033d3bce..e1d84c8ccb7 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -195,7 +195,10 @@ void cpu_synchronize_pre_loadvm(CPUState *cpu) =20 bool cpus_are_resettable(void) { - return cpu_check_are_resettable(); + if (cpus_accel->cpus_are_resettable) { + return cpus_accel->cpus_are_resettable(); + } + return true; } =20 int64_t cpus_get_virtual_clock(void) --=20 2.35.1