From nobody Tue Feb 10 03:17:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1646489077; cv=none; d=zohomail.com; s=zohoarc; b=EvZiPtlJRPghsCGlVhRFO9Rh5/0uEn91rw0/mCAIGvUCZhfBMnHkEFx8jJVALVV2HGT8P0v4S/2mAmiM4CeZe96dRvqPmQYY7O7/74CFjPzkkkXSWEHL1Ua8ULsNWQN23VOXtCTY3VB6y0hMI7oFMAT2LY3bgN7KrcaZpw7U6jE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646489077; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+PcUBwtyLONahwm9KYX/VH157VeW5IvLAn6bEjXJ16g=; b=U/Cx4GRai8IKs5ApdW81dMSPdmStut46lfeAUbbncP9JQgiS3OshkAqo2/JhrRLeA/r0emibcxqNv11n6xKEux8VmbsLWacaeW8TezeCzfgsMF+KJSri/DQghwk14bcr8PrO2E1ALGbtfPRET7e/Sup7PBeGFYQeR/ZQwRx8Ba8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646489077616805.0826709726384; Sat, 5 Mar 2022 06:04:37 -0800 (PST) Received: from localhost ([::1]:37680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQV1O-00037X-1C for importer@patchew.org; Sat, 05 Mar 2022 09:04:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQRuj-0001O0-Co for qemu-devel@nongnu.org; Sat, 05 Mar 2022 05:45:29 -0500 Received: from [2607:f8b0:4864:20::52f] (port=37660 helo=mail-pg1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQRuh-0004qJ-Ml for qemu-devel@nongnu.org; Sat, 05 Mar 2022 05:45:29 -0500 Received: by mail-pg1-x52f.google.com with SMTP id bc27so9599146pgb.4 for ; Sat, 05 Mar 2022 02:45:26 -0800 (PST) Received: from luka.sso.indeed.net ([2405:6580:a880:4700:a153:19a4:ff82:9114]) by smtp.gmail.com with ESMTPSA id on17-20020a17090b1d1100b001bf33c61444sm2546622pjb.12.2022.03.05.02.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Mar 2022 02:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toaruos-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+PcUBwtyLONahwm9KYX/VH157VeW5IvLAn6bEjXJ16g=; b=euPNrQXAbcqsc0RsNPPvDs3I5KKl0AipO3o+LBW+eG0t3GwIKV41o3F3mWC/TZ1hDH JkdNWjLNLADkLpkgkd/TDvH0PtszMyo6SK0JyJkj71x0ZZ9fKfAWgLlTVbuUxyHWfaGz 9XR3D6uPb/G7+6j7Y0boN/j6IUoZFJ/+54lv7ehh1rp1dp9/RCQIw1Roc1/vnUsDWko/ CnqFTuii7o/zugtELRQ9lF7TALBVGw+BNkd2eGUb2ffU01nqX480/pgfPIRUfYjQV/35 26APUN2vHD6WcjDkWeYdYoE00byAEmgnbD9GTjc8IZBj8b2WSj15SJRlUhsKi2Zo1TmG y4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+PcUBwtyLONahwm9KYX/VH157VeW5IvLAn6bEjXJ16g=; b=KUp1tN7lcsK0MMIlBsIWrEjclVmm937lV9w746vfJlUsvmQ+I/t5A8dQD0I5jFJvx1 IGY08Vti4jlrQLumXI68XJlsHsNMqY/4zGfCZSmOpnKZdlyp31Waj82gZJUQiLRTv/F3 yLwtUdbRFeENCfnzhehehXfN4iVZ1IoZ1gmHs/jtzF3t0GKUfg37oe8G0H3xlZTxDwW7 nVXvNhncnlWEtAAFVCPeSpKGkNFubjSfKlVYhFWMnIIiCH/bRax0NMjavzdOLg4KlkQh +97nI/RjdMv0jx/kplnp6B/u2BncTbS6nFhOV27nRSG8V7M76a/qTSfmxeuG3RfiIYtV wdWg== X-Gm-Message-State: AOAM5312Jqtcm8/31O52t3/q1KfkUs2WuHSC2kBrHjNe7R9lenPNgm9Q dOKlbw/cMazMdpAVIQX03RbWayCoJ0N4+ubT X-Google-Smtp-Source: ABdhPJzJ5BN3U3qB972qbQH9laRYH9q+D8r2GpCBU8PBIBBv4JQSHt6SkXQ5dVI8TakuV5j7uG3Vqw== X-Received: by 2002:a05:6a00:174d:b0:4f6:67e3:965 with SMTP id j13-20020a056a00174d00b004f667e30965mr3200379pfc.39.1646477125605; Sat, 05 Mar 2022 02:45:25 -0800 (PST) From: "K. Lange" To: qemu-devel@nongnu.org Subject: [PATCH] ui/gtk: Ignore 2- and 3-button press events Date: Sat, 5 Mar 2022 19:45:21 +0900 Message-Id: <20220305104521.3583703-1-klange@toaruos.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::52f; envelope-from=klange@toaruos.org; helo=mail-pg1-x52f.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 05 Mar 2022 09:03:29 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "K. Lange" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @toaruos-org.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1646489081869100001 Content-Type: text/plain; charset="utf-8" GTK already produces corresponding GDK_BUTTON_PRESS events alongside 2BUTTON and 3BUTTON_PRESS events. The 2BUTTON and 3BUTTON_PRESS events were incorrectly being interpreted and passed to guests as button release events. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/558 Signed-off-by: K. Lange --- ui/gtk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index a8567b9ddc..8675ae76fa 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -958,6 +958,10 @@ static gboolean gd_button_event(GtkWidget *widget, Gdk= EventButton *button, return TRUE; } =20 + if (button->type =3D=3D GDK_2BUTTON_PRESS || button->type =3D=3D GDK_3= BUTTON_PRESS) { + return TRUE; + } + qemu_input_queue_btn(vc->gfx.dcl.con, btn, button->type =3D=3D GDK_BUTTON_PRESS); qemu_input_event_sync(); --=20 2.25.1