From nobody Tue May 14 23:02:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1646277306; cv=none; d=zohomail.com; s=zohoarc; b=UIi7+SYTdUKBefPj/YsjaGvKtB3B2WG2eUi0x5D03WRW03BzvDtFbNN1TK73bLNUoQKkDRvIZma1Z3t2JgfLk4A3WmmsyHVq/5uHJ2buosJ47kSqDergErFDcYTjLEUxh4NTcUToN4lTDecxDgrP9kV4sTq7ZdZvfDJhpLKidvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646277306; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=bqyCuGYan0n6XII8OB0rwm8nLU73nkWFnckG0phPkiqoiC0xCwRdwnJYW0dD1qTPsPjy/Yml6FQ927OnO4tzn5yCokV4ugeuNkwDC0Hpe5pybhsHBf+N61LN6xlP8/ETggC/dajkgnfHAmthK5Jey63HthNNduQtwdjCu4vVSrc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646277306362644.133881345322; Wed, 2 Mar 2022 19:15:06 -0800 (PST) Received: from localhost ([::1]:37812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPbvf-0001Jv-N9 for importer@patchew.org; Wed, 02 Mar 2022 22:15:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbsV-0006wp-OG for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:43 -0500 Received: from [2607:f8b0:4864:20::102f] (port=46771 helo=mail-pj1-x102f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPbsU-0003Wg-67 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:43 -0500 Received: by mail-pj1-x102f.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso3623332pjo.5 for ; Wed, 02 Mar 2022 19:11:37 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id h7-20020a056a00170700b004e01663f59bsm605789pfc.117.2022.03.02.19.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 19:11:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=zcgdZr3CaBtvHQgE1kM8OA3KdTpe5q2TFD04PX1L40Rr5C7qbBY+dPbMTNJ1S8pyPn U3AjOcFEh2iuSftOIJZ2iQP32tr5fJjoaU9FIp+fhlkXd6Ca6/upDlIbIU+g5wMAYZpB oqMfYMRjeEkdTJ2kg3CN/JuV3xm6l4qSqY8TWr4ZZUbOzctWQlhSGAfU3agNzvG96K+n BOTtdX3c55Lfj8xy3BAVQa3TJZt/a6IOfuDbnYWGPn+EWObnOKoINtHocYa+MdlqJnam LDoJsyPMqZF9ZYx2AYV6LkBAIlum2Yog/0ckqIB1ji2ib3EnCVGR2IpwueIZxaSeglQp rJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z0nTGi36Q6kY2XhTWFaFoUNK+G34o+/T62xUlFxQppc=; b=48lf21jg+qNeyFHbGxE9BQkfxo5YrYqVMpvHVzQVn06OuEJtjQYqtyTn/7vYr1a7u+ QOBwueX38UM1xY+FWx5oGzBYhiaoaTzEF7QTwShX5IMZxZoEp77K+57enrRnHDXc1fd1 KUrqolhrakgGZWkvMIPd2P2du5UH20OUpwOwmEejgSdzU1eu0FXTJB1/VUmymBasmDhL bhe30ELeGimg/JZbVngkp1WqR+/ReHU2UBcfGtyX6+37vfp8K8MSy74QmTEy169m8h7k CrMgGBySQar4F/7W3T3ABNlhBfoK39gOg+tPRSJUL1oFfx1y0d3xZR//l22JffRfxz9w iCWQ== X-Gm-Message-State: AOAM531K1F2ZuLFguOISATJ88VOZtkzGJUcH4ZsDpVXLGBK0RwzCYlhT skeT//FbHDZ/XQQu1vf9EZ6afEQ0JJq4YA== X-Google-Smtp-Source: ABdhPJyiMTh0olcdYXgs30VnHPmVwN9603ULmzKcd0ghhsMSqIWxMWF80zz5/FLfGgrqBI+lEyPUqA== X-Received: by 2002:a17:902:8c86:b0:151:8226:e93b with SMTP id t6-20020a1709028c8600b001518226e93bmr11379437plo.128.1646277096293; Wed, 02 Mar 2022 19:11:36 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/3] tcg/s390x: Fix tcg_out_dupi_vec vs VGM Date: Wed, 2 Mar 2022 17:11:30 -1000 Message-Id: <20220303031132.444233-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303031132.444233-1-richard.henderson@linaro.org> References: <20220303031132.444233-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1646277308021100001 Content-Type: text/plain; charset="utf-8" The immediate operands to VGM were in the wrong order, producing an inverse mask. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 6e65828c09..508f1bccc7 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2715,7 +2715,7 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType t= ype, unsigned vece, msb =3D clz32(val); lsb =3D 31 - ctz32(val); } - tcg_out_insn(s, VRIb, VGM, dst, lsb, msb, MO_32); + tcg_out_insn(s, VRIb, VGM, dst, msb, lsb, MO_32); return; } } else { @@ -2729,7 +2729,7 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType t= ype, unsigned vece, msb =3D clz64(val); lsb =3D 63 - ctz64(val); } - tcg_out_insn(s, VRIb, VGM, dst, lsb, msb, MO_64); + tcg_out_insn(s, VRIb, VGM, dst, msb, lsb, MO_64); return; } } --=20 2.25.1 From nobody Tue May 14 23:02:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1646277311; cv=none; d=zohomail.com; s=zohoarc; b=QGXkEzHGEXUjBn7hlxT0dRqT6aQ8SV1uj/NbRgTpRpJrKoQeNay3XtybNbM/2qxm9HMqK+u4zC0LttVweF9xnW83I3p6y+TaQnJ2vj8+gUtWMA+BtEayp9ba7O4PvPizbYbmJ3uI9H0P1I4BJaDTnsg/OCfK021Zg1OYHTrEbRo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646277311; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OuBdYD4t9EnJOkWc0Xx7hBPfmAgY4I+FMKGqYJBs4Ic=; b=mRqm2asnEXEqJZpXK3J9xdQxLUdGqRtY8pXOMU5p2GBiL5mkfUSQevpW+F/sXzphZZ1wMxp3lN0ytGoOFYOv1SFWC8aVe0/50yday55wZ28j26ps4TJxgeJlennly/CbY2XaQYQixUdllIRbsMgFOtoftYCTe0a2/qhZU5RKObQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646277311545293.2815431919138; Wed, 2 Mar 2022 19:15:11 -0800 (PST) Received: from localhost ([::1]:37886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPbvq-0001N0-Ez for importer@patchew.org; Wed, 02 Mar 2022 22:15:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbsX-0006xA-38 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:46 -0500 Received: from [2607:f8b0:4864:20::630] (port=39660 helo=mail-pl1-x630.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPbsU-0003Ws-76 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:44 -0500 Received: by mail-pl1-x630.google.com with SMTP id 9so3329879pll.6 for ; Wed, 02 Mar 2022 19:11:38 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id h7-20020a056a00170700b004e01663f59bsm605789pfc.117.2022.03.02.19.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 19:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OuBdYD4t9EnJOkWc0Xx7hBPfmAgY4I+FMKGqYJBs4Ic=; b=IOOeYB/Og3Q6ijRzB6hBXgpmRnTs/yhzqi7JW9Le9Q1M1ygoZTMSVPsmhvM2coVLfw JBe9ZnnOhNVKgITqrsT0+RmE9UjHSUfu/M3tMqWwT3Y/UkHEt0JEjPCw7YW6ZLhsLgjR 9X+KgEnoQ3J613zurpon8bd2vNLlU6gWS+8DRbZH5FjQAPHuiUM6Uvkaak4gP09B8x+t EiWtz6dWO9pH/PmMWH4EmcKC/BT6mZTQpjFzbmjF672C8Fi13CRw2a1Qw75uJw2laxxl aYOhenuHASAmlWhDAoeK0Lwa6cJfGIqhOwKlbUiwG7V+5cN/35BNjFKnEOjccjV3WjVi RFvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OuBdYD4t9EnJOkWc0Xx7hBPfmAgY4I+FMKGqYJBs4Ic=; b=B6Ha1UXBINiaPh0Z6B8AFEyIGqJcIKsdJTD5dn74aegrDdIHKqLiAL8c/fDJIlCPQ6 9cRtXQ4cvOAjKogO3sVDqZDJIgG4dV/FKfyXHF57HDWQWR9J1mDcfIKYu/UCEaTGx9vX 58ESfcxk8d/knLZJAQpfvCTGCYCqFKwxr/8ZScx8dh3E7criR8vH8iVzjoOkhslN3qKE 7LNdMLA+vevwQi2pYceYlrRCPoj9IlgpmXuCRTN84pZ7EKW2IImeLJSFURyI6p67Rf7o DM9ctNoQ1+lM4xUhM2Qr4wCg1nFhN8Vayfn8ycWMIQvu3H1ovPPj9PhvQVWr14cSEDHy l9hg== X-Gm-Message-State: AOAM530WNeiLZZhPesIv5R2P3a0vZ4Wyf3BjsiqvUQ1m/suUHSOR0mQn z3sokH4iJLLDOOqRteOW7WOKHxyXIWyRWA== X-Google-Smtp-Source: ABdhPJyl2RekuWyG/DiPNkF9mvnzCJcIGR3nrU2RNOSjx0db84YEMPuAY1nC5h/t/pqhXer95s+Dgw== X-Received: by 2002:a17:902:e5ce:b0:151:9c5a:3c87 with SMTP id u14-20020a170902e5ce00b001519c5a3c87mr4775233plf.59.1646277097519; Wed, 02 Mar 2022 19:11:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/3] tcg/s390x: Fix INDEX_op_bitsel_vec vs VSEL Date: Wed, 2 Mar 2022 17:11:31 -1000 Message-Id: <20220303031132.444233-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303031132.444233-1-richard.henderson@linaro.org> References: <20220303031132.444233-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::630 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1646277313383100001 Content-Type: text/plain; charset="utf-8" The operands are output in the wrong order: the tcg selector argument is first, whereas the s390x selector argument is last. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 508f1bccc7..3b185b3c96 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2868,7 +2868,7 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode o= pc, break; =20 case INDEX_op_bitsel_vec: - tcg_out_insn(s, VRRe, VSEL, a0, a1, a2, args[3]); + tcg_out_insn(s, VRRe, VSEL, a0, a2, args[3], a1); break; =20 case INDEX_op_cmp_vec: --=20 2.25.1 From nobody Tue May 14 23:02:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1646277315; cv=none; d=zohomail.com; s=zohoarc; b=nCtm2AUoNQIh00WKqYYN40EYIb6Uz5HjvbIVuwTVi3ybxFIfHiA+BLvu9jDD4+8uOrzuUmU30AvlsFr0cy6WMCheUgWV0C/S7T6h4SqvBYvRNdt7jz+9PbvAvggZ48hx4Eyxd872VmtoVPOd0BSaRIjQcQKdKLfYFPprcg6drqs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646277315; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=PIqS9WymuZH6NqdRbRWSEGur9P2OQpnIbP1qxf0mi583IKw1n7w0f9RtEFqA1w1Ogw5mrqyoDOsciTYPUXTz3BueojMxnTXXOLrKw/lMJDZhAKicpXIUaECkZHZDDy5Ab2RCLEuUOJFsM+jFdNoo4waYS5qCayFIZg80wgQkmoI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646277315113419.0007763374881; Wed, 2 Mar 2022 19:15:15 -0800 (PST) Received: from localhost ([::1]:38104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPbvt-0001VY-SL for importer@patchew.org; Wed, 02 Mar 2022 22:15:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPbsW-0006x8-Vm for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:45 -0500 Received: from [2607:f8b0:4864:20::1032] (port=41655 helo=mail-pj1-x1032.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPbsU-0003X4-7U for qemu-devel@nongnu.org; Wed, 02 Mar 2022 22:11:44 -0500 Received: by mail-pj1-x1032.google.com with SMTP id ev16-20020a17090aead000b001bc3835fea8so3677347pjb.0 for ; Wed, 02 Mar 2022 19:11:39 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-e819-4400-f268-c391.res6.spectrum.com. [2603:800c:1201:c600:e819:4400:f268:c391]) by smtp.gmail.com with ESMTPSA id h7-20020a056a00170700b004e01663f59bsm605789pfc.117.2022.03.02.19.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 19:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=OfS4Ns3Mg0VEHvFW7Pm7KFSx9SCEqPhSAoL/AEMZB6yLObtcQoXwAmOwn8seYE8GoC 5w8trA/rrLS1Hba2l7UwfINbGpsp6qQ359G0gnuDWK2CpRtdizyq5i9GKhiHAw+Obp3k vxPr7Klwl1kv+FulCwFekMVPJ6jGI21ACVGnkU2gNPqAfuR9F+gvW/SW8FCFiy5kIjWy t/cP6GpQMAkTv67JjwiFfbIKT+5cYQ96KL473k5JaGtbuzBkYyDueL74/FolWzcsK0YV +uhq+mAPv4MWsU3RZHZI4kDhchnHxwjX7i5O5RO4CsSBjdSqHK+R1fUhSaBH62fwVvc0 NCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=ida7WF4WfOhOzGp4lHpGwZQyGzwLM+MrOX5sPzBJY6jx8HhIRCS3+VTtjJ5KuuTHc4 f2KdbYd1rPHDanwJJYR+NEtSAIFOq6eOLy+yG2mfUP7jmfPublmvORbDxBZHPHDoYjil 2cbUqdz6K0JnKR0rJ5KUPRuYEqNRadFxi1Q9A/na9YYyMl/qJ6bwm3MevvHzfM8H++Zr AYT6l69z6DTpzMFM48SyTKcyttcRSXbvoM8gKpxSnIF803Q3uY8NitQF13RkVxh+miA3 GUo+jhBgLMQko7wXyoWx3Tl8UW9nusWdVHof9s3AMLWwNZB9wRwWXeAOyjSY+P2PfFns P64w== X-Gm-Message-State: AOAM533m62h6gDAKvuEtbBpSFYJcZtyDTvfj+YhKz6SNp71vrj1FDZKj T3rTI1Mw8YUdRf5JTfG5yoTH3zbDq+aCGw== X-Google-Smtp-Source: ABdhPJxT0H3GC2Atls+ti5Qt4igH25votxbUyb5ElPQtXrl+W9Ons3qk8PsALKataGlIuKrAxbuJAw== X-Received: by 2002:a17:903:230f:b0:150:a2f:e070 with SMTP id d15-20020a170903230f00b001500a2fe070mr33897186plh.139.1646277098726; Wed, 02 Mar 2022 19:11:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] tcg/s390x: Fix tcg_out_dup_vec vs general registers Date: Wed, 2 Mar 2022 17:11:32 -1000 Message-Id: <20220303031132.444233-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303031132.444233-1-richard.henderson@linaro.org> References: <20220303031132.444233-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1032 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1646277317430100001 Content-Type: text/plain; charset="utf-8" We copied the data from the general register input to the vector register output, but have not yet replicated it. We intended to fall through into the vector-vector case, but failed to redirect the input register. This is caught by an assertion failure in tcg_out_insn_VRIc, which diagnosed the incorrect register class. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 3b185b3c96..33becd7694 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2675,6 +2675,7 @@ static bool tcg_out_dup_vec(TCGContext *s, TCGType ty= pe, unsigned vece, if (vece =3D=3D MO_64) { return true; } + src =3D dst; } =20 /* --=20 2.25.1