From nobody Sun Feb 8 16:11:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646049111; cv=none; d=zohomail.com; s=zohoarc; b=Gfe3QRwPdvAo0hN9JpNPxDhkbbBKOMPQyTajnL0k2X/iC9OmfYvOtTMNAEeUZD5qOBc2cRDNDxJyELJD3Y6/KsAdGtcBWiXM37tlBXiVeU8RSEB0mkUYP6CPmRnjLVOZSqrx4PpNFqFwa/1iLAjNB5mv1iKpGn+Z2GhwOdbC3qs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646049111; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ehGU4Tw5k4o/WuBzvTdXPZ+oJFTjwufnYgiOIbJCKNI=; b=bhAhkzOes8y93hO7cdq15yywIS0XLb5QVnOCjx7KPbrCcDpOl2nk4mRu3jmj6MQAE71+PftaLmoxNbcD/uf3GeFiZplz0l7dn9vLFV85eP7JsVVhqzog3wz/3xaoNUBuRM4N96G6oJAgh++nzZwNOGaTabvyrD/7L4JsZUi+pkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646049111350924.3105827132165; Mon, 28 Feb 2022 03:51:51 -0800 (PST) Received: from localhost ([::1]:54110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOeZB-0000uQ-S6 for importer@patchew.org; Mon, 28 Feb 2022 06:51:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeRM-0007IX-59 for qemu-devel@nongnu.org; Mon, 28 Feb 2022 06:43:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59264) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeRJ-0003JZ-IB for qemu-devel@nongnu.org; Mon, 28 Feb 2022 06:43:42 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-7TFbyfdmPS6h1LXDYo8dHQ-1; Mon, 28 Feb 2022 06:43:37 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48EF51006AA6; Mon, 28 Feb 2022 11:43:36 +0000 (UTC) Received: from thuth.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 526832B3DE; Mon, 28 Feb 2022 11:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646048620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ehGU4Tw5k4o/WuBzvTdXPZ+oJFTjwufnYgiOIbJCKNI=; b=QRxnn6ZKERiCvw6u7tFi9cKpXLqOgjZ5FDrZcTWQvLaUCseXE03XdXNUDfuxK46gf7s9LR 3hN92ns7WwidBCcX76JkuPkMEZLSJZB34Ade536Kxgtz4fxdt9EBTH5lGW9ACpcY+PUgMk 6Pfn7GS71PWv/RtFqb3kKBb9iGPxlxk= X-MC-Unique: 7TFbyfdmPS6h1LXDYo8dHQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta Subject: [PATCH] tests/avocado: Cancel BootLinux tests in case there is no free port Date: Mon, 28 Feb 2022 12:43:25 +0100 Message-Id: <20220228114325.818294-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646049113280100001 Content-Type: text/plain; charset="utf-8" The BootLinux tests are currently failing with an ugly python stack trace on my RHEL8 system since they cannot get a free port (likely due to the firewall settings on my system). Let's properly check the return value of find_free_port() instead and cancel the test gracefully if it cannot get a free port. Signed-off-by: Thomas Huth Reviewed-by: Beraldo Leal Reviewed-by: Cleber Rosa --- Unfortunately, it still takes > 70 seconds for each and every tests from tests/avocado/boot_linux.py to get canceled, so tests/avocado/boot_linux.py still renders "make check-avocado" for me pretty unusable... looking at the implementation of find_free_port() in Avocado, I wonder whether there isn't a better way to get a free port number in Python? Brute-forcing all ports between 1024 and 65536 seems just quite cumbersome to me... tests/avocado/avocado_qemu/__init__.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado= _qemu/__init__.py index 75063c0c30..9b056b5ce5 100644 --- a/tests/avocado/avocado_qemu/__init__.py +++ b/tests/avocado/avocado_qemu/__init__.py @@ -603,6 +603,8 @@ def prepare_cloudinit(self, ssh_pubkey=3DNone): try: cloudinit_iso =3D os.path.join(self.workdir, 'cloudinit.iso') self.phone_home_port =3D network.find_free_port() + if not self.phone_home_port: + self.cancel('Failed to get a free port') pubkey_content =3D None if ssh_pubkey: with open(ssh_pubkey) as pubkey: --=20 2.27.0