From nobody Mon Feb 9 15:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646048577; cv=none; d=zohomail.com; s=zohoarc; b=bS0+5MJUgb1cVjUiCQz8TnRwWaHc/oQR+YL0AbxBlRnfmnr/e0Lj//o5OU2aiYI/jrPx2px9XCa6EG3VFPLUpRTHbpSwFRQiWjHB9+zWzNy4Hldh3l48spSOZeVTo9JFZKXP6WIMbs4JG2SQWwq4m8F2BsHu4ORtXdGyzr9uyQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646048577; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2ha58A0v4WbyZFzyt4Oly5tNGHbMMfXoC3AZ2Fshd3g=; b=ahMblJKeKS74W4AxkOkmWRcCcYm6s7jkq90CwnZI+NXwAj9QXdF850OZWGFUSRalvIO7Pc0BV5HAl2p+3fUJd10TGZVXzJmHMpw3k3grQWOx4ceO4mhU0MUn5BKouhezQlu7Sp5f1kz5LVzjJwjeLZQBIRLPvjiV0r7IsvXHfNc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1646048577562391.8356346497437; Mon, 28 Feb 2022 03:42:57 -0800 (PST) Received: from localhost ([::1]:36570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOeQa-00056B-JV for importer@patchew.org; Mon, 28 Feb 2022 06:42:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeAe-000468-8n for qemu-devel@nongnu.org; Mon, 28 Feb 2022 06:26:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeAX-00077n-Nr for qemu-devel@nongnu.org; Mon, 28 Feb 2022 06:26:22 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-602-koqScLNgOSW7GLi97ER5vQ-1; Mon, 28 Feb 2022 06:26:16 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E3841006AA5; Mon, 28 Feb 2022 11:26:15 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CD037B6F1; Mon, 28 Feb 2022 11:26:15 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C8D4221E6A02; Mon, 28 Feb 2022 12:26:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646047579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ha58A0v4WbyZFzyt4Oly5tNGHbMMfXoC3AZ2Fshd3g=; b=XJpV6tKepD2iSjksxrVl6qklBr+hFIRRlBDDBApk8NaXUJyJLPz9s5yn3wwHeNip3tY6QC 0McmKHsVQqqn265b5juTOTbkPy2sB9eytldHo+maVu1Lmtpf8YvMKhvlwuvEWIu/E+Pdxz DghalDEFwKzOlW+wPm1HV0wkE2D7mhA= X-MC-Unique: koqScLNgOSW7GLi97ER5vQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 2/9] keyval: Fix grammar comment to cover downstream prefix Date: Mon, 28 Feb 2022 12:26:06 +0100 Message-Id: <20220228112613.520040-3-armbru@redhat.com> In-Reply-To: <20220228112613.520040-1-armbru@redhat.com> References: <20220228112613.520040-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646048579109100001 Content-Type: text/plain; charset="utf-8" According to the grammar, a key __com.redhat_foo would be parsed as two key fragments __com and redhat_foo. It's actually parsed as a single fragment. Fix the grammar. Signed-off-by: Markus Armbruster Message-Id: <20220218145551.892787-2-armbru@redhat.com> --- util/keyval.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/keyval.c b/util/keyval.c index 904337c8a1..0cf2e84dc8 100644 --- a/util/keyval.c +++ b/util/keyval.c @@ -16,7 +16,9 @@ * key-vals =3D [ key-val { ',' key-val } [ ',' ] ] * key-val =3D key '=3D' val | help * key =3D key-fragment { '.' key-fragment } - * key-fragment =3D / [^=3D,.]+ / + * key-fragment =3D qapi-name | index + * qapi-name =3D '__' / [a-z0-9.-]+ / '_' / [A-Za-z][A-Za-z0-9_-]* / + * index =3D / [0-9]+ / * val =3D { / [^,]+ / | ',,' } * help =3D 'help' | '?' * --=20 2.35.1