From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986199; cv=none; d=zohomail.com; s=zohoarc; b=E/kaZiaVRP4LsPTMeB23Z4UIuWYL0TeCD/MAz4Fv0YkotiHv/jVxY6EGnr6VMMuu5JU+ehZ9jleF9LwDRbvY/Rp+nQIenXLhVrJylhZJT8x8Lv2xjiRz1BFXYg+94ije84fz+Wk4+9bMKohDMBb+CMOeTpoN7TY/UmFfhewm6aQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986199; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JiLG8jrCqG2LmLZgkf4Aw8DjJEHnI6zkIpqp//BmyXY=; b=EqDWXKke5w0kKdQWOvLp5GRC9R37R+vCdD6qF+0es5jKCac6sO9qVC7CAlDtyuMX726BHBzfDqJizBxzc7/lhsFrfxdmq/OhWTfJKy0+sA5c5w94ra5IW0s4BKtBnF3YSF6mpC4K+S0cfKKJtfuhDHPIFbFVQZxUbYJb9/wP4xk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986199690423.41590955916126; Sun, 27 Feb 2022 10:23:19 -0800 (PST) Received: from localhost ([::1]:55066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOCU-0005CU-Eo for importer@patchew.org; Sun, 27 Feb 2022 13:23:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAo-0002Xq-5U for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:34 -0500 Received: from [2607:f8b0:4864:20::62d] (port=42729 helo=mail-pl1-x62d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAm-0007mY-J0 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:33 -0500 Received: by mail-pl1-x62d.google.com with SMTP id p17so8873012plo.9 for ; Sun, 27 Feb 2022 10:21:32 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JiLG8jrCqG2LmLZgkf4Aw8DjJEHnI6zkIpqp//BmyXY=; b=xEcX1c9FbjCwUu7YP+dvRzw4Q0NMLeAbx6ksgUendKQ0bRgTXNFRM21uVV4vw8okx7 yk/7cBQ9bqKXhQF/gnOkUchEHdA0RYTJTavPY6N89SJFkJVoL3aMdEmxLu5cAL4m2GOn P3DQ0nahXeSRHTjsLlvN0OUJgsGZVPhExZCGw0tC8JlCuGpJGk/EJsVNYjjJkMrLniVv SY7eCOYMOodDJuh0QvQQLK4aq8s1uQxAxdQIBjhTISWjvP55It7mEE9OIijAMloHy7g7 wrg+FeuJfQK0FbqCI5sC3NseG2ge1LAn/FO/1kOuq6srVLhQFtp8wd2Gt5v+9UgeLWF7 9klw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JiLG8jrCqG2LmLZgkf4Aw8DjJEHnI6zkIpqp//BmyXY=; b=dW3f5lwxO6CzL/gZLl/VonAvbaQ1x1XmJOskQYRv3KkX9+vUwgOaHITt7A5EK8jj62 BIJ7vRbL9dduiJAlgZT8JNStWU5aVMCwr7hCTI2bwlvkxRdVxWkdkLnp9xL/lQhPaL5U PYbRHLUOqic0yE8QuJwZl/c8ff2SvOeHs4Niy29NI9b4V/jg9fqbPTV/junjL/naoqOX Dm9dlAAa0y2arNZjjP8qMT+YJiv3B1ftjh/xtA4drN5/+3aDEw++syQWyQXcx7NiueTz 2uz0X+cslLPRroitvG+zdRR/0ib09BJ2D67oHivifjUk3rZBTuYebyNYdHG++eSoxpxs qN9g== X-Gm-Message-State: AOAM5309e/15bxqBJWAn+YcDq8tD0wdM1S/0/mB9+AFtEHfcTr914s2q jxMVOW9Qr4c1aLP6orISVr2ydOykmonWSQ== X-Google-Smtp-Source: ABdhPJxjzEF6mrZOf5tDW28QtzGR8QMVeC/HfA9qaUqWxaEqeCaUNfZ0kFqRTGDvthZv063VSMCmMw== X-Received: by 2002:a17:902:b204:b0:14f:26a7:9f61 with SMTP id t4-20020a170902b20400b0014f26a79f61mr17025043plr.97.1645986091364; Sun, 27 Feb 2022 10:21:31 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/7] target/nios2: Remove mmu_read_debug Date: Sun, 27 Feb 2022 08:21:19 -1000 Message-Id: <20220227182125.21809-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986201125100001 Content-Type: text/plain; charset="utf-8" This functionality can be had via plugins, if desired. In the meantime, it is unused code. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/nios2/helper.h | 1 - target/nios2/mmu.h | 1 - target/nios2/mmu.c | 20 -------------------- target/nios2/op_helper.c | 5 ----- target/nios2/translate.c | 17 ----------------- 5 files changed, 44 deletions(-) diff --git a/target/nios2/helper.h b/target/nios2/helper.h index 6c8f0b5b35..6d8eec1814 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -21,7 +21,6 @@ DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) =20 #if !defined(CONFIG_USER_ONLY) -DEF_HELPER_2(mmu_read_debug, void, env, i32) DEF_HELPER_3(mmu_write, void, env, i32, i32) DEF_HELPER_1(check_interrupts, void, env) #endif diff --git a/target/nios2/mmu.h b/target/nios2/mmu.h index 4f46fbb82e..b7785b46c0 100644 --- a/target/nios2/mmu.h +++ b/target/nios2/mmu.h @@ -44,7 +44,6 @@ void mmu_flip_um(CPUNios2State *env, unsigned int um); unsigned int mmu_translate(CPUNios2State *env, Nios2MMULookup *lu, target_ulong vaddr, int rw, int mmu_idx); -void mmu_read_debug(CPUNios2State *env, uint32_t rn); void mmu_write(CPUNios2State *env, uint32_t rn, uint32_t v); void mmu_init(CPUNios2State *env); =20 diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 2545c06761..5616c39d54 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -35,26 +35,6 @@ #define MMU_LOG(x) #endif =20 -void mmu_read_debug(CPUNios2State *env, uint32_t rn) -{ - switch (rn) { - case CR_TLBACC: - MMU_LOG(qemu_log("TLBACC READ %08X\n", env->regs[rn])); - break; - - case CR_TLBMISC: - MMU_LOG(qemu_log("TLBMISC READ %08X\n", env->regs[rn])); - break; - - case CR_PTEADDR: - MMU_LOG(qemu_log("PTEADDR READ %08X\n", env->regs[rn])); - break; - - default: - break; - } -} - /* rw - 0 =3D read, 1 =3D write, 2 =3D fetch. */ unsigned int mmu_translate(CPUNios2State *env, Nios2MMULookup *lu, diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index a59003855a..61fc4dc903 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -26,11 +26,6 @@ #include "qemu/main-loop.h" =20 #if !defined(CONFIG_USER_ONLY) -void helper_mmu_read_debug(CPUNios2State *env, uint32_t rn) -{ - mmu_read_debug(env, rn); -} - void helper_mmu_write(CPUNios2State *env, uint32_t rn, uint32_t v) { mmu_write(env, rn, v); diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f9abc2fdd2..194c8ebafd 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -448,23 +448,6 @@ static void rdctl(DisasContext *dc, uint32_t code, uin= t32_t flags) gen_check_supervisor(dc); =20 switch (instr.imm5 + CR_BASE) { - case CR_PTEADDR: - case CR_TLBACC: - case CR_TLBMISC: - { -#if !defined(CONFIG_USER_ONLY) - if (likely(instr.c !=3D R_ZERO)) { - tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); -#ifdef DEBUG_MMU - TCGv_i32 tmp =3D tcg_const_i32(instr.imm5 + CR_BASE); - gen_helper_mmu_read_debug(cpu_R[instr.c], cpu_env, tmp); - tcg_temp_free_i32(tmp); -#endif - } -#endif - break; - } - default: if (likely(instr.c !=3D R_ZERO)) { tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986204; cv=none; d=zohomail.com; s=zohoarc; b=js/YunSw2XRTCYicYc/Jfrp1EDOqxt9SuaMsIPfHhaJutI3C8yl5pikV2TPppr9YXk123Ik1rlMGHHIoRHbZ/MXvADMZREdz/abub6Z1TYy38hzs6EX4TuSeSJht/yCdcxSGrL9jagVTxD4VrJDX+hH2fylET/FjltMVxvpgXkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986204; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kflgz17ggbMf4pl8VvhV/1GKguptkIzSWpU/iXQLGD0=; b=YBmPpEggbH51hQybROrQzWyUQkAmsd35tmP2uT+0yHTFzBN1FXgPNsTBg0V9r8dKfMxb3ZowN5U3GxWrHDRiFDtFtbvoJ6tkHUzB6kSevjY2nAVoq15Yr/3wrD/iD5AqGUkIXFNd9vUaWicQWz8McRJXeSddu+XrORiKQLpUxzA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986204969953.3575326961427; Sun, 27 Feb 2022 10:23:24 -0800 (PST) Received: from localhost ([::1]:55596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOCZ-0005Y1-Rs for importer@patchew.org; Sun, 27 Feb 2022 13:23:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAp-0002ZY-Vv for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:36 -0500 Received: from [2607:f8b0:4864:20::432] (port=41835 helo=mail-pf1-x432.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAn-0007nW-W9 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:35 -0500 Received: by mail-pf1-x432.google.com with SMTP id p8so9077998pfh.8 for ; Sun, 27 Feb 2022 10:21:33 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kflgz17ggbMf4pl8VvhV/1GKguptkIzSWpU/iXQLGD0=; b=HnqNUhYyvn4aZ9czg9bB5reb4HC/3VGv5gL0916ZSgzj9mZg1uS8cGZkcPsJlZI8Kg uN6oWuW/+842eOppXenPr63/CxBlFGP/99ewW9XMqg3g1kC8US1OzYXEAh3LQLrY1Ma6 U/P0xkQ0n486RKnKepOQeltSh0RiPBgBuBixJEkrrmWpG/cZ3OHqu0mLCSIqEsp7nrBO NGz6kr6KH9KZ7uDpgGkn8v8oLq+LzrRHeyQtJkyRrgb515A0+lstv2gqxiVktm4Tq9gB Z9W0KSjawNz3V7uwUAS0e0M0D9EXUIIonNhLZpfLgVsaQNOVNUsaHnl0x0HCz1shaq97 OEPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kflgz17ggbMf4pl8VvhV/1GKguptkIzSWpU/iXQLGD0=; b=E0bGDqRpT++wfxKcHG2bocH+3PmI/972VyLkCI59JBecjnhw7Oip8i0JG3coubBB2a amy6hyseJRiP7p9wu0bN4qrZC9M8uBk9SDv65KX/4B/ETAWeQu6QhSZrV8/+uf5Tud2T cX3yPi77xyGZYK4EBvDTWQ6TnoiiJ5p/mAQgvw092Y3NNRWXGY9BXJiziUE2nbvw4nIE 8xQXeCz24S+6yFoYQLepr87Bt7xGH9B64//5Vggcp/N5024J4IjDlQPKM/6+31mQt4wT m52xvcbupI/0YxzKbVI4+aOxgfh14T761iFJjGZTNGH5LfdOZ48pESdz3/mQIkc4wlF0 hfFw== X-Gm-Message-State: AOAM531c0BAAheb7kBIg7vJabnOJpe+wZMEC+cuO/WvxGDcZVddclaV3 PMUG6mzgzBO7bTfYO5r3O2pG92jSz4Rjcw== X-Google-Smtp-Source: ABdhPJzgHycwKqjh64xn814ENfwivEOfgN0wOIF9ighwz8AyEq7ofyJSaXDZdyUgkQ5XwDo4XaQzXA== X-Received: by 2002:a63:10c:0:b0:36c:6dd0:44af with SMTP id 12-20020a63010c000000b0036c6dd044afmr14451242pgb.41.1645986092581; Sun, 27 Feb 2022 10:21:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/7] target/nios2: Replace MMU_LOG with tracepoints Date: Sun, 27 Feb 2022 08:21:20 -1000 Message-Id: <20220227182125.21809-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::432 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986207094100002 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 1 + target/nios2/mmu.c | 96 ++++++++++++--------------------------- target/nios2/trace-events | 10 ++++ 3 files changed, 39 insertions(+), 68 deletions(-) create mode 100644 target/nios2/trace-events diff --git a/meson.build b/meson.build index 8df40bfac4..98f167d782 100644 --- a/meson.build +++ b/meson.build @@ -2692,6 +2692,7 @@ if have_system or have_user 'target/i386', 'target/i386/kvm', 'target/mips/tcg', + 'target/nios2', 'target/ppc', 'target/riscv', 'target/s390x', diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 5616c39d54..306370f675 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -23,18 +23,10 @@ #include "cpu.h" #include "exec/exec-all.h" #include "mmu.h" +#include "trace/trace-target_nios2.h" =20 #if !defined(CONFIG_USER_ONLY) =20 -/* Define this to enable MMU debug messages */ -/* #define DEBUG_MMU */ - -#ifdef DEBUG_MMU -#define MMU_LOG(x) x -#else -#define MMU_LOG(x) -#endif - /* rw - 0 =3D read, 1 =3D write, 2 =3D fetch. */ unsigned int mmu_translate(CPUNios2State *env, Nios2MMULookup *lu, @@ -43,37 +35,26 @@ unsigned int mmu_translate(CPUNios2State *env, Nios2CPU *cpu =3D env_archcpu(env); int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; int vpn =3D vaddr >> 12; + int way, n_ways =3D cpu->tlb_num_ways; =20 - MMU_LOG(qemu_log("mmu_translate vaddr %08X, pid %08X, vpn %08X\n", - vaddr, pid, vpn)); - - int way; - for (way =3D 0; way < cpu->tlb_num_ways; way++) { - - Nios2TLBEntry *entry =3D - &env->mmu.tlb[(way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask)]; - - MMU_LOG(qemu_log("TLB[%d] TAG %08X, VPN %08X\n", - (way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask), - entry->tag, (entry->tag >> 12))); + for (way =3D 0; way < n_ways; way++) { + uint32_t index =3D (way * n_ways) + (vpn & env->mmu.tlb_entry_mask= ); + Nios2TLBEntry *entry =3D &env->mmu.tlb[index]; =20 if (((entry->tag >> 12) !=3D vpn) || (((entry->tag & (1 << 11)) =3D=3D 0) && ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) !=3D pid))) { + trace_nios2_mmu_translate_miss(vaddr, pid, index, entry->tag); continue; } + lu->vaddr =3D vaddr & TARGET_PAGE_MASK; lu->paddr =3D (entry->data & CR_TLBACC_PFN_MASK) << TARGET_PAGE_BI= TS; lu->prot =3D ((entry->data & CR_TLBACC_R) ? PAGE_READ : 0) | ((entry->data & CR_TLBACC_W) ? PAGE_WRITE : 0) | ((entry->data & CR_TLBACC_X) ? PAGE_EXEC : 0); =20 - MMU_LOG(qemu_log("HIT TLB[%d] %08X %08X %08X\n", - (way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask), - lu->vaddr, lu->paddr, lu->prot)); + trace_nios2_mmu_translate_hit(vaddr, pid, index, lu->paddr, lu->pr= ot); return 1; } return 0; @@ -84,21 +65,18 @@ static void mmu_flush_pid(CPUNios2State *env, uint32_t = pid) CPUState *cs =3D env_cpu(env); Nios2CPU *cpu =3D env_archcpu(env); int idx; - MMU_LOG(qemu_log("TLB Flush PID %d\n", pid)); =20 for (idx =3D 0; idx < cpu->tlb_num_entries; idx++) { Nios2TLBEntry *entry =3D &env->mmu.tlb[idx]; =20 - MMU_LOG(qemu_log("TLB[%d] =3D> %08X %08X\n", - idx, entry->tag, entry->data)); - if ((entry->tag & (1 << 10)) && (!(entry->tag & (1 << 11))) && ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) =3D=3D pid)) { uint32_t vaddr =3D entry->tag & TARGET_PAGE_MASK; =20 - MMU_LOG(qemu_log("TLB Flush Page %08X\n", vaddr)); - + trace_nios2_mmu_flush_pid_hit(pid, idx, vaddr); tlb_flush_page(cs, vaddr); + } else { + trace_nios2_mmu_flush_pid_miss(pid, idx, entry->tag); } } } @@ -108,18 +86,15 @@ void mmu_write(CPUNios2State *env, uint32_t rn, uint32= _t v) CPUState *cs =3D env_cpu(env); Nios2CPU *cpu =3D env_archcpu(env); =20 - MMU_LOG(qemu_log("mmu_write %08X =3D %08X\n", rn, v)); - switch (rn) { case CR_TLBACC: - MMU_LOG(qemu_log("TLBACC: IG %02X, FLAGS %c%c%c%c%c, PFN %05X\n", - v >> CR_TLBACC_IGN_SHIFT, - (v & CR_TLBACC_C) ? 'C' : '.', - (v & CR_TLBACC_R) ? 'R' : '.', - (v & CR_TLBACC_W) ? 'W' : '.', - (v & CR_TLBACC_X) ? 'X' : '.', - (v & CR_TLBACC_G) ? 'G' : '.', - v & CR_TLBACC_PFN_MASK)); + trace_nios2_mmu_write_tlbacc(v >> CR_TLBACC_IGN_SHIFT, + (v & CR_TLBACC_C) ? 'C' : '.', + (v & CR_TLBACC_R) ? 'R' : '.', + (v & CR_TLBACC_W) ? 'W' : '.', + (v & CR_TLBACC_X) ? 'X' : '.', + (v & CR_TLBACC_G) ? 'G' : '.', + v & CR_TLBACC_PFN_MASK); =20 /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TL= BACC */ if (env->regs[CR_TLBMISC] & CR_TLBMISC_WR) { @@ -138,16 +113,10 @@ void mmu_write(CPUNios2State *env, uint32_t rn, uint3= 2_t v) if ((entry->tag !=3D newTag) || (entry->data !=3D newData)) { if (entry->tag & (1 << 10)) { /* Flush existing entry */ - MMU_LOG(qemu_log("TLB Flush Page (OLD) %08X\n", - entry->tag & TARGET_PAGE_MASK)); tlb_flush_page(cs, entry->tag & TARGET_PAGE_MASK); } entry->tag =3D newTag; entry->data =3D newData; - MMU_LOG(qemu_log("TLB[%d] =3D %08X %08X\n", - (way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask), - entry->tag, entry->data)); } /* Auto-increment tlbmisc.WAY */ env->regs[CR_TLBMISC] =3D @@ -161,15 +130,14 @@ void mmu_write(CPUNios2State *env, uint32_t rn, uint3= 2_t v) break; =20 case CR_TLBMISC: - MMU_LOG(qemu_log("TLBMISC: WAY %X, FLAGS %c%c%c%c%c%c, PID %04X\n", - v >> CR_TLBMISC_WAY_SHIFT, - (v & CR_TLBMISC_RD) ? 'R' : '.', - (v & CR_TLBMISC_WR) ? 'W' : '.', - (v & CR_TLBMISC_DBL) ? '2' : '.', - (v & CR_TLBMISC_BAD) ? 'B' : '.', - (v & CR_TLBMISC_PERM) ? 'P' : '.', - (v & CR_TLBMISC_D) ? 'D' : '.', - (v & CR_TLBMISC_PID_MASK) >> 4)); + trace_nios2_mmu_write_tlbmisc(v >> CR_TLBMISC_WAY_SHIFT, + (v & CR_TLBMISC_RD) ? 'R' : '.', + (v & CR_TLBMISC_WR) ? 'W' : '.', + (v & CR_TLBMISC_DBL) ? '2' : '.', + (v & CR_TLBMISC_BAD) ? 'B' : '.', + (v & CR_TLBMISC_PERM) ? 'P' : '.', + (v & CR_TLBMISC_D) ? 'D' : '.', + (v & CR_TLBMISC_PID_MASK) >> 4); =20 if ((v & CR_TLBMISC_PID_MASK) !=3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK)) { @@ -193,11 +161,6 @@ void mmu_write(CPUNios2State *env, uint32_t rn, uint32= _t v) CR_TLBMISC_PID_SHIFT); env->regs[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; env->regs[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VP= N_SHIFT; - MMU_LOG(qemu_log("TLB READ way %d, vpn %05X, tag %08X, data %0= 8X, " - "tlbacc %08X, tlbmisc %08X, pteaddr %08X\n", - way, vpn, entry->tag, entry->data, - env->regs[CR_TLBACC], env->regs[CR_TLBMISC], - env->regs[CR_PTEADDR])); } else { env->regs[CR_TLBMISC] =3D v; } @@ -206,9 +169,8 @@ void mmu_write(CPUNios2State *env, uint32_t rn, uint32_= t v) break; =20 case CR_PTEADDR: - MMU_LOG(qemu_log("PTEADDR: PTBASE %03X, VPN %05X\n", - v >> CR_PTEADDR_PTBASE_SHIFT, - (v & CR_PTEADDR_VPN_MASK) >> CR_PTEADDR_VPN_SHIFT= )); + trace_nios2_mmu_write_pteaddr(v >> CR_PTEADDR_PTBASE_SHIFT, + (v & CR_PTEADDR_VPN_MASK) >> CR_PTEA= DDR_VPN_SHIFT); =20 /* Writes to PTEADDR don't change the read-back VPN value */ env->regs[CR_PTEADDR] =3D (v & ~CR_PTEADDR_VPN_MASK) | @@ -226,8 +188,6 @@ void mmu_init(CPUNios2State *env) Nios2CPU *cpu =3D env_archcpu(env); Nios2MMU *mmu =3D &env->mmu; =20 - MMU_LOG(qemu_log("mmu_init\n")); - mmu->tlb_entry_mask =3D (cpu->tlb_num_entries / cpu->tlb_num_ways) - 1; mmu->tlb =3D g_new0(Nios2TLBEntry, cpu->tlb_num_entries); } diff --git a/target/nios2/trace-events b/target/nios2/trace-events new file mode 100644 index 0000000000..07f1f0a5e7 --- /dev/null +++ b/target/nios2/trace-events @@ -0,0 +1,10 @@ +# mmu.c +nios2_mmu_translate_miss(uint32_t vaddr, uint32_t pid, uint32_t index, uin= t32_t tag) "mmu_translate: MISS vaddr=3D0x%08x pid=3D%u TLB[%u] tag=3D0x%08= x" +nios2_mmu_translate_hit(uint32_t vaddr, uint32_t pid, uint32_t index, uint= 32_t paddr, uint32_t prot) "mmu_translate: HIT vaddr=3D0x%08x pid=3D%u TLB[= %u] paddr=3D0x%08x prot=3D0x%x" + +nios2_mmu_flush_pid_miss(uint32_t pid, uint32_t index, uint32_t vaddr) "mm= u_flush: MISS pid=3D%u TLB[%u] tag=3D0x%08x" +nios2_mmu_flush_pid_hit(uint32_t pid, uint32_t index, uint32_t vaddr) "mmu= _flush: HIT pid=3D%u TLB[%u] vaddr=3D0x%08x" + +nios2_mmu_write_tlbacc(uint32_t ig, char c, char r, char w, char x, char g= , uint32_t pfn) "mmu_write_tlbacc: ig=3D0x%02x flags=3D%c%c%c%c%c pfn=3D0x%= 08x" +nios2_mmu_write_tlbmisc(uint32_t way, char r, char w, char t, char b, char= p, char d, uint32_t pid) "mmu_write_tlbmisc: way=3D0x%x flags=3D%c%c%c%c%c= %c pid=3D%u" +nios2_mmu_write_pteaddr(uint32_t ptb, uint32_t vpn) "mmu_write_pteaddr: pt= base=3D0x%03x vpn=3D0x%05x" --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986200; cv=none; d=zohomail.com; s=zohoarc; b=YKPy29RI7aNmd9x20QgK/sKUzZL+a2vsx2OwayGnNmHh61E9rYth7eeoqRLVQIxEBMpS8VoytZ6AISq6sPkJDCf9SKS+IWD4TTA5mXKUbjLeXpitcMTqfGLuN1Y+2V3ChmtI//Vr6VEHc2LugpWoyMl4icujcVn86vjYhCSItII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986200; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J7e/u37TYv9IPJn4rjMKxL8Ql7HntkOG8MpKKjdYqdw=; b=c3qa1ggs/lMEDyczzziEpelnbkFbx0C8Vcf93gLTDVVjEkTiuNeMHAznQ4GTRReLvcI9zYgHXsb3B75mCz6/J+oxtlFChTildkOZg+FLYAObDxvfZ+AfJ/xSh5y+a7tGC8xa2KGiXGhMJRJyJlfygatHqaOKnI917OSScBbplnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986200934247.51069762503482; Sun, 27 Feb 2022 10:23:20 -0800 (PST) Received: from localhost ([::1]:55256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOCV-0005KA-PA for importer@patchew.org; Sun, 27 Feb 2022 13:23:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAr-0002cO-12 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:37 -0500 Received: from [2607:f8b0:4864:20::102e] (port=54028 helo=mail-pj1-x102e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAp-0007nl-3T for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:36 -0500 Received: by mail-pj1-x102e.google.com with SMTP id bx5so9198994pjb.3 for ; Sun, 27 Feb 2022 10:21:34 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J7e/u37TYv9IPJn4rjMKxL8Ql7HntkOG8MpKKjdYqdw=; b=rTZ88MCkNO/ftTZDXO/mXy2bILQk/iQZ+4uSCaWOvNU0nEXO/UkxlnKub391wHjnpa mqA2VLMZHJlgiGQO4lSWdcyVnI9CFdQwteIit1gURjc6X2VRLv0265TIC2Ko6MyGLPFk pJrFRjKkWNMt5+PMefB8WSxlsvMAOsZlpQITKEjmTNkNOcqOR4JJId0JL+dbl+1DRHAM KSToYIxM0atvDvRGZfHuHoQNI/MDymv51WW9ETG2OKyHDS+sJ6MjYhc5+k3MW8ZopVIt 8o/qAzqwNi6BNTMrztvNRKrl/AJWdgadbuzwo/vYzkvq705TgGoY3pAuwL24G56eAiEY RF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J7e/u37TYv9IPJn4rjMKxL8Ql7HntkOG8MpKKjdYqdw=; b=eFBzP4/GRWEemf6goosNmvf1FBDBXrEem3pT8Iwamwcgcs7tB98rlnqGUEfKzp8uDt hY2KWUlD5n4f/qtdtHE7JG7nOGleqcoV/gtIIDbqOoGgmnXSKdvr3/0x4xRaHUHUYO0x KL0eIupmopmXVPbYJ9wsBUdzLCZ1DfmOJ9jq0/isy2BDLBiVmLL0KpImQJdmzsH1yONG unkqHaGYBLyAdlcgNOorINOBYHKSZFjj7PIBkrKL7KNe6G0DD8swPkwt+VtXpdJuI2QL asuSkt2ba2buIF4K5iQeSTyhEKAvU8lJnUue51WItHgUYMtZpq4OiLkVvZY8ZwTa5wZB 7B4A== X-Gm-Message-State: AOAM530+q/ujaoe3A6H5uzPR5eYVKjXimyocZoHkDAhx8vvvMQRtJ3Ea d6aGSelTih3DeBD6r33ZFl2YDQsAmk2A3g== X-Google-Smtp-Source: ABdhPJxjqLlDaROPy80lbxQAk+g+5ZuMFvAW3JfkF+/6Qa1ypGgyF/wBuTC4Q3raf+8ci3hj0Vm7Ug== X-Received: by 2002:a17:902:744a:b0:14f:a63b:577d with SMTP id e10-20020a170902744a00b0014fa63b577dmr17109488plt.86.1645986093854; Sun, 27 Feb 2022 10:21:33 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/7] target/nios2: Only build mmu.c for system mode Date: Sun, 27 Feb 2022 08:21:21 -1000 Message-Id: <20220227182125.21809-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986203068100003 Content-Type: text/plain; charset="utf-8" We can thus remove an ifdef covering the entire file. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/mmu.c | 3 --- target/nios2/meson.build | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 306370f675..437fad09b7 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -25,7 +25,6 @@ #include "mmu.h" #include "trace/trace-target_nios2.h" =20 -#if !defined(CONFIG_USER_ONLY) =20 /* rw - 0 =3D read, 1 =3D write, 2 =3D fetch. */ unsigned int mmu_translate(CPUNios2State *env, @@ -217,5 +216,3 @@ void dump_mmu(CPUNios2State *env) (entry->data & CR_TLBACC_X) ? 'X' : '-'); } } - -#endif /* !CONFIG_USER_ONLY */ diff --git a/target/nios2/meson.build b/target/nios2/meson.build index e643917db1..62b384702d 100644 --- a/target/nios2/meson.build +++ b/target/nios2/meson.build @@ -2,14 +2,13 @@ nios2_ss =3D ss.source_set() nios2_ss.add(files( 'cpu.c', 'helper.c', - 'mmu.c', 'nios2-semi.c', 'op_helper.c', 'translate.c', )) =20 nios2_softmmu_ss =3D ss.source_set() -nios2_softmmu_ss.add(files('monitor.c')) +nios2_softmmu_ss.add(files('monitor.c', 'mmu.c')) =20 target_arch +=3D {'nios2': nios2_ss} target_softmmu_arch +=3D {'nios2': nios2_softmmu_ss} --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986302; cv=none; d=zohomail.com; s=zohoarc; b=JPUd8PYX0KSfweHLH867tOpw92cUChN+7EDAGrYe0zGasQ62XnfXe5pPghFeHKWWIPHNuL9Sh2XAtQ5Rly8nBy6fZ+cECcYk72x4teQd0myqI+urH/hnFeI1b7/KpmmijuA5D8ASpL2IQaXKQQnDi2FdoI1cynatec0AJN2e5Rg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986302; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NbiZjwZMOI9QBNqQOVnUdzp1maV43aZ7/lLWc9/UloU=; b=OyM0q96tdNs8+4GfaD1ZzDR4fdAkhUheLA03FfWr2p96zF8EFRYTaz81vvczix10yxfwIVCxZBvoqFrrwA+xSDmwapevksifXvZK1F0IycDqlzWqfNgVvp74aacpLtvSU3scS0HMx1Yt8IRe5F903AdXXwmjWfQvbpUaSC+DOcw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986302945822.3684705521317; Sun, 27 Feb 2022 10:25:02 -0800 (PST) Received: from localhost ([::1]:34236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOE9-0001hE-WA for importer@patchew.org; Sun, 27 Feb 2022 13:25:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAs-0002fy-H1 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:38 -0500 Received: from [2607:f8b0:4864:20::1030] (port=51108 helo=mail-pj1-x1030.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAq-0007o6-Fo for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:38 -0500 Received: by mail-pj1-x1030.google.com with SMTP id m22so9243979pja.0 for ; Sun, 27 Feb 2022 10:21:36 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NbiZjwZMOI9QBNqQOVnUdzp1maV43aZ7/lLWc9/UloU=; b=vlNF5cmgJAbbqmcZaAeVhKYZyodeUq02DGyyv16HwwlaS9+uON7YyQF5DbBmKGcqKq XuUNBkJLZ6P5/XNdHw49E/i633xET4YkID6s4WEl88KUfQAQ8OsmbwgCkuNcYKKYh9UL 1VYJxGvsI9Fpo0/0yQ+Hs5C+dZVI4ntsZ0vYi2NrD3Cdd7qLpifwxfvyjCN0wV4SlErS Xsc8qY/nsI3wTP99j6G37sxzjHg1XMQsyo8mjakT3G69eEtXIjCCxspUU0SNZZWX41Kc +Sz+DOOO3ifhbGMXuqy21Fzl3n/4BwB/ZFMGXh3r8/wZp98rLS2gpJE9u89mELGP8nXT 0Dpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NbiZjwZMOI9QBNqQOVnUdzp1maV43aZ7/lLWc9/UloU=; b=q1yl6SqE+kclRhAf1Druygj75rEVirca6P/LMJdX4ZNtBPLC3VJ40jg18mxjsmNO6n /SdrVZxbCuB7Rc1QzIHz1QjuFF2T+d2vl+peGvOVRkqWtf5XgIgpd5BMkg4LVi5hNPYX tcXGAM3mBLf3eC6L5Gr9Ho/kgK6Ra8ghLBPpHLhZ3GMxwkqU+FTBou8UhG6FEyd+GvQO S0JUPu/5lMLd3NUfooARBnyFhWm+2kkp9j039DZCSJaJCnUghENYqssYwwaWPoaoAryQ bvItj14ne+oyCkDMdKDI7MbnC0zgCfwx1hz9sWKvrjUZ8bW/OevST3fIAhggR1bS23wz 4RdA== X-Gm-Message-State: AOAM533kP4sHxRQAOOY/P4XytvmV/Uhs0UXIhHZP0OA403Ppes+dn/gc 8GnHidsk/fYd5Lo3jGJIxIy51r3YEyzhlQ== X-Google-Smtp-Source: ABdhPJyHB6fv+8SvB0HbOTqsNfnmVWWRGl5KH20xIqsjfs83uC1/JVyCTPAOgWiQVsEw1gzfscMBWw== X-Received: by 2002:a17:90a:9b08:b0:1bc:9b4f:8dff with SMTP id f8-20020a17090a9b0800b001bc9b4f8dffmr12783493pjp.159.1645986095229; Sun, 27 Feb 2022 10:21:35 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 4/7] target/nios2: Hoist R_ZERO check in rdctl Date: Sun, 27 Feb 2022 08:21:22 -1000 Message-Id: <20220227182125.21809-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1030 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986303906100001 Content-Type: text/plain; charset="utf-8" This will avoid having to replicate the check to additional cases. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/translate.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 194c8ebafd..fa355308a9 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -447,11 +447,13 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) =20 gen_check_supervisor(dc); =20 + if (unlikely(instr.c =3D=3D R_ZERO)) { + return; + } + switch (instr.imm5 + CR_BASE) { default: - if (likely(instr.c !=3D R_ZERO)) { - tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); - } + tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); break; } } --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986419; cv=none; d=zohomail.com; s=zohoarc; b=KkXlA+yZe2fGIxMpBFetz9KS6n5BxW0rPK+xBY7J4SqXLF2/4iV36Ivg7exlIjbmtsJIveSY5vrzMUlGw0XAz4BQ4HYLaKcxxDgboG0WUjAyjQg70C4Yemc5nlhaGiLcWJf5ZooA/CdBMPaS1n/ZnNbtOIdpkbUAlosPr1b5ZuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986419; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aP6IO/cT72ijPpNPOU0qAba7aGUnduFPooW5AlogQb4=; b=gRNppaxu/GZhxZzKFKpLopxbehqluY/8LIUvW0GvNze0roAu4Dtka3j+7ereew1e8FulOqTviop/UTrVN660D3+RF6FACHriBTZX+4tysFmcG+/7oN+XZQ9uiY4OKzNqm64icPtNs4FFXxskO1d1UCs+Leef09M6lBSnM5sr1go= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986419033494.42067408060916; Sun, 27 Feb 2022 10:26:59 -0800 (PST) Received: from localhost ([::1]:39622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOG1-0005Kw-W2 for importer@patchew.org; Sun, 27 Feb 2022 13:26:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAu-0002lm-FX for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:40 -0500 Received: from [2607:f8b0:4864:20::435] (port=43815 helo=mail-pf1-x435.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAr-0007p8-W9 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:40 -0500 Received: by mail-pf1-x435.google.com with SMTP id d187so9072957pfa.10 for ; Sun, 27 Feb 2022 10:21:37 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aP6IO/cT72ijPpNPOU0qAba7aGUnduFPooW5AlogQb4=; b=YPXmB0DuHvXBy4h/8iIYSJPibk8hI8o9xTq+Y1xsSE3yAFzlBAZMh4aJydSgxFJyDz pcwP2h5t0qKD/q/ymC1Iah7HifzVPVivqGuIWiOX9QceqQn/H4K0lbev1j4dHz8QUEko QmPJ7aeUVYcoN9D1Adn4Rj7gMxGAXE5fjtSxt7jpee2C+QId+rSCHUsEuo79flD0T7CB k89zv8gvONFmnq0Ux9i7JhbV0g4z9BamLOcwRTWT/FOy5olbD9/3/QUmZlLP7nx8jrPU tY3LL+6ojRlJMzHs58yToNngJmSpDE6Wt80r2vH1rmgv8SPnqfEepqAXnGtYf+kd4W7P b7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aP6IO/cT72ijPpNPOU0qAba7aGUnduFPooW5AlogQb4=; b=zOlqXCRvkv4e22oWDJCLrRX5wndm414m8UrpSh9qtZbMfKQeHppC0f5hy6iYJ2DE54 03Qut4FLa5Gusm1yVnQtlT6Knxb+hp9CUzrFsBFb/3jzoILKQ3nQl9+atOtwn4CZ5jyK VcRLrJDh/UGVhrR8Fv/H9Stj/nZGMO2Vsj8XLcyY4h0XIr3x/FZZrCPQ6lUiza9APOct aZgqQ0EttJLzdLGQACGlwqKxt/rkn47dks/vzikh8B5kHn7u7tQ6H/773sozheaxUaaX D5I9yG1jvmCIXhqWIktx9SMKM275NtqsNC102vMNQ8ALpRcDsGKUIrsQG1EeGgLoVVD7 SEMQ== X-Gm-Message-State: AOAM530eFEv1n3qP52uidMCdvzBDPa+OwpxQg0HF6uN5MfJaLAw7mDKx Un0IdgHtDnZsbMZf13HGewc2mgxuPRvCMA== X-Google-Smtp-Source: ABdhPJwjyk/Af3QDT2KR3v9zcgQVjkbW0XgDp6HGH7e9TsSQJ38HbtnXxvVly72wXKG6Mzu7FEMl5A== X-Received: by 2002:a05:6a00:244b:b0:4c9:319e:ecb7 with SMTP id d11-20020a056a00244b00b004c9319eecb7mr17748868pfj.58.1645986096656; Sun, 27 Feb 2022 10:21:36 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 5/7] target/nios2: Split mmu_write Date: Sun, 27 Feb 2022 08:21:23 -1000 Message-Id: <20220227182125.21809-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::435 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986420776100001 Content-Type: text/plain; charset="utf-8" Create three separate functions for the three separate registers. Avoid extra dispatch through op_helper.c. Dispatch to the correct function in translation. Clean up the ifdefs in wrctl. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/nios2/helper.h | 4 +- target/nios2/mmu.c | 180 +++++++++++++++++++-------------------- target/nios2/op_helper.c | 5 -- target/nios2/translate.c | 26 +++--- 4 files changed, 104 insertions(+), 111 deletions(-) diff --git a/target/nios2/helper.h b/target/nios2/helper.h index 6d8eec1814..21ef7f0791 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -21,6 +21,8 @@ DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) =20 #if !defined(CONFIG_USER_ONLY) -DEF_HELPER_3(mmu_write, void, env, i32, i32) +DEF_HELPER_2(mmu_write_tlbacc, void, env, i32) +DEF_HELPER_2(mmu_write_tlbmisc, void, env, i32) +DEF_HELPER_2(mmu_write_pteaddr, void, env, i32) DEF_HELPER_1(check_interrupts, void, env) #endif diff --git a/target/nios2/mmu.c b/target/nios2/mmu.c index 437fad09b7..4daab2a7ab 100644 --- a/target/nios2/mmu.c +++ b/target/nios2/mmu.c @@ -23,6 +23,7 @@ #include "cpu.h" #include "exec/exec-all.h" #include "mmu.h" +#include "exec/helper-proto.h" #include "trace/trace-target_nios2.h" =20 =20 @@ -80,106 +81,103 @@ static void mmu_flush_pid(CPUNios2State *env, uint32_= t pid) } } =20 -void mmu_write(CPUNios2State *env, uint32_t rn, uint32_t v) +void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t v) { CPUState *cs =3D env_cpu(env); Nios2CPU *cpu =3D env_archcpu(env); =20 - switch (rn) { - case CR_TLBACC: - trace_nios2_mmu_write_tlbacc(v >> CR_TLBACC_IGN_SHIFT, - (v & CR_TLBACC_C) ? 'C' : '.', - (v & CR_TLBACC_R) ? 'R' : '.', - (v & CR_TLBACC_W) ? 'W' : '.', - (v & CR_TLBACC_X) ? 'X' : '.', - (v & CR_TLBACC_G) ? 'G' : '.', - v & CR_TLBACC_PFN_MASK); + trace_nios2_mmu_write_tlbacc(v >> CR_TLBACC_IGN_SHIFT, + (v & CR_TLBACC_C) ? 'C' : '.', + (v & CR_TLBACC_R) ? 'R' : '.', + (v & CR_TLBACC_W) ? 'W' : '.', + (v & CR_TLBACC_X) ? 'X' : '.', + (v & CR_TLBACC_G) ? 'G' : '.', + v & CR_TLBACC_PFN_MASK); =20 - /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TL= BACC */ - if (env->regs[CR_TLBMISC] & CR_TLBMISC_WR) { - int way =3D (env->regs[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); - int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; - int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; - int g =3D (v & CR_TLBACC_G) ? 1 : 0; - int valid =3D ((vpn & CR_TLBACC_PFN_MASK) < 0xC0000) ? 1 : 0; - Nios2TLBEntry *entry =3D - &env->mmu.tlb[(way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask)]; - uint32_t newTag =3D (vpn << 12) | (g << 11) | (valid << 10) | = pid; - uint32_t newData =3D v & (CR_TLBACC_C | CR_TLBACC_R | CR_TLBAC= C_W | - CR_TLBACC_X | CR_TLBACC_PFN_MASK); + /* if tlbmisc.WE =3D=3D 1 then trigger a TLB write on writes to TLBACC= */ + if (env->regs[CR_TLBMISC] & CR_TLBMISC_WR) { + int way =3D (env->regs[CR_TLBMISC] >> CR_TLBMISC_WAY_SHIFT); + int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; + int pid =3D (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> 4; + int g =3D (v & CR_TLBACC_G) ? 1 : 0; + int valid =3D ((vpn & CR_TLBACC_PFN_MASK) < 0xC0000) ? 1 : 0; + Nios2TLBEntry *entry =3D + &env->mmu.tlb[(way * cpu->tlb_num_ways) + + (vpn & env->mmu.tlb_entry_mask)]; + uint32_t newTag =3D (vpn << 12) | (g << 11) | (valid << 10) | pid; + uint32_t newData =3D v & (CR_TLBACC_C | CR_TLBACC_R | CR_TLBACC_W | + CR_TLBACC_X | CR_TLBACC_PFN_MASK); =20 - if ((entry->tag !=3D newTag) || (entry->data !=3D newData)) { - if (entry->tag & (1 << 10)) { - /* Flush existing entry */ - tlb_flush_page(cs, entry->tag & TARGET_PAGE_MASK); - } - entry->tag =3D newTag; - entry->data =3D newData; + if ((entry->tag !=3D newTag) || (entry->data !=3D newData)) { + if (entry->tag & (1 << 10)) { + /* Flush existing entry */ + tlb_flush_page(cs, entry->tag & TARGET_PAGE_MASK); } - /* Auto-increment tlbmisc.WAY */ - env->regs[CR_TLBMISC] =3D - (env->regs[CR_TLBMISC] & ~CR_TLBMISC_WAY_MASK) | - (((way + 1) & (cpu->tlb_num_ways - 1)) << - CR_TLBMISC_WAY_SHIFT); + entry->tag =3D newTag; + entry->data =3D newData; } - - /* Writes to TLBACC don't change the read-back value */ - env->mmu.tlbacc_wr =3D v; - break; - - case CR_TLBMISC: - trace_nios2_mmu_write_tlbmisc(v >> CR_TLBMISC_WAY_SHIFT, - (v & CR_TLBMISC_RD) ? 'R' : '.', - (v & CR_TLBMISC_WR) ? 'W' : '.', - (v & CR_TLBMISC_DBL) ? '2' : '.', - (v & CR_TLBMISC_BAD) ? 'B' : '.', - (v & CR_TLBMISC_PERM) ? 'P' : '.', - (v & CR_TLBMISC_D) ? 'D' : '.', - (v & CR_TLBMISC_PID_MASK) >> 4); - - if ((v & CR_TLBMISC_PID_MASK) !=3D - (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK)) { - mmu_flush_pid(env, (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK)= >> - CR_TLBMISC_PID_SHIFT); - } - /* if tlbmisc.RD =3D=3D 1 then trigger a TLB read on writes to TLB= MISC */ - if (v & CR_TLBMISC_RD) { - int way =3D (v >> CR_TLBMISC_WAY_SHIFT); - int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; - Nios2TLBEntry *entry =3D - &env->mmu.tlb[(way * cpu->tlb_num_ways) + - (vpn & env->mmu.tlb_entry_mask)]; - - env->regs[CR_TLBACC] &=3D CR_TLBACC_IGN_MASK; - env->regs[CR_TLBACC] |=3D entry->data; - env->regs[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC= _G : 0; - env->regs[CR_TLBMISC] =3D - (v & ~CR_TLBMISC_PID_MASK) | - ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) << - CR_TLBMISC_PID_SHIFT); - env->regs[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; - env->regs[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VP= N_SHIFT; - } else { - env->regs[CR_TLBMISC] =3D v; - } - - env->mmu.tlbmisc_wr =3D v; - break; - - case CR_PTEADDR: - trace_nios2_mmu_write_pteaddr(v >> CR_PTEADDR_PTBASE_SHIFT, - (v & CR_PTEADDR_VPN_MASK) >> CR_PTEA= DDR_VPN_SHIFT); - - /* Writes to PTEADDR don't change the read-back VPN value */ - env->regs[CR_PTEADDR] =3D (v & ~CR_PTEADDR_VPN_MASK) | - (env->regs[CR_PTEADDR] & CR_PTEADDR_VPN_MA= SK); - env->mmu.pteaddr_wr =3D v; - break; - - default: - break; + /* Auto-increment tlbmisc.WAY */ + env->regs[CR_TLBMISC] =3D + (env->regs[CR_TLBMISC] & ~CR_TLBMISC_WAY_MASK) | + (((way + 1) & (cpu->tlb_num_ways - 1)) << + CR_TLBMISC_WAY_SHIFT); } + + /* Writes to TLBACC don't change the read-back value */ + env->mmu.tlbacc_wr =3D v; +} + +void helper_mmu_write_tlbmisc(CPUNios2State *env, uint32_t v) +{ + Nios2CPU *cpu =3D env_archcpu(env); + + trace_nios2_mmu_write_tlbmisc(v >> CR_TLBMISC_WAY_SHIFT, + (v & CR_TLBMISC_RD) ? 'R' : '.', + (v & CR_TLBMISC_WR) ? 'W' : '.', + (v & CR_TLBMISC_DBL) ? '2' : '.', + (v & CR_TLBMISC_BAD) ? 'B' : '.', + (v & CR_TLBMISC_PERM) ? 'P' : '.', + (v & CR_TLBMISC_D) ? 'D' : '.', + (v & CR_TLBMISC_PID_MASK) >> 4); + + if ((v & CR_TLBMISC_PID_MASK) !=3D + (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK)) { + mmu_flush_pid(env, (env->mmu.tlbmisc_wr & CR_TLBMISC_PID_MASK) >> + CR_TLBMISC_PID_SHIFT); + } + /* if tlbmisc.RD =3D=3D 1 then trigger a TLB read on writes to TLBMISC= */ + if (v & CR_TLBMISC_RD) { + int way =3D (v >> CR_TLBMISC_WAY_SHIFT); + int vpn =3D (env->mmu.pteaddr_wr & CR_PTEADDR_VPN_MASK) >> 2; + Nios2TLBEntry *entry =3D + &env->mmu.tlb[(way * cpu->tlb_num_ways) + + (vpn & env->mmu.tlb_entry_mask)]; + + env->regs[CR_TLBACC] &=3D CR_TLBACC_IGN_MASK; + env->regs[CR_TLBACC] |=3D entry->data; + env->regs[CR_TLBACC] |=3D (entry->tag & (1 << 11)) ? CR_TLBACC_G := 0; + env->regs[CR_TLBMISC] =3D + (v & ~CR_TLBMISC_PID_MASK) | + ((entry->tag & ((1 << cpu->pid_num_bits) - 1)) << + CR_TLBMISC_PID_SHIFT); + env->regs[CR_PTEADDR] &=3D ~CR_PTEADDR_VPN_MASK; + env->regs[CR_PTEADDR] |=3D (entry->tag >> 12) << CR_PTEADDR_VPN_SH= IFT; + } else { + env->regs[CR_TLBMISC] =3D v; + } + + env->mmu.tlbmisc_wr =3D v; +} + +void helper_mmu_write_pteaddr(CPUNios2State *env, uint32_t v) +{ + trace_nios2_mmu_write_pteaddr(v >> CR_PTEADDR_PTBASE_SHIFT, + (v & CR_PTEADDR_VPN_MASK) >> CR_PTEADDR_= VPN_SHIFT); + + /* Writes to PTEADDR don't change the read-back VPN value */ + env->regs[CR_PTEADDR] =3D (v & ~CR_PTEADDR_VPN_MASK) | + (env->regs[CR_PTEADDR] & CR_PTEADDR_VPN_MASK); + env->mmu.pteaddr_wr =3D v; } =20 void mmu_init(CPUNios2State *env) diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index 61fc4dc903..d729379e4d 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -26,11 +26,6 @@ #include "qemu/main-loop.h" =20 #if !defined(CONFIG_USER_ONLY) -void helper_mmu_write(CPUNios2State *env, uint32_t rn, uint32_t v) -{ - mmu_write(env, rn, v); -} - static void nios2_check_interrupts(CPUNios2State *env) { if (env->irq_pending && diff --git a/target/nios2/translate.c b/target/nios2/translate.c index fa355308a9..52965ba17e 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -461,30 +461,28 @@ static void rdctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) /* ctlN <- rA */ static void wrctl(DisasContext *dc, uint32_t code, uint32_t flags) { - R_TYPE(instr, code); - gen_check_supervisor(dc); =20 +#ifndef CONFIG_USER_ONLY + R_TYPE(instr, code); + TCGv v =3D load_gpr(dc, instr.a); + switch (instr.imm5 + CR_BASE) { case CR_PTEADDR: - case CR_TLBACC: - case CR_TLBMISC: - { -#if !defined(CONFIG_USER_ONLY) - TCGv_i32 tmp =3D tcg_const_i32(instr.imm5 + CR_BASE); - gen_helper_mmu_write(cpu_env, tmp, load_gpr(dc, instr.a)); - tcg_temp_free_i32(tmp); -#endif + gen_helper_mmu_write_pteaddr(cpu_env, v); + break; + case CR_TLBACC: + gen_helper_mmu_write_tlbacc(cpu_env, v); + break; + case CR_TLBMISC: + gen_helper_mmu_write_tlbmisc(cpu_env, v); break; - } - default: - tcg_gen_mov_tl(cpu_R[instr.imm5 + CR_BASE], load_gpr(dc, instr.a)); + tcg_gen_mov_tl(cpu_R[instr.imm5 + CR_BASE], v); break; } =20 /* If interrupts were enabled using WRCTL, trigger them. */ -#if !defined(CONFIG_USER_ONLY) if ((instr.imm5 + CR_BASE) =3D=3D CR_STATUS) { if (tb_cflags(dc->base.tb) & CF_USE_ICOUNT) { gen_io_start(); --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986309; cv=none; d=zohomail.com; s=zohoarc; b=GosOjiQjhpLjfFYmVg2dzQgm/JvkRb41Q87GMlsdYk4qmKZlPRbpkPCmbeiauINSGqrxvufig/KyaW0Zby3Q7frO/GKB7KPRb7zbrqrkQ2OkoWkJ+NJUZOIOBU/Rgy6/unQkbVDfd/tUftKz62ryd0viKKxB/jXwxuHXRXXgNnE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986309; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RAL1NIBF7xZKJotAn1xZ6zr2b57K5Ny5tPwj+GqSPZE=; b=cgnC9fs1b9nFTuH4avqJ/Ar4R7pw/lmDibpw3i2VBj5hTJm5yhcL6cEtZhV0oIGN6AUkfN3XkNmB4e/ilsd/ugdf1S3qhBz4apWcs7tjnhQQgHeKNLP8tPgh44f3GWZmhJEK9W6ubfgd7VGPhOtop7K46UGa2wtOdB5Z206o4HU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986309402939.3162374707032; Sun, 27 Feb 2022 10:25:09 -0800 (PST) Received: from localhost ([::1]:34568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOEG-0001uO-7r for importer@patchew.org; Sun, 27 Feb 2022 13:25:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAu-0002m5-Ic for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:40 -0500 Received: from [2607:f8b0:4864:20::435] (port=38668 helo=mail-pf1-x435.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAt-0007pI-3p for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:40 -0500 Received: by mail-pf1-x435.google.com with SMTP id x18so9085542pfh.5 for ; Sun, 27 Feb 2022 10:21:38 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RAL1NIBF7xZKJotAn1xZ6zr2b57K5Ny5tPwj+GqSPZE=; b=QqKWF0fvqJFVLJShPA8r41r1TNaHsWYCesDf309pymM+7B1pP8MUsdzydywBvKxMUn cByMo9LYsdqFZyMxwHfIudAs6M859AgcvGPnvYyLM4R2KfBEW4/5ZaBKpNp/a82Oxehx 78wjic7OMjwttOdfq9RJvrSXvSJsUVhxxiQldiyQlD+xx3mH7AzSPlC9AQKzm6oIKTeN 9KoYDJDLmd8NZuKZghxaJ1AW98JLJEOCYBvuUxGBhDHguZ1BPnYMCDmTBP6pcQcxh/TW jHdkX66CVGl5JO3pz+qyi3l4qVMbUVPiLAqO6I8LjraaGG7QuhqEk6IGecPpizos26MX oqtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RAL1NIBF7xZKJotAn1xZ6zr2b57K5Ny5tPwj+GqSPZE=; b=BnhvJ81nPV20SM78Yj7oTaX4Uxp/L7OkwJni1AeH4XC9wjUuiLPP4syMLPR4yaLQ3U jrDzSF+C8AhfrjEaSs2e8VklFdCRF2VRJR5r3EM+Xq/cAQNCB+1jCBgYUmGlaUJ4INP8 zQgbxpuTx4LKcwY5SFzXeVcG4D+irRpI61HS2IJuB52VrSNO/RQqecNhHmxFBUc0en7p Ywn4BB0v4D0o7PiQz8FPFbHzq6XKVl/GXDoknTE7cInmr9hHSZHH2cpjC+jYvGTsOPnK F/zVj1Y1JjJM9YMY7FCUxqajhi3Vtjwx6C5KKK7jNq1rLWbmeF5qRddND8HTSxmUXtlM M3AQ== X-Gm-Message-State: AOAM533qlRlOTxBaB1wrYBktOnF2o+H3VVQi7sJZ9bVuzpUTezveHKam ulwCrZucxXSa3qE0Z0C2GxFU6yvigG1oyg== X-Google-Smtp-Source: ABdhPJwBQcR8sfQHDLKAuM+mCFeOgiTpXg52+wuVkXooqUMKDfPyInPANQwvb0ROk9D9NrHX0dACmg== X-Received: by 2002:a05:6a00:1494:b0:4f0:ece9:a01c with SMTP id v20-20020a056a00149400b004f0ece9a01cmr17484247pfu.58.1645986097953; Sun, 27 Feb 2022 10:21:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 6/7] target/nios2: Special case ipending in rdctl and wrctl Date: Sun, 27 Feb 2022 08:21:24 -1000 Message-Id: <20220227182125.21809-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::435 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986309878100001 Content-Type: text/plain; charset="utf-8" It was never correct to be able to write to ipending. Until the rest of the irq code is tidied, the read of ipending will generate an "unnecessary" mask. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/translate.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 52965ba17e..b17ce25a36 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -452,6 +452,15 @@ static void rdctl(DisasContext *dc, uint32_t code, uin= t32_t flags) } =20 switch (instr.imm5 + CR_BASE) { + case CR_IPENDING: + /* + * The value of the ipending register is synthetic. + * In hw, this is the AND of a set of hardware irq lines + * with the ienable register. In qemu, we re-use the space + * of CR_IPENDING to store the set of irq lines. + */ + tcg_gen_and_tl(cpu_R[instr.c], cpu_R[CR_IPENDING], cpu_R[CR_IENABL= E]); + break; default: tcg_gen_mov_tl(cpu_R[instr.c], cpu_R[instr.imm5 + CR_BASE]); break; @@ -477,6 +486,9 @@ static void wrctl(DisasContext *dc, uint32_t code, uint= 32_t flags) case CR_TLBMISC: gen_helper_mmu_write_tlbmisc(cpu_env, v); break; + case CR_IPENDING: + /* ipending is read only, writes ignored. */ + break; default: tcg_gen_mov_tl(cpu_R[instr.imm5 + CR_BASE], v); break; --=20 2.25.1 From nobody Mon Feb 9 15:00:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1645986323; cv=none; d=zohomail.com; s=zohoarc; b=ZTj6UKfEkXk60uTz37TEosR6SdaNqpYsSNXcO7nTDpFCVKZB1x/d2QMxqUdIF6kPkHdNGenTaNmH+/HnqRiMTpOFh6r/XPWFX53M/VNpy9uOJs8syg7ik4xqH+yUEYu/74SNU3O4wamXRmIRv7PpNi2PWyf7un6szbS67TeaD6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645986323; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1zSh8vavOK2dDRCHMdm2xP+DD5rjftdrYBF4cR1vNmw=; b=WEQyHiYXh/3zssyCgAXAlytw06jqrsn+pOi9kQswPZpbMrOziWIkCpNLDYiIVSdp5kyA8FAtR5ggc7nDedgI9uZtOpZJGM8bbKSOsv6S17FlNupLvlv1TD2pWSkH9X//vdABMQkqEc5DeMK7dxav+1o4LRdk7V6vThxMdkoUDic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645986323700909.6136209291573; Sun, 27 Feb 2022 10:25:23 -0800 (PST) Received: from localhost ([::1]:34922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOOEU-00028s-Ou for importer@patchew.org; Sun, 27 Feb 2022 13:25:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOOAw-0002tp-B1 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:42 -0500 Received: from [2607:f8b0:4864:20::1030] (port=41596 helo=mail-pj1-x1030.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOOAu-0007pT-P1 for qemu-devel@nongnu.org; Sun, 27 Feb 2022 13:21:42 -0500 Received: by mail-pj1-x1030.google.com with SMTP id ev16-20020a17090aead000b001bc3835fea8so9436947pjb.0 for ; Sun, 27 Feb 2022 10:21:40 -0800 (PST) Received: from localhost.localdomain (2603-800c-1201-c600-23be-43d9-7006-705a.res6.spectrum.com. [2603:800c:1201:c600:23be:43d9:7006:705a]) by smtp.gmail.com with ESMTPSA id t41-20020a056a0013a900b004e167af0c0dsm10776252pfg.89.2022.02.27.10.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 10:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1zSh8vavOK2dDRCHMdm2xP+DD5rjftdrYBF4cR1vNmw=; b=h/gDasq1Hy8kheLbjEQ4bSzKMb2frFHTbUNXStTJdhhonyD+YCFxVE601hUktz+WYm VVtgSq7myBFI0LaLI2g2T+jSBTSotFrES5W4BsmXKMpo9Fqns3RO2TFqoEKTdV09hn/a xOhr7j2YDZHB0ysY6HmrYQak0KnykwUan22KKpSjwHAEnDBFfWDY4g1nl9V1DMM/SJqf Soli+zKAtOA+lEAEk2Z4i9QF+LMZLWEJOyyfJYDaAEF7FEfPnou0PdM7PhJt1qEzr+TC 3PM4atTCk5BER5N2eIl7Ix6cb11VeQM51A95pFbInTN+dNC0oLXwmYYG5NKa3q6JYgw7 tJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1zSh8vavOK2dDRCHMdm2xP+DD5rjftdrYBF4cR1vNmw=; b=6bBYcxqR2rnjqwMGUvCBw5qXH6kGYGCHSV/q4SUmPLi8lAHPMADnJwqfMWOOljZZ7U 0qczKhkPft7c3ds3GF7r+n/iRvOnCgRi7E0InW+z0I9RJirBuKHk+R/kBu1jST3G7ZSF PbUEYUYFWoNiQiAlmwelh18HefdEwr/3yFjbOuhxr33pzPopFJ/mnjfULv6ISgpp3/9q YxNakzSpnteQSZuILPnOQtwMzWttTd4D/oixHQTKTqi9A9ftU+zqPuFb6BzHstGV5WFX 744SwNlAl3SXfWXkkpuUjX17h7RCPwKL4tN5vVJEawKVWBjoKc7n41Q7G9x0Aw3eIxWA fIHA== X-Gm-Message-State: AOAM530MPxNhqnN6IP76+U6q42y68q/H9Ih5H04mkV0GULd5OEBr9Ca+ 72dG1Y+/v/Z5gXqtDO9USQUoY2zbHcDmQg== X-Google-Smtp-Source: ABdhPJxCNsyJQrCi73wilJh4l0d8WXF4QU7Hxjh/hZJbnloKGiuTRH3Y0NgOVJlaa0h0KW+P66IRZQ== X-Received: by 2002:a17:90a:8d82:b0:1bc:6b54:e798 with SMTP id d2-20020a17090a8d8200b001bc6b54e798mr13092201pjo.77.1645986099405; Sun, 27 Feb 2022 10:21:39 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 7/7] target/nios2: Rewrite interrupt handling Date: Sun, 27 Feb 2022 08:21:25 -1000 Message-Id: <20220227182125.21809-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220227182125.21809-1-richard.henderson@linaro.org> References: <20220227182125.21809-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1030 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1645986325902100001 Content-Type: text/plain; charset="utf-8" Drop irq_pending boolean. Drop helper_check_interrupts. Move checks for irq disabled into nios2_cpu_exec_interrupt. End the TB on writes to ienable, just like to status. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/cpu.h | 1 - target/nios2/helper.h | 1 - target/nios2/cpu.c | 10 ++++------ target/nios2/op_helper.c | 19 ------------------- target/nios2/translate.c | 14 +++++--------- 5 files changed, 9 insertions(+), 36 deletions(-) diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h index d2ba0c5bbd..a00e4229ce 100644 --- a/target/nios2/cpu.h +++ b/target/nios2/cpu.h @@ -160,7 +160,6 @@ struct CPUNios2State { =20 #if !defined(CONFIG_USER_ONLY) Nios2MMU mmu; - uint32_t irq_pending; #endif int error_code; }; diff --git a/target/nios2/helper.h b/target/nios2/helper.h index 21ef7f0791..a44ecfdf7a 100644 --- a/target/nios2/helper.h +++ b/target/nios2/helper.h @@ -24,5 +24,4 @@ DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noret= urn, env, i32) DEF_HELPER_2(mmu_write_tlbacc, void, env, i32) DEF_HELPER_2(mmu_write_tlbmisc, void, env, i32) DEF_HELPER_2(mmu_write_pteaddr, void, env, i32) -DEF_HELPER_1(check_interrupts, void, env) #endif diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 4cade61e93..6975ae4bdb 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -73,12 +73,9 @@ static void nios2_cpu_set_irq(void *opaque, int irq, int= level) =20 env->regs[CR_IPENDING] =3D deposit32(env->regs[CR_IPENDING], irq, 1, != !level); =20 - env->irq_pending =3D env->regs[CR_IPENDING] & env->regs[CR_IENABLE]; - - if (env->irq_pending && (env->regs[CR_STATUS] & CR_STATUS_PIE)) { - env->irq_pending =3D 0; + if (env->regs[CR_IPENDING]) { cpu_interrupt(cs, CPU_INTERRUPT_HARD); - } else if (!env->irq_pending) { + } else { cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); } } @@ -134,7 +131,8 @@ static bool nios2_cpu_exec_interrupt(CPUState *cs, int = interrupt_request) CPUNios2State *env =3D &cpu->env; =20 if ((interrupt_request & CPU_INTERRUPT_HARD) && - (env->regs[CR_STATUS] & CR_STATUS_PIE)) { + (env->regs[CR_STATUS] & CR_STATUS_PIE) && + (env->regs[CR_IPENDING] & env->regs[CR_IENABLE])) { cs->exception_index =3D EXCP_IRQ; nios2_cpu_do_interrupt(cs); return true; diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c index d729379e4d..caa885f7b4 100644 --- a/target/nios2/op_helper.c +++ b/target/nios2/op_helper.c @@ -21,28 +21,9 @@ #include "qemu/osdep.h" #include "cpu.h" #include "exec/helper-proto.h" -#include "exec/cpu_ldst.h" #include "exec/exec-all.h" #include "qemu/main-loop.h" =20 -#if !defined(CONFIG_USER_ONLY) -static void nios2_check_interrupts(CPUNios2State *env) -{ - if (env->irq_pending && - (env->regs[CR_STATUS] & CR_STATUS_PIE)) { - env->irq_pending =3D 0; - cpu_interrupt(env_cpu(env), CPU_INTERRUPT_HARD); - } -} - -void helper_check_interrupts(CPUNios2State *env) -{ - qemu_mutex_lock_iothread(); - nios2_check_interrupts(env); - qemu_mutex_unlock_iothread(); -} -#endif /* !CONFIG_USER_ONLY */ - void helper_raise_exception(CPUNios2State *env, uint32_t index) { CPUState *cs =3D env_cpu(env); diff --git a/target/nios2/translate.c b/target/nios2/translate.c index b17ce25a36..ce3aacf59d 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -489,19 +489,15 @@ static void wrctl(DisasContext *dc, uint32_t code, ui= nt32_t flags) case CR_IPENDING: /* ipending is read only, writes ignored. */ break; + case CR_STATUS: + case CR_IENABLE: + /* If interrupts were enabled using WRCTL, trigger them. */ + dc->base.is_jmp =3D DISAS_UPDATE; + /* fall through */ default: tcg_gen_mov_tl(cpu_R[instr.imm5 + CR_BASE], v); break; } - - /* If interrupts were enabled using WRCTL, trigger them. */ - if ((instr.imm5 + CR_BASE) =3D=3D CR_STATUS) { - if (tb_cflags(dc->base.tb) & CF_USE_ICOUNT) { - gen_io_start(); - } - gen_helper_check_interrupts(cpu_env); - dc->base.is_jmp =3D DISAS_UPDATE; - } #endif } =20 --=20 2.25.1