From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551831875271.4736484921532; Tue, 22 Feb 2022 09:43:51 -0800 (PST) Received: from localhost ([::1]:59092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZCY-0003dL-Sb for importer@patchew.org; Tue, 22 Feb 2022 12:43:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7S-0003PE-SK for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:34 -0500 Received: from [2a00:1450:4864:20::532] (port=36581 helo=mail-ed1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7P-0002kl-0t for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:34 -0500 Received: by mail-ed1-x532.google.com with SMTP id cm8so29133075edb.3 for ; Tue, 22 Feb 2022 09:38:30 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IjU7t4xEBQGWyx6EMFWnMD35gczVylJjm0oYPCK2X/g=; b=FFhvUXT2KfPMwciuDPaKYkeMANhqhAzF4LnYk5NCC7H9i8koIJrgmT1A6H4mbocP2u UmrUoYMuV9P4R3BJKtytjy8qV3IBwhSFboRmkcvXJXlp81nzJJY/pQo3hGKBqNH3Cocp oOGIpNEmrorc1kzB5GKlwLyyuNV7/cdiZXomaVqA9ZLO4twPiuw+My9Omf5t/kWBCGPy 1O6Flu9JsR2fG8SYSMNKD8T6h4imRav0KgL3iJ8upOpmv9ODJx98GxzRHTqu5qO2ZwAN 8Glp+e1wb34Bqc2B4QkjlOAesvHjDeWxBu0koPPGCjbJ2oTEs09YsAad53/yqv5qUfmY lQDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IjU7t4xEBQGWyx6EMFWnMD35gczVylJjm0oYPCK2X/g=; b=Zs34YraM7MaLO+kByjosENW8K1rsbd39TIxPP8mVid3aODpAxsUek1n8CzGceIfGS/ dSfbigUWxmLGxQOm/YVeJoMtdnHZzVr6oSVD4vmBltX33HK9xuTjXzmMe1A/3DmVpsr/ 2kJMA91aa7OKs2lgTVUUCcQIMIfiv3e2vMyIVKYCnS33ZuORZJ5DtvP2KZFae/ITdCmH rOkGfln04GPlKS9IKWhO1SzYYXvirsfOGiHP8/bA3v7LpRcGZ2daziZw/KNzs1BMN9qu Lr500mqQq9t+WGszso/GWStIQPmOeOgbZXqnEyiwLkP7eO4gOYyiaMBpuHOL2b+t8R/W JedA== X-Gm-Message-State: AOAM533adhRLkYOzOfTr/mo9QkKwhNMSBhKlmhdvaXovDmNXLH79R7jr n2BYQLDiscvqoIQPUmdyWytgjASSyzY= X-Google-Smtp-Source: ABdhPJwaXIqK/0li13JVSVwwFcLzyqi6xebd5BwvbaN00l5zZoTEzXmnxTvC09d/R5w1qvaI1Fk11A== X-Received: by 2002:a05:6402:2546:b0:412:d0eb:2a4a with SMTP id l6-20020a056402254600b00412d0eb2a4amr21100290edb.306.1645551509416; Tue, 22 Feb 2022 09:38:29 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number Date: Tue, 22 Feb 2022 18:37:58 +0100 Message-Id: <20220222173819.76568-2-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::532 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=shentey@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Bernhard Beschow , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645551833506100001 Content-Type: text/plain; charset="utf-8" Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- hw/rtc/mc146818rtc.c | 8 ++++++-- include/hw/rtc/mc146818rtc.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 0fe7b69bc4..cb291d121c 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -197,7 +197,7 @@ static void piix4_realize(PCIDevice *dev, Error **errp) if (!qdev_realize(DEVICE(&s->rtc), BUS(isa_bus), errp)) { return; } - isa_init_irq(ISA_DEVICE(&s->rtc), &s->rtc.irq, RTC_ISA_IRQ); + isa_init_irq(ISA_DEVICE(&s->rtc), &s->rtc.irq, s->rtc.isairq); =20 piix4_dev =3D dev; } diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index e61a0cced4..f300f40257 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -956,15 +956,17 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_ye= ar, qemu_irq intercept_irq) { DeviceState *dev; ISADevice *isadev; + RTCState *s; =20 isadev =3D isa_new(TYPE_MC146818_RTC); dev =3D DEVICE(isadev); + s =3D MC146818_RTC(isadev); qdev_prop_set_int32(dev, "base_year", base_year); isa_realize_and_unref(isadev, bus, &error_fatal); if (intercept_irq) { qdev_connect_gpio_out(dev, 0, intercept_irq); } else { - isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ); + isa_connect_gpio_out(isadev, 0, s->isairq); } =20 object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isade= v), @@ -975,6 +977,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year= , qemu_irq intercept_irq) =20 static Property mc146818rtc_properties[] =3D { DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980), + DEFINE_PROP_UINT32("irq", RTCState, isairq, RTC_ISA_IRQ), DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, lost_tick_policy, LOST_TICK_POLICY_DISCARD), DEFINE_PROP_END_OF_LIST(), @@ -1010,6 +1013,7 @@ static void rtc_reset_hold(Object *obj) =20 static void rtc_build_aml(ISADevice *isadev, Aml *scope) { + RTCState *s =3D MC146818_RTC(isadev); Aml *dev; Aml *crs; =20 @@ -1020,7 +1024,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml *sco= pe) crs =3D aml_resource_template(); aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, 0x01, 0x08)); - aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); + aml_append(crs, aml_irq_no_flags(s->isairq)); =20 dev =3D aml_device("RTC"); aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00"))); diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h index 5b45b22924..c7586589ad 100644 --- a/include/hw/rtc/mc146818rtc.h +++ b/include/hw/rtc/mc146818rtc.h @@ -26,6 +26,7 @@ struct RTCState { uint8_t cmos_data[128]; uint8_t cmos_index; int32_t base_year; + uint32_t isairq; uint64_t base_rtc; uint64_t last_update; int64_t offset; --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551660604388.01047868990634; Tue, 22 Feb 2022 09:41:00 -0800 (PST) Received: from localhost ([::1]:50732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZ9n-0006Ou-Cm for importer@patchew.org; Tue, 22 Feb 2022 12:40:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7T-0003Pe-79; Tue, 22 Feb 2022 12:38:35 -0500 Received: from [2a00:1450:4864:20::529] (port=41692 helo=mail-ed1-x529.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7Q-0002kr-Ki; Tue, 22 Feb 2022 12:38:34 -0500 Received: by mail-ed1-x529.google.com with SMTP id w3so38746110edu.8; Tue, 22 Feb 2022 09:38:31 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hu2rdGt9hnCPLiEwvn+rLf/s7l/Y32BM0wU7w8P1XdI=; b=JpOS/IAXSki0RhrvpKFvleiKgfXBy7Wcl4FufF/+CwFjxbHbyrpXNeoPsJ8FPGk3pI 2KjncnXTMDWMZ8YMQHHXWW4xjrX9FzASI1TcABWn6ulkDNTXYxvZl+Fuq0SkZp44qY8b X0fg3KcuAzMkHzK6lsDHKvlWvn0tm9yROEJ9lrSf69lJBTZ7kr0fdlrXLxODXAfwBfBe Ol3DDY/MOXo4Dg9wnoxk0bbMl+anwjTUqy9wiaxd08337DAcGZPZ8awtpJndhpGRxbvA iLAtgpS7wrQ9tfFNtFxNa8JWYvDFFR/UHlYfHYIUy7iDWE9Adyl+RqYfC0Kv3L3aNycy feAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hu2rdGt9hnCPLiEwvn+rLf/s7l/Y32BM0wU7w8P1XdI=; b=OEu3/pI9Bnr5jNl1SGp+8d/2FcpZvKCmL7gjdSlEjUkST6KVx1oCeyeOceLWiyxPnb U0vjN8Gbtz0rfdcqYFvDxoRRj0BzoO3aNUKqhcZyQgai2Q4vCz6Rh+g3LBaE4E3UZqEY VzA2c08/FSet2eM3MRs05HapGQyiXncjMVgj2JmwhnVEMdx/LCdEpu90jTUInZ23K75f ck+ZBweEkFlIRERepFSXV/HAF0ajPAHJLPIjdBe4qU2pcuIs0SDY+Mcc4Rv7++xZn/zQ q7Ve0qIDldJGRmgxbhsc1tE4pZO9lA1bbhl5VitEl+eZbkt4QxW53kLU4f2Udr1sCvku O4wg== X-Gm-Message-State: AOAM533nAoX6/iugse25LY53AWBlN2FUIrY42EAL8O+l1J0WfOsMdmiR OVpc9eL+VjPaxNAFKCNLI7HKHSmE4EM= X-Google-Smtp-Source: ABdhPJxRUXDtES9+8J3Gt8DfCdGUekFNqfYevauT/Cz1rP87bxm8Su38HjSbUPiIS0LSDbIilbT5Pg== X-Received: by 2002:a05:6402:4245:b0:410:ee7d:8f0b with SMTP id g5-20020a056402424500b00410ee7d8f0bmr27537067edb.295.1645551510306; Tue, 22 Feb 2022 09:38:30 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number Date: Tue, 22 Feb 2022 18:37:59 +0100 Message-Id: <20220222173819.76568-3-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::529 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=shentey@gmail.com; helo=mail-ed1-x529.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:PReP" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645551662451100001 Content-Type: text/plain; charset="utf-8" Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c index dc21fb10a5..d1c1d789a5 100644 --- a/hw/rtc/m48t59-isa.c +++ b/hw/rtc/m48t59-isa.c @@ -42,6 +42,7 @@ struct M48txxISAState { ISADevice parent_obj; M48t59State state; uint32_t io_base; + uint32_t isairq; MemoryRegion io; }; =20 @@ -79,6 +80,7 @@ static void m48txx_isa_toggle_lock(Nvram *obj, int lock) static Property m48t59_isa_properties[] =3D { DEFINE_PROP_INT32("base-year", M48txxISAState, state.base_year, 0), DEFINE_PROP_UINT32("iobase", M48txxISAState, io_base, 0x74), + DEFINE_PROP_UINT32("irq", M48txxISAState, isairq, 8), DEFINE_PROP_END_OF_LIST(), }; =20 @@ -99,7 +101,7 @@ static void m48t59_isa_realize(DeviceState *dev, Error *= *errp) =20 s->model =3D u->info.model; s->size =3D u->info.size; - isa_init_irq(isadev, &s->IRQ, 8); + isa_init_irq(isadev, &s->IRQ, d->isairq); m48t59_realize_common(s, errp); memory_region_init_io(&d->io, OBJECT(dev), &m48t59_io_ops, s, "m48t59"= , 4); if (d->io_base !=3D 0) { --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551642734247.38581664632716; Tue, 22 Feb 2022 09:40:42 -0800 (PST) Received: from localhost ([::1]:50422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZ9U-0006CO-Gp for importer@patchew.org; Tue, 22 Feb 2022 12:40:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7S-0003N0-2n for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:34 -0500 Received: from [2a00:1450:4864:20::536] (port=37882 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7Q-0002l1-Hz for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:33 -0500 Received: by mail-ed1-x536.google.com with SMTP id q17so38939772edd.4 for ; Tue, 22 Feb 2022 09:38:32 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zLKgVUqBRhF999JiE5cE0vH6qtNFqrzfmojjNGgYENI=; b=PZhLB7jARlosefo7OAuJOyiSmVFEeji6bSMrvdFttg4nr6DUWiiu5m6KSE6cK6KTBq ooN5bmndNWITEYHLUqtDRPGIWnaBo55h8Q2Yj0VJLt5htfHNuHTCIZaJa+1yCjHGb+MW ArRLSD/LY6lZ3bvLHQk7F1NDgP1p7b1WKv5QQT+IDqx2juJzJ0Y6WZmLGJiy+iDpcD5v FNAP/aBbeBGzSi/jOd8I+eJ471asXqLKAodlF9t9Vd+YKjxnT8Hiwljm9G/TBJUMXkbx GH8IJn7tyXz0eDt3GHp5i37XSbKFgdbkPVCO2wI5feTpEOH1XNG3NEHgkIq9MmB4vTBV FNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zLKgVUqBRhF999JiE5cE0vH6qtNFqrzfmojjNGgYENI=; b=Ixrl+5E7z0RpDr1Vfu0CU7FpfklNI5m7/Tt7UXWf1W0OPTJtFB6aUDJZ1T5Y/dtvAL sifo0tXIeSJ0rXZPVL7Kjq39OtNLQJDdPaB8EtmqwSMUmNBUcpaB/AqcpX7DMsZheumu 2PNhZAiD6IyKCxsmb3EthgbmnpdN+udpn7HlMNiDs+KHc1DITXKzn+fW1qa8X/6A13MD BAQ3CQa0aq6KkNoPvoeKeSD5/Mf+TYpCHQDzsLW4mjDKRnb6uLJg2EYO/amZ9hTdOUsx Lv8nLfNvGTlnuc3txumutFo1Fmipk4G+zoNOgBVsVC43ZLH54te20XGKzoVWco3OqQI7 RjRw== X-Gm-Message-State: AOAM530xuNnN+MFfL3oivActSmzyGKS/S5dsR2DIkmx0LDG6Bj8D0MAW pyhSTrHf2ZWJYNAU/V9abmaxlJTf4vg= X-Google-Smtp-Source: ABdhPJxAKePnhi+61YVCmIuTnPu0uu0UXCoQaXRqNXdG4OmuK+SOQC4w4bYodG2KJCGdocs7j92+Aw== X-Received: by 2002:aa7:d415:0:b0:410:a0fa:dc40 with SMTP id z21-20020aa7d415000000b00410a0fadc40mr27439740edq.46.1645551511072; Tue, 22 Feb 2022 09:38:31 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 03/22] hw/input/pckbd: QOM'ify IRQ numbers Date: Tue, 22 Feb 2022 18:38:00 +0100 Message-Id: <20220222173819.76568-4-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=shentey@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Bernhard Beschow , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645551643969100001 Content-Type: text/plain; charset="utf-8" Exposing the IRQ numbers as a QOM properties not only allows them to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index baba62f357..e56bee87d2 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -671,6 +671,8 @@ struct ISAKBDState { KBDState kbd; bool kbd_throttle; MemoryRegion io[2]; + uint32_t kbd_irq; + uint32_t mouse_irq; }; =20 void i8042_isa_mouse_fake_event(ISAKBDState *isa) @@ -734,8 +736,8 @@ static void i8042_realizefn(DeviceState *dev, Error **e= rrp) ISAKBDState *isa_s =3D I8042(dev); KBDState *s =3D &isa_s->kbd; =20 - isa_init_irq(isadev, &s->irq_kbd, 1); - isa_init_irq(isadev, &s->irq_mouse, 12); + isa_init_irq(isadev, &s->irq_kbd, isa_s->kbd_irq); + isa_init_irq(isadev, &s->irq_mouse, isa_s->mouse_irq); =20 isa_register_ioport(isadev, isa_s->io + 0, 0x60); isa_register_ioport(isadev, isa_s->io + 1, 0x64); @@ -754,6 +756,7 @@ static void i8042_realizefn(DeviceState *dev, Error **e= rrp) =20 static void i8042_build_aml(ISADevice *isadev, Aml *scope) { + ISAKBDState *isa_s =3D I8042(isadev); Aml *kbd; Aml *mou; Aml *crs; @@ -761,7 +764,7 @@ static void i8042_build_aml(ISADevice *isadev, Aml *sco= pe) crs =3D aml_resource_template(); aml_append(crs, aml_io(AML_DECODE16, 0x0060, 0x0060, 0x01, 0x01)); aml_append(crs, aml_io(AML_DECODE16, 0x0064, 0x0064, 0x01, 0x01)); - aml_append(crs, aml_irq_no_flags(1)); + aml_append(crs, aml_irq_no_flags(isa_s->kbd_irq)); =20 kbd =3D aml_device("KBD"); aml_append(kbd, aml_name_decl("_HID", aml_eisaid("PNP0303"))); @@ -769,7 +772,7 @@ static void i8042_build_aml(ISADevice *isadev, Aml *sco= pe) aml_append(kbd, aml_name_decl("_CRS", crs)); =20 crs =3D aml_resource_template(); - aml_append(crs, aml_irq_no_flags(12)); + aml_append(crs, aml_irq_no_flags(isa_s->mouse_irq)); =20 mou =3D aml_device("MOU"); aml_append(mou, aml_name_decl("_HID", aml_eisaid("PNP0F13"))); @@ -783,6 +786,8 @@ static void i8042_build_aml(ISADevice *isadev, Aml *sco= pe) static Property i8042_properties[] =3D { DEFINE_PROP_BOOL("extended-state", ISAKBDState, kbd.extended_state, tr= ue), DEFINE_PROP_BOOL("kbd-throttle", ISAKBDState, kbd_throttle, false), + DEFINE_PROP_UINT32("kbd-irq", ISAKBDState, kbd_irq, 1), + DEFINE_PROP_UINT32("mouse-irq", ISAKBDState, mouse_irq, 12), DEFINE_PROP_END_OF_LIST(), }; =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552075650924.3556461055902; Tue, 22 Feb 2022 09:47:55 -0800 (PST) Received: from localhost ([::1]:40656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZGU-0001pb-B7 for importer@patchew.org; Tue, 22 Feb 2022 12:47:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7U-0003T8-Q2; Tue, 22 Feb 2022 12:38:36 -0500 Received: from [2a00:1450:4864:20::536] (port=34606 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7R-0002lk-P5; Tue, 22 Feb 2022 12:38:36 -0500 Received: by mail-ed1-x536.google.com with SMTP id z22so38706051edd.1; Tue, 22 Feb 2022 09:38:33 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U03uat2K/JdNuPwOAoEK+Plxb6frNDBLdlFpMsBFliQ=; b=phD3godSI6Ly/nbEfkFlc5QjFEkT+oaxL51g59JLbO//EvVUSIHmYfEk3nQv+BvaY/ UeBZp41Dp2CrIu6gHFxXMG5C2gciaQnWTPl1aTe4JVt6/ekf6sTBB7HDLOTRFev/wAjt 7fnYlkdiexTT/sQlY/uzKoMCs8Ma6IlNmQ4fmCKanbeV065Is//M0eyXWcNvRSQFp4pO X3kzAFAuGUae1vYo2MclF5pqmlm2zyJQEglr6Orja79J+UATtAHZSpcjUoD0QqWriemt 9MKS6y6l8ZfHLq+53csQWsrNrIFY4rSgscI8FJXP0/HnLnrYTX9DxB+XRpnwVAjFMPkw YpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U03uat2K/JdNuPwOAoEK+Plxb6frNDBLdlFpMsBFliQ=; b=55gT40w60fGlZp98JPAWIER99is2gCPZp0BEb+u89KCG4acNGC8V96QBBKIhq35NiI AMVPfbxEWkLWw4SPhAdA2MjcraQ9CsQplPmndD/LUJkNFUCbg2RUW0Ftu0MgesC+OyIj Em3AXF/OoaeQi7NhkUL0NN9HMGVFSEcAD10IT9qBZPQrFgObNt0NGyjw2UBcPdeQ2Z10 1g2ACDhdGG4CRR/NdwmW3AQuRzNcBnFZy7WjKhGOlp4ihF+mh05PhB6zFyXONf4WSZgK 2qe0OFECkmgGXigL10wDkC9ip7l/ErghKYPFsFOh0QESkVWMAzmZRNCU8kYuSHgR/uWf qpQA== X-Gm-Message-State: AOAM531AKYU9/z8ys8QLM5eFklKl4DFmwuZ7+J73+sDzidGNLbu2s8zB B69OQCMuWgkBVpBFOgCGsdpZqywjvBs= X-Google-Smtp-Source: ABdhPJxQPBT5KbUEUUcf6WYbE4HBJZw8vzUfKXjorYIYN+AmjR03jEhKjMtFZTNqzba+3JPbfbdtJg== X-Received: by 2002:a50:fb91:0:b0:408:5100:b4a7 with SMTP id e17-20020a50fb91000000b004085100b4a7mr27061125edq.311.1645551511940; Tue, 22 Feb 2022 09:38:31 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 04/22] hw/isa/isa-bus: Remove isabus_dev_print() Date: Tue, 22 Feb 2022 18:38:01 +0100 Message-Id: <20220222173819.76568-5-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=shentey@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Hanna Reitz , Bernhard Beschow , "open list:Block layer core" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552078047100001 Content-Type: text/plain; charset="utf-8" All isabus_dev_print() did was to print up to two IRQ numbers per device. This is redundant if the IRQ numbers are present as QOM properties (see e.g. the modified tests/qemu-iotests/172.out). Now that the last devices relying on isabus_dev_print() had their IRQ numbers QOM'ified, the contribution of this function ultimately became redundant. Remove it. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 16 ---------------- tests/qemu-iotests/172.out | 26 -------------------------- 2 files changed, 42 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 6c31398dda..af5add6a26 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -21,21 +21,18 @@ #include "qemu/error-report.h" #include "qemu/module.h" #include "qapi/error.h" -#include "monitor/monitor.h" #include "hw/sysbus.h" #include "sysemu/sysemu.h" #include "hw/isa/isa.h" =20 static ISABus *isabus; =20 -static void isabus_dev_print(Monitor *mon, DeviceState *dev, int indent); static char *isabus_get_fw_dev_path(DeviceState *dev); =20 static void isa_bus_class_init(ObjectClass *klass, void *data) { BusClass *k =3D BUS_CLASS(klass); =20 - k->print_dev =3D isabus_dev_print; k->get_fw_dev_path =3D isabus_get_fw_dev_path; } =20 @@ -222,19 +219,6 @@ void isa_build_aml(ISABus *bus, Aml *scope) } } =20 -static void isabus_dev_print(Monitor *mon, DeviceState *dev, int indent) -{ - ISADevice *d =3D ISA_DEVICE(dev); - - if (d->isairq[1] !=3D -1) { - monitor_printf(mon, "%*sisa irqs %d,%d\n", indent, "", - d->isairq[0], d->isairq[1]); - } else if (d->isairq[0] !=3D -1) { - monitor_printf(mon, "%*sisa irq %d\n", indent, "", - d->isairq[0]); - } -} - static void isabus_bridge_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); diff --git a/tests/qemu-iotests/172.out b/tests/qemu-iotests/172.out index 4cf4d536b4..9479b92185 100644 --- a/tests/qemu-iotests/172.out +++ b/tests/qemu-iotests/172.out @@ -15,7 +15,6 @@ Testing: fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -43,7 +42,6 @@ Testing: -fda TEST_DIR/t.qcow2 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -81,7 +79,6 @@ Testing: -fdb TEST_DIR/t.qcow2 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -135,7 +132,6 @@ Testing: -fda TEST_DIR/t.qcow2 -fdb TEST_DIR/t.qcow2.2 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -190,7 +186,6 @@ Testing: -fdb fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -230,7 +225,6 @@ Testing: -drive if=3Dfloppy,file=3DTEST_DIR/t.qcow2 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -268,7 +262,6 @@ Testing: -drive if=3Dfloppy,file=3DTEST_DIR/t.qcow2,ind= ex=3D1 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -322,7 +315,6 @@ Testing: -drive if=3Dfloppy,file=3DTEST_DIR/t.qcow2 -dr= ive if=3Dfloppy,file=3DTEST_DIR/t fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -380,7 +372,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -devi= ce floppy,drive=3Dnone0 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -418,7 +409,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -devi= ce floppy,drive=3Dnone0,unit=3D1 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -456,7 +446,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -driv= e if=3Dnone,file=3DTEST_DIR/t.qco fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -520,7 +509,6 @@ Testing: -fda TEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -device fl fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -575,7 +563,6 @@ Testing: -fda TEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -device fl fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -630,7 +617,6 @@ Testing: -fdb TEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -device fl fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -685,7 +671,6 @@ Testing: -fdb TEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -device fl fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -749,7 +734,6 @@ Testing: -drive if=3Dfloppy,file=3DTEST_DIR/t.qcow2 -dr= ive if=3Dnone,file=3DTEST_DIR/t.q fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -804,7 +788,6 @@ Testing: -drive if=3Dfloppy,file=3DTEST_DIR/t.qcow2 -dr= ive if=3Dnone,file=3DTEST_DIR/t.q fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -865,7 +848,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -glob= al floppy.drive=3Dnone0 -device fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -933,7 +915,6 @@ Testing: -device floppy fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -958,7 +939,6 @@ Testing: -device floppy,drive-type=3D120 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -983,7 +963,6 @@ Testing: -device floppy,drive-type=3D144 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -1008,7 +987,6 @@ Testing: -device floppy,drive-type=3D288 fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -1036,7 +1014,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -de= vice floppy,drive=3Dnone0,drive-t fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -1074,7 +1051,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -de= vice floppy,drive=3Dnone0,drive-t fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -1115,7 +1091,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -de= vice floppy,drive=3Dnone0,logical fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" @@ -1153,7 +1128,6 @@ Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -de= vice floppy,drive=3Dnone0,physica fdtypeA =3D "auto" fdtypeB =3D "auto" fallback =3D "288" - isa irq 6 bus: floppy-bus.0 type floppy-bus dev: floppy, id "" --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552273316968.4984281511802; Tue, 22 Feb 2022 09:51:13 -0800 (PST) Received: from localhost ([::1]:48672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZJg-0007Ej-2a for importer@patchew.org; Tue, 22 Feb 2022 12:51:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7X-0003cP-EM; Tue, 22 Feb 2022 12:38:39 -0500 Received: from [2a00:1450:4864:20::635] (port=40835 helo=mail-ej1-x635.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7S-0002lq-MX; Tue, 22 Feb 2022 12:38:39 -0500 Received: by mail-ej1-x635.google.com with SMTP id p15so45047307ejc.7; Tue, 22 Feb 2022 09:38:34 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XDgj4joug7f4HE4WKfuyWjX5As+7XR/H8T7Cnx16Sm4=; b=bUfdlDP8hXNh4Frsh9RMNmjvxfgsJQR8rYMn1yjj+cHREzLSa7+suZj1C49mpTHyyv IQNv8fFfShaeHYS9+Wdpv9F5MkXt7aBbceRhLlnm08yGK1KI7Xk4GXoWMoeHNCRgatVG 0+iPQcVOLolSFUUhO11tpapllX3D0kuMu4u1qKWpsteB4Xzb/9yvebDgRd6vaO92UuoF KhVictBTVRAirtUmb51gkOm5ziF13gHBR9MyMcRKMmGbhliK5lBcnZoeLOOJdVhcl7lQ KByb91b+gyJ6ygaC+dUC7kdReKxIyQxQgGEHZ8GxLJ3WcTXt8WOYCezQWLs+20gqbaBT SdxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XDgj4joug7f4HE4WKfuyWjX5As+7XR/H8T7Cnx16Sm4=; b=HqT8pIplfhzMawkrXyDfFgEL2kyMnHRQR27+rmLb7d9KYNBU1ddKMlDMy53tSU5XUg wm1mowBLILdrgeehr0i+VPC/X7e1HdH3Q1LFwvLl5lFkzt1bsQ8U+IsOSHvy/cfTsqQP TFPiaej5P1v07HEJ2C/ln6jnFGDaUawmaudmSNkW33vxmm98Z65VzC/UQeU8eB/QHxm6 NgV+Ep96nzLxDj3YNegVqNUC3IgaGRh/P/Wlz55ttGxhoK4XbAegsyGgmnanBI3vdWiA nJprbm75nonuAX0EprUy7Y7Rb+dieolNfUMXQL9yuuZ3jaVywKSY4MfUDsE87tRvrXH/ wp9A== X-Gm-Message-State: AOAM532+J/ZH1g/cubo6zjZUmV1aVz97bwRiFCwY47U7gHSBKFdD8GiV 3DjqCzxNTQJ5L9ahuyqsb95xBngvdhU= X-Google-Smtp-Source: ABdhPJy0OvCN3QIBerNe2137UH+jtukWAt/ymRUr9SxiLgQs7TFySubnTlzC6Dm2RVnNiSuPDNlTGg== X-Received: by 2002:a17:906:7a58:b0:6cd:a6bf:127 with SMTP id i24-20020a1709067a5800b006cda6bf0127mr19937649ejo.29.1645551512828; Tue, 22 Feb 2022 09:38:32 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property Date: Tue, 22 Feb 2022 18:38:02 +0100 Message-Id: <20220222173819.76568-6-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::635 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=shentey@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:PowerNV Non-Virt..." , Bernhard Beschow , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552275188100001 Content-Type: text/plain; charset="utf-8" Determine the IRQ number in the same way as for isa-ipmi-bt. This resolves the last usage of ISADevice::isairq[] which allows it to be removed. Signed-off-by: Bernhard Beschow --- hw/ppc/pnv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 837146a2fb..1e9f6b0690 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -380,9 +380,12 @@ static void pnv_dt_serial(ISADevice *d, void *fdt, int= lpc_off) cpu_to_be32(io_base), cpu_to_be32(8) }; + uint32_t irq; char *name; int node; =20 + irq =3D object_property_get_int(OBJECT(d), "irq", &error_fatal); + name =3D g_strdup_printf("%s@i%x", qdev_fw_name(DEVICE(d)), io_base); node =3D fdt_add_subnode(fdt, lpc_off, name); _FDT(node); @@ -394,7 +397,7 @@ static void pnv_dt_serial(ISADevice *d, void *fdt, int = lpc_off) =20 _FDT((fdt_setprop_cell(fdt, node, "clock-frequency", 1843200))); _FDT((fdt_setprop_cell(fdt, node, "current-speed", 115200))); - _FDT((fdt_setprop_cell(fdt, node, "interrupts", d->isairq[0]))); + _FDT((fdt_setprop_cell(fdt, node, "interrupts", irq))); _FDT((fdt_setprop_cell(fdt, node, "interrupt-parent", fdt_get_phandle(fdt, lpc_off)))); =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645551863; cv=none; d=zohomail.com; s=zohoarc; b=mCktUfYfdU+++IRXu9AtJyPXg63ScvvYC7Y2Ev2pQw7nLTtq12HI+ZwQElbbBngC16Tch34BzEYElIvxwNtYvRBaMSQHlhtdsZBVw+ArIanJYCvhHo7eg/96FG30UkJIk5toRUWniPu0sC3liRJ0xmpUwiREUf3brIz+QXZ6TCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645551863; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NSkH+rZ7LIEEh7cIevAxKcBEWeFcCPnBblGfAJiA4f4=; b=FFEDxKX6Xq/M6A0TE7gSNEFeFD6DgTDIDT/db0izfb3o7lpHi1rkCfMANRBkp/pEL112BHEuKO23WZESdozUruN8Tb7tBm07AOF8UD9hNrmfE29EpFO9iEA1hMDxySNxZtEHuZjxoF5j6ErDME/fTEUrYFzjSqLOVT9ECxSAwlE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551863515205.81766007084946; Tue, 22 Feb 2022 09:44:23 -0800 (PST) Received: from localhost ([::1]:60488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZD4-0004Y9-Gb for importer@patchew.org; Tue, 22 Feb 2022 12:44:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7V-0003VE-Ko for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:37 -0500 Received: from [2a00:1450:4864:20::633] (port=44603 helo=mail-ej1-x633.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7T-0002m4-4r for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:37 -0500 Received: by mail-ej1-x633.google.com with SMTP id p14so45076816ejf.11 for ; Tue, 22 Feb 2022 09:38:34 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NSkH+rZ7LIEEh7cIevAxKcBEWeFcCPnBblGfAJiA4f4=; b=Ggob4pzkG1UvrEaNDh+ue5L9H5SeNzadxF0CPT1mJHasMrdi6S+2wEjmLHrDJ3diMF DucIJ9R73KPfN/pOJ8QOyh4uK2q44NhRIs34dlZRESGzGrI5SqODd25XIQKqo0lm6NVN MTotg9xBMSJVPYZOi9zwGlcVBQHaIA3aulEu2ndzMcAvAxi8bJj9eAS8buEg07BMh9fi oMZ+BWZEWNwsYsSpWapLbaHCMQ/2kAXj8fc9FNVkBN8ys2PXK1rdp0pSBddksB97ecTH 4Q00yybOdLffUZ0Mx7u+eKLzf2OPruhPTxlvAehxxvdWUBPIzt7mXxFEHRJvxRmCUrvh AGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NSkH+rZ7LIEEh7cIevAxKcBEWeFcCPnBblGfAJiA4f4=; b=BpqoSQjwYT6YYr5NmqRpSs0tn3tIffXa/E/wUdal8K8r7toHFEDE7T+8PGxWPSJVY1 bMTl+PCr9STcjXjZs+R0wJUsh04KBVoqKJweHucrhTpPxMioG696kD+33agrVHOe1Ml4 DJmRgOdV1XwSEuiPO5jcLoY+DgEG7Bih4UogCQWiDa5JvxgvG0uMSTbKK5/A8HCLEDNj p5zVbc7Z26lIp5nM67LreVtpTheGw1te6AyIDVMUyqA5ZjOPvLdDlGh2LsJPDddr3vXU MRSqCKiJ6ZMtrOpXWhSVEkZoKOWsOXMt6cm+ktYL0uw6cy4Ukcpo8L/zEfmqePQCHRq7 xk2g== X-Gm-Message-State: AOAM532mOb0/C1t2mVtVU4mCr7okhUgj7hsmviqWKgYJ4kNQGyjkzl6P 4FWHo/XuiY6AvUojYnz4OyKxd5Y1EV4= X-Google-Smtp-Source: ABdhPJzskGPCQNMPoIFqGE93CBMncUXZ/EtHUwaV8Kvs/nfr+CCS9eftbpgJhcD38aJx1mFEjtU3XQ== X-Received: by 2002:a17:906:6b8e:b0:6cf:8e6e:609a with SMTP id l14-20020a1709066b8e00b006cf8e6e609amr20193328ejr.243.1645551513751; Tue, 22 Feb 2022 09:38:33 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 06/22] isa: Drop unused attributes from ISADevice Date: Tue, 22 Feb 2022 18:38:03 +0100 Message-Id: <20220222173819.76568-7-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::633 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=shentey@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645551865740100001 Content-Type: text/plain; charset="utf-8" Now that the last users of ISADevice::isairq[] have been resolved during the previous commits, it can be removed for good. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 13 ------------- include/hw/isa/isa.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index af5add6a26..c64a14120b 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -87,11 +87,7 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq) =20 void isa_init_irq(ISADevice *dev, qemu_irq *p, unsigned isairq) { - assert(dev->nirqs < ARRAY_SIZE(dev->isairq)); - assert(isairq < ISA_NUM_IRQS); - dev->isairq[dev->nirqs] =3D isairq; *p =3D isa_get_irq(dev, isairq); - dev->nirqs++; } =20 void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq) @@ -150,14 +146,6 @@ int isa_register_portio_list(ISADevice *dev, return 0; } =20 -static void isa_device_init(Object *obj) -{ - ISADevice *dev =3D ISA_DEVICE(obj); - - dev->isairq[0] =3D -1; - dev->isairq[1] =3D -1; -} - ISADevice *isa_new(const char *name) { return ISA_DEVICE(qdev_new(name)); @@ -244,7 +232,6 @@ static const TypeInfo isa_device_type_info =3D { .name =3D TYPE_ISA_DEVICE, .parent =3D TYPE_DEVICE, .instance_size =3D sizeof(ISADevice), - .instance_init =3D isa_device_init, .abstract =3D true, .class_size =3D sizeof(ISADeviceClass), .class_init =3D isa_device_class_init, diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index d4417b34b6..d80cab5b79 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -83,8 +83,6 @@ struct ISADevice { DeviceState parent_obj; /*< public >*/ =20 - int8_t isairq[2]; /* -1 =3D unassigned */ - int nirqs; int ioport_id; }; =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645551834; cv=none; d=zohomail.com; s=zohoarc; b=CMhi31JBQfe+n0FY7wymvWhLgEAtfYyMZqKBeK+s4Luaa9jTeAhpR/SWkTtGH3jb4qLUdsvu5xoJHlR6+Gq68kUqCFChccFFZ4MLLXcyADXeQbR4azCBH70zinN93FmVbAUKn3UaPjX0ankLXk0ETPsXa1JeqAXVY+z+7cOZmV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645551834; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v+v6TfEZmb9wwuiX3YkPxG5IdVxlkTReFcgd8M252ME=; b=bU6xgJM9jdOO0Qg/TLe6UTBTEJLWCrjjxSr642WrTE092+zjD09XMjaJEvPEbctSvgvpeGre6wn25hdCzm0BKCya7/emkKnd90zrp0UmA2yBZtYijsjYWLHLdqan/IWn0vqUn5gFx/n49qY/lLzuSlnuihK5kOEbRNwkBpI2pAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551834352872.3687903963648; Tue, 22 Feb 2022 09:43:54 -0800 (PST) Received: from localhost ([::1]:59292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZCb-0003lv-By for importer@patchew.org; Tue, 22 Feb 2022 12:43:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7V-0003Vl-Pa for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:37 -0500 Received: from [2a00:1450:4864:20::536] (port=35744 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7T-0002mO-Rt for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:37 -0500 Received: by mail-ed1-x536.google.com with SMTP id bq11so17423130edb.2 for ; Tue, 22 Feb 2022 09:38:35 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v+v6TfEZmb9wwuiX3YkPxG5IdVxlkTReFcgd8M252ME=; b=gL0hMcdBN8hz7YtN9uApjaH9NflMXfBsOVJngeYQicRnNyhpVq+pusx1vp379aZEYc fWKT4rhThPnp1Hq5BRlAr4iacUhrtrZAtqEOJAm+SusJXE0bCPPMmQUqdZCN6Nha6t+F NSMB12opEQHAg24QGswiDpaneIkiXMDkP9nQl3tTZUZxBcfRPxJDD/WofnjGc4OUoEYM cQRgKfxcFgl1Cg4cpQHazT9Rf5mHtLAeYviFQZSny4VE/up4XRPO0yncMR5lELBx7Ysy E2epMKmiLgxbNjbZgvQQfnJKd5snVVlhKX/qqyDoHCiiO9m3MITCiNU8NHBojkVindf5 lP4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v+v6TfEZmb9wwuiX3YkPxG5IdVxlkTReFcgd8M252ME=; b=nUWmQxtwZewIK9A5FE4o1Sq1gbWOV/uxvaEqcUEmSMckSvSF0zQxv6ae4K2GCHZhti hEWKfPj4pmF39G5qMZ0GXNEpMOgQurKVBn8yMbMM202eMQg+SN4mCk6bL9Z8+ycgtdBR afBBv0pdQQeiMoWB9Q8MyLHzzRSGqQvQLAv0JEHlMhEK6LBPYH1sP2FWa9wN506KHT6O k9Lze4ffRoWidHFIQiJQPnitFGRKFZcscOs3trFOCFoj9dxmo+gNoOBEht8toUNBeQM1 4m3/lNy3iPLrEgH4xPFQqahWUKaW2uxIMNgqqmk3jQ/WzW6ItK5Xf3iOT4JZJmpn4ux9 EKMQ== X-Gm-Message-State: AOAM531bT8XFeyucp6gl17JI31utYOlzkes0QeCda6lQRD04ytEP1URt fiLXZoIPDHL+BZ5tLjuJ2Vzplt1wyv4= X-Google-Smtp-Source: ABdhPJwIfUhN9czetpkqoSZb2bYbVkfSGf/mMOMkODcmaHW/WRm6Bf7RM0cpNkIN10XaGS9lEgtUQg== X-Received: by 2002:aa7:d3d9:0:b0:410:7a81:c0cf with SMTP id o25-20020aa7d3d9000000b004107a81c0cfmr27598085edr.177.1645551514535; Tue, 22 Feb 2022 09:38:34 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 07/22] hw/audio/cs4231a: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:04 +0100 Message-Id: <20220222173819.76568-8-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=shentey@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645551835245100003 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/cs4231a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index 7d60ce6f0e..0723e39430 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@ -677,7 +677,7 @@ static void cs4231a_realizefn (DeviceState *dev, Error = **errp) return; } =20 - isa_init_irq(d, &s->pic, s->irq); + s->pic =3D isa_get_irq(d, s->irq); k =3D ISADMA_GET_CLASS(s->isa_dma); k->register_channel(s->isa_dma, s->dma, cs_dma_read, s); =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552061; cv=none; d=zohomail.com; s=zohoarc; b=Qeue1fimlHHM741Wu4JemXAXVsIftrF0pJLMszN2lxb8XTckJdPPP/Bsy03AZbOHZJ+pk09yeObKOSG0fm/nH5FGuOpXqezi0CIUIkHAZNZKO3bUxITVZ4/fQZ6p4hr+y0cUPKFS9mu4n3js74khKtIFmZ5VDg2V/uezX9M+yYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552061; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CmvV1KBAyLb40CrSZESm4OuVCUBSwXaZp8sAs9w/www=; b=Gs3S9W/AN3KAs22RECDPshkRd0UhCMW+0l3/UEVYhMGnPrlQYlLBCBYqob8FtMAyYSccPAxWgacoJ4H2yO43Pi3bOsf8QjAgvWlDEEbxEaaFKVfiHXJ422/gg31hhKS+AfPtZjcmDcRBecQ8XGQW+njT/gYHLusr5DRrzrp65Yw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16455520612441017.2650182225999; Tue, 22 Feb 2022 09:47:41 -0800 (PST) Received: from localhost ([::1]:39864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZGG-0001IJ-2s for importer@patchew.org; Tue, 22 Feb 2022 12:47:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7W-0003X4-56 for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:38 -0500 Received: from [2a00:1450:4864:20::62d] (port=39633 helo=mail-ej1-x62d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7U-0002ml-O8 for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:37 -0500 Received: by mail-ej1-x62d.google.com with SMTP id p9so45187298ejd.6 for ; Tue, 22 Feb 2022 09:38:36 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CmvV1KBAyLb40CrSZESm4OuVCUBSwXaZp8sAs9w/www=; b=GJjRwv3bzvzbLoeR0Gzzij+Ucr1xjFu0dAnlUNI71Ed0u58ZK0K0DB6qqyfvE0y+U8 YJseSv3e1b/fBOyhMHxU4MYLMr1fLsHotBxmsjlDLa9LPHULM79MbfCQHqDrvVDw/dal cHNU7zCIE73fXpw/T3aCct5ZvW3MAGGBjA0+eE9Yns7wD/C/4mzZoaR0S6t4WUFhfmEq 9FitcijrvWGwUIqfBVZkiOJFAbKwDgid034U5iFlgvdmfVaX18vBRbwW3mlhZyImapiY GX2axvF6kb4K4WApeq5VppVF9UaIWDoMaAr1SrBs7rDnQVge8hjamDm6a97WNw1EB2TS tZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CmvV1KBAyLb40CrSZESm4OuVCUBSwXaZp8sAs9w/www=; b=iwmsxuVRkCbfPYHHFyvbV70o9xlcgLX3YFtALC+H/4s+s9ssYaBuBVysiWy5m4ZfXd /4U2HqKTiUd3b7BohhyGOfYBvsfFLBOnbs7sXQCZRsB4BcGIxgYEXsm8ejt983doYHHC SYj9yQhB3wqdT4HERz9xzK654frZzbUgvVeHD6WQm4jwHoyYoFuiD4GqFJAc55NFYiUY eBtAhpUEYpnrg4mWJolrfSMkSpMiue7eKJB7og0AWlOQ3Xe6oAxZY6GpPmvAgPfDM80a lAfH9nIsd8tcJTgTcbus4K0KhNSKP7NB7iIKmmsNuBY7B5FlhRL9bmNq5TlL9Yx8+ZKn tXsA== X-Gm-Message-State: AOAM531eVm+MJl7dvLq7cvMIQdGhAA9PBfgu82dkWYFefRSf9rK7TpFd scgUJRT7GM9yBrkJKUa7/ZPM2/yoREg= X-Google-Smtp-Source: ABdhPJw/q3kErtWGqpatxpJOMFM8CA2f+skc/QL5yW/eimabMqoQ+s2/DjKlfnE+F/t2wi612zrVvw== X-Received: by 2002:a17:906:a10:b0:6ce:7107:598b with SMTP id w16-20020a1709060a1000b006ce7107598bmr19810697ejf.653.1645551515381; Tue, 22 Feb 2022 09:38:35 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 08/22] hw/audio/gus: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:05 +0100 Message-Id: <20220222173819.76568-9-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552064215100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/gus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index e8719ee117..42f010b671 100644 --- a/hw/audio/gus.c +++ b/hw/audio/gus.c @@ -282,7 +282,7 @@ static void gus_realizefn (DeviceState *dev, Error **er= rp) s->emu.himemaddr =3D s->himem; s->emu.gusdatapos =3D s->emu.himemaddr + 1024 * 1024 + 32; s->emu.opaque =3D s; - isa_init_irq (d, &s->pic, s->emu.gusirq); + s->pic =3D isa_get_irq(d, s->emu.gusirq); =20 AUD_set_active_out (s->voice, 1); } --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552289; cv=none; d=zohomail.com; s=zohoarc; b=MRtnPWiYy2c2MIHlkjqNe1ikuLs1lCZdFV2DVr9kaFOKRfFj0vuleOVxtvplqyzTZPmoJWsid5heSrTvbzJADy32JsyGerHO5/CUy8lRMVRRUY3UyBxVWaBxgPto0ezHcxjk8JvFw0fyZ9J6dAwg5LK7tDZ7Cm7l8+bGy0BRCtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552289; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yYCWkHPOuJ94dyXJk+F5NkE0t29yoLIYoBmG6Tsv8gE=; b=BL0f4rRBPmCb79GvZgcMni9q9xVvjYbl3KyVCjWhOTkat9JnZVPEVQnSIzpLgshzrCLfb3SLog1G+IokKzptrh6fjWU+rINbyeiDXBfXMaBihz6/ugYwi1mK67nNeUGsKlH7Sh0kwmWVCO0HaXE51wxrQ+C5F8Ph2qOrWcEULSo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552289461866.5960743854539; Tue, 22 Feb 2022 09:51:29 -0800 (PST) Received: from localhost ([::1]:50162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZJw-0008Ei-Fw for importer@patchew.org; Tue, 22 Feb 2022 12:51:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7X-0003dH-Lk for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:39 -0500 Received: from [2a00:1450:4864:20::635] (port=46765 helo=mail-ej1-x635.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7V-0002nB-UT for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:39 -0500 Received: by mail-ej1-x635.google.com with SMTP id qx21so45069743ejb.13 for ; Tue, 22 Feb 2022 09:38:37 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yYCWkHPOuJ94dyXJk+F5NkE0t29yoLIYoBmG6Tsv8gE=; b=PRNpnUqOiM/QzTqzNSRnoDtQxCmgU+f7c4ZRHskfPQy117gG9bAyqak6A5Y2fGmgwe BQBjkZRtCZ8ElPZdKLkIH/nD4O2ziqESVNChxZJV6SSeO437tOOHujeSmpjRFX9ax6Re 53b16EjCemkj1Vj422M51msqxNp6dY7/gOVbeQNFqBFcRsfOviCYXc4hZqC46wxctSS/ kz0scaU+E5CKrNv15ONiHeSJ3j1vmzi9YA/ooOAen7O2B91YGv87IEovYRzNEgbKl5a5 SN+Gc+c7TheaNxw2f8p0otu2qNyJXK0eL3qYVN2Ah0MLS3kvGgV6nF4HsboCNFfR+2jj tFhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yYCWkHPOuJ94dyXJk+F5NkE0t29yoLIYoBmG6Tsv8gE=; b=IZF7PDqar4uxMVYGLPNohZCTtXg7/BMosKVCQLUPIpDVzB4L1akG3hSsrVMGcmjh8l Relkq20f4TzXgCCEwKOCcsL6L2Y1oWRDnbrLxwc9ikPMQxYtuCxlHlKuxLSra6zs6wSR V7L7JNULFYTH+eCThZD5M4B+14MA9U/gc0FGVCQIgOO/gomgah6OZwiF+kT0pRkR5quC J8AGDypidCaJFgy6FG2dHJzbSQBGHId89hzXV+vpt8G2cvHcpmRgZQafJnIkC/KbHQvp IAe/37iuaKo6v9RNWVP0sQVp+6cjDR/t7xYQAHOWVLaIs2BVkgds3y8UwXJCpdx1Ra0U F5JQ== X-Gm-Message-State: AOAM533WgDYwT0+QOPGmE0wABI6D3kyMhwPjCRjeLGDlHrGKhvYBP6pB Kn0eqdLt+s+D5QebNMshCmy4wPbV86E= X-Google-Smtp-Source: ABdhPJw8/ptrEsGLCg625R3+8RlKsnqk1nq7pRy4kmkjDcN58goLQrMcgxiUYAbnEgxgcfvAqaQq0w== X-Received: by 2002:a17:906:1ccd:b0:6ce:b0c1:b3ed with SMTP id i13-20020a1709061ccd00b006ceb0c1b3edmr19732122ejh.26.1645551516251; Tue, 22 Feb 2022 09:38:36 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 09/22] hw/audio/sb16: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:06 +0100 Message-Id: <20220222173819.76568-10-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::635 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=shentey@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552291210100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/sb16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index 60f1f75e3a..2215386ddb 100644 --- a/hw/audio/sb16.c +++ b/hw/audio/sb16.c @@ -1408,7 +1408,7 @@ static void sb16_realizefn (DeviceState *dev, Error *= *errp) return; } =20 - isa_init_irq (isadev, &s->pic, s->irq); + s->pic =3D isa_get_irq(isadev, s->irq); =20 s->mixer_regs[0x80] =3D magic_of_irq (s->irq); s->mixer_regs[0x81] =3D (1 << s->dma) | (1 << s->hdma); --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164555174642646.02135553836297; Tue, 22 Feb 2022 09:42:26 -0800 (PST) Received: from localhost ([::1]:54672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZBB-0000cg-E0 for importer@patchew.org; Tue, 22 Feb 2022 12:42:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7Y-0003e4-Hb; Tue, 22 Feb 2022 12:38:40 -0500 Received: from [2a00:1450:4864:20::52f] (port=39646 helo=mail-ed1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7X-0002nR-03; Tue, 22 Feb 2022 12:38:40 -0500 Received: by mail-ed1-x52f.google.com with SMTP id u18so38756108edt.6; Tue, 22 Feb 2022 09:38:38 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EeijvT97pxct3XtQrY7wd6pgmajnCOIp6/PW1V9+uSs=; b=OprOH5JVGbyK8c7bBVByBfVFT/LN7rbx7Kte5uco2bCfziq9kJRWhcHDllj3kOhEA4 uI0toyOS/qmKtn7Em1YCvNeoEc4ungXNDFxk6/LPCXQeZC9Pzg901WB35PaM/ClirZeM OPAEGn7aL9MPf5EldgXjvPcYB0vFcmjavxjJFNjbyYTzKjY/DQ+TnyF5x3EBRmI2Dn2I WpEV5rBX9GdKVQQQ4zugGKWIwTf3VX60Vo8pesr06t4vtpntNmghCukr222hQZL/Ii/2 kiVB4ucvYsu355iPkjRyJ/lD5xsVjqk6PkxvzHEf0Vha5Ta9Ho03TGE2wCU2Y44n08e/ c1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EeijvT97pxct3XtQrY7wd6pgmajnCOIp6/PW1V9+uSs=; b=efRW07JVOUX/Bjj5ZAt/RuCy2ZtI+CDsXD+KLDAYv+zXgipN87m4SvvQUzuvT3JbzW 4T3PyKXPaJ8kmNtccnepQToUaAJ8pjSrA4qTwNnPQ5rxVo3ZKNMnj2ky/QHIZujmTAP/ g6Oh84zIryLG5cz9RYO/3AznJujFrF2dvQEsUPVcw0z86R9oaG/7vC+AZwpkVuimPR7V JIWOsQERq2ly+WcH3ZTC64F1ak0LicfiZAB9m7VaGOtTDgTAjxawkKhZZNoG8xkc7e0y /8Zq9x/U3/OI/JGf8xQ+MXH1PnHwln0ExlG11TWuwn4mqrih3sg4IYAodp126qOIs6O2 1deA== X-Gm-Message-State: AOAM5338kKYjJshzp0IWpAWvcRxdseKIPu0r5kOqVnF9ShSJSBdv7oVi NTGrui2GDQJEKRZIAxGDNV/euMU9q2s= X-Google-Smtp-Source: ABdhPJynBDcvBlFxZwnQfR9wCQwXMkDGBlSeEYVeYOUIieeUUIN4B1m5G4YycceOOueuO1e5SgBrnA== X-Received: by 2002:a05:6402:440b:b0:410:5fb4:7225 with SMTP id y11-20020a056402440b00b004105fb47225mr27067778eda.216.1645551517234; Tue, 22 Feb 2022 09:38:37 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 10/22] hw/block/fdc-isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:07 +0100 Message-Id: <20220222173819.76568-11-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=shentey@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , Hanna Reitz , Bernhard Beschow , "open list:Floppy" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645551748673100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/block/fdc-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/fdc-isa.c b/hw/block/fdc-isa.c index ab663dce93..fa20450747 100644 --- a/hw/block/fdc-isa.c +++ b/hw/block/fdc-isa.c @@ -94,7 +94,7 @@ static void isabus_fdc_realize(DeviceState *dev, Error **= errp) isa->iobase, fdc_portio_list, fdctrl, "fdc"); =20 - isa_init_irq(isadev, &fdctrl->irq, isa->irq); + fdctrl->irq =3D isa_get_irq(isadev, isa->irq); fdctrl->dma_chann =3D isa->dma; if (fdctrl->dma_chann !=3D -1) { IsaDmaClass *k; --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645551900447611.5211529592426; Tue, 22 Feb 2022 09:45:00 -0800 (PST) Received: from localhost ([::1]:34978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZDf-0006M7-FU for importer@patchew.org; Tue, 22 Feb 2022 12:44:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7Z-0003gF-8B for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:41 -0500 Received: from [2a00:1450:4864:20::52a] (port=35734 helo=mail-ed1-x52a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7X-0002nh-MW for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:40 -0500 Received: by mail-ed1-x52a.google.com with SMTP id bq11so17423567edb.2 for ; Tue, 22 Feb 2022 09:38:39 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rI52xLFwbXQFqfgLnwofbV81YzDkaqrpGEFiKBHgqXU=; b=NvMTiL36NeZE22a/XFbZwuX//IEAFtbzEkS+J0bPvuOMZGgNwpdJVQdJ+jU85mRcub /kQICb5vfd7iVu3FrCfJkWB7kwqGNr2V+rCxczcW9D0khLdmAH9nQReNL7ob/j+J4lU2 CzWRkSPX+3DO6LX/hxI2QntYpyBaAGfMmnFlw+QU9J4NJlY1xasFbJI4d7mby30Ec2eU SuqFRbGuxo7fuwVU3m9bIhTVdMj2/Us8INBRjJ3j2dGUTMo0UkcoZrLlqyP0cWnm/QMP mQfulTZM6ULTy4hXQIyWop0Vf9MZJI7ejdHOQ1r5lvncdATA2poPbah7ll7WefOPVfkv XUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rI52xLFwbXQFqfgLnwofbV81YzDkaqrpGEFiKBHgqXU=; b=sg20j7zM5ia22bZKIwUadCEpwVwn09d8xaS8p6zjVuxqsGc+4gygFhndq7Qu0Mu6NC SbsOi6I9YN6zbQmXsjQktCbasgIIEYmJFksAEFiI/tb/Hb2yHt2s08yV5qf5pNUEzc53 rberN2npAZT+k63yzJ8f0YLgEyCBz9I9swguEJGylfQDRpgIWoEUrdj32IXwCiPlGPfY ah9rNUuz0Wm8daYK0JY02JKHwxiN8P2je2iLCNC4Kb/k78bG62Xk8nNk1BBc44OKyaV7 qbmWnx1zMU8Gdj/3qsuF6A88LUNeuuHCFa8GIhrXhMTUgIv/1Ht/EKBlpMUUaClNp573 k+IQ== X-Gm-Message-State: AOAM533kLFvDvli20DMtf/o5rR3DRKJV3BC+3ixT6suKot5zxPnfD7Yh aoieH4mIRhN71vIMit/Fs+J32DETqlE= X-Google-Smtp-Source: ABdhPJz+nEuGl/nS4S5Drbo/gTliyIO8a6yfusMxCJ1dDBGGVF0KLlPhb1DXz8coJSWtnrmtphKP4g== X-Received: by 2002:a05:6402:1e8c:b0:411:7180:7dfc with SMTP id f12-20020a0564021e8c00b0041171807dfcmr27869257edf.74.1645551518210; Tue, 22 Feb 2022 09:38:38 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 11/22] hw/char/parallel: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:08 +0100 Message-Id: <20220222173819.76568-12-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52a (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=shentey@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Bernhard Beschow , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645551901981100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/parallel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index b45e67bfbb..adb9bd9be3 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@ -553,7 +553,7 @@ static void parallel_isa_realizefn(DeviceState *dev, Er= ror **errp) index++; =20 base =3D isa->iobase; - isa_init_irq(isadev, &s->irq, isa->isairq); + s->irq =3D isa_get_irq(isadev, isa->isairq); qemu_register_reset(parallel_reset, s); =20 qemu_chr_fe_set_handlers(&s->chr, parallel_can_receive, NULL, --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552080588467.672615215369; Tue, 22 Feb 2022 09:48:00 -0800 (PST) Received: from localhost ([::1]:40718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZGZ-0001s6-8z for importer@patchew.org; Tue, 22 Feb 2022 12:47:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7a-0003lR-Cm for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:42 -0500 Received: from [2a00:1450:4864:20::533] (port=36584 helo=mail-ed1-x533.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7Y-0002oO-Hk for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:42 -0500 Received: by mail-ed1-x533.google.com with SMTP id cm8so29134216edb.3 for ; Tue, 22 Feb 2022 09:38:40 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Khkty+gm2SXPwPmKhEricJRnhM6YQl7su7I42HaaWvw=; b=HFxhnd1p4AsycSYUs3/DJDEtXdJysjcru6fGYwv/20+1UVJPQaDCWghYFn/ndqzM25 RjYbwangGHtPKq5qszfkbuFCcJcZrmCwjMMGvacrRDkASkkfDiRJvFCLRpYHZaH38jAL drLYRJo4HPBfoEIZ+MVe3CuDN9JxFE7PTvDSut4ZAavIoOrp4CK4gBfMiWp75cyTwPHU GPOvZamPWEmrrduuP2UW9BNsuYj6MOPKrqgK3FryEveuVvjUHdIdmYSn6UmE4I+4XaZk wb26NGVy1fyHNXPEjlw3I4X+U5rzJW3xC+5ruGNquxYs/tNtrRZg5Bl5wpgXVecZ/FKY DtIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Khkty+gm2SXPwPmKhEricJRnhM6YQl7su7I42HaaWvw=; b=wW/dQFMw8B64nMGNfthRJ634SiD0TReb7vBSti8h0TYqrZyxM2ktGdSzHk4lcHwBuQ aQPC+Bw2CLQsKFQxsA1cns32eiZgQR9iLzJxZzEh7IuNKE3zXdgCE90+UPs3KsTDRBxz wg2P43t/WSjLX1LW4jwcKLkSieBPdJJoS0MffEEVH3WsfK94UOIW8ZFPmLD+0vjuL8RT NXZmS82XvfpLFHk9RJOIpuPvMVkBAFHLvB06K8PSCQNRRXnAF2KIx67HJxWAZXq9PCKz GrORcMsLIVU68HnkyxeVh1iPDhIs+SyVgaKaLkbe0+3gdSq4gdj0QVQ+6Nvjhm21q6eS rPqQ== X-Gm-Message-State: AOAM5337/kG4zyRS2c1w77FLo1NPnAYNYrFtteow2dFgLFn0Q7quoc8t wvkoVf5bOB+IiVTr5t72wJJDjowRSok= X-Google-Smtp-Source: ABdhPJzN6lOORyiNJANZ3qtuRnL1kcs/8gKEASez26JxDk7xqULbYd5kuq2e8GSHrVESB1O2Xq18rg== X-Received: by 2002:aa7:d74d:0:b0:410:b60a:c37e with SMTP id a13-20020aa7d74d000000b00410b60ac37emr27215655eds.330.1645551519176; Tue, 22 Feb 2022 09:38:39 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 12/22] hw/char/serial-isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:09 +0100 Message-Id: <20220222173819.76568-13-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::533 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=shentey@gmail.com; helo=mail-ed1-x533.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Bernhard Beschow , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552081816100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/serial-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-isa.c b/hw/char/serial-isa.c index 1b8b303079..7a7ed239cd 100644 --- a/hw/char/serial-isa.c +++ b/hw/char/serial-isa.c @@ -75,7 +75,7 @@ static void serial_isa_realizefn(DeviceState *dev, Error = **errp) } index++; =20 - isa_init_irq(isadev, &s->irq, isa->isairq); + s->irq =3D isa_get_irq(isadev, isa->isairq); qdev_realize(DEVICE(s), NULL, errp); qdev_set_legacy_instance_id(dev, isa->iobase, 3); =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552137753352.02879599304447; Tue, 22 Feb 2022 09:48:57 -0800 (PST) Received: from localhost ([::1]:43720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZHU-0003s0-QM for importer@patchew.org; Tue, 22 Feb 2022 12:48:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7b-0003oe-Hf; Tue, 22 Feb 2022 12:38:43 -0500 Received: from [2a00:1450:4864:20::52f] (port=43728 helo=mail-ed1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7Z-0002p2-Ow; Tue, 22 Feb 2022 12:38:43 -0500 Received: by mail-ed1-x52f.google.com with SMTP id m3so32749151eda.10; Tue, 22 Feb 2022 09:38:41 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hODc348sDBOJP+v8u2lpOm8duN5QJTp75AGojk1OzEo=; b=Sf8V5s84FNlq6IkY7d6Xg1SJ5oZFjOIIhp+X9luDiBPU1zSeprfQNhKgQhMcSJFQI2 kBWew6zFigvTtAuqEC8Ye70uryIGkHQ0RjQupO0bh0/q25fqn5pu/wt9ZCGZtSP/yztT o8AFQ82WInhbCpZym6SRdn+GosaUll13gECzIwb+w5TiYqSanmDJlW+jPUAR6MJQSE6L 1j8Pdxyp40DP3zvnGD6iR2juapl+gbPxzqAgrM5VaJHoI9qt9xhNjwB1J1SJuPXvQmRw WCnzkMhOIvdI1sEcjcdzXwVBSLuCWJajg8lP4i+8MZLyTz3kZAoE0OG2quxbQ8763AMN /ihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hODc348sDBOJP+v8u2lpOm8duN5QJTp75AGojk1OzEo=; b=3vkhvlOY0s3kS4XJzK98Z3nGTnm8K4l2ixHHhBajDR/LGEPnSb0pp0gHqOLZrvV3yz 3/S5j+17gvUGxjr7ymVbVx/VHhkCV/qdTsDXDiEB4meYjfWoIzFLS4711QpfJ+4ZJy55 k3oCF4Xt8E47lK50zyU7BhLlZmlBxohuFwmeaWLpV5Uv34XQ1P+20tHrYS2hkeA57sgf z044aKboNXfGDzmURjSvGC5yjqCDmd/Oz0VdFgvd78U6lQcB1YGeOtwAj1k/pb1KywPY 0h27Az/B7/FrLxkWzvyurgZs27bxJg53Sean5afykYfyoq/Yn/defml9VwioeZnxUHxj xAGA== X-Gm-Message-State: AOAM530HiNe1bi9SlTd0h7UNykp1Po1hCxVo5Zi+zoV7QurBmqAQIrfU 0VpYqEo2ixnwhsmLrg94aH5fGYNoNGs= X-Google-Smtp-Source: ABdhPJzPnYJ8otHXEdr0edxIen9UPb+si46a7yDTGlVWEXGXvnYDdq5SV9C38o49eYORBwmy+2+NCA== X-Received: by 2002:a50:c04c:0:b0:410:b929:d658 with SMTP id u12-20020a50c04c000000b00410b929d658mr27593345edd.5.1645551520030; Tue, 22 Feb 2022 09:38:40 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 13/22] hw/ide/isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:10 +0100 Message-Id: <20220222173819.76568-14-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=shentey@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Bernhard Beschow , "open list:IDE" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552140214100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c index 24bbde24c2..8bedbd13f1 100644 --- a/hw/ide/isa.c +++ b/hw/ide/isa.c @@ -75,7 +75,7 @@ static void isa_ide_realizefn(DeviceState *dev, Error **e= rrp) =20 ide_bus_init(&s->bus, sizeof(s->bus), dev, 0, 2); ide_init_ioport(&s->bus, isadev, s->iobase, s->iobase2); - isa_init_irq(isadev, &s->irq, s->isairq); + s->irq =3D isa_get_irq(isadev, s->isairq); ide_init2(&s->bus, s->irq); vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_isa, s); ide_register_restart_cb(&s->bus); --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552506305416.4780941035351; Tue, 22 Feb 2022 09:55:06 -0800 (PST) Received: from localhost ([::1]:60080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZNP-0006Rl-VR for importer@patchew.org; Tue, 22 Feb 2022 12:55:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7c-0003ro-C2 for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:44 -0500 Received: from [2a00:1450:4864:20::532] (port=35742 helo=mail-ed1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7a-0002pL-Ie for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:43 -0500 Received: by mail-ed1-x532.google.com with SMTP id bq11so17423864edb.2 for ; Tue, 22 Feb 2022 09:38:42 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bgd958jqA3CUdC4YjY9L6ajQu0wLqK7CxsxrThFjcvE=; b=XOu+2S0h2IHFsTLmzqJnkthgLv7jtTN118PEa5gaxok9+uLlMVHFVz7xLbwVhumnNC 9XFBePoF/cSyfxBSlHPU95xU+czFPE4RTJMbaIGRpCwa0kEUnm4kb0uyYDez12RRSPXy KzGahrJJ/SjQkcjfkWkFifgj2msm1aRWgC1DIPoCoR/JVRfdYXjVtCo3gf3m4B9J5oOw CPsw7XMfBTa0I2gf3sMHIlepkpE5NSPyWnr7yBTP9qoGNDtk+b2CC+uyoI3+GLT52e1I ekikcVWOKcrNQY+92IKVa0LBYXOacdP3HwIaDXaJJwD/MnM/nwyhEhyQtoGkJEhmQ3Yq iY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bgd958jqA3CUdC4YjY9L6ajQu0wLqK7CxsxrThFjcvE=; b=gbWFxA2hboPe0vRO+3hopbZ/X2lOwirtNSjLk9Lp9/uzfqHIKF/Z35Cbk/169ROoqO E7WAEb8rd8H9qIolG4V+ezQwkzi7eRS/uMT4fmlj41bd2PqYzjhriSDLEv9md9jt7GL2 c1xE9vkJhXymiEVTEuSbH4bBb9VfR8LqHmJMDt9aep8w07HPYZMP4IKXqlOIfeAvB6fM uRI7hLh9cj5YOcd4nopz2X/7+W8rAnDTZbhDQDuavnnQxe6c1tuCUfz/zOumEorK/1jk vBptAom99Nu+YStnD4/FAHuxZ3eyUOZ0o1rZ0DLr9tOrikX7uXwrRRaj1EZIItoVoLOa ljgQ== X-Gm-Message-State: AOAM531zJwhGnIh0VfJF67okS59UNvTS1lFRa1P6FJDiLHM05MthkXxy xtO41OgewI/Mo8k6JtxTJcSBZGebFRo= X-Google-Smtp-Source: ABdhPJyIdAkkBrwqqgYaRe8BLA6Xq+Yan2zgE3edYNx4mu/sZgTIrX0sACUJIG7zJ8atWJUChiGoyw== X-Received: by 2002:a05:6402:1d55:b0:412:b3ae:2904 with SMTP id dz21-20020a0564021d5500b00412b3ae2904mr24609055edb.294.1645551521181; Tue, 22 Feb 2022 09:38:41 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 14/22] hw/input/pckbd: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:11 +0100 Message-Id: <20220222173819.76568-15-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::532 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=shentey@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Bernhard Beschow , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552506963100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index e56bee87d2..3ee36baf2d 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -736,8 +736,8 @@ static void i8042_realizefn(DeviceState *dev, Error **e= rrp) ISAKBDState *isa_s =3D I8042(dev); KBDState *s =3D &isa_s->kbd; =20 - isa_init_irq(isadev, &s->irq_kbd, isa_s->kbd_irq); - isa_init_irq(isadev, &s->irq_mouse, isa_s->mouse_irq); + s->irq_kbd =3D isa_get_irq(isadev, isa_s->kbd_irq); + s->irq_mouse =3D isa_get_irq(isadev, isa_s->mouse_irq); =20 isa_register_ioport(isadev, isa_s->io + 0, 0x60); isa_register_ioport(isadev, isa_s->io + 1, 0x64); --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552494; cv=none; d=zohomail.com; s=zohoarc; b=O4tvMTZioRU5ikc9ubJTuwz5CvZh945NwHbq9T/QAUO0ryIpnODXLVZAhKn+9jgv9DAt7aMmdaN76Q5y2UHjrajwNu7fKVmWwwr2b4aGPt+c8ZkiDZV2cW6v4EBEcw0P9UGPmoL09TFtD6uqa7rXnrnVBBU43ucu+hwDcgXrrVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552494; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OuZTr6rv/jwpyEGm5IkqFfaSg0z98+rElW1EZeduKOw=; b=hMBdJTIHdrmUwWec7IrNSUCUDvDaxRO+PnTDBJycJlA6ehywvtJQDLnhUdJ7cms1jMEu+l1NEUMA+FUxQh/BeEmFkicCYnIw20rgU8PRvyCv98oP70T7ibLXFSVtiszR/gYO2OcAhlCvZ9UGEOPTmpymf49ALoPzxcWBbgfnrwA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552494124218.05390718573324; Tue, 22 Feb 2022 09:54:54 -0800 (PST) Received: from localhost ([::1]:59110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZNE-0005oS-RA for importer@patchew.org; Tue, 22 Feb 2022 12:54:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7c-0003sa-Lh for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:44 -0500 Received: from [2a00:1450:4864:20::535] (port=35745 helo=mail-ed1-x535.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7b-0002ph-AJ for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:44 -0500 Received: by mail-ed1-x535.google.com with SMTP id bq11so17423944edb.2 for ; Tue, 22 Feb 2022 09:38:42 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OuZTr6rv/jwpyEGm5IkqFfaSg0z98+rElW1EZeduKOw=; b=C4vHBmwFM1e0t7nY0tsQWZpayR73eRlf5/rXQkGN/AQh1uzQt7jAlRmSLLpnEejBey Njj2LWYPW1szc5+k1fHYbPSohEf4qjlZ0gcekwNJRULsuJSn2NvO5FrzPx4F5hBEEiiS mb8cdJvulhXgm9nKeaDOk3iiscIy+NX4DvBGtulPLn2pQj7wa2Wy/3bAWKIZVmBTXuzW xWtaOOykWgpyuI2A+RIxSDbx/4VtxW2F3AVOrkRODWzWxVt+VJqnng66vnmo6RTkTqqG uoJ8SaUerGEZjgqboDRmuhRq22u+gzl+Z1/Mcc9KnsOpqGUicmHCxaaNMtCMB0z41cho kDPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OuZTr6rv/jwpyEGm5IkqFfaSg0z98+rElW1EZeduKOw=; b=ZeFVlFxjDyQbIiFwnvxG67JGRJPVmCOo4UNeANQnANK8SS9xybP6xmJSufhCyMi5lD 3GslzxJQDM5+naQSCEN6Gbq/dqm5Wy+FHEBr92CrdQJLJqHHCrfuVOKRGE/Yaj3w2Vku G10329DfOUhYv4ZST9Fhz/NQCEFBFJbrEOGMz2KBThkXGXWO0BUMg9oxYd8X0db5H1hm NhUqfjWnpNf8wdWpzwMAe9nW3juNmOvz17uerd4PW68vTAPy1hRudazXWqFWBazHwNeV VpxEgPbBio1BnqhN0b45iPGEzUuOICKofTqurqk6LeBLpvHFiyQoH+rFDPq61ANpxAND 7uRw== X-Gm-Message-State: AOAM533vZ/i5dmBPN63sGkcC3cUdlZsD/p0RJUu8RWtlRRgItf3hrQt7 7gH26uAgJlchasSmUjE40lwMVbJBXcc= X-Google-Smtp-Source: ABdhPJzXH3P+jSht7WqTFp3xZpciomL15lq+rDtEeFJ84+AauY2S0/P7PNINzmDShIUv+yHVS+2QMg== X-Received: by 2002:a05:6402:90b:b0:412:e7f8:6de6 with SMTP id g11-20020a056402090b00b00412e7f86de6mr16021527edz.182.1645551521949; Tue, 22 Feb 2022 09:38:41 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 15/22] hw/ipmi/isa_ipmi_bt: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:12 +0100 Message-Id: <20220222173819.76568-16-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::535 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=shentey@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552495261100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 02625eb94e..88aa734e9e 100644 --- a/hw/ipmi/isa_ipmi_bt.c +++ b/hw/ipmi/isa_ipmi_bt.c @@ -92,7 +92,7 @@ static void isa_ipmi_bt_realize(DeviceState *dev, Error *= *errp) } =20 if (iib->isairq > 0) { - isa_init_irq(isadev, &iib->irq, iib->isairq); + iib->irq =3D isa_get_irq(isadev, iib->isairq); iib->bt.use_irq =3D 1; iib->bt.raise_irq =3D isa_ipmi_bt_raise_irq; iib->bt.lower_irq =3D isa_ipmi_bt_lower_irq; --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552358; cv=none; d=zohomail.com; s=zohoarc; b=YB8fo1IrFdbDtUh1Jzn9L5m9Aj+m75BRNVbtuiP59rNBquoZqLfKtNFVgaoLYY6FMZTQUDRa2ILjHGfMLJF5DUQ32ifbO45EUl5a/fo5JxSmSq8U3zndFvJNludn662N4CaBSOnxkVKmnHIkuYFTeDNVLznF4ehw26MtAapJeFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552358; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zjmSFcMWhfofmPFxlk/r2EeC0P+Uw+dEJELYLF9MjVo=; b=DcSdS7uchiPWISdk/E6qDEPugjOo/6v8vkAFJY/bdWv9BOsFXbKf3CELpUPkRlcByBFcTWaKLM7Z/pYss5vgTmMJxKCqdOx/X2frUqv6LhCIqk6+21Izc56s1dfbckhs0R3oiwgIF1LIntLqI+1xd0wHPrUh5wI0fhAQo15c+NI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552358482328.8360607093615; Tue, 22 Feb 2022 09:52:38 -0800 (PST) Received: from localhost ([::1]:53142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZL3-0001oN-DU for importer@patchew.org; Tue, 22 Feb 2022 12:52:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7e-0003vk-1I for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:46 -0500 Received: from [2a00:1450:4864:20::52e] (port=42899 helo=mail-ed1-x52e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7c-0002q2-8k for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:45 -0500 Received: by mail-ed1-x52e.google.com with SMTP id i11so37020808eda.9 for ; Tue, 22 Feb 2022 09:38:43 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zjmSFcMWhfofmPFxlk/r2EeC0P+Uw+dEJELYLF9MjVo=; b=RXuSJjhZMKFGr3pclKhNgalDOKTxnrFfO8HRvdhLdiW1wZTk6Psz4lKQIEthOXcblX tyHs4Zqvp/y8agIx9hyxATm6mn/A7WYWO72f8P+Ae+V8YHANIqXviNQE6tvXU0LCGH2b /DaSLqn3MYDqEOMYcHVY3i9lHrhC5pDps1SH7TIV1Id3Ad9VEgPPtNzXaHQJpinVe44i fJ4deNzEf4r799LVLeDGdhKW696yjOwcOIyKp7x43ksIlTB/oZxsbuzQSlfS5ftAFnxD I+nKNId7lFzamQw/Pvs48SiCdnjkZ9iFn22ukkhSc62v1QZXr27tbsshZlx4VMS+HolC EE+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zjmSFcMWhfofmPFxlk/r2EeC0P+Uw+dEJELYLF9MjVo=; b=AYpHdQvxQjoj6/wKhuvYNAdnyVHgrhxkI8froi0ubecSDYuECMh4Hz6OpzGjaX7xYV 4Hf95LQqQExqVZEws7LlFjXocextP1J6N8I1QINbm0dP7tH1W0LyoxuXn3a8+QUfJalK vM1DFeYjA6wXCIenMebYtBHHXSDf3jzZZj7v77en7QPeGUX9EjVX0+D+OIx5kFhg4b3B HVtmE8hd9x+/glqAozfgRnq95cyWQvz6c/7d+fhlOq8o3SbAFaghtAuBxIZQMQdafrAD E9ignQvdKn9TsT/xsmHYjR34Hn/6k9KuluAJE31HJQThaIG1VeaGJ7raVHWpnOJdN2UH S5wQ== X-Gm-Message-State: AOAM531u54uGHk2/Y2uiXZYAJ20dwQEKyKxmZ6Wu7Irm+EDDoAqH7/9m +9pkEHbz1Z6LNOlFn4ITPuVMFtuIhn4= X-Google-Smtp-Source: ABdhPJxN8229K0AftczisfyzvuMFwm422TqeH2SNlTzcPqhCkleeOYg1mXJvpX4FKFRax42F3LmWHg== X-Received: by 2002:a50:ee14:0:b0:410:7a88:4b0c with SMTP id g20-20020a50ee14000000b004107a884b0cmr27568761eds.37.1645551522738; Tue, 22 Feb 2022 09:38:42 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 16/22] hw/ipmi/isa_ipmi_kcs: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:13 +0100 Message-Id: <20220222173819.76568-17-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=shentey@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552359878100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_kcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_kcs.c b/hw/ipmi/isa_ipmi_kcs.c index 3b23ad08b3..afabb95ebe 100644 --- a/hw/ipmi/isa_ipmi_kcs.c +++ b/hw/ipmi/isa_ipmi_kcs.c @@ -91,7 +91,7 @@ static void ipmi_isa_realize(DeviceState *dev, Error **er= rp) } =20 if (iik->isairq > 0) { - isa_init_irq(isadev, &iik->irq, iik->isairq); + iik->irq =3D isa_get_irq(isadev, iik->isairq); iik->kcs.use_irq =3D 1; iik->kcs.raise_irq =3D isa_ipmi_kcs_raise_irq; iik->kcs.lower_irq =3D isa_ipmi_kcs_lower_irq; --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552705196490.3272842549054; Tue, 22 Feb 2022 09:58:25 -0800 (PST) Received: from localhost ([::1]:39974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZQd-0003WA-U8 for importer@patchew.org; Tue, 22 Feb 2022 12:58:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7f-000403-5W for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:47 -0500 Received: from [2a00:1450:4864:20::534] (port=40919 helo=mail-ed1-x534.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7d-0002qd-6r for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:46 -0500 Received: by mail-ed1-x534.google.com with SMTP id h15so21729677edv.7 for ; Tue, 22 Feb 2022 09:38:44 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/3j29R7lXMdrMKGnt5++sE1+VglPHaZYEgL5oGNi9kU=; b=IYEzeZkOpD+tCxBCkj+puA2KbyUcR75VNdF+5fh2AJ93fKzCnDxHeA58ApRHbY1GDX qLnhfbYLLsyPPI9M+C03g7Sw14sl0nbdGaoZ2AbUU70sjLcBpYyKkGQ1YTol5PBoJtpA /elai6iSwqTvwr3RBj7tWL73hOmO+26tyIuR09Lh0VyqZpyCEywErGegbgUTHP/QUCzv qRTKlcfZETZgMOl8PxDUB0bXKRNKFTj14YQP4b2h4KmSqf1FuVEXuYDtXW1+cJnBZx83 kfILgJK5w2a6p90P1G2HvNFfkrrRyU2U5EDOjp7Giv85dHVH3bEfDduX6GVlwbylhXbi bDXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/3j29R7lXMdrMKGnt5++sE1+VglPHaZYEgL5oGNi9kU=; b=Gvw1A0WuYaDOL1Y0NaVwdQRfS/K6B/UeXZU2Av9O5xKPgm1hXZ6mjAGb8YTj/oJU0/ 3faRvcWPezo70P1sxggs7J4byd0G0yp5cTijXGrt9yHSoe5RxqdAJrlEFk+2lp2+UTBp peLZxmHeDc5k1xfRNhd1IyUAGn1tR127f0+ti7e997RGe5JTD7nzzFEZ+voWOSCL4IfB bF51kqmfu2XY+u3rHuUFKy8Nz/vxUxqGbH2r4TdBobVaJNA+I6i8UAX5c2xCnhslI2gG xJkTDoG0HduucDDQWOLbIx2vKvRumtOcE2Z63p8PWWKMcxoiM0ITwmQFtiXjOzhdkDIx ebpA== X-Gm-Message-State: AOAM532Qq9TSUyZG/OHUZCg4xj7a0EdIA5ZAAIV1bMCUQUKWlJaoFDxl b0ecLRRUAFchFgZgy3rksUDXCIUQUmY= X-Google-Smtp-Source: ABdhPJysvbm++pSafN/7RZhnBh/zPr/oTuqFQ1dXx1i23Ij0hOh7JmjY9hDqZyB8ntSJi6eVH4NmTQ== X-Received: by 2002:a05:6402:1d54:b0:410:f02d:4765 with SMTP id dz20-20020a0564021d5400b00410f02d4765mr26905537edb.28.1645551523758; Tue, 22 Feb 2022 09:38:43 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 17/22] hw/isa/piix4: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:14 +0100 Message-Id: <20220222173819.76568-18-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::534 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=shentey@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Bernhard Beschow , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552706939100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index cb291d121c..0fd6756dcf 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -197,7 +197,7 @@ static void piix4_realize(PCIDevice *dev, Error **errp) if (!qdev_realize(DEVICE(&s->rtc), BUS(isa_bus), errp)) { return; } - isa_init_irq(ISA_DEVICE(&s->rtc), &s->rtc.irq, s->rtc.isairq); + s->rtc.irq =3D isa_get_irq(ISA_DEVICE(&s->rtc), s->rtc.isairq); =20 piix4_dev =3D dev; } --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164555252226475.53174787925582; Tue, 22 Feb 2022 09:55:22 -0800 (PST) Received: from localhost ([::1]:60616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZNh-0006oX-8o for importer@patchew.org; Tue, 22 Feb 2022 12:55:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7f-000430-Ph for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:47 -0500 Received: from [2a00:1450:4864:20::52e] (port=45690 helo=mail-ed1-x52e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7d-0002qu-WE for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:47 -0500 Received: by mail-ed1-x52e.google.com with SMTP id c6so35852006edk.12 for ; Tue, 22 Feb 2022 09:38:45 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M0VwRAVUenlZUvRbc1a5N4xtILg9Nv9mnMQHhVnmjwI=; b=EODm9VRTFmJtqu+YHzCPHxxH1zwA7u80Zzo0Ku7JtZ+kCQBUbKQ7NO4SIlwc9gHvTb HimccB2FeTE4gFLk/jjUR+Cf/N8PE/q2U7N/osbyiCNjGP8AxRxgzeJk0eMnZgraNmnO XYUb4ipNVuf38QdgQk+E46sgYYll5SSdFHIeYuyhj3QMgwwpsH4huKrCMSNbz9NrsGiZ 9+174a46b2fZ9n0OyeOW785HcYAmRq95XzF30RillIbU6YHKL3Esxsx0QpH6hlSH7L96 mtLfDgH3LcpI/OrFi7eBTvJDZj9lIK9OxcVOP4SrewptaYsRP/FjUSFuUpC9Gv32M6ds m57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M0VwRAVUenlZUvRbc1a5N4xtILg9Nv9mnMQHhVnmjwI=; b=fbr43BlxTYrYKfem3K5LlTcaZmlEPOlUO6s32EqYtXT4b9Ajx0siEvnjZITFmHSQvH FGy88Vu8dEhUgCqsABJB7wCVURLfmdAucK8TbYNmEw3xhGjvhVe1RWMKdA5Uuqk3BrTh ooouGh0MdWpeSarMbZBw1V45J4sdQbtKqdM/lWb+stdpdp9mB9P8lIA28dVH3zHL8Y25 NJur/YlrzGmQwYTx7y7KShUW3aq3bc3roAFoJe6Ae+ewuGOx44CIxQMo2XW4LiVkASts lYbhttFrMpWpL2qpclVn2jRoAIpAxDauqH0NeqHwNf/rBsSK1u+uGLEsxMdGfpZuZ2wv /nsg== X-Gm-Message-State: AOAM531nl9PfZmi/KrCByK2E+EFN1JBKZwX30SI9BvRvxckmJHKi6f8I LhlrIeZLL639x7P0kz+4o/H+Sybgd5Q= X-Google-Smtp-Source: ABdhPJw0j/+5hsq2wmH7/CQSo0rNPfXFDeWBUo7fOu50ztZ6gvZ/f6C+IP3C6OONEgi7F9yWepsenQ== X-Received: by 2002:a50:9f8b:0:b0:413:2dbd:8793 with SMTP id c11-20020a509f8b000000b004132dbd8793mr636533edf.39.1645551524734; Tue, 22 Feb 2022 09:38:44 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 18/22] hw/net/ne2000-isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:15 +0100 Message-Id: <20220222173819.76568-19-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52e (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=shentey@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552523196100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/net/ne2000-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/ne2000-isa.c b/hw/net/ne2000-isa.c index dd6f6e34d3..6ced6775ff 100644 --- a/hw/net/ne2000-isa.c +++ b/hw/net/ne2000-isa.c @@ -68,7 +68,7 @@ static void isa_ne2000_realizefn(DeviceState *dev, Error = **errp) ne2000_setup_io(s, DEVICE(isadev), 0x20); isa_register_ioport(isadev, &s->io, isa->iobase); =20 - isa_init_irq(isadev, &s->irq, isa->isairq); + s->irq =3D isa_get_irq(isadev, isa->isairq); =20 qemu_macaddr_default_if_unset(&s->c.macaddr); ne2000_reset(s); --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552715512759.853974605642; Tue, 22 Feb 2022 09:58:35 -0800 (PST) Received: from localhost ([::1]:40756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZQo-00041y-16 for importer@patchew.org; Tue, 22 Feb 2022 12:58:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7g-000462-Lc; Tue, 22 Feb 2022 12:38:48 -0500 Received: from [2a00:1450:4864:20::536] (port=46625 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7f-0002rE-8D; Tue, 22 Feb 2022 12:38:48 -0500 Received: by mail-ed1-x536.google.com with SMTP id s1so5618692edd.13; Tue, 22 Feb 2022 09:38:46 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pBWZyQf2a1EQOS4RoRDBdmQBnv7imwruIUWeEsAYGFM=; b=RTrf4vivibqVA47BSV3Nl0St1l+Y8yQMyFLZ8y/H/GlTp6Pvb5BPtt25T5BwX6DgBB YdyR4lNC4KQqUKPoB+8ldnf3vkUifLFOzH2Yfu8EB76AJhu2wthBE1m7F13+i3ld3KgR OllIPzF57F50oZ6QsAxS5m2l232b4QNYVUuzI2x5ldwnepli42S4qjH8Kv6Jj3wZasJi +4DBABU0gRQwBi3uaNRljo5mPRqCJgWwnFnlflakuwFYwuApDV7arwvFsCdmh3bZs/65 Teo3O1zbYyjMzFwtAb+6TXx68wGtnufccrZFdvzLFTDSD0ZogvBQJB55xDRVddlD00co fmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pBWZyQf2a1EQOS4RoRDBdmQBnv7imwruIUWeEsAYGFM=; b=4Q5/IV8p5Kuv3+ocPAlmUsiVrPiId500Suov+DwTI3y4eLqWH2Mfq+Jv4a/gBg6GR0 yDWy+wgqeGvQmi0arQdW1x1Zk3xaSc3EK3/nyJuzO/qm/afp4K+qvhP6i6Z1v85eYVS2 mIHKXHjeVR//ddHp21jxp9ppcfvbRZi7iBbgeiDY8oVY0etL926lQaV66kvofX+6GZJr yKvKKA2TY9ZBV5hDTcEqpt8nsiPfgQxsWUbrpeLe6rbTrQJDtTyudsVr6RWl9yRBhf1S g4a1XoKiVkB810xQMT9fOaideI07J7s4ZceQ/Fd61AeMEnvSo9k+fZup5mkNUDbqtLLI LqUw== X-Gm-Message-State: AOAM533YYbTolT8yE1NTyHs4d3me/6fQXFa5A5/kYEFdLwa4rpswVcLn QeIl7xGOJYNJimpERbZakXxjax3y6Hk= X-Google-Smtp-Source: ABdhPJyeoj2YRZxyyjH44iSZBDqCgzZ+0MeIXBAKd1bBMuXDbica8RYh8NOg3ddArgd/0lP2G424lw== X-Received: by 2002:aa7:d343:0:b0:40a:1425:8896 with SMTP id m3-20020aa7d343000000b0040a14258896mr28245140edr.242.1645551525532; Tue, 22 Feb 2022 09:38:45 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 19/22] hw/rtc/m48t59-isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:16 +0100 Message-Id: <20220222173819.76568-20-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=shentey@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:PReP" , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645552716776100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c index d1c1d789a5..31918c416f 100644 --- a/hw/rtc/m48t59-isa.c +++ b/hw/rtc/m48t59-isa.c @@ -101,7 +101,7 @@ static void m48t59_isa_realize(DeviceState *dev, Error = **errp) =20 s->model =3D u->info.model; s->size =3D u->info.size; - isa_init_irq(isadev, &s->IRQ, d->isairq); + s->IRQ =3D isa_get_irq(isadev, d->isairq); m48t59_realize_common(s, errp); memory_region_init_io(&d->io, OBJECT(dev), &m48t59_io_ops, s, "m48t59"= , 4); if (d->io_base !=3D 0) { --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552280; cv=none; d=zohomail.com; s=zohoarc; b=lpk0u5zH3KD28YmZwbrUNtMuCoviYYRp6CgwtPbgNfvLb3FmYxWCyhX25dZ7gB8fGxCA7OHgbLxkp7SfLygU0WVJ5DgJ7nxEL6Bq3RE8E2lX2nHaxTFyiy/XiTqeEVbgIwiXAdKAceV2aBDPYD8wJ2FApcEodnDqm0GBasf2Ddk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552280; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i9gsYbLS+oFxHUewZXteoSpkAOteqQtXYimRXD0P1Ec=; b=NyWO+A3byjftfW6v4JuHA3w5/LDlOKWpHAyNY64MkDcrPoroczyv318VEXS+bNXQNkUzZ6/oOZrHfqmuoFDzbya1NicRtmf1pXapNtguMbzfS87mosrPair/bxPyJB9AlCRVxAlt40nsQBy6o7kLD579jXv3JUOjfxfoGm7jwPM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552280055637.4007965473046; Tue, 22 Feb 2022 09:51:20 -0800 (PST) Received: from localhost ([::1]:49462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZJm-0007k4-Nm for importer@patchew.org; Tue, 22 Feb 2022 12:51:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7h-0004Au-M3 for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:49 -0500 Received: from [2a00:1450:4864:20::52d] (port=44697 helo=mail-ed1-x52d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7f-0002rZ-TS for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:49 -0500 Received: by mail-ed1-x52d.google.com with SMTP id x5so38626750edd.11 for ; Tue, 22 Feb 2022 09:38:47 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i9gsYbLS+oFxHUewZXteoSpkAOteqQtXYimRXD0P1Ec=; b=hEzmFYQ5g8Vrs7Ktqe7Ca4+D+WTHxYYSeoBoLfP2WtPDEKoG+QXwtqePsOmOWwuh0Q 50cCXq5+dMWQYaZyLq0y52ydM4vOU8SnD6ANEal2wAvkmOjXTeQQ+VqqtNXEWGhty7dH rjHKvVYROilALaIAuItmNqCE0vHIVIHB/oQDitaEyGSu5kiYgb5PqO9glYp2cBRhmDqr ozKoTYPSZwJy9/7bAx5jT6inFOAsvpuUF15rhkaPW9HZMnfdnkhLLxqthUdpsclLWi00 f+IMMydC4g34sVCF95ZGXAjQcVuBNabNDewkw+CUNGRqFctulr/7KmdeiFrb01MIVt/h G+9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i9gsYbLS+oFxHUewZXteoSpkAOteqQtXYimRXD0P1Ec=; b=c+isaEAJ16LmnmQcISu3ZJj29/qFDRrDvUqb0Iw6S2+EXaDJEfOCprmzTeaTKkiKEx 5PWb1PXszwFfBXK+0MIEqwI8l9PSKeG6HO/bKar/t/wF54FUAjKgDYUdDf+YXOE1nZO4 pDMbLeIbcaOd3myl7uHpRR1f8zcBYmEmI5Ur29B8XqV8YIm7ZA52otBIjE1MewvKt0B8 mE/Osd/sYWmfS5Q3nmkcvmDcBTDujAxobBTbRbAuXC1F8wTJQ3yAi+5Fe5ENT9CrdBRF 33mGKMt+KpKlTDYqQyO6O8wOgi/cqEWljXBQqB3xjsjSkmmby+QdbBFIuMZQS5BH66N2 MeGA== X-Gm-Message-State: AOAM533G6ugdYt+XpoGJHO9EZrIucaK55Pie9pECAI8U/arkZrahYzk0 BCn7qfQhGc1vATEkqdUNw2aq4a2gYcQ= X-Google-Smtp-Source: ABdhPJy5DcxRKCsKsRiBPIpWMDh3nFvKZzwe73HhKgU2/mpyfGFodQct7+m6BEe8muYNp4nRRukG9Q== X-Received: by 2002:a05:6402:2751:b0:412:d64c:fa65 with SMTP id z17-20020a056402275100b00412d64cfa65mr18181213edd.204.1645551526532; Tue, 22 Feb 2022 09:38:46 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 20/22] hw/tpm/tpm_tis_isa: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:17 +0100 Message-Id: <20220222173819.76568-21-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=shentey@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow , Stefan Berger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552281253100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/tpm/tpm_tis_isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis_isa.c b/hw/tpm/tpm_tis_isa.c index 10d8a14f19..3477afd735 100644 --- a/hw/tpm/tpm_tis_isa.c +++ b/hw/tpm/tpm_tis_isa.c @@ -127,7 +127,7 @@ static void tpm_tis_isa_realizefn(DeviceState *dev, Err= or **errp) return; } =20 - isa_init_irq(ISA_DEVICE(dev), &s->irq, s->irq_num); + s->irq =3D isa_get_irq(ISA_DEVICE(dev), s->irq_num); =20 memory_region_add_subregion(isa_address_space(ISA_DEVICE(dev)), TPM_TIS_ADDR_BASE, &s->mmio); --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552893; cv=none; d=zohomail.com; s=zohoarc; b=UfecnWTiQJhOgbG63yJbmGIz2cmOb30Rsm4VZQoc6slMdI5jdQJA3itF4+jdZ5BG3VX+ygpI8LZV264e6EVSMo1ABO5n82kczB4uyQZdpeBn0UtdBCBaCujJAp5EBBpyJpy0JGv49pXrYC5HkuOBO06O4xdDrlDDkdz1tn+jzKw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552893; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HbYju84CvG42z6Al6B5zdxO5OIvmYAHPnRzWM1yGA1k=; b=QTUXXPHpG5mETO6HC+DULEvkFXH1ITQGI06PAg8MfEo89YrH2FUju1jLhj4sYbGxgRKsVJgKRGdd7toVS5NQYMYR+7p9RbEeBWYpWqg9OgCywMnf4ATuZJEYL1dWLuPZN5c2a7/61avSuiBk53MZ9NDW4F1rF7r2SNUiL6MHqYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16455528932811013.8768985228019; Tue, 22 Feb 2022 10:01:33 -0800 (PST) Received: from localhost ([::1]:46820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZTg-000863-7L for importer@patchew.org; Tue, 22 Feb 2022 13:01:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7j-0004Hu-6A for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:51 -0500 Received: from [2a00:1450:4864:20::52c] (port=33478 helo=mail-ed1-x52c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7h-0002sL-Nl for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:50 -0500 Received: by mail-ed1-x52c.google.com with SMTP id s14so21356574edw.0 for ; Tue, 22 Feb 2022 09:38:49 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HbYju84CvG42z6Al6B5zdxO5OIvmYAHPnRzWM1yGA1k=; b=YoW7kJcCorEdQCp1iPYE1Ic31GloCvkqII6d6X+FlyJgFnEBz6zBvynec7gpi+Z+U4 xvbM+3dtBx8w6/chaBf908/umrQf85bBlt98ICDtzZs7te7fcVrZTLDFwtKfySzxjUUo QXX+XDCIO2PTZjijd4sxvdXYXVstqo5OvIIb1rNjwb8voEcO429WKcLJyUPft3ySUcxv DN4hKIQTpWVH40KkOAV+Tk5obduqu3ghrVHAxs2mjcEILH7zJjIXJbqufySqokA0efaj klnbazxWKP5b/fqyNcRt5RvracAPCRYf0w8+xQPPSUErGsbs0+s8QUFafERSijeoyAvB y/Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HbYju84CvG42z6Al6B5zdxO5OIvmYAHPnRzWM1yGA1k=; b=q+1J46UhNtnAWVehjpS9/zzJ5TmnBZo0Qbyo644NrI5H7Rt4Iy7f2rftJaSVswdbI9 UGA1F8yJC83s9PzRUHYwXF3wnCmnOJMuVhERDXzeeJc1Fm+OpAHbVnlup7v2+OV5q2Mk 5ZHFuTLlOLfPoixnQuT22n9HIbRzzAzoQUS+VtgZDjpEz32GfSZzGozaiN2g+Iq5nbiJ CkLKV2oavWJz4ab7l0l8xCmCUDtvs6aYaJ9VF7GyL3n26NwSasVVllCM4eQOXJ6OncoW LigGMVVHvlnPXZX1j2VmSlG2Zn1GX/nj3OkAJAcVeL3QiBVnqBC1YysUU0zpT4xOqBV2 BR3g== X-Gm-Message-State: AOAM530C6hNWPNoWxq4pKsIVSsQyRYTegSbrCQuzaz+jAaJDdTF1QYaQ 0aYgaWN8L4VWKS5Jo81VM7SraDicdUA= X-Google-Smtp-Source: ABdhPJy0Q2gD9TF5eP9Ov24y9VQyqtxvLw/2Wdn6ZOnzU/F4cUuY1EKwFIAE5QQv8VTn3qdCbUpFQg== X-Received: by 2002:a05:6402:42c6:b0:412:8cbc:8f3d with SMTP id i6-20020a05640242c600b004128cbc8f3dmr27986588edc.310.1645551527224; Tue, 22 Feb 2022 09:38:47 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 21/22] hw/isa/isa-bus: Disuse isa_init_irq() Date: Tue, 22 Feb 2022 18:38:18 +0100 Message-Id: <20220222173819.76568-22-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52c (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=shentey@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552894322100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index c64a14120b..1e8c102177 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -92,8 +92,7 @@ void isa_init_irq(ISADevice *dev, qemu_irq *p, unsigned i= sairq) =20 void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq) { - qemu_irq irq; - isa_init_irq(isadev, &irq, isairq); + qemu_irq irq =3D isa_get_irq(isadev, isairq); qdev_connect_gpio_out(DEVICE(isadev), gpioirq, irq); } =20 --=20 2.35.1 From nobody Wed May 15 13:19:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1645552694; cv=none; d=zohomail.com; s=zohoarc; b=lG+GdAV+kSyNyNTCewrTSH3+75ATlcESBTgyqWAKBeJkiXZQ6PmrcPwfIThsNWnhBO7LM/fD3J4GUkox0WXR8SHvmbmaGV0/TZX4KyAV710fyqjRpEEkCdRCfSJ59KwkPpKvvqPaNgLUV0lAJJCX1qhzqRMdEkeSsPkI9jnULLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1645552694; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0PkugM/nmdz5ZSPWNwtFAXt+z4ki/4C47OuH3ieIYfs=; b=FZsrHXRSrK+pu9/AM3tG13KPyzP3ShH2r0JukJgxwfBwwrg0URkiDZChpYc8XFCe0si+6YN0GRCcRWM0mMRt6d4RP1c9SMXIZGO9V8qf2QUEAFuKqm+erINSo03ACgzUfS31QlFE8GQjnON6TuoZe0RGVAcm0B7fLMPh2giMo4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1645552694892166.0710735542632; Tue, 22 Feb 2022 09:58:14 -0800 (PST) Received: from localhost ([::1]:39476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMZQT-0003BW-Ph for importer@patchew.org; Tue, 22 Feb 2022 12:58:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMZ7j-0004Hj-5X for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:51 -0500 Received: from [2a00:1450:4864:20::532] (port=40918 helo=mail-ed1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMZ7h-0002sG-A9 for qemu-devel@nongnu.org; Tue, 22 Feb 2022 12:38:50 -0500 Received: by mail-ed1-x532.google.com with SMTP id h15so21730103edv.7 for ; Tue, 22 Feb 2022 09:38:48 -0800 (PST) Received: from Provence.localdomain (dynamic-089-012-227-088.89.12.pool.telefonica.de. [89.12.227.88]) by smtp.gmail.com with ESMTPSA id et2sm6449382ejc.101.2022.02.22.09.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 09:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0PkugM/nmdz5ZSPWNwtFAXt+z4ki/4C47OuH3ieIYfs=; b=FyX/NSXb7OgA4e9NHpjG/9z0neWBqkzoInDMZDCt13mZYjqjwlK/wQwfsM5w7dOYKb 5VOkbowWizl6f1sJtYXTcaW92PlK5lGfNKKPtJ30cjZ4GLaqnCxmngwIjKnxd5nd6a4f MQXsJ9Gd/SFafKzZo2HP/4YNCC8nUwdop4wNqJ2djkP9W7Yof3RlrZXYoGgg6DrJSvlf JaKyQNdMSRV6Y2cx7adwUkYnw1zIMQzprEV5jGC5v//qtj+M5XkkdPHRtqsQd/0rfvFn EdI0zbL9nHIDrtkUJ0voTWNdOl+rI/fXweuTDNf502LA+BzTkt9yvhzoesuhoZJ2na7d H0KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0PkugM/nmdz5ZSPWNwtFAXt+z4ki/4C47OuH3ieIYfs=; b=tKfJCuJKoISpR3g23mSbh90IBY2erPzqMa4k6cZVWQMwxj0fyFtcDndf+ato5xn6YZ wYxBo+v7EgOBSfhS+Hp5iVpz9kUBm57+VwAApNFngbektJeSXJ806QDS1RMZjxkRpoux n7wQS1tLlr/iVmgBZ2s+4NHx1EzNO0FCV523dEkXw1Gn6aeU9OrUvHdy7ZV1lxGLh8dl IB2qTVNghiQe5x8MP0sQMHc7q7dLLrqmYBLlzuDxi7Xy+i4AFnQDC1vCA5kE8lHE4Wxp I6jjPiLkQaARa30Yi6T+HoUqNOQhi/S9aLLW7debmxWybzPuncc85VBNhVG4UUkjN4MH 0c6A== X-Gm-Message-State: AOAM532B6/gikEmKy4aZEZ972vXwOwcUF68saEzDjWwXEQWpbAD5FNZi yosTyRct1YXPf0jsMcQVeNZbd/nLoV4= X-Google-Smtp-Source: ABdhPJySzGxA1lyI95ZT7CMP7nA95Eo06WL91c0B71j9U8At+WaO0bKGnAAiCPN+mXhOcfZ3eOd6+w== X-Received: by 2002:aa7:ce08:0:b0:410:a996:d6a5 with SMTP id d8-20020aa7ce08000000b00410a996d6a5mr26547341edv.303.1645551527962; Tue, 22 Feb 2022 09:38:47 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Subject: [PATCH 22/22] isa: Remove unused isa_init_irq() Date: Tue, 22 Feb 2022 18:38:19 +0100 Message-Id: <20220222173819.76568-23-shentey@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222173819.76568-1-shentey@gmail.com> References: <20220222173819.76568-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::532 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=shentey@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernhard Beschow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1645552696756100001 Content-Type: text/plain; charset="utf-8" isa_init_irq() had become a trivial one-line wrapper for isa_get_irq(). The previous commits resolved all usages in favor of isa_get_irq(). isa_init_irq() can therefore be removed. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 5 ----- include/hw/isa/isa.h | 1 - 2 files changed, 6 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 1e8c102177..0ad1c5fd65 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -85,11 +85,6 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq) return isabus->irqs[isairq]; } =20 -void isa_init_irq(ISADevice *dev, qemu_irq *p, unsigned isairq) -{ - *p =3D isa_get_irq(dev, isairq); -} - void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq) { qemu_irq irq =3D isa_get_irq(isadev, isairq); diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index d80cab5b79..034d706ba1 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -90,7 +90,6 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *addre= ss_space, MemoryRegion *address_space_io, Error **errp); void isa_bus_irqs(ISABus *bus, qemu_irq *irqs); qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq); -void isa_init_irq(ISADevice *dev, qemu_irq *p, unsigned isairq); void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq); void isa_bus_dma(ISABus *bus, IsaDma *dma8, IsaDma *dma16); IsaDma *isa_get_dma(ISABus *bus, int nchan); --=20 2.35.1