From nobody Mon Feb 9 09:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164510820452553.626880523075215; Thu, 17 Feb 2022 06:30:04 -0800 (PST) Received: from localhost ([::1]:33936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKhnG-0008RG-Oj for importer@patchew.org; Thu, 17 Feb 2022 09:30:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKh0f-0006n5-Mf; Thu, 17 Feb 2022 08:39:50 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:64974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKh0M-0001lf-4N; Thu, 17 Feb 2022 08:39:32 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21HD7A5n017341; Thu, 17 Feb 2022 13:39:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e9pnn924p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Feb 2022 13:39:27 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21HDYZaJ029304; Thu, 17 Feb 2022 13:39:27 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e9pnn9240-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Feb 2022 13:39:26 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21HDaAnw013267; Thu, 17 Feb 2022 13:39:24 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma01fra.de.ibm.com with ESMTP id 3e64ha0f2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Feb 2022 13:39:24 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21HDdKbl44958184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Feb 2022 13:39:20 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DEB294C06A; Thu, 17 Feb 2022 13:39:19 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 199054C050; Thu, 17 Feb 2022 13:39:19 +0000 (GMT) Received: from li-c6ac47cc-293c-11b2-a85c-d421c8e4747b.ibm.com.com (unknown [9.171.42.121]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 17 Feb 2022 13:39:19 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=uEorX0lnubEv9/2pQJn+S0XeXc+WB6C5fhr9TQ8DLBk=; b=VNhWISiFPpGDrhL/M2pYoWaCW+zYn9+Lby2f+kBASF4tURNjvjzeI9gy1axjzI/ggw+9 TkoKaE9Mb5uv9O0/bVhC+lS/PjOTyXPoX+HCwi4HRzkWWPYYGZtNj55GgS8zQeXqZL6j yAO8Kxv9DZnr/4xEgnZKOmHDqCJmdeFDHDkluwArhCfeBcnj/hD8h6+NB6FX0K5qOhsb 7d8IOfXOYSLGpJGJ1s8AkkLM/xsXqc1ydxovG6fdjVj273Hd5kQsN/Rke9tZ3XPj8XUD UFWofldvM/MskiiFp88ekIOcbAny+/1pw0xqQBhP2FB2PwP2Uy/EVDyIBXncLFMJsheI MQ== From: Pierre Morel To: qemu-s390x@nongnu.org Subject: [PATCH v6 09/11] s390x: topology: Adding drawers to STSI Date: Thu, 17 Feb 2022 14:41:23 +0100 Message-Id: <20220217134125.132150-10-pmorel@linux.ibm.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220217134125.132150-1-pmorel@linux.ibm.com> References: <20220217134125.132150-1-pmorel@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jhTdTQGL59ceB5fbX4IujDyQlkHJ_q4P X-Proofpoint-ORIG-GUID: lUBJMxHhW7HaQIIBkYUEWIXTrjg2Vevo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-17_05,2022-02-17_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 mlxscore=0 phishscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202170061 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=pmorel@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, seiden@linux.ibm.com, nrb@linux.ibm.com, ehabkost@redhat.com, kvm@vger.kernel.org, david@redhat.com, eblake@redhat.com, cohuck@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mst@redhat.com, pbonzini@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1645108209016100001 Content-Type: text/plain; charset="utf-8" Let's add STSI support for the container level 4, drawers, and provide the information back to the guest. Signed-off-by: Pierre Morel --- hw/s390x/cpu-topology.c | 137 +++++++++++++++++++++++++++++--- include/hw/s390x/cpu-topology.h | 19 ++++- include/hw/s390x/sclp.h | 2 +- target/s390x/cpu_topology.c | 40 ++++++++-- 4 files changed, 176 insertions(+), 22 deletions(-) diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c index 4705a2af96..3ae86f80f1 100644 --- a/hw/s390x/cpu-topology.c +++ b/hw/s390x/cpu-topology.c @@ -81,6 +81,26 @@ static S390TopologyBook *s390_create_book(S390TopologyDr= awer *drawer, int id) return book; } =20 +static S390TopologyDrawer *s390_create_drawer(S390TopologyNode *node, int = id) +{ + DeviceState *dev; + S390TopologyDrawer *drawer; + const MachineState *ms =3D MACHINE(qdev_get_machine()); + + if (node->bus->num_children >=3D ms->smp.drawers) { + return NULL; + } + + dev =3D qdev_new(TYPE_S390_TOPOLOGY_DRAWER); + qdev_realize_and_unref(dev, node->bus, &error_fatal); + + drawer =3D S390_TOPOLOGY_DRAWER(dev); + drawer->drawer_id =3D id; + node->cnt++; + + return drawer; +} + /* * s390_get_cores: * @socket: the socket to search into @@ -130,6 +150,31 @@ static S390TopologySocket *s390_get_socket(S390Topolog= yBook *book, return s390_create_socket(book, socket_id); } =20 +/* + * s390_get_drawer: + * @node: The node to search into + * @drawer_id: the identifier of the drawer to search for + * + * returns a pointer to a S390TopologyDrawer structure within a book having + * the specified drawer_id. + * First search if the book is already containing the S390TopologyDrawer + * structure and if not create one with this drawer_id. + */ +static S390TopologyDrawer *s390_get_drawer(S390TopologyNode *node, + int drawer_id) +{ + S390TopologyDrawer *drawer; + BusChild *kid; + + QTAILQ_FOREACH(kid, &node->bus->children, sibling) { + drawer =3D S390_TOPOLOGY_DRAWER(kid->child); + if (drawer->drawer_id =3D=3D drawer_id) { + return drawer; + } + } + return s390_create_drawer(node, drawer_id); +} + /* * s390_get_book: * @drawer: The drawer to search into @@ -169,6 +214,7 @@ static S390TopologyBook *s390_get_book(S390TopologyDraw= er *drawer, void s390_topology_new_cpu(int core_id) { const MachineState *ms =3D MACHINE(qdev_get_machine()); + S390TopologyNode *node; S390TopologyDrawer *drawer; S390TopologyBook *book; S390TopologySocket *socket; @@ -176,13 +222,16 @@ void s390_topology_new_cpu(int core_id) int origin, bit; int nb_cores_per_socket; int nb_cores_per_book; + int nb_cores_per_drawer; =20 - drawer =3D s390_get_topology(); + node =3D s390_get_topology(); =20 /* Cores for the S390 topology are cores and threads of the QEMU topol= ogy */ nb_cores_per_socket =3D ms->smp.cores * ms->smp.threads; nb_cores_per_book =3D ms->smp.sockets * nb_cores_per_socket; + nb_cores_per_drawer =3D ms->smp.books * nb_cores_per_book; =20 + drawer =3D s390_get_drawer(node, core_id / nb_cores_per_drawer); book =3D s390_get_book(drawer, core_id / nb_cores_per_book); socket =3D s390_get_socket(book, core_id / nb_cores_per_socket); =20 @@ -216,23 +265,23 @@ void s390_topology_setup(MachineState *ms) DeviceState *dev; =20 /* Create BOOK bridge device */ - dev =3D qdev_new(TYPE_S390_TOPOLOGY_DRAWER); + dev =3D qdev_new(TYPE_S390_TOPOLOGY_NODE); object_property_add_child(qdev_get_machine(), - TYPE_S390_TOPOLOGY_DRAWER, OBJECT(dev)); + TYPE_S390_TOPOLOGY_NODE, OBJECT(dev)); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); } =20 -S390TopologyDrawer *s390_get_topology(void) +S390TopologyNode *s390_get_topology(void) { - static S390TopologyDrawer *drawer; + static S390TopologyNode *node; =20 - if (!drawer) { - drawer =3D S390_TOPOLOGY_DRAWER(object_resolve_path( - TYPE_S390_TOPOLOGY_DRAWER, NULL)); - assert(drawer !=3D NULL); + if (!node) { + node =3D S390_TOPOLOGY_NODE(object_resolve_path( + TYPE_S390_TOPOLOGY_NODE, NULL)); + assert(node !=3D NULL); } =20 - return drawer; + return node; } =20 /* --- CORES Definitions --- */ @@ -455,6 +504,7 @@ static void drawer_class_init(ObjectClass *oc, void *da= ta) =20 hc->unplug =3D qdev_simple_device_unplug_cb; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); + dc->bus_type =3D TYPE_S390_TOPOLOGY_NODE_BUS; dc->realize =3D s390_drawer_device_realize; device_class_set_props(dc, s390_topology_drawer_properties); dc->desc =3D "topology drawer"; @@ -462,7 +512,7 @@ static void drawer_class_init(ObjectClass *oc, void *da= ta) =20 static const TypeInfo drawer_info =3D { .name =3D TYPE_S390_TOPOLOGY_DRAWER, - .parent =3D TYPE_SYS_BUS_DEVICE, + .parent =3D TYPE_DEVICE, .instance_size =3D sizeof(S390TopologyDrawer), .class_init =3D drawer_class_init, .interfaces =3D (InterfaceInfo[]) { @@ -470,6 +520,69 @@ static const TypeInfo drawer_info =3D { { } } }; + +/* --- NODE Definitions --- */ + +/* + * Nodes are the first level of CPU topology we support + * only one NODE for the moment. + */ +static char *node_bus_get_dev_path(DeviceState *dev) +{ + return g_strdup_printf("00"); +} + +static void node_bus_class_init(ObjectClass *oc, void *data) +{ + BusClass *k =3D BUS_CLASS(oc); + + k->get_dev_path =3D node_bus_get_dev_path; + k->max_dev =3D S390_MAX_NODES; +} + +static const TypeInfo node_bus_info =3D { + .name =3D TYPE_S390_TOPOLOGY_NODE_BUS, + .parent =3D TYPE_BUS, + .instance_size =3D 0, + .class_init =3D node_bus_class_init, +}; + +static void s390_node_device_realize(DeviceState *dev, Error **errp) +{ + S390TopologyNode *node =3D S390_TOPOLOGY_NODE(dev); + BusState *bus; + + /* Create NODE bus on NODE bridge device */ + bus =3D qbus_new(TYPE_S390_TOPOLOGY_NODE_BUS, dev, + TYPE_S390_TOPOLOGY_NODE_BUS); + node->bus =3D bus; + + /* Enable hotplugging */ + qbus_set_hotplug_handler(bus, OBJECT(dev)); +} + +static void node_class_init(ObjectClass *oc, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(oc); + HotplugHandlerClass *hc =3D HOTPLUG_HANDLER_CLASS(oc); + + hc->unplug =3D qdev_simple_device_unplug_cb; + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); + dc->realize =3D s390_node_device_realize; + dc->desc =3D "topology node"; +} + +static const TypeInfo node_info =3D { + .name =3D TYPE_S390_TOPOLOGY_NODE, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(S390TopologyNode), + .class_init =3D node_class_init, + .interfaces =3D (InterfaceInfo[]) { + { TYPE_HOTPLUG_HANDLER }, + { } + } +}; + static void topology_register(void) { type_register_static(&cpu_cores_info); @@ -479,6 +592,8 @@ static void topology_register(void) type_register_static(&book_info); type_register_static(&drawer_bus_info); type_register_static(&drawer_info); + type_register_static(&node_bus_info); + type_register_static(&node_info); } =20 type_init(topology_register); diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topolog= y.h index 78017c3d78..10e4bd754f 100644 --- a/include/hw/s390x/cpu-topology.h +++ b/include/hw/s390x/cpu-topology.h @@ -68,18 +68,29 @@ OBJECT_DECLARE_SIMPLE_TYPE(S390TopologyBook, S390_TOPOL= OGY_BOOK) #define TYPE_S390_TOPOLOGY_DRAWER "topology drawer" #define TYPE_S390_TOPOLOGY_DRAWER_BUS "drawer-bus" struct S390TopologyDrawer { - SysBusDevice parent_obj; + DeviceState parent_obj; BusState *bus; uint8_t drawer_id; int cnt; }; typedef struct S390TopologyDrawer S390TopologyDrawer; OBJECT_DECLARE_SIMPLE_TYPE(S390TopologyDrawer, S390_TOPOLOGY_DRAWER) -#define S390_MAX_DRAWERS 1 +#define S390_MAX_DRAWERS 4 =20 -S390TopologyDrawer *s390_init_topology(void); +#define TYPE_S390_TOPOLOGY_NODE "topology node" +#define TYPE_S390_TOPOLOGY_NODE_BUS "node-bus" +struct S390TopologyNode { + SysBusDevice parent_obj; + BusState *bus; + uint8_t node_id; + int cnt; +}; +typedef struct S390TopologyNode S390TopologyNode; +OBJECT_DECLARE_SIMPLE_TYPE(S390TopologyNode, S390_TOPOLOGY_NODE) +#define S390_MAX_NODES 1 =20 -S390TopologyDrawer *s390_get_topology(void); +S390TopologyNode *s390_init_topology(void); +S390TopologyNode *s390_get_topology(void); void s390_topology_setup(MachineState *ms); void s390_topology_new_cpu(int core_id); =20 diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index e8c55486f7..660ef49ec5 100644 --- a/include/hw/s390x/sclp.h +++ b/include/hw/s390x/sclp.h @@ -111,7 +111,7 @@ typedef struct CPUEntry { uint8_t reserved1; } QEMU_PACKED CPUEntry; =20 -#define SCLP_READ_SCP_INFO_MNEST 3 +#define SCLP_READ_SCP_INFO_MNEST 4 #define SCLP_READ_SCP_INFO_FIXED_CPU_OFFSET 128 typedef struct ReadInfo { SCCBHeader h; diff --git a/target/s390x/cpu_topology.c b/target/s390x/cpu_topology.c index 08e1fbd13e..fd25c56213 100644 --- a/target/s390x/cpu_topology.c +++ b/target/s390x/cpu_topology.c @@ -77,36 +77,64 @@ static int set_book(const MachineState *ms, void *p, return len; } =20 +static int set_drawer(const MachineState *ms, void *p, + S390TopologyDrawer *drawer, int level) +{ + BusChild *kid; + int l, len =3D 0; + + if (level >=3D 4) { + len +=3D stsi_15_container(p, 3, drawer->drawer_id); + p +=3D len; + } + + QTAILQ_FOREACH_REVERSE(kid, &drawer->bus->children, sibling) { + l =3D set_book(ms, p, S390_TOPOLOGY_BOOK(kid->child), level); + p +=3D l; + len +=3D l; + } + + return len; +} + static void setup_stsi(const MachineState *ms, void *p, int level) { - S390TopologyDrawer *drawer; + S390TopologyNode *node; SysIB_151x *sysib; BusChild *kid; - int nb_sockets, nb_books; + int nb_sockets, nb_books, nb_drawers; int len, l; =20 sysib =3D (SysIB_151x *)p; sysib->mnest =3D level; switch (level) { case 2: + nb_drawers =3D 0; nb_books =3D 0; - nb_sockets =3D ms->smp.sockets * ms->smp.books; + nb_sockets =3D ms->smp.sockets * ms->smp.books * ms->smp.drawers; break; case 3: + nb_drawers =3D 0; + nb_books =3D ms->smp.books * ms->smp.drawers; + nb_sockets =3D ms->smp.sockets; + break; + case 4: + nb_drawers =3D ms->smp.drawers; nb_books =3D ms->smp.books; nb_sockets =3D ms->smp.sockets; break; } + sysib->mag[TOPOLOGY_NR_MAG4] =3D nb_drawers; sysib->mag[TOPOLOGY_NR_MAG3] =3D nb_books; sysib->mag[TOPOLOGY_NR_MAG2] =3D nb_sockets; sysib->mag[TOPOLOGY_NR_MAG1] =3D ms->smp.cores * ms->smp.threads; =20 - drawer =3D s390_get_topology(); + node =3D s390_get_topology(); len =3D sizeof(SysIB_151x); p +=3D len; =20 - QTAILQ_FOREACH_REVERSE(kid, &drawer->bus->children, sibling) { - l =3D set_book(ms, p, S390_TOPOLOGY_BOOK(kid->child), level); + QTAILQ_FOREACH_REVERSE(kid, &node->bus->children, sibling) { + l =3D set_drawer(ms, p, S390_TOPOLOGY_DRAWER(kid->child), level); p +=3D l; len +=3D l; } --=20 2.27.0