From nobody Tue May 14 10:55:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1644493134424605.4619813190345; Thu, 10 Feb 2022 03:38:54 -0800 (PST) Received: from localhost ([::1]:40130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nI7mn-0002bx-So for importer@patchew.org; Thu, 10 Feb 2022 06:38:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI7ee-0003hr-4T for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:30:28 -0500 Received: from [2a00:1450:4864:20::62f] (port=33735 helo=mail-ej1-x62f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nI7eb-0002VP-L2 for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:30:27 -0500 Received: by mail-ej1-x62f.google.com with SMTP id fy20so14507929ejc.0 for ; Thu, 10 Feb 2022 03:30:25 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m4sm1910267ejl.45.2022.02.10.03.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 03:30:22 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A04971FFB8; Thu, 10 Feb 2022 11:30:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A473qbjGyhHnN0ZQyd0Yg8rCuTL/rArhdYtN54HK9fc=; b=gAaJXt9+Pcc1amrW6/4raCME0JCmTtXkvfAoifDAYnAAfJImvW83uWbgKA3lXjYwIv 7Azi9V/6J0StO/FmWDwqer49IjhmSaCtVLxZhHomVetfjKlRJs/b8TXUzHL/dSs3UTs3 V7Qqnjw8Q8GiTuuqVEiOfsyN2LSR+pxAHZ7aa4oKzTi4tmY7GtDUzg2bb+5ZHOX4Xxrm 1V40GlO6N09cfOO+QqDCp1/uCRsYL+pj8bwzIMHA07xMALlpp84cyjeKW0KMzFufzG8i Zw5KjAjAtDoXbEG1v3obWaDzc0ecUkg1qCRw5kDJXh2FXFfsfD1WtPjzc4oS7XKNyCEy pvyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A473qbjGyhHnN0ZQyd0Yg8rCuTL/rArhdYtN54HK9fc=; b=BWQEBUhPUz+n7tyA4CcZPZMj4DglIdwRuk2R8rcw7+uOGoTApr0KkmUdv3k3+YNEE+ xS6CCOjF0RY2tjKMMj80U/Yab9TVUaXb3bx9ZKgKSTf7oYYrD1s13dd1YQ6yornD9me/ E/JeXIEnQRCHW9j+Q0AMmlaQiJHwAaRI+uq/ijofD9oNM83PyPt/EZbpzfQbJ1ju/eBP 5yQLVrTeCQo9WpG+cpN0DnLPOXrzb/yij2VReZC+E0o8b0c8XX2Sss4FVHyf/fA9Pays aOSLYNIADnt0n/d+ukDaBFZjY3/EZE6xpu/EPpiQWVsJS/f5pLNqd1J7Gzv7Au7RKuaS sdJg== X-Gm-Message-State: AOAM5304Ocn8ASmOU7wPb6wwQ8uURB2FiyHZR3JaeFXMVkUojZb6eqn6 MtU/U9BKv4cglFweNVUfJYx0/Q== X-Google-Smtp-Source: ABdhPJzDOjY7y7h0fPlLMMgZeBC7mNLN02/8RXcMgSIaEkQNLK88SWzoiPrHl8UFRVCGbVK6XavVcg== X-Received: by 2002:a17:907:3da1:: with SMTP id he33mr5997248ejc.207.1644492624027; Thu, 10 Feb 2022 03:30:24 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v5 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO Date: Thu, 10 Feb 2022 11:30:20 +0000 Message-Id: <20220210113021.3799514-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220210113021.3799514-1-alex.bennee@linaro.org> References: <20220210113021.3799514-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62f (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Strauss , Keith Packard , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1644493136987100003 The previous numbers were a guess at best and rather arbitrary without taking into account anything that might be loaded. Instead of using guesses based on the state of registers implement a new function that: a) scans the MemoryRegions for the largest RAM block b) iterates through all "ROM" blobs looking for the biggest gap The "ROM" blobs include all code loaded via -kernel and the various -device loader techniques. Signed-off-by: Alex Benn=C3=A9e Cc: Andrew Strauss Cc: Keith Packard Message-Id: <20210601090715.22330-1-alex.bennee@linaro.org> Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v2 - report some known information (limits) - reword the commit message v3 - rework to use the ROM blob scanning suggested by Peter - drop arch specific wrappers - dropped rb/tb tags as it's a rework v4 - search for the largest RAM which should be the main RAM - implement the biggest gap algorithm - make stackbase the inverse of heap info v5 - move rom_find_largest_gap description to above fn and reword - add documentation of sort behaviour - handle matching se flags (- -1 -1) and (- 1 1) =3D=3D 0 - add helper function and sentinal - fix off-by-ones in comparisons - allow a rambase at 0 squash! semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO --- include/hw/loader.h | 14 ++++ hw/core/loader.c | 86 +++++++++++++++++++++++ semihosting/arm-compat-semi.c | 129 ++++++++++++++++++---------------- 3 files changed, 168 insertions(+), 61 deletions(-) diff --git a/include/hw/loader.h b/include/hw/loader.h index 4fa485bd61..5572108ba5 100644 --- a/include/hw/loader.h +++ b/include/hw/loader.h @@ -343,4 +343,18 @@ int rom_add_option(const char *file, int32_t bootindex= ); * overflow on real hardware too. */ #define UBOOT_MAX_GUNZIP_BYTES (64 << 20) =20 +typedef struct RomGap { + hwaddr base; + size_t size; +} RomGap; + +/** + * rom_find_largest_gap_between: return largest gap between ROMs in given = range + * + * Given a range of addresses, this function finds the largest + * contiguous subrange which has no ROMs loaded to it. That is, + * it finds the biggest gap which is free for use for other things. + */ +RomGap rom_find_largest_gap_between(hwaddr base, size_t size); + #endif diff --git a/hw/core/loader.c b/hw/core/loader.c index 19edb928e9..ca2f2431fb 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1333,6 +1333,92 @@ static Rom *find_rom(hwaddr addr, size_t size) return NULL; } =20 +typedef struct RomSec { + hwaddr base; + int se; /* start/end flag */ +} RomSec; + + +/* + * Sort into address order. We break ties between rom-startpoints + * and rom-endpoints in favour of the startpoint, by sorting the 0->1 + * transition before the 1->0 transition. Either way round would + * work, but this way saves a little work later by avoiding + * dealing with "gaps" of 0 length. + */ +static gint sort_secs(gconstpointer a, gconstpointer b) +{ + RomSec *ra =3D (RomSec *) a; + RomSec *rb =3D (RomSec *) b; + + if (ra->base =3D=3D rb->base) { + return ra->se - rb->se; + } + return ra->base > rb->base ? 1 : -1; +} + +static GList *add_romsec_to_list(GList *secs, hwaddr base, int se) +{ + RomSec *cand =3D g_new(RomSec, 1); + cand->base =3D base; + cand->se =3D se; + return g_list_prepend(secs, cand); +} + +RomGap rom_find_largest_gap_between(hwaddr base, size_t size) +{ + Rom *rom; + RomSec *cand; + RomGap res =3D {0, 0}; + hwaddr gapstart =3D base; + GList *it, *secs =3D NULL; + int count =3D 0; + + QTAILQ_FOREACH(rom, &roms, next) { + /* Ignore blobs being loaded to special places */ + if (rom->mr || rom->fw_file) { + continue; + } + /* ignore anything finishing bellow base */ + if (rom->addr + rom->romsize <=3D base) { + continue; + } + /* ignore anything starting above the region */ + if (rom->addr >=3D base + size) { + continue; + } + + /* Save the start and end of each relevant ROM */ + secs =3D add_romsec_to_list(secs, rom->addr, 1); + + if (rom->addr + rom->romsize < base + size) { + secs =3D add_romsec_to_list(secs, rom->addr + rom->romsize, -1= ); + } + } + + /* sentinel */ + secs =3D add_romsec_to_list(secs, base + size, 1); + + secs =3D g_list_sort(secs, sort_secs); + + for (it =3D g_list_first(secs); it; it =3D g_list_next(it)) { + cand =3D (RomSec *) it->data; + if (count =3D=3D 0 && count + cand->se =3D=3D 1) { + size_t gap =3D cand->base - gapstart; + if (gap > res.size) { + res.base =3D gapstart; + res.size =3D gap; + } + } else if (count =3D=3D 1 && count + cand->se =3D=3D 0) { + gapstart =3D cand->base; + } + count +=3D cand->se; + } + + g_list_free_full(secs, g_free); + return res; +} + /* * Copies memory from registered ROMs to dest. Any memory that is containe= d in * a ROM between addr and addr + size is copied. Note that this can involve diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index 37963becae..3704b250b2 100644 --- a/semihosting/arm-compat-semi.c +++ b/semihosting/arm-compat-semi.c @@ -44,6 +44,7 @@ #define COMMON_SEMI_HEAP_SIZE (128 * 1024 * 1024) #else #include "qemu/cutils.h" +#include "hw/loader.h" #ifdef TARGET_ARM #include "hw/arm/boot.h" #endif @@ -144,33 +145,69 @@ typedef struct GuestFD { static GArray *guestfd_array; =20 #ifndef CONFIG_USER_ONLY -#include "exec/address-spaces.h" -/* - * Find the base of a RAM region containing the specified address + +/** + * common_semi_find_bases: find information about ram and heap base + * + * This function attempts to provide meaningful numbers for RAM and + * HEAP base addresses. The rambase is simply the lowest addressable + * RAM position. For the heapbase we ask the loader to scan the + * address space and the largest available gap by querying the "ROM" + * regions. + * + * Returns: a structure with the numbers we need. */ -static inline hwaddr -common_semi_find_region_base(hwaddr addr) + +typedef struct LayoutInfo { + target_ulong rambase; + size_t ramsize; + hwaddr heapbase; + hwaddr heaplimit; +} LayoutInfo; + +static bool find_ram_cb(Int128 start, Int128 len, const MemoryRegion *mr, + hwaddr offset_in_region, void *opaque) +{ + LayoutInfo *info =3D (LayoutInfo *) opaque; + uint64_t size =3D int128_get64(len); + + if (!mr->ram || mr->readonly) { + return false; + } + + if (size > info->ramsize) { + info->rambase =3D int128_get64(start); + info->ramsize =3D size; + } + + /* search exhaustively for largest RAM */ + return false; +} + +static LayoutInfo common_semi_find_bases(CPUState *cs) { - MemoryRegion *subregion; + FlatView *fv; + LayoutInfo info =3D { 0, 0, 0, 0 }; + + RCU_READ_LOCK_GUARD(); + + fv =3D address_space_to_flatview(cs->as); + flatview_for_each_range(fv, find_ram_cb, &info); =20 /* - * Find the chunk of R/W memory containing the address. This is - * used for the SYS_HEAPINFO semihosting call, which should - * probably be using information from the loaded application. + * If we have found the RAM lets iterate through the ROM blobs to + * workout the best place for the remainder of RAM and split it + * equally between stack and heap. */ - QTAILQ_FOREACH(subregion, &get_system_memory()->subregions, - subregions_link) { - if (subregion->ram && !subregion->readonly) { - Int128 top128 =3D int128_add(int128_make64(subregion->addr), - subregion->size); - Int128 addr128 =3D int128_make64(addr); - if (subregion->addr <=3D addr && int128_lt(addr128, top128)) { - return subregion->addr; - } - } + if (info.rambase || info.ramsize > 0) { + RomGap gap =3D rom_find_largest_gap_between(info.rambase, info.ram= size); + info.heapbase =3D gap.base; + info.heaplimit =3D gap.base + gap.size; } - return 0; + + return info; } + #endif =20 #ifdef TARGET_ARM @@ -204,28 +241,6 @@ common_semi_sys_exit_extended(CPUState *cs, int nr) return (nr =3D=3D TARGET_SYS_EXIT_EXTENDED || is_a64(cs->env_ptr)); } =20 -#ifndef CONFIG_USER_ONLY -#include "hw/arm/boot.h" -static inline target_ulong -common_semi_rambase(CPUState *cs) -{ - CPUArchState *env =3D cs->env_ptr; - const struct arm_boot_info *info =3D env->boot_info; - target_ulong sp; - - if (info) { - return info->loader_start; - } - - if (is_a64(env)) { - sp =3D env->xregs[31]; - } else { - sp =3D env->regs[13]; - } - return common_semi_find_region_base(sp); -} -#endif - #endif /* TARGET_ARM */ =20 #ifdef TARGET_RISCV @@ -251,17 +266,6 @@ common_semi_sys_exit_extended(CPUState *cs, int nr) return (nr =3D=3D TARGET_SYS_EXIT_EXTENDED || sizeof(target_ulong) =3D= =3D 8); } =20 -#ifndef CONFIG_USER_ONLY - -static inline target_ulong -common_semi_rambase(CPUState *cs) -{ - RISCVCPU *cpu =3D RISCV_CPU(cs); - CPURISCVState *env =3D &cpu->env; - return common_semi_find_region_base(env->gpr[xSP]); -} -#endif - #endif =20 /* @@ -1165,12 +1169,12 @@ target_ulong do_common_semihosting(CPUState *cs) case TARGET_SYS_HEAPINFO: { target_ulong retvals[4]; - target_ulong limit; int i; #ifdef CONFIG_USER_ONLY TaskState *ts =3D cs->opaque; + target_ulong limit; #else - target_ulong rambase =3D common_semi_rambase(cs); + LayoutInfo info =3D common_semi_find_bases(cs); #endif =20 GET_ARG(0); @@ -1201,12 +1205,15 @@ target_ulong do_common_semihosting(CPUState *cs) retvals[2] =3D ts->stack_base; retvals[3] =3D 0; /* Stack limit. */ #else - limit =3D current_machine->ram_size; - /* TODO: Make this use the limit of the loaded application. */ - retvals[0] =3D rambase + limit / 2; - retvals[1] =3D rambase + limit; - retvals[2] =3D rambase + limit; /* Stack base */ - retvals[3] =3D rambase; /* Stack limit. */ + /* + * Reporting 0 indicates we couldn't calculate the real + * values which should force most software to fall back to + * using information it has. + */ + retvals[0] =3D info.heapbase; /* Heap Base */ + retvals[1] =3D info.heaplimit; /* Heap Limit */ + retvals[2] =3D info.heaplimit; /* Stack base */ + retvals[3] =3D info.heapbase; /* Stack limit. */ #endif =20 for (i =3D 0; i < ARRAY_SIZE(retvals); i++) { --=20 2.30.2 From nobody Tue May 14 10:55:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1644493324; cv=none; d=zohomail.com; s=zohoarc; b=E9P90iZveOwVu6NtDgiuMShTodkWVVdF9uifUkO0KaiYryP6A7oj/FlW1wdYqwlQ1wmen0y1l4ZaNB6Y7eLTwa7FQPZIKuTUeONGLGz9wvrqq8WVb+s89anaeK0X2sxnaZPmFugvBQwZ8HiTvySUdnEmwRzvYjFL002ry4RlhNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644493324; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9qy7IV48skw6PiK32u8+FO1zaKIr1zsoKUR1tPCSI0c=; b=RJeuzd2daVR9YwPKHnrAThZa24QMGk+kKjVVHlaewwwBDAjoQ4xud1J+6dMXsWDrc7aYBtkLIIh+Z+rDjJFjJewx2guq7xBIc205grV2qJZ0Dl1epnUbpRrrUiNKy2EK8m8fP8z3rdsOxbcZtXpr6lz/m1uKgA3/o3+/crxS4SQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1644493324898952.893046090194; Thu, 10 Feb 2022 03:42:04 -0800 (PST) Received: from localhost ([::1]:46278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nI7pr-0006pu-V8 for importer@patchew.org; Thu, 10 Feb 2022 06:42:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI7ef-0003ie-FI for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:30:32 -0500 Received: from [2a00:1450:4864:20::629] (port=45584 helo=mail-ej1-x629.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nI7ed-0002Vp-5O for qemu-devel@nongnu.org; Thu, 10 Feb 2022 06:30:29 -0500 Received: by mail-ej1-x629.google.com with SMTP id s21so14365260ejx.12 for ; Thu, 10 Feb 2022 03:30:26 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id ku15sm5624043ejc.25.2022.02.10.03.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 03:30:22 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B81B91FFBA; Thu, 10 Feb 2022 11:30:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9qy7IV48skw6PiK32u8+FO1zaKIr1zsoKUR1tPCSI0c=; b=wVmNAdBG53HscQ0hYgt7SAJbb4aIflYY8gWqyGKt4d2ZpkFLsRK3NMoswRZanLHMGE gCytAEagVH+Bn2mykwZjtPL/DHRdA0uYjODktv+2gzleeJWs307QGicWIkeWad3/Sseu pWUx2fgq6QtKRLR7VwmwZJNrHLt0bektrPzWno9ddPcGY1QrcswLgs9M0H429CcEKPta uLRnVrXkxojsiid9ACIfsqi9qoQDLlOVogZWv9t4CvHNe84G7AWJP83ndE/ie7oDTXX1 GRHK2+PNqVcBOHpbkbmMaRNrNkoj6p0/EpqUGp74LMdhATvxPZQKOxQfH7M8V0ojnyai 6+DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9qy7IV48skw6PiK32u8+FO1zaKIr1zsoKUR1tPCSI0c=; b=2xDQ++0LsgdsmtRmNOJnQ8UogTTwHzqtmGbpzulE8i2tEUtUFQkYRtLliRX28S1oC7 QqNKQRRUWFvOUV08k2d7IKS6GA03Yr92cCObyHq1NNCMzrbw7Ua7Avn/OmoFTfEa2gj9 0nrRVMZBZqEISsuDTnmyRhSG0ZvxlbgVvoufr6YYz8QhEtZ2Q5LvCpe5ZrSkzi0c+nst ILyprRnRe1GIRx3KaelAiyBZqKrZtefF5du6NMkcr7kLCiShrtzjPe8oW94vCoHe2fca 9iWMX5B2gauCaMuebCU6FUmq/P9BkmtUiEQe9eNt75clZCve4lk1AoXXJ3MWA3SGJzKO QT6g== X-Gm-Message-State: AOAM5305T6M21wqOQK81hbbk9zAYcV86XFDoaXNVWtLDhtFzBjQk+i1w t6QIdaZnczJqBLuVbriPuZtBWA== X-Google-Smtp-Source: ABdhPJwfVX22NAq1VhDZ/haNQlOJHs0z3kFlnw55yJ9GZw+NZJvmvO1VnEGC5oLvMXGmPKqRS2tPfw== X-Received: by 2002:a17:907:7207:: with SMTP id dr7mr5965867ejc.500.1644492625806; Thu, 10 Feb 2022 03:30:25 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v5 2/2] tests/tcg: port SYS_HEAPINFO to a system test Date: Thu, 10 Feb 2022 11:30:21 +0000 Message-Id: <20220210113021.3799514-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220210113021.3799514-1-alex.bennee@linaro.org> References: <20220210113021.3799514-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::629 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1644493326342100001 This allows us to check our new SYS_HEAPINFO implementation generates sane values. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell --- v5 - static init of heapinfo structure - clean-up comment on why we can test stack position - add memory clobber for semicall - test we can read/write to a portion of the heap - fix MAINTAINERS --- tests/tcg/aarch64/system/semiheap.c | 93 +++++++++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 94 insertions(+) create mode 100644 tests/tcg/aarch64/system/semiheap.c diff --git a/tests/tcg/aarch64/system/semiheap.c b/tests/tcg/aarch64/system= /semiheap.c new file mode 100644 index 0000000000..4ed258476d --- /dev/null +++ b/tests/tcg/aarch64/system/semiheap.c @@ -0,0 +1,93 @@ +/* + * Semihosting System HEAPINFO Test + * + * Copyright (c) 2021 Linaro Ltd + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include +#include +#include + +#define SYS_HEAPINFO 0x16 + +uintptr_t __semi_call(uintptr_t type, uintptr_t arg0) +{ + register uintptr_t t asm("x0") =3D type; + register uintptr_t a0 asm("x1") =3D arg0; + asm("hlt 0xf000" + : "=3Dr" (t) + : "r" (t), "r" (a0) + : "memory" ); + + return t; +} + +int main(int argc, char *argv[argc]) +{ + struct { + void *heap_base; + void *heap_limit; + void *stack_base; + void *stack_limit; + } info =3D { }; + void *ptr_to_info =3D (void *) &info; + uint32_t *ptr_to_heap; + int i; + + ml_printf("Semihosting Heap Info Test\n"); + + __semi_call(SYS_HEAPINFO, (uintptr_t) &ptr_to_info); + + if (info.heap_base =3D=3D NULL || info.heap_limit =3D=3D NULL) { + ml_printf("null heap: %p -> %p\n", info.heap_base, info.heap_limit= ); + return -1; + } + + /* Error if heap base is above limit */ + if ((uintptr_t) info.heap_base >=3D (uintptr_t) info.heap_limit) { + ml_printf("heap base %p >=3D heap_limit %p\n", + info.heap_base, info.heap_limit); + return -2; + } + + if (info.stack_base =3D=3D NULL) { + ml_printf("null stack: %p -> %p\n", info.stack_base, info.stack_li= mit); + return -3; + } + + /* + * boot.S put our stack somewhere inside the data segment of the + * ELF file, and we know that SYS_HEAPINFO won't pick a range + * that overlaps with part of a loaded ELF file. So the info + * struct (on the stack) should not be inside the reported heap. + */ + if (ptr_to_info > info.heap_base && ptr_to_info < info.heap_limit) { + ml_printf("info appears to be inside the heap: %p in %p:%p\n", + ptr_to_info, info.heap_base, info.heap_limit); + return -4; + } + + ml_printf("heap: %p -> %p\n", info.heap_base, info.heap_limit); + ml_printf("stack: %p <- %p\n", info.stack_limit, info.stack_base); + + /* finally can we read/write the heap */ + ptr_to_heap =3D (uint32_t *) info.heap_base; + for (i =3D 0; i < 512; i++) { + *ptr_to_heap++ =3D i; + } + ptr_to_heap =3D (uint32_t *) info.heap_base; + for (i =3D 0; i < 512; i++) { + uint32_t tmp =3D *ptr_to_heap; + if (tmp !=3D i) { + ml_printf("unexpected value in heap: %d @ %p", tmp, ptr_to_hea= p); + return -5; + } + ptr_to_heap++; + } + ml_printf("r/w to heap upto %p\n", ptr_to_heap); + + ml_printf("Passed HeapInfo checks\n"); + return 0; +} diff --git a/MAINTAINERS b/MAINTAINERS index b0b845f445..251f96af9e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3536,6 +3536,7 @@ S: Maintained F: semihosting/ F: include/semihosting/ F: tests/tcg/multiarch/arm-compat-semi/ +F: tests/tcg/aarch64/system/semiheap.c =20 Multi-process QEMU M: Elena Ufimtseva --=20 2.30.2