From nobody Mon Feb 9 19:53:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16443387859181009.9285916156456; Tue, 8 Feb 2022 08:46:25 -0800 (PST) Received: from localhost ([::1]:48932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHTdJ-0001Zv-Ek for importer@patchew.org; Tue, 08 Feb 2022 11:46:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHRaz-0003Ik-E7 for qemu-devel@nongnu.org; Tue, 08 Feb 2022 09:35:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHRap-0008H8-Hk for qemu-devel@nongnu.org; Tue, 08 Feb 2022 09:35:51 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-320-YD3Ktbk6P_urCKd6Q9UtJg-1; Tue, 08 Feb 2022 09:35:38 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62BCA81440E; Tue, 8 Feb 2022 14:35:37 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56FE3747B5; Tue, 8 Feb 2022 14:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644330941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wX+3AwW6iYj+pDk0+pG3oFLfarjTAcAJI2uFQ6auxic=; b=cM72UfGcThTGt0JARa57/FyPvckDTwMRvXybj+cgJTddaS9ZZZ6biovmHbanpIikrW4WcT BzhA9i/9SkNz2oOYSqYRBfQX8aUWiySeyGYgRhX6a9DG9JSTkwqrnmprv1fDGzCCU7Mq+e gzmmrSUDs3rPmBWSzUwkf9vsJwAKyd4= X-MC-Unique: YD3Ktbk6P_urCKd6Q9UtJg-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v5 16/20] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext Date: Tue, 8 Feb 2022 09:35:09 -0500 Message-Id: <20220208143513.1077229-17-eesposit@redhat.com> In-Reply-To: <20220208143513.1077229-1-eesposit@redhat.com> References: <20220208143513.1077229-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Emanuele Giuseppe Esposito , Markus Armbruster , qemu-devel@nongnu.org, Hanna Reitz , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1644338792031100001 Content-Type: text/plain; charset="utf-8" We are always using the given bs AioContext, so there is no need to take the job ones (which is identical anyways). This also reduces the point we need to check when protecting job.aio_context field. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Stefan Hajnoczi --- block/commit.c | 4 ++-- block/mirror.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/commit.c b/block/commit.c index 2883a3ba52..3ea460fe4a 100644 --- a/block/commit.c +++ b/block/commit.c @@ -369,7 +369,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, goto fail; } =20 - s->base =3D blk_new(s->common.job.aio_context, + s->base =3D blk_new(bdrv_get_aio_context(bs), base_perms, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED); @@ -381,7 +381,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, s->base_bs =3D base; =20 /* Required permissions are already taken with block_job_add_bdrv() */ - s->top =3D blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL); + s->top =3D blk_new(bdrv_get_aio_context(bs), 0, BLK_PERM_ALL); ret =3D blk_insert_bs(s->top, top, errp); if (ret < 0) { goto fail; diff --git a/block/mirror.c b/block/mirror.c index 0a3eb712e6..28d137407c 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1727,7 +1727,7 @@ static BlockJob *mirror_start_job( goto fail; } =20 - s->target =3D blk_new(s->common.job.aio_context, + s->target =3D blk_new(bdrv_get_aio_context(bs), target_perms, target_shared_perms); ret =3D blk_insert_bs(s->target, target, errp); if (ret < 0) { --=20 2.31.1