From nobody Mon Feb 9 20:12:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail header.i=@quicinc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1644192170316841.0852424620462; Sun, 6 Feb 2022 16:02:50 -0800 (PST) Received: from localhost ([::1]:33076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGrUW-0007ET-Pw for importer@patchew.org; Sun, 06 Feb 2022 19:02:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGrP4-0000PX-OI for qemu-devel@nongnu.org; Sun, 06 Feb 2022 18:57:10 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:55064) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1nGrP1-00084W-CW for qemu-devel@nongnu.org; Sun, 06 Feb 2022 18:57:09 -0500 Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 06 Feb 2022 15:50:54 -0800 Received: from hu-tsimpson-lv.qualcomm.com (HELO hu-devc-lv-u18-c.qualcomm.com) ([10.47.235.220]) by ironmsg08-lv.qualcomm.com with ESMTP; 06 Feb 2022 15:50:53 -0800 Received: by hu-devc-lv-u18-c.qualcomm.com (Postfix, from userid 47164) id A3A4150059B; Sun, 6 Feb 2022 15:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1644191827; x=1675727827; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tNqqqrBfxkzf1q8B88OdtnWymC8vC3Fcezde/EkrMuU=; b=dtV1Srz4sOLZ2U/k1nL5SKMRrnnGVF6qI6jqESWfovT1fmt1V+tjwbvN K4Q8JqIVdo0IEi1SIZGL2lz+P8NKotgPWkpbqcMeNzRCy40QXYCzvzMoq vvtPOUYr8IInmmbVYGDw633NVQe6N4Foe+MwU6a6EMKdki8066QESCf6d E=; X-QCInternal: smtphost From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PATCH 4/8] Hexagon (target/hexagon) properly handle SNaN in dfmin/dfmax/sfmin/sfmax Date: Sun, 6 Feb 2022 15:50:26 -0800 Message-Id: <20220206235030.31493-5-tsimpson@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220206235030.31493-1-tsimpson@quicinc.com> References: <20220206235030.31493-1-tsimpson@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=129.46.98.28; envelope-from=tsimpson@qualcomm.com; helo=alexa-out.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, richard.henderson@linaro.org, f4bug@amsat.org, tsimpson@quicinc.com, mlambert@quicinc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1644192172508100001 The float??_minnum implementation differs from Hexagon for SNaN, it returns NaN, but Hexagon returns the other input. So, we add checks for NaN before calling it. test cases added in a subsequent patch to more extensively test USR bits Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 54 +++++++++++++++++++++++++++++++++----- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 75dc0f23f0..7f40e09486 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -947,7 +947,17 @@ float32 HELPER(sfmax)(CPUHexagonState *env, float32 Rs= V, float32 RtV) { float32 RdV; arch_fpop_start(env); - RdV =3D float32_maxnum(RsV, RtV, &env->fp_status); + if (float32_is_signaling_nan(RsV, &env->fp_status) && + !float32_is_any_nan(RtV)) { + RdV =3D RtV; + float_raise(float_flag_invalid, &env->fp_status); + } else if (!float32_is_any_nan(RsV) && + float32_is_signaling_nan(RtV, &env->fp_status)) { + RdV =3D RsV; + float_raise(float_flag_invalid, &env->fp_status); + } else { + RdV =3D float32_maxnum(RsV, RtV, &env->fp_status); + } arch_fpop_end(env); return RdV; } @@ -956,7 +966,17 @@ float32 HELPER(sfmin)(CPUHexagonState *env, float32 Rs= V, float32 RtV) { float32 RdV; arch_fpop_start(env); - RdV =3D float32_minnum(RsV, RtV, &env->fp_status); + if (float32_is_signaling_nan(RsV, &env->fp_status) && + !float32_is_any_nan(RtV)) { + RdV =3D RtV; + float_raise(float_flag_invalid, &env->fp_status); + } else if (!float32_is_any_nan(RsV) && + float32_is_signaling_nan(RtV, &env->fp_status)) { + RdV =3D RsV; + float_raise(float_flag_invalid, &env->fp_status); + } else { + RdV =3D float32_minnum(RsV, RtV, &env->fp_status); + } arch_fpop_end(env); return RdV; } @@ -1040,9 +1060,20 @@ float64 HELPER(dfmax)(CPUHexagonState *env, float64 = RssV, float64 RttV) { float64 RddV; arch_fpop_start(env); - RddV =3D float64_maxnum(RssV, RttV, &env->fp_status); - if (float64_is_any_nan(RssV) || float64_is_any_nan(RttV)) { + if (float64_is_signaling_nan(RssV, &env->fp_status) && + !float64_is_any_nan(RttV)) { + RddV =3D RttV; float_raise(float_flag_invalid, &env->fp_status); + } else if (!float64_is_any_nan(RssV) && + float64_is_signaling_nan(RttV, &env->fp_status)) { + RddV =3D RssV; + float_raise(float_flag_invalid, &env->fp_status); + } else { + RddV =3D float64_maxnum(RssV, RttV, &env->fp_status); + if (float64_is_quiet_nan(RssV, &env->fp_status) || + float64_is_quiet_nan(RttV, &env->fp_status)) { + float_raise(float_flag_invalid, &env->fp_status); + } } arch_fpop_end(env); return RddV; @@ -1052,9 +1083,20 @@ float64 HELPER(dfmin)(CPUHexagonState *env, float64 = RssV, float64 RttV) { float64 RddV; arch_fpop_start(env); - RddV =3D float64_minnum(RssV, RttV, &env->fp_status); - if (float64_is_any_nan(RssV) || float64_is_any_nan(RttV)) { + if (float64_is_signaling_nan(RssV, &env->fp_status) && + !float64_is_any_nan(RttV)) { + RddV =3D RttV; float_raise(float_flag_invalid, &env->fp_status); + } else if (!float64_is_any_nan(RssV) && + float64_is_signaling_nan(RttV, &env->fp_status)) { + RddV =3D RssV; + float_raise(float_flag_invalid, &env->fp_status); + } else { + RddV =3D float64_minnum(RssV, RttV, &env->fp_status); + if (float64_is_quiet_nan(RssV, &env->fp_status) || + float64_is_quiet_nan(RttV, &env->fp_status)) { + float_raise(float_flag_invalid, &env->fp_status); + } } arch_fpop_end(env); return RddV; --=20 2.17.1