From nobody Sun May 12 14:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=quarantine dis=quarantine) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1644065135; cv=none; d=zohomail.com; s=zohoarc; b=OV4RlHUUmDgBpW2fCpbzSLvsHQZb9gpE4AtiLFoS6q+Zssxw8zDLjO2A60TKBURO4QaSCk1Ly8a+PydKsp4VUqTWHcnQh1ffN3ZndhIFXwaL4FSTikViUiOD2HGcNw/4/eaPbcp2ms4guRA5VVJ1e1cckA2WwegW3jgFXFCCTwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644065135; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=evtIBXc2XbOQXIQlNH8D77rdUx7zxf/It59jNbA4TBw=; b=YCdAAVD5ixlm6iopQb3nm1qFvHpkOnC21B7EobfbfCKx0FaeeGWZmNv04tC/lXzAM0Y/QOJzN5fab4JYwGb68hIO5ka76bbNTsZozKApNzQgAMJ1qr+Hb0E9QiXRwYwj27q3zhUITINCF/R0V9Ixu9A0y3SM1Q8E8eaZPKHwOzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1644065135383318.1061315377498; Sat, 5 Feb 2022 04:45:35 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id u15so16286725wrt.3 for ; Sat, 05 Feb 2022 04:45:34 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id t1sm5378265wre.45.2022.02.05.04.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Feb 2022 04:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=evtIBXc2XbOQXIQlNH8D77rdUx7zxf/It59jNbA4TBw=; b=PuvKiVkkmr3sD5KBpbNH3iM0GFQsYHzWDEAEexSc8M9ASRny4gDPLPeOWlH+VNj9X1 RZ3wpBkcQwK3q6dfukAEauCkolx+D91UdsPGx0QhqzadUVgHFH8LP6SwlwLebfjMLyyp 9dLKCGNNAs59jhGqGKD9Q/PyOc2seZ5/cRIU5iqi3wcRcRfIQtt+IhDC0wtBx4G2f55Y oHzSJweGKsYr1pjg4OqGtlXKke+4tkvYyNlFTV29MdaMhRPcs8Xdz45fNTgcDyTjMnQ0 PE3Lh3neD4T5P8B6+0P+hX9NNWlW+S3uNR3WzyxoVIYSC3RZAeBadIbZ2t46i//M3CT4 XuLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=evtIBXc2XbOQXIQlNH8D77rdUx7zxf/It59jNbA4TBw=; b=mNsw3Gh+b1SZlBORa6R20t4ufAHlshHzqUg9jVcQfUHgfU7K/WOxb6BV3lV9BI2C9f 0pFN/ftR/UaKlSkhWDxXMJ0sVHVchA7sQ8KOni3m09CzZ6eJEfqn+Mz7AkOTwwMh2fsv gFiuOaws0ff/jh4+YRmoIJPp0IcS2NzQvI/0MsMQTPH4sVzJoTtoFvAZz1VhF2jhmF39 fjZ9eIJTyENcB51cfmfCuK9REZL6FvbWSVXdRyAHr6/3+DYEDVrePDWzVFWgvfn7NDDY cDFbckpw8YfcpOLZGCerqkTQHkcfiyFxosXe8/2FRNIlaeRPHANkQy7ZOnLt1Idrm9l3 rU5w== X-Gm-Message-State: AOAM533ZSsxrj+C6C26Zu5jDMIkhVWzDozBclsZOU28AU43rok0wylBk vawrz7Xja4CXOLsGQTGE9Hw= X-Google-Smtp-Source: ABdhPJyfjuohszKFd0FN7LnJzMh1KUYLFVceTnQRhWQZJ41hFrK4najayA1Rxm4souXs12X97J8DnQ== X-Received: by 2002:a5d:64c8:: with SMTP id f8mr3080693wri.337.1644065133640; Sat, 05 Feb 2022 04:45:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yang Zhong , "Michael S. Tsirkin" , Jean-Philippe Brucker , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Ani Sinha , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 1/4] tests/qtest/acpi: Temporary allow VIOT table changes Date: Sat, 5 Feb 2022 13:45:23 +0100 Message-Id: <20220205124526.500158-2-f4bug@amsat.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220205124526.500158-1-f4bug@amsat.org> References: <20220205124526.500158-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1644065137646100001 In preparation of changing the VIOT table, add it to the ACPI tests allowlist. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index dfb8523c8bf..27ab8d3ba8d 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,2 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/q35/VIOT.viot", --=20 2.34.1 From nobody Sun May 12 14:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=amsat.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1644065166003201.4116160605298; Sat, 5 Feb 2022 04:46:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-623w3w-JM_WKyS_XQQdJQw-1; Sat, 05 Feb 2022 07:46:02 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 791BE363A4; Sat, 5 Feb 2022 12:45:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FCA56D02A; Sat, 5 Feb 2022 12:45:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2E10A4BB7C; Sat, 5 Feb 2022 12:45:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 215CjiZo011120 for ; Sat, 5 Feb 2022 07:45:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7225740FF696; Sat, 5 Feb 2022 12:45:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D52640FF690 for ; Sat, 5 Feb 2022 12:45:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 536AC801E8D for ; Sat, 5 Feb 2022 12:45:44 +0000 (UTC) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-aPkJR-klNCKLoLtGwhVLmA-1; Sat, 05 Feb 2022 07:45:40 -0500 Received: by mail-wr1-f52.google.com with SMTP id j16so16170102wrd.8; Sat, 05 Feb 2022 04:45:39 -0800 (PST) Received: from nuc.. (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id q2sm4433669wrw.14.2022.02.05.04.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Feb 2022 04:45:38 -0800 (PST) X-MC-Unique: 623w3w-JM_WKyS_XQQdJQw-1 X-MC-Unique: aPkJR-klNCKLoLtGwhVLmA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kqczEjmmxYGSgKtA86NCLgWxtCH+cJ1jSQOS+NjVnJA=; b=1f8ESDWfCrmNMo5U8WVIZ5v6e2RmGIT9px4ZRxx5QvMsam4xJmkh0cZoFoXOr3Mhz4 gttgp+maKEr+AXdyFLFycvytLDnuQR+nCNiP8Hvz3HVJyuF4Fy97D+LLHcWdetatOnS5 02t1lj5SSMVdGOFA8OPkypPkMBlnzt7Ja7kbAPjF/0sV4AHkV7y+ROhKD4w2t0qllEDQ V8ja5TzuZ5CMf49qdqHbnuqvPG/UvuSkD9tdeOGFu4CxIximDr0cmiXdTgoEoIvARzKr ogmooamVfjG0jWr3iT8L6Ddhy6/wgOrj2G+kDImXejeibBHoN/FWT1zkZigsrILRJzH2 s76A== X-Gm-Message-State: AOAM530Ik/hEqenJuO8qkh/hP+EUdsgoZ7iwyt7kYaphT9O6rzcQHD4o GxRw/HrnKroR73IYqEIo+lg= X-Google-Smtp-Source: ABdhPJywP3MGiFxe1+SuCNMt1DripYChSsg20LEXJcKDgrabHsFkgZ5XGnyHCez4aM9M/GuLuevFFw== X-Received: by 2002:a05:6000:2aa:: with SMTP id l10mr2914067wry.191.1644065138835; Sat, 05 Feb 2022 04:45:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 2/4] hw/i386: Attach CPUs to machine Date: Sat, 5 Feb 2022 13:45:24 +0100 Message-Id: <20220205124526.500158-3-f4bug@amsat.org> In-Reply-To: <20220205124526.500158-1-f4bug@amsat.org> References: <20220205124526.500158-1-f4bug@amsat.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: libvir-list@redhat.com Cc: Yang Zhong , Jean-Philippe Brucker , "Michael S. Tsirkin" , libvir-list@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Igor Mammedov , Ani Sinha , Paolo Bonzini X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1644065168415100001 Previously CPUs were exposed in the QOM tree at a path /machine/unattached/device[nn] where the 'nn' of the first CPU is usually zero, but can vary depending on what devices were already created. With this change the CPUs are now at /machine/cpu[nn] where the 'nn' of the first CPU is always zero. Note: This (intentionally) breaks compatibility with current libvirt code that looks for "/machine/unattached/device[0]" in the assumption it is the first CPU. Cc: libvir-list@redhat.com Suggested-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/x86.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index b84840a1bb9..50bf249c700 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -108,6 +108,7 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_i= d, Error **errp) { Object *cpu =3D object_new(MACHINE(x86ms)->cpu_type); =20 + object_property_add_child(OBJECT(x86ms), "cpu[*]", OBJECT(cpu)); if (!object_property_set_uint(cpu, "apic-id", apic_id, errp)) { goto out; } --=20 2.34.1 From nobody Sun May 12 14:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=quarantine dis=quarantine) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1644065145; cv=none; d=zohomail.com; s=zohoarc; b=fD7/3ofwGyG+JMighjsEGTNsAmWlNpMz3GI2HRM5TsHBPgXEVyxACBMLp6kCla6PljoDALyKU1Rsq6adoRPxS/Dc4csjq14VCHFmxrIye4QhDriwuE0fU00yHVCQ7MN5yKbXEE+fVJhDS1hs9Yv5VFAUv+98647V4ZkpiVQIsX8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644065145; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Yuz/9v4u5M09P8jk52zn4t509YN+V3S2cmy3DTylfSY=; b=Z8hmBznKReImXNfC0cvEjJuFUg23cN6lycWrlI8/ckBSd5Gr+du/WEoVrBnVZkgkRE7gh8TiZ2g769ux1O/RPAJjHWxzVMfySriv5iGhEfzSIZuXoHIy9NJpt/Z5lIMGSq/0BQ8H7ASD2uMG0zN/gm2nm9rLLY4j2RuBfyXVVc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1644065145477388.2516961215134; Sat, 5 Feb 2022 04:45:45 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id m14so16183329wrg.12 for ; Sat, 05 Feb 2022 04:45:44 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id az16sm3823560wmb.15.2022.02.05.04.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Feb 2022 04:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yuz/9v4u5M09P8jk52zn4t509YN+V3S2cmy3DTylfSY=; b=a3PVbZ/KtWYQ/Jd25/edukXNjS2/xmVcJz8QHAF8+f17cNOrHnmLqxRxqdcY+3G4F+ UChS+MOvW76BilVatTpuric5+XCDt+OgdWNS84JeNwEU+FHCRgYISgvkE7OZ9JIldgcP 1tVPzlievBvWoCT5czrHEphzEwrUPDt5IemofEOKbTWeXUS5T9Y35Ix0mv0GBjKj39KI Zi3UaUtwSQ3PYQwy6yQeD0KYl2p6xx+vaQmSQtb3ya8HI0aoRn8Uasgy3/QHT+Z8aHRX mtwps1uJg/86TEIlEDVKhewQbfU5Ow41NXcKORwfysj3WlcTC26evR/1dagULzXLVvV1 rsnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Yuz/9v4u5M09P8jk52zn4t509YN+V3S2cmy3DTylfSY=; b=XY8IUwvyQxlHLYxSXf0kphWKxHqM7yu4KOS4bEYzhzbjBDUcRJspbTnOUJKZVC2MmN YHeaNQxJl+FVodEMa/9NAsDIO6F19xbbisR2rfK+5qEc5mWxlbX/NuUt/737+V7IsGHQ dTC0+r5WpYh3eD4TsII4bWoNQDk1a5NSBjqPE4fuUxchx8yvgMbeh2cJ/NUPg+VS72pn x5bTfhnEvd7RGyHYzm5tGwDnOxnopkdKZNZzONj2fKiTVDi3VKcZnQ1LC4zGBMHHdJUL Ts/e/k9YDXZbn8OBX+Avx96KAilnn86heVf3gg9+zTqql1mux09CMjI/hjlEnDO5zAQR Xu/w== X-Gm-Message-State: AOAM5336hbOk6V4NKnq6STmvOMF3W7z6c4U1/F93l7/71O2ncs+ZAsNG u5QNSJLDX5UuAknCmWgc5EU= X-Google-Smtp-Source: ABdhPJyMwPVn0urrWXsS9FK6UR3fXo9JZIdH9lq4eVClNsEQ7qtYUdMnWMMvAuSLP5x6l+1E4bZTGw== X-Received: by 2002:a05:6000:1707:: with SMTP id n7mr2885350wrc.662.1644065143691; Sat, 05 Feb 2022 04:45:43 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yang Zhong , "Michael S. Tsirkin" , Jean-Philippe Brucker , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Ani Sinha , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/4] tests/qtest/acpi: Update VIOT table blob Date: Sat, 5 Feb 2022 13:45:25 +0100 Message-Id: <20220205124526.500158-4-f4bug@amsat.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220205124526.500158-1-f4bug@amsat.org> References: <20220205124526.500158-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1644065146704100001 Empty bios-tables-test-allowed-diff.h and run rebuild-expected-aml.sh to update the VIOT blob. The iasl output diff is: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20210604 (64-bit version) * Copyright (c) 2000 - 2021 Intel Corporation * * Disassembly of tests/data/acpi/q35/VIOT.viot, Sat Feb 5 11:11:11 2022 * * ACPI Data Table [VIOT] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue */ [000h 0000 4] Signature : "VIOT" [Virtual I/O Tran= slation Table] [004h 0004 4] Table Length : 00000070 [008h 0008 1] Revision : 00 [009h 0009 1] Checksum : 3D [00Ah 0010 6] Oem ID : "BOCHS " [010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 [024h 0036 2] Node count : 0003 [026h 0038 2] Node offset : 0030 [028h 0040 8] Reserved : 0000000000000000 [030h 0048 1] Type : 03 [VirtIO-PCI IOMMU] [031h 0049 1] Reserved : 00 [032h 0050 2] Length : 0010 [034h 0052 2] PCI Segment : 0000 [036h 0054 2] PCI BDF number : 0010 [038h 0056 8] Reserved : 0000000000000000 [040h 0064 1] Type : 01 [PCI Range] [041h 0065 1] Reserved : 00 [042h 0066 2] Length : 0018 -[044h 0068 4] Endpoint start : 00003000 +[044h 0068 4] Endpoint start : 00001000 [048h 0072 2] PCI Segment start : 0000 [04Ah 0074 2] PCI Segment end : 0000 -[04Ch 0076 2] PCI BDF start : 3000 -[04Eh 0078 2] PCI BDF end : 30FF +[04Ch 0076 2] PCI BDF start : 1000 +[04Eh 0078 2] PCI BDF end : 10FF [050h 0080 2] Output node : 0030 [052h 0082 6] Reserved : 000000000000 [058h 0088 1] Type : 01 [PCI Range] [059h 0089 1] Reserved : 00 [05Ah 0090 2] Length : 0018 -[05Ch 0092 4] Endpoint start : 00001000 +[05Ch 0092 4] Endpoint start : 00003000 [060h 0096 2] PCI Segment start : 0000 [062h 0098 2] PCI Segment end : 0000 -[064h 0100 2] PCI BDF start : 1000 -[066h 0102 2] PCI BDF end : 10FF +[064h 0100 2] PCI BDF start : 3000 +[066h 0102 2] PCI BDF end : 30FF [068h 0104 2] Output node : 0030 [06Ah 0106 6] Reserved : 000000000000 Raw Table Data: Length 112 (0x70) 0000: 56 49 4F 54 70 00 00 00 00 3D 42 4F 43 48 53 20 // VIOTp....=3D= BOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....= BXPC 0020: 01 00 00 00 03 00 30 00 00 00 00 00 00 00 00 00 // ......0.....= .... 0030: 03 00 10 00 00 00 10 00 00 00 00 00 00 00 00 00 // ............= .... - 0040: 01 00 18 00 00 30 00 00 00 00 00 00 00 30 FF 30 // .....0......= .0.0 - 0050: 30 00 00 00 00 00 00 00 01 00 18 00 00 10 00 00 // 0...........= .... - 0060: 00 00 00 00 00 10 FF 10 30 00 00 00 00 00 00 00 // ........0...= .... + 0040: 01 00 18 00 00 10 00 00 00 00 00 00 00 10 FF 10 // ............= .... + 0050: 30 00 00 00 00 00 00 00 01 00 18 00 00 30 00 00 // 0...........= .0.. + 0060: 00 00 00 00 00 30 FF 30 30 00 00 00 00 00 00 00 // .....0.00...= .... Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - tests/data/acpi/q35/VIOT.viot | Bin 112 -> 112 bytes 2 files changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index 27ab8d3ba8d..dfb8523c8bf 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/q35/VIOT.viot", diff --git a/tests/data/acpi/q35/VIOT.viot b/tests/data/acpi/q35/VIOT.viot index 9b179266ccbf84f1c250ee646812d17e27987764..275c78fbe8e93190321d957c91c= 3f17551f865d4 100644 GIT binary patch delta 10 RcmXRYnBY1wR(PU=3D1OOI`1E2r^ delta 10 RcmXRYnBY1wR(PU=3D1OOI`1E2r^ --=20 2.34.1 From nobody Sun May 12 14:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=quarantine dis=quarantine) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1644065150; cv=none; d=zohomail.com; s=zohoarc; b=IcPJvioZKyTt9tHsEH5k/46N/Miyv4UamqS/JzkEqh4gpWHjmJIcDpbZeNgQpD3u97zDLk6HqUx2eHRZ2b11S8qFeANkwOZj8piGB9Qjf5eOmnyEiYy0pPwT/CrZsYvsWVqQDdrtlmFdZ5N1vg1a9bs+N7C8c1cjWyFoArAvstI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644065150; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AOPY/qtmKHQg2E5Q15NX1b06PLvVTPqP1LdnToTRgJI=; b=nWI7qQiXPQv6r1JT8i6kmGP/bp9dyqeVoMcl9LJ92lApSFPxiJ9T9h171yYisXbJe82dk7kqNN9sTKp1SwLDWMiUPX+EWs+ZXtRKi+Zx1C1ATA9tF9SE49diBfqM2JZcftSx0qcrJTNqWJY8a23qklIteGr0ZQS2bvZhSUHvt6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1644065150328701.1748221285599; Sat, 5 Feb 2022 04:45:50 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id j5-20020a05600c1c0500b0034d2e956aadso5400879wms.4 for ; Sat, 05 Feb 2022 04:45:49 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id v8sm3637370wmd.44.2022.02.05.04.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Feb 2022 04:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AOPY/qtmKHQg2E5Q15NX1b06PLvVTPqP1LdnToTRgJI=; b=aIZXgBd4YJGPwHbT6b+KcuVJevGxm8NPoo7ijv6w9nmqQaoOTQnsfASqpU6JurQXY1 PnU0VUjboAKcfNAhcha3y+WU0pcqY+m8r54WCovaX4a/Y3JBFu3eVqmLkktNSiZXxjH8 nXJLqS+ugLDZfMhSbu2liPZRJVS1FzNdP7KudhfLve1bG8lIiLPKG7JY3GGEctGYDg27 oNKZxyghE/fc0YEPOoTl1K1KA/U000CLOGV3VKcQVehU188ErFEwI4tbX/ZfdE0Xu/RM rNYp9WKVxHw4iEBYFNJ8smykZSRrseSdoU9assjiWO7aAcYUGWBAIHBC1pzL+IWsUpux 3QdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=AOPY/qtmKHQg2E5Q15NX1b06PLvVTPqP1LdnToTRgJI=; b=0dN9eHl2neVwLOFupNJfXsOebo5tTXvhYo7D1Rf+a/oXY4v4oH9KGmAm7zyBb1htof BNSZdDB6wRAu+Dm8zmnSBu27Bmg5AbPslxpyzQd+9FlUet2Ot9EczR8j7/gVKGoGWwwP xFwSuMptWIlE7DegzHOs+/eR+vmL2scHRnoCKC7TXnVgXl+SldUfu18ZLmurM5AHxU7j stsnWvg7D4X6bx82Cs7Rm1rAT4hmgrwpjUfp/OxrVdWi1ZNREHN+G76P/15MEXGVuWWq SmYjQcVhnXNjy5MPV+ah3qAsv6KyOKm8f3aPC7tBbUxJ/6X1IQpwYWFqHeYqwaoDoVCC 2GsQ== X-Gm-Message-State: AOAM532f6/bcig1X+k3Pqgo35qow2prGuW8zCHQ5soLR16g3hbRp+2u4 96R7/79xs8UInIvqJQs6vAk= X-Google-Smtp-Source: ABdhPJxAXZomMB3Xbc/Al5AOGAIBZPIKTC+N+R7inxoCbllxqnzp7bNgwZ3r6kNfXLuqAzNS9KOlSg== X-Received: by 2002:a05:600c:1e84:: with SMTP id be4mr2976375wmb.147.1644065148639; Sat, 05 Feb 2022 04:45:48 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Yang Zhong , "Michael S. Tsirkin" , Jean-Philippe Brucker , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Ani Sinha , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 4/4] hw/i386/sgx: Attach SGX-EPC objects to machine Date: Sat, 5 Feb 2022 13:45:26 +0100 Message-Id: <20220205124526.500158-5-f4bug@amsat.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220205124526.500158-1-f4bug@amsat.org> References: <20220205124526.500158-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1644065151269100001 Previously SGX-EPC objects were exposed in the QOM tree at a path /machine/unattached/device[nn] where the 'nn' varies depending on what devices were already created. With this change the SGX-EPC objects are now at /machine/sgx-epc[nn] where the 'nn' of the first SGX-EPC object is always zero. Reported-by: Yang Zhong Suggested-by: Paolo Bonzini Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/sgx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c index a2b318dd938..3ab2217ca43 100644 --- a/hw/i386/sgx.c +++ b/hw/i386/sgx.c @@ -304,6 +304,8 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms) for (list =3D x86ms->sgx_epc_list; list; list =3D list->next) { obj =3D object_new("sgx-epc"); =20 + object_property_add_child(OBJECT(pcms), "sgx-epc[*]", OBJECT(obj)); + /* set the memdev link with memory backend */ object_property_parse(obj, SGX_EPC_MEMDEV_PROP, list->value->memde= v, &error_fatal); --=20 2.34.1