From nobody Mon Feb 9 23:02:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1643921852; cv=none; d=zohomail.com; s=zohoarc; b=f25Qr55+Is0tsTzPiNnKFQNwjOykt7ilxdlz6hWAJQNSYlLzHj3lqtH8ezaCJGHiXHBa3FaWIaWoLJ692E6aH8wevta8bLcD7tmOpiox16SyFezuEGDpMJM4dGt9jpCjOT4i93y+kYa6PvUnmR5vXTNKNxcVjd3lYbFRIuz0Zgg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643921852; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wwui0+WgM4nUhQWC4QaU40VqiH7mK4rt3aliM0RxQg0=; b=JVXdKPpNDTqdX+5EDNpX9WWaOby508Wjjo5rICx6RyJ0yI96aG4hCMWPp8XTn/+L6uJ8X7kUNZ9g/H030VmIs+p4pC2fnYUakJy9jol/IE+ab6oQSGaWkOPgFCWEN6xtYRQBo+j3GiAngK8aknj4s5VQIUcThT13KmOBhbzwFQo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164392185253663.618297888388156; Thu, 3 Feb 2022 12:57:32 -0800 (PST) Received: from localhost ([::1]:41346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFjAZ-00048t-Ir for importer@patchew.org; Thu, 03 Feb 2022 15:57:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFhw2-000464-2m for qemu-devel@nongnu.org; Thu, 03 Feb 2022 14:38:26 -0500 Received: from [2607:f8b0:4864:20::635] (port=40595 helo=mail-pl1-x635.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFhvz-0005rW-3j for qemu-devel@nongnu.org; Thu, 03 Feb 2022 14:38:25 -0500 Received: by mail-pl1-x635.google.com with SMTP id y17so3073178plg.7 for ; Thu, 03 Feb 2022 11:38:18 -0800 (PST) Received: from localhost.localdomain (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id mm24sm10865058pjb.20.2022.02.03.11.38.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Feb 2022 11:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wwui0+WgM4nUhQWC4QaU40VqiH7mK4rt3aliM0RxQg0=; b=d3JVR5lfk3VJQDdDk2hZehXRy+Ff/OktDe07R8bYRvWYn8uJHyrc7aUff6LxDWoxCC Ubgs+2Zn7lMEeWCL7lQAUWTYJsx3gR0FKmNUnFYVe8V1ZaAooPK3ynhPsVXbvROUqFxO 3mKzaDT6zh3JcLZT17pXKUN5EKMs1PFFWj9VDoydsZOeZEbj4xO65bvDXXrCPqcOVLR5 xCld+4n9ODMRhCozSJKK3yJl8CCr1hjxJMh6WEHE3CF8JRxNA37w03xE+k406NhrrpBp N47wFe6Sb5I98aCB/rf7fdkz9HItkR3l/iCAFksGl63tmJckyUMd8b88Y29Pwrsbh9z1 mGEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wwui0+WgM4nUhQWC4QaU40VqiH7mK4rt3aliM0RxQg0=; b=Gvoq7CW2i9C1rqYWA6SjqlgJRGdvNWYfUbg+nwkZYbKjZaMTcGxb8rCmD8eHfTAQrV bF6CTfHyMgm3unsjf//v646lVbrOXur9opmFD2Mp6cjFG/MNRRuBar1eFQUYeWjcjkng gQ4ACQtDaEvcFxf05DfaQP0eC8ssKsZM9SctGDN1q119ES4XBXqTOmRHO6MkaV62Wllu mHKrI7N/YinUpw38o6l+jbYamKl91EQlbK9/VpfqfRNhPqpHbHbQ/FG8/CtlD9C9rlS2 EJ+qV3DlUmA7N7N34wOL0VOvrGykXWA6YRX3R2w+qpIgGSRpklKtyQKcQjlCqFghIN7d Sz7w== X-Gm-Message-State: AOAM530ENZj9uiLerPY+9GoY9N/q3aAXin1MHcf4p2jIseK21gbOSRdB Q+Cpjdv1//hPRaYjHhT4eMmfmn0JOA8= X-Google-Smtp-Source: ABdhPJx5fhgKd+KkP0z7cL6oAr9unGSh/GAOoxWH/aDROoWstL3lfY/XrySTtPb+7dEs2qgILD2nCw== X-Received: by 2002:a17:90b:3850:: with SMTP id nl16mr15581872pjb.131.1643917097285; Thu, 03 Feb 2022 11:38:17 -0800 (PST) To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 01/10] hw/tpm: Clean includes Date: Thu, 3 Feb 2022 20:37:54 +0100 Message-Id: <20220203193803.45671-2-f4bug@amsat.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220203193803.45671-1-f4bug@amsat.org> References: <20220203193803.45671-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::635 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Reply-to: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= via X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1643921855153100001 "tpm_ppi.h" only requires to include "exec/memory.h" to get the MemoryRegion declaration. tpm_ppi.c requires "hw/qdev-core.h" to use the DEVICE() macro, tpm_crb.c is the only source file requiring "exec/address-spaces.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/tpm/tpm_crb.c | 1 + hw/tpm/tpm_ppi.c | 4 ++-- hw/tpm/tpm_ppi.h | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c index 58ebd1469c..aa9c00aad3 100644 --- a/hw/tpm/tpm_crb.c +++ b/hw/tpm/tpm_crb.c @@ -18,6 +18,7 @@ =20 #include "qemu/module.h" #include "qapi/error.h" +#include "exec/address-spaces.h" #include "hw/qdev-properties.h" #include "hw/pci/pci_ids.h" #include "hw/acpi/tpm.h" diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c index 274e9aa4b0..6dbb9f41e4 100644 --- a/hw/tpm/tpm_ppi.c +++ b/hw/tpm/tpm_ppi.c @@ -14,9 +14,9 @@ #include "qemu/osdep.h" =20 #include "qapi/error.h" -#include "cpu.h" #include "sysemu/memory_mapping.h" #include "migration/vmstate.h" +#include "hw/qdev-core.h" #include "hw/acpi/tpm.h" #include "tpm_ppi.h" #include "trace.h" @@ -44,7 +44,7 @@ void tpm_ppi_reset(TPMPPI *tpmppi) } } =20 -void tpm_ppi_init(TPMPPI *tpmppi, struct MemoryRegion *m, +void tpm_ppi_init(TPMPPI *tpmppi, MemoryRegion *m, hwaddr addr, Object *obj) { tpmppi->buf =3D qemu_memalign(qemu_real_host_page_size, diff --git a/hw/tpm/tpm_ppi.h b/hw/tpm/tpm_ppi.h index 6f773c25a0..bf5d4a300f 100644 --- a/hw/tpm/tpm_ppi.h +++ b/hw/tpm/tpm_ppi.h @@ -12,7 +12,7 @@ #ifndef TPM_TPM_PPI_H #define TPM_TPM_PPI_H =20 -#include "exec/address-spaces.h" +#include "exec/memory.h" =20 typedef struct TPMPPI { MemoryRegion ram; @@ -29,7 +29,7 @@ typedef struct TPMPPI { * Register the TPM PPI memory region at @addr on the given address * space for the object @obj. **/ -void tpm_ppi_init(TPMPPI *tpmppi, struct MemoryRegion *m, +void tpm_ppi_init(TPMPPI *tpmppi, MemoryRegion *m, hwaddr addr, Object *obj); =20 /** --=20 2.34.1