From nobody Fri May 3 00:51:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1643128949; cv=none; d=zohomail.com; s=zohoarc; b=XWudCvWmOfdon+riuArpswOnUoPVgQfCKdU6zWN4IP5hVn+6afRHKUGZAjfUFn9MzpUt4z7KI2Z1UdK8pMLxz+Oj3GtsCV9ywhTZk/14O/OOKuaKLkaKh9g24pCXqEgHuLCxhUmcYy3F2aFkMw5GgEOwysTjBMnESRX760ayeKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643128949; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=MvqqKgm51a9RkxXNdoE2SHc7RqqOkz+eRk/Pc/Vjr+I=; b=k49oZxL/A8j1oBOSYmHhU3hh9blpYXpL7qwIny+Jbkps8NMznX+CEUcYp8tD+gr7ipRXMUkSGxslF5fcn/nr+vIy8uwiDk3FnA9kaOWJfpktxWLdCIchjhc/3DrMc1xLswCkRM59wRtkWxvKq17hyhaXC8zgZ8c+pFqR7GEGV6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1643128949607423.81333229985773; Tue, 25 Jan 2022 08:42:29 -0800 (PST) Received: from localhost ([::1]:35794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCOtn-0003UR-Tx for importer@patchew.org; Tue, 25 Jan 2022 11:42:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <32iXwYQcKCvsyhqwxuhjrrjoh.frpthpx-ghyhoqrqjqx.ruj@flex--venture.bounces.google.com>) id 1nCOpF-0000Tn-3C for qemu-devel@nongnu.org; Tue, 25 Jan 2022 11:37:45 -0500 Received: from [2607:f8b0:4864:20::249] (port=41658 helo=mail-oi1-x249.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <32iXwYQcKCvsyhqwxuhjrrjoh.frpthpx-ghyhoqrqjqx.ruj@flex--venture.bounces.google.com>) id 1nCOpD-0007Ms-81 for qemu-devel@nongnu.org; Tue, 25 Jan 2022 11:37:44 -0500 Received: by mail-oi1-x249.google.com with SMTP id o11-20020a0568080f8b00b002cd0d1c3638so4483588oiw.8 for ; Tue, 25 Jan 2022 08:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=MvqqKgm51a9RkxXNdoE2SHc7RqqOkz+eRk/Pc/Vjr+I=; b=c9BECqagQTxzI8bxd1w8PFZk09OLu+WDEn5RhuX08RRDdTyWYLwAcsXVywI2A3PaHh BIEAbq5Jkzk2//7dUxFqrpIklwyav0IWWPGM17keZ1Er/UnI2lygT/MmnUnNIoD4n7pw IWe7q09ZizLj9xKWaZQhBmq0jMcVA6kW0D4rCFVazCldyfElQ5FUg21pEkQ8fcDImaKh 1iKHJjDpQ43c3aORML4zEfbx8zjB5pRDu7MRsx8gW6qW3iOZ1SwC3iEI/7aYVXRRsJ66 E+BWsKsDcPNYn0SQtn/CRzrjmEVNAgTYUR/V4/0/OXFXKkbkoWtlfvUDHLYjBbXI71yy r7wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=MvqqKgm51a9RkxXNdoE2SHc7RqqOkz+eRk/Pc/Vjr+I=; b=ERki64hOwiUpZYElrTmtDXSi25aYRO33igfZCY/oB8ihno1SijEnngNbAonj5aqbQU /eWT0rGA5y0srgES/5Y3POQYc9JUxBUGzA+wtaxHSgycEf9eK5LrQcAD6Js5px9mQg7H YYA8jusyTx/wj1PeNRI3+P47WA5Y0Iq6CS/blmocx/NOaGRJuC5O5w7Sja1kqE8guyvC LFFaAEHNgF0kklcFBJq4J/YzzyWP6dMv9zZtnzcR4mFrhabFu+DdHZhGobCrDExEn1z+ 7I7qj7/NEcpx2IHlQSfpNjEjRe0o+zJdzRU4me7ihWaKneHNVO2LcKsebI4gkW9l9/V+ G7eg== X-Gm-Message-State: AOAM5306xfDxoAR0IWyczj21zOUEjoZsH/OV6GGFD9VPGK6+Bt3p5taB 3ypLlx9MWaBNpWZ0112+NF4Vgomg08U5 X-Google-Smtp-Source: ABdhPJxXqGpBkKAXrRbepJFA7tUSrM/2E1hI+CQHgMGJghs9ycnmpB/BIfTPxewgxWMglldcXAVJ1lNnmW6E X-Received: from venture.svl.corp.google.com ([2620:15c:2a3:200:f1c8:fddb:d88f:ccec]) (user=venture job=sendgmr) by 2002:a25:a463:: with SMTP id f90mr32259455ybi.52.1643128282019; Tue, 25 Jan 2022 08:31:22 -0800 (PST) Date: Tue, 25 Jan 2022 08:31:18 -0800 Message-Id: <20220125163118.1011809-1-venture@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog Subject: [PATCH v3] hw/smbios: Add table 4 parameter, "processor-id" From: Patrick Venture To: mst@redhat.com, imammedo@redhat.com, ani@anisinha.ca Cc: qemu-devel@nongnu.org, Patrick Venture , Peter Foley , Titus Rwantare X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::249 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::249; envelope-from=32iXwYQcKCvsyhqwxuhjrrjoh.frpthpx-ghyhoqrqjqx.ruj@flex--venture.bounces.google.com; helo=mail-oi1-x249.google.com X-Spam_score_int: -87 X-Spam_score: -8.8 X-Spam_bar: -------- X-Spam_report: (-8.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1643128952863100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This parameter is to be used in the processor_id entry in the type 4 table. This parameter is set as optional and if left will use the values from the CPU model. This enables hiding the host information from the guest and allowing AMD VMs to run pretending to be Intel for some userspace software concerns. Reviewed-by: Peter Foley Reviewed-by: Titus Rwantare Signed-off-by: Patrick Venture Reviewed-by: Igor Mammedov --- v3: updated commit message to match v2 v2: Added to SRST options list, upgraded to full 64-bit value. --- hw/smbios/smbios.c | 19 ++++++++++++++++--- qemu-options.hx | 3 ++- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 7397e56737..385b69b0c9 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -104,9 +104,11 @@ static struct { const char *sock_pfx, *manufacturer, *version, *serial, *asset, *part; uint64_t max_speed; uint64_t current_speed; + uint64_t processor_id; } type4 =3D { .max_speed =3D DEFAULT_CPU_SPEED, - .current_speed =3D DEFAULT_CPU_SPEED + .current_speed =3D DEFAULT_CPU_SPEED, + .processor_id =3D 0, }; =20 static struct { @@ -327,6 +329,10 @@ static const QemuOptDesc qemu_smbios_type4_opts[] =3D { .name =3D "part", .type =3D QEMU_OPT_STRING, .help =3D "part number", + }, { + .name =3D "processor-id", + .type =3D QEMU_OPT_NUMBER, + .help =3D "processor id", }, { /* end of list */ } }; @@ -669,8 +675,13 @@ static void smbios_build_type_4_table(MachineState *ms= , unsigned instance) t->processor_type =3D 0x03; /* CPU */ t->processor_family =3D 0x01; /* Other */ SMBIOS_TABLE_SET_STR(4, processor_manufacturer_str, type4.manufacturer= ); - t->processor_id[0] =3D cpu_to_le32(smbios_cpuid_version); - t->processor_id[1] =3D cpu_to_le32(smbios_cpuid_features); + if (type4.processor_id =3D=3D 0) { + t->processor_id[0] =3D cpu_to_le32(smbios_cpuid_version); + t->processor_id[1] =3D cpu_to_le32(smbios_cpuid_features); + } else { + t->processor_id[0] =3D cpu_to_le32((uint32_t)type4.processor_id); + t->processor_id[1] =3D cpu_to_le32(type4.processor_id >> 32); + } SMBIOS_TABLE_SET_STR(4, processor_version_str, type4.version); t->voltage =3D 0; t->external_clock =3D cpu_to_le16(0); /* Unknown */ @@ -1292,6 +1303,8 @@ void smbios_entry_add(QemuOpts *opts, Error **errp) save_opt(&type4.serial, opts, "serial"); save_opt(&type4.asset, opts, "asset"); save_opt(&type4.part, opts, "part"); + /* If the value is 0, it will take the value from the CPU mode= l. */ + type4.processor_id =3D qemu_opt_get_number(opts, "processor-id= ", 0); type4.max_speed =3D qemu_opt_get_number(opts, "max-speed", DEFAULT_CPU_SPEED); type4.current_speed =3D qemu_opt_get_number(opts, "current-spe= ed", diff --git a/qemu-options.hx b/qemu-options.hx index ec90505d84..6256417935 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2527,6 +2527,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, " specify SMBIOS type 3 fields\n" "-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Dstr= ][,serial=3Dstr]\n" " [,asset=3Dstr][,part=3Dstr][,max-speed=3D%d][,current-s= peed=3D%d]\n" + " [,processor-id=3D%d]\n" " specify SMBIOS type 4 fields\n" "-smbios type=3D11[,value=3Dstr][,path=3Dfilename]\n" " specify SMBIOS type 11 fields\n" @@ -2552,7 +2553,7 @@ SRST ``-smbios type=3D3[,manufacturer=3Dstr][,version=3Dstr][,serial=3Dstr][,as= set=3Dstr][,sku=3Dstr]`` Specify SMBIOS type 3 fields =20 -``-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Dstr][,= serial=3Dstr][,asset=3Dstr][,part=3Dstr]`` +``-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Dstr][,= serial=3Dstr][,asset=3Dstr][,part=3Dstr][,processor-id=3D%d]`` Specify SMBIOS type 4 fields =20 ``-smbios type=3D11[,value=3Dstr][,path=3Dfilename]`` --=20 2.35.0.rc0.227.g00780c9af4-goog