From nobody Mon Feb 9 23:03:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164251067692915.68896157457607; Tue, 18 Jan 2022 04:57:56 -0800 (PST) Received: from localhost ([::1]:60488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9o3f-0002hr-40 for importer@patchew.org; Tue, 18 Jan 2022 07:57:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbc-0004Yi-UW; Tue, 18 Jan 2022 07:28:57 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:37711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nba-0001uZ-OW; Tue, 18 Jan 2022 07:28:56 -0500 Received: from quad ([82.142.13.186]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MQy0N-1mvHQj1fVv-00NyCU; Tue, 18 Jan 2022 13:28:50 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 2/9] hw/scsi/megasas: Simplify using the ldst API Date: Tue, 18 Jan 2022 13:28:40 +0100 Message-Id: <20220118122847.636461-3-laurent@vivier.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118122847.636461-1-laurent@vivier.eu> References: <20220118122847.636461-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kA5fMoXBa0wB00HzZofVdfTi95TE04Gb1A9HDOUdB+QwUMk041L 6vcjl53WEmxp0F7uvkffuL+guM2LpNAfmF07WIDXOMMWCA5nZQ6+8eN0Mx1Tf7Q0g5LZ4Oz +PUCKlBuRq/FIX64LGMOIxxq+Dr6WyucEdqUNYS4HhrlZOtWwzC9wWXSj2QLTtq+dFzPKSW UMbgHwjafKi96atA8J3Vw== X-UI-Out-Filterresults: notjunk:1;V03:K0:iUAunBZy8rg=:kvDIGkbx3hSWv05mOfGb8v GGWlCnB1vBNjQx8vsUjDX6x7sRxltLyMY7xj3KkWccjLKdYtDGXJQeDkmrtpCCngmbj3ajgGT KvoOT9PN3I74jJALA+gV8lc47Td9/Nya5B9UxQITCP6zOAfy9TD99uiA8CBQMCk6dmD0BJLuO dyGqB8qkWFKCoEPIezvJCMBeuSAk7j1O0tuWNaUPzsxfB7Pmo8rP4copQoArur5uSXUtSptKr dtGY4tgduX+L2DD6VHaJguy21AWRrKjGKQPCF6BlQKfuIEs9tWreVOulF9e6L9+iUOUjkFVEf XpVw/vl66uuA36cvterlJqL/3UzPt7UYpCfOE5LKZaQZXxl6Rf5ovEwsW8sH/yBPBVkUy5ysM 6kZ15+IYnCOEPrgWiX9+QmevyRi8WdQIbd/XHfeatTMIny1lQgIb50xciGar8GSgi8GQl5vsD UutNvnwek2T//gmJbTP6B9GC/QPCafri6NNnLU3jFQgv7M3WBpwifJZ/83AsMH+tGCu3xUlxf SO1MK4MCheyuqOSTpFLErnikuoz0v1DtTLpmIz3iuyyy5hvA8a9w2NhotzugYNlspdnku1cUn 7dlkVEiURD+yXRv2lVh54QsFW4sEZkKnBZIGkxUbdbhOka6Los+KvbIJwkzpFE1iOWThNvI6U 0oIZug3TkaPtmesCJdF3aWcdQ9USQBuH0Xnuasf+5efobhfokwSAHGicEX2ZqVKZSCco= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1642510678823100001 From: Philippe Mathieu-Daud=C3=A9 This code is easier to review using the load/store API. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211218111912.1499377-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/scsi/megasas.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index dc9bbdb740e7..83c321ec208a 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -383,8 +383,7 @@ static int megasas_setup_inquiry(uint8_t *cdb, int pg, = int len) cdb[1] =3D 0x1; cdb[2] =3D pg; } - cdb[3] =3D (len >> 8) & 0xff; - cdb[4] =3D (len & 0xff); + stw_be_p(&cdb[3], len); return len; } =20 @@ -400,18 +399,8 @@ static void megasas_encode_lba(uint8_t *cdb, uint64_t = lba, } else { cdb[0] =3D READ_16; } - cdb[2] =3D (lba >> 56) & 0xff; - cdb[3] =3D (lba >> 48) & 0xff; - cdb[4] =3D (lba >> 40) & 0xff; - cdb[5] =3D (lba >> 32) & 0xff; - cdb[6] =3D (lba >> 24) & 0xff; - cdb[7] =3D (lba >> 16) & 0xff; - cdb[8] =3D (lba >> 8) & 0xff; - cdb[9] =3D (lba) & 0xff; - cdb[10] =3D (len >> 24) & 0xff; - cdb[11] =3D (len >> 16) & 0xff; - cdb[12] =3D (len >> 8) & 0xff; - cdb[13] =3D (len) & 0xff; + stq_be_p(&cdb[2], lba); + stl_be_p(&cdb[2 + 8], len); } =20 /* --=20 2.34.1